Re: [patch] vmwgfx: information leak in vmw_execbuf_copy_fence_user()

On Tue, Oct 18, 2011 at 09:10 +0300, Dan Carpenter wrote: > If ret is non-zero then we don't initialize the struct which leaks > stack information to user space. > > Signed-off-by: Dan Carpenter Reviewed-by: Vasiliy Kulikov > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ex

[patch] vmwgfx: information leak in vmw_execbuf_copy_fence_user()

On Tue, Oct 18, 2011 at 09:10 +0300, Dan Carpenter wrote: > If ret is non-zero then we don't initialize the struct which leaks > stack information to user space. > > Signed-off-by: Dan Carpenter Reviewed-by: Vasiliy Kulikov > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ex

[PATCH] drm: radeon: fix error value sign

enable_vblank implementations should use negative result to indicate error. radeon_enable_vblank() returns EINVAL in this case. Change this to -EINVAL. Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/gpu/drm/radeon/radeon_irq.c |4 ++-- 1 files changed, 2 insertions(+), 2

[PATCH] drm: radeon: fix error value sign

enable_vblank implementations should use negative result to indicate error. radeon_enable_vblank() returns EINVAL in this case. Change this to -EINVAL. Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/gpu/drm/radeon/radeon_irq.c |4 ++-- 1 files changed, 2 insertions(+), 2

[PATCH] gpu: drm: vmwgfx: fix information leak to userland

Structure drm_vmw_fence_rep is copied to userland with field "pad64" uninitialized. It leads to leaking of contents of kernel stack memory. Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH] gpu: drm: vmwgfx: fix information leak to userland

Structure drm_vmw_fence_rep is copied to userland with field "pad64" uninitialized. It leads to leaking of contents of kernel stack memory. Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c |1 + 1 files changed, 1 insertions(+), 0