> +{
> + ssize_t err;
> +
> + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_EXIT_IDLE_MODE, NULL, 0);
> + if (err < 0)
> + return err;
> +
> + return 0;
For this one also: return mipi_dsi_dcs_write(dsi, MIPI_DCS_EXIT_IDLE_MODE,
NULL, 0);
--
Varka Bhadram.
obe and remove code to directly return from
> pwmchip_add/remove
>
> drivers/pwm/Kconfig | 7 +++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-crc.c | 143
> ++
> 3 files changed, 151 insertions(+)
> create mode 100644 drivers/pwm/pwm-crc.c
Reviewed-by: Varka Bhadram
--
Best regards,
Varka Bhadram.
On 06/22/2015 05:27 PM, Inki Dae wrote:
> On 2015ë
06ì 22ì¼ 20:41, Varka Bhadram wrote:
>
(..)
> +platform_set_drvdata(pdev, ctx);
>> You are setting the driver data as ctx..
>>
>> But no where you are using it...?
>>
>> Am i missing anyth
er, 0,
> + "drm_decon", ctx);
> + if (ret < 0) {
> + dev_err(dev, "lcd_sys irq request failed\n");
> + return ret;
> + }
> +
> + platform_set_drvdata(pdev, ctx);
You are setting the driver data as ctx..
But no where you are using it...?
Am i missing anything ?
--
Best regards,
Varka Bhadram.
driver removed\n");
This debug message may not be required :-)
you can directly do:
return pwmchip_remove(&pwm->chip);
> +
> + return 0;
> +}
> +
> +static struct platform_driver crystalcove_pwm_driver = {
> + .probe = crystalcove_pwm_probe,
> + .remove = crystalcove_pwm_remove,
> + .driver = {
> + .name = "crystal_cove_pwm",
> + },
> +};
> +
> +builtin_platform_driver(crystalcove_pwm_driver);
--
Best regards,
Varka Bhadram.
; Acked-by: Lee Jones
> Signed-off-by: Shobhit Kumar
> ---
Here you add this change history so that after applying this
will not be the part of your commit description.
This comment is applicable for all of your patches.
--
Best regards,
Varka Bhadram.
ver_dt_match[] = {
> + { .compatible = "samsung,exynos5433-decon" },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, exynos5433_decon_driver_dt_match);
> +
> +struct platform_driver exynos5433_decon_driver = {
> + .probe = exynos5433_decon_probe,
> + .remove = exynos5433_decon_remove,
> + .driver = {
> + .name = "exynos5433-decon",
> + .owner = THIS_MODULE,
Remove this field. It will be updated by platform core.
> + .of_match_table = exynos5433_decon_driver_dt_match,
> + },
> +};
--
Varka Bhadram
irst cell encodes the PWM id (0 is the only acceptable
value here,
because the chip only provide one PWM).
The second cell encodes the PWM period in nanoseconds.
The third cell encodes the PWM flags (the only supported flag
is
PWM_POLARITY_INVERTED)
--
Regards,
Varka Bhadram
quired properties:
- compatible : value should be one of the following:"atmel,sama5d3-hlcdc"
- reg : base address and size of the HLCDC device registers.
- clock-names : the name of the 3 clocks requested by the HLCDC device.
Should contain "periph_clk", "sys_clk" and "slow_clk".
- clocks : should contain the 3 clocks requested by the HLCDC device.
..
--
Regards,
Varka Bhadram
On 07/22/2014 05:23 PM, YoungJun Cho wrote:
> Hi Varka,
>
> On 07/22/2014 08:14 PM, Varka Bhadram wrote:
>> On 07/22/2014 04:40 PM, YoungJun Cho wrote:
>>> Hi Varka,
>>>
>>> This irq handler should be registered in attach() and unregistered in
>>
ter
> dsi is probed and not removed.
> So I don't use devm_* APIs.
You meant to say that in-case of GPIOs also you are following the same thing ..?
Means requesting the GPIOs and Releasing several times ..?
>
>>
>
--
Regards,
Varka Bhadram.
* called by drm_panel_init() before panel is attached.
> + */
> + ret = request_threaded_irq(gpio_to_irq(dsi->te_gpio),
> + exynos_dsi_te_irq_handler, NULL,
> + IRQF_TRIGGER_RISING, "TE", dsi);
why don't we use devm_request_threaded_irq()..?
--
Regards,
Varka Bhadram.
12 matches
Mail list logo
