[PATCH] drm/amdkfd: avoid CONFIG_ prefix for non-Kconfig symbols

2015-06-05 Thread Valentin Rothberg
static analysis tools happy. Signed-off-by: Valentin Rothberg --- drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c | 10 +- drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Valentin Rothberg
Hi Christian, On Thu, Jun 4, 2015 at 6:47 PM, Christian König wrote: > On 04.06.2015 17:09, Alex Deucher wrote: >> >> On Thu, Jun 4, 2015 at 10:04 AM, Valentin Rothberg >> wrote: >>> >>> Hi Alex, >>> >>> On Thu, Jun 4, 2015 at 4:01 PM,

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Valentin Rothberg
x > >> >> Oded >> >> On Thu, Jun 4, 2015 at 4:45 PM Valentin Rothberg >> wrote: >>> >>> Hi Yair, >>> >>> your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger >>> module support") has shown up i

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Valentin Rothberg
ree other symbols SH_REG_{BASE,SIZE,END}, I would rename CONFIG_ to CONF_ to avoid mix-ups. Kind regards, Valentin > Oded > > On Thu, Jun 4, 2015 at 4:45 PM Valentin Rothberg > wrote: >> >> Hi Yair, >> >> your commit fbeb661bfa89 ("drm/amdkfd: Add skeleto

drm/amdkfd: bad CONFIG_ prefix for enum entries

2015-06-04 Thread Valentin Rothberg
Hi Yair, your commit fbeb661bfa89 ("drm/amdkfd: Add skeleton H/W debugger module support") has shown up in today's linux-next tree (i.e., next-20150604). The commit adds the following lines of code to drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.h: +/* CONFIG reg space definition */ +enum { + CON

drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-10 Thread Valentin Rothberg
On Thu, Apr 09, 2015 at 04:20:45PM -0400, Rob Clark wrote: > On Thu, Apr 9, 2015 at 3:44 PM, Valentin Rothberg > wrote: > > On Thu, Apr 09, 2015 at 02:54:29PM -0400, Rob Clark wrote: > >> On Thu, Apr 9, 2015 at 2:12 PM, Paul Bolle wrote: > >> > On Thu, 2015-04

drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Valentin Rothberg
On Thu, Apr 09, 2015 at 02:54:29PM -0400, Rob Clark wrote: > On Thu, Apr 9, 2015 at 2:12 PM, Paul Bolle wrote: > > On Thu, 2015-04-09 at 19:07 +0200, Greg KH wrote: > >> I really don't understand. Why is this code in the kernel tree if it > >> can't be built? How does anyone use this? By taking

drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING

2015-04-09 Thread Valentin Rothberg
Hi Hai, your commit d5af49c92a8a ("drm/msm/mdp5: Enable DSI connector in msm drm driver") in today's Linux next tree adds an #ifdef with CONFIG_MSM_BUS_SCALING as condition. MSM_BUS_SCALING is not defined in Kconfig, so the code in this #ifdef block won't be compiled at its current state. I saw