RE: [PATCH v4 01/11] mtd: core: always create master device

2025-01-18 Thread Usyskin, Alexander
> >> > This streamlines device tree and allows to anchor > >> > runtime power management on master device in all cases. > >> > >> Please explain in more detail why this is needed. > >> If this change makes the overall situation better and breaks > >> no userspace, I'm happy. :-) > >> > > > > The re

RE: [PATCH v4 01/11] mtd: core: always create master device

2025-01-15 Thread Usyskin, Alexander
> > Create master device without partition when > > CONFIG_MTD_PARTITIONED_MASTER flag is unset. > > > > This streamlines device tree and allows to anchor > > runtime power management on master device in all cases. > > Please explain in more detail why this is needed. > If this change makes the ov

RE: [PATCH v4 01/11] mtd: core: always create master device

2025-01-14 Thread Usyskin, Alexander
> > > Create master device without partition when > > > CONFIG_MTD_PARTITIONED_MASTER flag is unset. > > > > I don't think you took into consideration my remarks regarding the fact > > that you would break userspace. If you enable the master, you no longer > > have the same device numbering in user

RE: [PATCH v4 01/11] mtd: core: always create master device

2025-01-06 Thread Usyskin, Alexander
> Subject: Re: [PATCH v4 01/11] mtd: core: always create master device > > Hi Alexander, > > On 01/01/2025 at 17:39:15 +02, Alexander Usyskin > wrote: > > > Create master device without partition when > > CONFIG_MTD_PARTITIONED_MASTER flag is unset. > > I don't think you took into consideratio

RE: [PATCH v4 06/11] mtd: intel-dg: align 64bit read and write

2025-01-02 Thread Usyskin, Alexander
> > GSC NVM controller HW errors on quad access overlapping 1K border. > > Align 64bit read and write to avoid readq/writeq over 1K border. > > > > Acked-by: Miquel Raynal > > Signed-off-by: Alexander Usyskin > > --- > > drivers/mtd/devices/mtd-intel-dg.c | 35 > ++ >

RE: [PATCH v4 02/11] mtd: add driver for intel graphics non-volatile memory device

2025-01-02 Thread Usyskin, Alexander
> ... > > > +struct intel_dg_nvm { > > + struct kref refcnt; > > + void __iomem *base; > > + size_t size; > > + unsigned int nregions; > > + struct { > > + const char *name; > > + u8 id; > > + u64 offset; > > + u64 size; > > + } regions[]; > > _

RE: [PATCH v4 03/11] mtd: intel-dg: implement region enumeration

2025-01-02 Thread Usyskin, Alexander
> > > @@ -89,6 +281,13 @@ static int intel_dg_mtd_probe(struct > auxiliary_device *aux_dev, > > goto err; > > } > > > > + ret = intel_dg_nvm_init(nvm, device); > > + if (ret < 0) { > > + dev_err(device, "cannot initialize nvm\n"); > > + ret = -ENODEV; > > W

RE: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

2025-01-01 Thread Usyskin, Alexander
> >> > >> >> If so, I have to add patch for mtd subsystem to always have device for > >> master > >> >> initialized regardless of kernel flag. > >> >> Only to initialize struct device, not to create full mtd node. > >> >> > >> >> Miquel - are you agree to this? > >> > >> Conceptually yes, but pleas

RE: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

2024-12-29 Thread Usyskin, Alexander
> > Hello Alexander, > > >> If so, I have to add patch for mtd subsystem to always have device for > master > >> initialized regardless of kernel flag. > >> Only to initialize struct device, not to create full mtd node. > >> > >> Miquel - are you agree to this? > > Conceptually yes, but please m

RE: [PATCH v3 03/10] mtd: intel-dg: implement access functions

2024-12-19 Thread Usyskin, Alexander
> > + > > +static ssize_t idg_nvm_rewrite_partial(struct intel_dg_nvm *nvm, loff_t to, > > + loff_t offset, size_t len, const u32 > *newdata) > > +{ > > + u32 data = idg_nvm_read32(nvm, to); > > + > > + if (idg_nvm_error(nvm)) > > + return -EIO; > > +

RE: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

2024-12-18 Thread Usyskin, Alexander
> > >> @@ -474,20 +478,28 @@ static int intel_dg_mtd_erase(struct mtd_info > > *mtd, struct erase_info *info) > > >> total_len = info->len; > > >> addr = info->addr; > > >> > > >> +ret = pm_runtime_resume_and_get(mtd->dev.parent); > > > on this, I really don't believe this

RE: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

2024-12-17 Thread Usyskin, Alexander
> >> @@ -474,20 +478,28 @@ static int intel_dg_mtd_erase(struct mtd_info > *mtd, struct erase_info *info) > >>total_len = info->len; > >>addr = info->addr; > >> > >> + ret = pm_runtime_resume_and_get(mtd->dev.parent); > > on this, I really don't believe this is right and we should use > >

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-12-11 Thread Usyskin, Alexander
Adding Kartihik > Subject: Re: [PATCH 06/10] mtd: intel-dg: wake card on operations > > Hi Alexander, > > Please reduce the context when answering, otherwise it's hard to find > all places where you commented. > > >> > > > That's the part that I'm not sure if I agree. if I remember from some >

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-11-11 Thread Usyskin, Alexander
> -Original Message- > From: Usyskin, Alexander > Sent: Sunday, November 10, 2024 3:17 PM > To: Vivi, Rodrigo > Cc: Gupta, Anshuman ; Deak, Imre > ; Miquel Raynal ; > Richard Weinberger ; Vignesh Raghavendra > ; De Marchi, Lucas ; Thomas > Hellström ; Maarten

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-11-10 Thread Usyskin, Alexander
> -Original Message- > From: Vivi, Rodrigo > Sent: Friday, November 8, 2024 12:50 AM > To: Usyskin, Alexander > Cc: Gupta, Anshuman ; Deak, Imre > ; Miquel Raynal ; > Richard Weinberger ; Vignesh Raghavendra > ; De Marchi, Lucas ; Thomas > Hellström ; Maarten

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-11-05 Thread Usyskin, Alexander
> -Original Message- > From: Vivi, Rodrigo > Sent: Monday, November 4, 2024 11:16 PM > To: Usyskin, Alexander > Cc: Gupta, Anshuman ; Deak, Imre > ; Miquel Raynal ; > Richard Weinberger ; Vignesh Raghavendra > ; De Marchi, Lucas ; Thomas > Hellström ; Maarten

RE: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-10-29 Thread Usyskin, Alexander
> -Original Message- > From: Gupta, Anshuman > Sent: Monday, October 28, 2024 5:02 PM > To: Vivi, Rodrigo ; Usyskin, Alexander > ; Deak, Imre > Cc: Miquel Raynal ; Richard Weinberger > ; Vignesh Raghavendra ; De Marchi, > Lucas ; Thomas Hellström > ; Maarten

RE: [PATCH v6 01/12] spi: add driver for intel graphics on-die spi device

2024-09-25 Thread Usyskin, Alexander
> On Sat, Sep 21, 2024 at 01:00:52PM +, Winkler, Tomas wrote: > > > On Thu, Sep 19, 2024 at 09:54:24AM +, Winkler, Tomas wrote: > > > > > On Mon, Sep 16, 2024 at 04:49:17PM +0300, Alexander Usyskin > wrote: > > > > Just do normal open coded allocations, the reference counting is just > > >

RE: [PATCH v6 08/12] drm/i915/spi: add spi device for discrete graphics

2024-09-23 Thread Usyskin, Alexander
> Subject: Re: [PATCH v6 08/12] drm/i915/spi: add spi device for discrete > graphics > > On Mon, 16 Sep 2024, Alexander Usyskin > wrote: > > diff --git a/drivers/gpu/drm/i915/i915_drv.h > b/drivers/gpu/drm/i915/i915_drv.h > > index 39f6614a0a99..b9d4f9be5355 100644 > > --- a/drivers/gpu/drm/i915/

RE: [PATCH v6 00/12] spi: add driver for Intel discrete graphics

2024-09-18 Thread Usyskin, Alexander
> On Mon, Sep 16, 2024 at 04:49:16PM +0300, Alexander Usyskin wrote: > > Add driver for access to Intel discrete graphics card > > internal SPI device. > > Expose device on auxiliary bus by i915 and Xe drivers and > > provide spi driver to register this device with MTD framework. > > As far as I c

RE: [Intel-gfx] [PATCH v5 2/6] drm/i915/pxp: add device link between i915 and mei_pxp

2023-01-21 Thread Usyskin, Alexander
> > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > index d50354bfb993..bef6d7f8ac55 100644 > > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > @@ -127,6 +127,10 @@ static int i915_pxp_tee_c

RE: [Intel-gfx] [PATCH v3 11/40] misc/mei/hdcp: Store the HDCP Pairing info

2018-05-16 Thread Usyskin, Alexander
l.com; Winkler, Tomas ; > Usyskin, Alexander > Cc: Vivi, Rodrigo > Subject: Re: [Intel-gfx] [PATCH v3 11/40] misc/mei/hdcp: Store the HDCP > Pairing info > > > > On Wednesday 09 May 2018 03:58 PM, Shankar, Uma wrote: > > > >> -Origi

RE: [PATCH v3 08/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2018-05-16 Thread Usyskin, Alexander
> -Original Message- > From: C, Ramalingam > Sent: Wednesday, May 16, 2018 18:20 > To: Usyskin, Alexander ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > seanp...@chromium.org; dan...@ffwll.ch; ch...@chris-wilson.co.uk; > jani.nik...@lin

RE: [PATCH v3 05/40] misc/mei/hdcp: Notifier chain for mei cldev state change

2018-05-16 Thread Usyskin, Alexander
> -Original Message- > From: C, Ramalingam > Sent: Wednesday, May 16, 2018 16:05 > To: Usyskin, Alexander ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > seanp...@chromium.org; dan...@ffwll.ch; ch...@chris-wilson.co.uk; > jani.nik...@lin

RE: [PATCH v3 08/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2018-04-03 Thread Usyskin, Alexander
> -Original Message- > From: C, Ramalingam > Sent: Tuesday, April 03, 2018 16:57 > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > seanp...@chromium.org; dan...@ffwll.ch; ch...@chris-wilson.co.uk; > jani.nik...@linux.intel.com; Winkler,

RE: [PATCH v3 05/40] misc/mei/hdcp: Notifier chain for mei cldev state change

2018-04-03 Thread Usyskin, Alexander
> -Original Message- > From: C, Ramalingam > Sent: Tuesday, April 03, 2018 16:57 > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > seanp...@chromium.org; dan...@ffwll.ch; ch...@chris-wilson.co.uk; > jani.nik...@linux.intel.com; Winkler, Tomas ; &g