[BUG] drm/amd/display: possible null-pointer dereference or redundant null check in amdgpu_dm.c

goto error; //2009 } //2010 .. register_dmub_notify_callback(..., dmub_aux_setconfig_callback, ...) //2019 I am not sure if adev->dm.dmub_notify is assigned with NULL elsewhere. If not, the if check at Line 734 can be redundant. Any feedback would be appreciated, thanks! Sincerely, Tuo Li

Re: [PATCH] drm/exynos: fix a possible null-pointer dereference due to data race in exynos_drm_crtc_atomic_disable()

Hello, Thanks for your reply! The report is publicly available at https://sites.google.com/view/basscheck/home. And this patch is from the 8th report on this website. Thanks, Tuo Li On Sat, Jul 1, 2023 at 4:01 PM Krzysztof Kozlowski < krzysztof.kozlow...@linaro.org> wrote: > On 30/0

[PATCH] drm/exynos: fix a possible null-pointer dereference due to data race in exynos_drm_crtc_atomic_disable()

by data race, the spin lock coverage is extended to protect the if statement as well as the function call to drm_crtc_send_vblank_event(). Reported-by: BassCheck Signed-off-by: Tuo Li --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletion

[PATCH] gpu: drm: amd: amdgpu: amdgpu_i2c: fix possible uninitialized-variable access in amdgpu_i2c_router_select_ddc_port()

nitialized, but it is accessed in: val &= ~amdgpu_connector->router.ddc_mux_control_pin; To fix this possible uninitialized-variable access, initialize val to 0 in amdgpu_i2c_router_select_ddc_port(). Reported-by: TOTE Robot Signed-off-by: Tuo Li --- drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH] drm/display: fix possible null-pointer dereference in dcn10_set_clock()

Thanks for your feedback. We will prepare a V2 patch according to your advice. Best wishes, Tuo Li On 2021/8/10 21:38, Chen, Guchun wrote: [Public] Thanks for your patch. I suggest moving the check of function pointer dc->clk_mgr->funcs->get_clock earlier, and return early if it&#

[BUG] drm/amdgpu: possible null-pointer dereference in dce_vXX_0_afmt_setmode()

E Robot Best wishes, Tuo Li

[PATCH] drm/display: fix possible null-pointer dereference in dcn10_set_clock()

dc->clk_mgr before dereferencing it. Reported-by: TOTE Robot Signed-off-by: Tuo Li --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/displ

[PATCH] drm/amd/display/dc/dce112/dce112_resource: Drop redundant null-pointer check in bw_calcs_data_update_from_pplib()

The variable dc->bw_vbios is guaranteed to be not NULL by its callers. Thus the null-pointer check can be dropped. Reported-by: TOTE Robot Signed-off-by: Tuo Li --- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH] drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate()

The varialbe gtt in the function amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context. Thus the null-pointer checks are redundant and can be dropped. Reported-by: TOTE Robot Signed-off-by: Tuo Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4

[PATCH] drm/amdgpu: fix possible null-pointer dereference in amdgpu_ttm_tt_unpopulate()

dereferences will occur in the function ttm_pool_free() which is called in: return ttm_pool_free(&adev->mman.bdev.pool, ttm); To fix these possible null-pointer dereferences, the function returns when ttm is NULL. Reported-by: TOTE Robot Signed-off-by: Tuo Li --- drivers/gpu/drm/am

[PATCH] drm/amdgpu: fix possible null-pointer dereference in amdgpu_ttm_tt_populate()

dereferences will occur in the function ttm_pool_alloc() which is called in: return ttm_pool_alloc(&adev->mman.bdev.pool, ttm, ctx); To fix these possible null-pointer dereferences, the function returns -EINVAL when ttm is NULL. Reported-by: TOTE Robot Signed-off-by: Tuo Li --- d

[PATCH] scsi: csiostor: fix possible null-pointer dereference in csio_eh_lun_reset_handler()

the function returns FAILED directly if rn is NULL. Reported-by: TOTE Robot Signed-off-by: Tuo Li --- drivers/scsi/csiostor/csio_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c index 56b9ad0a1