Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-07-11 Thread Tomasz Figa
On Thu, Jun 20, 2024 at 3:52 PM Hans Verkuil wrote: > > On 19/06/2024 06:19, Tomasz Figa wrote: > > On Wed, Jun 19, 2024 at 1:24 AM Nicolas Dufresne > > wrote: > >> > >> Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : > >>> Hi TaoJi

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Tomasz Figa
On Wed, Jun 19, 2024 at 1:24 AM Nicolas Dufresne wrote: > > Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : > > Hi TaoJiang, > > > > On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > > > > > From: Ming Qian > > > > > >

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Tomasz Figa
Hi TaoJiang, On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > From: Ming Qian > > When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know > whether the dma buffer is coherent or synchronized. > > The videobuf2-core will skip cache syncs as it think the DMA exporter > should take

Re: [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-06-17 Thread Tomasz Figa
On Mon, Jun 17, 2024 at 3:53 PM Yong Wu (吴勇) wrote: > > On Wed, 2024-06-12 at 14:22 +0900, Tomasz Figa wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Thu, May 16, 2024 at

Re: [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-06-11 Thread Tomasz Figa
On Thu, May 16, 2024 at 08:20:50PM +0800, Yunfei Dong wrote: > Need to call dma heap interface to allocate/free secure memory when playing > secure video. > > Signed-off-by: Yunfei Dong > --- > .../media/platform/mediatek/vcodec/Kconfig| 1 + > .../mediatek/vcodec/common/mtk_vcodec_util.c

Re: [PATCH v6,04/24] v4l: add documentation for restricted memory flag

2024-06-11 Thread Tomasz Figa
On Wed, May 22, 2024 at 02:16:22PM +0300, Laurent Pinchart wrote: > Hi Jefrey, > > Thank you for the patch. > > On Thu, May 16, 2024 at 08:20:42PM +0800, Yunfei Dong wrote: > > From: Jeffrey Kardatzke > > > > Adds documentation for V4L2_MEMORY_FLAG_RESTRICTED. > > > > Signed-off-by: Jeffrey Ka

Re: [PATCH v6,03/24] v4l2: verify restricted dmabufs are used in restricted queue

2024-06-11 Thread Tomasz Figa
On Thu, May 16, 2024 at 08:20:41PM +0800, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Verfies in the dmabuf implementations that if the restricted memory > flag is set for a queue that the dmabuf submitted to the queue is > unmappable. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by:

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-23 Thread Tomasz Figa
On Wed, Aug 23, 2023 at 4:11 PM Hsia-Jun Li wrote: > > > > On 8/23/23 12:46, Tomasz Figa wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > >

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-22 Thread Tomasz Figa
Hi Hsia-Jun, On Tue, Aug 22, 2023 at 8:14 PM Hsia-Jun Li wrote: > > Hello > > I would like to introduce a usage of SHMEM slimier to DMA-buf, the major > purpose of that is sharing metadata or just a pure container for cross > drivers. > > We need to exchange some sort of metadata between drivers,

Re: Try to address the DMA-buf coherency problem

2022-12-11 Thread Tomasz Figa
On Fri, Dec 9, 2022 at 6:32 PM Pekka Paalanen wrote: > > On Fri, 9 Dec 2022 17:26:06 +0900 > Tomasz Figa wrote: > > > On Mon, Dec 5, 2022 at 5:29 PM Christian König > > wrote: > > > > > > Hi Tomasz, > > > > > > Am 05.12.22 um 07:41

Re: Try to address the DMA-buf coherency problem

2022-12-11 Thread Tomasz Figa
On Fri, Dec 9, 2022 at 7:27 PM Christian König wrote: > > Am 09.12.22 um 09:26 schrieb Tomasz Figa: [snip] > Yes, same what Daniel said as well. We need to provide some more hints > which allocator to use from the kernel. > > >>>>>> So if a device dr

Re: Try to address the DMA-buf coherency problem

2022-12-09 Thread Tomasz Figa
On Mon, Dec 5, 2022 at 5:29 PM Christian König wrote: > > Hi Tomasz, > > Am 05.12.22 um 07:41 schrieb Tomasz Figa: > > [SNIP] > >> In other words explicit ownership transfer is not something we would > >> want as requirement in the framework, cause otherwise w

Re: Try to address the DMA-buf coherency problem

2022-12-04 Thread Tomasz Figa
Hi Christian, On Thu, Nov 17, 2022 at 9:11 PM Christian König wrote: > > Hi Tomasz, > > Am 17.11.22 um 10:35 schrieb Tomasz Figa: > > Hi Christian and everyone, > > > > On Thu, Nov 3, 2022 at 4:14 AM Christian König > > wrote: > >> Am 02.11.22 um

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-28 Thread Tomasz Figa
e read-only buffer issue has been resolved, FOLL_WRITE could > >>> again be set depending on the DMA direction. > >>> > >>> Cc: Hans Verkuil > >>> Cc: Marek Szyprowski > >>> Cc: Tomasz Figa > >>> Cc: Marek Szyprowski >

Re: Try to address the DMA-buf coherency problem

2022-11-17 Thread Tomasz Figa
Hi Christian and everyone, On Thu, Nov 3, 2022 at 4:14 AM Christian König wrote: > > Am 02.11.22 um 18:10 schrieb Lucas Stach: > > Am Mittwoch, dem 02.11.2022 um 13:21 +0100 schrieb Christian König: > > [SNIP] > >> It would just be doing this for the importer and exactly that > >> would be bad de

Re: [PATCH v1 5/6] media: videobuf2: Assert held reservation lock for dma-buf mmapping

2022-11-10 Thread Tomasz Figa
t; > Suggested-by: Daniel Vetter > Signed-off-by: Dmitry Osipenko > --- > drivers/media/common/videobuf2/videobuf2-dma-contig.c | 3 +++ > drivers/media/common/videobuf2/videobuf2-dma-sg.c | 3 +++ > drivers/media/common/videobuf2/videobuf2-vmalloc.c| 3 +++ > 3 files cha

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-07 Thread Tomasz Figa
that case, but I don't know the background behind it being added here in the first place. +Hans Verkuil +Marek Szyprowski do you happen to remember anything about it? Best regards, Tomasz > > FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove > it. > >

Re: [PATCH v3 1/9] dma-buf: Add _unlocked postfix to function names

2022-08-31 Thread Tomasz Figa
ux/dma-buf.h | 34 +---- > 21 files changed, 162 insertions(+), 153 deletions(-) > For drivers/media/videobu2: Acked-by: Tomasz Figa Best regards, Tomasz > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 1c912255c5d6..452a6a1f

Re: [PATCH] [Draft]: media: videobuf2-dma-heap: add a vendor defined memory runtine

2022-08-24 Thread Tomasz Figa
Hi Randy, Sorry for the late reply, I went on vacation last week. On Sun, Aug 7, 2022 at 12:23 AM Hsia-Jun Li wrote: > > > > On 8/5/22 18:09, Tomasz Figa wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-22 Thread Tomasz Figa
> > Le vendredi 19 août 2022 à 02:13 +0300, Laurent Pinchart a écrit : > >> On Thu, Aug 18, 2022 at 02:33:42PM +0800, Hsia-Jun Li wrote: > >>> On 8/18/22 14:06, Tomasz Figa wrote: > >>>> On Tue, Aug 9, 2022 at 1:28 AM Hsia-Jun Li > >>>> w

Re: [PATCH 1/2] drm/fourcc: Add Synaptics VideoSmart tiled modifiers

2022-08-17 Thread Tomasz Figa
Hi Randy, On Tue, Aug 9, 2022 at 1:28 AM Hsia-Jun Li wrote: > > From: "Hsia-Jun(Randy) Li" > > Memory Traffic Reduction(MTR) is a module in Synaptics > VideoSmart platform could process lossless compression image > and cache the tile memory line. > > Those modifiers only record the parameters wo

Re: [PATCH 2/2] [WIP]: media: Add Synaptics compressed tiled format

2022-08-17 Thread Tomasz Figa
Hi Randy, On Tue, Aug 9, 2022 at 1:28 AM Hsia-Jun Li wrote: > > From: "Hsia-Jun(Randy) Li" > > The most of detail has been written in the drm. > Please notice that the tiled formats here request > one more plane for storing the motion vector metadata. > This buffer won't be compressed, so you ca

Re: [PATCH] [Draft]: media: videobuf2-dma-heap: add a vendor defined memory runtine

2022-08-05 Thread Tomasz Figa
On Tue, Aug 2, 2022 at 9:21 PM ayaka wrote: > > Sorry, the previous one contains html data. > > > On Aug 2, 2022, at 3:33 PM, Tomasz Figa wrote: > > > > On Mon, Aug 1, 2022 at 8:43 PM ayaka wrote: > >> Sent from my iPad > >>>> On Aug 1, 2

Re: [PATCH] [Draft]: media: videobuf2-dma-heap: add a vendor defined memory runtine

2022-08-02 Thread Tomasz Figa
On Mon, Aug 1, 2022 at 8:43 PM ayaka wrote: > > > > Sent from my iPad > > > On Aug 1, 2022, at 5:46 PM, Tomasz Figa wrote: > > > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know t

Re: [PATCH v1 0/6] Move all drivers to a common dma-buf locking convention

2022-07-19 Thread Tomasz Figa
drivers/gpu/drm/qxl/qxl_prime.c | 4 +- > drivers/gpu/drm/tegra/gem.c | 27 +-- > drivers/infiniband/core/umem_dmabuf.c | 11 +- > .../common/videobuf2/videobuf2-dma-contig.c | 26 +-- > .../media/common/videobuf2/videobuf2-dma-sg.c | 23 +- > .../common/videobuf2/videobuf2-vmalloc.c | 17 +- For the videobuf2 changes: Acked-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Tomasz Figa
t; mmu_notifier, without breaking how this all works. The only real fix > >>>>>> is to deprecate userptr support for VM_IO | VM_PFNMAP mappings and > >>>>>> tell everyone to cut over to dma-buf memory sharing for zerocopy. > >>>>>> > >>>

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Tomasz Figa
VM_IO | VM_PFNMAP mappings and > >> tell everyone to cut over to dma-buf memory sharing for zerocopy. > >> > >> userptr for normal memory will keep working as-is, this only affects > >> the zerocopy userptr usage enabled in 50ac952d2263 ("[media] > >&g

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-11-02 Thread Tomasz Figa
On Fri, Oct 30, 2020 at 3:38 PM Daniel Vetter wrote: > > On Fri, Oct 30, 2020 at 3:11 PM Tomasz Figa wrote: > > > > On Fri, Oct 30, 2020 at 11:08 AM Daniel Vetter > > wrote: > > > > > > This is used by media/videbuf2 for persistent dma mappings, not

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-10-30 Thread Tomasz Figa
t; Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Mauro Carvalho Chehab > Cc: Andrew Morton > Cc: John Hubbard > Cc: Jérôme Glisse > Cc: Jan Kara > Cc: Dan Williams &g

Re: [PATCH v4 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-10-26 Thread Tomasz Figa
e a lot. > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Mauro Carvalho Chehab > Cc: Andrew Morton > Cc: John Hubbard > Cc: Jérôme Glisse > Cc: Jan

Re: [PATCH v4 06/15] media: videobuf2: Move frame_vector into media subsystem

2020-10-26 Thread Tomasz Figa
t; Reviewed-by: John Hubbard > Acked-by: Mauro Carvalho Chehab > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Mauro Carvalho Chehab > Cc: Andrew Morton > Cc: John Hubba

Re: [PATCH v4 09/15] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-10-26 Thread Tomasz Figa
this is a good first step towards deprecating this legacy code, so: Acked-by: Tomasz Figa Of course the last word goes to Mauro. :) Best regards, Tomasz > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Kees Cook > Cc: Dan Williams > Cc: Andrew Morton > C

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Tomasz Figa
Hi Mauro, On Fri, Oct 9, 2020 at 2:37 PM Mauro Carvalho Chehab wrote: > > Em Fri, 9 Oct 2020 09:21:11 -0300 > Jason Gunthorpe escreveu: > > > On Fri, Oct 09, 2020 at 12:34:21PM +0200, Mauro Carvalho Chehab wrote: > > > Hi, > > > > > > Em Fri, 9 Oct 2020 09:59:26 +0200 > > > Daniel Vetter escre

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Tomasz Figa
Hi Daniel, On Fri, Oct 9, 2020 at 7:52 PM Daniel Vetter wrote: > > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 02:37:23PM +0200, Mauro Carvalho Chehab wrote: > > > > > I'm not a mm/ expert, but, from what I understood from Daniel's patch > > > descriptio

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 4:23 PM Daniel Vetter wrote: > > On Wed, Oct 7, 2020 at 4:12 PM Tomasz Figa wrote: > > > > On Wed, Oct 7, 2020 at 4:09 PM Daniel Vetter wrote: > > > > > > On Wed, Oct 7, 2020 at 3:34 PM Tomasz Figa wrote: > > > > > &

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 4:09 PM Daniel Vetter wrote: > > On Wed, Oct 7, 2020 at 3:34 PM Tomasz Figa wrote: > > > > On Wed, Oct 7, 2020 at 3:06 PM Jason Gunthorpe wrote: > > > > > > On Wed, Oct 07, 2020 at 02:58:33PM +0200, Daniel Vetter wrote: > > >

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 3:06 PM Jason Gunthorpe wrote: > > On Wed, Oct 07, 2020 at 02:58:33PM +0200, Daniel Vetter wrote: > > On Wed, Oct 7, 2020 at 2:48 PM Tomasz Figa wrote: > > > > > > On Wed, Oct 7, 2020 at 2:44 PM Jason Gunthorpe wrote: > > > >

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Sat, Oct 3, 2020 at 1:31 AM Jason Gunthorpe wrote: > > On Fri, Oct 02, 2020 at 08:16:48PM +0200, Daniel Vetter wrote: > > On Fri, Oct 2, 2020 at 8:06 PM Jason Gunthorpe wrote: > > > On Fri, Oct 02, 2020 at 07:53:03PM +0200, Daniel Vetter wrote: > > > > For $reasons I've stumbled over this code

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 2:44 PM Jason Gunthorpe wrote: > > On Wed, Oct 07, 2020 at 02:33:56PM +0200, Marek Szyprowski wrote: > > Well, it was in vb2_get_vma() function, but now I see that it has been > > lost in fb639eb39154 and 6690c8c78c74 some time ago... > > There is no guarentee that holding a

Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames()

2020-10-02 Thread Tomasz Figa
Signed-off-by: Daniel Vetter > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Tomasz Figa > Cc: Andrew Morton > Cc: Oded Gabbay > Cc: O

Re: [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-25 Thread Tomasz Figa
| 6 +- > include/drm/drm_prime.h | 5 +- > include/linux/dma-buf-map.h | 193 ++++++ > include/linux/dma-buf.h | 11 +- > 18 files changed, 372 insertions(+), 94 deletions(-) > create mode 100644 include

Re: [PATCH v10 30/30] videobuf2: use sgtable-based scatterlist wrappers

2020-09-10 Thread Tomasz Figa
On Thu, Sep 10, 2020 at 11:17 AM Hans Verkuil wrote: > > On 04/09/2020 15:17, Marek Szyprowski wrote: > > Use recently introduced common wrappers operating directly on the struct > > sg_table objects and scatterlist page iterators to make the code a bit > > more compact, robust, easier to follow a

Re: [PATCH v10 30/30] videobuf2: use sgtable-based scatterlist wrappers

2020-09-07 Thread Tomasz Figa
On Mon, Sep 7, 2020 at 4:02 PM Marek Szyprowski wrote: > > Hi Tomasz, > > On 07.09.2020 15:07, Tomasz Figa wrote: > > On Fri, Sep 4, 2020 at 3:35 PM Marek Szyprowski > > wrote: > >> Use recently introduced common wrappers operating directly on the struct >

Re: [PATCH v10 30/30] videobuf2: use sgtable-based scatterlist wrappers

2020-09-07 Thread Tomasz Figa
Hi Marek, On Fri, Sep 4, 2020 at 3:35 PM Marek Szyprowski wrote: > > Use recently introduced common wrappers operating directly on the struct > sg_table objects and scatterlist page iterators to make the code a bit > more compact, robust, easier to follow and copy/paste safe. > > No functional ch

Re: [PATCH v3] drm/mediatek: check plane visibility in atomic_update

2020-06-22 Thread Tomasz Figa
changed, 15 insertions(+), 10 deletions(-) > +/- the Change-Id pointed out by Matthias: Reviewed-by: Tomasz Figa Best regards, Tomasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/mediatek: check plane visibility in atomic_update

2020-06-22 Thread Tomasz Figa
Hi Hsin-Yi, On Mon, Jun 22, 2020 at 11:01:09PM +0800, Hsin-Yi Wang wrote: > Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config() > would proceed with invalid plane and we may see vblank timeout. > > Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") >

Re: [libcamera-devel] [PATCH v2] drm/fourcc: Add bayer formats and modifiers

2020-06-19 Thread Tomasz Figa
Hi Niklas, On Fri, May 22, 2020 at 01:52:01AM +0200, Niklas Söderlund wrote: > Bayer formats are used with cameras and contain green, red and blue > components, with alternating lines of red and green, and blue and green > pixels in different orders. For each block of 2x2 pixels there is one > pix

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-10-16 Thread Tomasz Figa
On Wed, Oct 16, 2019 at 6:18 PM Daniel Vetter wrote: > > On Wed, Oct 16, 2019 at 12:19:02PM +0900, Tomasz Figa wrote: > > On Wed, Oct 9, 2019 at 12:04 AM Daniel Vetter wrote: > > > > > > On Tue, Oct 08, 2019 at 07:49:39PM +0900, Tomasz Figa wrote: > > >

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-10-16 Thread Tomasz Figa
On Wed, Oct 16, 2019 at 3:12 PM Gerd Hoffmann wrote: > > Hi, > > > up later when given a buffer index. But we would still need to make > > the DMA-buf itself importable. For virtio-gpu I guess that would mean > > returning an sg_table backed by the shadow buffer pages. > > The virtio-gpu driver

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-10-15 Thread Tomasz Figa
On Wed, Oct 9, 2019 at 12:04 AM Daniel Vetter wrote: > > On Tue, Oct 08, 2019 at 07:49:39PM +0900, Tomasz Figa wrote: > > On Tue, Oct 8, 2019 at 7:03 PM Daniel Vetter wrote: > > > > > > On Sat, Oct 05, 2019 at 02:41:54PM +0900, Tomasz Figa wrote: > > > &g

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-10-08 Thread Tomasz Figa
On Tue, Oct 8, 2019 at 7:03 PM Daniel Vetter wrote: > > On Sat, Oct 05, 2019 at 02:41:54PM +0900, Tomasz Figa wrote: > > Hi Daniel, Gerd, > > > > On Tue, Sep 17, 2019 at 10:23 PM Daniel Vetter wrote: > > > > > > On Thu, Sep 12, 2019 at 06:41:21PM +0900

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-10-04 Thread Tomasz Figa
Hi Daniel, Gerd, On Tue, Sep 17, 2019 at 10:23 PM Daniel Vetter wrote: > > On Thu, Sep 12, 2019 at 06:41:21PM +0900, Tomasz Figa wrote: > > This patch is an early RFC to judge the direction we are following in > > our virtualization efforts in Chrome OS. The purpose is to star

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-09-13 Thread Tomasz Figa
On Fri, Sep 13, 2019 at 5:07 PM Gerd Hoffmann wrote: > > Hi, > > > > > To seamlessly enable buffer sharing with drivers using such frameworks, > > > > make the virtio-gpu driver expose the resource handle as the DMA address > > > > of the buffer returned from the DMA-buf mapping operation. Argu

Re: [RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-09-12 Thread Tomasz Figa
Hi Gerd, On Thu, Sep 12, 2019 at 9:38 PM Gerd Hoffmann wrote: > > Hi, > > > To seamlessly enable buffer sharing with drivers using such frameworks, > > make the virtio-gpu driver expose the resource handle as the DMA address > > of the buffer returned from the DMA-buf mapping operation. Arguab

[RFC PATCH] drm/virtio: Export resource handles via DMA-buf API

2019-09-12 Thread Tomasz Figa
d already do the work. For example, a V4L2 driver using the videobuf2 framework would just call thee vb2_dma_contig_plane_dma_addr() function to get what the above open-coded function would return. Signed-off-by: Tomasz Figa --- drivers/gpu/drm/virtio/virtgpu_drv.c | 2 + drivers/gpu/d

Re: [PATCH] drm/mediatek: make imported PRIME buffers contiguous

2019-07-23 Thread Tomasz Figa
e, and use said DMA device when importing PRIME buffers. > > Signed-off-by: Alexandre Courbot > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 47 -- > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 ++ > 2 files changed, 46 insertions(+), 3 deletions(-) &

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-04 Thread Tomasz Figa
On Mon, Jun 3, 2019 at 7:48 PM Rob Clark wrote: > > On Sun, Jun 2, 2019 at 11:25 PM Tomasz Figa wrote: > > > > On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > > > > > > On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > > > > > >

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-02 Thread Tomasz Figa
On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > > On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > > > > On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > > > > > On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > > > > > > > This solves a problem we see with drm/msm, caused by gettin

Re: Support for 2D engines/blitters in V4L2 and DRM

2019-04-21 Thread Tomasz Figa
On Sat, Apr 20, 2019 at 12:31 AM Nicolas Dufresne wrote: > > Le vendredi 19 avril 2019 à 13:27 +0900, Tomasz Figa a écrit : > > On Fri, Apr 19, 2019 at 9:30 AM Nicolas Dufresne > > wrote: > > > Le jeudi 18 avril 2019 à 10:18 +0200, Daniel Vetter a écrit : > &g

Re: Support for 2D engines/blitters in V4L2 and DRM

2019-04-18 Thread Tomasz Figa
On Fri, Apr 19, 2019 at 9:30 AM Nicolas Dufresne wrote: > > Le jeudi 18 avril 2019 à 10:18 +0200, Daniel Vetter a écrit : > > > It would be cool if both could be used concurrently and not just return > > > -EBUSY when the device is used with the other subsystem. > > > > We live in this world alrea

Re: Support for 2D engines/blitters in V4L2 and DRM

2019-04-18 Thread Tomasz Figa
On Thu, Apr 18, 2019 at 6:14 PM Paul Kocialkowski wrote: > > Hi, > > On Thu, 2019-04-18 at 18:09 +0900, Tomasz Figa wrote: > > On Thu, Apr 18, 2019 at 5:55 PM Paul Kocialkowski > > wrote: > > > Hi Daniel, > > > > > > On Thu, 2019-04-18 at 10:18

Re: Support for 2D engines/blitters in V4L2 and DRM

2019-04-18 Thread Tomasz Figa
On Thu, Apr 18, 2019 at 5:55 PM Paul Kocialkowski wrote: > > Hi Daniel, > > On Thu, 2019-04-18 at 10:18 +0200, Daniel Vetter wrote: > > On Wed, Apr 17, 2019 at 08:10:15PM +0200, Paul Kocialkowski wrote: > > > Hi Nicolas, > > > > > > I'm detaching this thread from our V4L2 stateless decoding spec s

Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update

2019-03-12 Thread Tomasz Figa
On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon wrote: > > On Tue, 12 Mar 2019 12:34:45 -0300 > Helen Koike wrote: > > > On 3/12/19 3:34 AM, Boris Brezillon wrote: > > > On Mon, 11 Mar 2019 23:21:59 -0300 > > > Helen Koike wrote: > > > > > >> In the case of async update, modifications are done

Re: [PATCH] drm: add capability DRM_CAP_ASYNC_UPDATE

2018-12-20 Thread Tomasz Figa
On Thu, Dec 20, 2018 at 7:47 PM Daniel Vetter wrote: > > On Thu, Dec 20, 2018 at 10:07 AM Tomasz Figa wrote: > > > > Hi Helen, > > > > On Fri, Dec 14, 2018 at 10:35 AM Helen Koike > > wrote: > > > > > > Hi Tomasz, > > > > >

Re: [PATCH] drm: add capability DRM_CAP_ASYNC_UPDATE

2018-12-20 Thread Tomasz Figa
Hi Helen, On Fri, Dec 14, 2018 at 10:35 AM Helen Koike wrote: > > Hi Tomasz, > > On 12/13/18 2:02 AM, Tomasz Figa wrote: > > On Thu, Dec 6, 2018 at 1:12 AM Helen Koike > > wrote: > >> > >> Hi Ville > >> > >> On 11/27/18 11:34 AM, V

Re: [PATCH] dts: rockchip: rk3066: add qos_hdmi and HCLK_HDMI to pmu node

2018-12-16 Thread Tomasz Figa
Hi Johan, On Sun, Dec 16, 2018 at 12:03 AM Johan Jonker wrote: > > A MK808 TV stick with rk3066 processor boots normal with logo and console. > After the boot the monitor remains black. > This patch fixes a vblank timeout crash by adding qos_hdmi and > HCLK_HDMI to the pmu node. > The HCLK_HDMI c

Re: [BUG] drm_rockchip: rk3066_hdmi: No driver support for vblank timestamp query.

2018-12-13 Thread Tomasz Figa
Hi Johan, On Fri, Dec 14, 2018 at 2:32 AM Johan Jonker wrote: > > Bug fix? (PART 7) > > A little bit of success here. > Penguins and other colors are on the screen. > DRM and FB old style seems to work with DVI-D. > Pure HDMI and sound not tested. > I think 'someone' forgot to add HCLK_HDMI to th

Re: [PATCH v2] drm/atomic: add ATOMIC_AMEND flag to the Atomic IOCTL.

2018-12-12 Thread Tomasz Figa
Hi Helen, On Sat, Nov 24, 2018 at 6:54 AM Helen Koike wrote: > > This flag tells core to jump ahead the queued update if the conditions > in drm_atomic_async_check() are met. That means we are only able to do an > async update if no modeset is pending and update for the same plane is > not queued

Re: [PATCH] drm: add capability DRM_CAP_ASYNC_UPDATE

2018-12-12 Thread Tomasz Figa
On Thu, Dec 6, 2018 at 1:12 AM Helen Koike wrote: > > Hi Ville > > On 11/27/18 11:34 AM, Ville Syrjälä wrote: > > On Fri, Nov 23, 2018 at 07:53:26PM -0200, Helen Koike wrote: > >> Allow userspace to identify if the driver supports async update. > > > > And what exactly is an "async update"? > > I

Re: [BUG] drm_rockchip: rk3066_hdmi: No driver support for vblank timestamp query.

2018-12-09 Thread Tomasz Figa
Hi Johan, It looks like VOP on RK3066 is not officially supported by upstream, so what you're seeing is not a bug, it's just expected behavior, because nobody had the time (or need) to enable support for your hardware yet. I added all the people that may be potentially thinking to add support for

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-02 Thread Tomasz Figa
nce we don't currently have a better > +* solution, and this code runs before the driver is probed and > +* has a chance to intervene, use a simple blacklist to avoid > +* ending up with iommu dma_ops: > +*/ > + if (of_match_device(iommu_blacklist, de

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-12-02 Thread Tomasz Figa
On Sat, Dec 1, 2018 at 3:47 AM Rob Clark wrote: > > On Fri, Nov 30, 2018 at 9:05 PM Tomasz Figa wrote: > > > > On Thu, Nov 29, 2018 at 4:23 PM Tomasz Figa wrote: > > > > > > On Thu, Nov 29, 2018 at 12:03 PM Robin Murphy > > > wrote: > >

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-30 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 4:23 PM Tomasz Figa wrote: > > On Thu, Nov 29, 2018 at 12:03 PM Robin Murphy wrote: > > > > On 29/11/2018 19:57, Tomasz Figa wrote: > > > On Thu, Nov 29, 2018 at 11:40 AM Jordan Crouse > > > wrote: > > >> > > >&g

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 12:03 PM Robin Murphy wrote: > > On 29/11/2018 19:57, Tomasz Figa wrote: > > On Thu, Nov 29, 2018 at 11:40 AM Jordan Crouse > > wrote: > >> > >> On Thu, Nov 29, 2018 at 01:48:15PM -0500, Rob Clark wrote: > >>> On Thu, N

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 11:40 AM Jordan Crouse wrote: > > On Thu, Nov 29, 2018 at 01:48:15PM -0500, Rob Clark wrote: > > On Thu, Nov 29, 2018 at 10:54 AM Christoph Hellwig wrote: > > > > > > On Thu, Nov 29, 2018 at 09:42:50AM -0500, Rob Clark wrote: > > > > Maybe the thing we need to do is just i

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Tomasz Figa
[CC Marek] On Thu, Nov 29, 2018 at 9:09 AM Daniel Vetter wrote: > > On Thu, Nov 29, 2018 at 5:57 PM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 05:28:07PM +0100, Daniel Vetter wrote: > > > Just spend a bit of time reading through the implementations already > > > merged. Is the struct d

Re: [PATCH v2 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-27 Thread Tomasz Figa
ap_sg() calls with dma_sync_sg_for_device{|cpu}() > to do the cache maintenance. > > Signed-off-by: Vivek Gautam > Suggested-by: Tomasz Figa > Cc: Rob Clark > Cc: Jordan Crouse > Cc: Sean Paul > --- > > Changes since v1: > - Addressed Jordan's and Tomasz's c

Re: [BUG] drm_rockchip: rk3066_hdmi: No driver support for vblank timestamp query.

2018-11-27 Thread Tomasz Figa
On Tue, Nov 27, 2018 at 6:11 PM Tomasz Figa wrote: > > Hi Johan, > > Adding the dri-devel mailing lists and some maintainers. > > On Sun, Nov 25, 2018 at 12:53 AM Johan Jonker wrote: > > > > For a TV stick called MK808 with rk3066 processor I would like to enable

Re: [BUG] drm_rockchip: rk3066_hdmi: No driver support for vblank timestamp query.

2018-11-27 Thread Tomasz Figa
Hi Johan, Adding the dri-devel mailing lists and some maintainers. On Sun, Nov 25, 2018 at 12:53 AM Johan Jonker wrote: > > For a TV stick called MK808 with rk3066 processor I would like to enable > the VOP and HDMI. > With boot logo and console enabled I can see 2 pinguins and a cursor for > a

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-26 Thread Tomasz Figa
Hi Gustavo, On Tue, Nov 27, 2018 at 8:54 AM Gustavo Padovan wrote: > > Hi Tomasz, > > On 11/23/18 12:27 AM, Tomasz Figa wrote: > > Hi Helen, > > > > On Fri, Nov 23, 2018 at 8:31 AM Helen Koike > > wrote: > >> Hi Tomasz, > >> >

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-22 Thread Tomasz Figa
Hi Michael, On Fri, Nov 23, 2018 at 1:58 PM Michael Zoran wrote: > > On Fri, 2018-11-23 at 11:27 +0900, Tomasz Figa wrote: > > > > The point here is not about setting and resetting the plane->fb > > pointer. It's about what happens inside > > drm_atomi

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-22 Thread Tomasz Figa
Hi Helen, On Fri, Nov 23, 2018 at 8:31 AM Helen Koike wrote: > > Hi Tomasz, > > On 11/20/18 4:48 AM, Tomasz Figa wrote: > > Hi Helen, > > > > On Tue, Nov 20, 2018 at 4:08 AM Helen Koike > > wrote: > >> > >> From: Enric Balletbo i Serra

Re: [PATCH 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-20 Thread Tomasz Figa
non-dma type. Using dma mapping APIs with that domain is bad. > > > > Replace dma_map_sg() calls with dma_sync_sg_for_device{|cpu}() > > to do the cache maintenance. > > > > Signed-off-by: Vivek Gautam > > Suggested-by: Tomasz Figa > > --- > > >

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-19 Thread Tomasz Figa
Hi Helen, On Tue, Nov 20, 2018 at 4:08 AM Helen Koike wrote: > > From: Enric Balletbo i Serra > > Add support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Enric Balletbo i Serra > [updated for upstream] > Signed-off-by: Helen Koike > > --- > Hell

Re: [PATCH v2] drm/rockchip: update cursors asynchronously through atomic.

2018-11-14 Thread Tomasz Figa
Hi Enric, On Fri, Sep 28, 2018 at 5:27 PM Enric Balletbo i Serra wrote: > > Add support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Enric Balletbo i Serra > --- > Hi, > > This is a second version of the patch to add async-plane update support > to

Re: [RFC v4 03/18] vb2: Move cache synchronisation from buffer done to dqbuf handler

2018-10-05 Thread Tomasz Figa
Hi Sakari, Hans, On Tue, May 9, 2017 at 12:05 AM Sakari Ailus wrote: > > The cache synchronisation may be a time consuming operation and thus not > best performed in an interrupt which is a typical context for > vb2_buffer_done() calls. This may consume up to tens of ms on some > machines, depend

Re: [PATCH] drm/rockchip: update cursors asynchronously through atomic.

2018-08-13 Thread Tomasz Figa
On Mon, Aug 13, 2018 at 4:26 PM Heiko Stuebner wrote: > > Am Montag, 13. August 2018, 09:11:07 CEST schrieb Tomasz Figa: > > Hi Enric, > > > > On Tue, Aug 7, 2018 at 12:53 AM Enric Balletbo i Serra > > wrote: > > > > > > Add support to

Re: [PATCH] drm/rockchip: update cursors asynchronously through atomic.

2018-08-13 Thread Tomasz Figa
Hi Enric, On Tue, Aug 7, 2018 at 12:53 AM Enric Balletbo i Serra wrote: > > Add support to async updates of cursors by using the new atomic > interface for that. > > Signed-off-by: Enric Balletbo i Serra > --- > Hi, > > This first version is slightly different from the RFC, note that I did > not

Re: [PATCH v4 1/2] drm/rockchip: vop: split out core clock enablement into separate functions

2018-06-18 Thread Tomasz Figa
31 insertions(+), 13 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-06-18 Thread Tomasz Figa
s: %#02x\n", > active_irqs); > > + vop_core_clks_disable(vop); > + > +out: > + pm_runtime_put(vop->dev); > return ret; > } Other than that: Reviewed-by: Tomasz Figa Best regards, Tomasz ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/rockchip: vop: fix irq disabled after vop driver probed

2018-05-24 Thread Tomasz Figa
Hi Heiko, Sandy, On Fri, May 25, 2018 at 7:07 AM Heiko Stübner wrote: > From: Sandy Huang > The vop irq is shared between vop and iommu and irq probing in the > iommu driver moved to the probe function recently. This can in some > cases lead to a stall if the irq is triggered while the vop dri

minigbm/cros_gralloc handle struct (Was: Re: [drm_hwc] PSA: drm_hwc submissions via gitlab)

2018-05-06 Thread Tomasz Figa
[Really taking this to another thread. Leaving CC as is for the time being.] On Sat, May 5, 2018 at 4:16 AM Mauro Rossi wrote: > > Il 04 mag 2018 19:51, "Alistair Strachan" ha > scritto: > > On Fri, May 4, 2018 at 10:35 AM Sean Paul wrote: > >> On Fri, May 04, 2018 at 05:19:50PM +, Mauro R

Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier

2018-04-16 Thread Tomasz Figa
Hi Andrzej, On Mon, Apr 16, 2018 at 6:57 PM Andrzej Hajda wrote: > On 05.04.2018 11:49, Enric Balletbo i Serra wrote: > > From: Tomasz Figa > > > > It looks like the driver subsystem detaches devices from power domains > > at shutdown without consent of the drive

Re: [RFC 0/1] DRM Node Probing functionality

2018-04-15 Thread Tomasz Figa
Hi Rob, On Thu, Apr 12, 2018 at 12:56 PM Robert Foss wrote: > *Resend the whole actual series* > This patch implements a simple function for matching DRM device FDs against > the desired properties of a device that you are looking for. > The properties that are possible to look for are the ele

Re: [PATCH libdrm 1/2] intel: Do not use libpciaccess on Android

2018-03-27 Thread Tomasz Figa
On Wed, Mar 21, 2018 at 2:36 AM, Emil Velikov wrote: > From: Tomasz Figa > > This patch makes the code not rely anymore on libpciaccess when compiled > for Android to eliminate ioperm() and iopl() syscalls required by that > library. As a side effect, the mappable aperture size

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-22 Thread Tomasz Figa
On Thu, Feb 22, 2018 at 10:45 PM, Robin Murphy wrote: > [sorry, I had intended to reply sooner but clearly forgot] > > > On 16/02/18 00:13, Tomasz Figa wrote: >> >> On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy >> wrote: >>> &

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-22 Thread Tomasz Figa
On Fri, Feb 16, 2018 at 9:13 AM, Tomasz Figa wrote: > On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy wrote: >> On 15/02/18 04:17, Tomasz Figa wrote: >> [...] >>>> >>>> Could you elaborate on what kind of locking you are concerned about? >>>> As I

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-15 Thread Tomasz Figa
On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy wrote: > On 15/02/18 04:17, Tomasz Figa wrote: > [...] >>> >>> Could you elaborate on what kind of locking you are concerned about? >>> As I explained before, the normally happening fast path would lock >>> de

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-14 Thread Tomasz Figa
On Thu, Feb 15, 2018 at 12:17 PM, Tomasz Figa wrote: > On Thu, Feb 15, 2018 at 1:03 AM, Robin Murphy wrote: >> On 14/02/18 10:33, Vivek Gautam wrote: >>> >>> On Wed, Feb 14, 2018 at 2:46 PM, Tomasz Figa wrote: >>> >>> Adding Jordan to this thread a

Re: [Freedreno] [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-14 Thread Tomasz Figa
On Thu, Feb 15, 2018 at 1:12 AM, Rob Clark wrote: > On Wed, Feb 14, 2018 at 10:48 AM, Jordan Crouse > wrote: >> On Wed, Feb 14, 2018 at 12:31:29PM +0900, Tomasz Figa wrote: >>> >>> - When submitting commands to the GPU, the GPU driver will >>> pm_runtime_g

  1   2   3   4   5   >