Re: [PATCH 1/2] drm/ttm: set ttm_buffer_object pointer as null after it's freed

o since my workstation depends on our staging tree to work properly...). Tom Am 10.09.2018 um 14:59 schrieb Tom St Denis: Hi Christian, Are you adding new traces or turning on existing ones?  Would you like me to try them out in my setup? Tom On 2018-09-10 8:49 a.m., Christian König

Re: [PATCH 1/2] drm/ttm: set ttm_buffer_object pointer as null after it's freed

Hi Christian, Are you adding new traces or turning on existing ones? Would you like me to try them out in my setup? Tom On 2018-09-10 8:49 a.m., Christian König wrote: Am 10.09.2018 um 14:05 schrieb Huang Rui: On Mon, Sep 10, 2018 at 05:25:48PM +0800, Koenig, Christian wrote: Am 10.09.201

[PATCH] drm/amdgpu: replace iova debugfs file with iomem (v3)

This allows access to pages allocated through the driver with optional IOMMU mapping. v2: Fix number of bytes copied and add write method v3: drop check for kmap return Original-by: Christian König Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 102

Re: [PATCH v3 00/13] gpu: drm: amd: remove unused headers

This will break umr since we source the headers from the kernel. The kernel might not use them but the different IP blocks have deltas that umr is aware of. One might argue that we should then publish the headers somewhere else that is public but the kernel is our vehicle right now. Thought

Re: [PATCH] drm/amdgpu: replace iova debugfs file with iomem (v2)

On 12/02/18 12:16 PM, Christian König wrote: Am 12.02.2018 um 17:40 schrieb Tom St Denis: On 09/02/18 01:44 PM, Christian König wrote: Am 09.02.2018 um 19:19 schrieb Tom St Denis: On 09/02/18 01:17 PM, Christian König wrote: Am 09.02.2018 um 18:28 schrieb Tom St Denis: On 09/02/18 12:27 PM

Re: [PATCH] drm/amdgpu: replace iova debugfs file with iomem (v2)

On 09/02/18 01:44 PM, Christian König wrote: Am 09.02.2018 um 19:19 schrieb Tom St Denis: On 09/02/18 01:17 PM, Christian König wrote: Am 09.02.2018 um 18:28 schrieb Tom St Denis: On 09/02/18 12:27 PM, Tom St Denis wrote: From: Christian König Oops, I'll remove this from the c

[PATCH] drm/amdgpu: replace iova debugfs file with iomem (v3)

From: Christian König This allows access to pages allocated through the driver with optional IOMMU mapping. v2: Fix number of bytes copied and add write method v3: drop check for kmap return Original-by: Christian König Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

Re: [PATCH] drm/amdgpu: replace iova debugfs file with iomem (v2)

On 09/02/18 01:17 PM, Christian König wrote: Am 09.02.2018 um 18:28 schrieb Tom St Denis: On 09/02/18 12:27 PM, Tom St Denis wrote: From: Christian König Oops, I'll remove this from the commit message before pushing :-) I did give you credit below though. The patch before this one

Re: [PATCH] drm/amdgpu: replace iova debugfs file with iomem (v2)

On 09/02/18 12:27 PM, Tom St Denis wrote: From: Christian König Oops, I'll remove this from the commit message before pushing :-) I did give you credit below though. Tom This allows access to pages allocated through the driver with optional IOMMU mapping. v2: Fix number of bytes c

[PATCH] drm/amdgpu: replace iova debugfs file with iomem (v2)

From: Christian König This allows access to pages allocated through the driver with optional IOMMU mapping. v2: Fix number of bytes copied and add write method Original-by: Christian König Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 110

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

On 09/02/18 09:56 AM, Christian König wrote: Am 09.02.2018 um 15:51 schrieb Tom St Denis: On 09/02/18 09:12 AM, Christian König wrote: No, there is simply no need to initialize the system domain. What are the values of p->mapping and adev->mman.bdev.dev_mapping when they don't matc

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

On 09/02/18 09:12 AM, Christian König wrote: No, there is simply no need to initialize the system domain. What are the values of p->mapping and adev->mman.bdev.dev_mapping when they don't match? Maybe we are allocating memory before initializing adev->mman.bdev.dev_mapping. In my test setup I

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

On 09/02/18 08:56 AM, Christian König wrote: Am 09.02.2018 um 14:32 schrieb Tom St Denis: On 02/02/18 02:09 PM, Christian König wrote: [SNIP] +    if (p->mapping != adev->mman.bdev.dev_mapping) +    return -EPERM; This comparison fails for both IOMMU and non-IOMMU devices

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

On 02/02/18 02:09 PM, Christian König wrote: This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 57 - 1 file changed, 35 insertions(+), 22 deletions

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

x27;m more concerned about is if setting page->mapping during allocation of the page could have any negative effect? I of hand don't see any since the page isn't reclaimable directly anyway, but I'm not 100% sure of that. Christian. Am 05.02.2018 um 12:49 schrieb Tom St De

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

Another thing that occurred to me is this will break write access to GPU bound memory. Previously we relied on iova to translate the address and then /dev/mem or /dev/fmem to read/write it. But since this is literally a read only method obviously there's no write support. Tom On 04/02/18 0

[PATCH 08/12] drm/ttm: Remove unncessary retval from ttm_bo_vm_fault()

The dual ret/retval was more complex than need be. Now we drop the retval variable and assign the appropriate VM codes to ret instead. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 28 +--- 1 file changed, 13 insertions

[PATCH 11/12] drm/ttm: Fix coding style in ttm_dma_pool_alloc_new_pages()

Add missing {} braces. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c index

[PATCH 07/12] drm/ttm: Fix coding style in ttm_bo_move_memcpy()

Add missing {} braces. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c index 153de1bf0232..33ffe286f3a5

[PATCH 10/12] drm/ttm: Fix coding style in ttm_tt_swapout()

Add missing {} braces. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index e90d3ed6283f..95a77dab8cc9 100644 --- a

[PATCH 12/12] drm/ttm: Simplify ttm_dma_page_put()

Remove redundant store of return code. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm

[PATCH 05/12] drm/ttm: Fix coding style in ttm_pool_store()

Correct missing {} style. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c index

[PATCH 09/12] drm/ttm: Simplify ttm_eu_reserve_buffers()

Hoist the comparison of the ret to -EDEADLK above the two code paths to simplify the function. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_execbuf_util.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 06/12] drm/ttm: Simplify ttm_dma_find_pool() (v2)

Flip the logic of the comparison and remove the redudant variable for the pool address. Signed-off-by: Tom St Denis Reviewed-by: Christian König (v2): Remove {} bracing. --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff

Various TTM cleanups (v2)

Various TTM cleanups (mostly no functional changes). Notably patch #1 fixes a bug in the access_kmap() function. The rest are either coding style fixes or simplifications. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freede

[PATCH 02/12] drm/ttm: Fix coding style in ttm_bo.c

Correct indentation and {} brace style. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index d33a6bb742a1

[PATCH 01/12] drm/ttm: Fix 'buf' pointer update in ttm_bo_vm_access_kmap() (v2)

The buf pointer was not being incremented inside the loop meaning the same block of data would be read or written repeatedly. Signed-off-by: Tom St Denis Reviewed-by: Christian König (v2) Change 'buf' pointer to uint8_t* type --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 ++- 1 file

[PATCH 04/12] drm/ttm: Change ttm_tt page allocations to return errors

Explicitly return errors in ttm_tt_alloc_page_directory() and ttm_dma_tt_alloc_page_directory() instead of relying on further logic to detect errors. Signed-off-by: Tom St Denis Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 16 ++-- 1 file changed, 10 insertions

[PATCH 03/12] drm/ttm: Add a default BO destructor to simplify code (v2)

Signed-off-by: Tom St Denis Reviewed-by: Christian König (v2): Remove stray ; noticed by Felix --- drivers/gpu/drm/ttm/ttm_bo.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 8cf89da7030d

Re: Various TTM cleanups/fixes

anyone else has issues. I agree that #10 is a bit tricky because retval had a default value which hopefully I captured with the assignment towards the end of the function. It just seemed kinda awkward to have ret and retval :-) Thanks, Tom Regards, Christian. Am 26.01.2018 um 19:28

[PATCH 09/12] drm/ttm: Fix indentation in ttm_bo_move_memcpy()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_bo_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c index 153de1bf0232..33ffe286f3a5 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_util.c +++ b

[PATCH 05/12] drm/ttm: Fix indentation in ttm_pool_store()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c index 9e90d0ebc773..647eb5f40ab9 100644 --- a/drivers/gpu/drm

[PATCH 11/12] drm/ttm: Fix 'buf' pointer update in ttm_bo_vm_access_kmap()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c index 07b22f04b969..6311f8a481ea 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c +++ b/drivers/gpu/drm/ttm

[PATCH 10/12] drm/ttm: Remove unncessary retval from ttm_bo_vm_fault()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c index 08a3c324242e..07b22f04b969 100644 --- a/drivers/gpu/drm/ttm

[PATCH 06/12] drm/ttm: Simplify ttm_dma_page_put()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c index 647eb5f40ab9..962838cfb1a3 100644 --- a/drivers/gpu/drm/ttm

[PATCH 08/12] drm/ttm: Fix indentation in ttm_dma_pool_alloc_new_pages()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c index 579c4aedc17e..aa1ec35dc187 100644 --- a/drivers/gpu/drm/ttm

[PATCH 12/12] drm/ttm: Simplify ttm_eu_reserve_buffers()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_execbuf_util.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_execbuf_util.c b/drivers/gpu/drm/ttm/ttm_execbuf_util.c index 373ced0b2fc2..fa44f7b15285 100644 --- a/drivers/gpu/drm

[PATCH 07/12] drm/ttm: Simplify ttm_dma_find_pool()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c index 962838cfb1a3..579c4aedc17e 100644 --- a/drivers/gpu

[PATCH 04/12] drm/ttm: Fix indentation in ttm_tt_swapout()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_tt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index e90d3ed6283f..95a77dab8cc9 100644 --- a/drivers/gpu/drm/ttm/ttm_tt.c +++ b/drivers/gpu/drm/ttm

[PATCH 01/12] drm/ttm: Clean up indentation in ttm_bo.c

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_bo.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index d33a6bb742a1..8cf89da7030d 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm

[PATCH 02/12] drm/ttm: Add a default BO destructor to simplify code

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_bo.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 8cf89da7030d..4e85c32fea26 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu

[PATCH 03/12] drm/ttm: Change ttm_tt page allocations to return errors

Explicitly return errors in ttm_tt_alloc_page_directory() and ttm_dma_tt_alloc_page_directory() instead of relying on further logic to detect errors. Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_tt.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

Various TTM cleanups/fixes

This series includes mostly no-functional-changes to simplify or cleanup various routines. Patch #11 includes an fix to functional behaviour. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-d

Re: 'buf' pointer in ttm_bo_vm_access_kmap()

On 26/01/18 09:38 AM, Christian König wrote: Am 26.01.2018 um 15:31 schrieb Tom St Denis: Hi all, In the function ttm_bo_vm_access_kmap() it doesn't seem to me like the 'buf' pointer is incremented.  That seems like a bug no? Yeah, looks suspicious to me as well. But TTM ques

Re: Hardware 3D acceleration doesn't work anymore with the latest git kernel

On 27/11/17 07:02 AM, Michel Dänzer wrote: On 2017-11-27 12:50 PM, Christian König wrote: Am 27.11.2017 um 12:02 schrieb Michel Dänzer: On 2017-11-24 05:09 PM, Michel Dänzer wrote: On 2017-11-24 03:29 PM, Christian Zigotzky wrote: Hi All, I bisected today and the first bad commit is: a4dec81

Re: [radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 4/16] drivers/gpu//drm/ttm/ttm_page_alloc.c:923:5: error: redefinition of 'ttm_populate_and_map_pages'

Is this: commit 7a9667ae197460e6c9c3bb432fe68c708fce6259 Refs: v4.13-rc5-1195-g7a9667ae1974 Author: Tom St Denis AuthorDate: Tue Sep 5 07:30:59 2017 -0400 Commit: Alex Deucher CommitDate: Tue Sep 12 14:22:55 2017 -0400 drm/ttm: Fix configuration error around populate_and_map

[PATCH] drm/ttm: Fix unused variables with huge page support

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index b6f16e73..95022473704b 100644 --- a/drivers/gpu/drm/ttm

Re: [PATCH 4/4] drm/ttm: Remove TTM dma tracepoint since it's not required anymore

On 19/09/17 07:13 AM, Christian König wrote: Am 18.09.2017 um 19:33 schrieb Tom St Denis: Signed-off-by: Tom St Denis Mhm, I sometimes have good use for those. But just adding a printk at the right place does the job as well. So patch is Reviewed-by: Christian König . Well if you want

remove ttm trace and add iova debugfs (v2)

In this respin I add some changes per feedback and make the iova entry have proper read/write methods which access pages mapped by amdgpu. So there is no need for /dev/mem or /dev/fmem anymore when reading system memory. Patches 3/4 are unchanged and remove the TTM trace from amdgpu and from TTM

[PATCH 4/4] drm/ttm: Remove TTM dma tracepoint since it's not required anymore

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/Makefile | 2 +- drivers/gpu/drm/ttm/ttm_debug.c | 74 - drivers/gpu/drm/ttm/ttm_trace.h | 87 --- drivers/gpu/drm/ttm/ttm_tracepoints.c | 45

[PATCH 1/4] drm/amd/amdgpu: Fold TTM debugfs entries into array (v2)

Signed-off-by: Tom St Denis (v2): add domains and avoid strcmp --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 54 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 4 +-- 2 files changed, 32 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 3/4] drm/amd/amdgpu: remove usage of ttm trace

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 36 +++-- 1 file changed, 3 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 02ae32378e1c..b41d03226c26

[PATCH 2/4] drm/amd/amdgpu: add support for iova_to_phys to replace TTM trace (v3)

Signed-off-by: Tom St Denis (v2): Add domain to iova debugfs (v3): Add true read/write methods to access system memory of pages mapped to the device --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 104 1 file changed, 104 insertions(+) diff --git a/drivers

Re: [PATCH 1/4] drm/amd/amdgpu: Fold TTM debugfs entries into array

On 18/09/17 08:48 AM, Christian König wrote: Am 18.09.2017 um 14:35 schrieb Tom St Denis: Signed-off-by: Tom St Denis ---   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 53 ++---   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h |  4 +--   2 files changed, 31 insertions

Re: [PATCH 2/4] drm/amd/amdgpu: add support for iova_to_phys to replace TTM trace

On 18/09/17 08:52 AM, Christian König wrote: Am 18.09.2017 um 14:35 schrieb Tom St Denis: Signed-off-by: Tom St Denis ---   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 32   1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

[PATCH 4/4] drm/ttm: Remove TTM dma tracepoint since it's not required anymore

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/Makefile | 2 +- drivers/gpu/drm/ttm/ttm_debug.c | 74 - drivers/gpu/drm/ttm/ttm_trace.h | 87 --- drivers/gpu/drm/ttm/ttm_tracepoints.c | 45

[PATCH 2/4] drm/amd/amdgpu: add support for iova_to_phys to replace TTM trace

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 7848ffa99eb4..b4c298925e2a 100644 --- a/drivers

[PATCH 1/4] drm/amd/amdgpu: Fold TTM debugfs entries into array

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 53 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 4 +-- 2 files changed, 31 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 3/4] drm/amd/amdgpu: remove usage of ttm trace

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 36 +++-- 1 file changed, 3 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index b4c298925e2a..e0c37fe4d043

Remove TTM trace and use proper IOMMU api

These patches tidy up the amdgpu_ttm debugfs creation, add an iova_to_phys interface and then remove the TTM trace from both amdgpu and drm/ttm. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dr

[PATCH] drm/ttm: Fix configuration error around populate_and_map() functions

Fixed kbuild errors when IOMMU/SWIOTLB are disabled. Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index 6a660d196d87..052e1f102113 100644

Re: [PATCH] drm/ttm: Fix trace include path (v2)

On 01/09/17 01:48 PM, Thierry Reding wrote: On Fri, Sep 01, 2017 at 12:14:23PM -0400, Tom St Denis wrote: Signed-off-by: Tom St Denis (v2): Drop Makefile change too. --- drivers/gpu/drm/ttm/Makefile| 2 +- drivers/gpu/drm/ttm/ttm_trace.h | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 1/2] drm/amd/amdgpu: Fix TRACE include path

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h index b1f97417241d..cef1a26deb2d 100644 --- a/drivers/gpu/drm/amd

[PATCH 2/2] drm/ttm: Fix trace include path

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_trace.h b/drivers/gpu/drm/ttm/ttm_trace.h index 23279b9b8e64..715ce68b7b33 100644 --- a/drivers/gpu/drm/ttm/ttm_trace.h +++ b/drivers/gpu

[PATCH] drm/ttm: Fix trace include path (v2)

Signed-off-by: Tom St Denis (v2): Drop Makefile change too. --- drivers/gpu/drm/ttm/Makefile| 2 +- drivers/gpu/drm/ttm/ttm_trace.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/Makefile b/drivers/gpu/drm/ttm/Makefile index fd3da00c0bf2

Re: [PATCH 2/2] drm/ttm: Fix trace include path

On 01/09/17 12:12 PM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Friday, September 01, 2017 12:11 PM To: amd-...@lists.freedesktop.org Cc: StDenis, Tom; dri-devel@lists.freedesktop.org Subject

Re: [PATCH 1/6] drm: Use correct path to trace include

On 01/09/17 11:02 AM, Christian König wrote: Am 01.09.2017 um 16:49 schrieb Thierry Reding: From: Thierry Reding The header comment in include/trace/define_trace.h specifies that the TRACE_INCLUDE_PATH needs to be relative to the define_trace.h header rather than the trace file including it. M

Re: [PATCH 2/2] drm/ttm: Remove needless 'extern' on functions in header.

On 24/08/17 07:53 AM, Christian König wrote: Am 24.08.2017 um 12:48 schrieb Tom St Denis: Minor tidy up. Signed-off-by: Tom St Denis Thanks and sorry that I thought you added this, I really need more sleep. Patch is Reviewed-by: Christian König . No worries. For a second there I thought

[PATCH 2/2] drm/ttm: Remove needless 'extern' on functions in header.

Minor tidy up. Signed-off-by: Tom St Denis --- include/drm/ttm/ttm_page_alloc.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/drm/ttm/ttm_page_alloc.h b/include/drm/ttm/ttm_page_alloc.h index 4400c08169cd..19bdd907613c 100644 --- a/include/drm/ttm

[PATCH 1/2] drm/ttm: Add dummy *populate_and_*map_pages() functions

On non IOTLB/IOMMU builds these functions would be undefined. Signed-off-by: Tom St Denis --- include/drm/ttm/ttm_page_alloc.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/drm/ttm/ttm_page_alloc.h b/include/drm/ttm/ttm_page_alloc.h index 8695918ea629..4400c08169cd

Re: [radeon-alex:drm-next-4.14-wip 39/44] drivers/gpu/drm/radeon/radeon_ttm.c:763:2: error: implicit declaration of function 'ttm_populate_and_map_pages'

On 24/08/17 02:43 AM, Christian König wrote: The problem is here: #if defined(CONFIG_SWIOTLB) || defined(CONFIG_INTEL_IOMMU) extern int ttm_dma_populate(struct ttm_dma_tt *ttm_dma, struct device *dev); extern void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct device *dev); We h

Re: [PATCH] drm/ttm: Add helper functions to populate/map in one call

ping? Haven't seen any comments on amd-gfx or dri-devel. Cheers, Tom On 18/08/17 10:07 AM, Tom St Denis wrote: These functions replace a section of common code found in radeon/amdgpu drivers (and possibly others) as part of the ttm_tt_*populate() callbacks. Signed-off-by: Tom St

[PATCH 2/2] drm/amd/amdgpu: Remove AMDGPU tracepoint and use new TTM tracepoint (v2)

Switches the AMDGPU driver over to the TTM tracepoint and removes our old one. Now you can enable traces before loading the module and trace all mappings. Signed-off-by: Tom St Denis Reviewed-by: Christian König (v2): Use struct device instead of pci in trace. --- drivers/gpu/drm/amd/amdgpu

[PATCH 1/2] drm/ttm: Add DMA map/unmap tracepoint (v3)

Also exports two functions that vendor drivers can call to trace DMA mappings. This is meant to help translate IOMMU mappings of bus addresses back to physical pages. Used by the umr amdgpu debugger for instance. Signed-off-by: Tom St Denis Reviewed-by: Christian König (v2): Use dev_name

[PATCH] drm/ttm: Add helper functions to populate/map in one call

These functions replace a section of common code found in radeon/amdgpu drivers (and possibly others) as part of the ttm_tt_*populate() callbacks. Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 41 include/drm/ttm/ttm_page_alloc.h

[PATCH] drm/nouveau: use new TTM populate/DMA map function

Removes common code found in numerous vendor drivers and places it higher up in the TTM tree. Signed-off-by: Tom St Denis --- drivers/gpu/drm/nouveau/nouveau_bo.c | 37 ++-- 1 file changed, 2 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/drm/nouveau

Brightness control fails between 3.6.8 and 3.7.0-rc7 (Intel 915/Dell Vostro 3560)

- Original Message - > From: "Daniel Vetter" > To: "Tom St Denis" > Cc: linux-kernel at vger.kernel.org, "intel-gfx" lists.freedesktop.org>, "dri-devel" > > Sent: Sunday, 2 December, 2012 9:42:39 AM > Subject: Re: Brightness control fa

Re: Brightness control fails between 3.6.8 and 3.7.0-rc7 (Intel 915/Dell Vostro 3560)

- Original Message - > From: "Daniel Vetter" > To: "Tom St Denis" > Cc: linux-ker...@vger.kernel.org, "intel-gfx" > , "dri-devel" > > Sent: Sunday, 2 December, 2012 9:42:39 AM > Subject: Re: Brightness control fails between 3.6.8 and 3.7

Re: Brightness control fails between 3.6.8 and 3.7.0-rc7 (Intel 915/Dell Vostro 3560)

60) > > Including a bunch more lists to the cc. > > On Sun, Dec 2, 2012 at 12:42 PM, Daniel Vetter > wrote: > > On Sun, Dec 2, 2012 at 12:32 PM, Tom St Denis > > wrote: > >> I've narrowed it down to sometime between v3.6.8 and v3.7-rc1. So > >> n

Brightness control fails between 3.6.8 and 3.7.0-rc7 (Intel 915/Dell Vostro 3560)

> 915/Dell Vostro 3560) > > Including a bunch more lists to the cc. > > On Sun, Dec 2, 2012 at 12:42 PM, Daniel Vetter > wrote: > > On Sun, Dec 2, 2012 at 12:32 PM, Tom St Denis > > wrote: > >> I've narrowed it down to sometime between v3.6.8 and v