Re: [PATCH v2] drm/radeon: have the callers of set_memory_*() check the return value

2020-02-04 Thread Tianlin Li
> On Feb 3, 2020, at 11:16 AM, Christian König wrote: > > Am 03.02.20 um 17:18 schrieb Tianlin Li: >> Right now several architectures allow their set_memory_*() family of >> functions to fail, > > Oh, that is a detail I previously didn't recognized. Which archi

[PATCH v2] drm/radeon: have the callers of set_memory_*() check the return value

2020-02-04 Thread Tianlin Li
protections aren't left in a partial state. This series is part of step 1. Make drm/radeon check the return value of set_memory_*(). Signed-off-by: Tianlin Li --- v2: The hardware is too old to be tested on and the code cannot be simply removed from the kernel, so this is the solution for the

Re: [PATCH 0/2] drm/radeon: have the callers of set_memory_*() check the return value

2020-01-09 Thread Tianlin Li
> On Jan 8, 2020, at 6:56 AM, Christian König wrote: > > Am 07.01.20 um 20:25 schrieb Tianlin Li: >> Right now several architectures allow their set_memory_*() family of >> functions to fail, but callers may not be checking the return values. >> If set_memory_*()

[PATCH 2/2] drm/radeon: change call sites to handle return value properly.

2020-01-08 Thread Tianlin Li
Ideally, the failure of set_memory_*() should be passed up the call stack, and callers should examine the failure and deal with it. Fix those call sites in drm/radeon to handle retval properly. Since fini functions are always void, print errors for the failures. Signed-off-by: Tianlin Li

[PATCH 0/2] drm/radeon: have the callers of set_memory_*() check the return value

2020-01-08 Thread Tianlin Li
protections aren't left in a partial state. This series is part of step 1. Make drm/radeon check the return value of set_memory_*(). Tianlin Li (2): drm/radeon: have the callers of set_memory_*() check the return value drm/radeon: change call sites to handle return value properly. drivers/gp

[PATCH 1/2] drm/radeon: have the callers of set_memory_*() check the return value

2020-01-08 Thread Tianlin Li
Have the callers of set_memory_*() in drm/radeon check the return value. Change the return type of the callers properly. Signed-off-by: Tianlin Li --- drivers/gpu/drm/radeon/radeon.h | 2 +- drivers/gpu/drm/radeon/radeon_gart.c | 22 ++ 2 files changed, 19 insertions