On Fri, Jun 27, 2025 at 02:38:19PM +0200, Jocelyn Falempe wrote:
> On 32bits ARM, u64 divided by a constant is not optimized to a
> multiply by inverse by the compiler [1].
> So do the multiply by inverse explicitly for this architecture.
>
> Link: https://github.com/llvm/llvm-project/issues/37280
t to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping locks in atomic contexts.
Switch to the regular pointer formatting which is safer and
easier to reason about.
Signed-off-by: Thomas Weißschuh
---
Changes in v2:
- Drop already applied patches
t to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping locks in atomic contexts.
Switch to the regular pointer formatting which is safer and
easier to reason about.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 2 +-
is safe.
Signed-off-by: Thomas Weißschuh
---
Thomas Weißschuh (3):
drm/bridge: samsung-dsim: Don't use %pK through printk
drm/exynos: Don't use %pK through printk
drm/msm: Don't use %pK through printk
drivers/gpu/drm/bridge/samsung-dsim.c | 4 ++--
driv
t to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping locks in atomic contexts.
Switch to the regular pointer formatting which is safer and
easier to reason about.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/bridge/samsung-dsim.c | 4 ++-
t to be used
through printk(). They can still unintentionally leak raw pointers or
acquire sleeping locks in atomic contexts.
Switch to the regular pointer formatting which is safer and
easier to reason about.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/exynos/exynos_drm_gem.c | 2 +-
dr
Hi,
On Tue, Mar 11, 2025 at 07:28:55PM +0800, oushixiong1...@163.com wrote:
> From: Shixiong Ou
>
> Use device_add_group() to simplify creation and removal.
>
> Signed-off-by: Shixiong Ou
> ---
> drivers/video/fbdev/core/fbcon.c | 48 +++-
> 1 file changed, 22 inse
Hi,
On 2024-12-16 12:34:46+0100, Thomas Weißschuh wrote:
> The sysfs core now allows instances of 'struct bin_attribute' to be
> moved into read-only memory. Make use of that to protect them against
> accidental or malicious modifications.
Can anybody pick up these patches?
E
Hi Sasha,
On 2025-01-26 09:54:18-0500, Sasha Levin wrote:
> From: Thomas Weißschuh
>
> [ Upstream commit 22e5c7ae12145af13785e3ff138395d5b1a22116 ]
>
> Panels using a PWM-controlled backlight source do not have a standard
> way to communicate their valid PWM ranges.
>
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.
Signed-off-by: Thomas Weißschuh
---
drivers/accel/habanalabs/common/sysfs.c | 10 +-
1 file
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.
Signed-off-by: Thomas Weißschuh
---
Thomas Weißschuh (5):
drm/sysfs: Constify 'struct bin_attri
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 8 --
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/i915/i915_gpu_error.c | 8
drivers/gp
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++---
drivers/gpu/drm/
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/drm_sysfs.c | 10 +-
1 file changed, 5 insert
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/lima/lima_drv.c | 8
1 file changed, 4 insert
It should not be possible for every user to override the EDID.
Limit it to the system administrator.
Fixes: 8ef8cc4fca4a ("staging: udlfb: support for writing backup EDID to sysfs
file")
Cc: sta...@vger.kernel.org
Signed-off-by: Thomas Weißschuh
---
The EDID passed through sysfs is on
The sysfs core now provides callback variants that explicitly take a
const pointer. Make use of it to match the attribute definitions.
Signed-off-by: Thomas Weißschuh
---
drivers/video/fbdev/aty/radeon_base.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
The sysfs core now provides callback variants that explicitly take a
const pointer. Make use of it to match the attribute definition.
Signed-off-by: Thomas Weißschuh
---
drivers/video/fbdev/udlfb.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev
On 2024-12-03 11:06:16-0500, James Bottomley wrote:
> > diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> > index
> > d17c473c1ef292875475bf3bdf62d07241c13882..d713a6445a6267145a7014f308d
> > f3bb25b8c3287 100644
> > --- a/include/linux/sysfs.h
> > +++ b/include/linux/sysfs.h
> > @@ -305
On 2024-12-03 08:58:26-0500, James Bottomley wrote:
> On Tue, 2024-12-03 at 21:02 +0800, Zijun Hu wrote:
> > On 2024/12/3 20:41, Greg Kroah-Hartman wrote:
> > > On Tue, Dec 03, 2024 at 08:23:45PM +0800, Zijun Hu wrote:
> [...]
> > > > or squash such patch series into a single patch ?
> > > >
> > >
The custom "struct dc_edid" can be replaced by the standard "struct
drm_edid.
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
---
dr
Now that a struct drm_edid is available make use of the standard
drm_edid_get_panel_id().
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display
The callers of dc_link_add_remote_sink() are using 'struct edid' which
they all need to cast to uint8_t *.
Allow the direct passing of 'struct edid' to avoid these cast and also
move the length calculation so it does not need to be duplicated
everywhere.
Signed-off-
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
--
.
Patches 1 and 2 delete some dead code.
The remaining patches perform the actual conversion in steps.
If some patches are already acceptable as they are, I'd be happy for
those to be picked up from the series.
Signed-off-by: Thomas Weißschuh
---
Changes in v2:
- Remove a wrong kfree(struc
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
-
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Now that all callers of dc_link_add_remote_sink() have access to a
validate struct drm_edid, pass it around directly.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgp
All usages of these fields have been removed.
Fixes: 7c7f5b15be65 ("drm/amd/display: Refactor edid read.")
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/dc/dc_ddc_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_ddc_
The prototype is the whole content of commit
575d0df6dae4 ("drm/amd/display: refine the EDID override").
Apparently the definition was never added.
Fixes: 575d0df6dae4 ("drm/amd/display: refine the EDID override")
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/dis
uot;
sysfs file has not shown any negative impact.
One quirk seems to be that 0% at panel_power_savings=0 seems to be
slightly darker than at panel_power_savings=4.
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
Reviewed-by: Mario Limonciello
Reviewed-by: Harry Wentland
---
drive
From: "Dustin L. Howett"
I have tested these panels on the Framework Laptop 13 AMD with firmware
revision 3.05 (latest at time of submission).
Signed-off-by: Dustin L. Howett
Signed-off-by: Thomas Weißschuh
Reviewed-by: Mario Limonciello
Reviewed-by: Harry Wentland
---
drive
panels.
Add a quirk infrastructure with which the minimum valid backlight value
can be maintained as part of the kernel.
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
Reviewed-by: Mario Limonciello
Reviewed-by: Harry Wentland
---
Documentation/gpu/drm-kms-helpers.rst| 3
isible.
Tested on a Framework AMD 13 BIOS 3.05 with the matte panel.
Link: https://community.frame.work/t/25711/9
Link: https://community.frame.work/t/47036
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
Reviewed-by: Mario Limonciello
Reviewed-by: Harry Wentland
---
drivers/gpu/dr
tte panel
- Link to v1:
https://lore.kernel.org/r/20240610-amdgpu-min-backlight-quirk-v1-1-8459895a5...@weissschuh.net
---
Dustin L. Howett (1):
drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels
Thomas Weißschuh (3):
drm: Add panel backlight quirks
drm/am
Stop abusing the is_bin_visible() callback to calculate the attribute
size. Instead use the new, dedicated bin_size() one.
Signed-off-by: Thomas Weißschuh
---
drivers/pci/pci-sysfs.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/pci
As preparation for the constification of struct bin_attribute,
constify the arguments of the read and write callbacks.
Signed-off-by: Thomas Weißschuh
---
drivers/base/node.c | 4 ++--
drivers/base/topology.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
churn during the transition.
As soon as all handlers are switch to the const variant, the non-const
one can be removed together with the transition machinery.
Signed-off-by: Thomas Weißschuh
---
fs/sysfs/file.c | 22 +-
include/linux/sysfs.h | 25 +++--
2
Upcoming changes to the sysfs core require the size of the created file
to be overridable by the caller.
Add a parameter to enable this.
For now keep using attr->size in all cases.
Signed-off-by: Thomas Weißschuh
---
fs/sysfs/file.c | 8
fs/sysfs/group.c | 3 ++-
fs/sysfs/sysfs.h
The llseek() callbacks should not modify the struct
bin_attribute passed as argument.
Enforce this by marking the argument as const.
As there are not many callback implementers perform this change
throughout the tree at once.
Signed-off-by: Thomas Weißschuh
---
drivers/pci/pci-sysfs.c | 2
ibutes.
This series is intended to be merged through the driver core tree.
Signed-off-by: Thomas Weißschuh
---
Changes in v2:
- Drop RFC state
- Refuse registration of attributes with both read/read_new or
write/write_new
- Remove don't drop llseek() callback, as it is actually used.
I
The mmap() callbacks should not modify the struct
bin_attribute passed as argument.
Enforce this by marking the argument as const.
As there are not many callback implementers perform this change
throughout the tree at once.
Signed-off-by: Thomas Weißschuh
---
arch/alpha/kernel/pci-sysfs.c
Stop abusing the is_bin_visible() callback to calculate the attribute
size. Instead use the new, dedicated bin_size() one.
Signed-off-by: Thomas Weißschuh
---
drivers/nvmem/core.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers
The preparations for the upcoming constification of struct bin_attribute
requires some logic in the structure definition macros.
To avoid duplication of that logic in multiple macros, reimplement all
other macros in terms of __BIN_ATTR().
Signed-off-by: Thomas Weißschuh
---
include/linux
ize field.
* It prevents the structure to be moved to read-only memory.
Introduce a new dedicated callback to calculate the size of the
attribute.
Signed-off-by: Thomas Weißschuh
---
fs/sysfs/group.c | 2 ++
include/linux/sysfs.h | 8
2 files changed, 10 insertions(+)
diff --git a
The is_bin_visible() callbacks should not modify the struct
bin_attribute passed as argument.
Enforce this by marking the argument as const.
As there are not many callback implementers perform this change
throughout the tree at once.
Signed-off-by: Thomas Weißschuh
---
drivers/cxl/port.c
On 2024-09-16 15:43:35-0400, Harry Wentland wrote:
> On 2024-08-26 12:57, Mario Limonciello wrote:
> > On 8/24/2024 13:33, Thomas Weißschuh wrote:
> >> Not all platforms provide the full range of PWM backlight capabilities
> >> supported by the hardware through ATIF.
>
Hi Harry, Leo and other amdgpu maintainers,
On 2024-08-24 20:33:53+, Thomas Weißschuh wrote:
> The value of "min_input_signal" returned from ATIF on a Framework AMD 13
> is "12". This leads to a fairly bright minimum display backlight.
>
> Introduce a quirk t
On 2024-08-30 12:16:46+, Helge Deller wrote:
> On 8/30/24 11:45, Thomas Weißschuh wrote:
> > Introduce a device-managed variant of register_framebuffer() which
> > automatically unregisters the framebuffer on device destruction.
> > This can simplify the error handling an
Introduce a device-managed variant of register_framebuffer() which
automatically unregisters the framebuffer on device destruction.
This can simplify the error handling and resource management in drivers.
Signed-off-by: Thomas Weißschuh
---
This is a fixed resend of [0], which was broken.
Thanks
Hi everybody,
On 2024-08-27 17:25:14+, Thomas Weißschuh wrote:
> Introduce a device-managed variant of register_framebuffer() which
> automatically unregisters the framebuffer on device destruction.
> This can simplify the error handling and resource management in drivers.
Bert repo
On 2024-08-28 19:42:51+, Helge Deller wrote:
> On 8/27/24 17:25, Thomas Weißschuh wrote:
> > These variables are only used inside efifb_probe().
> > Afterwards they are using memory unnecessarily.
>
> Did you check if this change really saves some memory?
Nope...
&g
The driver core can register and cleanup sysfs groups already.
Make use of that functionality to simplify the error handling and
cleanup.
Also avoid a UAF race during unregistering where the sysctl attributes
were usable after the info struct was freed.
Signed-off-by: Thomas Weißschuh
Since commit b9cfd1d271ab ("fbdev/efifb: Use screen_info pointer from device")
efifb uses a local copy of screen_info and applies its modifications
there. Adapt the sysfs attributes to also work with the custom copy
instead of the unmodified platform data.
Signed-off-by: Thomas
These variables are only used inside efifb_probe().
Afterwards they are using memory unnecessarily.
Signed-off-by: Thomas Weißschuh
---
drivers/video/fbdev/efifb.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/video/fbdev
Introduce a device-managed variant of register_framebuffer() which
automatically unregisters the framebuffer on device destruction.
This can simplify the error handling and resource management in drivers.
Signed-off-by: Thomas Weißschuh
---
drivers/video/fbdev/core/fbmem.c | 24
This simplifies the error handling.
Also the drvdata slot is now unused and can be used for other usecases.
Signed-off-by: Thomas Weißschuh
---
drivers/video/fbdev/efifb.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers
Some random optimization and fixes I came up with while looking at
efifb.c.
I can't get the efifb driver to probe on my hardware,
so this is only compile-tested.
If somebody could actually test it, that would be great.
Signed-off-by: Thomas Weißschuh
---
Thomas Weißschuh (5):
fbdev/
uot;
sysfs file has not shown any negative impact.
One quirk seems to be that 0% at panel_power_savings=0 seems to be
slightly darker than at panel_power_savings=4.
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdg
isible.
Tested on a Framework AMD 13 BIOS 3.05 with the matte panel.
Link: https://community.frame.work/t/25711/9
Link: https://community.frame.work/t/47036
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/drm_panel_backlight_quirks.
ucture
- Quirk by EDID and DMI instead of only DMI
- Limit quirk to only single Framework 13 matte panel
- Link to v1:
https://lore.kernel.org/r/20240610-amdgpu-min-backlight-quirk-v1-1-8459895a5...@weissschuh.net
---
Dustin L. Howett (1):
drm: panel-backlight-quirks: Add Framework 13 gloss
From: "Dustin L. Howett"
I have tested these panels on the Framework Laptop 13 AMD with firmware
revision 3.05 (latest at time of submission).
Signed-off-by: Dustin L. Howett
Signed-off-by: Thomas Weißschuh
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/drm_panel_backlight_qui
panels.
Add a quirk infrastructure with which the minimum valid backlight value
can be maintained as part of the kernel.
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
Reviewed-by: Mario Limonciello
---
Documentation/gpu/drm-kms-helpers.rst| 3 ++
drivers/gpu/drm/Kconfig
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
---
On 2024-08-21 15:54:14+, Mario Limonciello wrote:
> On 8/18/2024 01:56, Thomas Weißschuh wrote:
> > Not all platforms provide correct PWM backlight capabilities through ATIF.
>
> I don't think correct is an accurate term here. How about 'optimial'?
Looks typ
On 2024-08-21 15:51:17+, Mario Limonciello wrote:
> On 8/18/2024 01:56, Thomas Weißschuh wrote:
> > Panels using a PWM-controlled backlight source do not have a standard
> > way to communicate their valid PWM ranges.
> > On x86 the ranges are read from ACPI through d
Hi Mario,
(+ a question for Dustin inside)
On 2024-08-21 15:45:46+, Mario Limonciello wrote:
> On 8/18/2024 01:56, Thomas Weißschuh wrote:
> > The value of "min_input_signal" returned from ATIF on a Framework AMD 13
> > is "12". This leads to a fair
Hi Melissa,
On 2024-08-19 11:31:44+, Melissa Wen wrote:
> On 08/18, Thomas Weißschuh wrote:
> > The AMD DRM drivers use 'struct edid', raw pointers and even custom
> > structs to represent EDID data.
> > Uniformly switch to the safe and recommended "str
On 2024-08-19 11:51:45+, Jani Nikula wrote:
> On Sun, 18 Aug 2024, Thomas Weißschuh wrote:
> > "struct drm_edid" is the safe and recommended alternative to "struct edid".
> >
> > Rename the member to make sure that no usage sites are missed,
> >
On 2024-08-19 11:21:21+, Jani Nikula wrote:
> On Sun, 18 Aug 2024, Thomas Weißschuh wrote:
> > drm_edid_is_valid() does not modify its argument, so mark it as const.
>
> That's not true.
Indeed, thanks for noticing.
It turns out this patch is not necessary anyways and
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
-
The callers of dc_link_add_remote_sink() are using 'struct edid' which
they all need to cast to uint8_t *.
Allow the direct passing of 'struct edid' to avoid these cast and also
move the length calculation so it does not need to be duplicated
everywhere.
Signed-off-
The argument edid is passed in as const.
Preserve this constness through the edid_buf variable and the used
helper functions.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
The custom "struct dc_edid" can be replaced by the standard "struct
drm_edid.
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
---
dr
Reduce the number of casts needed by reusing the edid_buf variable.
Also initialize edid_buf after the !edid case has been handled to avoid
the ternary expression.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 8 +---
1 file changed, 5
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
-
drm_edid_is_valid() does not modify its argument, so mark it as const.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/drm_edid.c | 2 +-
include/drm/drm_edid.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
The parsing functions do not modify their edid argument.
Mark the const to reflect this to the caller.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +-
2 files changed, 8
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Now that all callers of dc_link_add_remote_sink() have access to a
validate struct drm_edid, pass it around directly.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgp
"struct drm_edid" is the safe and recommended alternative to "struct edid".
Rename the member to make sure that no usage sites are missed,
as "struct drm_edid" has some restrictions, for example it can not be
used with kfree().
Signed-off-by: Thomas Weißschuh
--
As struct drm_edid is opaque, drivers can't directly memcmp() the
contained data. Add a helper to provide this functionality.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/drm_edid.c | 18 ++
include/drm/drm_edid.h | 1 +
2 files changed, 19 insertions(+)
diff
The prototype is the whole content of commit
575d0df6dae4 ("drm/amd/display: refine the EDID override").
Apparently the definition was never added.
Fixes: 575d0df6dae4 ("drm/amd/display: refine the EDID override")
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/dis
All usages of these fields have been removed.
Fixes: 7c7f5b15be65 ("drm/amd/display: Refactor edid read.")
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/dc/dc_ddc_types.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_ddc_
around some code.
The remaining patches perform the actual conversion in steps.
[0]
https://lore.kernel.org/lkml/20240818-amdgpu-min-backlight-quirk-v5-0-b6c0ead0c...@weissschuh.net/
Signed-off-by: Thomas Weißschuh
---
Thomas Weißschuh (12):
drm/amd/display: remove spurious definition for
d
panels.
Add a quirk infrastructure with which the minimum valid backlight value
can be maintained as part of the kernel.
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
---
Documentation/gpu/drm-kms-helpers.rst| 3 ++
drivers/gpu/drm/Kconfig | 4
Not all platforms provide correct PWM backlight capabilities through ATIF.
Use the generic drm panel minimum backlight quirk infrastructure to
override the capabilities where necessary.
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
---
drivers/gpu/drm/amd/amdgpu/Kconfig
isible.
Tested on a Framework AMD 13 BIOS 3.05 with the matte panel.
Link: https://community.frame.work/t/25711/9
Link: https://community.frame.work/t/47036
Signed-off-by: Thomas Weißschuh
Tested-by: Dustin L. Howett
---
drivers/gpu/drm/drm_panel_backlight_quirks.c | 8
1 file changed,
From: "Dustin L. Howett"
I have tested these panels on the Framework Laptop 13 AMD with firmware
revision 3.05 (latest at time of submission).
Signed-off-by: Dustin L. Howett
---
drivers/gpu/drm/drm_panel_backlight_quirks.c | 16
1 file changed, 16 insertions(+)
diff --git a/
net
---
Dustin L. Howett (1):
drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels
Thomas Weißschuh (3):
drm: Add panel backlight quirks
drm/amd/display: Add support for minimum backlight quirk
drm: panel-backlight-quirks: Add Framework 13 matte panel
Hi Dustin,
On 2024-08-17 14:23:42+, Dustin Howett wrote:
> On Sat, Aug 17, 2024 at 1:59 PM Dustin L. Howett wrote:
> >
> > This patch depends on
> > 20240812-amdgpu-min-backlight-quirk-v4-0-56a63ff89...@weissschuh.net
> >
> > I have tested these panels on the Framework Laptop 13 AMD with firm
isible.
Tested on a Framework AMD 13 BIOS 3.05 with the matte panel.
Link: https://community.frame.work/t/25711/9
Link: https://community.frame.work/t/47036
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/drm_panel_backlight_quirks.c | 8
1 file changed, 8 insertions(+)
with newer panels.
Add a quirk infrastructure with which the minimum valid backlight value
can be maintained as part of the kernel.
Signed-off-by: Thomas Weißschuh
---
Documentation/gpu/drm-kms-helpers.rst| 3 ++
drivers/gpu/drm/Kconfig | 4 ++
drivers/gpu/drm
Not all platforms provide correct PWM backlight capabilities through ATIF.
Use the generic drm panel minimum backlight quirk infrastructure to
override the capabilities where necessary.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/amdgpu/Kconfig| 1 +
drivers/gpu/drm
mdgpu-min-backlight-quirk-v1-1-8459895a5...@weissschuh.net
---
Thomas Weißschuh (3):
drm: Add panel backlight quirks
drm: panel-backlight-quirks: Add Framework 13 matte panel
drm/amd/display: Add support for minimum backlight quirk
Documentation/gpu/drm-kms-helpers.rst
On 2024-08-10 15:30:58+, Aditya Garg wrote:
>
> >
> > Also include linux/device.h as you are using functions from there.
> > Like devm_kcalloc().
>
> Alright, I’ll add that
> >
> >>>
> +#include
> +#include
> +
> +#include "hid-ids.h"
> +
> +#define APPLETB_
On 2024-08-10 13:23:30+, Aditya Garg wrote:
> Hi Thomas
>
> >> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> >> index e40f1ddeb..1d825a474 100644
> >> --- a/drivers/hid/Makefile
> >> +++ b/drivers/hid/Makefile
> >> @@ -29,6 +29,7 @@ obj-$(CONFIG_HID_ALPS) += hid-alps.o
> >> obj-$(
On 2024-08-08 13:50:33+, Aditya Garg wrote:
> From: Kerem Karabay
>
> This commit adds a driver for the backlight of Apple Touch Bars on x86
> Macs. Note that currently only T2 Macs are supported.
>
> This driver is based on previous work done by Ronald Tschalär
> .
>
> Signed-off-by: Kerem
Hi,
On 2024-08-01 10:52:55+, Hans de Goede wrote:
> On 7/31/24 10:55 PM, Daniel Vetter wrote:
> > On Wed, Jul 31, 2024 at 08:40:12PM +0300, Jani Nikula wrote:
> >> On Wed, 31 Jul 2024, Thomas Weißschuh wrote:
> >>> The value of "min_input_signal"
I
- Limit quirk to only single Framework 13 matte panel
- Link to v1:
https://lore.kernel.org/r/20240610-amdgpu-min-backlight-quirk-v1-1-8459895a5...@weissschuh.net
---
Thomas Weißschuh (2):
drm/connector: add drm_connector_get_cmdline_min_brightness_override()
drm/amd/display: impleme
This is useful if the minimum backlight as reported by machines VBT
does not match the user expectations.
As an example, the minimum backlight brightness on the Framework 13
matte panel is too high.
Signed-off-by: Thomas Weißschuh
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6
1 - 100 of 128 matches
Mail list logo
