Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Thomas Preston
On 07/03/2019 10:34, Jani Nikula wrote: There are dangers with default VBTs too. They might contain incorrect information about the specific board you have. You'll also have to set up the opregion, not just VBT. I'm afraid I can't help you there. You already know where to look to see how the ker

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Thomas Preston
On 07/03/2019 10:34, Jani Nikula wrote: On Wed, 06 Mar 2019, Thomas Preston wrote: We rely on VBT DDI port info for eDP detection on GEN9 platforms and above. This breaks GEN9 platforms which don't have VBT because port A eDP now defaults to false. Fix this by defaulting to true when V

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Thomas Preston
Hi, Thanks for looking at this. On 07/03/2019 08:18, Jani Nikula wrote: The subject should probably have "drm/i915/bios" or "drm/i915/vbt". Noted On Wed, 06 Mar 2019, Thomas Preston wrote: We rely on VBT DDI port info for eDP detection on GEN9 platforms and abo

[PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-06 Thread Thomas Preston
fo for eDP detection") Signed-off-by: Thomas Preston --- drivers/gpu/drm/i915/intel_bios.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index 1faa494e2bc9..efbbfb64b55f 100644 --- a/drivers/gpu/drm/i915/intel_bios.