[PATCH] drm/omap: Make sure device_id tables are NULL terminated

2019-05-27 Thread Thomas Meyer
Make sure (of/i2c/platform)_device_id tables are NULL terminated. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c --- a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c +++ b/drivers/gpu/drm/omapdrm

[no subject]

2019-05-27 Thread Thomas Meyer
t; X-Serial-No: 1 Make sure (of/i2c/platform)_device_id tables are NULL terminated. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c --- a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c +++ b/drivers

[PATCH] drm/amdgpu: NULL check before some freeing functions is not needed.

2018-12-03 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c @@ -816,6

radeon_get_bios: BUG: unable to handle kernel paging request

2017-09-24 Thread Thomas Meyer
Hi, while trying to resurrect my old Macbook as an 32 bit kernel testing device, I think someone broke the radeon driver on this first generation pure EFI boot Macbook. My guess would be that the introduction of the vga_switcheroo code did break the radeon_get_bios functionality. I will try agai

[PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

2017-09-22 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c --- a/drivers/gpu/dr

[PATCH 1/4] drm/amd/powerplay: Cocci spatch "alloc_cast"

2017-09-22 Thread Thomas Meyer
Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." Found by coccinelle spatch "api/alloc/alloc_cast.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_proce

[PATCH 2/10] drm/amdgpu: Use ARRAY_SIZE macro

2017-09-03 Thread Thomas Meyer
k/verification. Signed-off-by: Thomas Meyer --- diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c index 9804318f3488..7ef84d884714 100644 --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c @@ -20,6 +20,8 @@ *

[PATCH 3/10] drm/i915/gvt: Use ARRAY_SIZE macro

2017-09-03 Thread Thomas Meyer
k/verification. Signed-off-by: Thomas Meyer --- diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c index 3deadcbd5a24..7d8035093a1e 100644 --- a/drivers/gpu/drm/i915/gvt/vgpu.c +++ b/drivers/gpu/drm/i915/gvt/vgpu.c @@ -30,6 +30,7 @@ *Bing Niu * */ +#include #

[PATCH 4/10] drm/nouveau/bios/init: Use ARRAY_SIZE macro

2017-09-03 Thread Thomas Meyer
k/verification. Signed-off-by: Thomas Meyer --- diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c index b58ee99f7bfc..440efa333d6c 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c +++ b/drivers/gpu/drm/nouveau/nvkm/sub

[4.0.0-rc3-24042-g5fb0f7fa] BUG: NULL pointer dereference in DRM

2015-03-25 Thread Thomas Meyer
Am Sonntag, den 22.03.2015, 17:46 +0100 schrieb Thomas Meyer: > Hi, > another hard lock-up of the graphic system. this time with 4.0.0-rc4-24381-gb314aca I previously did use the Fedora default kernel, i.e. 3.18.x. with those I didn't encounter these kind of lock-ups. Mär

[UDL] NULL pointer dereference in udl_driver_unload->drm_vblank_cleanup

2014-12-08 Thread Thomas Meyer
Dez 08 22:21:08 localhost.localdomain kernel: Restarting tasks ... done. Dez 08 22:21:08 localhost.localdomain kernel: video LNXVIDEO:00: Restoring backlight state Dez 08 22:21:08 localhost.localdomain kernel: BUG: unable to handle kernel NULL pointer dereference at (null) Dez 08 22:21:

[PATCH] Fix SIGSEGV in libdrm for heigth = 0 and width = 0

2014-11-07 Thread Thomas Meyer
drm_intel_gem_bo_free() crashes because the list bo_gem->vma_list is not yet initialised, but the error path tries to free it. See also https://bugs.freedesktop.org/show_bug.cgi?id=75844 Reviewed-by: Chris Wilson Signed-off-by: Thomas Meyer --- diff --git a/intel/intel_bufmgr_gem.c b/in

[i915] BUG: Bad page state in process Xorg

2013-12-04 Thread Thomas Meyer
Am Samstag, den 30.11.2013, 08:55 -0500 schrieb Rob Clark: > On Sat, Nov 30, 2013 at 3:33 AM, Thomas Meyer wrote: > > Am Montag, den 25.11.2013, 08:23 -0500 schrieb Rob Clark: > >> oh, hmm.. are you importing buffers from i915? It looks like this part: > > > > M

[i915] BUG: Bad page state in process Xorg

2013-11-30 Thread Thomas Meyer
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/udl?id=5dc9e1e87229cb786a5bb58ddd0d60fee6eb4641 > > > > With kind regards > > Thomas > > > > Am 22.11.2013 17:18 schrieb Daniel Vetter : > >> > >> On Fri, Nov 22, 2013 at

[i915] BUG: Bad page state in process Xorg

2013-11-22 Thread Thomas Meyer
> Am 22.11.2013 um 11:55 schrieb Chris Wilson : > >> On Wed, Nov 20, 2013 at 09:55:28PM +0100, Thomas Meyer wrote: >> Hi, >> >> I reported this bug a few days ago, but nobody did respond to my bug >> report: >> http://lkml.indiana.edu/hypermail/linux/

[i915] BUG: Bad page state in process Xorg

2013-11-22 Thread Thomas Meyer
> Am 22.11.2013 um 11:55 schrieb Daniel Vetter : > > On Fri, Nov 22, 2013 at 11:36 AM, Dave Airlie wrote: >>> Hi, >> >> cc'ing mailing list, >> >> Daniel any ideas? > > Nope, not really :( And no ideas how to triage this further - if it > takes 9 days to hit it eventually we'll have a real h

[PATCH] drm/msm: Odd PTR_ERR usage

2013-09-17 Thread Thomas Meyer
The variable priv->kms is not initialized yet. Found by "scripts/coccinelle/tests/odd_ptr_err.cocci". PTR_ERR should access the value just tested by IS_ERR. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c --- a/driver

[PATCH] drm/prime: Cocci spatch "err_cast.spatch"

2013-06-02 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -277,7 +277,7 @@ struct drm_gem_object *drm_gem_prime_imp attach = dma_buf_attach(dma_buf, dev->

[PATCH] drm/cma: Cocci spatch "ptr_ret.spatch"

2013-06-02 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c --- a/drivers/gpu/drm/drm_gem_cma_helper.c +++ b/drivers/gpu/drm/drm_gem_cma_helper.c @@ -174,10 +174,7 @@ int drm_gem_cma_dumb_create(struct drm_f cma_obj

[PATCH] dma-buf: Cocci spatch "ptr_ret.spatch"

2013-06-02 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c --- a/drivers/base/dma-buf.c +++ b/drivers/base/dma-buf.c @@ -680,10 +680,7 @@ int dma_buf_debugfs_create_file(const ch d = debugfs_create_file(name, S_IRUGO, dma_buf_debugfs_dir

[PATCH] drm/prime: Cocci spatch "err_cast.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c --- a/drivers/gpu/drm/drm_prime.c +++ b/drivers/gpu/drm/drm_prime.c @@ -277,7 +277,7 @@ struct drm_gem_object *drm_gem_prime_imp attach = dma_buf_attach(dma_buf, dev->dev);

[PATCH] drm/cma: Cocci spatch "ptr_ret.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c --- a/drivers/gpu/drm/drm_gem_cma_helper.c +++ b/drivers/gpu/drm/drm_gem_cma_helper.c @@ -174,10 +174,7 @@ int drm_gem_cma_dumb_create(struct drm_f cma_obj

[PATCH] dma-buf: Cocci spatch "ptr_ret.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c --- a/drivers/base/dma-buf.c +++ b/drivers/base/dma-buf.c @@ -680,10 +680,7 @@ int dma_buf_debugfs_create_file(const ch d = debugfs_create_file(name, S_IRUGO, dma_buf_debugfs_dir

[PATCH] drm/i915: Cocci spatch "memdup.spatch"

2013-05-22 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -2282,11 +2282,10 @@ intel_dp_get_edid(struct drm_connector * return NULL

[PATCH] drm: Cocci spatch "memdup.spatch"

2013-05-22 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c --- a/drivers/gpu/drm/drm_edid_load.c +++ b/drivers/gpu/drm/drm_edid_load.c @@ -186,12 +186,11 @@ static u8 *edid_load(struct drm_connecto goto relfw_out

[PATCH] drm/i915: Cocci spatch "memdup.spatch"

2013-05-22 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -2282,11 +2282,10 @@ intel_dp_get_edid(struct drm_connector * return NULL

[PATCH] drm: Cocci spatch "memdup.spatch"

2013-05-22 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c --- a/drivers/gpu/drm/drm_edid_load.c +++ b/drivers/gpu/drm/drm_edid_load.c @@ -186,12 +186,11 @@ static u8 *edid_load(struct drm_connecto goto relfw_out

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Thomas Meyer
My laptop is an Acer 1810T. I see this error message each boot. Kind regards Thomas Jiri Kosina schrieb: >On Fri, 15 Mar 2013, Jiri Kosina wrote: > >> > I have the same problem on my Lenovo T500. I think the graphics card is >> > involved. >> > >> > This laptop has "hybrid graphics" - one Inte

[3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-18 Thread Thomas Meyer
My laptop is an Acer 1810T. I see this error message each boot. Kind regards Thomas Jiri Kosina schrieb: >On Fri, 15 Mar 2013, Jiri Kosina wrote: > >> > I have the same problem on my Lenovo T500. I think the graphics card is >> > involved. >> > >> > This laptop has "hybrid graphics" - one Inte

[UDL] general protection fault in fb_deferred_io_mkwrite()

2012-08-18 Thread Thomas Meyer
Am Sonntag, den 12.08.2012, 14:22 -0700 schrieb Bernie Thompson: > On Sun, Aug 12, 2012 at 3:34 AM, Thomas Meyer wrote: > guilty driver is probably udl_fb.c > any ideas? > > > Hi Thomas, Hi Bernie! > We were seeing similar issues in udlfb (the original fb

Re: [UDL] general protection fault in fb_deferred_io_mkwrite()

2012-08-18 Thread Thomas Meyer
Am Sonntag, den 12.08.2012, 14:22 -0700 schrieb Bernie Thompson: > On Sun, Aug 12, 2012 at 3:34 AM, Thomas Meyer wrote: > guilty driver is probably udl_fb.c > any ideas? > > > Hi Thomas, Hi Bernie! > We were seeing similar issues in udlfb (the original fb

[UDL] general protection fault in fb_deferred_io_mkwrite()

2012-08-13 Thread Thomas Meyer
Hi, guilty driver is probably udl_fb.c any ideas? [ 42.890551] open /dev/fb1 user=1 fb_info=880130e0a800 count=1 [ 42.890585] released /dev/fb1 user=1 count=0 [ 42.890702] open /dev/fb1 user=1 fb_info=880130e0a800 count=1 [ 43.053034] type=1400 audit(1344698343.496:9): avc: denie

[UDL] general protection fault in fb_deferred_io_mkwrite()

2012-08-12 Thread Thomas Meyer
Hi, guilty driver is probably udl_fb.c any ideas? [ 42.890551] open /dev/fb1 user=1 fb_info=880130e0a800 count=1 [ 42.890585] released /dev/fb1 user=1 count=0 [ 42.890702] open /dev/fb1 user=1 fb_info=880130e0a800 count=1 [ 43.053034] type=1400 audit(1344698343.496:9): avc: denie

[PATCH] nouveau: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(.. [1]

2012-08-08 Thread Thomas Meyer
The semantic patch that makes this change is available in scripts/coccinelle/api/err_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau

[PATCH] drm/udl: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(.. [1]

2012-08-08 Thread Thomas Meyer
The semantic patch that makes this change is available in scripts/coccinelle/api/err_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c --- a

[PATCH] drm/exynos: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(.. [1]

2012-08-08 Thread Thomas Meyer
The semantic patch that makes this change is available in scripts/coccinelle/api/err_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos

[PATCH] drm/exynos: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(.. [1]

2012-08-07 Thread Thomas Meyer
The semantic patch that makes this change is available in scripts/coccinelle/api/err_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos

[PATCH] nouveau: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(.. [1]

2012-08-07 Thread Thomas Meyer
The semantic patch that makes this change is available in scripts/coccinelle/api/err_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau

[PATCH] drm/udl: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(.. [1]

2012-08-07 Thread Thomas Meyer
The semantic patch that makes this change is available in scripts/coccinelle/api/err_cast.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c --- a

[PATCH] drm/i915: Use kcalloc instead of kzalloc to allocate array

2011-12-04 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas

[PATCH] vmwgfx: Use kcalloc instead of kzalloc to allocate array

2011-12-04 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas

[PATCH] drm/radeon: Use kcalloc instead of kzalloc to allocate array

2011-12-04 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas

[PATCH] drm: Use kcalloc instead of kzalloc to allocate array

2011-12-04 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas

[PATCH] drm: Use kcalloc instead of kzalloc to allocate array

2011-11-29 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas

[PATCH] drm/radeon: Use kcalloc instead of kzalloc to allocate array

2011-11-29 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas

[PATCH] vmwgfx: Use kcalloc instead of kzalloc to allocate array

2011-11-29 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas

[PATCH] drm/i915: Use kcalloc instead of kzalloc to allocate array

2011-11-29 Thread Thomas Meyer
The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas

2.6.35-rc6+: i915: Bisected regression

2010-08-24 Thread Thomas Meyer
On Sunday 01 August 2010 17:17:54 Roberto Oppedisano wrote: > On 01/08/2010 15:14, Paul Rolland wrote: > > My machine has : > > 00:02.0 0300: 8086:2a42 (rev 07) > > 00:02.1 0380: 8086:2a43 (rev 07) > > > > 00:02.0 VGA compatible controller: Intel Corporation Mobile 4 Series > > Chipset Integrate

Re: 2.6.35-rc6+: i915: Bisected regression

2010-08-24 Thread Thomas Meyer
On Sunday 01 August 2010 17:17:54 Roberto Oppedisano wrote: > On 01/08/2010 15:14, Paul Rolland wrote: > > My machine has : > > 00:02.0 0300: 8086:2a42 (rev 07) > > 00:02.1 0380: 8086:2a43 (rev 07) > > > > 00:02.0 VGA compatible controller: Intel Corporation Mobile 4 Series > > Chipset Integrate

2.6.35-rc6+: i915: Bisected regression

2010-08-01 Thread Thomas Meyer
Am 01.08.2010 um 13:42 schrieb Stefan Richter : > Thomas Meyer wrote: >> This commit makes suspend to ram unreliable for me: >> >> commit d1b851fc0d105caa6b6e3e7c92d2987dfb52cbe0 >> Author: Zou Nan hai >> Date: Fri May 21 09:08:57 2010 +0800 >> >&

Re: 2.6.35-rc6+: i915: Bisected regression

2010-08-01 Thread Thomas Meyer
Am 01.08.2010 um 13:42 schrieb Stefan Richter : > Thomas Meyer wrote: >> This commit makes suspend to ram unreliable for me: >> >> commit d1b851fc0d105caa6b6e3e7c92d2987dfb52cbe0 >> Author: Zou Nan hai >> Date: Fri May 21 09:08:57 2010 +0800 >> >&