[PULL] drm-xe-fixes

Hi Dave, Simona The drm-xe-fixes PR for -rc4. Thanks, Thomas drm-xe-fixes-2025-06-26: UAPI Changes: Driver Changes: - Missing error check (Haoxiang Li) - Fix xe_hwmon_power_max_write (Karthik) - Move flushes (Maarten and Matthew Auld) - Explicitly exit CT safe mode on unwind (Michal) - Process d

[PULL] drm-xe-fixes

Hi Dave, Simona Three fixes for -rc3. There are a couple more pending with non-trivial merge conflicts that need to be properly backported. drm-xe-fixes-2025-06-19: Driver Changes: - A workaround update (Vinay) - Fix memset on iomem (Lucas) - Fix early wedge on GuC Load failure (Daniele) The fol

[PULL] drm-xe-fixes

Hi Dave, Simona Two fixes for 6.16-rc2. Thanks, Thomas drm-xe-fixes-2025-06-12: Driver Changes: - Fix regression disallowing 64K SVM migration (Maarten) - Use a bounce buffer for WA BB (Lucas) The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494: Linux 6.16-rc1 (2025-0

[PULL] drm-xe-next-fixes

Dave, Simona This week's drm-xe-next-fixes pull. Quite a few this week. One thing to be aware of is a conflict in "Create LRC bo without VM", Looks like a commit got pulled into drm-xe-fixes that is not in drm-xe-next-fixes, and pulling this branch will likely conflict with that once Linus merges

[PULL] drm-xe-next-fixes

Hi Dave, Simona Two documentation fixes this week. Thanks, Thomas drm-xe-next-fixes-2025-05-28: Driver Changes: - Two documentation fixes (Rodrigo) The following changes since commit 879ede53958f7bab79a8f77e0ca91f0f77da: drm/xe: Default auto_link_downgrade status to false (2025-05-23 09:

[PULL] drm-xe-next-fixes

Hi Dave, Simona This week's drm-xe-next-fixes PR. Two small fixes. Thanks Thomas drm-xe-next-fixes-2025-05-23: Driver Changes: - Fix a SLPC debugfs NULL pointer dereference (Aradhya) - Fix an arbitrary value sysfs read return (Aradhya) The following changes since commit 1faeeb315fdbd005bbc1bc742

[PULL] drm-xe-next

Hi Dave, Simona The probably last drm-xe-next PR towards 6.16. Almost only fixes, except for the PCIe link downgrade attributes. Thanks, Thomas drm-xe-next-2025-05-08: UAPI Changes: - Expose PCIe link downgrade attributes (Raag) Cross-subsystem Changes: Core Changes: - gpusvm has_dma_mapping f

[PULL] drm-xe-next

Hi Dave, Simona An additional drm-xe-next PR as requested on IRC. Take 2, This time with a normal-looking diffstat. A lot of fixes but some new stuff as detailed below. Please note that the top commit, "Drop force_alloc from xe_bo_evict in selftests" carries a Fixes tag that is not an ancestor

[PULL] drm-xe-next

Hi Dave, Simona The first drm-xe-next PR towards 6.16 Nothing major worth pointing out, a lot of work and improvents all over the drivers. There is a drm_gpusvm kernel-doc fix that touches core drm. Thanks, Thomas drm-xe-next-2025-04-17: Core Changes: Fix drm_gpusvm kernel-doc (Lucas) Driver Ch

[PULL] drm-xe-fixes

Hi Dave, Simona! Rodrigo is out this week, but sending a PR for a single fix. Thanks, Thomas drm-xe-fixes-2025-03-20: Driver Changes: - Fix for an error if exporting a dma-buf multiple time (Tomasz) The following changes since commit f5d4e81774c42d9c2ea3980e570f3330ff2ed5d2: drm/xe: remove re

[PULL] drm-xe-fixes

Hi Dave, Simona! The hopefully last drm-xe-fixes for 6.13 It's a little bigger than I was hoping for but nothing that really stands out. Thanks, Thomas drm-xe-fixes-2025-01-16: Driver Changes: - Add steering info support for GuC register lists (Jesus Narvaez) - Add means to wait for reset and sy

[PULL] drm-xe-fixes

Hi Dave, Simona Two fixes this week. Thanks, Thomas drm-xe-fixes-2025-01-09: Driver Changes: - Avoid a NULL ptr deref when wedging (Lucas) - Fix power gate sequence on DG1 (Rodrigo) The following changes since commit f0ed39830e6064d62f9c5393505677a26569bb56: xe/oa: Fix query mode of operation

[PULL] drm-xe-fixes

Hi Dave, Simona! Happy new year! This PR supersedes the one sent out 24-12-23, since that didn't seem to get pulled over the holidays. There's one extra commit (The OA fixes). The rest of the summary is repeated. Thanks, Thomas drm-xe-fixes-2025-01-02: This supersedes drm-xe-fixes-2024-12-23. U

[PULL] drm-xe-fixes

Hi Dave, Simona The Xe fixes for -rc5. Thanks, Thomas drm-xe-fixes-2024-12-23: UAPI Changes: - Revert some devcoredump file format changes breaking a mesa debug tool (John) Driver Changes: - Fixes around waits when moving to system (Nirmoy) - Fix a typo when checking for LMEM provisioning (Mi

[PULL] drm-xe-fixes

Dave, Simona This week'd drm-xe-fixes PR. Thanks, Thomas drm-xe-fixes-2024-12-12: - Fix a KUNIT test error message (Mirsad Todorovac) - Fix an invalidation fence PM ref leak (Daniele) - Fix a register pool UAF (Lucas) The following changes since commit 5dce85fecb87751ec94526e1ac516dd7871e2e0c:

[PULL] drm-xe-fixes

Hi Dave, Simona Two xe fixes for -rc2 Thanks, Thomas drm-xe-fixes-2024-12-04: Driver Changes: - Missing init value and 64-bit write-order check (Zhanjung) - Fix a memory allocation issue causing lockdep violation (John) The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37:

[PULL] drm-xe-next-fixes

Hi Dave, Simona An all-Matt drm-xe-next-fixes PR this week. Thanks, Thomas drm-xe-next-fixes-2024-11-28: Driver Changes: - Update xe2 graphics name string (Matt Roper) - Fix a couple of guc submit races (Matt Auld) - Fix pat index usage in migrate (Matt Auld) - Ensure non-cached migrate pagetabl

[PULL] drm-xe-next-fixes

Hi Dave, Simona A couple of fixes to drm-xe-next. I'm currently looking into as to why they are not CC'd stable and will ensure they get backported if needed. Thanks, Thomas drm-xe-next-fixes-2024-11-21: Driver Changes: - Wake up waiters after wait condition set to true (Nirmoy Das) - Mark the p

[PULL] drm-xe-next-fixes

Hi Dave, Simona A single NULL ptr deref fix this week. Thanks, Thomas drm-xe-next-fixes-2024-11-15: Driver Changes: - Fix a NULL pointer deref (Everest K.C.) The following changes since commit 56b70bf9ec460ad7d7d94dfb7a54a8829741e16e: Merge tag 'drm-misc-next-2024-11-08' of https://gitlab.f

[PULL] drm-xe-next

Hi, Dave, Simona This week's drm-xe-next pull request, including also the changes that we decided not to pull last week. Note that this PR introduces a run-time warning when flushing xe workqueues. That is fixed by the patch 746ae46c11137ba21f0c0c68f082a9d8c1222c78 currently present in drm-misc-f

[PULL] drm-xe-next

Hi, Dave & Simona, This week's drm-xe-next PR Thanks, Thomas drm-xe-next-2024-10-24: UAPI Changes: - Define and parse OA sync properties (Ashutosh) Driver Changes: - Add caller info to xe_gt_reset_async (Nirmoy) - A large forcewake rework / cleanup (Himal) - A g2h response timeout fix (Badal)

[PULL] drm-xe-next

Dave, Simona This week's -next PR. Note the implicit fencing uapi fix. Thanks, Thomas drm-xe-next-2024-10-17: UAPI Changes: - (Implicit) Fix the exec unnecessary implicit fencing (Matt Brost) Driver Changes: - Fix an inverted if statement (Colin) - Fixes around display d3cold vs non-d3cold runt

[PULL] drm-xe-next

Hi Dave & Simona First drm-xe-next pull request for 6.13 Thanks, Thomas drm-xe-next-2024-10-10: Cross-subsystem Changes: - Add drm_line_printer (Michal) Driver Changes: - Fix an UAF (Matt Auld) - Sanity check compression and coherency mode (Matt Auld) - Some PIC-ID work (Jani) - Use IS_ENABLED(

[PULL] drm-xe-fixes

Hi Dave and Sima Two small fixes this week. Thanks, Thomas drm-xe-fixes-2024-07-04: Driver Changes: - One copy/paste mistake fix. - One error path fix causing an error pointer dereference. The following changes since commit 22a40d14b572deb80c0648557f4bd502d7e83826: Linux 6.10-rc6 (2024-06-30

[PULL] drm-xe-fixes

Hi, Dave, Sima A single fix this week. Thanks, Thomas drm-xe-fixes-2024-06-20: Driver Changes: - Fix for invalid register access The following changes since commit 6ba59ff4227927d3a8530fc2973b80e94b54d58f: Linux 6.10-rc4 (2024-06-16 13:40:16 -0700) are available in the Git repository at:

[PULL] drm-xe-fixes

Hi Dave & Sima, This week's drm-xe-fixes PR. Except from the maintainer update, nothing major, really. The "drm/xe: move disable_c6 call" required some conflict resolution (both visible and silent) which was also reflected in a conflict with drm-next when building drm-tip. drm-xe-fixes-2024-06-1

[PULL] drm-xe-fixes

Dave and Sima, A single fix for a missing Local Memory Translation Table update for -rc3. Thanks, Thomas drm-xe-fixes-2024-06-04: Driver Changes: - drm/xe/pf: Update the LMTT when freeing VF GT config The following changes since commit 6c5cd0807c79eb4c0cda70b48f6be668a241d584: drm/xe: Proper

[PULL] drm-xe-fixes

Hi Dave, Sima The drm-xe-fixes for -rc2 Only three fixes so far. I'm holding back one additional fix to be able to sort out whether it's correct or need more work. drm-xe-fixes-2024-05-30: Driver Changes: - One pcode polling timeout change - One fix for deadlocks for faulting VMs - One error-pat

[PULL] drm-xe-next-fixes

Hi, Dave & Sima This weeks -next-fixes. Two fixes breifly described below. Driver Changes: - Use ordered WQ for G2H handler. (Matthew Brost) - Use flexible-array rather than zero-sized (Lucas De Marchi) Thanks, Thomas The following changes since commit 3bc8848bb7f7478e6806e4522b06b63f40a53e1e:

[PULL] drm-xe-next-fixes

Dave, Sima This week's small set of fixes for drm-next. drm-xe-next-fixes-2024-05-02: Driver Changes: - Fix for a backmerge going slightly wrong. - An UAF fix - Avoid a WA error on LNL. Thanks, Thomas The following changes since commit 4a56c0ed5aa0bcbe1f5f7d755fb1fe1ebf48ae9c: Merge tag 'amd

[PULL] drm-xe-next

Hi, Dave, Sima The main -next 6.10 pull request for the xe driver. I scanned through the patches and tried to provide a somewhat condensed log below. Nothing spectacular in the uAPI changes. Among other things there are some flags that are reinstated now that we have published UMD for them. Unfo

[PULL] drm-xe-fixes

Hi Dave, Sima A single error path fix for 6.8 final (-rc8). Thanks, Thomas drm-xe-fixes-2024-03-07: Driver Changes: - An error path fix. The following changes since commit 90d35da658da8cff0d4ecbb5113f5fac9d00eb72: Linux 6.8-rc7 (2024-03-03 13:02:52 -0800) are available in the Git repository

[PULL] drm-xe-fixes

Dave, Sima The xe fixes for -rc7. It's mostly uapi sanitizing and future-proofing, and a couple of driver fixes. drm-xe-fixes-2024-02-29: UAPI Changes: - A couple of tracepoint updates from Priyanka and Lucas. - Make sure BINDs are completed before accepting UNBINDs on LR vms. - Don't arbitrarily

[PULL] drm-xe-fixes

Hi, Dave Sima The Xe pull request for 6.8-rc6 The uAPI fixes / adjustments we've been discussing are starting to appear, and I will hopefully have the rest for next week's PR. In addition two driver fixes. drm-xe-fixes-2024-02-22: UAPI Changes: - Remove support for persistent exec_queues - Drop a

[PULL] drm-xe-fixes

Hi Dave, Sima! The xe fixes pull request for -rc5. drm-xe-fixes-2024-02-15: Driver Changes: - Fix an out-of-bounds shift. - Fix the display code thinking xe uses shmem - Fix a warning about index out-of-bound - Fix a clang-16 compilation warning Thanks, Thomas The following changes since commit

[PULL] drm-xe-fixes

Dave, Sima The drm-xe-fixes pull for -rc4. Thanks, Thomas drm-xe-fixes-2024-02-08: Driver Changes: - Fix a loop in an error path - Fix a missing dma-fence reference - Fix a retry path on userptr REMAP - Workaround for a false gcc warning - Fix missing map of the usm batch buffer in the migrate

[PULL] drm-xe-fixes

Hi Dave and Sima, The xe fixes for 6.8-rc2. drm-xe-fixes-2024-02-01: UAPI Changes: - Only allow a single user-fence per exec / bind. The reason for this clarification fix is a limitation in the implementation which can be lifted moving forward, if needed. Driver Changes: - A crash fix - A fi

[PULL] drm-xe-fixes

Hi, Dave, Sima The Xe fixes PR for 6.8-rc2. Thanks, Thomas. The following changes since commit 6613476e225e090cc9aad49be7fa504e290dd33d: Linux 6.8-rc1 (2024-01-21 14:11:32 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-fixes-202

[git-pull] vmwgfx-next

vmw_fifo_ping_host() drm/vmwgfx: Remove a few unused functions Thomas Hellstrom (2): drm/vmwgfx: Fix the refuse_dma mode when using guest-backed objects drm/vmwgfx: Refuse DMA operation when SEV encryption is active drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 3 +- drivers/gpu/drm/vmwgfx

Re: [PATCH v4 5/9] drm/ttm, drm/vmwgfx: Support huge TTM pagefaults

On Sun, 2020-03-01 at 21:49 +0800, Hillf Danton wrote: > On Thu, 20 Feb 2020 13:27:15 +0100 Thomas Hellstrom wrote: > > + > > +static vm_fault_t ttm_bo_vm_huge_fault(struct vm_fault *vmf, > > + enum page_entry_size pe_size) > > +{ > &g

Re: [PATCH 1/2] drm/vmwgfx: Drop preempt_disable() in vmw_fifo_ping_host()

RT. This has been reported in the bugzilla. > > It has been explained by Thomas Hellstrom that this > preempt_disable()ed > section is not required for correctness. > > Remove the preempt_disable() section. > Hi, Sebastian, I suppose there isn't something like a pree

Re: [PATCH v3 20/22] drm/vmwgfx: Convert to CRTC VBLANK callbacks

wgfx_stdu.c | 3 +++ > 6 files changed, 15 insertions(+), 9 deletions(-) > Acked-by: Thomas Hellstrom ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 1/2] mm: Add a vmf_insert_mixed_prot() function

On 12/12/19 9:48 AM, Thomas Hellström (VMware) wrote: > From: Thomas Hellstrom > > The TTM module today uses a hack to be able to set a different page > protection than struct vm_area_struct::vm_page_prot. To be able to do > this properly, add the needed vm functionality as vmf_in

Re: [PATCH] drm/vmwgfx: prevent memory leak in vmw_context_define

On 9/25/19 6:46 AM, Navid Emamdoost wrote: > In vmw_context_define if vmw_context_init fails the allocated resource > should be unreferenced. The goto label was fixed. > > Signed-off-by: Navid Emamdoost > --- > drivers/gpu/drm/vmwgfx/vmwgfx_context.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH] drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add

kely(ret != 0)) { > + kfree(cres); > goto out_invalid_key; > + } > > cres->state = VMW_CMDBUF_RES_ADD; > cres->res = vmw_resource_reference(res); Reviewed-by: Thomas Hellstrom Will be part of next vmwgfx-next pull. Thanks, Thomas _

Re: [PATCH v2] drm/vmwgfx: Call vmw_driver_{load,unload}() before registering device

On 12/10/19 1:43 PM, Thomas Zimmermann wrote: > The load/unload callbacks in struct drm_driver are deprecated. Remove > them and call functions explicitly. > > v2: > * remove accidental whitespace fix > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Thomas He

Re: [PATCH] drm/vmwgfx: Call vmw_driver_{load,unload}() before registering device

On 12/9/19 12:06 PM, Thomas Zimmermann wrote: > The load/unload callbacks in struct drm_driver are deprecated. Remove > them and call functions explicitly. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 44 + > 1 file changed, 38 ins

Re: [PATCH] drm/vmwgfx: Call vmw_driver_{load,unload}() before registering device

Hi, On 12/9/19 12:06 PM, Thomas Zimmermann wrote: > The load/unload callbacks in struct drm_driver are deprecated. Remove > them and call functions explicitly. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 44 +++ Hmm, which tree is this diff against? I g

Re: [PATCH] drm/vmwgfx: Replace deprecated PTR_RET

l_add(sw_context, vmw_view_sr, > + cmd->body.shaderResourceViewId); > > - return PTR_RET(vmw_view_id_val_add(sw_context, vmw_view_sr, > -cmd- > >body.shaderResourceViewId)); > + return PTR_ERR_OR_ZERO(ret); > } &g

Re: [PATCH v3 2/2] mm, drm/ttm: Fix vm page protection handling

Hi Michal, On Fri, 2019-12-06 at 11:30 +0100, Michal Hocko wrote: > On Fri 06-12-19 09:24:26, Thomas Hellström (VMware) wrote: > [...] > > @@ -283,11 +282,26 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct > > vm_fault *vmf, > > pfn = page_to_pfn(page); > > } > > >

Re: locking&resource refcounting for ttm_bo_kmap/dma_buf_vmap

On 11/20/19 1:24 PM, Christian König wrote: > Am 20.11.19 um 13:19 schrieb Daniel Vetter: >> On Wed, Nov 20, 2019 at 1:09 PM Daniel Vetter wrote: >>> On Wed, Nov 20, 2019 at 1:02 PM Christian König >>> wrote: > What am I missing? The assumption is that when you want to create a vmap of a

Re: [PATCH 10/15] drm/vmwgfx: Delete mmaping functions

dd a backlog item to revisit this. > > One more aside: The (un)map_dma_buf can't ever be called because > ->attach rejects everything. Might want to drop a BUG_ON(1) in there. > Same for ->detach. And this. > > Signed-off-by: Daniel Vetter > Cc: VMware Graphics

Re: [PATCH 3/5] drm/vmwgfx: drop DRM_AUTH for render ioctls

er realms. > > As of last commit, we're explicitly checking for authentication in the > only render ioctls which care about one. > > With those in place, the DRM_AUTH token serves no real purpose. Let's > drop it. > > Cc: VMware Graphics > Cc: Thomas Hellstrom

Re: [PATCH 2/5] drm/vmwgfx: check master authentication in surface_ref ioctls

r and b) unauthenticated - bailing out as result. > > Otherwise the usual isolation path kicks in and we're all good. > > v2: Reword commit message, since the isolation work has landed. > > Cc: VMware Graphics > Cc: Thomas Hellstrom > Signed-off-by: Emil Velikov > ---

Re: [PATCH 1/5] drm/vmwgfx: move the require_exist handling together

On 11/1/19 2:05 PM, Emil Velikov wrote: > From: Emil Velikov > > Move the render_client hunk for require_exist alongside the rest. > Keeping all the reasons why an existing object is needed, in a single > place makes it easier to follow. > > Cc: VMware Graphics > Cc: Th

Re: [PATCH 1/5] drm/vmwgfx: move the require_exist handling together

>> place makes it easier to follow. >> >> Cc: VMware Graphics >> Cc: Thomas Hellstrom >> Signed-off-by: Emil Velikov >> --- >> drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >

Re: [PATCH 1/3] dma_resv: prime lockdep annotations

an allocate mm! (Chris). Horrible worker hack out, clean > initcall solution in. > > v4: Annotate with __init (Rob Herring) > > Cc: Rob Herring > Cc: Alex Deucher > Cc: Christian König > Cc: Chris Wilson > Cc: Thomas Zimmermann > Cc: Rob Herring > Cc: Tomeu

Re: [PATCH] drm/ttm: move cpu_writers handling into vmwgfx v2

Hi, Christian, On 9/30/19 6:34 PM, Christian König wrote: > From: Christian König > > This feature is only used by vmwgfx and superflous for everybody else. > > v2: use vmw_buffer_object instead of vmw_user_bo. > > Signed-off-by: Christian König > --- I just sent out a patch based on this that

Re: Re-review? WAS [PATCH 2/7] drm/ttm: Remove explicit typecasts of vm_private_data

p on this. > > Thanks, > Christian. Sure, please do. We can sort out any merge problems later. Let me quickly fix the commit message of patch #3 since it doesn't reflect that we export more helpers, and I'll send out these two as a separate patchset. Thanks, Thomas > > Am 18.

Re-review? WAS [PATCH 2/7] drm/ttm: Remove explicit typecasts of vm_private_data

) wrote: > From: Thomas Hellstrom > > The explicit typcasts are meaningless, so remove them. > > Suggested-by: Matthew Wilcox > Signed-off-by: Thomas Hellstrom > --- > drivers/gpu/drm/ttm/ttm_bo_vm.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) &g

Re: [PATCH] drm/vmwgfx: Fix double free in vmw_recv_msg()

On Thu, 2019-08-15 at 09:38 +0100, Colin Ian King wrote: > On 15/08/2019 09:30, Dan Carpenter wrote: > > We recently added a kfree() after the end of the loop: > > > > if (retries == RETRIES) { > > kfree(reply); > > return -EINVAL; > > } > > > > There are two probl

Re: [PATCH 7/8] drm/vmwgfx: switch to own vma manager

On Thu, 2019-09-05 at 09:05 +0200, Gerd Hoffmann wrote: > Add struct drm_vma_offset_manager to vma_private, initialize it and > pass it to ttm_bo_device_init(). > > With this in place the last user of ttm's embedded vma offset manager > is gone and we can remove it (in a separate patch). > > Sign

[tip: x86/vmware] drm/vmwgfx: Update the backdoor call with support for new instructions

The following commit has been merged into the x86/vmware branch of tip: Commit-ID: 6abe3778cf5abd59b23b9037796f3eab8b7f1d98 Gitweb: https://git.kernel.org/tip/6abe3778cf5abd59b23b9037796f3eab8b7f1d98 Author:Thomas Hellstrom AuthorDate:Wed, 28 Aug 2019 10:03:52 +02:00

Re: [PATCH v4 12/17] drm/vmwgfx: switch driver from bo->resv to bo->base.resv

Still doesn't like this very much, but anyway Acked-by: Thomas Hellstrom On 8/2/19 7:22 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 8 drivers/gpu/drm/v

Re: [PATCH v2 00/18] drm/ttm: make ttm bo a gem bo subclass

Hi, Daniel, On 6/22/19 11:18 AM, Daniel Vetter wrote: Hi Thomas, On Sat, Jun 22, 2019 at 12:52 AM Thomas Hellstrom wrote: On 6/21/19 5:57 PM, Daniel Vetter wrote: On Fri, Jun 21, 2019 at 05:12:19PM +0200, Thomas Hellström (VMware) wrote: On 6/21/19 1:57 PM, Gerd Hoffmann wrote: Aargh

Re: [PATCH v2 00/18] drm/ttm: make ttm bo a gem bo subclass

Hi, Daniel, On 6/21/19 5:57 PM, Daniel Vetter wrote: On Fri, Jun 21, 2019 at 05:12:19PM +0200, Thomas Hellström (VMware) wrote: On 6/21/19 1:57 PM, Gerd Hoffmann wrote: Aargh. Please don't do this. Multiple reasons: 1) I think It's bad to dump all buffer object functionality we can possibly

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

On 6/18/19 3:27 PM, Daniel Vetter wrote: On Tue, Jun 18, 2019 at 03:08:01PM +0200, Thomas Hellstrom wrote: On 6/18/19 2:19 PM, Daniel Vetter wrote: On Tue, Jun 18, 2019 at 11:54:08AM +0100, Emil Velikov wrote: Hi Thomas, On 2019/06/18, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

On 6/18/19 12:54 PM, Emil Velikov wrote: Hi Thomas, On 2019/06/18, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom TTM provides a means to assign eviction priorities to buffer object. This means that all buffer objects with a lower priority will be evicted first on memory pressure

Re: [PATCH 1/4] drm/vmwgfx: Assign eviction priorities to resources

On 6/18/19 2:19 PM, Daniel Vetter wrote: On Tue, Jun 18, 2019 at 11:54:08AM +0100, Emil Velikov wrote: Hi Thomas, On 2019/06/18, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom TTM provides a means to assign eviction priorities to buffer object. This means that all buffer objects

Re: [PATCH] drm/ttm: move cpu_writers handling into vmwgfx

Hi, Christian, On Fri, 2019-06-14 at 14:58 +0200, Christian König wrote: > Thomas just a gentle ping on this. > > It's not that my live depends on this, but it would still be a nice > to > have cleanup. > > Thanks, > Christian. > I thought I had answered this, but I can't find it in my outgoi

Re: [PATCH v5 5/9] drm/ttm: TTM fault handler helpers

Hi! On Thu, 2019-06-13 at 12:25 +0800, Hillf Danton wrote: > Hello Thomas > > On Wed, 12 Jun 2019 08:42:39 +0200 Thomas Hellstrom wrote: > > From: Thomas Hellstrom > > > > With the vmwgfx dirty tracking, the default TTM fault handler is > > not > > compl

Re: [PATCH] drm/ttm: move cpu_writers handling into vmwgfx

Hi, Christian, This looks OK, although there are a couple of minor alterations needed in the vmwgfx driver: - We should operate on vmw_buffer_objects rather than on user_buffer_objects. - vmw_user_bo_verify_synccpu should move to the validate code. I can take care of that if it's ok with you. T

[PATCH v3] drm/vmwgfx: fix a warning due to missing dma_parms

d DRM driver for VMware Virtual GPU") Co-developed-by: Thomas Hellstrom Signed-off-by: Qian Cai Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_d

Re: [RESEND PATCH v2] drm/vmwgfx: fix a warning due to missing dma_parms

Reviewed-by: Thomas Hellstrom I'll just need to give this some more testing before queueing it on vmwgfx-fixes. Thanks, Thomas On Mon, 2019-06-03 at 16:44 -0400, Qian Cai wrote: > Booting up with DMA_API_DEBUG_SG=y generates a warning due to the > driver > forgot to

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

On Wed, 2019-05-29 at 09:50 +0200, Christian König wrote: > Am 28.05.19 um 19:23 schrieb Lendacky, Thomas: > > On 5/28/19 12:05 PM, Thomas Hellstrom wrote: > > > On 5/28/19 7:00 PM, Lendacky, Thomas wrote: > > > > On 5/28/19 11:32 AM, Koenig, Christian wrote: > >

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

On 5/28/19 7:00 PM, Lendacky, Thomas wrote: On 5/28/19 11:32 AM, Koenig, Christian wrote: Am 28.05.19 um 18:27 schrieb Thomas Hellstrom: On Tue, 2019-05-28 at 15:50 +, Lendacky, Thomas wrote: On 5/28/19 10:17 AM, Koenig, Christian wrote: Hi Thomas, Am 28.05.19 um 17:11 schrieb Thomas

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

On Tue, 2019-05-28 at 15:50 +, Lendacky, Thomas wrote: > On 5/28/19 10:17 AM, Koenig, Christian wrote: > > Hi Thomas, > > > > Am 28.05.19 um 17:11 schrieb Thomas Hellstrom: > > > Hi, Tom, > > > > > > Thanks for the reply. The question is not

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

Hi, Tom, Thanks for the reply. The question is not graphics specific, but lies in your answer further below: On 5/28/19 4:48 PM, Lendacky, Thomas wrote: On 5/28/19 2:31 AM, Thomas Hellstrom wrote: Hi, Tom, Could you shed some light on this? I don't have a lot of GPU knowledge, so l

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

Hi, Tom, Could you shed some light on this? Thanks, Thomas On 5/24/19 5:08 PM, Alex Deucher wrote: + Tom He's been looking into SEV as well. On Fri, May 24, 2019 at 8:30 AM Thomas Hellstrom wrote: On 5/24/19 2:03 PM, Koenig, Christian wrote: Am 24.05.19 um 12:37 schrieb Thomas Hell

Re: [PATCH 4/5] drm/vmwgfx: remove custom ioctl io encoding check

On 5/27/19 5:27 PM, Emil Velikov wrote: On 2019/05/27, Thomas Hellstrom wrote: On 5/27/19 2:35 PM, Emil Velikov wrote: Hi Thomas, On 2019/05/27, Thomas Hellstrom wrote: I think we might be talking past each other, let's take a step back: - as of previous patch, all of vmwgfx ioctls

Re: [PATCH 13/13] drm: allow render capable master with DRM_AUTH ioctls

On 5/27/19 3:16 PM, Daniel Vetter wrote: On Mon, May 27, 2019 at 02:39:18PM +0200, Thomas Hellstrom wrote: On 5/27/19 10:17 AM, Emil Velikov wrote: From: Emil Velikov There are cases (in mesa and applications) where one would open the primary node without properly authenticating the client

Re: [PATCH 4/5] drm/vmwgfx: remove custom ioctl io encoding check

On 5/27/19 2:35 PM, Emil Velikov wrote: Hi Thomas, On 2019/05/27, Thomas Hellstrom wrote: I think we might be talking past each other, let's take a step back: - as of previous patch, all of vmwgfx ioctls size is consistently handled by the core I don't think I follow you he

Re: [PATCH 13/13] drm: allow render capable master with DRM_AUTH ioctls

On 5/27/19 10:17 AM, Emil Velikov wrote: From: Emil Velikov There are cases (in mesa and applications) where one would open the primary node without properly authenticating the client. Sometimes we don't check if the authentication succeeds, but there's also cases we simply forget to do it. T

Re: [PATCH 4/5] drm/vmwgfx: remove custom ioctl io encoding check

Hi, Emil, On Mon, 2019-05-27 at 10:08 +0100, Emil Velikov wrote: > On 2019/05/25, Thomas Hellstrom wrote: > > On Sat, 2019-05-25 at 00:39 +0200, Thomas Hellström wrote: > > > Hi, Emil > > > > > > On Fri, 2019-05-24 at 16:26 +0100, Emil Velikov wrote: > >

Re: [PATCH 4/5] drm/vmwgfx: remove custom ioctl io encoding check

On Sat, 2019-05-25 at 00:39 +0200, Thomas Hellström wrote: > Hi, Emil > > On Fri, 2019-05-24 at 16:26 +0100, Emil Velikov wrote: > > On 2019/05/24, Thomas Hellstrom wrote: > > > On Fri, 2019-05-24 at 13:14 +0100, Emil Velikov wrote: > > > > On 2019/05/23,

Re: [PATCH 4/5] drm/vmwgfx: remove custom ioctl io encoding check

Hi, Emil On Fri, 2019-05-24 at 16:26 +0100, Emil Velikov wrote: > On 2019/05/24, Thomas Hellstrom wrote: > > On Fri, 2019-05-24 at 13:14 +0100, Emil Velikov wrote: > > > On 2019/05/23, Thomas Hellstrom wrote: > > > > Hi, Emil, > > > > > > > >

Re: [PATCH 4/5] drm/vmwgfx: remove custom ioctl io encoding check

On Fri, 2019-05-24 at 13:14 +0100, Emil Velikov wrote: > On 2019/05/23, Thomas Hellstrom wrote: > > Hi, Emil, > > > > On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Drop the custom ioctl io encoding c

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

On 5/24/19 2:03 PM, Koenig, Christian wrote: Am 24.05.19 um 12:37 schrieb Thomas Hellstrom: [CAUTION: External Email] On 5/24/19 12:18 PM, Koenig, Christian wrote: Am 24.05.19 um 11:55 schrieb Thomas Hellstrom: [CAUTION: External Email] On 5/24/19 11:11 AM, Thomas Hellstrom wrote: Hi

Re: [PATCH] drm/vmwgfx: fix a warning due to missing dma_parms

On Fri, 2019-05-24 at 08:19 +0200, Christoph Hellwig wrote: > On Thu, May 23, 2019 at 10:37:19PM -0400, Qian Cai wrote: > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > index bf6c3500d363..5c567b81174f 100644 > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

On 5/24/19 12:53 PM, Emil Velikov wrote: On 2019/05/24, Daniel Vetter wrote: On Fri, May 24, 2019 at 8:05 AM Thomas Hellstrom wrote: On Wed, 2019-05-22 at 21:09 +0200, Daniel Vetter wrote: On Wed, May 22, 2019 at 9:01 PM Thomas Hellstrom < thellst...@vmware.com> wrote: Hi, Emil,

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

On 5/24/19 12:18 PM, Koenig, Christian wrote: Am 24.05.19 um 11:55 schrieb Thomas Hellstrom: [CAUTION: External Email] On 5/24/19 11:11 AM, Thomas Hellstrom wrote: Hi, Christian, On 5/24/19 10:37 AM, Koenig, Christian wrote: Am 24.05.19 um 10:11 schrieb Thomas Hellström (VMware): [CAUTION

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

On 5/24/19 11:11 AM, Thomas Hellstrom wrote: Hi, Christian, On 5/24/19 10:37 AM, Koenig, Christian wrote: Am 24.05.19 um 10:11 schrieb Thomas Hellström (VMware): [CAUTION: External Email] From: Thomas Hellstrom With SEV encryption, all DMA memory must be marked decrypted (AKA "shared&

Re: [RFC PATCH] drm/ttm, drm/vmwgfx: Have TTM support AMD SEV encryption

Hi, Christian, On 5/24/19 10:37 AM, Koenig, Christian wrote: Am 24.05.19 um 10:11 schrieb Thomas Hellström (VMware): [CAUTION: External Email] From: Thomas Hellstrom With SEV encryption, all DMA memory must be marked decrypted (AKA "shared") for devices to be able to read it. In

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

On Wed, 2019-05-22 at 21:09 +0200, Daniel Vetter wrote: > On Wed, May 22, 2019 at 9:01 PM Thomas Hellstrom < > thellst...@vmware.com> wrote: > > Hi, Emil, > > > > On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > > > From: Emil Velikov > > >

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

ity. > > Cc: "VMware Graphics" > Cc: Thomas Hellstrom > Cc: Daniel Vetter > Signed-off-by: Emil Velikov Tested using piglit quick using execbuf versions 1 and 2. Tested-by: Thomas Hellstrom Reviewed-by: Thomas Hellstrom > --- > Thomas, VMware team, > > P

Re: [PATCH 2/5] drm/vmgfx: kill off unused init_mutex

On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > According to the docs - prevents firstopen/lastclose races. Yet never > used in practise. > > Cc: "VMware Graphics" > Cc: Thomas Hellstrom > Cc: Daniel Vetter > Signed-off-b

Re: [PATCH 1/5] vmwgfx: drop empty lastclose stub

On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > Core DRM is safe when the callback is NULL. > > Cc: "VMware Graphics" > Cc: Thomas Hellstrom > Cc: Daniel Vetter > Signed-off-by: Emil Velikov Reviewed-by: Thomas Hellstrom

Re: [PATCH 4/5] drm/vmwgfx: remove custom ioctl io encoding check

Hi, Emil, On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > Drop the custom ioctl io encoding check - core drm does it for us. I fail to see where the core does this, or do I miss something? Thanks, Thomas > > Cc: "VMware Graphics" >

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

bably be fixed before pushing this. > > Cc: "VMware Graphics" > Cc: Thomas Hellstrom > Cc: Daniel Vetter > Signed-off-by: Emil Velikov > --- > Thomas, VMware team, > > Please give this some testing on your end. I've only tested it > against > mes

[git pull] vmwgfx-fixes-5.2

5-21 10:23:10 +0200) Murray McAllister (2): drm/vmwgfx: NULL pointer dereference from vmw_cmd_dx_view_define() drm/vmwgfx: integer underflow in vmw_cmd_dx_set_shader() leading to an invalid read Thomas Hellstrom (4):

  1   2   3   4   5   6   7   8   9   10   >