[PATCH v2] drm/i915: fix screen flickering

2015-05-14 Thread Thomas Gummerer
lped-by: Matt Roper Signed-off-by: Thomas Gummerer --- > Sorry, I missed your patch when you first sent it. That type of fix > looks like an okay workaround while we do a more in-depth rework of the > watermark system. However I think your patch could cause a crash if we > disable the

[BUG/REGRESSION] Screen flickering

2015-05-13 Thread Thomas Gummerer
Sudip Mukherjee writes: > On Wed, May 13, 2015 at 11:53:19AM +0200, Jan Niehusmann wrote: >> Apr 30 08:50:23 localhost kernel: [drm:intel_cpu_fifo_underrun_irq_handler >> [i915]] *ERROR* CPU pipe B FIFO underrun >> Apr 30 08:50:23 localhost kernel: [drm:intel_pch_fifo_underrun_irq_handler >> [i

[BUG/REGRESSION] Screen flickering

2015-05-13 Thread Thomas Gummerer
Jan Niehusmann writes: > Hi, > > On Wed, May 13, 2015 at 12:14:39PM +0300, Jani Nikula wrote: >> Is this the same as https://bugzilla.kernel.org/show_bug.cgi?id=98141 ? > > The visible effect in the video is similar to what I see on the LVDS > display. I also see some influence of the mouse point

[BUG/REGRESSION] Screen flickering

2015-05-12 Thread Thomas Gummerer
Hi, I noticed that on my machine the screen starts to flicker after I suspend and resume my machine, on the main laptop display if an external display is attached with kernel v4.1-rc1. I tracked the regression down to commit c9f038a1a592 ("drm/i915: Don't assume primary & cursor are always on fo

[PATCH/RFC] i915: fix screen flickering

2015-04-29 Thread Thomas Gummerer
Thomas Gummerer writes: > Commit c9f038a1a592 ("drm/i915: Don't assume primary & cursor are > always on for wm calculation (v4)") fixes a null pointer dereference. > Setting the primary and cursor panes to false in > ilk_compute_wm_parameters to false does however

[PATCH/RFC] i915: fix screen flickering

2015-04-28 Thread Thomas Gummerer
d causes the screen to flicker. [ 101.133716] [drm:intel_set_cpu_fifo_underrun_reporting [i915]] *ERROR* uncleared fifo underrun on pipe A [ 101.133725] [drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe A FIFO underrun Always setting the panes to enabled fixes this error. Si