Re: [PATCH] drm/tegra: rgb: Fix the unbound reference count

2025-05-08 Thread Thierry Reding
On Wed, May 07, 2025 at 04:10:07PM +, Biju Das wrote: > Hi Thierry, > > > -Original Message- > > From: Thierry Reding > > Sent: 07 May 2025 17:00 > > To: Biju Das > > Subject: Re: [PATCH] drm/tegra: rgb: Fix the unbound reference count > &g

Re: [PATCH -next v2] gpu: host1x: Use for_each_available_child_of_node_scoped()

2025-05-07 Thread Thierry Reding
On Fri, Aug 30, 2024 at 03:38:24PM +0800, Jinjie Ruan wrote: > Avoids the need for manual cleanup of_node_put() in early exits > from the loop. > > Signed-off-by: Jinjie Ruan > --- > v2: > - Split out from the patch set. > --- > drivers/gpu/host1x/bus.c | 11 +++ > 1 file changed, 3 inse

Re: [PATCH RESEND] drm/tegra: fix a possible null pointer dereference

2025-05-07 Thread Thierry Reding
On Wed, Feb 12, 2025 at 09:42:45AM +0800, Qiu-ji Chen wrote: > In tegra_crtc_reset(), new memory is allocated with kzalloc(), but > no check is performed. Before calling __drm_atomic_helper_crtc_reset, > state should be checked to prevent possible null pointer dereference. > > Fixes: b7e0b04ae450

Re: [PATCH] drm/tegra: rgb: Fix the unbound reference count

2025-05-07 Thread Thierry Reding
On Wed, Feb 05, 2025 at 11:21:35AM +, Biju Das wrote: > The of_get_child_by_name() increments the refcount in tegra_dc_rgb_probe, > but the driver does not decrement the refcount during unbind. Fix the > unbound reference count using devm_add_action_or_reset() helper. > > Fixes: d8f4a9eda006 (

Re: [PATCH] drm/tegra: rgb: Fix the unbound reference count

2025-05-07 Thread Thierry Reding
On Wed, Feb 05, 2025 at 11:21:35AM +, Biju Das wrote: > The of_get_child_by_name() increments the refcount in tegra_dc_rgb_probe, > but the driver does not decrement the refcount during unbind. Fix the > unbound reference count using devm_add_action_or_reset() helper. > > Fixes: d8f4a9eda006 (

Re: [PATCH linux-next 1/2] gpu: drm: tegra: dpaux: Use dev_err_probe()

2025-05-07 Thread Thierry Reding
On Wed, Apr 02, 2025 at 07:37:58PM +0800, shao.ming...@zte.com.cn wrote: > From: Zhang Enpei > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Zhang Enpei > Signed-off-by: Shao Mingyin > --- > drivers/gpu/drm/tegra/dpaux.c | 11 +++ > 1 file chang

Re: [PATCH] gpu: host1x: Remove mid-job CDMA flushes

2025-05-07 Thread Thierry Reding
On Tue, Feb 04, 2025 at 02:45:46AM +, Mikko Perttunen wrote: > The current code can issue CDMA flushes (DMAPUT bumps) in the middle > of a job, before all opcodes have been written into the pushbuffer. > This can happen when pushbuffer fills up. Presumably this made sense > at some point in the

Re: [PATCH] drm/tegra: falcon: Pipeline firmware copy

2025-05-07 Thread Thierry Reding
On Wed, Feb 05, 2025 at 06:10:27AM +, Mikko Perttunen wrote: > The Falcon DMA engine allows queueing multiple operations for > improved performance. Do this to optimize firmware loading. > A performance improvement of 4x to 6x is observed. > > Co-developed-by: Ivan Raul Guadarrama > Signed-of

Re: [PATCH] drm/fbdev-client: Ignore EOPNOTSUPP errors

2025-05-07 Thread Thierry Reding
On Sat, Apr 26, 2025 at 08:52:40AM +0300, Dmitry Baryshkov wrote: > On Sat, Apr 12, 2025 at 09:00:47AM +0200, Thierry Reding wrote: > > From: Thierry Reding > > > > Recent generations of Tegra have moved the display components outside of > > host1x, leading to a device

Re: [PATCH] drm/tegra: Remove unneeded include

2025-05-07 Thread Thierry Reding
On Mon, Apr 28, 2025 at 04:34:35PM +0100, Jon Hunter wrote: > The header file 'tegra_drm.h' is included in gem.c, but this file is > already include 'drm.h'. Although there is no harm in including this > file again, it is also not necessary. Furthermore, the header file is > located under 'include/

Re: [PATCH v2] drm/tegra: Assign plane type before registration

2025-05-07 Thread Thierry Reding
On Mon, Apr 21, 2025 at 11:13:05AM -0500, Aaron Kling via B4 Relay wrote: > From: Thierry Reding > > Changes to a plane's type after it has been registered aren't propagated > to userspace automatically. This could possibly be achieved by updating > the property,

[PATCH] drm/fbdev-client: Ignore EOPNOTSUPP errors

2025-04-12 Thread Thierry Reding
From: Thierry Reding Recent generations of Tegra have moved the display components outside of host1x, leading to a device that has no CRTCs attached and hence doesn't support any of the modesetting functionality. When this is detected, the driver clears the DRIVER_MODESET and DRIVER_ATOMIC

Re: [PATCH rc] gpu: host1x: Do not assume that a NULL domain means no DMA IOMMU

2025-03-19 Thread Thierry Reding
On Mon, Mar 10, 2025 at 12:34:35PM +, Diogo Ivo wrote: > > Hello again, > > On 2/4/25 7:18 PM, Jason Gunthorpe wrote: > > Previously with tegra-smmu, even with CONFIG_IOMMU_DMA, the default domain > > could have been left as NULL. The NULL domain is specially recognized by > > host1x_iommu_at

Re: [PATCH rc] gpu: host1x: Do not assume that a NULL domain means no DMA IOMMU

2025-03-19 Thread Thierry Reding
On Tue, Feb 04, 2025 at 03:18:19PM -0400, Jason Gunthorpe wrote: > Previously with tegra-smmu, even with CONFIG_IOMMU_DMA, the default domain > could have been left as NULL. The NULL domain is specially recognized by > host1x_iommu_attach() as meaning it is not the DMA domain and > should be replac

Re: [PATCH v3 20/25] drm/tegra: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-06 Thread Thierry Reding
On Tue, Feb 18, 2025 at 03:23:43PM +0100, Thomas Zimmermann wrote: > Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and > buffer size. Align the pitch according to hardware requirements. > > Signed-off-by: Thomas Zimmermann > Cc: Thierry Reding > C

Re: [PATCH] gpu: host1x: Remove unused host1x_debug_dump_syncpts

2025-02-28 Thread Thierry Reding
On Sun, Dec 15, 2024 at 09:47:50PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > host1x_debug_dump_syncpts() has been unused since > commit f0fb260a0cdb ("gpu: host1x: Implement syncpoint wait using DMA > fences") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert

Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-04 Thread Thierry Reding
On Tue, Feb 04, 2025 at 03:33:53PM +, Biju Das wrote: > Hi Thierry Reding, > > > -Original Message- > > From: Thierry Reding > > Sent: 04 February 2025 15:25 > > Subject: Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe() > > > > On T

Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-04 Thread Thierry Reding
On Tue, Feb 04, 2025 at 09:07:05AM +, Biju Das wrote: > Hi Geert, > > Thanks for the feedback. > > > -Original Message- > > From: dri-devel On Behalf Of > > Geert Uytterhoeven > > Sent: 03 February 2025 11:06 > > Subject: Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe() > >

Re: [PATCH 14/14] Documentation: Update the todo

2025-01-29 Thread Thierry Reding
On Wed, Jan 29, 2025 at 04:28:49PM +0100, Maxime Ripard wrote: > On Wed, Jan 29, 2025 at 03:41:32PM +0100, Thierry Reding wrote: > > On Wed, Jan 29, 2025 at 03:31:50PM +0100, Maxime Ripard wrote: > > > Hi Thomas, > > > > > > On Wed, Jan 29, 2025 at 02:06

Re: [PATCH 14/14] Documentation: Update the todo

2025-01-29 Thread Thierry Reding
On Wed, Jan 29, 2025 at 03:31:50PM +0100, Maxime Ripard wrote: > Hi Thomas, > > On Wed, Jan 29, 2025 at 02:06:15PM +0100, Thomas Zimmermann wrote: > > Am 28.01.25 um 23:29 schrieb Anusha Srivatsa: > > > Remove the TODO now that this series addresses > > > the changes needed. > > > > While your se

Re: [PATCH] drm: cast calculation to __u64 to fix potential integer overflow

2024-12-04 Thread Thierry Reding
On Tue, Dec 03, 2024 at 10:02:00AM -0600, Gax-c wrote: > From: Zichen Xie > > Like commit b0b0d811eac6 ("drm/mediatek: Fix coverity issue with > unintentional integer overflow"), directly multiply pitch and > height may lead to integer overflow. Add a cast to avoid it. > > Fixes: 6d1782919dc9 ("

Re: [PATCH 1/3] drm: display: Set fwnode for aux bus devices

2024-10-25 Thread Thierry Reding
-e107adca4598@notapiano/ > Tested-by: "Nícolas F. R. A. Prado" > Signed-off-by: Saravana Kannan > --- > drivers/gpu/drm/display/drm_dp_aux_bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH 2/3] phy: tegra: xusb: Set fwnode for xusb port devices

2024-10-24 Thread Thierry Reding
gt; Tested-by: Jon Hunter > Suggested-by: "Nícolas F. R. A. Prado" > Signed-off-by: Saravana Kannan > --- > drivers/phy/tegra/xusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH next] drm/tegra: Fix NULL vs IS_ERR() check in probe()

2024-10-24 Thread Thierry Reding
On Fri, Sep 13, 2024 at 05:34:54PM +0300, Dan Carpenter wrote: > The iommu_paging_domain_alloc() function doesn't return NULL pointers, > it returns error pointers. Update the check to match. > > Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()") > Signed-off-by: Dan Carpenter >

Re: [PATCH] gpu: host1x: Set up device DMA parameters

2024-09-25 Thread Thierry Reding
On Mon, Sep 16, 2024 at 03:33:20PM GMT, Thierry Reding wrote: > From: Thierry Reding > > In order to store device DMA parameters, the DMA framework depends on > the device's dma_parms field to point at a valid memory location. Add > backing storage for this in struct host1

Re: [PATCH] gpu: host1x: Fix boot regression for Tegra

2024-09-25 Thread Thierry Reding
On Wed, Sep 25, 2024 at 05:05:04PM GMT, Jon Hunter wrote: > Commit 4c27ac45e622 ("gpu: host1x: Request syncpoint IRQs only during > probe") caused a boot regression for the Tegra186 device. Following this > update the function host1x_intr_init() now calls > host1x_hw_intr_disable_all_syncpt_intrs()

Re: [PATCH -next 2/3] drm/tegra: Enable module autoloading

2024-09-25 Thread Thierry Reding
On Mon, Sep 23, 2024 at 07:21:21AM GMT, Dmitry Baryshkov wrote: > On Mon, Sep 02, 2024 at 11:33:19AM GMT, Liao Chen wrote: > > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based > > on the alias from of_device_id table. > > > > Signed-off-by: Liao Chen > > --- > > drivers/g

Re: [PATCH] gpu: host1x: Request syncpoint IRQs only during probe

2024-09-25 Thread Thierry Reding
On Tue, Sep 24, 2024 at 07:33:05PM GMT, Jon Hunter wrote: > > On 06/09/2024 09:38, Jon Hunter wrote: > > Hi Mikko, > > > > On 31/05/2024 08:07, Mikko Perttunen wrote: > > > From: Mikko Perttunen > > > > > > Syncpoint IRQs are currently requested in a code path that runs > > > during resume. Due

[PATCH] gpu: host1x: Set up device DMA parameters

2024-09-16 Thread Thierry Reding
From: Thierry Reding In order to store device DMA parameters, the DMA framework depends on the device's dma_parms field to point at a valid memory location. Add backing storage for this in struct host1x_memory_context and point to it. Reported-by: Jonathan Hunter Signed-off-by: Thierry R

Re: [PATCH v2 1/3] drm/nouveau/tegra: Use iommu_paging_domain_alloc()

2024-09-09 Thread Thierry Reding
m/nouveau/nvkm/engine/device/tegra.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v2 3/3] drm/tegra: Use iommu_paging_domain_alloc()

2024-09-09 Thread Thierry Reding
er relevant. > > Replace iommu_domain_alloc() with iommu_paging_domain_alloc() which takes > the physical device from which the host1x_device virtual device was > instantiated. This physical device is a common parent to all physical > devices that are part of the virtual device. > > Suggested

Re: [PATCH] drm/tegra: fix potential uninitialized variable use

2024-09-03 Thread Thierry Reding
D@stanley.mountain > Fixes: 98365ca74cbf ("drm/tegra: convert to struct drm_edid") > Cc: Thierry Reding > Cc: Daniel Vetter > Cc: linux-te...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/tegra/output.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH 5/5] gpu: host1x: fence: Disable timeout on pre-silicon

2024-08-29 Thread Thierry Reding
On Thu, Apr 25, 2024 at 08:02:37AM GMT, Mikko Perttunen wrote: > From: Mikko Perttunen > > Timing can be wonky on pre-silicon platforms, so disable fence timeouts > on pre-silicon platforms. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/host1x/fence.c | 9 + > 1 file changed,

Re: [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static

2024-08-29 Thread Thierry Reding
On Thu, Aug 22, 2024 at 09:50:47PM GMT, Colin Ian King wrote: > Don't populate the const read-only array possible_nvram_sizes on the I've changed this (and the occurrence in the subject) to reflect the actual array name ("freqs") that's being changed here. Applied, thanks. Thierry signature.as

Re: [PATCH] gpu: host1x: Make host1x_context_device_bus_type constant

2024-08-29 Thread Thierry Reding
On Fri, Aug 23, 2024 at 04:07:24PM GMT, Kunwu Chan wrote: > From: Kunwu Chan > > Since commit d492cc2573a0 ("driver core: device.h: make struct > bus_type a const *"), the driver core can properly handle constant > struct bus_type, move the host1x_context_device_bus_type variable > to be a consta

[PATCH] Revert "drm/tegra: gr3d: Convert into dev_pm_domain_attach|detach_list()"

2024-08-29 Thread Thierry Reding
From: Thierry Reding This reverts commit f790b5c09665cab0d51dfcc84832d79d2b1e6c0e. An updated version of patch was applied to the PM tree. Sorry for the mixup. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/gr3d.c | 46 ++-- 1 file changed, 33

Re: [PATCH 4/6] drm/tegra: convert to struct drm_edid

2024-08-29 Thread Thierry Reding
On Thu, Aug 22, 2024 at 08:42:50PM GMT, Jani Nikula wrote: > Prefer the struct drm_edid based functions for reading the EDID and > updating the connector. > > Signed-off-by: Jani Nikula > > --- > > Cc: Thierry Reding > Cc: Mikko Perttunen > Cc: J

Re: [PATCH 3/3] drm/tegra: Remove call to iommu_domain_alloc()

2024-08-28 Thread Thierry Reding
On Mon, Aug 12, 2024 at 03:10:34PM GMT, Lu Baolu wrote: > Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from > the bus structure. The iommu subsystem no longer relies on bus for > operations. So iommu_domain_alloc() interface is no longer relevant. > > Normally, iommu_paging_do

Re: [PATCH 1/1] gpu: host1x: Use iommu_paging_domain_alloc()

2024-08-28 Thread Thierry Reding
On Mon, Aug 12, 2024 at 03:16:05PM GMT, Lu Baolu wrote: > An iommu domain is allocated in host1x_iommu_attach() and is attached to > host->dev. Use iommu_paging_domain_alloc() to make it explicit. > > Signed-off-by: Lu Baolu > Reviewed-by: Jason Gunthorpe > Link: > https://lore.kernel.org/r/202

Re: [PATCH] drm/tegra: hub: Use fn parameter directly to fix Coccinelle warning

2024-08-28 Thread Thierry Reding
On Wed, Jul 10, 2024 at 11:00:35PM GMT, Thorsten Blum wrote: > The function parameter out can be used directly instead of assigning it > to a temporary u64 variable first. > > Remove the local variable tmp2 and use the parameter out directly as the > divisor in do_div() to remove the following Coc

Re: [PATCH] gpu: host1x: Request syncpoint IRQs only during probe

2024-08-28 Thread Thierry Reding
On Fri, May 31, 2024 at 10:07:18AM GMT, Mikko Perttunen wrote: > From: Mikko Perttunen > > Syncpoint IRQs are currently requested in a code path that runs > during resume. Due to this, we get multiple overlapping registered > interrupt handlers as host1x is suspended and resumed. > > Rearrange i

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-07-12 Thread Thierry Reding
On Wed, Jul 10, 2024 at 02:10:09PM GMT, Maxime Ripard wrote: > On Fri, Jul 05, 2024 at 04:31:34PM GMT, Thierry Reding wrote: > > On Thu, Jul 04, 2024 at 02:24:49PM GMT, Maxime Ripard wrote: > > > On Fri, Jun 28, 2024 at 04:42:35PM GMT, Thierry Reding wrote: > > > >

Re: [Linaro-mm-sig] Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-07-11 Thread Thierry Reding
On Mon, Jul 08, 2024 at 09:14:14AM GMT, Christian König wrote: > Am 05.07.24 um 17:35 schrieb Daniel Vetter: > > Just figured I'll jump in on one detail here. > > > > On Fri, Jul 05, 2024 at 04:31:34PM +0200, Thierry Reding wrote: > > > On Thu, Jul 04, 2024 at

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-07-11 Thread Thierry Reding
On Wed, Jul 10, 2024 at 02:10:09PM GMT, Maxime Ripard wrote: > On Fri, Jul 05, 2024 at 04:31:34PM GMT, Thierry Reding wrote: > > On Thu, Jul 04, 2024 at 02:24:49PM GMT, Maxime Ripard wrote: > > > On Fri, Jun 28, 2024 at 04:42:35PM GMT, Thierry Reding wrote: > > > >

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-07-05 Thread Thierry Reding
On Thu, Jul 04, 2024 at 02:24:49PM GMT, Maxime Ripard wrote: > On Fri, Jun 28, 2024 at 04:42:35PM GMT, Thierry Reding wrote: > > On Fri, Jun 28, 2024 at 03:08:46PM GMT, Maxime Ripard wrote: > > > Hi, > > > > > > On Fri, Jun 28, 2024 at 01:29:17PM GMT, Thierry

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-06-28 Thread Thierry Reding
On Fri, Jun 28, 2024 at 03:08:46PM GMT, Maxime Ripard wrote: > Hi, > > On Fri, Jun 28, 2024 at 01:29:17PM GMT, Thierry Reding wrote: > > On Tue, May 21, 2024 at 02:06:19PM GMT, Daniel Vetter wrote: > > > On Thu, May 16, 2024 at 09:51:35AM -0700, John Stultz wrote: > &g

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-28 Thread Thierry Reding
On Fri, Jun 28, 2024 at 03:21:51PM GMT, mrip...@kernel.org wrote: > On Fri, Jun 28, 2024 at 01:47:01PM GMT, Thierry Reding wrote: > > On Thu, Jun 27, 2024 at 04:40:02PM GMT, mrip...@kernel.org wrote: > > > On Thu, Jun 27, 2024 at 08:57:40AM GMT, Christian König wrote: > >

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-28 Thread Thierry Reding
On Fri, Jun 28, 2024 at 02:34:24PM GMT, Christian König wrote: > Am 28.06.24 um 13:47 schrieb Thierry Reding: > > [SNIP] > > > > The reason I ask is that encryption here looks just like another > > > > parameter > > > > for the buffer, e.g. like form

Re: [PATCH v5 7/9] dma-buf: heaps: restricted_heap: Add MediaTek restricted heap and heap_init

2024-06-28 Thread Thierry Reding
On Wed, May 15, 2024 at 07:23:06PM GMT, Yong Wu wrote: > Add a MediaTek restricted heap which uses TEE service call to restrict > buffer. Currently this restricted heap is NULL, Prepare for the later > patch. Mainly there are two changes: > a) Add a heap_init ops since TEE probe late than restricte

Re: [PATCH v5 5/9] dma-buf: heaps: restricted_heap: Add private heap ops

2024-06-28 Thread Thierry Reding
On Wed, May 15, 2024 at 07:23:04PM GMT, Yong Wu wrote: > Add "struct restricted_heap_ops". For the restricted memory, totally there > are two steps: > a) alloc: Allocate the buffer in kernel; > b) restrict_buf: Restrict/Protect/Secure that buffer. > The "alloc" is mandatory while "restrict_buf" is

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-28 Thread Thierry Reding
On Thu, Jun 27, 2024 at 04:40:02PM GMT, mrip...@kernel.org wrote: > On Thu, Jun 27, 2024 at 08:57:40AM GMT, Christian König wrote: > > Am 27.06.24 um 05:21 schrieb Jason-JH Lin (林睿祥): > > > > > > On Wed, 2024-06-26 at 19:56 +0200, Daniel Vetter wrote: > > > > > External email : Please do not cli

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-06-28 Thread Thierry Reding
On Tue, May 21, 2024 at 02:06:19PM GMT, Daniel Vetter wrote: > On Thu, May 16, 2024 at 09:51:35AM -0700, John Stultz wrote: > > On Thu, May 16, 2024 at 3:56 AM Daniel Vetter wrote: > > > On Wed, May 15, 2024 at 11:42:58AM -0700, John Stultz wrote: > > > > But it makes me a little nervous to add a

Re: [PATCH V2] drm/tegra: fix a possible null pointer dereference

2024-06-27 Thread Thierry Reding
On Sun Jun 2, 2024 at 10:46 AM CEST, Huai-Yuan Liu wrote: > In malidp_tegra_crtc_reset, new memory is allocated with kzalloc, but > no check is performed. Before calling __drm_atomic_helper_crtc_reset, > mw_state should be checked to prevent possible null pointer dereference. The commit message he

Re: [PATCH v2 3/8] drm/tegra: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-26 Thread Thierry Reding
ewed-by: Maxime Ripard > Signed-off-by: Douglas Anderson > --- > This commit is only compile-time tested. > > (no changes since v1) > > drivers/gpu/drm/tegra/drm.c | 6 ++ > 1 file changed, 6 insertions(+) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH] drm/tegra: fix a possible null pointer dereference

2024-05-31 Thread Thierry Reding
On Fri May 31, 2024 at 3:56 PM CEST, Huai-Yuan Liu wrote: > In malidp_tegra_crtc_reset, new memory is allocated with kzalloc, but > no check is performed. Before calling __drm_atomic_helper_crtc_reset, > mw_state should be checked to prevent possible null pointer dereferene. Please check that al

Re: [PATCH] docs: document python version used for compilation

2024-05-31 Thread Thierry Reding
On Fri May 31, 2024 at 9:33 AM CEST, Geert Uytterhoeven wrote: > Hi Thierry, > > On Thu, May 30, 2024 at 7:07 PM Thierry Reding > wrote: > > Alternatively, maybe Kconfig could be taught about build dependencies? > > git grep "depends on \$(" -- "*Kconf*&qu

Re: [BUG] Build failure and alleged fix for next-20240523

2024-05-30 Thread Thierry Reding
On Thu May 30, 2024 at 6:55 PM CEST, Paul E. McKenney wrote: > On Fri, May 24, 2024 at 12:57:58PM -0700, Abhinav Kumar wrote: > > Hello > > > > On 5/24/2024 12:55 PM, Paul E. McKenney wrote: > > > Hello! > > > > > > I get the following allmodconfig build error on x86 in next-20240523: > > > > >

Re: [PATCH] docs: document python version used for compilation

2024-05-30 Thread Thierry Reding
On Fri May 10, 2024 at 10:04 PM CEST, Rob Clark wrote: > On Fri, May 10, 2024 at 3:09 AM Jani Nikula wrote: > > > > On Fri, 10 May 2024, Mauro Carvalho Chehab wrote: > > > Em Fri, 10 May 2024 11:08:38 +0300 > > > Jani Nikula escreveu: > > > > > >> On Thu, 09 May 2024, Dmitry Baryshkov > > >> w

Re: [PATCH] docs: document python version used for compilation

2024-05-30 Thread Thierry Reding
On Thu May 9, 2024 at 6:48 PM CEST, Jonathan Corbet wrote: > Dmitry Baryshkov writes: > > > The drm/msm driver had adopted using Python3 script to generate register > > header files instead of shipping pre-generated header files. Document > > the minimal Python version supported by the script. > >

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-30 Thread Thierry Reding
On Wed May 8, 2024 at 1:04 AM CEST, Abhinav Kumar wrote: > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"), > compilation is broken on machines having python versions older than 3.9 > due to dependency on argparse.BooleanOptionalAction. > > Switch to use simple bool for

Re: (subset) [PATCH v7 0/5] Add Tegra Security Engine driver

2024-04-26 Thread Thierry Reding
On Fri Apr 26, 2024 at 5:32 PM CEST, Thierry Reding wrote: > From: Thierry Reding > > > On Wed, 03 Apr 2024 15:30:34 +0530, Akhil R wrote: > > Add support for Tegra Security Engine which can accelerates various > > crypto algorithms. The Engine has two separate instance

Re: (subset) [PATCH v7 0/5] Add Tegra Security Engine driver

2024-04-26 Thread Thierry Reding
From: Thierry Reding On Wed, 03 Apr 2024 15:30:34 +0530, Akhil R wrote: > Add support for Tegra Security Engine which can accelerates various > crypto algorithms. The Engine has two separate instances within for > AES and HASH algorithms respectively. > > The driver regis

Re: [PATCH] gpu: host1x: mipi: Benefit from devm_clk_get_prepared()

2024-04-19 Thread Thierry Reding
n through whatever tree is most appropriate for this ongoing work: Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH 3/4] gpu: host1x: Convert to platform remove callback returning void

2024-04-19 Thread Thierry Reding
> are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/host1x/dev.c | 6 ++ > 1 file cha

Re: [PATCH 0/4] gpu: Convert to platform remove callback returning void

2024-04-19 Thread Thierry Reding
this thread completed in > one go), I think with how drm maintenace works, it's best if the patches > are picked up by their individual maintainers. I guess that's: > > - Frank Binns + Matt Coster for imagination > > - Chun-Kuang Hu + Philipp Zabel for mediatek > > -

Re: [PATCH] gpu: host1x: Do not setup DMA for virtual devices

2024-04-08 Thread Thierry Reding
On Wed Apr 3, 2024 at 12:07 PM CEST, Jon Hunter wrote: > Hi Thierry, > > On 15/03/2024 11:25, Jon Hunter wrote: > > > > On 14/03/2024 15:49, Thierry Reding wrote: > >> From: Thierry Reding > >> > >> The host1x devices are virtual compound devices

[PATCH] gpu: host1x: Do not setup DMA for virtual devices

2024-03-14 Thread Thierry Reding
From: Thierry Reding The host1x devices are virtual compound devices and do not perform DMA accesses themselves, so they do not need to be set up for DMA. Ideally we would also not need to set up DMA masks for the virtual devices, but we currently still need those for legacy support on old

[PATCH] drm: Remove drm_num_crtcs() helper

2024-02-27 Thread Thierry Reding
From: Thierry Reding The drm_num_crtcs() helper determines the number of CRTCs by iterating over the list of CRTCs that have been registered with the mode config. However, we already keep track of that number in the mode config's num_crtcs field, so we can simply retrieve the value from tha

Re: [PATCH v2] drm/tegra: Remove existing framebuffer only if we support display

2024-02-26 Thread Thierry Reding
On Mon Feb 26, 2024 at 1:08 PM CET, Robert Foss wrote: > On Mon, Feb 26, 2024 at 12:36 PM Javier Martinez Canillas > wrote: > > > > Thomas Zimmermann writes: > > > > > Hi > > > > > > Am 23.02.24 um 16:03 schrieb Thierry Reding: > > >>

[PATCH v2] drm/tegra: Remove existing framebuffer only if we support display

2024-02-23 Thread Thierry Reding
From: Thierry Reding Tegra DRM doesn't support display on Tegra234 and later, so make sure not to remove any existing framebuffers in that case. v2: - add comments explaining how this situation can come about - clear DRIVER_MODESET and DRIVER_ATOMIC feature bits Signed-off-by: Th

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-22 Thread Thierry Reding
On Thu Feb 22, 2024 at 2:05 AM CET, Mikko Perttunen wrote: > From: Mikko Perttunen > > On Tegra186, secure world applications may need to access host1x > during suspend/resume, and rely on the kernel to keep Host1x out > of reset during the suspend cycle. As such, as a quirk, > skip asserting Host

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-19 Thread Thierry Reding
On Mon Feb 19, 2024 at 3:18 AM CET, Mikko Perttunen wrote: > On 2/16/24 19:02, Thierry Reding wrote: > > On Wed Feb 14, 2024 at 12:40 PM CET, Mikko Perttunen wrote: > >> From: Mikko Perttunen > >> > >> On Tegra186, other software components may rely on the ke

Re: [PATCH] phy: constify of_phandle_args in xlate

2024-02-19 Thread Thierry Reding
drivers/phy/ti/phy-da8xx-usb.c | 2 +- > drivers/phy/ti/phy-gmii-sel.c | 2 +- > drivers/phy/xilinx/phy-zynqmp.c| 2 +- > drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 2 +- > include/linux/phy/phy.h

Re: [PATCH][next] gpu: host1x: remove redundant assignment to variable space

2024-02-16 Thread Thierry Reding
On Thu Feb 15, 2024 at 11:43 PM CET, Colin Ian King wrote: > The variable space is being initialized with a value that is never read, > it is being re-assigned later on. The initialization is redundant and > can be removed. Also merge two declaration lines together. > > Cleans up clang scan build w

Re: [PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-16 Thread Thierry Reding
On Wed Feb 14, 2024 at 12:40 PM CET, Mikko Perttunen wrote: > From: Mikko Perttunen > > On Tegra186, other software components may rely on the kernel to > keep Host1x operational even during suspend. As such, as a quirk, > skip asserting Host1x's reset on Tegra186. This all sounds a bit vague. Wh

Re: [PATCH] gpu: host1x: bus: make host1x_bus_type const

2024-02-14 Thread Thierry Reding
On Tue Feb 13, 2024 at 3:44 PM CET, Ricardo B. Marliere wrote: > Since commit d492cc2573a0 ("driver core: device.h: make struct > bus_type a const *"), the driver core can properly handle constant > struct bus_type, move the host1x_bus_type variable to be a constant > structure as well, placing it

Re: [PATCH 0/6] drm/tegra: Fix some error handling paths

2023-12-14 Thread Thierry Reding
On Sat, Sep 02, 2023 at 05:22:07PM +0200, Christophe JAILLET wrote: > Most of the patches are retated to tegra_output_probe() and missing > tegra_output_remove(). Others are things spotted while writting the serie. > > > Patches 1, 3, 4 are verbose, but some functions called in the probe can > re

Re: [PATCH] drm/tegra: dpaux: Fix PM disable depth imbalance in tegra_dpaux_probe

2023-12-14 Thread Thierry Reding
On Wed, Oct 04, 2023 at 10:10:55PM +0800, Zhang Shurong wrote: > The pm_runtime_enable function increases the power disable depth, > which means that we must perform a matching decrement on the error > handling path to maintain balance within the given context. > Additionally, we need to address th

Re: [PATCH v2] drm/tegra: include drm/drm_edid.h only where needed

2023-12-14 Thread Thierry Reding
On Wed, Dec 13, 2023 at 12:19:51PM +0200, Jani Nikula wrote: > Reduce the need for rebuilds when drm_edid.h is modified by including it > only where needed. > > v2: Fix build (kernel test robot ) > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/tegra/drm.h| 2 +- > drivers/gpu/drm/teg

Re: [PATCH] drm/tegra: dsi: Add missing check for of_find_device_by_node

2023-12-14 Thread Thierry Reding
On Tue, Oct 24, 2023 at 08:07:38AM +, Chen Ni wrote: > Add check for the return value of of_find_device_by_node() and return > the error if it fails in order to avoid NULL pointer dereference. > > Fixes: e94236cde4d5 ("drm/tegra: dsi: Add ganged mode support") > Signed-off-by: Chen Ni > --- >

Re: [PATCH] fbdev/simplefb: change loglevel when the power domains cannot be parsed

2023-12-13 Thread Thierry Reding
support for generic power-domains") > Signed-off-by: Brian Masney > --- > drivers/video/fbdev/simplefb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v4 000/115] pwm: Fix lifetime issues for pwm_chips

2023-12-11 Thread Thierry Reding
On Fri, Dec 08, 2023 at 07:50:33PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Fri, Dec 08, 2023 at 04:41:39PM +0100, Thierry Reding wrote: > > On Wed, Dec 06, 2023 at 12:43:14PM +0100, Uwe Kleine-König wrote: > > > This series is based on Thierry's for

Re: [PATCH v4 000/115] pwm: Fix lifetime issues for pwm_chips

2023-12-08 Thread Thierry Reding
t a single allocation, but I much prefer the end result because it's got the driver and internals much more cleanly separated. Going forward I think it would be easier to apply all the ref-counting on top of that because we only need to keep the PWM framework-internal data structure alive after a

[PATCH] drm/nouveau: Fixup gk20a instobj hierarchy

2023-12-08 Thread Thierry Reding
From: Thierry Reding Commit 12c9b05da918 ("drm/nouveau/imem: support allocations not preserved across suspend") uses container_of() to cast from struct nvkm_memory to struct nvkm_instobj, assuming that all instance objects are derived from struct nvkm_instobj. For the gk20a family that

Re: (subset) [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

2023-12-05 Thread Thierry Reding
On Tue, Nov 28, 2023 at 09:58:41PM +0100, Uwe Kleine-König wrote: > On Tue, Nov 28, 2023 at 06:49:23PM +0100, Thierry Reding wrote: > > > > On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > > > Merging > > > === > > > I propose to tak

Re: [PATCH 08/10] iommu/tegra: Use tegra_dev_iommu_get_stream_id() in the remaining places

2023-12-01 Thread Thierry Reding
On Wed, Nov 29, 2023 at 03:26:03PM -0400, Jason Gunthorpe wrote: > On Wed, Nov 29, 2023 at 05:23:13PM +0100, Thierry Reding wrote: > > > diff --git a/drivers/memory/tegra/tegra186.c > > > b/drivers/memory/tegra/tegra186.c > > > index 533f85a4b2bdb7..3e4fbe94dd6

Re: [PATCH 08/10] iommu/tegra: Use tegra_dev_iommu_get_stream_id() in the remaining places

2023-11-29 Thread Thierry Reding
> Suggested-by: Thierry Reding > Signed-off-by: Jason Gunthorpe > --- > drivers/dma/tegra186-gpc-dma.c | 8 +++- > drivers/gpu/drm/nouveau/nvkm/subdev/ltc/gp10b.c | 7 ++- > drivers/memory/tegra/tegra186.c | 12 ++-- > 3

Re: (subset) [PATCH 00/17] dt-bindings: samsung: add specific compatibles for existing SoC

2023-11-28 Thread Thierry Reding
> 3. No drivers are affected by this change. > 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect >follow up patchsets. > > [...] Applied, thanks! [12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC commit: 5d67b8f81b9d5985

Re: [PATCH v5 1/4] pwm: rename pwm_apply_state() to pwm_apply_cansleep()

2023-11-24 Thread Thierry Reding
On Sat, Nov 18, 2023 at 04:16:17PM +, Sean Young wrote: > In order to introduce a pwm api which can be used from atomic context, > we will need two functions for applying pwm changes: > > int pwm_apply_cansleep(struct pwm *, struct pwm_state *); > int pwm_apply_atomic(struct pwm *,

[PATCH v2 2/2] fbdev/simplefb: Add support for generic power-domains

2023-11-01 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer device tree bindings document the power-domains property, so make sure that simplefb supports it. This ensures that the power domains remain enabled as long as simplefb is active. v2: - remove unnecessary call to simplefb_detach_genpds() since that&#

[PATCH v2 1/2] fbdev/simplefb: Support memory-region property

2023-11-01 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer bindings specify that the "memory-region" property can be used as an alternative to the "reg" property to define the framebuffer memory used by the display hardware. Implement support for this in the simplefb driver. Reviewed-by: H

[PATCH v2 0/2] fbdev/simplefb: Add missing simple-framebuffer features

2023-11-01 Thread Thierry Reding
From: Thierry Reding Hi, This contains two patches that bring simplefb up to feature parity with simpledrm. The patches add support for the "memory-region" property that provides an alternative to the "reg" property to describe the memory used for the framebuffer and allow

Re: [PATCH 2/2] fbdev/simplefb: Add support for generic power-domains

2023-11-01 Thread Thierry Reding
On Thu, Oct 26, 2023 at 02:50:27PM +0200, Hans de Goede wrote: > Hi, > > Thank you for your patches. > > On 10/11/23 16:38, Thierry Reding wrote: > > From: Thierry Reding > > > > The simple-framebuffer device tree bindings document the power-domains > &g

Re: [PATCH 1/2] gpu: host1x: Correct allocated size for contexts

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:59:09PM +0300, Mikko Perttunen wrote: > From: Johnny Liu > > Original implementation over allocates the memory size for the > contexts list. The size of memory for the contexts list is based > on the number of iommu groups specified in the device tree. > > Fixes: 8aa5b

Re: [PATCH] gpu: host1x: Syncpoint interrupt sharding

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:40:07PM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > Support sharded syncpoint interrupts on Tegra234+. This feature > allows specifying one of eight interrupt lines for each syncpoint > to lower processing latency of syncpoint threshold > interrupts. > >

Re: [PATCH 1/3] gpu: host1x: Add locking in channel allocation

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:15:07PM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > Add locking around channel allocation to avoid race conditions. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/host1x/channel.c | 7 +++ > drivers/gpu/host1x/channel.h | 3 +++ > 2 files ch

[PATCH 1/2] fbdev/simplefb: Support memory-region property

2023-10-11 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer bindings specify that the "memory-region" property can be used as an alternative to the "reg" property to define the framebuffer memory used by the display hardware. Implement support for this in the simplefb driver. Signed-of

[PATCH 2/2] fbdev/simplefb: Add support for generic power-domains

2023-10-11 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer device tree bindings document the power-domains property, so make sure that simplefb supports it. This ensures that the power domains remain enabled as long as simplefb is active. Signed-off-by: Thierry Reding --- drivers/video/fbdev/simplefb.c | 93

[PATCH 0/2] fbdev/simplefb: Add missing simple-framebuffer features

2023-10-11 Thread Thierry Reding
From: Thierry Reding Hi, This contains two patches that bring simplefb up to feature parity with simpledrm. The patches add support for the "memory-region" property that provides an alternative to the "reg" property to describe the memory used for the framebuffer and allow

[PATCH] drm/simpledrm: Fix power domain device link validity check

2023-10-11 Thread Thierry Reding
From: Thierry Reding We need to check if a link is non-NULL before trying to delete it. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tiny/simpledrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c

  1   2   3   4   5   6   7   8   9   10   >