There are no remaining users of mipi_dsi_dcs_write_seq and it can be
removed in favor of mipi_dsi_dcs_write_seq_multi.
Signed-off-by: Tejas Vipin
---
include/drm/drm_mipi_dsi.h | 22 --
1 file changed, 22 deletions(-)
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm
Changes the samsung-sofef00 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-samsung-sofef00.c | 70 ++-
1 file changed, 21 insertions(+), 49 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung
panel-samsung-sofef00 is the last remaining user of
mipi_dsi_dcs_write_seq, so mipi_dsi_dcs_write_seq can be removed after
the panel has been changed to use mipi_dsi_*_multi functions.
Tejas Vipin (2):
drm/panel: panel-samsung-sofef00: transition to mipi_dsi wrapped
functions
drm/mipi-dsi
boe_bf060y8m_aj0_prepare fails.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Tejas Vipin
---
Changes in v3:
- Disable regulators in boe_bf060y8m_aj0_prepare if
boe_bf060y8m_aj0_on fails.
Changes in v2:
- Always set MIPI_DSI_MODE_LPM in boe_bf060y8m_aj0_off
Link to v2:
https://lore.kernel.org
On 4/13/25 3:40 AM, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 11, 2025 at 9:30 PM Tejas Vipin wrote:
>>
>> Changes the boe-bf060y8m-aj0 panel to use multi style functions for
>> improved error handling. Additionally the MIPI_DSI_MODE_LPM flag is set
>>
boe_bf060y8m_aj0_prepare fails.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Tejas Vipin
---
Changes in v3:
- Disable regulators in boe_bf060y8m_aj0_prepare if
boe_bf060y8m_aj0_on fails.
Changes in v2:
- Always set MIPI_DSI_MODE_LPM in boe_bf060y8m_aj0_off
Link to v2:
https://lore.kernel.org
Changes the boe-bf060y8m-aj0 panel to use multi style functions for
improved error handling. Additionally the MIPI_DSI_MODE_LPM flag is set
after the off commands are run in boe_bf060y8m_aj0_off regardless of any
failures.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Tejas Vipin
---
Changes in
Changes the boe-bf060y8m-aj0 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
.../gpu/drm/panel/panel-boe-bf060y8m-aj0.c| 112 +++---
1 file changed, 43 insertions(+), 69 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-boe
Changes the himax-hx8394 panel to use multi style functions for
improved error handling.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Revert behavior change in hx8394_enable
- Move variable declaration to top of function
Link to v1:
https
Changes the himax-hx8394 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-himax-hx8394.c | 444 ++---
1 file changed, 210 insertions(+), 234 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-himax
Changes the samsung-s6d7aa0 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Remove unnecessary early return in s6d7aa0_lock
- Remove redundant GPIO reset setting in s6d7aa0_on.
Link to v1:
https://lore.kernel.org/all
Changes the samsung-s6d7aa0 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 223 ++
1 file changed, 68 insertions(+), 155 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung
Changes the novatek-nt36523 panel to use multi style functions for
improved error handling.
Reviewed-by: Douglas Anderson
Signed-off-by: Tejas Vipin
---
Changes in v4:
- Cleanup nt36523_prepare
Link to v3:
https://lore.kernel.org/all/20250309040355.381386-1-tejasvipi...@gmail.com
ed here.
>>>>
>>>
>>> I was actually thinking of sending patches per driver this time around
>> since Tejas also seems to be looking into similar partsThoughts?
>>
>> Have you discussed it with Tejas? What is his next target?
>>
>> I was hoping he will have some feedback on this patch and we could take it
> from there.
> It *should* be okay for me to send all changes in a single series...
>
> Anusha
>
There's 5 more panels that use dcs/generic write_seq(). Maybe I could
work on those (himax-hx8394, samsung-sofef00, samsung-s6d7aa0,
boe-bf060y8m-aj0, jdi-lpm102a188a) while you work on transitioning the
rest of the panels (excluding these) that use other functions in the
old API? When either of us finishes before the other we could have
another discussion about splitting work if necessary. I'm open to other
suggestions too.
>>>>> Cc: Maxime Ripard
>>>>
>>>> That hasn't been my email address for 6 years :)
>>>>
>>> My bad. Will change this.
>>
>>
>>
>> --
>> With best wishes
>> Dmitry
>>
>>
>
--
Tejas Vipin
Changes the novatek-nt36523 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
Changes in v3:
- Remove mipi_dsi_dual_msleep
- Change mipi_dsi_dual_dcs_write_seq_multi to use the same dsi_ctx
by swapping the dsi accordingly.
Link to v2
Changes the novatek-nt36523 panel to use multi style functions for
improved error handling. Additionally, novatek-nt36523 will now continue
to execute the init sequence on one of the DSI devices on an error
occurring on the other one.
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Uses
Introduces mipi_dsi_dual_msleep to be used with double-DSI panels and
converts novatek-nt36523 to use multi style functions including
mipi_dsi_dual_msleep. In this process, minor changes to
novatek-nt36523's behavior are introduced.
Tejas Vipin (2):
drm/mipi-dsi: Add mipi_dsi_dual_msleep
Introduces mipi_dsi_dual_msleep to make it easier to use msleep in the
case of a double-DSI panel.
Signed-off-by: Tejas Vipin
---
include/drm/drm_mipi_dsi.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
index bd40a443385c
On 3/6/25 10:58 PM, Doug Anderson wrote:
> Hi,
>
> On Thu, Mar 6, 2025 at 6:05 AM wrote:
>>
>> On 06/03/2025 14:43, Tejas Vipin wrote:
>>> Changes the novatek-nt36523 panel to use multi style functions for
>>> improved error handling.
>>>
>&
Changes the novatek-nt36523 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-novatek-nt36523.c | 1683 -
1 file changed, 823 insertions(+), 860 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel
Removes mipi_dsi_dcs_set_tear_off and replaces it with a
multi version as after replacing it in sony-td4353-jdi, it doesn't
appear anywhere else. sony-td4353-jdi is converted to use multi style
functions, including mipi_dsi_dcs_set_tear_off_multi.
Signed-off-by: Tejas Vipin
---
Changes
On 2/15/25 6:12 AM, Doug Anderson wrote:
> Hi,
>
> On Fri, Feb 14, 2025 at 9:30 AM Tejas Vipin wrote:
>>
>> Change the sony-td4353-jdi panel to use multi style functions for
>> improved error handling.
>>
>> Signed-off-by: Tejas Vipin
>> ---
>
This patch removes mipi_dsi_dcs_set_tear_off and replaces it with a
multi version as after replacing it in sony-td4353-jdi, it doesn't
appear anywhere else. sony-td4353-jdi is converted to use multi style
functions, including mipi_dsi_dcs_set_tear_off_multi.
Tejas Vipin (2):
drm/mip
mipi_dsi_dcs_set_tear_off can heavily benefit from being converted
to a multi style function as it is often called in the context of
similar functions.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c | 42 +++---
include/drm/drm_mipi_dsi.h | 2
Change the sony-td4353-jdi panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-sony-td4353-jdi.c | 107 --
1 file changed, 23 insertions(+), 84 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sony
Change the visionox-r66451 panel to use multi style functions for
improved error handling. Additionally, always drop LPM flag after
sending init sequence.
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Fixed visionox_r66451_enable to return dsi_ctx.accum_err
- Mentioned changed
Change the visionox-r66451 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-visionox-r66451.c | 179 --
1 file changed, 76 insertions(+), 103 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel
Changes the sharp-ls060t1sx01 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
.../gpu/drm/panel/panel-sharp-ls060t1sx01.c | 59 +--
1 file changed, 16 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sharp
Changes the samsung-s6e88a0-ams452ef01 panel to use multi style functions
for improved error handling.
Reviewed-by: Douglas Anderson
Signed-off-by: Tejas Vipin
---
Changes in v2:
- changed s6e88a0_ams452ef01_off to return void
Link to v1:
https://lore.kernel.org/all/20250121134819.251718
Changes the samsung-s6e88a0-ams452ef01 panel to use multi style functions
for improved error handling.
Signed-off-by: Tejas Vipin
---
.../panel/panel-samsung-s6e88a0-ams452ef01.c | 89 +++
1 file changed, 31 insertions(+), 58 deletions(-)
diff --git a/drivers/gpu/drm/panel
Changes the xinpeng-xpp055c272 panel to use multi style functions for
improved error handling.
Reviewed-by: Neil Armstrong
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Changed print statement to conditionally run
- Removed unnecessary error message
- Reverted 2 mipi_dsi_msleep to
On 1/7/25 10:18 AM, Doug Anderson wrote:
> Hi,
>
> On Mon, Jan 6, 2025 at 8:21 PM Tejas Vipin wrote:
>>
>>>>> - ret = xpp055c272_init_sequence(ctx);
>>>>> - if (ret < 0) {
>>>>> - dev_err(ctx->dev,
; - }
>>> + xpp055c272_init_sequence(&dsi_ctx);
>>> + dev_dbg(ctx->dev, "Panel init sequence done\n");
>
> Should the above print be only if "accum_err" is 0? That would match
> the previous behavior. I guess I would have also left the print as
> part of xpp055c272_init_sequence() unless there's a reason for moving
> it...
I don't think it should print only if accum_err is 0. In the previous
code, it would just print after all the msleeps and write_seqs are done,
with no error checking at any point.
The reason I've moved the print outside the function is because we are
able to reduce a couple lines of code by passing dsi_ctx to the function
instead of ctx. If I'd kept the print inside, it would require us to
declare a `struct device*` variable which would require ctx as far as
I've seen and just overall introduces some lines that we could otherwise
avoid. I've done this in a couple other panels too.
I'll do a v2 with the other suggested changes.
--
Tejas Vipin
Changes the ebbg-ft8719 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 67 ++-
1 file changed, 16 insertions(+), 51 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719
Changes the xinpeng-xpp055c272 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
.../gpu/drm/panel/panel-xinpeng-xpp055c272.c | 185 --
1 file changed, 84 insertions(+), 101 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel
On 10/29/24 12:24 AM, Doug Anderson wrote:
> Hi,
>
> On Fri, Oct 25, 2024 at 9:00 PM Tejas Vipin wrote:
>>
>> @@ -418,79 +398,42 @@ static const struct ltk050h3146w_desc
>> ltk050h3146w_data = {
>> MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT
Changes the leadtek-ltk050h3146w panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
.../drm/panel/panel-leadtek-ltk050h3146w.c| 345 +++---
1 file changed, 134 insertions(+), 211 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel
Changes the elida-kd35t133 panel to use multi style functions for
improved error handling.
Reviewed-by: Jessica Zhang
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Tejas Vipin
---
Changes in v3:
- Added back bytes that were removed
- Replaced mipi_dsi_dcs_write_buffer_multi with
On 9/25/24 1:25 AM, Doug Anderson wrote:
> Hi,
>
> On Mon, Sep 23, 2024 at 5:33 AM Tejas Vipin wrote:
>>
>> -static int kd35t133_init_sequence(struct kd35t133 *ctx)
>> +static void kd35t133_init_sequence(struct mipi_dsi_multi_context *dsi_ctx)
>> {
>&
Changes the elida-kd35t133 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Changed mipi_dsi_dcs_write to mipi_dsi_dcs_write_buffer_multi
- Cleaned up error handling
Link to v1:
https://lore.kernel.org/all
On 9/20/24 9:59 PM, Dmitry Baryshkov wrote:
> On Tue, Sep 17, 2024 at 12:47:10PM GMT, Tejas Vipin wrote:
>> Changes the elida-kd35t133 panel to use multi style functions for
>> improved error handling.
>>
>> Signed-off-by: Tejas Vipin
>> ---
>> drive
Changes the elida-kd35t133 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-elida-kd35t133.c | 107 ---
1 file changed, 45 insertions(+), 62 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-elida
Changes the raydium-rm69380 panel to use multi style functions for
improved error handling.
Reviewed-by: Douglas Anderson
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Fix whitespace issues
Link to v1:
https://lore.kernel.org/all/20240907140130.410349-1-tejasvipi...@gmail.com
On 9/12/24 12:49 PM, Thomas Zimmermann wrote:
> Hi
>
> Am 11.09.24 um 20:06 schrieb Tejas Vipin:
>> Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since
>> monitor HDMI information is available after EDID is parsed. Additionally
>> rewrite the
Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since
monitor HDMI information is available after EDID is parsed. Additionally
rewrite the code the code to have fewer indentation levels.
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Use drm_edid instead of edid
Link to v1
Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi since
monitor HDMI information is available after EDID is parsed. Additionally
rewrite the code the code to have fewer indentation levels.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 18
Changes the raydium-rm69380 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-raydium-rm69380.c | 95 ++-
1 file changed, 30 insertions(+), 65 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-raydium
On 9/7/24 3:53 AM, Jessica Zhang wrote:
>
>
> On 9/6/2024 3:14 PM, Jessica Zhang wrote:
>>
>>
>> On 9/4/2024 7:15 AM, Tejas Vipin wrote:
>>> Changes the himax-hx83112a panel to use multi style functions for
>>> improved error handling.
>>
Changes the himax-hx83112a panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-himax-hx83112a.c | 297 +--
1 file changed, 136 insertions(+), 161 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-himax
Changes the samsung-s6e3fa7 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-samsung-s6e3fa7.c | 71 ++-
1 file changed, 21 insertions(+), 50 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-samsung
Changes the novatek-nt35950 panel to use multi style functions for
improved error handling.
Reviewed-by: Neil Armstrong
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Style changes
- Fixed changes in logic
v1: https://lore.kernel.org/all/20240824084422.202946-1-tejasvipi...@gmail.com
Changes the novatek-nt35950 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-novatek-nt35950.c | 214 ++
1 file changed, 70 insertions(+), 144 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-novatek
Converts uppercase hex to lowercase hex for cleanup.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
b/drivers/gpu/drm/panel/panel
Changes the mantix-mlaf057we51 panel to use multi style functions for
improved error handling.
Reviewed-by: Guido Günther
Reviewed-by: Douglas Anderson
Signed-off-by: Tejas Vipin
---
.../gpu/drm/panel/panel-mantix-mlaf057we51.c | 77 +++
1 file changed, 26 insertions(+), 51
Uses mipi_dsi_*_multi function in the mantix-mlaf057we51 panel and
converting uppercase hex to lowercase hex for cleanup.
---
Changes in v2:
- Split cleanup changes into separate patch
v1: https://lore.kernel.org/all/20240818072356.870465-1-tejasvipi...@gmail.com/
---
Tejas Vipin (2):
drm
Changes the mantix-mlaf057we51 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
.../gpu/drm/panel/panel-mantix-mlaf057we51.c | 79 +++
1 file changed, 27 insertions(+), 52 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel
Changes the jdi-fhd-r63452 panel to use multi style functions for
improved error handling.
Reviewed-by: Douglas Anderson
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 149 ++-
1 file changed, 48 insertions(+), 101 deletions(-)
diff --git a
mipi_dsi_dcs_set_tear_scanline_multi can heavily benefit from being
converted to a multi style function as it is often called in the context of
similar functions.
Reviewed-by: Douglas Anderson
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c | 31
/
---
Tejas Vipin (2):
drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi
drm/panel: jdi-fhd-r63452: transition to mipi_dsi wrapped functions
drivers/gpu/drm/drm_mipi_dsi.c | 31
drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 149 ++-
include/drm
Changes the jdi-fhd-r63452 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 150 ++-
1 file changed, 49 insertions(+), 101 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd
mipi_dsi_dcs_set_tear_scanline_multi can heavily benefit from being
converted to a multi style function as it is often called in the context of
similar functions.
Reviewed-by: Douglas Anderson
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c | 31
...@gmail.com/
---
Changes in v2:
- Fixed return values
- Removed extra error messages
v1: https://lore.kernel.org/all/20240810045404.188146-1-tejasvipi...@gmail.com/
---
Tejas Vipin (2):
drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi
drm/panel: jdi-fhd-r63452: transition to mipi_dsi
Changes the jdi-fhd-r63452 panel to use multi style functions for
improved error handling.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 125 ++-
1 file changed, 39 insertions(+), 86 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd
mipi_dsi_dcs_set_tear_scanline_multi can heavily benefit from being
converted to a multi style function as it is often called in the context of
similar functions.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c | 31 +++
include/drm/drm_mipi_dsi.h
This patch adds mipi_dsi_dcs_set_tear_scanline_multi to the list of multi
functions and uses it with other multi functions in the jdi-fhd-r63452
panel.
Tejas Vipin (2):
drm/mipi-dsi: Add mipi_dsi_dcs_set_tear_scanline_multi
drm/panel: jdi-fhd-r63452: transition to mipi_dsi wrapped functions
Use multi style wrapped functions for mipi_dsi in the
startek-kd070fhfid015 panel.
Signed-off-by: Tejas Vipin
---
.../drm/panel/panel-startek-kd070fhfid015.c | 115 ++
1 file changed, 35 insertions(+), 80 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-startek
...@gmail.com/
---
Tejas Vipin (2):
drm/mipi-dsi: add more multi functions for better error handling
drm/panel: startek-kd070fhfid015: transition to mipi_dsi wrapped
functions
drivers/gpu/drm/drm_mipi_dsi.c| 194 ++
.../drm/panel/panel-startek-kd070fhfid015.c
Add more functions that can benefit from being multi style and mark
older variants as deprecated to eventually convert all mipi_dsi functions
to multi style.
Acked-by: Maxime Ripard
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c | 194 +
include
On 8/1/24 4:39 PM, Jani Nikula wrote:
> On Tue, 30 Jul 2024, Tejas Vipin wrote:
>> Add more functions that can benefit from being multi style and mark
>> older variants as deprecated to eventually convert all mipi_dsi functions
>> to multi style.
>
> What?
>
&g
On 8/1/24 2:59 AM, Doug Anderson wrote:
> Hi,
>
> On Mon, Jul 29, 2024 at 11:07 PM Tejas Vipin wrote:
>> +/**
>> + * mipi_dsi_dcs_get_display_brightness_multi() - gets the current
>> brightness value
>> + *of the display
>> + * @ctx
Use multi style wrapped functions for mipi_dsi in the
startek-kd070fhfid015 panel.
Signed-off-by: Tejas Vipin
---
.../drm/panel/panel-startek-kd070fhfid015.c | 123 ++
1 file changed, 39 insertions(+), 84 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-startek
Add more functions that can benefit from being multi style and mark
older variants as deprecated to eventually convert all mipi_dsi functions
to multi style.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c | 226 +
include/drm/drm_mipi_dsi.h
transition
---
Tejas Vipin (2):
drm/mipi-dsi: add more multi functions for better error handling
drm/panel: startek-kd070fhfid015: transition to mipi_dsi wrapped
functions
drivers/gpu/drm/drm_mipi_dsi.c| 226 ++
.../drm/panel/panel-startek-kd070fhfid015.c
Changes all the multi functions to check if the current context requires
errors to be printed or not using the quiet member.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b
multi functions without any loss of
functionality once all the panels are changed to use multi functions.
Tejas Vipin (2):
drm/mipi-dsi: Add quiet member to mipi_dsi_multi_context struct
drm/mipi-dsi: Change multi functions to use quiet member of
mipi_dsi_multi_context
drivers/gpu/drm
A "quiet" member is added to mipi_dsi_multi_context which allows
silencing all the errors printed by the multi functions.
Signed-off-by: Tejas Vipin
---
include/drm/drm_mipi_dsi.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/drm/drm_mipi_dsi.h b/i
or message and just stringify the function name for the
> error message?
>
The problem with any macro solution that defines new multi functions is
that it creates a lot of bloat. Defining the function through macros
might be smaller than defining them manually, but there are still twice
as many function declarations as there would be if we went all multi.
The generated code is still just as big as if we manually defined
everything. I think a macro that defines functions should be more of a
last resort if we don't have any other options.
> -Doug
--
Tejas Vipin
On 7/16/24 10:31 PM, Dmitry Baryshkov wrote:
> On Tue, Jul 16, 2024 at 07:01:17PM GMT, Tejas Vipin wrote:
>> Introduce 2 new macros, DSI_CTX_NO_OP and MIPI_DSI_ADD_MULTI_VARIANT.
>>
>> DSI_CTX_NO_OP calls a function only if the context passed to it hasn't
>>
i_dsi function that follows a certain style. This allows us to
greatly reduce the amount of redundant code written for each multi
function. It reduces the overhead for a developer introducing new
mipi_dsi_*_multi functions.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c
On 7/9/24 5:50 AM, Doug Anderson wrote:
> Hi,
>
> On Fri, Jun 28, 2024 at 11:25 AM Tejas Vipin wrote:
>>
>> +/**
>> + * mipi_dsi_dcs_set_page_address_multi() - define the column extent of the
>> + * frame memory accessed by the host processor
>
Use multi style wrapped functions for mipi_dsi in the
startek-kd070fhfid015 panel.
Signed-off-by: Tejas Vipin
---
.../drm/panel/panel-startek-kd070fhfid015.c | 107 ++
1 file changed, 35 insertions(+), 72 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-startek
Add more functions that can benefit from being multi style, which
reduces code size in panels where they appear.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/drm_mipi_dsi.c | 164 +
include/drm/drm_mipi_dsi.h | 10 ++
2 files changed, 174 insertions
This series adds more multi style functions and uses them in the
startek-kd070fhfid015 panel effectively.
Tejas Vipin (2):
drm/mipi-dsi: add more multi functions for better error handling
drm/panel: startek-kd070fhfid015: transition to mipi_dsi wrapped
functions
drivers/gpu/drm
Sorry, didn't intend to send this. please ignore it :p
On 6/28/24 11:42 PM, Tejas Vipin wrote:
> Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi:
> Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
> ("drm/mipi-dsi: wrap more functions
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi:
Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling") for the
asus-z00t-tm5p5-n35596 panel.
Signed-off-by: Tejas Vipin
---
.../drm/panel/p
Hi,
On 6/26/24 5:55 PM, Guido Günther wrote:
> Hi,
> On Wed, Jun 26, 2024 at 10:22:41AM +0530, Tejas Vipin wrote:
>> Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi:
>> Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
>> (&quo
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi:
Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling") for
sitronix-st7703 based panels.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi:
Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling") for the
asus-z00t-tm5p5-n35596 panel.
Signed-off-by: Tejas Vipin
---
.../drm/panel/p
pare() is changed to
properly power the panel off in the case of a wider range of
initialization commands failing than before.
Reviewed-by: Dmitry Baryshkov
Reviewed-by: Douglas Anderson
Signed-off-by: Tejas Vipin
---
Changes in v3:
- Remove extra blank line
- Expanded on error handling fu
On 6/19/24 12:06 PM, Dmitry Baryshkov wrote:
> On Wed, Jun 19, 2024 at 09:03:49AM GMT, Tejas Vipin wrote:
>> Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce
>> mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
>> ("drm/mipi-dsi
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce
mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling") for the
raydium rm692e5 panel.
Signed-off-by: Tejas Vipin
---
Changes in v2:
-
On 6/18/24 7:06 PM, Doug Anderson wrote:
> Hi,
>
> On Tue, Jun 18, 2024 at 5:25 AM Tejas Vipin wrote:
>>
>>>> rm692e5_reset(ctx);
>>>>
>>>> - ret = rm692e5_on(ctx);
>>>> - if (ret < 0) {
>>
On 6/18/24 1:36 AM, Doug Anderson wrote:
> Hi,
>
> On Sat, Jun 15, 2024 at 2:40 AM Tejas Vipin wrote:
>>
>> @@ -168,48 +147,38 @@ static int rm692e5_prepare(struct drm_panel *panel)
>> struct rm692e5_panel *ctx = to_rm692e5_panel(panel);
>> str
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce
mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling") for the
raydium rm692e5 panel.
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce
mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling") for the
sony tulip truly nt35521 panel.
Reviewed-by: Douglas Anderson
Signed
s ctx by reference (similar to
other functions), mipi_dsi_msleep can be modified to treat ctx as a
pointer and do it correctly, and the other calls to this macro can be
adjusted accordingly.
Tejas Vipin (2):
drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep
drm/mipi-dsi
mipi_dsi_msleep should be modified to accept ctx as a pointer and the
function call should be adjusted accordingly.
Fixes: a2ab7cb169da3 ("drm/panel: himax-hx83102: use wrapped MIPI DCS
functions")
Signed-off-by: Tejas Vipin
---
drivers/gpu/drm/panel/panel-himax-hx83102.c | 6 +++-
ctx would be better off treated as a pointer to account for most of its
usage so far, and brackets should be added to account for operator
precedence for correct evaluation.
Fixes: f79d6d28d8fe7 ("drm/mipi-dsi: wrap more functions for streamline
handling")
Signed-off-by: T
mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a
value and not as a reference.
Fixes: a2ab7cb169da ("drm/panel: himax-hx83102: use wrapped MIPI DCS functions")
Signed-off-by: Tejas Vipin
---
Changes in v2:
- Add Fixes tag
v1: https://lore.kernel.org/al
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce
mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe
("drm/mipi-dsi: wrap more functions for streamline handling") for the
sony tulip truly nt35521 panel.
Signed-off-by: Tejas Vipin
---
Changes in
1 - 100 of 102 matches
Mail list logo
