Re: [PATCH] drm/i915: Don't set PIPE_CONTROL_FLUSH_L3 for aux inval

2023-09-26 Thread Tapani Pälli
Fixes all regressions we saw, I also run some extra vulkan and GL workloads, no regressions observed. Tested-by: Tapani Pälli On 26.9.2023 17.24, Nirmoy Das wrote: PIPE_CONTROL_FLUSH_L3 is not needed for aux invalidation so don't set that. Fixes: 78a6ccd65fa3 ("drm/i915/gt: Ens

Re: [PATCH] drm/i915: Remove unnecessary memory quiescing for aux inval

2023-09-20 Thread Tapani Pälli
I tested this first against tests that were failing for Mesa and it fixes all of the regressed cases (TGL LP). Also did a full run of all KHR-GLES31* and KHR-GLES32* test groups in the Khronos CTS suite, no regressions observed. Tested-by: Tapani Pälli On 20.9.2023 14.11, Nirmoy Das wrote

Re: [PATCH] drm/i915: Fix aux invalidation with proper pipe_control flag

2023-09-19 Thread Tapani Pälli
line. Cc: Jonathan Cavitt Cc: Andi Shyti Cc: # v5.8+ Cc: Nirmoy Das Cc: Andrzej Hajda Cc: Tvrtko Ursulin Cc: Matt Roper Cc: Lucas De Marchi Cc: Tejas Upadhyay Cc: Prathap Kumar Valsan Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti and I believe Tested-by: Tapani Pälli Yes, tes

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Tapani Pälli
On 3/18/19 3:25 PM, Robert Foss wrote: Hey, On 3/18/19 2:11 PM, Mauro Rossi wrote: Hi, On Mon, Mar 18, 2019 at 10:58 AM Robert Foss wrote: Hey Mauro, On 3/18/19 9:38 AM, Mauro Rossi wrote: Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: On a second note, this does no

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Tapani Pälli
It seems like there is no usage of __android_log_vprint in upstream libdrm. Perhaps this was against libdrm with some android specific changes on top? On 3/17/19 10:50 PM, Mauro Rossi wrote: Fixes the following building error: FAILED: $(OUT)/obj/SHARED_LIBRARIES/libdrm_platform_intermediates

Re: [PATCH libdrm] libkms: update list of intel_drivers for Android build

2019-03-03 Thread Tapani Pälli
ping! On 2/21/19 8:56 AM, Tapani Pälli wrote: Add new iris driver, remove deprecated ilo driver. Signed-off-by: Tapani Pälli --- libkms/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libkms/Android.mk b/libkms/Android.mk index 0be72054..a8b9489f 100644 --- a

[PATCH libdrm] libkms: update list of intel_drivers for Android build

2019-02-20 Thread Tapani Pälli
Add new iris driver, remove deprecated ilo driver. Signed-off-by: Tapani Pälli --- libkms/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libkms/Android.mk b/libkms/Android.mk index 0be72054..a8b9489f 100644 --- a/libkms/Android.mk +++ b/libkms/Android.mk @@ -1,6

[PATCH libdrm] libkms: remove ilo from list of intel_drivers

2018-12-17 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- (Driver was removed from Mesa long time ago.) libkms/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libkms/Android.mk b/libkms/Android.mk index 0be72054..bf4781a3 100644 --- a/libkms/Android.mk +++ b/libkms/Android.mk @@ -1,6 +1,6

Re: [PATCH v6 1/2] drm_fourcc: Add new P010, P016 video format

2017-10-23 Thread Tapani Pälli
On 10/17/2017 02:43 PM, ayaka wrote: On 10/12/2017 07:56 PM, Tapani Pälli wrote: Is this one going to land soon? The discussion was a bit hard to read but it looks like in the end consensus was that everything looks good in this patch. I am very sorry, I am too busy with  the other dma

Re: [PATCH v6 1/2] drm_fourcc: Add new P010, P016 video format

2017-10-12 Thread Tapani Pälli
Is this one going to land soon? The discussion was a bit hard to read but it looks like in the end consensus was that everything looks good in this patch. Thanks; On 03/01/2017 01:21 AM, clinton.a.tay...@intel.com wrote: From: Clint Taylor P010 is a planar 4:2:0 YUV with interleaved UV pla

Re: drm_hwcomposer moving to fd.o

2017-09-28 Thread Tapani Pälli
On 09/28/2017 10:35 AM, Tomeu Vizoso wrote: On 09/28/2017 09:08 AM, Daniel Vetter wrote: On Thu, Sep 28, 2017 at 8:49 AM, Chih-Wei Huang wrote: 2017-09-26 13:26 GMT+08:00 Daniel Vetter : On Mon, Sep 25, 2017 at 09:06:55AM +0200, Tomeu Vizoso wrote: On 09/25/2017 04:44 AM, Chih-Wei Huang wr

[Bug 92173] [regression, bisected] commit 266d05a broke WebGL-Water Caustics on NI/Turks (6670)

2015-09-30 Thread Tapani Pälli
On 09/30/2015 03:39 PM, Dieter Nützel wrote: > Hello Tapani, > > this was your patch. > Any comments? > It is probably a duplicate bug for 92173. I've sent a patch to mesa-dev which should fix the issue: http://lists.freedesktop.org/archives/mesa-dev/2015-September/095521.html > Thanks, > Di

[PATCH 1/3] remove usage of 'c_plusplus' preprocessor macro

2015-08-07 Thread Tapani Pälli
On 08/07/2015 03:11 PM, Thierry Reding wrote: > On Fri, Aug 07, 2015 at 10:37:56AM +0300, Tapani Pälli wrote: >> Use only __cplusplus which is supported by the C++ standard. >> >> Signed-off-by: Tapani Pälli >> --- >> libkms/libkms.h | 4 ++-- >> xf86drm.h | 4 ++-- >> xf86drmMode.h

[PATCH 3/3] modeprint: cleanup, remove compile warnings

2015-08-07 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- tests/modeprint/modeprint.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/modeprint/modeprint.c b/tests/modeprint/modeprint.c index e6c6553..5e953f7 100644 --- a/tests/modeprint/modeprint.c +++ b/tests/modeprint/modeprint.c @@ -61,6

[PATCH 2/3] intel: wrap intel_bufmgr.h C code for C++ compilation/linking

2015-08-07 Thread Tapani Pälli
We need this include in porting changes for the OpenGL ES conformance suite. v2: remove c_plusplus usage Signed-off-by: Tapani Pälli --- intel/intel_bufmgr.h | 8 1 file changed, 8 insertions(+) diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h index 285919e..95eecb8 100644 --

[PATCH 1/3] remove usage of 'c_plusplus' preprocessor macro

2015-08-07 Thread Tapani Pälli
Use only __cplusplus which is supported by the C++ standard. Signed-off-by: Tapani Pälli --- libkms/libkms.h | 4 ++-- xf86drm.h | 4 ++-- xf86drmMode.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libkms/libkms.h b/libkms/libkms.h index c00b159..930a2bf 1006

[PATCH] intel: wrap intel_bufmgr.h C code for C++ compilation/linking

2015-07-27 Thread Tapani Pälli
On 07/03/2015 06:44 PM, Emil Velikov wrote: > On 01/07/15 12:37, Tapani Pälli wrote: >> (We need this include in porting changes for the OpenGL ES >> conformance suite.) >> >> Signed-off-by: Tapani Pälli >> --- >> intel/intel_bufmgr.h | 8 >> 1 file changed, 8 insertions(+) >> >> dif

[PATCH] intel: wrap intel_bufmgr.h C code for C++ compilation/linking

2015-07-01 Thread Tapani Pälli
(We need this include in porting changes for the OpenGL ES conformance suite.) Signed-off-by: Tapani Pälli --- intel/intel_bufmgr.h | 8 1 file changed, 8 insertions(+) diff --git a/intel/intel_bufmgr.h b/intel/intel_bufmgr.h index 285919e..f061454 100644 --- a/intel/intel_bufmgr.h ++

[PATCH 0/3] Android support

2012-10-11 Thread Tapani Pälli
On 10/10/2012 08:05 PM, Chad Versace wrote: > On 10/07/2012 10:50 PM, Tapani P?lli wrote: >> Upstreaming old set of patches here to enable Android support in libdrm. >> Some little rebasing was required for the first one. >> >> Chad Versace (2): >> libdrm,intel: Factor source file lists into sour

[PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2

2012-10-11 Thread Tapani Pälli
On 10/10/2012 08:01 PM, Chad Versace wrote: > Is the only difference between v2 and v1 of this patch the removal of the > Change-ID tag? yep that is the diff (sorry for not noting it), there is the v3 as well where I've removed the [] comment per Oliver's suggestion. > On 10/08/2012 02:23 AM, Ta

Re: [PATCH 0/3] Android support

2012-10-11 Thread Tapani Pälli
On 10/10/2012 08:05 PM, Chad Versace wrote: > On 10/07/2012 10:50 PM, Tapani Pälli wrote: >> Upstreaming old set of patches here to enable Android support in libdrm. >> Some little rebasing was required for the first one. >> >> Chad Versace (2): >> libdrm,int

Re: [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2

2012-10-11 Thread Tapani Pälli
10/08/2012 02:23 AM, Tapani Pälli wrote: >> From: Haitao Huang >> >> Export necessary header files used by other components for Android, >> such as libva intel-driver, gralloc, hwcomposer, etc. >> >> Signed-off-by: Haitao Huang >> [chad: Fi

[PATCH 0/3] Android support

2012-10-09 Thread Tapani Pälli
On 10/08/2012 06:37 PM, Eric Anholt wrote: > Tapani P?lli writes: > >> Upstreaming old set of patches here to enable Android support in libdrm. >> Some little rebasing was required for the first one. >> >> Chad Versace (2): >> libdrm,intel: Factor source file lists into sources.mk >> libdrm,i

Re: [PATCH 0/3] Android support

2012-10-08 Thread Tapani Pälli
On 10/08/2012 06:37 PM, Eric Anholt wrote: > Tapani Pälli writes: > >> Upstreaming old set of patches here to enable Android support in libdrm. >> Some little rebasing was required for the first one. >> >> Chad Versace (2): >> libdrm,intel: Factor source fi

[PATCH v3 3/3] Android.mk: use LOCAL_COPY_HEADERS to export headers.

2012-10-08 Thread Tapani Pälli
From: Haitao Huang Export necessary header files used by other components for Android, such as libva intel-driver, gralloc, hwcomposer, etc. Signed-off-by: Haitao Huang Signed-off-by: Chad Versace --- [chad: Fixed inconsistent indentation.] Android.mk | 12 +++- 1 file changed, 11 ins

[PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2

2012-10-08 Thread Tapani Pälli
On 10/08/2012 02:43 PM, Oliver McFadden wrote: > On Mon, Oct 08, 2012 at 12:23:56PM +0300, Tapani P?lli wrote: >> From: Haitao Huang >> >> Export necessary header files used by other components for Android, >> such as libva intel-driver, gralloc, hwcomposer, etc. >> >> Signed-off-by: Haitao Huang

[PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2

2012-10-08 Thread Tapani Pälli
From: Haitao Huang Export necessary header files used by other components for Android, such as libva intel-driver, gralloc, hwcomposer, etc. Signed-off-by: Haitao Huang [chad: Fixed inconsistent indentation.] Signed-off-by: Chad Versace --- Android.mk | 12 +++- 1 file changed, 11 ins

[PATCH 3/3] Android.mk: use LOCAL_COPY_HEADERS to export headers.

2012-10-08 Thread Tapani Pälli
From: Haitao Huang Export necessary header files used by other components for Android, such as libva intel-driver, gralloc, hwcomposer, etc. Change-Id: I2feabf6941379ef4d756e942f30eba059de641f1 Signed-off-by: Haitao Huang [chad: Fixed inconsistent indentation.] Signed-off-by: Chad Versace ---

[PATCH 2/3] libdrm,intel: Add Android makefiles (v2)

2012-10-08 Thread Tapani Pälli
From: Chad Versace This enables libdrm.so and libdrm_intel.so to build on Android IceCreamSandwich. v2: Link libdrm_intel to libpciaccess. Signed-off-by: Chad Versace --- Android.mk | 52 +++ intel/Android.mk | 57 +

[PATCH 1/3] libdrm,intel: Factor source file lists into sources.mk

2012-10-08 Thread Tapani Pälli
From: Chad Versace Factor the source file list for libdrm.so from Makefile.am into sources.mk. Ditto for libdrm_intel.so. This is in preparation for adding support for Android. The sources.mk's will be shared between autotools and Android. Rationale: The most commonly changed parts of any makef

[PATCH 0/3] Android support

2012-10-08 Thread Tapani Pälli
Upstreaming old set of patches here to enable Android support in libdrm. Some little rebasing was required for the first one. Chad Versace (2): libdrm,intel: Factor source file lists into sources.mk libdrm,intel: Add Android makefiles (v2) Haitao Huang (1): Android.mk: use LOCAL_COPY_HEADER

[PATCH v3 3/3] Android.mk: use LOCAL_COPY_HEADERS to export headers.

2012-10-08 Thread Tapani Pälli
From: Haitao Huang Export necessary header files used by other components for Android, such as libva intel-driver, gralloc, hwcomposer, etc. Signed-off-by: Haitao Huang Signed-off-by: Chad Versace --- [chad: Fixed inconsistent indentation.] Android.mk | 12 +++- 1 file changed, 11 ins

Re: [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2

2012-10-08 Thread Tapani Pälli
On 10/08/2012 02:43 PM, Oliver McFadden wrote: > On Mon, Oct 08, 2012 at 12:23:56PM +0300, Tapani Pälli wrote: >> From: Haitao Huang >> >> Export necessary header files used by other components for Android, >> such as libva intel-driver, gralloc, hwcomposer, etc. >&g

[PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2

2012-10-08 Thread Tapani Pälli
From: Haitao Huang Export necessary header files used by other components for Android, such as libva intel-driver, gralloc, hwcomposer, etc. Signed-off-by: Haitao Huang [chad: Fixed inconsistent indentation.] Signed-off-by: Chad Versace --- Android.mk | 12 +++- 1 file changed, 11 ins

[PATCH 3/3] Android.mk: use LOCAL_COPY_HEADERS to export headers.

2012-10-07 Thread Tapani Pälli
From: Haitao Huang Export necessary header files used by other components for Android, such as libva intel-driver, gralloc, hwcomposer, etc. Change-Id: I2feabf6941379ef4d756e942f30eba059de641f1 Signed-off-by: Haitao Huang [chad: Fixed inconsistent indentation.] Signed-off-by: Chad Versace ---

[PATCH 2/3] libdrm,intel: Add Android makefiles (v2)

2012-10-07 Thread Tapani Pälli
From: Chad Versace This enables libdrm.so and libdrm_intel.so to build on Android IceCreamSandwich. v2: Link libdrm_intel to libpciaccess. Signed-off-by: Chad Versace --- Android.mk | 52 +++ intel/Android.mk | 57 +

[PATCH 1/3] libdrm,intel: Factor source file lists into sources.mk

2012-10-07 Thread Tapani Pälli
f any makefile are the source lists. So, by sharing the lists between the two build systems, we can reduce the frequency at which modifications to the Linux build breaks the Android build. Signed-off-by: Chad Versace Signed-off-by: Sean V Kelley Signed-off-by: Tapani Pälli --- Makefile.am

[PATCH 0/3] Android support

2012-10-07 Thread Tapani Pälli
Upstreaming old set of patches here to enable Android support in libdrm. Some little rebasing was required for the first one. Chad Versace (2): libdrm,intel: Factor source file lists into sources.mk libdrm,intel: Add Android makefiles (v2) Haitao Huang (1): Android.mk: use LOCAL_COPY_HEADER

[PATCH] xf86drm.h : wrap C code for C++ compilation/linking

2011-09-23 Thread Tapani Pälli
To enable usage of xf86drm.h from C++ programs/frameworks. Signed-off-by: Tapani P?lli --- xf86drm.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xf86drm.h b/xf86drm.h index 20f4c78..7cdf631 100644 --- a/xf86drm.h +++ b/xf86drm.h @@ -39,6 +39,10 @@ #include

[PATCH] xf86drm.h : wrap C code for C++ compilation/linking

2011-09-23 Thread Tapani Pälli
To enable usage of xf86drm.h from C++ programs/frameworks. Signed-off-by: Tapani Pälli --- xf86drm.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/xf86drm.h b/xf86drm.h index 20f4c78..7cdf631 100644 --- a/xf86drm.h +++ b/xf86drm.h @@ -39,6 +39,10 @@ #include