Re: [PATCH] drm/amd/display: remove unreachable code

2022-08-12 Thread Tales Lelo da Aparecida
Hi, On 12/08/2022 00:19, Jiapeng Chong wrote: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:1658 dml32_TruncToValidBPP() warn: ignoring unreachable code. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1894 Reported-by: Abaci Robot Signed-off-by: Jiapeng C

Re: [PATCH 4/4] Documentation/gpu/amdgpu/amdgpu_dm: add DM docs for pixel blend mode

2022-07-17 Thread Tales Lelo da Aparecida
On 16/07/2022 19:25, Melissa Wen wrote: AMD GPU display manager (DM) maps DRM pixel blend modes (None, Pre-multiplied, Coverage) to MPC hw blocks through blend configuration options. Describe relevant elements and how to set and test them to get the expected DRM blend mode on DCN hw. Signed-off-

Re: [PATCH 3/4] drm/amd/display: add doc entries for MPC blending configuration

2022-07-17 Thread Tales Lelo da Aparecida
On 16/07/2022 19:25, Melissa Wen wrote: Describe structs and enums used to set blend mode properties to MPC blocks. Some pieces of information are already available as code comments, and were just formatted. Others were collected and summarised from discusssions on AMD issue tracker[1][2]. Typo

Re: [PATCH 2/4] Documentation/amdgpu/display: add DC color caps info

2022-07-17 Thread Tales Lelo da Aparecida
On 16/07/2022 19:25, Melissa Wen wrote: Add details about color correction capabilities and explain a bit about differences between DC hw generations and also how they are mapped between DRM and DC interface. Two schemas for DCN 2.0 and 3.0 (converted to svg from the original png) is included to

Re: [PATCH 1/4] Documentation/amdgpu_dm: Add DM color correction documentation

2022-07-17 Thread Tales Lelo da Aparecida
On 16/07/2022 19:25, Melissa Wen wrote: AMDGPU DM maps DRM color management properties (degamma, ctm and gamma) to DC color correction entities. Part of this mapping is already documented as code comments and can be converted as kernel docs. v2: - rebase to amd-staging-drm-next Reviewed-by: Har

[PATCH 2/2] MAINTAINERS: add docs entry to AMDGPU

2022-04-15 Thread Tales Lelo da Aparecida
To make sure maintainers of amdgpu drivers are aware of any changes in their documentation, add its entry to MAINTAINERS. Signed-off-by: Tales Lelo da Aparecida --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d54b9f15ffce..b3594b2a09de 100644

[PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

2022-04-15 Thread Tales Lelo da Aparecida
Add missing acronyms to the amdgppu glossary. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Signed-off-by: Tales Lelo da Aparecida --- Documentation/gpu/amdgpu/amdgpu-glossary.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/gpu

[PATCH 0/2] Update AMDGPU glossary and MAINTAINERS

2022-04-15 Thread Tales Lelo da Aparecida
I was handling the request from [0] and then I noticed that some AMD developers were missing from get_maintainers output due to the lack of a reference to their documentation in the MAINTAINERS file. [0] https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Tales Lelo da Aparecida (2

[PATCH] drm/amd/display: make hubp1_wait_pipe_read_start() static

2022-04-15 Thread Tales Lelo da Aparecida
It's a local function, let's make it static. Signed-off-by: Tales Lelo da Aparecida --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c b/drivers/gpu/drm/amd/displa

[PATCH v2 2/2] drm/vkms: return early if compose_plane fails

2022-04-15 Thread Tales Lelo da Aparecida
Do not exit quietly from compose_plane. If any plane has an invalid map, propagate the error value upwards. While here, add log messages for the invalid index. Signed-off-by: Tales Lelo da Aparecida --- drivers/gpu/drm/vkms/vkms_composer.c | 30 ++-- 1 file changed, 20

[PATCH v2 1/2] drm/vkms: check plane_composer->map[0] before using it

2022-04-15 Thread Tales Lelo da Aparecida
Fix a copypasta error. The caller of compose_plane() already checks primary_composer->map. In contrast, plane_composer->map is never verified here before handling. Fixes: 7938f4218168 ("dma-buf-map: Rename to iosys-map") Reviewed-by: André Almeida Signed-off-by: Tales Lelo da A

[PATCH v2 0/2] drm/vkms: check plane_composer->map[0] before using it

2022-04-15 Thread Tales Lelo da Aparecida
Hi, this is a follow-up of my last patch. Thanks for the reviews! Changes from v1: Edit the first commit message as suggested by Melissa and add a commit to enhance the error handling (André) Tales Lelo da Aparecida (2): drm/vkms: check plane_composer->map[0] before using it drm/v

[PATCH 1/1] drm/vkms: check plane_composer->map[0] before using it

2022-04-11 Thread Tales Lelo da Aparecida
Fix a copypasta error, which resulted in checking repeatedly if the primary_composer->map[0] was null, instead of checking each plane_composer while composing planes. Signed-off-by: Tales Lelo da Aparecida --- drivers/gpu/drm/vkms/vkms_composer.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH 0/1] drm/vkms: check plane_composer->map[0] before using it

2022-04-11 Thread Tales Lelo da Aparecida
Hello, I'm interested in collaborating with VKMS, please let me know if there's anything that I could better. Tales Lelo da Aparecida (1): drm/vkms: check plane_composer->map[0] before using it drivers/gpu/drm/vkms/vkms_composer.c | 2 +- 1 file changed, 1 insertion(+