Re: [PATCH v4 6/8] backlight: led-backlight: add devlink to supplier LEDs

2025-05-12 Thread Sverdlin, Alexander
Hi Luca, On Mon, 2025-05-12 at 13:39 +0200, Alexander Sverdlin wrote: > > led-backlight is a consumer of one or multiple LED class devices, but no > > devlink is created for such supplier-producer relationship. One consequence > > is that removal ordered is not correctly enforced. > > > > Issues

Re: [PATCH v4 6/8] backlight: led-backlight: add devlink to supplier LEDs

2025-05-12 Thread Sverdlin, Alexander
Hi Luca, On Tue, 2024-09-17 at 10:53 +0200, Luca Ceresoli wrote: > led-backlight is a consumer of one or multiple LED class devices, but no > devlink is created for such supplier-producer relationship. One consequence > is that removal ordered is not correctly enforced. > > Issues happen for exam

Re: [PATCH v10 10/13] drm/atomic-helper: Refactor crtc & encoder-bridge op loops into separate functions

2025-04-04 Thread Sverdlin, Alexander
On Wed, 2025-02-26 at 21:27 +0530, Aradhya Bhatia wrote: > From: Aradhya Bhatia > > The way any singular display pipeline, in need of a modeset, gets > enabled is as follows - > > crtc enable > (all) bridge pre-enable > encoder enable > (all) bridge enable > > - and the

Re: [PATCH 2/2] drm/bridge: ti-sn65dsi83: add h/vsync-disable support

2025-04-04 Thread Sverdlin, Alexander
Hi Rob, Dmitry, On Tue, 2025-03-11 at 15:27 +, Zini, Alessandro wrote: > > > The h/vsync-disable properties are used to control whether to use or > > > not h/vsync signals, by configuring their pulse width to zero. > > > > > > This is required on some panels which are driven in DE-only mode b

Re: [PATCH v10 11/13] drm/atomic-helper: Separate out bridge pre_enable/post_disable from enable/disable

2025-03-25 Thread Sverdlin, Alexander
On Wed, 2025-02-26 at 21:27 +0530, Aradhya Bhatia wrote: > The encoder-bridge ops occur by looping over the new connector states of > the display pipelines. The enable sequence runs as follows - > > - pre_enable(bridge), > - enable(encoder), > - enable(bridge), > > while the dis

Re: [PATCH v10 12/13] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2025-03-25 Thread Sverdlin, Alexander
On Wed, 2025-02-26 at 21:27 +0530, Aradhya Bhatia wrote: > Move the bridge pre_enable call before crtc enable, and the bridge > post_disable call after the crtc disable. > > The sequence of enable after this patch will look like: > > bridge[n]_pre_enable > ... > bridge[1]_pre_en

Re: [PATCH v6 4/4] drm/tidss: Add OLDI bridge support

2025-03-25 Thread Sverdlin, Alexander
Thank you for your work Aradhya! On Wed, 2025-02-26 at 23:43 +0530, Aradhya Bhatia wrote: > From: Aradhya Bhatia > > The AM62x and AM62Px SoCs feature 2 OLDI TXes each, which makes it > possible to connect them in dual-link or cloned single-link OLDI display > modes. The current OLDI support in

Re: [PATCH v4 0/3] drm/tidss: Add OLDI bridge support

2025-03-25 Thread Sverdlin, Alexander
Hi Aradhya! On Thu, 2025-03-20 at 18:54 +0530, Aradhya Bhatia wrote: > > I've tried to test the patchset with necessary pre-requisites and DT > > additions > > with a single channel LVDS pannel and while I'm not successful yet, I've > > also noticed > > the following warning: > > > > tidss 3020

Re: [PATCH v4 0/3] drm/tidss: Add OLDI bridge support

2025-03-20 Thread Sverdlin, Alexander
Hi Aradhya! On Thu, 2025-03-20 at 18:54 +0530, Aradhya Bhatia wrote: > While you have mentioned that you did add the prerequisites, could you > confirm that you applied the (now older) dependency patch mentioned in > the v4 cover-letter[1]? > Ideally, you should not observe these concerns if [1] w

Re: [PATCH v4 0/3] drm/tidss: Add OLDI bridge support

2025-03-19 Thread Sverdlin, Alexander
Thank you for the patches, Aradhya! On Sun, 2024-11-24 at 20:06 +0530, Aradhya Bhatia wrote: > Regardless, I'd appreciate it if somebody can test it, and report back if they > observe any issues. I've tried to test the patchset with necessary pre-requisites and DT additions with a single channel

Re: [PATCH v4 3/3] drm/tidss: Add OLDI bridge support

2025-03-18 Thread Sverdlin, Alexander
Hi Aradhya! On Sun, 2024-11-24 at 20:06 +0530, Aradhya Bhatia wrote: > From: Aradhya Bhatia > > The AM62x and AM62Px SoCs feature 2 OLDI TXes each, which makes it > possible to connect them in dual-link or cloned single-link OLDI display > modes. The current OLDI support in tidss_dispc.c can onl

Re: [PATCH v4 2/2] leds: lp8864: New driver

2024-12-18 Thread Sverdlin, Alexander
Hi Andrew! On Tue, 2024-12-17 at 09:56 -0600, Andrew Davis wrote: > > +static int lp8864_fault_check(struct lp8864_led *led) > > +{ > > + int ret, i; > > + unsigned int val; > > + > > + ret = regmap_read(led->regmap, LP8864_SUPPLY_STATUS, &val); > > + if (ret) > > + goto err; >

Re: [PATCH v4 2/2] leds: lp8864: New driver

2024-12-17 Thread Sverdlin, Alexander
Hi Andrew! On Tue, 2024-12-17 at 09:56 -0600, Andrew Davis wrote: > On 12/17/24 7:37 AM, A. Sverdlin wrote: > > From: Alexander Sverdlin > > > > Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers > > with I2C interface. > > > > Link: https://www.ti.com/lit/gpn/lp8864-q1

Re: [PATCH v4 5/8] i2c: i2c-core-of: follow i2c-parent phandle to probe devices from added nodes

2024-12-13 Thread Sverdlin, Alexander
Hi Luca! On Fri, 2024-12-13 at 12:28 +0100, Luca Ceresoli wrote: > > > However for hotplug connectors described via device tree overlays there is > > > additional level of indirection, which is needed to decouple the overlay > > > and the base tree: > > > > > >    --- base device tree --- > > >

Re: [PATCH v3 2/2] leds: lp8864: New driver

2024-12-12 Thread Sverdlin, Alexander
Hi Lee! On Thu, 2024-12-12 at 18:59 +, Lee Jones wrote: > On Mon, 09 Dec 2024, A. Sverdlin wrote: > > > From: Alexander Sverdlin > > > > Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers > > with I2C interface. > > > > Link: https://www.ti.com/lit/gpn/lp8864-q1 >

Re: [PATCH v4 5/8] i2c: i2c-core-of: follow i2c-parent phandle to probe devices from added nodes

2024-12-12 Thread Sverdlin, Alexander
Hi Luca! On Tue, 2024-09-17 at 10:53 +0200, Luca Ceresoli wrote: > When device tree nodes are added, the I2C core tries to probe client > devices based on the classic DT structure: > > i2c@abcd { > some-client@42 { compatible = "xyz,blah"; ... }; > }; > > However for hotplug connec

Re: [PATCH v2 0/2] leds: TI LP8864/LP8866 support

2024-12-06 Thread Sverdlin, Alexander
On Fri, 2024-12-06 at 22:24 +0100, A. Sverdlin wrote: > From: Alexander Sverdlin > > The series adds support for a family of Texas Instruments' automotive > high-efficiency LED drivers with boost controller. The four or six > high-precision current sinks support phase shifting that is automatical

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Sverdlin, Alexander
Hi Andrew, On Fri, 2024-12-06 at 12:02 -0600, Andrew Davis wrote: > On 12/6/24 11:46 AM, Sverdlin, Alexander wrote: > > Hi Andrew, > > > > On Fri, 2024-12-06 at 11:43 -0600, Andrew Davis wrote: > > > > Are you sure this is a correct thing to do? The lp8860-q1

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Sverdlin, Alexander
Hi Andrew, On Fri, 2024-12-06 at 11:43 -0600, Andrew Davis wrote: > > Are you sure this is a correct thing to do? The lp8860-q1 product link > > cites it as being a 4-channel device. Even if the kernel only ever > > supports it as a single-channel device, the binding should reflect what > > it is

Re: [PATCH 1/2] dt-bindings: backlight: Convert LP8860 into YAML format adding LP886x

2024-12-06 Thread Sverdlin, Alexander
Hello Conor, On Fri, 2024-12-06 at 17:14 +, Conor Dooley wrote: > > Add Texas Instruments' LP8864/LP8866 bindings into LP8860 converting them > > into YAML format simultaneously. While here, drop the index of the "led" > > subnode, this one is neither used nor mandated by the drivers. All the

Re: [PATCH] drm/vmwgfx: Keep a gem reference to user bos in surfaces

2023-12-21 Thread Sverdlin, Alexander
Hi Zack, thank you for the patch! On Thu, 2023-09-28 at 00:13 -0400, Zack Rusin wrote: > From: Zack Rusin > > Surfaces can be backed (i.e. stored in) memory objects (mob's) which > are created and managed by the userspace as GEM buffers. Surfaces > grab only a ttm reference which means that the

Re: [PATCH] drm/sched: Fix compilation issues with DRM priority rename

2023-11-29 Thread Sverdlin, Alexander
Hi Luben, thanks for the patch! On Sat, 2023-11-25 at 14:22 -0500, Luben Tuikov wrote: > Fix compilation issues with DRM scheduler priority rename MIN to LOW. > > Signed-off-by: Luben Tuikov > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202311252109.wgbjss

Re: [PATCH 1/3] drm/rockchip: lvds: add rk3568 support

2023-01-20 Thread Sverdlin, Alexander
Hello Sascha, On Fri, 2023-01-20 at 10:16 +0100, Sascha Hauer wrote: > > +   /* Enable LVDS mode */ > > +   return regmap_update_bits(lvds->grf, RK3568_GRF_VO_CON2, > > + RK3568_LVDS0_MODE_EN(1), > > + RK3568_LVDS0_MODE_EN(1))