; 1 file changed, 54 insertions(+), 40 deletions(-)
Reviewed-by: Sumit Garg
-Sumit
>
> diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c
> index 685afcaa3ea1..820e394b9054 100644
> --- a/drivers/tee/tee_core.c
> +++ b/drivers/tee/tee_core.c
> @@ -353,6 +353,55 @@ tee_ioc
Hi Jens,
On Fri, May 02, 2025 at 11:59:17AM +0200, Jens Wiklander wrote:
> The OP-TEE backend driver has two internal function pointers to convert
> between the subsystem type struct tee_param and the OP-TEE type struct
> optee_msg_param.
>
> The conversion is done from one of the types to the ot
> include/linux/tee_core.h | 4 +++
> include/linux/tee_drv.h | 6
> include/uapi/linux/tee.h | 41 +++
> 4 files changed, 130 insertions(+), 6 deletions(-)
Minor nits from me below, otherwise this looks reasonable new IOCTL
interface to me. FWIW:
Reviewed
On Wed, Apr 09, 2025 at 05:20:08PM +1000, Amirreza Zarrabi wrote:
>
>
> On 4/9/2025 4:41 PM, Jens Wiklander wrote:
> > Hi Amirreza,
> >
> > On Wed, Apr 9, 2025 at 2:28 AM Amirreza Zarrabi
> > wrote:
> >>
> >> Hi jens,
> >>
> >> On 4/8/2025 10:19 PM, Jens Wiklander wrote:
> >>
> >> Hi Amirreza,
On Thu, Mar 27, 2025 at 07:47:24PM -0700, Amirreza Zarrabi wrote:
> The tee_context can be used to manage TEE user resources, including
> those allocated by the driver for the TEE on behalf of the user.
> The release() callback is invoked only when all resources, such as
> tee_shm, are released and
n for tee_device_alloc(), it is not handled correctly.
>
> Signed-off-by: Amirreza Zarrabi
> ---
> drivers/tee/tee_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Sumit Garg
-Sumit
> diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.
On Tue, Apr 01, 2025 at 02:26:59PM +0200, Jens Wiklander wrote:
> On Tue, Apr 1, 2025 at 12:13 PM Sumit Garg wrote:
> >
> > + MM folks to seek guidance here.
> >
> > On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote:
> > > Hi Sumit,
> > >
Thanks David for your response.
On Wed, Apr 09, 2025 at 12:01:21PM +0200, David Hildenbrand wrote:
> On 01.04.25 12:13, Sumit Garg wrote:
> > + MM folks to seek guidance here.
> >
> > On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote:
> > > Hi Sumi
On Tue, Apr 08, 2025 at 03:28:45PM +0200, Jens Wiklander wrote:
> On Tue, Apr 8, 2025 at 11:14 AM Sumit Garg wrote:
> >
> > On Tue, Apr 01, 2025 at 10:33:04AM +0200, Jens Wiklander wrote:
> > > On Tue, Apr 1, 2025 at 9:58 AM Sumit Garg wrote:
> > > >
> &
On Tue, Apr 01, 2025 at 10:33:04AM +0200, Jens Wiklander wrote:
> On Tue, Apr 1, 2025 at 9:58 AM Sumit Garg wrote:
> >
> > On Tue, Mar 25, 2025 at 11:55:46AM +0100, Jens Wiklander wrote:
> > > Hi Sumit,
> > >
> >
> >
> >
> >
On Thu, Mar 20, 2025 at 02:00:57PM +0100, Jens Wiklander wrote:
> Hi Sumit,
>
> On Thu, Mar 20, 2025 at 10:25 AM Sumit Garg wrote:
> >
> > Hi Jens,
> >
> > On Mon, Mar 17, 2025 at 08:42:01AM +0100, Jens Wiklander wrote:
> > > Hi Sumit,
> > >
On Tue, Mar 25, 2025 at 09:50:35AM +0100, Jens Wiklander wrote:
> On Tue, Mar 25, 2025 at 6:56 AM Sumit Garg wrote:
> >
> > On Thu, Mar 20, 2025 at 02:00:57PM +0100, Jens Wiklander wrote:
> > > Hi Sumit,
> > >
> > > On Thu, Mar 20, 2025 at 10:25 AM
On Tue, Mar 25, 2025 at 11:55:46AM +0100, Jens Wiklander wrote:
> Hi Sumit,
>
>
> >
> > > +
> > > +#include "tee_private.h"
> > > +
> > > +struct tee_dma_heap {
> > > + struct dma_heap *heap;
> > > + enum tee_dma_heap_id id;
> > > + struct tee_rstmem_pool *pool;
> > > + struct
On Tue, Mar 25, 2025 at 12:17:20PM +0100, Jens Wiklander wrote:
> Hi Sumit,
>
> On Tue, Mar 25, 2025 at 7:50 AM Sumit Garg wrote:
> >
> > Hi Jens,
> >
> > On Wed, Mar 05, 2025 at 02:04:12PM +0100, Jens Wiklander wrote:
> > > From: Etienne Carriere
+ MM folks to seek guidance here.
On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote:
> Hi Sumit,
>
> On Tue, Mar 25, 2025 at 8:42 AM Sumit Garg wrote:
> >
> > On Wed, Mar 05, 2025 at 02:04:15PM +0100, Jens Wiklander wrote:
> > > Add support in the
On Wed, Mar 05, 2025 at 02:04:16PM +0100, Jens Wiklander wrote:
> Add support in the OP-TEE backend driver for dynamic restricted memory
> allocation using the SMC ABI.
>
> Signed-off-by: Jens Wiklander
> ---
> drivers/tee/optee/smc_abi.c | 96 +++--
> 1 file chan
On Wed, Mar 05, 2025 at 02:04:15PM +0100, Jens Wiklander wrote:
> Add support in the OP-TEE backend driver dynamic restricted memory
> allocation with FF-A.
>
> The restricted memory pools for dynamically allocated restrict memory
> are instantiated when requested by user-space. This instantiation
On Wed, Mar 05, 2025 at 02:04:14PM +0100, Jens Wiklander wrote:
> Add support in the OP-TEE backend driver for restricted memory
> allocation. The support is limited to only the SMC ABI and for secure
> video buffers.
>
> OP-TEE is probed for the range of restricted physical memory and a
> memory
Hi Jens,
On Wed, Mar 05, 2025 at 02:04:13PM +0100, Jens Wiklander wrote:
> Add tee_shm_alloc_cma_phys_mem() to allocate a physical memory using
> from the default CMA pool. The memory is represented by a tee_shm object
> using the new flag TEE_SHM_CMA_BUF to identify it as physical memory
> from C
Hi Jens,
On Wed, Mar 05, 2025 at 02:04:12PM +0100, Jens Wiklander wrote:
> From: Etienne Carriere
>
> Enable userspace to create a tee_shm object that refers to a dmabuf
> reference.
>
> Userspace registers the dmabuf file descriptor as in a tee_shm object.
> The registration is completed with
Hi Jens,
On Wed, Mar 05, 2025 at 02:04:11PM +0100, Jens Wiklander wrote:
> Implement DMA heap for restricted DMA-buf allocation in the TEE
> subsystem.
>
> Restricted memory refers to memory buffers behind a hardware enforced
> firewall. It is not accessible to the kernel during normal circumstan
Hi Jens,
It has taken a bit of time for me to review this patch-set as I am
settling in my new role.
On Wed, Mar 05, 2025 at 02:04:10PM +0100, Jens Wiklander wrote:
> Update the header files describing the secure world ABI, both with and
> without FF-A. The ABI is extended to deal with restricted
Hi Jens,
On Mon, Mar 17, 2025 at 08:42:01AM +0100, Jens Wiklander wrote:
> Hi Sumit,
>
> On Thu, Mar 13, 2025 at 11:41 AM Sumit Garg wrote:
> >
> > Hi Jens,
> >
> > On Wed, Mar 05, 2025 at 02:04:09PM +0100, Jens Wiklander wrote:
> > > The OP-TEE backend
Hi Jens,
On Wed, Mar 05, 2025 at 02:04:09PM +0100, Jens Wiklander wrote:
> The OP-TEE backend driver has two internal function pointers to convert
> between the subsystem type struct tee_param and the OP-TEE type struct
> optee_msg_param.
>
> The conversion is done from one of the types to the ot
e/optee/ffa_abi.c | 8
> drivers/tee/optee/smc_abi.c | 4 ++--
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Sumit Garg
-Sumit
> diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c
> index f3af5666bb11..4ca1d5161b82 100644
> --- a/driv
---
> drivers/tee/tee_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Sumit Garg
-Sumit
> diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c
> index d113679b1e2d..685afcaa3ea1 100644
> --- a/drivers/tee/tee_core.c
> +++ b/drivers/tee/tee_core.c
On Tue, Mar 04, 2025 at 08:17:23AM +0100, Jens Wiklander wrote:
> Hi Daniel,
>
> On Fri, Feb 21, 2025 at 3:12 PM Daniel Stone wrote:
> >
> > Hi Sumit,
> >
> > On Fri, 21 Feb 2025 at 11:24, Sumit Garg wrote:
> > > On Tue, 18 Feb 2025 at 21:52, Daniel S
On Tue, 18 Feb 2025 at 21:52, Daniel Stone wrote:
>
> Hi Sumit,
>
> On Mon, 17 Feb 2025 at 06:13, Sumit Garg wrote:
> > On Fri, 14 Feb 2025 at 21:19, Boris Brezillon
> > wrote:
> > > I would say one heap per-profile.
> >
> > And then it would ha
On Fri, 14 Feb 2025 at 21:19, Boris Brezillon
wrote:
>
> On Fri, 14 Feb 2025 18:37:14 +0530
> Sumit Garg wrote:
>
> > On Fri, 14 Feb 2025 at 15:37, Jens Wiklander
> > wrote:
> > >
> > > Hi,
> > >
> > > On Thu, Feb 13, 2025 at 6:39 PM
On Fri, 14 Feb 2025 at 15:37, Jens Wiklander wrote:
>
> Hi,
>
> On Thu, Feb 13, 2025 at 6:39 PM Daniel Stone wrote:
> >
> > Hi,
> >
> > On Thu, 13 Feb 2025 at 15:57, Jens Wiklander
> > wrote:
> > > On Thu, Feb 13, 2025 at 3:05 PM Daniel Stone wrote:
> > > > But just because TEE is one good bac
On Thu, 13 Feb 2025 at 14:06, Boris Brezillon
wrote:
>
> On Thu, 13 Feb 2025 12:11:52 +0530
> Sumit Garg wrote:
>
> > Hi Boris,
> >
> > On Thu, 13 Feb 2025 at 01:26, Boris Brezillon
> > wrote:
> > >
> > > +Florent, who's workin
Hi Boris,
On Thu, 13 Feb 2025 at 01:26, Boris Brezillon
wrote:
>
> +Florent, who's working on protected-mode support in Panthor.
>
> Hi Jens,
>
> On Tue, 17 Dec 2024 11:07:36 +0100
> Jens Wiklander wrote:
>
> > Hi,
> >
> > This patch set allocates the restricted DMA-bufs via the TEE subsystem.
>
On Wed, 8 Jan 2025 at 22:27, Simona Vetter wrote:
>
> On Tue, Dec 24, 2024 at 12:05:19PM +0530, Sumit Garg wrote:
> > Hi Simona,
> >
> > On Wed, 18 Dec 2024 at 16:36, Simona Vetter wrote:
> > >
> > > On Tue, Dec 17, 2024 at 11:07:36AM +0100, Jens Wikland
Hi Lukas,
On Tue, 24 Dec 2024 at 14:58, Lukas Wunner wrote:
>
> On Tue, Dec 24, 2024 at 12:05:19PM +0530, Sumit Garg wrote:
> > Restricted memory is a feature enforced by hardware specific firewalls
> > where a particular TEE implementation governs which particular bloc
Hi Simona,
On Wed, 18 Dec 2024 at 16:36, Simona Vetter wrote:
>
> On Tue, Dec 17, 2024 at 11:07:36AM +0100, Jens Wiklander wrote:
> > Hi,
> >
> > This patch set allocates the restricted DMA-bufs via the TEE subsystem.
> >
> > The TEE subsystem handles the DMA-buf allocations since it is the TEE
>
On Tue, 3 Dec 2024 at 15:58, Jens Wiklander wrote:
>
> Hi Sumit,
>
> On Tue, Dec 3, 2024 at 9:27 AM Sumit Garg wrote:
> >
> > Hi Jens,
> >
> > On Thu, 28 Nov 2024 at 20:39, Jens Wiklander
> > wrote:
> > >
> > > The OP-TEE
Hi Jens,
On Thu, 28 Nov 2024 at 20:39, Jens Wiklander wrote:
>
> The OP-TEE backend driver has two internal function pointers to convert
> between the subsystem type struct tee_param and the OP-TEE type struct
> optee_msg_param.
>
> The conversion is done from one of the types to the other, which
Hi Jens,
On Thu, 28 Nov 2024 at 20:39, Jens Wiklander wrote:
>
> Add support in the OP-TEE backend driver for restricted memory
> allocation.
>
> The restricted memory can be allocated from a static carveout, but also
> be dynamically allocated from CMA and turned into restricted memory by
> OP-T
Hi Jens,
On Thu, 28 Nov 2024 at 20:39, Jens Wiklander wrote:
>
> Add restricted memory allocation to the TEE subsystem. Restricted memory
> is not be accessible by kernel during normal circumstances. A new ioctl
s/not be accessible/not accessible/
How about if we reword it as follows?
Rest
Hi Jens,
On Tue, 15 Oct 2024 at 15:47, Jens Wiklander wrote:
>
> Add support in the OP-TEE backend driver for restricted memory
> allocation. The support is limited to only the SMC ABI and for secure
> video buffers.
>
> OP-TEE is probed for the range of restricted physical memory and a
> memory
Hi Jens,
On Tue, 15 Oct 2024 at 15:47, Jens Wiklander wrote:
>
> Hi,
>
> This patch set allocates the restricted DMA-bufs via the TEE subsystem.
> This a complete rewrite compared to the previous patch set [1], and other
> earlier proposals [2] and [3] with a separate restricted heap.
>
> The TEE
On Sat, 28 Sept 2024 at 01:20, Nicolas Dufresne wrote:
>
> Le jeudi 26 septembre 2024 à 19:22 +0530, Sumit Garg a écrit :
> > [Resend in plain text format as my earlier message was rejected by
> > some mailing lists]
> >
> > On Thu, 26 Sept 2024 at 19:17, Sumit Garg
On 9/25/24 19:31, Christian König wrote:
Am 25.09.24 um 14:51 schrieb Dmitry Baryshkov:
On Wed, Sep 25, 2024 at 10:51:15AM GMT, Christian König wrote:
Am 25.09.24 um 01:05 schrieb Dmitry Baryshkov:
On Tue, Sep 24, 2024 at 01:13:18PM GMT, Andrew Davis wrote:
On 9/23/24 1:33 AM, Dmitry Baryshko
[Resend in plain text format as my earlier message was rejected by
some mailing lists]
On Thu, 26 Sept 2024 at 19:17, Sumit Garg wrote:
>
> On 9/25/24 19:31, Christian König wrote:
>
> Am 25.09.24 um 14:51 schrieb Dmitry Baryshkov:
>
> On Wed, Sep 25, 2024 at 10:51:15AM GM
Hi,
On Wed, 17 Jul 2024 at 18:01, Dmitry Baryshkov
wrote:
>
> Adding TEE mailing list and maintainers to the CC list.
Thanks. I am not going to reiterate what Jens said in the other thread
but going to cover some additional points.
>
> Amirreza, please include them in future even if you are not
On Fri, 3 Feb 2023 at 16:31, Olivier Masse wrote:
>
> On jeu., 2023-02-02 at 10:58 +0100, Etienne Carriere wrote:
> > Caution: EXT Email
> >
> > On Thu, 2 Feb 2023 at 09:35, Sumit Garg
> > wrote:
> > > Hi Cyrille,
> > >
> > >
use-case supported by upstream
OP-TEE? AFAIK, the Secure Data Path (SDP) use-case is the one
supported in OP-TEE upstream but without secure dmabuf heap [1]
available, the new ioctl can't be exercised.
[1] https://github.com/OP-TEE/optee_test/blob/master/host/xtest/sdp_basic.h#L15
-Sumit
>
Hi Olivier,
On Fri, 27 Jan 2023 at 16:24, Olivier Masse wrote:
>
> Hi Joakim,
> Hi Etienne,
>
> Let me bring back this pull request for OPTEE Linux driver.
>
> Last feedback was from Christian König and Sumit Garg.
> From Christian:
> > Just two comments:
> >
On Thu, 8 Sept 2022 at 14:48, Olivier Masse wrote:
>
> Hi Sumit
>
> On ven., 2022-08-19 at 13:54 +0530, Sumit Garg wrote:
> > Caution: EXT Email
> >
> > Hi Olivier,
> >
> > On Fri, 12 Aug 2022 at 20:01, Olivier Masse
> > wrote:
> > >
Hi Daniel,
On Wed, 7 Sept 2022 at 01:29, Daniel Vetter wrote:
>
> On Fri, Aug 19, 2022 at 01:54:31PM +0530, Sumit Garg wrote:
> > Hi Olivier,
> >
> > On Fri, 12 Aug 2022 at 20:01, Olivier Masse wrote:
> > >
> > > Add a new ioctl called TEE_IOC_SHM_REG
Hi Olivier,
On Fri, 12 Aug 2022 at 20:01, Olivier Masse wrote:
>
> Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a
> shared memory from a dmabuf file descriptor.
> This new ioctl will allow the Linux Kernel to register a buffer
> to be used by the Secure Data Path OPTEE OS feature.
>
Hi Olivier,
On Thu, 11 Aug 2022 at 19:26, Olivier Masse wrote:
>
> Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a
> shared memory from a dmabuf file descriptor.
>
IIRC, here you are trying to fill the gap for OP-TEE SDP use-case. But
the use-case should be described here, its curre
Hi Olivier,
On Thu, 11 Aug 2022 at 19:26, Olivier Masse wrote:
>
> From: Etienne Carriere
>
> This change allows userland to create a tee_shm object that refers
> to a dmabuf reference.
>
> Userland provides a dmabuf file descriptor as buffer reference.
> The created tee_shm object exported as a
53 matches
Mail list logo
