Re: [PATCH v10 9/9] optee: smc abi: dynamic protected memory allocation

2025-06-17 Thread Sumit Garg
++-- > 1 file changed, 75 insertions(+), 3 deletions(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/drivers/tee/optee/smc_abi.c b/drivers/tee/optee/smc_abi.c > index cf106d15e64e..fd1d873de941 100644 > --- a/drivers/tee/optee/smc_abi.c > +++ b/drivers/tee/optee/smc_abi

Re: [PATCH v10 8/9] optee: FF-A: dynamic protected memory allocation

2025-06-17 Thread Sumit Garg
nsertions(+), 3 deletions(-) > create mode 100644 drivers/tee/optee/protmem.c Reviewed-by: Sumit Garg -Sumit > > diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile > index a6eff388d300..ad7049c1c107 100644 > --- a/drivers/tee/optee/Makefile > +++ b/drivers/t

Re: [PATCH v10 7/9] optee: support protected memory allocation

2025-06-17 Thread Sumit Garg
t; drivers/tee/optee/smc_abi.c | 70 ++- > 4 files changed, 85 insertions(+), 2 deletions(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig > index 7bb7990d0b07..50d2051f7f20 100644 > --- a/dr

Re: [PATCH v10 6/9] tee: add tee_shm_alloc_dma_mem()

2025-06-17 Thread Sumit Garg
a_mem; > + dma_free_pages(&teedev->dev, shm->size, dma_mem->page, > +dma_mem->dma_addr, DMA_BIDIRECTIONAL); > +#endif > + } else if (shm->flags & TEE_SHM_DMA_BUF) { Do we need a similar config check for this flag too? With

Re: [PATCH v10 5/9] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2025-06-17 Thread Sumit Garg
On Tue, Jun 10, 2025 at 03:13:49PM +0200, Jens Wiklander wrote: > From: Etienne Carriere > > Add a userspace API to create a tee_shm object that refers to a dmabuf > reference. > > Userspace registers the dmabuf file descriptor as in a tee_shm object. > The registration is completed with a tee_s

Re: [PATCH v10 3/9] tee: implement protected DMA-heap

2025-06-17 Thread Sumit Garg
ting protected memory > + * @free:called when freeing protected memory > + * @update_shm: called when registering a dma-buf to update the > @shm > + * with physical address of the buffer or to return the > + * @parent_shm of

Re: [PATCH v10 2/9] dma-buf: dma-heap: export declared functions

2025-06-17 Thread Sumit Garg
drivers/dma-buf/dma-heap.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Sumit Garg -Sumit > > diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c > index 3cbe87d4a464..cdddf0e24dce 100644 > --- a/drivers/dma-buf/dma-heap.c > +++ b/drivers/dma-bu

Re: [PATCH v5 05/12] tee: increase TEE_MAX_ARG_SIZE to 4096

2025-06-11 Thread Sumit Garg
res a larger buffer for argument marshaling. > > Signed-off-by: Amirreza Zarrabi > --- > include/uapi/linux/tee.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h &

Re: [PATCH v9 6/9] tee: add tee_shm_alloc_dma_mem()

2025-05-26 Thread Sumit Garg
On Mon, May 26, 2025 at 11:21:47AM +0200, Jens Wiklander wrote: > On Mon, May 26, 2025 at 9:22 AM Sumit Garg wrote: > > > > On Tue, May 20, 2025 at 05:16:49PM +0200, Jens Wiklander wrote: > > > Add tee_shm_alloc_dma_mem() to allocate DMA memory. The memory is > > >

Re: [PATCH v9 9/9] optee: smc abi: dynamic protected memory allocation

2025-05-26 Thread Sumit Garg
On Tue, May 20, 2025 at 05:16:52PM +0200, Jens Wiklander wrote: > Add support in the OP-TEE backend driver for dynamic protected memory > allocation using the SMC ABI. > > Signed-off-by: Jens Wiklander > --- > drivers/tee/optee/smc_abi.c | 102 ++-- > 1 file chang

Re: [PATCH v9 8/9] optee: FF-A: dynamic protected memory allocation

2025-05-26 Thread Sumit Garg
On Tue, May 20, 2025 at 05:16:51PM +0200, Jens Wiklander wrote: > Add support in the OP-TEE backend driver dynamic protected memory > allocation with FF-A. > > The protected memory pools for dynamically allocated protected memory > are instantiated when requested by user-space. This instantiation

Re: [PATCH v9 7/9] optee: support protected memory allocation

2025-05-26 Thread Sumit Garg
On Tue, May 20, 2025 at 05:16:50PM +0200, Jens Wiklander wrote: > Add support in the OP-TEE backend driver for protected memory > allocation. The support is limited to only the SMC ABI and for secure > video buffers. > > OP-TEE is probed for the range of protected physical memory and a > memory po

Re: [PATCH v9 6/9] tee: add tee_shm_alloc_dma_mem()

2025-05-26 Thread Sumit Garg
On Tue, May 20, 2025 at 05:16:49PM +0200, Jens Wiklander wrote: > Add tee_shm_alloc_dma_mem() to allocate DMA memory. The memory is > represented by a tee_shm object using the new flag TEE_SHM_DMA_MEM to > identify it as DMA memory. The allocated memory will later be lent to > the TEE to be used as

Re: [PATCH v9 5/9] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2025-05-23 Thread Sumit Garg
gt; include/linux/tee_drv.h | 10 > include/uapi/linux/tee.h | 31 +++ > 6 files changed, 221 insertions(+), 5 deletions(-) With below minor comments fixed, feel free to add: Reviewed-by: Sumit Garg > > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee

Re: [PATCH v9 3/9] tee: implement protected DMA-heap

2025-05-23 Thread Sumit Garg
+ Robin Jens, I suppose you missed to add Robin who has earlier reviewed this patch. On Tue, May 20, 2025 at 05:16:46PM +0200, Jens Wiklander wrote: > Implement DMA heap for protected DMA-buf allocation in the TEE > subsystem. > > Restricted memory refers to memory buffers behind a hardware enf

Re: [PATCH v9 1/9] optee: sync secure world ABI headers

2025-05-23 Thread Sumit Garg
--- > drivers/tee/optee/optee_ffa.h | 27 --- > drivers/tee/optee/optee_msg.h | 84 ++- > drivers/tee/optee/optee_smc.h | 37 ++- > 3 files changed, 130 insertions(+), 18 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --g

Re: [PATCH v4 08/11] tee: add Qualcomm TEE driver

2025-05-15 Thread Sumit Garg
On Thu, May 15, 2025 at 02:35:34PM +0530, Kuldeep Singh wrote: > > > On 5/14/2025 6:55 PM, Sumit Garg wrote: > > Hi Amir, > > > > Apologies for getting to this patch review a bit late, mostly due to > > it's enormous size. > > > > On Mon,

Re: [PATCH v4 05/11] firmware: qcom: scm: add support for object invocation

2025-05-14 Thread Sumit Garg
On Wed, May 14, 2025 at 05:27:44PM +0200, Bartosz Golaszewski wrote: > On Wed, 14 May 2025 at 11:37, Sumit Garg wrote: > > > > Hi Amir, > > > > I am still unable to get the QCOMTEE driver to work on db845c. As I can > > see machine: "qcom,sdm845" is not

Re: [PATCH v4 03/11] tee: add TEE_IOCTL_PARAM_ATTR_TYPE_UBUF

2025-05-14 Thread Sumit Garg
> 3 files changed, 55 insertions(+), 6 deletions(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index 721522fe5c63..7bf265c4ac65 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -386,6 +386,17

Re: [PATCH v4 02/11] tee: add close_context to TEE driver operation

2025-05-14 Thread Sumit Garg
drivers/tee/tee_core.c| 7 +++ > drivers/tee/tee_private.h | 6 -- > include/linux/tee_core.h | 50 > +-- > 3 files changed, 55 insertions(+), 8 deletions(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/drivers/te

Re: [PATCH v4 09/11] qcomtee: add primordial object

2025-05-14 Thread Sumit Garg
insertions(+), 5 deletions(-) Looks reasonable to me, feel free to add: Acked-by: Sumit Garg -Sumit > > diff --git a/drivers/tee/qcomtee/Makefile b/drivers/tee/qcomtee/Makefile > index 1b14b943e5f5..a3a2d00e83f0 100644 > --- a/drivers/tee/qcomtee/Makefile > +++ b/drivers/tee/qcom

Re: [PATCH v4 08/11] tee: add Qualcomm TEE driver

2025-05-14 Thread Sumit Garg
Hi Amir, Apologies for getting to this patch review a bit late, mostly due to it's enormous size. On Mon, Apr 28, 2025 at 11:06:29PM -0700, Amirreza Zarrabi wrote: > Introduce qcomtee_object, which represents an object in both QTEE and > the kernel. QTEE clients can invoke an instance of qcomtee_

Re: [PATCH v4 05/11] firmware: qcom: scm: add support for object invocation

2025-05-14 Thread Sumit Garg
Hi Amir, On Mon, Apr 28, 2025 at 11:06:26PM -0700, Amirreza Zarrabi wrote: > Qualcomm TEE (QTEE) hosts Trusted Applications (TAs) and services in > the secure world, accessed via objects. A QTEE client can invoke these > objects to request services. Similarly, QTEE can request services from > the

Re: [PATCH v8 07/14] tee: refactor params_from_user()

2025-05-07 Thread Sumit Garg
; 1 file changed, 54 insertions(+), 40 deletions(-) Reviewed-by: Sumit Garg -Sumit > > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index 685afcaa3ea1..820e394b9054 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -353,6 +353,55 @@ tee_ioc

Re: [PATCH v8 03/14] optee: account for direction while converting parameters

2025-05-07 Thread Sumit Garg
Hi Jens, On Fri, May 02, 2025 at 11:59:17AM +0200, Jens Wiklander wrote: > The OP-TEE backend driver has two internal function pointers to convert > between the subsystem type struct tee_param and the OP-TEE type struct > optee_msg_param. > > The conversion is done from one of the types to the ot

Re: [PATCH v3 04/11] tee: add TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF

2025-04-21 Thread Sumit Garg
> include/linux/tee_core.h | 4 +++ > include/linux/tee_drv.h | 6 > include/uapi/linux/tee.h | 41 +++ > 4 files changed, 130 insertions(+), 6 deletions(-) Minor nits from me below, otherwise this looks reasonable new IOCTL interface to me. FWIW: Reviewed

Re: [PATCH v3 03/11] tee: add TEE_IOCTL_PARAM_ATTR_TYPE_UBUF

2025-04-21 Thread Sumit Garg
On Wed, Apr 09, 2025 at 05:20:08PM +1000, Amirreza Zarrabi wrote: > > > On 4/9/2025 4:41 PM, Jens Wiklander wrote: > > Hi Amirreza, > > > > On Wed, Apr 9, 2025 at 2:28 AM Amirreza Zarrabi > > wrote: > >> > >> Hi jens, > >> > >> On 4/8/2025 10:19 PM, Jens Wiklander wrote: > >> > >> Hi Amirreza,

Re: [PATCH v3 02/11] tee: add close_context to TEE driver operation

2025-04-21 Thread Sumit Garg
On Thu, Mar 27, 2025 at 07:47:24PM -0700, Amirreza Zarrabi wrote: > The tee_context can be used to manage TEE user resources, including > those allocated by the driver for the TEE on behalf of the user. > The release() callback is invoked only when all resources, such as > tee_shm, are released and

Re: [PATCH v3 01/11] tee: allow a driver to allocate a tee_device without a pool

2025-04-21 Thread Sumit Garg
n for tee_device_alloc(), it is not handled correctly. > > Signed-off-by: Amirreza Zarrabi > --- > drivers/tee/tee_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.

Re: [PATCH v6 09/10] optee: FF-A: dynamic restricted memory allocation

2025-04-10 Thread Sumit Garg
On Tue, Apr 01, 2025 at 02:26:59PM +0200, Jens Wiklander wrote: > On Tue, Apr 1, 2025 at 12:13 PM Sumit Garg wrote: > > > > + MM folks to seek guidance here. > > > > On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote: > > > Hi Sumit, > > >

Re: [PATCH v6 09/10] optee: FF-A: dynamic restricted memory allocation

2025-04-09 Thread Sumit Garg
Thanks David for your response. On Wed, Apr 09, 2025 at 12:01:21PM +0200, David Hildenbrand wrote: > On 01.04.25 12:13, Sumit Garg wrote: > > + MM folks to seek guidance here. > > > > On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote: > > > Hi Sumi

Re: [PATCH v6 05/10] tee: implement restricted DMA-heap

2025-04-09 Thread Sumit Garg
On Tue, Apr 08, 2025 at 03:28:45PM +0200, Jens Wiklander wrote: > On Tue, Apr 8, 2025 at 11:14 AM Sumit Garg wrote: > > > > On Tue, Apr 01, 2025 at 10:33:04AM +0200, Jens Wiklander wrote: > > > On Tue, Apr 1, 2025 at 9:58 AM Sumit Garg wrote: > > > > > &

Re: [PATCH v6 05/10] tee: implement restricted DMA-heap

2025-04-08 Thread Sumit Garg
On Tue, Apr 01, 2025 at 10:33:04AM +0200, Jens Wiklander wrote: > On Tue, Apr 1, 2025 at 9:58 AM Sumit Garg wrote: > > > > On Tue, Mar 25, 2025 at 11:55:46AM +0100, Jens Wiklander wrote: > > > Hi Sumit, > > > > > > > > > > >

Re: [PATCH v6 03/10] optee: account for direction while converting parameters

2025-04-05 Thread Sumit Garg
On Thu, Mar 20, 2025 at 02:00:57PM +0100, Jens Wiklander wrote: > Hi Sumit, > > On Thu, Mar 20, 2025 at 10:25 AM Sumit Garg wrote: > > > > Hi Jens, > > > > On Mon, Mar 17, 2025 at 08:42:01AM +0100, Jens Wiklander wrote: > > > Hi Sumit, > > >

Re: [PATCH v6 03/10] optee: account for direction while converting parameters

2025-04-05 Thread Sumit Garg
On Tue, Mar 25, 2025 at 09:50:35AM +0100, Jens Wiklander wrote: > On Tue, Mar 25, 2025 at 6:56 AM Sumit Garg wrote: > > > > On Thu, Mar 20, 2025 at 02:00:57PM +0100, Jens Wiklander wrote: > > > Hi Sumit, > > > > > > On Thu, Mar 20, 2025 at 10:25 AM

Re: [PATCH v6 05/10] tee: implement restricted DMA-heap

2025-04-05 Thread Sumit Garg
On Tue, Mar 25, 2025 at 11:55:46AM +0100, Jens Wiklander wrote: > Hi Sumit, > > > > > > > + > > > +#include "tee_private.h" > > > + > > > +struct tee_dma_heap { > > > + struct dma_heap *heap; > > > + enum tee_dma_heap_id id; > > > + struct tee_rstmem_pool *pool; > > > + struct

Re: [PATCH v6 06/10] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2025-04-05 Thread Sumit Garg
On Tue, Mar 25, 2025 at 12:17:20PM +0100, Jens Wiklander wrote: > Hi Sumit, > > On Tue, Mar 25, 2025 at 7:50 AM Sumit Garg wrote: > > > > Hi Jens, > > > > On Wed, Mar 05, 2025 at 02:04:12PM +0100, Jens Wiklander wrote: > > > From: Etienne Carriere

Re: [PATCH v6 09/10] optee: FF-A: dynamic restricted memory allocation

2025-04-04 Thread Sumit Garg
+ MM folks to seek guidance here. On Thu, Mar 27, 2025 at 09:07:34AM +0100, Jens Wiklander wrote: > Hi Sumit, > > On Tue, Mar 25, 2025 at 8:42 AM Sumit Garg wrote: > > > > On Wed, Mar 05, 2025 at 02:04:15PM +0100, Jens Wiklander wrote: > > > Add support in the

Re: [PATCH v6 10/10] optee: smc abi: dynamic restricted memory allocation

2025-03-25 Thread Sumit Garg
On Wed, Mar 05, 2025 at 02:04:16PM +0100, Jens Wiklander wrote: > Add support in the OP-TEE backend driver for dynamic restricted memory > allocation using the SMC ABI. > > Signed-off-by: Jens Wiklander > --- > drivers/tee/optee/smc_abi.c | 96 +++-- > 1 file chan

Re: [PATCH v6 09/10] optee: FF-A: dynamic restricted memory allocation

2025-03-25 Thread Sumit Garg
On Wed, Mar 05, 2025 at 02:04:15PM +0100, Jens Wiklander wrote: > Add support in the OP-TEE backend driver dynamic restricted memory > allocation with FF-A. > > The restricted memory pools for dynamically allocated restrict memory > are instantiated when requested by user-space. This instantiation

Re: [PATCH v6 08/10] optee: support restricted memory allocation

2025-03-25 Thread Sumit Garg
On Wed, Mar 05, 2025 at 02:04:14PM +0100, Jens Wiklander wrote: > Add support in the OP-TEE backend driver for restricted memory > allocation. The support is limited to only the SMC ABI and for secure > video buffers. > > OP-TEE is probed for the range of restricted physical memory and a > memory

Re: [PATCH v6 07/10] tee: add tee_shm_alloc_cma_phys_mem()

2025-03-24 Thread Sumit Garg
Hi Jens, On Wed, Mar 05, 2025 at 02:04:13PM +0100, Jens Wiklander wrote: > Add tee_shm_alloc_cma_phys_mem() to allocate a physical memory using > from the default CMA pool. The memory is represented by a tee_shm object > using the new flag TEE_SHM_CMA_BUF to identify it as physical memory > from C

Re: [PATCH v6 06/10] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2025-03-24 Thread Sumit Garg
Hi Jens, On Wed, Mar 05, 2025 at 02:04:12PM +0100, Jens Wiklander wrote: > From: Etienne Carriere > > Enable userspace to create a tee_shm object that refers to a dmabuf > reference. > > Userspace registers the dmabuf file descriptor as in a tee_shm object. > The registration is completed with

Re: [PATCH v6 05/10] tee: implement restricted DMA-heap

2025-03-24 Thread Sumit Garg
Hi Jens, On Wed, Mar 05, 2025 at 02:04:11PM +0100, Jens Wiklander wrote: > Implement DMA heap for restricted DMA-buf allocation in the TEE > subsystem. > > Restricted memory refers to memory buffers behind a hardware enforced > firewall. It is not accessible to the kernel during normal circumstan

Re: [PATCH v6 04/10] optee: sync secure world ABI headers

2025-03-24 Thread Sumit Garg
Hi Jens, It has taken a bit of time for me to review this patch-set as I am settling in my new role. On Wed, Mar 05, 2025 at 02:04:10PM +0100, Jens Wiklander wrote: > Update the header files describing the secure world ABI, both with and > without FF-A. The ABI is extended to deal with restricted

Re: [PATCH v6 03/10] optee: account for direction while converting parameters

2025-03-20 Thread Sumit Garg
Hi Jens, On Mon, Mar 17, 2025 at 08:42:01AM +0100, Jens Wiklander wrote: > Hi Sumit, > > On Thu, Mar 13, 2025 at 11:41 AM Sumit Garg wrote: > > > > Hi Jens, > > > > On Wed, Mar 05, 2025 at 02:04:09PM +0100, Jens Wiklander wrote: > > > The OP-TEE backend

Re: [PATCH v6 03/10] optee: account for direction while converting parameters

2025-03-13 Thread Sumit Garg
Hi Jens, On Wed, Mar 05, 2025 at 02:04:09PM +0100, Jens Wiklander wrote: > The OP-TEE backend driver has two internal function pointers to convert > between the subsystem type struct tee_param and the OP-TEE type struct > optee_msg_param. > > The conversion is done from one of the types to the ot

Re: [PATCH v6 02/10] optee: pass parent device to tee_device_alloc()

2025-03-10 Thread Sumit Garg
e/optee/ffa_abi.c | 8 > drivers/tee/optee/smc_abi.c | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c > index f3af5666bb11..4ca1d5161b82 100644 > --- a/driv

Re: [PATCH v6 01/10] tee: tee_device_alloc(): copy dma_mask from parent device

2025-03-10 Thread Sumit Garg
--- > drivers/tee/tee_core.c | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index d113679b1e2d..685afcaa3ea1 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-03-03 Thread Sumit Garg
On Tue, Mar 04, 2025 at 08:17:23AM +0100, Jens Wiklander wrote: > Hi Daniel, > > On Fri, Feb 21, 2025 at 3:12 PM Daniel Stone wrote: > > > > Hi Sumit, > > > > On Fri, 21 Feb 2025 at 11:24, Sumit Garg wrote: > > > On Tue, 18 Feb 2025 at 21:52, Daniel S

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-21 Thread Sumit Garg
On Tue, 18 Feb 2025 at 21:52, Daniel Stone wrote: > > Hi Sumit, > > On Mon, 17 Feb 2025 at 06:13, Sumit Garg wrote: > > On Fri, 14 Feb 2025 at 21:19, Boris Brezillon > > wrote: > > > I would say one heap per-profile. > > > > And then it would ha

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-16 Thread Sumit Garg
On Fri, 14 Feb 2025 at 21:19, Boris Brezillon wrote: > > On Fri, 14 Feb 2025 18:37:14 +0530 > Sumit Garg wrote: > > > On Fri, 14 Feb 2025 at 15:37, Jens Wiklander > > wrote: > > > > > > Hi, > > > > > > On Thu, Feb 13, 2025 at 6:39 PM

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-14 Thread Sumit Garg
On Fri, 14 Feb 2025 at 15:37, Jens Wiklander wrote: > > Hi, > > On Thu, Feb 13, 2025 at 6:39 PM Daniel Stone wrote: > > > > Hi, > > > > On Thu, 13 Feb 2025 at 15:57, Jens Wiklander > > wrote: > > > On Thu, Feb 13, 2025 at 3:05 PM Daniel Stone wrote: > > > > But just because TEE is one good bac

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-13 Thread Sumit Garg
On Thu, 13 Feb 2025 at 14:06, Boris Brezillon wrote: > > On Thu, 13 Feb 2025 12:11:52 +0530 > Sumit Garg wrote: > > > Hi Boris, > > > > On Thu, 13 Feb 2025 at 01:26, Boris Brezillon > > wrote: > > > > > > +Florent, who's workin

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-02-12 Thread Sumit Garg
Hi Boris, On Thu, 13 Feb 2025 at 01:26, Boris Brezillon wrote: > > +Florent, who's working on protected-mode support in Panthor. > > Hi Jens, > > On Tue, 17 Dec 2024 11:07:36 +0100 > Jens Wiklander wrote: > > > Hi, > > > > This patch set allocates the restricted DMA-bufs via the TEE subsystem. >

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2025-01-08 Thread Sumit Garg
On Wed, 8 Jan 2025 at 22:27, Simona Vetter wrote: > > On Tue, Dec 24, 2024 at 12:05:19PM +0530, Sumit Garg wrote: > > Hi Simona, > > > > On Wed, 18 Dec 2024 at 16:36, Simona Vetter wrote: > > > > > > On Tue, Dec 17, 2024 at 11:07:36AM +0100, Jens Wikland

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2024-12-25 Thread Sumit Garg
Hi Lukas, On Tue, 24 Dec 2024 at 14:58, Lukas Wunner wrote: > > On Tue, Dec 24, 2024 at 12:05:19PM +0530, Sumit Garg wrote: > > Restricted memory is a feature enforced by hardware specific firewalls > > where a particular TEE implementation governs which particular bloc

Re: [PATCH v4 0/6] TEE subsystem for restricted dma-buf allocations

2024-12-23 Thread Sumit Garg
Hi Simona, On Wed, 18 Dec 2024 at 16:36, Simona Vetter wrote: > > On Tue, Dec 17, 2024 at 11:07:36AM +0100, Jens Wiklander wrote: > > Hi, > > > > This patch set allocates the restricted DMA-bufs via the TEE subsystem. > > > > The TEE subsystem handles the DMA-buf allocations since it is the TEE >

Re: [PATCH v3 2/4] optee: account for direction while converting parameters

2024-12-03 Thread Sumit Garg
On Tue, 3 Dec 2024 at 15:58, Jens Wiklander wrote: > > Hi Sumit, > > On Tue, Dec 3, 2024 at 9:27 AM Sumit Garg wrote: > > > > Hi Jens, > > > > On Thu, 28 Nov 2024 at 20:39, Jens Wiklander > > wrote: > > > > > > The OP-TEE

Re: [PATCH v3 2/4] optee: account for direction while converting parameters

2024-12-03 Thread Sumit Garg
Hi Jens, On Thu, 28 Nov 2024 at 20:39, Jens Wiklander wrote: > > The OP-TEE backend driver has two internal function pointers to convert > between the subsystem type struct tee_param and the OP-TEE type struct > optee_msg_param. > > The conversion is done from one of the types to the other, which

Re: [PATCH v3 4/4] optee: support restricted memory allocation

2024-12-03 Thread Sumit Garg
Hi Jens, On Thu, 28 Nov 2024 at 20:39, Jens Wiklander wrote: > > Add support in the OP-TEE backend driver for restricted memory > allocation. > > The restricted memory can be allocated from a static carveout, but also > be dynamically allocated from CMA and turned into restricted memory by > OP-T

Re: [PATCH v3 1/4] tee: add restricted memory allocation

2024-12-02 Thread Sumit Garg
Hi Jens, On Thu, 28 Nov 2024 at 20:39, Jens Wiklander wrote: > > Add restricted memory allocation to the TEE subsystem. Restricted memory > is not be accessible by kernel during normal circumstances. A new ioctl s/not be accessible/not accessible/ How about if we reword it as follows? Rest

Re: [RFC PATCH v2 2/2] optee: support restricted memory allocation

2024-10-17 Thread Sumit Garg
Hi Jens, On Tue, 15 Oct 2024 at 15:47, Jens Wiklander wrote: > > Add support in the OP-TEE backend driver for restricted memory > allocation. The support is limited to only the SMC ABI and for secure > video buffers. > > OP-TEE is probed for the range of restricted physical memory and a > memory

Re: [RFC PATCH v2 0/2] TEE subsystem for restricted dma-buf allocations

2024-10-17 Thread Sumit Garg
Hi Jens, On Tue, 15 Oct 2024 at 15:47, Jens Wiklander wrote: > > Hi, > > This patch set allocates the restricted DMA-bufs via the TEE subsystem. > This a complete rewrite compared to the previous patch set [1], and other > earlier proposals [2] and [3] with a separate restricted heap. > > The TEE

Re: [Linaro-mm-sig] Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-29 Thread Sumit Garg
On Sat, 28 Sept 2024 at 01:20, Nicolas Dufresne wrote: > > Le jeudi 26 septembre 2024 à 19:22 +0530, Sumit Garg a écrit : > > [Resend in plain text format as my earlier message was rejected by > > some mailing lists] > > > > On Thu, 26 Sept 2024 at 19:17, Sumit Garg

Re: [Linaro-mm-sig] Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-26 Thread Sumit Garg
On 9/25/24 19:31, Christian König wrote: Am 25.09.24 um 14:51 schrieb Dmitry Baryshkov: On Wed, Sep 25, 2024 at 10:51:15AM GMT, Christian König wrote: Am 25.09.24 um 01:05 schrieb Dmitry Baryshkov: On Tue, Sep 24, 2024 at 01:13:18PM GMT, Andrew Davis wrote: On 9/23/24 1:33 AM, Dmitry Baryshko

Re: [Linaro-mm-sig] Re: [RFC PATCH 0/4] Linaro restricted heap

2024-09-26 Thread Sumit Garg
[Resend in plain text format as my earlier message was rejected by some mailing lists] On Thu, 26 Sept 2024 at 19:17, Sumit Garg wrote: > > On 9/25/24 19:31, Christian König wrote: > > Am 25.09.24 um 14:51 schrieb Dmitry Baryshkov: > > On Wed, Sep 25, 2024 at 10:51:15AM GM

Re: [PATCH RFC 0/3] Implement Qualcomm TEE IPC and ioctl calls

2024-07-18 Thread Sumit Garg
Hi, On Wed, 17 Jul 2024 at 18:01, Dmitry Baryshkov wrote: > > Adding TEE mailing list and maintainers to the CC list. Thanks. I am not going to reiterate what Jens said in the other thread but going to cover some additional points. > > Amirreza, please include them in future even if you are not

Re: [EXT] Re: [PATCH v2 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2023-02-03 Thread Sumit Garg
On Fri, 3 Feb 2023 at 16:31, Olivier Masse wrote: > > On jeu., 2023-02-02 at 10:58 +0100, Etienne Carriere wrote: > > Caution: EXT Email > > > > On Thu, 2 Feb 2023 at 09:35, Sumit Garg > > wrote: > > > Hi Cyrille, > > > > > >

Re: [EXT] Re: [PATCH v2 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2023-02-02 Thread Sumit Garg
use-case supported by upstream OP-TEE? AFAIK, the Secure Data Path (SDP) use-case is the one supported in OP-TEE upstream but without secure dmabuf heap [1] available, the new ioctl can't be exercised. [1] https://github.com/OP-TEE/optee_test/blob/master/host/xtest/sdp_basic.h#L15 -Sumit >

Re: [PATCH v2 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2023-01-31 Thread Sumit Garg
Hi Olivier, On Fri, 27 Jan 2023 at 16:24, Olivier Masse wrote: > > Hi Joakim, > Hi Etienne, > > Let me bring back this pull request for OPTEE Linux driver. > > Last feedback was from Christian König and Sumit Garg. > From Christian: > > Just two comments: > >

Re: [EXT] Re: [PATCH v2 0/1] tee: Add tee_shm_register_fd

2022-09-08 Thread Sumit Garg
On Thu, 8 Sept 2022 at 14:48, Olivier Masse wrote: > > Hi Sumit > > On ven., 2022-08-19 at 13:54 +0530, Sumit Garg wrote: > > Caution: EXT Email > > > > Hi Olivier, > > > > On Fri, 12 Aug 2022 at 20:01, Olivier Masse > > wrote: > > >

Re: [PATCH v2 0/1] tee: Add tee_shm_register_fd

2022-09-08 Thread Sumit Garg
Hi Daniel, On Wed, 7 Sept 2022 at 01:29, Daniel Vetter wrote: > > On Fri, Aug 19, 2022 at 01:54:31PM +0530, Sumit Garg wrote: > > Hi Olivier, > > > > On Fri, 12 Aug 2022 at 20:01, Olivier Masse wrote: > > > > > > Add a new ioctl called TEE_IOC_SHM_REG

Re: [PATCH v2 0/1] tee: Add tee_shm_register_fd

2022-08-19 Thread Sumit Garg
Hi Olivier, On Fri, 12 Aug 2022 at 20:01, Olivier Masse wrote: > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > shared memory from a dmabuf file descriptor. > This new ioctl will allow the Linux Kernel to register a buffer > to be used by the Secure Data Path OPTEE OS feature. >

Re: [PATCH 0/1] tee: Add tee_shm_register_fd

2022-08-13 Thread Sumit Garg
Hi Olivier, On Thu, 11 Aug 2022 at 19:26, Olivier Masse wrote: > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > shared memory from a dmabuf file descriptor. > IIRC, here you are trying to fill the gap for OP-TEE SDP use-case. But the use-case should be described here, its curre

Re: [PATCH 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2022-08-13 Thread Sumit Garg
Hi Olivier, On Thu, 11 Aug 2022 at 19:26, Olivier Masse wrote: > > From: Etienne Carriere > > This change allows userland to create a tee_shm object that refers > to a dmabuf reference. > > Userland provides a dmabuf file descriptor as buffer reference. > The created tee_shm object exported as a