[PATCH] drm/radeon: Calling object_unrefer() when creating fb failure

2013-01-31 Thread Su, Xuemin
From: liu chuansheng Date: Thu, 31 Jan 2013 22:13:00 +0800 Subject: [PATCH] drm/radeon: Calling object_unrefer() when creating fb failure When kzalloc() failed in radeon_user_framebuffer_create(), need to call object_unreference() to match the object_reference(). Signed-off-by: liu chuansheng

[PATCH V3] drm_crtc: check if fb_create return NULL

2013-01-31 Thread Su, Xuemin
-Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Thursday, January 24, 2013 5:05 PM To: Su, Xuemin Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org; linux-kernel at vger.kernel.org; yanmin_zhang at linux.intel.com; He, Bo Subject: Re: [PATCH V3

[PATCH] drm/radeon: Calling object_unrefer() when creating fb failure

2013-01-30 Thread Su, Xuemin
From: liu chuansheng Date: Thu, 31 Jan 2013 22:13:00 +0800 Subject: [PATCH] drm/radeon: Calling object_unrefer() when creating fb failure When kzalloc() failed in radeon_user_framebuffer_create(), need to call object_unreference() to match the object_reference(). Signed-off-by: liu chuansheng

RE: [PATCH V3] drm_crtc: check if fb_create return NULL

2013-01-30 Thread Su, Xuemin
-Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Thursday, January 24, 2013 5:05 PM To: Su, Xuemin Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; yanmin_zh...@linux.intel.com; He, Bo Subject: Re: [PATCH V3] drm_crtc

[PATCH V3] drm_crtc: check if fb_create return NULL

2013-01-24 Thread Su, Xuemin
On Thu, 2013-01-24 at 10:31 +0200, Jani Nikula wrote: > > } > > + /* some buggy driver may return NULL here, which may cause panic */ > > + BUG_ON(!fb); > > I fail to see the benefit of this compared to just letting it oops... > > > or->fb_id = fb->base.id; > > ...right here. > > F

[PATCH V3] drm_crtc: check if fb_create return NULL

2013-01-24 Thread Su, Xuemin
From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |2 ++ 1 files changed, 2 insertions(+),

Re: [PATCH V3] drm_crtc: check if fb_create return NULL

2013-01-24 Thread Su, Xuemin
On Thu, 2013-01-24 at 10:31 +0200, Jani Nikula wrote: > > } > > + /* some buggy driver may return NULL here, which may cause panic */ > > + BUG_ON(!fb); > > I fail to see the benefit of this compared to just letting it oops... > > > or->fb_id = fb->base.id; > > ...right here. > > F

[PATCH V2 RESEND] drm_crtc: check if fb_create return NULL

2013-01-24 Thread Su, Xuemin
-Original Message- >From: Daniel Vetter [mailto:daniel.vetter at ffwll.ch] On Behalf Of Daniel >Vetter >Sent: Wednesday, January 23, 2013 5:54 PM >To: Su, Xuemin >Cc: airlied at linux.ie; dri-devel at lists.freedesktop.org; linux-kernel at >vger.kernel.or

[PATCH V3] drm_crtc: check if fb_create return NULL

2013-01-23 Thread Su, Xuemin
From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |2 ++ 1 files changed, 2 insertions(+),

RE: [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL

2013-01-23 Thread Su, Xuemin
-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Wednesday, January 23, 2013 5:54 PM >To: Su, Xuemin >Cc: airl...@linux.ie; dri-devel@lists.freedesktop.org; >linux-ker...@vger.kernel.org; yanmin_zh...@linux.in

[PATCH V2 RESEND] drm_crtc: check if fb_create return NULL

2013-01-23 Thread Su, Xuemin
From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |7 +++ 1 files changed, 7 insertions

[PATCH] drm_crtc: check if fb_create return NULL

2013-01-23 Thread Su, Xuemin
From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |6 ++ 1 files changed, 6 insertions(

[PATCH] radeon_display: Use pointer return error codes

2013-01-23 Thread Su, Xuemin
From: xueminsu Date: Tue, 22 Jan 2013 22:16:53 +0800 Subject: [PATCH] radeon_display: Use pointer return error codes drm_mode_addfb() expects fb_create return error code instead of NULL. Signed-off-by: xueminsu --- drivers/gpu/drm/radeon/radeon_display.c |2 +- 1 files changed, 1 insertion

[PATCH V2 RESEND] drm_crtc: check if fb_create return NULL

2013-01-22 Thread Su, Xuemin
From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |7 +++ 1 files changed, 7 insertions

[PATCH] drm_crtc: check if fb_create return NULL

2013-01-22 Thread Su, Xuemin
From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |6 ++ 1 files changed, 6 insertions(

[PATCH] radeon_display: Use pointer return error codes

2013-01-22 Thread Su, Xuemin
From: xueminsu Date: Tue, 22 Jan 2013 22:16:53 +0800 Subject: [PATCH] radeon_display: Use pointer return error codes drm_mode_addfb() expects fb_create return error code instead of NULL. Signed-off-by: xueminsu --- drivers/gpu/drm/radeon/radeon_display.c |2 +- 1 files changed, 1 insertion