Re: [PATCH 1/2] dt-bindings: display/msm/dsi-phy: Add header with exposed clock IDs

2025-01-27 Thread Stephen Boyd
; > --- Acked-by: Stephen Boyd

Re: [PATCH 2/2] drm/msm/dsi/phy: Use the header with clock IDs

2025-01-27 Thread Stephen Boyd
Quoting Krzysztof Kozlowski (2025-01-27 05:21:05) > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > index fdb6c648e16f..7541ffde6521 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.h > @@ -6,6 +6,7 @@ >

Re: [PATCH 4/5] clk: Add flag to prevent frequency changes when walking subtrees

2024-12-30 Thread Stephen Boyd
Quoting Miquel Raynal (2024-12-23 10:43:13) > Hi Maxime, > > On 17/12/2024 at 13:47:53 +01, Maxime Ripard wrote: > > > On Thu, Nov 21, 2024 at 06:41:14PM +0100, Miquel Raynal wrote: > >> There are mainly two ways to change a clock frequency. > > > > There's much more than that :) > > "mainly" >

Re: [PATCH 4/5] clk: Add flag to prevent frequency changes when walking subtrees

2024-12-30 Thread Stephen Boyd
Quoting Miquel Raynal (2024-12-23 10:38:20) > Hi Stephen, > > >> +/* do not passively change this clock rate during subtree rate > >> propagation */ > >> +#define CLK_NO_RATE_CHANGE_DURING_PROPAGATION BIT(14) > > > > Why doesn't rate locking work? > > Can you be more specific? What function from

Re: [RFC PATCH v2 01/19] dt-bindings: clock: Add VO subsystem clocks and update address requirements

2024-12-23 Thread Stephen Boyd
Quoting Michal Wilczynski (2024-12-23 04:55:35) > The T-Head TH1520 SoC’s AP clock controller now needs two address ranges > to manage both the Application Processor (AP) and Video Output (VO) > subsystem clocks. Update the device tree bindings to require two `reg` > entries, one for the AP clocks

Re: [PATCH v4 16/16] drm/msm/dp: drop the msm_dp_catalog module

2024-12-16 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-15 14:44:21) > Now as the msm_dp_catalog module became nearly empty, drop it, accessing > registers directly from the corresponding submodules. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd # sc7180-trogdor

Re: [PATCH v4 15/16] drm/msm/dp: read hw revision only once

2024-12-16 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-15 14:44:20) > There is little point in rereading DP controller revision over and over > again. Read it once, after the first software reset and propagate it to > the dp_panel module. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Steph

Re: [PATCH v4 06/16] drm/msm/dp: split MMSS_DP_DSC_DTO register write to a separate function

2024-12-16 Thread Stephen Boyd
gt; Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd # sc7180-trogdor

Re: [PATCH v4 05/16] drm/msm/dp: stop passing panel to msm_dp_audio_get()

2024-12-16 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-15 14:44:10) > The dp_audio module doesn't make any use of the passed DP panel > instance. Drop the argument. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd Tested-by: Stephen Boyd # sc7180-trogdor

Re: [PATCH v4 02/16] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-16 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-15 14:44:07) > Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly > to program audio packet data. Use 0 as Packet ID, as it was not > programmed earlier. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Steph

Re: [PATCH v3 00/14] drm/msm/dp: perform misc cleanups

2024-12-12 Thread Stephen Boyd
: Dmitry Baryshkov > --- For the series Tested-by: Stephen Boyd # sc7180-trogdor

Re: [PATCH v3 06/14] drm/msm/dp: move/inline AUX register functions

2024-12-12 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-11 15:41:41) > Move all register-level functions to dp_aux.c, inlining one line > wrappers during this process. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 05/14] drm/msm/dp: move I/O functions to global header

2024-12-12 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-11 15:41:40) > Move msm_dp_read()/msm_write_foo() functions to the dp_catalog.h, > allowing other modules to access the data directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2] drm/msm/dpu: check dpu_plane_atomic_print_state() for valid sspp

2024-12-12 Thread Stephen Boyd
; Fixes: 31f7148fd370 ("drm/msm/dpu: move pstate->pipe initialization to > dpu_plane_atomic_check") > Reported-by: Stephen Boyd > Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/67 > Signed-off-by: Abhinav Kumar > --- Tested-by: Stephen Boyd # sc7180-trogdor

Re: [PATCH v2 14/14] drm/msm/dp: move interrupt handling to dp_ctrl

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:44) > It makes it easier to keep all interrupts-related code in dp_ctrl > submodule. Move all functions to dp_ctrl.c. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 12/14] drm/msm/dp: move more AUX functions to dp_aux.c

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:42) > Move several misnamed functions accessing AUX bus to dp_aux.c, further > cleaning up dp_catalog submodule. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 13/14] drm/msm/dp: drop struct msm_dp_panel_in

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:43) > All other submodules pass arguments directly. Drop struct > msm_dp_panel_in that is used to wrap dp_panel's submodule args and pass > all data to msm_dp_panel_get() directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 11/14] drm/msm/dp: move/inline audio related functions

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:41) > Move audio-related functions to dp_audio.c, following up the cleanup > done by the rest of the submodules. Inline functions with simple > register access patterns. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:39) > Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly > to program audio packet data. Use 0 as Packet ID, as it was not > programmed earlier. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boy

Re: [PATCH v2 10/14] drm/msm/dp: drop obsolete audio headers access through catalog

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:40) > Drop obsolete functions to access audio packet headers. The dp_audio.c > now writes them using msm_dp_write_link() directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 08/14] drm/msm/dp: move/inline panel related functions

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:38) > Move panel-related functions to dp_panel.c, following up the cleanup > done by the rest of the submodules. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 07/14] drm/msm/dp: move/inline ctrl register functions

2024-12-11 Thread Stephen Boyd
dp_catalog.c, pending later cleanup. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 04/14] drm/msm/dp: pull I/O data out of msm_dp_catalog_private()

2024-12-11 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-11 13:16:56) > On Wed, 11 Dec 2024 at 23:11, Stephen Boyd wrote: > > > > It is pure DP. Maybe we can have a google,cros-ec-usbc-hdmi compatible > > string here because this is a weird design. > > Just google,cros-ec-hdmi for the corresponding connector? > Sure.

Re: [PATCH v2 03/14] drm/msm/dp: drop msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs()

2024-12-11 Thread Stephen Boyd
mitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 02/14] drm/msm/dp: fix msm_dp_utils_pack_sdp_header interface

2024-12-11 Thread Stephen Boyd
quot;) > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-11 Thread Stephen Boyd
Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202411081748.0ppl9mij-...@intel.com/ > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 06/14] drm/msm/dp: move/inline AUX register functions

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:36) > diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c > index > bc8d46abfc619d669dce339477d58fb0c464a3ea..46e8a2e13ac1d1249fbad9b50a6d64c52d51cf38 > 100644 > --- a/drivers/gpu/drm/msm/dp/dp_aux.c > +++ b/drivers/gpu/drm/msm

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-05 10:47:08) > On Tue, Dec 03, 2024 at 03:50:58PM -0800, Stephen Boyd wrote: > > > > The easiest way to imagine this is that we took the usb-c-connector and > > jammed an HDMI dongle in there with some glue so that it can never be > > r

Re: [PATCH v2 05/14] drm/msm/dp: move I/O functions to global header

2024-12-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-02 02:06:35) > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.h > b/drivers/gpu/drm/msm/dp/dp_catalog.h > index > 13486c9c8703748e69e846be681951368df0a29e..2c500dc0898edfe1d6bdac2eedf3c1b78056cf6b > 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.h > +++ b/driv

Re: [PATCH 4/5] clk: Add flag to prevent frequency changes when walking subtrees

2024-12-10 Thread Stephen Boyd
Quoting Miquel Raynal (2024-11-21 09:41:14) > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index > adfc5bfb93b5a65b6f58c52ca2c432d651f7dd7d..94d93470479e77769e63e97462b176261103b552 > 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -1927,7 +1927,6 @@ long clk_get_accuracy(

Re: [RFC PATCH v1 05/14] dt-bindings: clock: thead, th1520: Add support for Video Output subsystem

2024-12-04 Thread Stephen Boyd
Quoting Stephen Boyd (2024-12-04 12:21:11) > Quoting Michal Wilczynski (2024-12-04 02:11:26) > > > > To address this, I'll specify the 'reg' property in each node to define > > the address ranges explicitly fragmenting the address space for the VOSYS >

Re: [RFC PATCH v1 05/14] dt-bindings: clock: thead, th1520: Add support for Video Output subsystem

2024-12-04 Thread Stephen Boyd
Quoting Michal Wilczynski (2024-12-04 02:11:26) > On 12/3/24 16:45, Krzysztof Kozlowski wrote: > > On 03/12/2024 14:41, Michal Wilczynski wrote: > > [1] - > https://openbeagle.org/beaglev-ahead/beaglev-ahead/-/blob/main/docs/TH1520%20Video%20Image%20Processing%20User%20Manual.pdf > > > >> +

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-12-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-11-21 14:59:42) > On Tue, Nov 19, 2024 at 08:09:31PM -0500, Stephen Boyd wrote: > > > > It sounds like we're debating how to handle lane assignment in the > > kernel. Either way, the code is going to be implemented in the bridge > >

Re: [PATCH 00/37] drm/vc4: Add support for BCM2712 / Pi5 display hardware

2024-12-03 Thread Stephen Boyd
Quoting Dave Stevenson (2024-11-27 06:43:38) > > V2 includes fixing Maxime's comment on "[PATCH 31/37] clk: bcm: rpi: > Allow cpufreq driver to also adjust gpu clocks" that Stephen also > commented on. > > Stephen: Sorry, maintaining newbie, particularly for clocks. I see in > linux-clk patchwork

Re: [RFC PATCH v1 01/14] clk: thead: Refactor TH1520 clock driver to share common code

2024-12-03 Thread Stephen Boyd
Quoting Michal Wilczynski (2024-12-03 05:41:24) > diff --git a/drivers/clk/thead/Makefile b/drivers/clk/thead/Makefile > index 7ee0bec1f251..d7cf88390b69 100644 > --- a/drivers/clk/thead/Makefile > +++ b/drivers/clk/thead/Makefile > @@ -1,2 +1,2 @@ > # SPDX-License-Identifier: GPL-2.0 > -obj-$(CON

Re: [PATCH 30/37] clk: bcm: rpi: Add ISP to exported clocks

2024-11-21 Thread Stephen Boyd
Quoting Dave Stevenson (2024-10-23 09:50:27) > From: Dom Cobley > > The ISP clock can be controlled by the driver, so register it > with the clock subsystem. > > Signed-off-by: Dom Cobley > Signed-off-by: Dave Stevenson > --- Acked-by: Stephen Boyd

Re: [PATCH 31/37] clk: bcm: rpi: Allow cpufreq driver to also adjust gpu clocks

2024-11-21 Thread Stephen Boyd
With Maxime's suggestion: Acked-by: Stephen Boyd

Re: [PATCH 34/37] clk: bcm: rpi: Add disp clock

2024-11-21 Thread Stephen Boyd
Signed-off-by: Dave Stevenson > --- Acked-by: Stephen Boyd

Re: [PATCH 33/37] clk: bcm: rpi: Create helper to retrieve private data

2024-11-21 Thread Stephen Boyd
cating it > all over the place. > > Signed-off-by: Maxime Ripard > Signed-off-by: Dave Stevenson > --- Acked-by: Stephen Boyd

Re: [PATCH 32/37] clk: bcm: rpi: Enable minimize for all firmware clocks

2024-11-21 Thread Stephen Boyd
Quoting Dave Stevenson (2024-10-23 09:50:29) > From: Dom Cobley > > There isn't a reason not to minimise the clocks, and it saves > some power. > > Signed-off-by: Dom Cobley > Signed-off-by: Dave Stevenson > --- Acked-by: Stephen Boyd

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-11-19 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-11-15 09:17:15) > On Mon, Nov 11, 2024 at 06:16:27PM -0800, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2024-11-08 23:05:18) > > > On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (202

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-11-11 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-11-08 23:05:18) > On Thu, Nov 07, 2024 at 04:28:24PM -0800, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2024-10-31 15:54:49) > > > On Thu, Oct 31, 2024 at 02:45:29PM -0700, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (202

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-11-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-10-31 15:54:49) > On Thu, Oct 31, 2024 at 02:45:29PM -0700, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2024-10-31 11:42:36) > > > On Tue, Oct 29, 2024 at 01:15:51PM -0700, Stephen Boyd wrote: > > > > Or use a displayport proper

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-10-31 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-10-31 11:42:36) > On Tue, Oct 29, 2024 at 01:15:51PM -0700, Stephen Boyd wrote: > > At this point we need to tell the DP bridge, like IT6505, that it's one > > or the other output endpoints that it should use, but we haven't > > directl

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-10-29 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-10-25 03:49:36) > On Tue, Oct 22, 2024 at 06:15:47PM -0700, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2024-09-20 02:38:53) > > > On Sat, Aug 31, 2024 at 09:06:53PM GMT, Stephen Boyd wrote: > > > > > Either way the problem see

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-10-22 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-09-20 02:38:53) > On Sat, Aug 31, 2024 at 09:06:53PM GMT, Stephen Boyd wrote: > > Based on our disccusions at LPC, here are several DT examples that seem > sensible to implement this case and several related cases from other > ChromeBooks. (Apolog

Re: [PATCH v4 13/18] dt-bindings: usb-switch: Extend for DisplayPort altmode

2024-10-10 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-09-19 03:40:19) > On Sat, Aug 31, 2024 at 09:06:51PM GMT, Stephen Boyd wrote: > > diff --git a/Documentation/devicetree/bindings/usb/usb-switch.yaml > > b/Documentation/devicetree/bindings/usb/usb-switch.yaml > > index f5dc7e23b134..816f295f

Re: [PATCH v4 02/27] clk: qcom: clk-rcg2: name refactoring

2024-09-13 Thread Stephen Boyd
Quoting Dzmitry Sankouski (2024-09-13 08:07:45) > clk-rcg2.c uses 2 variable names for pre divisor register value: > pre_div and hid_div. > > Replace hid_div with pre_div. Update calc_rate docs to reflect, that > pre_div is not pure divisor, but a register value, and requires conversion. > > Sign

Re: [PATCH v4 18/18] platform/chrome: cros_ec_typec: Handle lack of HPD information

2024-09-06 Thread Stephen Boyd
Quoting Tzung-Bi Shih (2024-09-06 01:18:21) > On Wed, Sep 04, 2024 at 02:45:36PM -0700, Stephen Boyd wrote: > > Quoting Tzung-Bi Shih (2024-09-04 02:36:45) > > > On Sat, Aug 31, 2024 at 09:06:56PM -0700, Stephen Boyd wrote: > > > > + /* Inject HPD from the GPIO

Re: [PATCH v4 18/18] platform/chrome: cros_ec_typec: Handle lack of HPD information

2024-09-04 Thread Stephen Boyd
Quoting Tzung-Bi Shih (2024-09-04 02:36:45) > On Sat, Aug 31, 2024 at 09:06:56PM -0700, Stephen Boyd wrote: > > +static void cros_typec_inject_hpd(struct cros_typec_data *typec, > > + struct ec_response_usb_pd_mux_info *resp, > > +

Re: [PATCH v4 06/18] drm/bridge: aux-hpd: Support USB Type-C DP altmodes via DRM lane assignment

2024-09-04 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-09-04 06:00:57) > On Tue, Sep 03, 2024 at 06:20:14PM -0400, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-09-02 04:35:46) > > > On Sat, Aug 31, 2024 at 09:06:44PM -0700, Stephen Boyd wrote: > > > > > + adev->dev.o

Re: [PATCH v4 11/18] device property: Add remote endpoint to devcon matcher

2024-09-03 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-09-02 04:12:49) > On Sat, Aug 31, 2024 at 09:06:49PM -0700, Stephen Boyd wrote: > > Is it possible to move these Cc:s after --- line below? Ok. > > > /** > > * devcon_match_fn_t - device connection match function > > * @fwnode: R

Re: [PATCH v4 10/18] devcon property: Document devcon_match_fn_t

2024-09-03 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-09-02 04:17:12) > On Sat, Aug 31, 2024 at 09:06:48PM -0700, Stephen Boyd wrote: > > The usage of this match function is hard to understand at a glance. > > Document the arguments and the return value so it is clear how to > > implement the functi

Re: [PATCH v4 06/18] drm/bridge: aux-hpd: Support USB Type-C DP altmodes via DRM lane assignment

2024-09-03 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-09-02 04:35:46) > On Sat, Aug 31, 2024 at 09:06:44PM -0700, Stephen Boyd wrote: > > Extend the aux-hpd bridge driver to support assigning DP lanes to USB > > type-c pins based on typec mux state entry. Existing users of this > > driver only n

[PATCH v4 18/18] platform/chrome: cros_ec_typec: Handle lack of HPD information

2024-08-31 Thread Stephen Boyd
: Prashant Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_typec.c | 74 + drivers/platform/chrome/cros_ec_typec.h | 2 + 2 files changed, 76 insertions(+) diff --git a/drivers/platf

[PATCH v4 17/18] platform/chrome: cros_ec_typec: Support DP muxing

2024-08-31 Thread Stephen Boyd
he EC doesn't hide these details from the AP so we have to reimplement the logic in the kernel. Cc: Prashant Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_typec.c | 31 +++-- drivers/platf

[PATCH v4 16/18] platform/chrome: cros_ec_typec: Add support for signaling DP HPD via drm_bridge

2024-08-31 Thread Stephen Boyd
a port into DP mode, the mode switch registered in the drm_dp_typec bridge driver will signal HPD state to the drm_bridge chain because the typec subsystem will configure the usbc switches connected to the port with the data this driver provides. Cc: Prashant Malani Cc: Benson Leung Cc: Tzu

[PATCH v4 15/18] dt-bindings: usb: Add ports to google, cros-ec-typec for DP altmode

2024-08-31 Thread Stephen Boyd
(Arm) Cc: Krzysztof Kozlowski Cc: Conor Dooley Acked-by: Lee Jones Cc: Benson Leung Cc: Guenter Roeck Cc: Prashant Malani Cc: Tzung-Bi Shih Cc: Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- .../bindings/mfd/google,cros-ec.yaml | 7 +- .../bindings/usb

[PATCH v4 14/18] dt-bindings: Move google, cros-ec-typec binding to usb

2024-08-31 Thread Stephen Boyd
: Cc: Pin-yen Lin Suggested-by: Krzysztof Kozlowski Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +- .../bindings/{chrome => usb}/google,cros-ec-typec.yaml| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) rename Docum

[PATCH v4 13/18] dt-bindings: usb-switch: Extend for DisplayPort altmode

2024-08-31 Thread Stephen Boyd
on the output. Add an example to show how this new port can be used. Reviewed-by: Rob Herring (Arm) Cc: Krzysztof Kozlowski Cc: Conor Dooley Cc: Benson Leung Cc: Guenter Roeck Cc: Prashant Malani Cc: Tzung-Bi Shih Cc: Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- .../devicetree

[PATCH v4 10/18] devcon property: Document devcon_match_fn_t

2024-08-31 Thread Stephen Boyd
The usage of this match function is hard to understand at a glance. Document the arguments and the return value so it is clear how to implement the function. Suggested-by: Andy Shevchenko Signed-off-by: Stephen Boyd --- include/linux/property.h | 21 +++-- 1 file changed, 19

[PATCH v4 12/18] dt-bindings: usb-switch: Extract endpoints to defs

2024-08-31 Thread Stephen Boyd
d and accelerate binding checks. Reviewed-by: Rob Herring (Arm) Cc: Krzysztof Kozlowski Cc: Conor Dooley Cc: Benson Leung Cc: Guenter Roeck Cc: Prashant Malani Cc: Tzung-Bi Shih Cc: Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- .../devicetree/bindings/usb/usb-switch.yaml

[PATCH v4 11/18] device property: Add remote endpoint to devcon matcher

2024-08-31 Thread Stephen Boyd
ko Cc: Daniel Scally Cc: Heikki Krogerus Cc: Sakari Ailus Cc: Greg Kroah-Hartman Cc: Vinod Koul Cc: "Rafael J. Wysocki" Cc: Mika Westerberg Cc: Alexandre Belloni Cc: Ivan Orlov Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: Conor Dooley Cc: Cc: Cc: Cc: Pin-yen Lin Signed-off-

[PATCH v4 09/18] drm/bridge: dp_typec: Allow users to hook hpd notify path

2024-08-31 Thread Stephen Boyd
shant Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 31 + include/drm/bridge/aux-bridge.h | 9 +++ 2 files changed, 40 insertions(+) diff --

[PATCH v4 08/18] drm/bridge: dp_typec: Add "no-hpd" support

2024-08-31 Thread Stephen Boyd
enson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c b/drivers/gpu/drm/bridge/aux-hpd

[PATCH v4 07/18] drm/bridge: dp_typec: Support USB Type-C orientation

2024-08-31 Thread Stephen Boyd
and the device doesn't have an orientation switch wired down on the board between the connector and the DP controller. Cc: Prashant Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/aux-hpd-bri

[PATCH v4 06/18] drm/bridge: aux-hpd: Support USB Type-C DP altmodes via DRM lane assignment

2024-08-31 Thread Stephen Boyd
t Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 483 +++- include/drm/bridge/aux-bridge.h | 17 + 2 files changed, 488 insertions(+), 12 deletions(-) diff

[PATCH v4 05/18] usb: typec: Add device managed typec_switch_register()

2024-08-31 Thread Stephen Boyd
Simplify driver error paths by adding devm_typec_switch_register() which will unregister the typec switch when the parent device is unbound. Cc: Heikki Krogerus Cc: Greg Kroah-Hartman Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/usb/typec/mux.c | 36

[PATCH v4 04/18] usb: typec: Add device managed typec_mux_register()

2024-08-31 Thread Stephen Boyd
Simplify driver error paths by adding devm_typec_mux_register() which will unregister the typec mux when the parent device is unbound. Cc: Heikki Krogerus Cc: Greg Kroah-Hartman Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/usb/typec/mux.c | 35

[PATCH v4 02/18] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-31 Thread Stephen Boyd
c: David Airlie Cc: Daniel Vetter Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_bridge.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index bd18c1e91dee..e350

[PATCH v4 03/18] usb: typec: Stub out typec_switch APIs when CONFIG_TYPEC=n

2024-08-31 Thread Stephen Boyd
Ease driver development by adding stubs for the typec_switch APIs when CONFIG_TYPEC=n. Copy the same method used for the typec_mux APIs to be consistent. Cc: Heikki Krogerus Cc: Greg Kroah-Hartman Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- include/linux/usb/typec_mux.h | 43

[PATCH v4 01/18] drm/atomic-helper: Introduce lane remapping support to bridges

2024-08-31 Thread Stephen Boyd
assignment. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-of

[PATCH v4 00/18] platform/chrome: Add DT USB/DP muxing/topology support

2024-08-31 Thread Stephen Boyd
* Move the DT graph and other properties to the cros-ec-typec binding * Skip mode-switch/orientation-switch properties because we're not registering typec structs anymore Stephen Boyd (18): drm/atomic-helper: Introduce lane remapping support to bridges drm/bridge: Verify lane

Re: [PATCH v3 13/17] dt-bindings: Move google,cros-ec-typec binding to usb

2024-08-23 Thread Stephen Boyd
Quoting Tzung-Bi Shih (2024-08-22 07:34:31) > On Mon, Aug 19, 2024 at 03:38:27PM -0700, Stephen Boyd wrote: > > -title: Google Chrome OS EC(Embedded Controller) Type C port driver. > > +title: Google Chrome OS Embedded Controller (EC) USB type-c port driver > > Given that it

Re: [PATCH v3 15/17] platform/chrome: cros_ec_typec: Add support for signaling DP HPD via drm_bridge

2024-08-23 Thread Stephen Boyd
Quoting Tzung-Bi Shih (2024-08-22 07:35:13) > On Mon, Aug 19, 2024 at 03:38:29PM -0700, Stephen Boyd wrote: > > +struct cros_typec_dp_bridge { > > + struct cros_typec_data *typec_data; > > + struct drm_dp_typec_bridge_dev *dev; > > +}; > > It look

Re: [PATCH v3 16/17] platform/chrome: cros_ec_typec: Support DP muxing

2024-08-23 Thread Stephen Boyd
Quoting Tzung-Bi Shih (2024-08-22 07:37:05) > On Mon, Aug 19, 2024 at 03:38:30PM -0700, Stephen Boyd wrote: > > @@ -671,6 +674,20 @@ static int cros_typec_configure_mux(struct > > cros_typec_data *typec, int port_num, > > if (port->mux_flags == resp.flags &&

Re: [PATCH v3 10/17] device property: Add remote endpoint to devcon matcher

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 03:20:44) > On Mon, Aug 19, 2024 at 03:38:24PM -0700, Stephen Boyd wrote: > > include/linux/property.h| 5 +++-- > > > -typedef void *(*devcon_match_fn_t)(const struct fwnode_handle *fwnode, > > const char *id, > > -

Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 10:29:41) > On Tue, Aug 20, 2024 at 10:24:47AM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-08-20 10:17:46) > > > On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > > > > Quoting Andy Shevchenko (2024-08

Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 10:17:46) > On Tue, Aug 20, 2024 at 10:12:55AM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-08-20 03:09:29) > > > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote: > > > > + /* > > > > +

Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-20 Thread Stephen Boyd
Quoting Stephen Boyd (2024-08-20 10:19:48) > Quoting Andy Shevchenko (2024-08-20 10:16:40) > > On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote: > > > Quoting Andy Shevchenko (2024-08-20 03:16:09) > > > > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen B

Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 10:16:40) > On Tue, Aug 20, 2024 at 10:01:07AM -0700, Stephen Boyd wrote: > > Quoting Andy Shevchenko (2024-08-20 03:16:09) > > > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > > > > + ptr = devres_alloc(devm_t

Re: [PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 03:09:29) > On Mon, Aug 19, 2024 at 03:38:16PM -0700, Stephen Boyd wrote: > > Verify during drm_atomic_bridge_check() that the lane assignment set in > > a bridge's atomic_check() callback is going to be satisfied by the > > previous

Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-20 Thread Stephen Boyd
Quoting Andy Shevchenko (2024-08-20 03:16:09) > On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > > + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*ptr), > > GFP_KERNEL); > > + if (!ptr) > > + return ERR_PTR(-ENOMEM);

[PATCH v3 16/17] platform/chrome: cros_ec_typec: Support DP muxing

2024-08-19 Thread Stephen Boyd
he EC doesn't hide these details from the AP so we have to reimplement the logic in the kernel. Cc: Prashant Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_typec.c | 27 +++-- 1 file c

[PATCH v3 17/17] platform/chrome: cros_ec_typec: Handle lack of HPD information

2024-08-19 Thread Stephen Boyd
: Prashant Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/platform/chrome/cros_ec_typec.c | 79 + 1 file changed, 79 insertions(+) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platf

[PATCH v3 13/17] dt-bindings: Move google, cros-ec-typec binding to usb

2024-08-19 Thread Stephen Boyd
n Lin Suggested-by: Krzysztof Kozlowski Signed-off-by: Stephen Boyd --- Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 2 +- .../bindings/{chrome => usb}/google,cros-ec-typec.yaml| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) rename Documentation/devicetree/

[PATCH v3 15/17] platform/chrome: cros_ec_typec: Add support for signaling DP HPD via drm_bridge

2024-08-19 Thread Stephen Boyd
a port into DP mode, the mode switch registered in the drm_dp_typec bridge driver will signal HPD state to the drm_bridge chain because the typec subsystem will configure the usbc switches connected to the port with the data this driver provides. Cc: Prashant Malani Cc: Benson Leung Cc: Tzu

[PATCH v3 14/17] dt-bindings: usb: Add ports to google, cros-ec-typec for DP altmode

2024-08-19 Thread Stephen Boyd
zysztof Kozlowski Cc: Conor Dooley Cc: Lee Jones Cc: Benson Leung Cc: Guenter Roeck Cc: Prashant Malani Cc: Tzung-Bi Shih Cc: Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- .../bindings/mfd/google,cros-ec.yaml | 7 +- .../bindings/usb/google,cros-ec-typec.yaml| 229 +

[PATCH v3 11/17] dt-bindings: usb-switch: Extract endpoints to defs

2024-08-19 Thread Stephen Boyd
d and accelerate binding checks. Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: Conor Dooley Cc: Benson Leung Cc: Guenter Roeck Cc: Prashant Malani Cc: Tzung-Bi Shih Cc: Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- .../devicetree/bindings/usb/usb-switch.yaml | 74 --- 1

[PATCH v3 12/17] dt-bindings: usb-switch: Extend for DisplayPort altmode

2024-08-19 Thread Stephen Boyd
on the output. Add an example to show how this new port can be used. Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: Conor Dooley Cc: Benson Leung Cc: Guenter Roeck Cc: Prashant Malani Cc: Tzung-Bi Shih Cc: Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- .../devicetree/bindings/usb/usb

[PATCH v3 10/17] device property: Add remote endpoint to devcon matcher

2024-08-19 Thread Stephen Boyd
ko Cc: Daniel Scally Cc: Heikki Krogerus Cc: Sakari Ailus Cc: Greg Kroah-Hartman Cc: Vinod Koul Cc: "Rafael J. Wysocki" Cc: Mika Westerberg Cc: Alexandre Belloni Cc: Ivan Orlov Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: Conor Dooley Cc: Cc: Cc: Cc: Pin-yen Lin Signed-off-

[PATCH v3 09/17] drm/bridge: dp_typec: Allow users to hook hpd notify path

2024-08-19 Thread Stephen Boyd
shant Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 30 + include/drm/bridge/aux-bridge.h | 9 2 files changed, 39 insertions(+) diff --

[PATCH v3 08/17] drm/bridge: dp_typec: Add "no-hpd" support

2024-08-19 Thread Stephen Boyd
enson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c b/drivers/gpu/drm/bridge/aux-hpd

[PATCH v3 05/17] usb: typec: Add device managed typec_switch_register()

2024-08-19 Thread Stephen Boyd
Simplify driver error paths by adding devm_typec_switch_register() which will unregister the typec switch when the parent device is unbound. Cc: Heikki Krogerus Cc: Greg Kroah-Hartman Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/usb/typec/mux.c | 27

[PATCH v3 07/17] drm/bridge: dp_typec: Support USB Type-C orientation

2024-08-19 Thread Stephen Boyd
and the device doesn't have an orientation switch wired down on the board between the connector and the DP controller. Cc: Prashant Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/aux-hpd-bri

[PATCH v3 06/17] drm/bridge: aux-hpd: Support USB Type-C DP altmodes via DRM lane assignment

2024-08-19 Thread Stephen Boyd
t Malani Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/bridge/aux-hpd-bridge.c | 476 +++- include/drm/bridge/aux-bridge.h | 17 + 2 files changed, 481 insertions(+), 12 deletions(-) diff

[PATCH v3 04/17] usb: typec: Add device managed typec_mux_register()

2024-08-19 Thread Stephen Boyd
Simplify driver error paths by adding devm_typec_mux_register() which will unregister the typec mux when the parent device is unbound. Cc: Heikki Krogerus Cc: Greg Kroah-Hartman Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- drivers/usb/typec/mux.c | 37

[PATCH v3 03/17] usb: typec: Stub out typec_switch APIs when CONFIG_TYPEC=n

2024-08-19 Thread Stephen Boyd
Ease driver development by adding stubs for the typec_switch APIs when CONFIG_TYPEC=n. Copy the same method used for the typec_mux APIs to be consistent. Cc: Heikki Krogerus Cc: Greg Kroah-Hartman Cc: Cc: Pin-yen Lin Signed-off-by: Stephen Boyd --- include/linux/usb/typec_mux.h | 42

[PATCH v3 02/17] drm/bridge: Verify lane assignment is going to work during atomic_check

2024-08-19 Thread Stephen Boyd
c: David Airlie Cc: Daniel Vetter Cc: Cc: Pin-yen Lin Cc: Dmitry Baryshkov Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_bridge.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index bd18c1e91dee..68c7

  1   2   3   4   5   6   7   8   9   10   >