Re: [PATCH 1/2] drm/msm: Fix refcnt underflow in error path

2025-09-22 Thread Stephan Gerhold
On Mon, Sep 22, 2025 at 10:42:52AM -0700, Rob Clark wrote: > On Mon, Sep 22, 2025 at 9:46 AM Stephan Gerhold > wrote: > > > > On Mon, Sep 22, 2025 at 09:41:07AM -0700, Rob Clark wrote: > > > On Mon, Sep 22, 2025 at 9:33 AM Stephan Gerhold > > > wrote: > &

Re: [PATCH 1/2] drm/msm: Fix refcnt underflow in error path

2025-09-22 Thread Stephan Gerhold
On Mon, Sep 22, 2025 at 09:41:07AM -0700, Rob Clark wrote: > On Mon, Sep 22, 2025 at 9:33 AM Stephan Gerhold > wrote: > > On Wed, Jul 23, 2025 at 12:08:49PM -0700, Rob Clark wrote: > > > If we hit an error path in GEM obj creation before msm_gem_new_handle() > > >

Re: [PATCH 1/2] drm/msm: Fix refcnt underflow in error path

2025-09-22 Thread Stephan Gerhold
Hi Rob, On Wed, Jul 23, 2025 at 12:08:49PM -0700, Rob Clark wrote: > If we hit an error path in GEM obj creation before msm_gem_new_handle() > updates obj->resv to point to the gpuvm resv object, then obj->resv > still points to &obj->_resv. In this case we don't want to decrement > the refcount

Re: [PATCH 0/2] driver core: platform: / drm/msm: dp: Delay applying clock defaults

2025-08-19 Thread Stephan Gerhold
On Tue, Aug 19, 2025 at 04:19:26AM +0300, Dmitry Baryshkov wrote: > On Mon, Aug 18, 2025 at 11:41:16AM +0200, Stephan Gerhold wrote: > > On Sat, Aug 16, 2025 at 04:55:00PM +0300, Dmitry Baryshkov wrote: > > > On Thu, Aug 14, 2025 at 02:38:45PM +0200, Stephan Gerhold wrote: >

Re: [PATCH 0/2] driver core: platform: / drm/msm: dp: Delay applying clock defaults

2025-08-18 Thread Stephan Gerhold
On Sat, Aug 16, 2025 at 04:55:00PM +0300, Dmitry Baryshkov wrote: > On Thu, Aug 14, 2025 at 02:38:45PM +0200, Stephan Gerhold wrote: > > On Thu, Aug 14, 2025 at 02:55:44PM +0300, Dmitry Baryshkov wrote: > > > On Thu, Aug 14, 2025 at 11:18:05AM +0200, Stephan Gerhold wrote: >

Re: [PATCH v6 1/2] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller

2025-08-14 Thread Stephan Gerhold
On Thu, Aug 14, 2025 at 04:21:09PM +0200, Neil Armstrong wrote: > On 09/08/2025 00:28, Christopher Obbard wrote: > > On Mon, 4 Aug 2025 at 14:13, Johan Hovold wrote: > > > > > > On Thu, Jul 31, 2025 at 09:51:26PM +0100, Christopher Obbard wrote: > > > > The eDP controller has an HPD GPIO. Describ

Re: [PATCH 0/2] driver core: platform: / drm/msm: dp: Delay applying clock defaults

2025-08-14 Thread Stephan Gerhold
On Thu, Aug 14, 2025 at 02:55:44PM +0300, Dmitry Baryshkov wrote: > On Thu, Aug 14, 2025 at 11:18:05AM +0200, Stephan Gerhold wrote: > > Currently, the platform driver core always calls of_clk_set_defaults() > > before calling the driver probe() function. This will apply any >

[PATCH 1/2] driver core: platform: Add option to skip/delay applying clock defaults

2025-08-14 Thread Stephan Gerhold
f this option is set, applying the clock defaults is skipped in the platform driver core and the driver must do this itself when ready. Signed-off-by: Stephan Gerhold --- drivers/base/platform.c | 8 +--- include/linux/platform_device.h | 6 ++ 2 files changed, 11 insertions(+), 3

[PATCH 2/2] drm/msm: dp: Delay applying clock defaults until PHY is fully enabled

2025-08-14 Thread Stephan Gerhold
_clk_defaults" option in the platform_driver struct. Delay the call to of_clk_set_defaults() until we have set up the PHY to avoid the error shown above. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 10 ++ drivers/gpu/drm/msm/dp/dp_display.c | 2 ++

[PATCH 0/2] driver core: platform: / drm/msm: dp: Delay applying clock defaults

2025-08-14 Thread Stephan Gerhold
he actual rate is still being derived from the old parent. [1]: https://lore.kernel.org/r/20250716134717.4085567-3-mwa...@kernel.org/ Signed-off-by: Stephan Gerhold --- Stephan Gerhold (2): driver core: platform: Add option to skip/delay applying clock defaults drm/msm: dp: Delay

Re: [PATCH v7] drm/msm/dp: reuse generic HDMI codec implementation

2025-06-23 Thread Stephan Gerhold
On Thu, May 29, 2025 at 10:40:12AM +0800, Xilin Wu wrote: > On 2025/4/24 01:52:45, Dmitry Baryshkov wrote: > > From: Dmitry Baryshkov > > > > The MSM DisplayPort driver implements several HDMI codec functions > > in the driver, e.g. it manually manages HDMI codec device registration, > > returnin

Re: [PATCH RESEND] drm/bridge-connector: Fix bridge in drm_connector_hdmi_audio_init()

2025-06-23 Thread Stephan Gerhold
th driver hdmi-audio-codec failed with error -22 By de-referencing the "bridge" from the outer scope I think the current broken code basically de-references some random out-of-bounds memory. This should be fixed ASAP. Tested-by: Stephan Gerhold > --- > drivers/gpu/drm/display/dr

[PATCH] drm/msm/gpu: Fix crash when throttling GPU immediately during boot

2025-04-29 Thread Stephan Gerhold
e after initialization and msm_devfreq_get_dev_status() will end up accessing GMU registers, causing the crash. Fix this by setting df->suspended correctly during initialization. Cc: sta...@vger.kernel.org Fixes: 6694482a70e9 ("drm/msm: Avoid unclocked GMU register access in 6xx gpu_busy") Signed-of

Re: [PATCH 03/11] dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible

2025-03-07 Thread Stephan Gerhold
On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetre

Re: [PATCH 13/45] drm/msm/dp: separate dp_display_prepare() into its own API

2024-12-06 Thread Stephan Gerhold
On Thu, Dec 05, 2024 at 08:31:44PM -0800, Abhinav Kumar wrote: > dp_display_prepare() only prepares the link in case its not > already ready before dp_display_enable(). Hence separate it into > its own API. > > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_display.c | 24 +++

[PATCH] drm/msm/dpu: fix x1e80100 intf_6 underrun/vsync interrupt

2024-11-15 Thread Stephan Gerhold
t;) Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h index a3

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Stephan Gerhold
On Mon, Jul 15, 2024 at 03:01:57PM +0200, Neil Armstrong wrote: > On 15/07/2024 14:54, Stephan Gerhold wrote: > > On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > > > On 15/07/2024 14:15, Stephan Gerhold wrote: > > > > This reverts commit 8ebb1fc2e6

Re: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Stephan Gerhold
On Mon, Jul 15, 2024 at 02:42:12PM +0200, Neil Armstrong wrote: > On 15/07/2024 14:15, Stephan Gerhold wrote: > > This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. > > > > The panel should be handled through the samsung-atna33xc20 driver for > > correct powe

[PATCH v2 4/4] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20

2024-07-15 Thread Stephan Gerhold
This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-15 Thread Stephan Gerhold
ust with a larger resolution and size. Add a new "samsung,atna45af01" compatible to describe this panel in the DT. Use the existing "samsung,atna33xc20" as fallback compatible since existing drivers should work as-is, given that resolution and size are discoverable through the eDP

[PATCH v2 3/4] arm64: dts: qcom: x1e80100-crd: Fix backlight

2024-07-15 Thread Stephan Gerhold
panel regulator. The panel does not seem to power off properly if the regulator stays on. Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") Reviewed-by: Konrad Dybcio Signed-off-by: Stephan Gerhold --- This can be applied as fix for 6.11 since the driver w

[PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-15 Thread Stephan Gerhold
nfiguration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Reviewed-by: Douglas Anderson Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/pa

[PATCH v2 0/4] drm/panel: atna33xc20: Fix the Samsung ATNA45AF01 panel

2024-07-15 Thread Stephan Gerhold
work correctly. The panel and DT changes can be picked up independently. Since v2 uses the existing "samsung,atna33xc20" compatible as fallback, the DT changes work even without the driver changes. Signed-off-by: Stephan Gerhold --- Changes in v2: - Use fallback compatible to avoid

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-12 Thread Stephan Gerhold
On Wed, Jul 10, 2024 at 12:16:58PM -0700, Doug Anderson wrote: > On Wed, Jul 10, 2024 at 12:03 PM Stephan Gerhold > wrote: > > > > > 2. In theory you could make your compatible look like this: > > > > > > compatible = "samsung,atna45af01", "

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-10 Thread Stephan Gerhold
On Wed, Jul 10, 2024 at 10:35:28AM -0700, Doug Anderson wrote: > On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold > wrote: > > > > The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight > > control over the DP AUX channel. While it works almost correctly w

[PATCH 3/5] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-10 Thread Stephan Gerhold
nfiguration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/d

[PATCH 5/5] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20

2024-07-10 Thread Stephan Gerhold
This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

[PATCH 4/5] arm64: dts: qcom: x1e80100-crd: Fix backlight

2024-07-10 Thread Stephan Gerhold
panel regulator. The panel does not seem to power off properly if the regulator stays on. Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100

[PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-10 Thread Stephan Gerhold
ust with a larger resolution and size. Add a new "samsung,atna45af01" compatible to describe this panel in the DT. Signed-off-by: Stephan Gerhold --- .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --

[PATCH 2/5] drm/panel: samsung-atna33xc20: Add compatible for ATNA45AF01

2024-07-10 Thread Stephan Gerhold
h "samsung,atna33xc20" as a fallback compatible, the original submission of the compatible in commit 4bfe6c8f7c23 ("drm/panel-simple: Add Samsung ATNA33XC20") had the timings and resolution hardcoded. These would not work for ATNA45AF01. Signed-off-by: Stephan Gerhold --- drive

[PATCH 0/5] drm/panel: atna33xc20: Fix the Samsung ATNA45AF01 panel

2024-07-10 Thread Stephan Gerhold
work correctly. The DT changes are included here for reference and easier testing, I assume Bjorn or Konrad will pick them up after the DRM panel changes were applied. Signed-off-by: Stephan Gerhold --- Stephan Gerhold (5): dt-bindings: display: panel: samsung,atna33xc20: Document

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-15 Thread Stephan Gerhold
On Thu, Jun 15, 2023 at 09:49:27AM +0200, Neil Armstrong wrote: > On 14/06/2023 22:58, Linus Walleij wrote: > > On Tue, Jun 13, 2023 at 11:08 PM Stephan Gerhold > > wrote: > > > > > I'm still quite confused about what exactly is supposed to be in > >

Re: [PATCH] drm/panel: move some dsi commands from unprepare to disable

2023-06-13 Thread Stephan Gerhold
[added Dmitry to Cc, since he suggested doing this in [1]] On Tue, Jun 13, 2023 at 12:36:52AM +0100, Caleb Connolly wrote: > The commit 007ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE") > breaks panels which send DSI commands in their .unprepare callbacks. > Migrate to using .disable for th

Re: [PATCH v2 7/7] ARM: dts: qcom: msm8226: Add mdss nodes

2023-05-31 Thread Stephan Gerhold
On Tue, May 30, 2023 at 08:24:17PM +0200, Luca Weiss wrote: > Add the nodes that describe the mdss so that display can work on > MSM8226. > > Signed-off-by: Luca Weiss Can you update this to use labels like in [1]? See inline below. This will allow proper grouping of the labels in the board DT.

Re: [Freedreno] [PATCH 3/7] dt-bindings: msm: dsi: Fix power-domains constraint

2022-07-01 Thread Stephan Gerhold
On Thu, Jun 30, 2022 at 08:49:03PM +0100, Bryan O'Donoghue wrote: > On 30/06/2022 20:01, Krzysztof Kozlowski wrote: > > On 30/06/2022 14:08, Bryan O'Donoghue wrote: > > > The existing msm8916.dtsi does not depend on nor require power-domains. > > > Drop from the list of required. > > > > That's no

[PATCH] drm/msm: Fix devfreq NULL pointer dereference on a3xx

2021-09-13 Thread Stephan Gerhold
actually initialized earlier. Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") Reported-by: Nikita Travkin Tested-by: Nikita Travkin Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/g

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-08 Thread Stephan Gerhold
On Sun, Aug 08, 2021 at 09:44:57PM +0800, Shawn Guo wrote: > On Wed, Aug 04, 2021 at 02:09:19PM +0200, Stephan Gerhold wrote: > > On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > > > + ... > > > + nt_dcs_write(0xb1, 0x6c, 0x21); > > > + nt_dcs_writ

Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver

2021-08-04 Thread Stephan Gerhold
Hi Shawn, Thanks for the patch! On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which > can be found on Sony Xperia M4 Aqua phone. The panel backlight is > managed through DSI link. > > Signed-off-by: Shawn Guo > ---

Re: [PATCH] drm/mcde: Fix off by 10^3 in calculation

2021-06-09 Thread Stephan Gerhold
were not so lucky and got black screens. > > Cc: Ville Syrjälä > Reported-by: Stephan Gerhold > Fixes: 920dd1b1425b ("drm/mcde: Use mode->clock instead of reverse > calculating it from the vrefresh") > Signed-off-by: Linus Walleij Can confirm this makes things much

Re: [PATCH v2] drm/mcde: Retry DSI read/write transactions

2020-08-15 Thread Stephan Gerhold
gt; the Samsung s6e63m0 panel on the Golden device. > > Retry reads and writes alike three times. > > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Retry three times. > - Only retry the actual command transmission like the vendor >

Re: [PATCH 2/4] drm/panel: s6e63m0: Add DSI transport

2020-08-14 Thread Stephan Gerhold
On Sun, Aug 09, 2020 at 11:51:02PM +0200, Linus Walleij wrote: > This makes it possible to use the s6e63m0 panel with a > DSI host, such as in the Samsung GT-I8190 (Golden) mobile > phone. > > Cc: Stephan Gerhold > Cc: Paweł Chmiel > Signed-off-by: Linus Walleij > ---

Re: [PATCH] drm/mcde: Retry DSI read/write transactions

2020-07-30 Thread Stephan Gerhold
gt; the Samsung s6e63m0 panel on the Golden device. > So this fixes reads from the panel for samsung-golden? > Retry reads and writes alike two times. > > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/mcde/mcde_dsi.c | 21 +++-- &g

Re: [PATCH 2/2 v2] drm/mcde: Fix display data flow control

2020-07-29 Thread Stephan Gerhold
> a TE request before every command when sending data to > a display in command mode: this should only be explicitly > requested when using BTA, according to the vendor driver. > > This has been tested and works fine with the command mode > displays I have. (All that are su

Re: [PATCH 2/2] drm/mcde: Fix display data flow control

2020-07-29 Thread Stephan Gerhold
isplay in command mode: this should only be explicitly > requested when using BTA, according to the vendor driver. > > This has been tested and works fine with the command mode > displays I have. (All that are supported upstream.) > > Reported-by: Steph

Re: [PATCH 1/2] drm/mcde: Rename flow function

2020-07-29 Thread Stephan Gerhold
current > usage. > > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij Reviewed-by: Stephan Gerhold > --- > drivers/gpu/drm/mcde/mcde_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mcde/mcde_display.c >

Re: [PATCH] drm/mcde: Fix stability issue

2020-07-26 Thread Stephan Gerhold
_display_send_one_frame(). > > This fixes crashes on the Samsung GT-S7710 (Skomer). > > Cc: Stephan Gerhold > Cc: sta...@vger.kernel.org > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/mcde/mcde_display.c | 11 --- > 1 file changed, 8 insertions(+), 3 del

Re: [PATCH v3 0/2] drm/modes: Apply video parameters with only reflect option

2020-02-12 Thread Stephan Gerhold
Hi Maxime, On Fri, Jan 17, 2020 at 07:51:00PM +0100, Maxime Ripard wrote: > On Fri, Jan 17, 2020 at 04:34:27PM +0100, Stephan Gerhold wrote: > > At the moment, video mode parameters like video=540x960,reflect_x, > > (without rotation set) are not taken into account when applying

[PATCH v3 2/2] drm/modes: Allow DRM_MODE_ROTATE_0 when applying video mode parameters

2020-01-17 Thread Stephan Gerhold
ation" and should therefore not require any special handling, so we can just add it to the if condition. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/drm_client_modeset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drive

[PATCH v3 0/2] drm/modes: Apply video parameters with only reflect option

2020-01-17 Thread Stephan Gerhold
tion values v2: https://lore.kernel.org/dri-devel/20191216171017.173326-1-step...@gerhold.net/ - Clarified commit message - parameters are parsed correctly, but not taken into account when applying the mode. v1: https://lore.kernel.org/dri-devel/20191209183254.211428-1-step...@gerhold.ne

[PATCH v3 1/2] drm/modes: Make sure to parse valid rotation value from cmdline

2020-01-17 Thread Stephan Gerhold
valid rotation value: - Set DRM_MODE_ROTATE_0 by default (if no rotate= option is set) - Validate that there is exactly one rotation angle set (i.e. specifying the rotate= option multiple times is invalid) Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/drm_modes.c

Re: [PATCH v2] drm/modes: Apply video parameters with only reflect option

2020-01-13 Thread Stephan Gerhold
Hi Maxime, On Mon, Dec 16, 2019 at 07:08:12PM +0100, Stephan Gerhold wrote: > On Mon, Dec 16, 2019 at 07:27:25PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 16, 2019 at 06:10:17PM +0100, Stephan Gerhold wrote: > > > At the moment, video mode parameters like video=540x960,reflect

Re: [PATCH v6] drm/mcde: Some fixes to handling video mode

2019-12-17 Thread Stephan Gerhold
ck - 6 as in > the vendor driver and mask the field properly. > - Set the DSI_VID_VCA_SETTING1 field > DSI_VID_VCA_SETTING1_MAX_BURST_LIMIT to blkeol_pck - 6 to > blkeol_duration - 6 as in the vendor driver. > > Cc: Stephan Gerhold > Fixes: 5fc537bfd000 ("drm/mcde:

Re: [PATCH v5] drm/mcde: Some fixes to handling video mode

2019-12-17 Thread Stephan Gerhold
tation where the code is hard to understand. > - Set the DSI_VID_VCA_SETTING2 field > DSI_VID_VCA_SETTING2_MAX_LINE_LIMIT to blkline_pck - 6 as in > the vendor driver and mask the field properly. > > Cc: Stephan Gerhold > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericss

Re: [PATCH v2] drm/modes: Apply video parameters with only reflect option

2019-12-16 Thread Stephan Gerhold
On Mon, Dec 16, 2019 at 07:27:25PM +0200, Ville Syrjälä wrote: > On Mon, Dec 16, 2019 at 06:10:17PM +0100, Stephan Gerhold wrote: > > At the moment, video mode parameters like video=540x960,reflect_x, > > (without rotation set) are not taken into account when applying

Re: [PATCH v3] drm/mcde: Some fixes to handling video mode

2019-12-16 Thread Stephan Gerhold
zero like in the vendor driver. > - Put in lots of clarifying comments and references to the > documentation where the code is hard to understand. > > Cc: Stephan Gerhold > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") > Signed-off-by: Linus

[PATCH v2] drm/modes: Apply video parameters with only reflect option

2019-12-16 Thread Stephan Gerhold
handling (e.g. specific tiling format). This makes video parameters with only reflect option work correctly. Signed-off-by: Stephan Gerhold --- v1: https://lists.freedesktop.org/archives/dri-devel/2019-December/248145.html Changes in v2: - Clarified commit message - parameters are parsed correctly

Re: [PATCH] drm/modes: Support video parameters with only reflect option

2019-12-13 Thread Stephan Gerhold
On Fri, Dec 13, 2019 at 10:39:50AM +0100, Maxime Ripard wrote: > Hi Stephan, > > On Wed, Dec 11, 2019 at 08:08:39PM +0100, Stephan Gerhold wrote: > > On Wed, Dec 11, 2019 at 07:10:46PM +0100, Maxime Ripard wrote: > > > On Tue, Dec 10, 2019 at 11:42:37AM +0100, Stephan G

Re: [PATCH] drm/modes: Support video parameters with only reflect option

2019-12-11 Thread Stephan Gerhold
On Wed, Dec 11, 2019 at 07:10:46PM +0100, Maxime Ripard wrote: > Hi Stephan, > > On Tue, Dec 10, 2019 at 11:42:37AM +0100, Stephan Gerhold wrote: > > On Tue, Dec 10, 2019 at 11:20:46AM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Dec 09,

Re: [PATCH] drm/modes: Support video parameters with only reflect option

2019-12-10 Thread Stephan Gerhold
On Tue, Dec 10, 2019 at 11:20:46AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Dec 09, 2019 at 07:32:54PM +0100, Stephan Gerhold wrote: > > At the moment, video mode parameters like video=540x960,reflect_x, > > (without rotation set) are silently ignored. > > > &g

[PATCH] drm/modes: Support video parameters with only reflect option

2019-12-09 Thread Stephan Gerhold
o parameters with only reflect option work correctly. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/drm_client_modeset.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modes

Re: [PATCH 2/2] drm/mcde: Do not needlessly logically and with 3

2019-11-22 Thread Stephan Gerhold
tes less cognitive stress > for humans. > > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij Reviewed-by: Stephan Gerhold > --- > drivers/gpu/drm/mcde/mcde_dsi.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH 1/2] drm/mcde: Reuse global DSI command defs

2019-11-22 Thread Stephan Gerhold
On Fri, Nov 22, 2019 at 08:24:57AM +0100, Linus Walleij wrote: > The MCDE DSI include file redefines some commands that > already exist in the common header. > > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij Reviewed-by: Stephan Gerhold > --- > drivers/gp

Re: [PATCH 2/2 v6] drm/panel: Add driver for Sony ACX424AKP panel

2019-11-20 Thread Stephan Gerhold
nd mode > by using the bool property "dsi-command-mode". > > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij > --- > ChangeLog v4->v5: > - Bindings were iterated separately so a jump in versioning. > - Add Stephan as reviewer. > ChangeLog v3->v4: >

[PATCH] drm/mcde: dsi: Fix invalid pointer dereference if panel cannot be found

2019-11-18 Thread Stephan Gerhold
h above then becomes: mcde-dsi a0351000.dsi: failed to find panel try bridge (-517) mcde-dsi a0351000.dsi: no panel or bridge ... Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/mcde/mcde_dsi.c | 6 --

Re: [Freedreno] [PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable()

2019-11-09 Thread Stephan Gerhold
On Fri, Nov 08, 2019 at 08:47:08PM -0700, Jeffrey Hugo wrote: > On Fri, Nov 8, 2019 at 4:47 PM Stephan Gerhold wrote: > > > > On Fri, Nov 08, 2019 at 03:12:28PM -0700, Jeffrey Hugo wrote: > > > On Fri, Nov 8, 2019 at 2:29 PM Stephan Gerhold > > > wrote: >

Re: [Freedreno] [PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable()

2019-11-08 Thread Stephan Gerhold
On Fri, Nov 08, 2019 at 03:12:28PM -0700, Jeffrey Hugo wrote: > On Fri, Nov 8, 2019 at 2:29 PM Stephan Gerhold wrote: > > > > At the moment, the MSM DSI driver calls drm_panel_enable() rather early > > from the DSI bridge pre_enable() function. At this point, the encoder &

[PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable()

2019-11-08 Thread Stephan Gerhold
ble() to dsi_mgr_bridge_disable() for similar reasons. (This is not strictly required for the panel affected above...) Tested-by: Jasper Korten Signed-off-by: Stephan Gerhold --- Since this is a core change I thought it would be better to send this early. I believe Jasper still wants to finish some other change

[PATCH 7/7] drm/mcde: Handle pending vblank while disabling display

2019-11-06 Thread Stephan Gerhold
if there is an vblank event pending when disabling the display, and clear it by sending a fake vblank event in that case. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/mcde/mcde_display.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/mcde/mcde_display.c b

[PATCH 3/7] drm/mcde: dsi: Make video mode errors more verbose

2019-11-06 Thread Stephan Gerhold
Triggering an error conditions in DSI video mode only results in a very generic "some video mode error status" error message at the moment. Make this more clear by adding separate error messages for each bit. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/mcde/mcde_dsi.c

[PATCH 0/7] drm/mcde: DSI video mode fixes

2019-11-06 Thread Stephan Gerhold
://lists.freedesktop.org/archives/dri-devel/2019-October/238175.html Stephan Gerhold (7): drm/mcde: Provide vblank handling unconditionally drm/mcde: Fix frame sync setup for video mode panels drm/mcde: dsi: Make video mode errors more verbose drm/mcde: dsi: Delay start of video stream

[PATCH 5/7] drm/mcde: dsi: Fix duplicated DSI connector

2019-11-06 Thread Stephan Gerhold
le above. Therefore we can just remove the connector setup from mcde_dsi.c and let the DRM core handle all the hard work. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/mcde/mcde_dsi.c | 52 + 1 file changed, 1 insertion(+), 51 deletions(-) diff --git a/

[PATCH 6/7] drm/mcde: dsi: Enable clocks in pre_enable() instead of mode_set()

2019-11-06 Thread Stephan Gerhold
sequence from mode_set() to pre_enable(). Keep most of the video mode setup in mode_set() since most of the registers are only dependent on the mode that is set for the panel - there is no need to write them again each time we re-enable the display. Signed-off-by: Stephan Gerhold --- drivers/gpu

[PATCH 1/7] drm/mcde: Provide vblank handling unconditionally

2019-11-06 Thread Stephan Gerhold
, the vblank handling should be working correctly in all the cases and we can enable it unconditionally. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/mcde/mcde_display.c | 15 +-- drivers/gpu/drm/mcde/mcde_drv.c | 16 2 files changed, 9 insertions(+), 22

[PATCH 2/7] drm/mcde: Fix frame sync setup for video mode panels

2019-11-06 Thread Stephan Gerhold
necessary changes in that case. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/mcde/mcde_display.c | 32 - drivers/gpu/drm/mcde/mcde_drm.h | 1 + drivers/gpu/drm/mcde/mcde_drv.c | 2 -- drivers/gpu/drm/mcde/mcde_dsi.c | 13 ++-- 4 files c

[PATCH 4/7] drm/mcde: dsi: Delay start of video stream generator

2019-11-06 Thread Stephan Gerhold
DSI formatter is properly set up and running (i.e. when mcde_dsi_bridge_enable() is called). Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/mcde/mcde_dsi.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde

[PATCH v2] drm/msm/dsi: Implement qcom,dsi-phy-regulator-ldo-mode for 28nm PHY

2019-10-23 Thread Stephan Gerhold
rogram the registers correctly for LDO mode. Tested-by: Nikita Travkin # l8150 Signed-off-by: Stephan Gerhold --- Changes in v2: Move DCDC/LDO code into separate methods v1: https://lore.kernel.org/linux-arm-msm/20191021163425.83697-1-step...@gerhold.net/ This is needed to make the display work on Longc

Re: [PATCH] drm/msm/dsi: Implement qcom,dsi-phy-regulator-ldo-mode for 28nm PHY

2019-10-21 Thread Stephan Gerhold
On Mon, Oct 21, 2019 at 01:47:19PM -0400, Sean Paul wrote: > On Mon, Oct 21, 2019 at 06:34:25PM +0200, Stephan Gerhold wrote: > > The DSI PHY regulator supports two regulator modes: LDO and DCDC. > > This mode can be selected using the "qcom,dsi-phy-regulator-ldo-mode"

[PATCH] drm/msm/dsi: Implement qcom,dsi-phy-regulator-ldo-mode for 28nm PHY

2019-10-21 Thread Stephan Gerhold
rogram the registers correctly for LDO mode. Tested-by: Nikita Travkin # l8150 Signed-off-by: Stephan Gerhold --- This is needed to make the display work on Longcheer L8150, which has recently gained mainline support in: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/

Re: [PATCH v2] drm/mcde: Some fixes to handling video mode

2019-09-03 Thread Stephan Gerhold
ll > back to zero like in the vendor driver. > > Cc: Stephan Gerhold > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Fix some more comments so we understand what is going

Re: [PATCH v3] drm/mcde: Fix DSI transfers

2019-09-03 Thread Stephan Gerhold
read up to 4 bytes from the > display. > > Tested with a Sony ACX424AKP display: this display now self- > identifies and can control backlight in command mode. > > Reported-by: kbuild test robot > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE"

Re: [PATCH] drm/mcde: Some fixes to handling video mode

2019-09-02 Thread Stephan Gerhold
ll > back to zero like in the vendor driver. > > Cc: Stephan Gerhold > Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/mcde/mcde_dsi.c | 60 ++--- > 1 file

Re: [PATCH v2] drm/mcde: Fix DSI transfers

2019-09-02 Thread Stephan Gerhold
read up to 4 bytes from the > display. > > Tested with a Sony ACX424AKP display: this display now self- > identifies and can control backlight in command mode. > > Cc: Stephan Gerhold > Reported-by: kbuild test robot > Fixes: 5fc537bfd000 ("drm/mcde: Add new driv

Re: [PATCH] drm/msm: shake fist angrily at dma-mapping

2019-07-31 Thread Stephan Gerhold
t; msm_gem_get_and_pin_iova+0xdc/0x168 [msm] > ... > > Fixes the combination of two patches: > > Fixes: 0036bc73ccbe ("drm/msm: stop abusing dma_map/unmap for cache") > Fixes: 449fa54d6815 ("dma-direct: correct the physical addr in > dma_direct_sync_sg_for_cpu/device") Thanks for the patch! It fixes the issue on MSM8916/A5U: Tested-by: Stephan Gerhold