Hi Christian,
On Mon, Nov 14, 2016 at 10:43:10AM +0100, Christian König wrote:
> Am 14.11.2016 um 00:03 schrieb Stefan Christ:
> > Hi,
> >
> > this is the second version of the refactoring work suggested by Daniel
> > Vetter
> > in the email:
> >
> &g
:
.fb_setcmap = drm_fb_helper_setcmap,
and the struct psbfb_unaccel_ops implements two additional members:
.fb_setcmap = drm_fb_helper_setcmap,
.fb_pan_display = drm_fb_helper_pan_display,
These changes are not tested.
Cc: Patrik Jakobsson
Signed-off-by: Stefan Christ
Cc: Daniel Vetter
Cc: Jani Nikula
Signed-off-by: Stefan Christ
---
v2: Also remove fb_debug_(enter|leave) assignments
---
drivers/gpu/drm/i915/intel_fbdev.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
b/drivers/gpu/drm/i915
Cc: Tomi Valkeinen
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/omapdrm/omap_fbdev.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c
b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index adb10fb..8d8ac17 100644
--- a/drivers/gpu/drm
This patch removes a TODO comment in the code. I do not know whether it
is still relevant.
Cc: David Airlie
Cc: Gerd Hoffmann
Signed-off-by: Stefan Christ
---
v2: Also remove fb_debug_(enter|leave) assignments
---
drivers/gpu/drm/virtio/virtgpu_fb.c | 8 +---
1 file changed, 1 insertion
Cc: Rob Clark
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/msm/msm_fbdev.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index ffd4a33..d29f5e8 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b
Cc: Dave Airlie
Signed-off-by: Stefan Christ
---
v2: Also remove fb_debug_(enter|leave) assignments
---
drivers/gpu/drm/udl/udl_fb.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index 611b6b9..167f42c
Cc: Thierry Reding
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/tegra/fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index e6d71fa..e4a5ab0 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm
Cc: Alex Deucher
Signed-off-by: Stefan Christ
---
v2: Also remove fb_debug_(enter|leave) assignments
---
drivers/gpu/drm/radeon/radeon_fb.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c
b/drivers/gpu/drm/radeon/radeon_fb.c
index
Cc: Mark Yao
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
index a16c69f..8f639c8 100644
--- a
This patch removes a TODO comment in the code. I do not know whether it
is still relevant.
Cc: Dave Airlie
Signed-off-by: Stefan Christ
---
v2: Also remove fb_debug_(enter|leave) assignments
v2: Add note about TODO comment in commit message
---
drivers/gpu/drm/qxl/qxl_fb.c | 8 +---
1 file
Cc: Ben Skeggs
Signed-off-by: Stefan Christ
---
v2: Also remove fb_debug_(enter|leave) assignments
---
drivers/gpu/drm/nouveau/nouveau_fbcon.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
b/drivers/gpu/drm/nouveau
Cc: Inki Dae
Cc: Joonyoung Shim
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Acked-by: Inki Dae
Signed-off-by: Stefan Christ
---
v2: Add Acked-by from Inki Dae
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
Cc: David Airlie
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/drm_fb_cma_helper.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
b/drivers/gpu/drm/drm_fb_cma_helper.c
index 1fd6eac..71551fd 100644
--- a/drivers/gpu/drm
Cc: Gerd Hoffmann
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/bochs/bochs_fbdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bochs/bochs_fbdev.c
b/drivers/gpu/drm/bochs/bochs_fbdev.c
index e1ec498..da790a1 100644
--- a/drivers/gpu/drm/bochs
Cc: Russell King
Signed-off-by: Stefan Christ
---
v2: Also remove fb_debug_(enter|leave) assignments
---
drivers/gpu/drm/armada/armada_fbdev.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_fbdev.c
b/drivers/gpu/drm/armada
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Stefan Christ
---
v2: Also remove fb_debug_(enter|leave) assignments
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
b/drivers/gpu
Add additional members fb_debug_enter and fb_debug_leave to helper
define. They are shared by all fb_ops implementations.
Suggested-by: Daniel Vetter
Signed-off-by: Stefan Christ
---
include/drm/drm_fb_helper.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/drm
mented, the
code in drm_fb_helper_debug_(enter|leave) does effectively nothing.
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/drm_fb_helper.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 03414bd..823fc9e 1006
nobody noticed.
Refactoring patches for ast, cirrus and mgag200 are dropped. I leave it to
Daniel if additional drivers should not be converted.
This series is based on tag v4.9-rc1 and applies cleanly onto drm-next, too.
Kind regards,
Stefan Christ
Changes in v2:
- add patch
Fix invalid sphinx markup in the comment for the newly added
DRM_FB_HELPER_DEFAULT_OPS.
Signed-off-by: Stefan Christ
---
Hi,
> > If I'm not mistaken v1 of this patch is already in drm-misc so you may
> > want to send a patch that fix just the line above.
>
> Yup, I ne
implementations */
};
Suggested-by: Daniel Vetter
Signed-off-by: Stefan Christ
---
v2: Fix sphinx error:
warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS:
---
include/drm/drm_fb_helper.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/drm
:
.fb_setcmap = drm_fb_helper_setcmap,
and the struct psbfb_unaccel_ops implements two additional members:
.fb_setcmap = drm_fb_helper_setcmap,
.fb_pan_display = drm_fb_helper_pan_display,
These changes are not tested.
Cc: Patrik Jakobsson
Signed-off-by: Stefan Christ
Cc: Daniel Vetter
Cc: Jani Nikula
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/i915/intel_fbdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbdev.c
b/drivers/gpu/drm/i915/intel_fbdev.c
index 3e3632c..cf589ab 100644
--- a/drivers/gpu
Cc: Tomi Valkeinen
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/omapdrm/omap_fbdev.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c
b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index adb10fb..8d8ac17 100644
--- a/drivers/gpu/drm
This patch removes a TODO comment in the code. I do not know whether it
is still relevant.
Cc: David Airlie
Cc: Gerd Hoffmann
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/virtio/virtgpu_fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/virtio
Cc: Rob Clark
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/msm/msm_fbdev.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index ffd4a33..d29f5e8 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b
Cc: Dave Airlie
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/udl/udl_fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
index 9688bfa..2137a4f 100644
--- a/drivers/gpu/drm/udl/udl_fb.c
+++ b/drivers/gpu
Cc: Thierry Reding
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/tegra/fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index e6d71fa..e4a5ab0 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm
Cc: Alex Deucher
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/radeon/radeon_fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c
b/drivers/gpu/drm/radeon/radeon_fb.c
index 0e3143a..12c6fe1 100644
--- a/drivers/gpu/drm/radeon
Cc: Mark Yao
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
index 207e01d..46eaa3e 100644
--- a
Cc: Dave Airlie
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/qxl/qxl_fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c
index 28c1423..114f4cb 100644
--- a/drivers/gpu/drm/qxl/qxl_fb.c
+++ b/drivers/gpu
Cc: Ben Skeggs
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/nouveau/nouveau_fbcon.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index d1f248f..2373796 100644
--- a
Cc: Dave Airlie
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/mgag200/mgag200_fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c
b/drivers/gpu/drm/mgag200/mgag200_fb.c
index d9b04b0..a41aa19 100644
--- a/drivers/gpu/drm/mgag200
Cc: Inki Dae
Cc: Joonyoung Shim
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
b/drivers/gpu/drm/exynos
Cc: David Airlie
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/drm_fb_cma_helper.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
b/drivers/gpu/drm/drm_fb_cma_helper.c
index 1fd6eac..71551fd 100644
--- a/drivers/gpu/drm
Cc: Dave Airlie
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
index 3b5be72..4f8d42b 100644
--- a/drivers/gpu/drm
Cc: Gerd Hoffmann
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/bochs/bochs_fbdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bochs/bochs_fbdev.c
b/drivers/gpu/drm/bochs/bochs_fbdev.c
index e1ec498..da790a1 100644
--- a/drivers/gpu/drm/bochs
Cc: Dave Airlie
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/ast/ast_fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index c017a93..b604fdd 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu
Cc: Russell King
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/armada/armada_fbdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_fbdev.c
b/drivers/gpu/drm/armada/armada_fbdev.c
index 7d03c51..0322bb0 100644
--- a/drivers/gpu/drm
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
index 9191467..6b80982 100644
implementations */
};
Suggested-by: Daniel Vetter
Signed-off-by: Stefan Christ
---
include/drm/drm_fb_helper.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index db8d478..b76f5c7 100644
--- a/include/drm
s series is based on tag v4.8-rc8. If rebased onto 'drm-next' there are two
small conflicts.
Kind regards,
Stefan Christ
Stefan Christ (20):
drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops
drm/amdgpu: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops
drm/armada: use DRM_FB
/0xa SS:ESP 0068:f5e6bccc
CR2: 0104
---[ end trace 27c6bec7dc5672b3 ]---
Signed-off-by: Stefan Christ
---
Hi,
trying out the recent release candiate of the linux kernel 4.8, namely v4.8-rc1
and v4.8-rc6, I see this regression on my IBM Thinkpad X40. My video hardware is
Stub implementation of fb_ioctl can be omitted, because function
do_fb_ioctl already returns -ENOTTY when fb_ioctl is not assigned.
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/gma500/framebuffer.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/gpu/drm/gma500
ches? One big patch, one patch
per driver or group of drivers per patch?
Mit freundlichen GrüÃen / Kind regards,
Stefan Christ
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
Hi Daniel,
On Wed, Jul 13, 2016 at 12:00:07PM +0200, Daniel Vetter wrote:
> On Wed, Jul 13, 2016 at 10:11:45AM +0200, Stefan Christ wrote:
> > Hi,
> >
> > im currently working on supporting double/tripple buffering for the
> > framebuffer
> > emulation on
mebuffer
ioctl FBIOPAN_DISPLAY for buffer flipping. When the fast-patch is not
present, the ioctl FBIOPAN_DISPLAY causes a complete mode set which is
too interruptive.
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/imx/ipuv3-crtc.c | 10 ++
1 file changed, 10 insertions(+)
diff --g
based on
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/gpu/drm/xilinx/xilinx_drm_fb.c#L196
Signed-off-by: Stefan Christ
---
drivers/gpu/drm/drm_fb_cma_helper.c | 1 +
drivers/gpu/drm/drm_fb_helper.c | 43 +
include/drm/drm_fb_helper.h
a buffer flip can be operated. It will need
some time for Android device vendors to abondon legency fbdev. So multi
buffer for fbdev is needed.
Signed-off-by: Xinliang Liu
[s.christ at phytec.de: Picking patch from
https://lkml.org/lkml/2015/9/14/188]
Signed-off-by: Stefan
needed for simple
framebuffer applications and some OpenGL libraries using double buffering with
FBIOPUT_VSCREENINFO, FBIO_WAITFORVSYNC and FBIOPAN_DISPLAY.
Any comments?
Kind regards,
Stefan Christ
Stefan Christ (2):
drm: fb_helper: implement ioctl FBIO_WAITFORVSYNC
drm/imx: ipuv3
51 matches
Mail list logo