Hi Dzmitry,
On Fri, Sep 13, 2024 at 10:15 AM Dzmitry Sankouski wrote:
>
> Leave gmu enabled, because it's only probed when
> GPU is.
>
> Signed-off-by: Dzmitry Sankouski
> ---
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 4
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts
x27;s keeping the panel power on
> then without my patch it would be possible to do DP AUX transactions
> even when the panel was "off" from Linux's point of view. It would
> have worked mostly due to luck, but now luck will run out and it will
> stop working. I really hope nobody has userspace that is relying on
> this, but I suppose it's always possible that somewhere, someone's
> userspace is. If you are or know of someone who is then please shout.
>
> -Doug
Tested on my Thinkpad X13s, with display on, I get the did when
hexdumping /dev/drm_dp_aux2, with display off I get device/resource
busy.
Tested-by: Steev Klimaszewski
On Thu, Nov 30, 2023 at 1:21 PM Rob Clark wrote:
>
> From: Rob Clark
>
> The UBWC settings need to match between the display and GPU. When we
> updated the GPU settings, we forgot to make the corresponding update on
> the display side.
>
> Reported-by: Steev Klimaszewsk
= {0xf, 0x, 0x0},
> + .safe_lut_tbl = {0xfe00, 0xfe00, 0x},
> .qos_lut_tbl = {
> {.nentry = ARRAY_SIZE(sc8180x_qos_linear),
> .entries = sc8180x_qos_linear
>
> ---
> base-commit: c503e3eec382ac708ee7adf874add37b77c5d312
> change-id: 20231030-sc8280xp-dpu-safe-lut-9769027b8452
>
> Best regards,
> --
> Bjorn Andersson
>
Tested-by: Steev Klimaszewski
> --
> 2.39.2
>
Tested here on my X13s with GNOME 44.1 and using Wayland.
Tested-by: Steev Klimaszewski
Hi Dmitry
On Sun, May 21, 2023 at 12:28 PM Dmitry Baryshkov
wrote:
>
> Both DPU and MDSS programming requires knowledge of some of UBWC
> parameters. This results in duplication of UBWC data between MDSS and
> DPU drivers. To remove such duplication and make the driver more
> error-prone, export
rs/gpu/drm/tiny/simpledrm.c
> > @@ -802,6 +802,7 @@ static int simpledrm_probe(struct platform_device *pdev)
> > {
> > struct simpledrm_device *sdev;
> > struct drm_device *dev;
> > + unsigned int color_mode;
> > int ret;
> >
> > sdev = simpledrm_device_create(&simpledrm_driver, pdev);
> > @@ -813,7 +814,11 @@ static int simpledrm_probe(struct platform_device
> > *pdev)
> > if (ret)
> > return ret;
> >
> > - drm_fbdev_generic_setup(dev, drm_format_info_bpp(sdev->format, 0));
> > + color_mode = drm_format_info_bpp(sdev->format, 0);
> > + if (color_mode == 16)
> > + color_mode = sdev->format->depth; // can be 15 or 16
> > +
> > + drm_fbdev_generic_setup(dev, color_mode);
> >
> > return 0;
> > }
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Ivo Totev
I know it's already in drm-misc-next, but wanted to chime in...
I've tested v4 on the Thinkpad X13s as well as the Yoga C630 WoS, both
msm based systems and this does fix the issue I was seeing as well as
make my patch not needed and can be considered abandoned.
Tested-by: Steev Klimaszewski
---[ end trace ]---
Signed-off-by: Steev Klimaszewski
---
drivers/gpu/drm/msm/msm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 8b0b0ac74a6f..65c4c93c311e 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
++
On 1/2/23 2:21 AM, Johan Hovold wrote:
On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa wrote:
The actual name is R133NW4K-R0.
Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
Signed-off-by:
133NW4J-R3"),
> + EDP_PANEL_ENTRY('I', 'V', 'O', 0x854b, &delay_200_500_p2e100,
> "R133NW4K-R0"),
>
> EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624,
> &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"),
> EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50,
> "116N29-30NK-C007"),
> --
> 2.34.1
>
Thanks for this - when I was looking for the panel, I simply went with
what I found on panel-look.
Tested-by: Steev Klimaszewski
--steev
p-dpu.yaml
> create mode 100644
> Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
>
> --
> 2.37.3
>
Tested on Lenovo Thinkpad X13s
Tested-by: Steev Klimaszewski
reg = <0 0x0ae96400 0 0x200>,
<0 0x0ae96600 0 0x280>,
Tested on Lenovo Yoga C630
Tested-by: Steev Klimaszewski
Hi Johan,
On Wed, Sep 14, 2022 at 1:01 AM Johan Hovold wrote:
>
> On Tue, Sep 13, 2022 at 03:23:10PM -0500, Steev Klimaszewski wrote:
> > Hi Johan,
> >
> > On 9/13/22 3:53 AM, Johan Hovold wrote:
> > > The MSM DRM driver is currently broken in multiple ways wit
Hi Johan,
On 9/13/22 3:53 AM, Johan Hovold wrote:
The MSM DRM driver is currently broken in multiple ways with respect to
probe deferral. Not only does the driver currently fail to probe again
after a late deferral, but due to a related use-after-free bug this also
triggers NULL-pointer derefere
On 9/12/22 1:10 PM, Dmitry Baryshkov wrote:
On 12/09/2022 18:40, Johan Hovold wrote:
Device-managed resources allocated post component bind must be tied to
the lifetime of the aggregate DRM device or they will not necessarily be
released when binding of the aggregate device is deferred.
This
On Wed, Aug 10, 2022 at 11:28 PM Steev Klimaszewski wrote:
>
> Hi Bjorn,
>
>
> On Wed, Aug 10, 2022 at 10:58 PM Bjorn Andersson
> wrote:
> >
> > The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9
> > interfaces, 2 DSI controllers and 4
Hi Bjorn,
On Wed, Aug 10, 2022 at 10:58 PM Bjorn Andersson
wrote:
>
> The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9
> interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the
> necessary definitions and describe the DPU in the SC8280XP.
>
> Signed-off-by: Bjorn
Add an eDP panel entry for IVO M133NW4J-R3.
Due to lack of documentation, use the delay_200_500_e50 timings for now.
Signed-off-by: Steev Klimaszewski
---
v2 - actually mark it as R3 in the change, not R2...
I'm basing my information gathering off what I could find for the IVO
M133NW4J p
Add an eDP panel entry for IVO M133NW4J-R3.
Due to lack of documentation, use the delay_200_500_e50 timings for now.
Signed-off-by: Steev Klimaszewski
---
I'm basing my information gathering off what I could find for the IVO
M133NW4J panels on panelook.com. R0 is glossy, and mine is not
ted_aux;
+ if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
+ return 0;
+
pdata->connector = drm_bridge_connector_init(pdata->bridge.dev,
pdata->bridge.encoder);
if (IS_ERR(pdata->connector)) {
Tested on Lenovo Yoga C630
Tested-by: Steev Klimaszewski
min_dp_rate_idx(pdata, bpp);
dp_rate_idx < ARRAY_SIZE(ti_sn_bridge_dp_rate_lut);
dp_rate_idx++) {
if (!(valid_rates & BIT(dp_rate_idx)))
Tested on the Lenovo Yoga C630. bpc is found to be 6, which I believe
is correct.
Tested-by: Steev Klimaszewski
again with
the correct value. But we should just not do this. Instead
just leave a sanity check that the fence looks plausible (in
case the GPU scribbled on memory).
Reported-by: Steev Klimaszewski
Fixes: 95d1deb02a9c ("drm/msm/gem: Add fenced vma unpin")
Signed-off-by: Rob Clark
---
d
. But walking the list of submits in the
irq handler isn't really needed, as dma_fence_is_signaled() will dtrt.
So lets just drop it entirely.
Reported-by: Steev Klimaszewski
Fixes: 95d1deb02a9c ("drm/msm/gem: Add fenced vma unpin")
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm
aspace->lock);
if (vma->iova)
I've seen the splat on the Lenovo Yoga C630 here, and have tested this
patch, and as described, the splat still happens, but the system is
still able to be used.
Tested-by: Steev Klimaszewski
On 11/17/21 1:27 AM, Christian König wrote:
Am 16.11.21 um 19:30 schrieb Amit Pundir:
On Tue, 16 Nov 2021 at 21:21, Rob Clark wrote:
From: Rob Clark
drm_sched_job_add_dependency() could drop the last ref, so we need
to do
the dma_fence_get() first.
It fixed the splats I saw on RB5 (sm8
ge from v1 :D
Tested-By: Steev Klimaszewski
On 11/4/21 5:28 PM, Rob Clark wrote:
From: Rob Clark
Reported-by: Douglas Anderson
Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gpu_devfreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/ms
On 10/14/21 10:42 AM, Steev Klimaszewski wrote:
On 10/14/21 8:54 AM, Dmitry Baryshkov wrote:
From: Amit Pundir
This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4.
This upstream commit broke AOSP (post Android 12 merge) build
on RB5. The device either silently crashes into USB
On 10/14/21 8:54 AM, Dmitry Baryshkov wrote:
From: Amit Pundir
This reverts commit 001ce9785c0674d913531345e86222c965fc8bf4.
This upstream commit broke AOSP (post Android 12 merge) build
on RB5. The device either silently crashes into USB crash mode
after android boot animation or we see a b
14,8 @@ struct pwm_device *pwm_request_from_chip(struct pwm_chip
> *chip,
>
> struct pwm_device *of_pwm_xlate_with_flags(struct pwm_chip *pc,
> const struct of_phandle_args *args);
> +struct pwm_device *of_pwm_single_xlate(struct pwm_chip *pc,
> +const struct of_phandle_args *args);
>
> struct pwm_device *pwm_get(struct device *dev, const char *con_id);
> struct pwm_device *of_pwm_get(struct device *dev, struct device_node *np,
I've tested these v6 all 3 patches on the Lenovo Yoga C630
Tested-by: Steev Klimaszewski
gt;Code: aa0003f5 a90153f3 f8408eb3 aa1303e0 (f85e8674)
>---[ end trace 39b2fa37509a2be2 ]---
> Fixing recursive fault but reboot is needed!
>
> Fixes: 86c2a0f000c1 drm/msm: ("Small submitqueue creation cleanup")
> Reported-by: Steev Klimaszewski
> Signed-off-b
On 3/31/21 7:34 AM, kalya...@codeaurora.org wrote:
> On 2021-03-31 00:04, Steev Klimaszewski wrote:
>> On 3/22/21 4:17 AM, Kalyan Thota wrote:
>>> From: Kalyan Thota
>>>
>>> DPU runtime resume will request for a min vote on the AXI bus as
>>> it
On 3/22/21 4:17 AM, Kalyan Thota wrote:
> From: Kalyan Thota
>
> DPU runtime resume will request for a min vote on the AXI bus as
> it is a necessary step before turning ON the AXI clock.
>
> The change does below
> 1) Move the icc path set before requesting runtime get_sync.
> 2) remove the dep
;))
> - dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
> -
> + dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
> if (dma_buf)
> geni_se_select_mode(se, GENI_SE_DMA);
> else
Tested-by: Steev Klimaszewski
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
From: Douglas AndersonSent: Friday, October 2, 2020 4:04 PMTo: Andrzej Hajda; Neil Armstrong; Sam RavnborgCc: Rob Clark; Bjorn Andersson; Steev Klimaszewski; Douglas Anderson; Daniel Vetter; David Airlie; Jernej Skrabec; Jonas Karlman; Laurent Pinchart; dri-devel@lists.freedesktop.org; linux-ker
; }
>
> + /* If we saw quite a few retries, add a note about it */
> + if (!ret && i > SN_LINK_TRAINING_TRIES / 2)
> + DRM_DEV_INFO(pdata->dev, "Link training needed %d retries\n",
> i);
> +
> exit:
> /* Disable the
,backlight-scale:
> +description:
> + The granularity of brightness for the PWM signal provided on GPIO4, if
> + this property is specified.
> +minimum: 0
> +maximum: 65535
>
>ports:
> type: object
Tested-By: Steev Klimaszewsk
DRM_ERROR("invalid max-brightness\n");
> + return -EINVAL;
> + }
> +
> + props.type = BACKLIGHT_RAW;
> + props.max_brightness = pdata->max_brightness;
> + bl = devm_backlight_device_register(dev, "sn65dsi86", dev, pdata,
> + &ti_sn_backlight_ops, &props);
> + if (IS_ERR(bl)) {
> + DRM_ERROR("failed to register backlight device\n");
> + return PTR_ERR(bl);
> + }
> +
> + return 0;
> +}
> +
> static int ti_sn_bridge_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> @@ -1224,6 +1353,12 @@ static int ti_sn_bridge_probe(struct i2c_client
> *client,
>
> pm_runtime_enable(pdata->dev);
>
> + ret = ti_sn_backlight_init(pdata);
> + if (ret) {
> + pm_runtime_disable(pdata->dev);
> + return ret;
> + }
> +
> ret = ti_sn_setup_gpio_controller(pdata);
> if (ret) {
> pm_runtime_disable(pdata->dev);
Tested-By: Steev Klimaszewski
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
8 +231,7 @@ static void _setup_pingpong_ops(struct dpu_hw_pingpong *c,
> c->ops.poll_timeout_wr_ptr = dpu_hw_pp_poll_timeout_wr_ptr;
> c->ops.get_line_count = dpu_hw_pp_get_line_count;
>
> - if (test_bit(DPU_PINGPONG_DITHER, &
On 7/10/20 9:47 AM, Doug Anderson wrote:
> Hi,
>
>
> But should I continue on this path,
> It's probably worth getting dithering working on your sdm845 anyway in
> case anyone actually does put a 6bpp panel on this SoC.
>
>
>> or should we be finding others who
>> have an N61 and see what their ED
On 7/9/20 10:17 PM, Steev Klimaszewski wrote:
On 7/9/20 10:12 PM, Steev Klimaszewski wrote:
On 7/9/20 9:14 PM, Doug Anderson wrote:
Hi,
On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson
wrote:
Hi,
On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski
wrote:
Hi Doug,
I've been testin
Hi,
On 7/9/20 11:12 PM, Doug Anderson wrote:
root@c630:~# bus=$(i2cdetect -l | grep sn65 | sed 's/i2c-\([0-9]*\).*$/\1/')
root@c630:~# i2cdump ${bus} 0x50 i > edid
WARNING! This program can confuse your I2C bus, cause data loss and worse!
I will probe file /dev/i2c-16, address 0x50, mode i2c blo
On 7/9/20 10:12 PM, Steev Klimaszewski wrote:
On 7/9/20 9:14 PM, Doug Anderson wrote:
Hi,
On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson
wrote:
Hi,
On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski
wrote:
Hi Doug,
I've been testing 5.8 and linux-next on the Lenovo Yoga C630, and
On 7/9/20 9:14 PM, Doug Anderson wrote:
Hi,
On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson wrote:
Hi,
On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote:
Hi Doug,
I've been testing 5.8 and linux-next on the Lenovo Yoga C630, and with this
patch applied, there is really bad ba
> for (j = 0; j < num; j++)
> - buffer[i + j] = value >> (j * 8);
> + buffer[i * 4 + j] = value >> (j * 8);
> }
> }
>
> --
> 2.4.5
>
>
This fixes the issue that I reported earlier, so feel free to add my
Tested-by: Steev Klimaszewski
-- next part --
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/dri-devel/attachments/20150720/be4f8a7b/attachment-0001.html>
45 matches
Mail list logo
