Re: [PATCH RFC 1/5] drm: Support post-blend color pipeline API

2025-09-26 Thread Sebastian Wick
(Sorry for re-sending; used a web mail client which send html) On Mon, Sep 15, 2025, at 2:31 PM, Daniel Stone wrote: > Hi Nícolas, > > On Wed, 3 Sept 2025 at 19:43, Nícolas F. R. A. Prado > wrote: > > On Tue, 2025-08-26 at 13:25 +0100, Daniel Stone wrote: > > Based on this discussion, this is my

Re: [PATCH RFC 1/5] drm: Support post-blend color pipeline API

2025-09-26 Thread Sebastian Wick
On Mon, Sep 15, 2025, at 2:31 PM, Daniel Stone wrote: > Hi Nícolas, > > On Wed, 3 Sept 2025 at 19:43, Nícolas F. R. A. Prado > wrote: > > On Tue, 2025-08-26 at 13:25 +0100, Daniel Stone wrote: > > Based on this discussion, this is my understanding for the changes > > desired on the series and t

Re: [PATCH v2 0/2] Add "pixel_encoding" to switch between RGB & YUV color modes

2025-09-01 Thread Sebastian Wick
On Wed Aug 27, 2025 at 1:08 PM CEST, Sebastian Wick wrote: > On Wed Aug 27, 2025 at 12:39 PM CEST, Daniel Stone wrote: >> Hey, >> >> On Wed, 27 Aug 2025 at 10:41, Maxime Ripard wrote: >>> On Wed, Aug 27, 2025 at 12:26:56AM +0800, Shengyu Qu wrote: >>> >

Re: [PATCH RFC 1/5] drm: Support post-blend color pipeline API

2025-08-27 Thread Sebastian Wick
On Fri Aug 22, 2025 at 8:36 PM CEST, Nícolas F. R. A. Prado wrote: > Introduce support for a post-blend color pipeline API analogous to the > pre-blend color pipeline API. While the pre-blend color pipeline was > configured through a COLOR_PIPELINE property attached to a drm_plane, > the post-blend

Re: [PATCH v2 0/2] Add "pixel_encoding" to switch between RGB & YUV color modes

2025-08-27 Thread Sebastian Wick
On Wed Aug 27, 2025 at 12:39 PM CEST, Daniel Stone wrote: > Hey, > > On Wed, 27 Aug 2025 at 10:41, Maxime Ripard wrote: >> On Wed, Aug 27, 2025 at 12:26:56AM +0800, Shengyu Qu wrote: >> > 1.Can you send patch with only i915/amdgpu first? It's a long-needed >> > feature >> > to deal with some moni

Re: [PATCH V11 00/47] Color Pipeline API w/ VKMS

2025-08-21 Thread Sebastian Wick
With the small improvements, the core drm parts are Reviewed-by: Sebastian Wick On Fri Aug 15, 2025 at 5:49 AM CEST, Alex Hung wrote: > This is an RFC set for a color pipeline API, along with implementations > in VKMS and amdgpu. It is tested with a set of IGT tests that can be > fo

Re: [PATCH V11 35/47] drm/colorop: Add 1D Curve Custom LUT type

2025-08-21 Thread Sebastian Wick
On Wed Aug 20, 2025 at 8:16 PM CEST, Alex Hung wrote: > > > On 8/19/25 09:31, Sebastian Wick wrote: >>> +/** >>> + * drm_plane_colorop_curve_1d_lut_init - Initialize a DRM_COLOROP_1D_LUT >>> + * >>> + * @dev: DRM device >>> + * @colorop: Th

Re: [PATCH V11 35/47] drm/colorop: Add 1D Curve Custom LUT type

2025-08-19 Thread Sebastian Wick
On Fri Aug 15, 2025 at 5:50 AM CEST, Alex Hung wrote: > We've previously introduced DRM_COLOROP_1D_CURVE for > pre-defined 1D curves. But we also have HW that supports > custom curves and userspace needs the ability to pass > custom curves, aka LUTs. > > This patch introduces a new colorop type, ca

Re: [PATCH V11 07/47] drm/colorop: Add BYPASS property

2025-08-19 Thread Sebastian Wick
On Fri Aug 15, 2025 at 5:49 AM CEST, Alex Hung wrote: > From: Harry Wentland > > We want to be able to bypass each colorop at all times. > Introduce a new BYPASS boolean property for this. > > Reviewed-by: Simon Ser > Reviewed-by: Louis Chauvet > Signed-off-by: Alex Hung > Signed-off-by: Harry

Re: [PATCH V11 06/47] drm/colorop: Add 1D Curve subtype

2025-08-19 Thread Sebastian Wick
On Fri Aug 15, 2025 at 5:49 AM CEST, Alex Hung wrote: > From: Harry Wentland > > Add a new drm_colorop with DRM_COLOROP_1D_CURVE with two subtypes: > DRM_COLOROP_1D_CURVE_SRGB_EOTF and DRM_COLOROP_1D_CURVE_SRGB_INV_EOTF. > > Reviewed-by: Simon Ser > Reviewed-by: Louis Chauvet > Signed-off-by: Ha

[PATCH 2/2] Revert "drm/amd/display: add panel_power_savings sysfs entry to eDP connectors"

2024-08-06 Thread Sebastian Wick
From: Sebastian Wick This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5. The panel_power_savings sysfs entry can be used to change the displayed colorimetry which breaks color managed setups. The "do not break userspace" rule which was violated here is enough reason to r

[PATCH 1/2] Revert "drm/amd/display: Don't register panel_power_savings on OLED panels"

2024-08-06 Thread Sebastian Wick
From: Sebastian Wick This reverts commit 76cb763e6ea62e838ccc8f7a1ea4246d690fccc9. Reverting the panel_power_savings sysfs. See next commit. Signed-off-by: Sebastian Wick --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +++ 1 file changed, 4 insertions(+), 25 deletions

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
On Fri, Aug 2, 2024 at 4:37 PM Harry Wentland wrote: > > On 2024-08-02 09:28, Sebastian Wick wrote: > > I'm very unhappy about how this has played out. > > > > We have a new sysfs property that controls a feature of the display > > path that has been set to a

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
I'm very unhappy about how this has played out. We have a new sysfs property that controls a feature of the display path that has been set to a default(!) which changes the color behavior! This broke color management for everyone who is on a device which supports this feature. What should have be

[PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-07-02 Thread Sebastian Wick
rt * Make it clear that drivers can choose between RGB and YCbCr on their own Signed-off-by: Sebastian Wick Reviewed-by: Pekka Paalanen --- drivers/gpu/drm/drm_connector.c | 79 + include/drm/drm_connector.h | 8 2 files changed, 61 insertions(+), 26

[PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-04-10 Thread Sebastian Wick
When extending support for a driver-specific KMS property to additional drivers, we should apply all the requirements for new properties and make sure the semantics are the same and documented. v2: devs of the driver which introduced property shall help and ack Signed-off-by: Sebastian Wick

Re: [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-11 Thread Sebastian Wick
On Thu, Mar 07, 2024 at 10:29:22AM +0200, Pekka Paalanen wrote: > On Wed, 6 Mar 2024 17:42:09 +0100 > Sebastian Wick wrote: > > > On Wed, Mar 06, 2024 at 10:27:21AM +0200, Pekka Paalanen wrote: > > > On Tue, 5 Mar 2024 14:51:49 +0100 > > > Sebastian Wick wr

[PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-11 Thread Sebastian Wick
When extending support for a driver-specific KMS property to additional drivers, we should apply all the requirements for new properties and make sure the semantics are the same and documented. v2: devs of the driver which introduced property shall help and ack Signed-off-by: Sebastian Wick

Re: [PATCH] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-06 Thread Sebastian Wick
On Wed, Mar 06, 2024 at 03:14:15PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Feb 29, 2024 at 09:28:31PM +0100, Sebastian Wick wrote: > > When extending support for a driver-specific KMS property to additional > > drivers, we should apply all the requirements for new pr

Re: [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-06 Thread Sebastian Wick
On Wed, Mar 06, 2024 at 10:27:21AM +0200, Pekka Paalanen wrote: > On Tue, 5 Mar 2024 14:51:49 +0100 > Sebastian Wick wrote: > > > The initial idea of the Colorspace prop was that this maps 1:1 to > > InfoFrames/SDP but KMS does not give user space enough information nor

[PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-05 Thread Sebastian Wick
rt * Make it clear that drivers can choose between RGB and YCbCr on their own Signed-off-by: Sebastian Wick --- drivers/gpu/drm/drm_connector.c | 79 + include/drm/drm_connector.h | 8 2 files changed, 61 insertions(+), 26 deletions(-) diff --git a/d

[PATCH] drm/drm_connector: Document Colorspace property variants

2024-03-04 Thread Sebastian Wick
usable from user space and consistent with other KMS properties for those variants is left as an exercise for whoever wants to use them. Signed-off-by: Sebastian Wick --- drivers/gpu/drm/drm_connector.c | 67 - include/drm/drm_connector.h | 8 2 files changed

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-03-01 Thread Sebastian Wick
On Fri, Mar 01, 2024 at 01:12:02PM +0100, Maxime Ripard wrote: > On Fri, Mar 01, 2024 at 12:29:41PM +0100, Sebastian Wick wrote: > > On Fri, Mar 01, 2024 at 11:30:56AM +0100, Maxime Ripard wrote: > > > On Thu, Feb 29, 2024 at 08:47:26PM +0100, Sebastian Wick wrote: > > &

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-03-01 Thread Sebastian Wick
On Fri, Mar 01, 2024 at 11:30:56AM +0100, Maxime Ripard wrote: > On Thu, Feb 29, 2024 at 08:47:26PM +0100, Sebastian Wick wrote: > > > @@ -1708,6 +1731,39 @@ > > > EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property); > > > /** > >

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-03-01 Thread Sebastian Wick
On Fri, Mar 01, 2024 at 09:29:17AM +0100, Hans Verkuil wrote: > On 29/02/2024 20:47, Sebastian Wick wrote: > > On Thu, Feb 22, 2024 at 07:14:07PM +0100, Maxime Ripard wrote: > >> The i915 driver has a property to force the RGB range of an HDMI output. > >> The vc4 drive

Colorspace "Default" and the CTA-861 spec

2024-02-29 Thread Sebastian Wick
Hey all, I was trying to document the Colorspace property variants with what the sink expects, what kind of data the CRTC should be configured to produce, and what drivers must guarantee. I tried to stick to CTA-861-I for this exercise and after more than an hour to get the "Default" variant right

[PATCH] drm: Document requirements for driver-specific KMS props in new drivers

2024-02-29 Thread Sebastian Wick
When extending support for a driver-specific KMS property to additional drivers, we should apply all the requirements for new properties and make sure the semantics are the same and documented. Signed-off-by: Sebastian Wick --- Documentation/gpu/drm-kms.rst | 5 + 1 file changed, 5

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-02-29 Thread Sebastian Wick
NULL; > + > + return broadcast_rgb_names[broadcast_rgb].name; > +} > +EXPORT_SYMBOL(drm_hdmi_connector_get_broadcast_rgb_name); > + > static const char * const output_format_str[] = { > [HDMI_COLORSPACE_RGB] = "RGB", > [HD

Re: [PATCH v2 0/7] Add YUV formats to VKMS

2024-02-29 Thread Sebastian Wick
On Wed, Feb 28, 2024 at 08:42:41PM -0300, Arthur Grillo wrote: > > > On 15/01/24 12:06, Sebastian Wick wrote: > > On Wed, Jan 10, 2024 at 02:44:00PM -0300, Arthur Grillo wrote: > >> This patchset aims to add support for additional buffer YUV formats. > >> More

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-02-27 Thread Sebastian Wick
he list is "in order of preference" > Add a a link to the mutter MR > > Cc: Simon Ser > Cc: Jonas Ådahl > Cc: Daniel Stone > Cc: Sameer Lattannavar > Cc: Sebastian Wick > Acked-by: Harry Wentland > Acked-by: Pekka Paalanen > Signed-of

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-22 Thread Sebastian Wick
On Thu, Feb 22, 2024 at 02:58:45PM +0200, Ville Syrjälä wrote: > On Thu, Feb 22, 2024 at 11:54:04AM +0100, Maxime Ripard wrote: > > On Mon, Feb 19, 2024 at 03:01:44PM +0100, Sebastian Wick wrote: > > > On Thu, Feb 15, 2024 at 12:00:01PM +0100, Maxime Ripard wrote: > > >

Re: Re: Re: Re: Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-19 Thread Sebastian Wick
On Thu, Feb 15, 2024 at 12:00:01PM +0100, Maxime Ripard wrote: > On Mon, Feb 12, 2024 at 06:06:18PM +0100, Sebastian Wick wrote: > > On Mon, Feb 12, 2024 at 05:53:48PM +0100, Maxime Ripard wrote: > > > On Mon, Feb 12, 2024 at 05:49:33PM +0200, Ville Syrjälä wrote: > > >

Re: [PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-19 Thread Sebastian Wick
On Tue, Feb 13, 2024 at 11:26:44AM +0200, Ville Syrjälä wrote: > On Mon, Feb 12, 2024 at 05:50:36PM +0100, Sebastian Wick wrote: > > On Mon, Feb 12, 2024 at 11:10:15AM +0200, Pekka Paalanen wrote: > > > On Fri, 9 Feb 2024 17:53:07 +0100 > > > Xaver Hugl wrote: > >

Re: [PATCH 09/28] drm: Add Color ops capability property

2024-02-13 Thread Sebastian Wick
On Tue, Feb 13, 2024 at 12:18:16PM +0530, Uma Shankar wrote: > Add capability property which a colorop can expose it's > hardware's abilities. It's a blob property that can be > filled with respective data structures depending on the > colorop. The user space is expected to read this property > and

Re: [PATCH 08/28] drm: Add Color lut range attributes

2024-02-13 Thread Sebastian Wick
On Tue, Feb 13, 2024 at 12:18:15PM +0530, Uma Shankar wrote: > This defines a new structure to define color lut ranges, > along with related macro definitions and enums. This will help > describe segmented lut ranges/PWL LUTs in the hardware. > > Signed-off-by: Uma Shankar > Signed-off-by: Chaita

Re: Re: Re: Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-12 Thread Sebastian Wick
On Mon, Feb 12, 2024 at 05:53:48PM +0100, Maxime Ripard wrote: > On Mon, Feb 12, 2024 at 05:49:33PM +0200, Ville Syrjälä wrote: > > On Mon, Feb 12, 2024 at 11:01:07AM +0100, Maxime Ripard wrote: > > > On Fri, Feb 09, 2024 at 09:34:35PM +0100, Sebastian Wick wrote: > > >

Re: [PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-12 Thread Sebastian Wick
On Mon, Feb 12, 2024 at 11:10:15AM +0200, Pekka Paalanen wrote: > On Fri, 9 Feb 2024 17:53:07 +0100 > Xaver Hugl wrote: > > > Signed-off-by: Xaver Hugl > > --- > > drivers/gpu/drm/drm_connector.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_connec

Re: [PATCH] drm: document userspace expectations around the Colorspace connector property

2024-02-09 Thread Sebastian Wick
the property. > + * > * Basically the expectation from userspace is: > * - Set up CRTC DEGAMMA/CTM/GAMMA to convert to some sink > *colorspace > -- > 2.43.0 > Thank you! Reviewed-by: Sebastian Wick

Re: Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-09 Thread Sebastian Wick
gt; On Fri, Feb 02, 2024 at 02:01:39PM +0100, Maxime Ripard wrote: > > > > > Hi, > > > > > > > > > > On Mon, Jan 15, 2024 at 03:37:20PM +0100, Sebastian Wick wrote: > > > > > > > > /** > > > > > > > > *

Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-09 Thread Sebastian Wick
On Fri, Feb 02, 2024 at 04:49:04PM +0100, Maxime Ripard wrote: > Hi Sebastian, > > On Mon, Jan 15, 2024 at 03:33:08PM +0100, Sebastian Wick wrote: > > > /** > > > * DOC: HDMI connector properties > > > * > > > + * Broadcast RGB > > >

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-18 Thread Sebastian Wick
On Wed, Jan 17, 2024 at 12:58:15PM +, Andri Yngvason wrote: > mið., 17. jan. 2024 kl. 09:21 skrifaði Pekka Paalanen : > > > > On Tue, 16 Jan 2024 14:11:43 + > > Andri Yngvason wrote: > > > > > þri., 16. jan. 2024 kl. 13:29 skrifaði Sebastian Wick &g

Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-01-18 Thread Sebastian Wick
On Mon, Jan 15, 2024 at 04:25:41PM +0100, Maxime Ripard wrote: > On Mon, Jan 15, 2024 at 03:33:08PM +0100, Sebastian Wick wrote: > > On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: > > > The i915 driver has a property to force the RGB range of an HDMI output. &g

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-16 Thread Sebastian Wick
On Tue, Jan 16, 2024 at 01:13:13PM +, Andri Yngvason wrote: > Hi Sebastian, > > þri., 16. jan. 2024 kl. 11:42 skrifaði Sebastian Wick > : > > > > On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > > > From: Werner Sembach > > > > &g

Re: [PATCH v2 2/4] drm/uAPI: Add "force color format" drm property as setting for userspace

2024-01-16 Thread Sebastian Wick
On Mon, Jan 15, 2024 at 04:05:52PM +, Andri Yngvason wrote: > From: Werner Sembach > > Add a new general drm property "force color format" which can be used > by userspace to tell the graphics driver which color format to use. I don't like the "force" in the name. This just selects the color

Re: [PATCH v2 0/7] Add YUV formats to VKMS

2024-01-15 Thread Sebastian Wick
On Wed, Jan 10, 2024 at 02:44:00PM -0300, Arthur Grillo wrote: > This patchset aims to add support for additional buffer YUV formats. > More specifically, it adds support to: > > Semi-planar formats: > > - NV12 > - NV16 > - NV24 > - NV21 > - NV61 > - NV42 > > Planar formats: > > - YUV440 > - YU

Re: [PATCH 2/7] drm/uAPI: Add "active color format" drm property as feedback for userspace

2024-01-15 Thread Sebastian Wick
On Thu, Jan 11, 2024 at 05:17:46PM +, Andri Yngvason wrote: > mið., 10. jan. 2024 kl. 13:26 skrifaði Daniel Stone : > > > > > > This thing here works entirely differently, and I think we need somewhat > > > new semantics for this: > > > > > > - I agree it should be read-only for userspace, so i

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-01-15 Thread Sebastian Wick
On Mon, Jan 15, 2024 at 03:33:08PM +0100, Sebastian Wick wrote: > On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: > > The i915 driver has a property to force the RGB range of an HDMI output. > > The vc4 driver then implemented the same property with the same > >

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-01-15 Thread Sebastian Wick
On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: > The i915 driver has a property to force the RGB range of an HDMI output. > The vc4 driver then implemented the same property with the same > semantics. KWin has support for it, and a PR for mutter is also there to > support it. > > B

Re: [RFC PATCH 2/2] vc4: introduce DMA-BUF heap

2023-11-10 Thread Sebastian Wick
On Thu, Nov 09, 2023 at 06:38:20PM +, Dave Stevenson wrote: > Hi Simon > > On Thu, 9 Nov 2023 at 17:46, Simon Ser wrote: > > > > On Thursday, November 9th, 2023 at 16:42, Dave Stevenson > > wrote: > > > > > > > - What would be a good name for the heap? "vc4" is maybe a bit naive > > > > >

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-11-08 Thread Sebastian Wick
On Wed, Nov 8, 2023 at 11:16 AM Pekka Paalanen wrote: > > On Tue, 7 Nov 2023 11:58:26 -0500 > Harry Wentland wrote: > > > On 2023-11-07 04:55, Pekka Paalanen wrote: > > > On Mon, 6 Nov 2023 11:19:27 -0500 > > > Harry Wentland wrote: > > > > > >> On 2023-10-20 06:36, Pekka Paalanen wrote: > > >>>

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-11-07 Thread Sebastian Wick
On Tue, Nov 07, 2023 at 11:52:11AM -0500, Harry Wentland wrote: > > > On 2023-10-26 13:30, Sebastian Wick wrote: > > On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: > >> On Wed, 25 Oct 2023 15:16:08 -0500 (CDT) > >> Alex Goins wrote: > &g

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Sebastian Wick
On Fri, Oct 27, 2023 at 10:59:25AM +0200, Michel Dänzer wrote: > On 10/26/23 21:25, Alex Goins wrote: > > On Thu, 26 Oct 2023, Sebastian Wick wrote: > >> On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: > >>> On Wed, 25 Oct 2023 15:16:08 -0500

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-26 Thread Sebastian Wick
anen wrote: > > > > > On Fri, 20 Oct 2023 11:23:28 -0400 > > > Harry Wentland wrote: > > > > > > > On 2023-10-20 10:57, Pekka Paalanen wrote: > > > > > On Fri, 20 Oct 2023 16:22:56 +0200 > > > > > Sebastian Wick wrote:

Re: [PATCH v3 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-10-23 Thread Sebastian Wick
Honestly, the less time people spend on this property the better. Lift the Intel one into core and be done with it. We'll hopefully be able to remove it in the not-to-distant future with the new color pipeline API and adding a new property which only sets the connector metadata instead of influenci

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-20 Thread Sebastian Wick
patibility" section (Sebastian, Pekka) > > Signed-off-by: Harry Wentland > Cc: Ville Syrjala > Cc: Pekka Paalanen > Cc: Simon Ser > Cc: Harry Wentland > Cc: Melissa Wen > Cc: Jonas Ådahl > Cc: Sebastian Wick > Cc: Shashank Sharma > Cc: Alexander

Re: [PATCH RFC v6 01/10] drm: Introduce pixel_source DRM plane property

2023-10-19 Thread Sebastian Wick
: > > + * No active pixel source. > > + * Committing with a NONE pixel source will disable the plane. > > + * > > + * "FB": > > + * Framebuffer source set by the "FB_ID" property. > > + * > > * Note that all the property extensions described here apply either to the > > * plane or the CRTC (e.g. for the background color, which currently is not > > * exposed and assumed to be black). > > This UAPI: > Acked-by: Pekka Paalanen Thanks Jessica, same for me Acked-by: Sebastian Wick > > > Thanks, > pq

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-11 Thread Sebastian Wick
> Cc: Simon Ser > > > Cc: Harry Wentland > > > Cc: Melissa Wen > > > Cc: Jonas Ådahl > > > Cc: Sebastian Wick > > > Cc: Shashank Sharma > > > Cc: Alexander Goins > > > Cc: Joshua Ashton > > > Cc: Michel Dänzer >

Re: [PATCH v4 00/32] drm/amd/display: add AMD driver-specific properties for color mgmt

2023-10-06 Thread Sebastian Wick
On Thu, Oct 05, 2023 at 04:14:55PM -0100, Melissa Wen wrote: > Hello, > > Just another iteration for AMD driver-specific color properties. > Basically, addressing comments from the previous version. > > Recap: this series extends the current KMS color management API with AMD > driver-specific pro

Re: [PATCH v4 09/32] drm/amd/display: add plane 3D LUT driver-specific properties

2023-10-06 Thread Sebastian Wick
On Thu, Oct 05, 2023 at 04:15:04PM -0100, Melissa Wen wrote: > Add 3D LUT property for plane color transformations using a 3D lookup > table. 3D LUT allows for highly accurate and complex color > transformations and is suitable to adjust the balance between color > channels. It's also more complex

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-09-08 Thread Sebastian Wick
gt; Cc: Simon Ser > Cc: Harry Wentland > Cc: Melissa Wen > Cc: Jonas Ådahl > Cc: Sebastian Wick > Cc: Shashank Sharma > Cc: Alexander Goins > Cc: Joshua Ashton > Cc: Michel Dänzer > Cc: Aleix Pol > Cc: Xaver Hugl > Cc: Victoria Brekenfeld > Cc: Danie

Re: [RFC 00/33] Add Support for Plane Color Pipeline

2023-09-05 Thread Sebastian Wick
On Tue, Sep 05, 2023 at 02:33:04PM +0200, Sebastian Wick wrote: > On Tue, Sep 05, 2023 at 02:33:26PM +0300, Pekka Paalanen wrote: > > On Mon, 4 Sep 2023 14:29:56 + > > "Shankar, Uma" wrote: > > > > > > -Original Message- > > > >

Re: [RFC 00/33] Add Support for Plane Color Pipeline

2023-09-05 Thread Sebastian Wick
On Tue, Sep 05, 2023 at 02:33:26PM +0300, Pekka Paalanen wrote: > On Mon, 4 Sep 2023 14:29:56 + > "Shankar, Uma" wrote: > > > > -Original Message- > > > From: Sebastian Wick > > > Sent: Thursday, August 31, 2023 2:46 AM > >

Re: [RFC 00/33] Add Support for Plane Color Pipeline

2023-08-30 Thread Sebastian Wick
.@lists.freedesktop.org > > Cc: wayland-de...@lists.freedesktop.org; Ville Syrjala > > ; Pekka Paalanen > > ; > > Simon Ser ; Melissa Wen ; Jonas Ådahl > > ; Sebastian Wick ; Shashank > > Sharma ; Alexander Goins ; > > Naseer Ahmed ; Christopher Braga > > >

Re: [PATCH RFC v6 00/10] Support for Solid Fill Planes

2023-08-29 Thread Sebastian Wick
color information would have unecessary overhead that > does not reflect the behavior of the solid fill feature. In addition, > assigning the solid fill blob to FB_ID would require loosening some core > drm_property checks that might cause unwanted side effects elsewhere. The cover lette

Re: [PATCH RFC v6 02/10] drm: Introduce solid fill DRM plane property

2023-08-29 Thread Sebastian Wick
On Mon, Aug 28, 2023 at 05:05:08PM -0700, Jessica Zhang wrote: > Document and add support for solid_fill property to drm_plane. In > addition, add support for setting and getting the values for solid_fill. > > To enable solid fill planes, userspace must assign a property blob to > the "solid_fill"

Re: [PATCH v7] drm/doc: Document DRM device reset expectations

2023-08-22 Thread Sebastian Wick
EVICE_LOST`` for submissions. > +This error code means, among other things, that a device reset has happened > and > +it needs to recreate the contexts to keep going. > + > +Reporting causes of resets > +-- > + > +Apart from propagating the

Re: [PATCH v6 5/6] drm: Refuse to async flip with atomic prop changes

2023-08-22 Thread Sebastian Wick
On Tue, Aug 15, 2023 at 03:57:09PM -0300, André Almeida wrote: > Given that prop changes may lead to modesetting, which would defeat the > fast path of the async flip, refuse any atomic prop change for async > flips in atomic API. The only exceptions are the framebuffer ID to flip > to and the mode

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-08 Thread Sebastian Wick
On Fri, Aug 4, 2023 at 3:03 PM Daniel Vetter wrote: > > On Tue, Jun 27, 2023 at 10:23:23AM -0300, André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > > kernel and userspace drivers. > > > > Acked-by: Pekka Paalanen > > Signed-off-by: André Almeida >

Re: [PATCH RFC v5 01/10] drm: Introduce pixel_source DRM plane property

2023-08-08 Thread Sebastian Wick
On Mon, Aug 7, 2023 at 7:52 PM Jessica Zhang wrote: > > > > On 8/4/2023 6:15 AM, Sebastian Wick wrote: > > On Fri, Jul 28, 2023 at 7:03 PM Jessica Zhang > > wrote: > >> > >> Add support for pixel_source property to drm_plane and related > >>

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-04 Thread Sebastian Wick
On Fri, Aug 4, 2023 at 3:27 PM Dmitry Baryshkov wrote: > > On Fri, 28 Jul 2023 at 20:03, Jessica Zhang wrote: > > > > Document and add support for solid_fill property to drm_plane. In > > addition, add support for setting and getting the values for solid_fill. > > > > To enable solid fill planes,

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-04 Thread Sebastian Wick
On Mon, Jul 31, 2023 at 6:01 AM Dmitry Baryshkov wrote: > > On 28/07/2023 20:02, Jessica Zhang wrote: > > Document and add support for solid_fill property to drm_plane. In > > addition, add support for setting and getting the values for solid_fill. > > > > To enable solid fill planes, userspace mu

Re: [PATCH RFC v5 01/10] drm: Introduce pixel_source DRM plane property

2023-08-04 Thread Sebastian Wick
On Fri, Jul 28, 2023 at 7:03 PM Jessica Zhang wrote: > > Add support for pixel_source property to drm_plane and related > documentation. In addition, force pixel_source to > DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break > legacy userspace. > > This enum property will allow u

Re: [PATCH] drm/vkms: avoid race-condition between flushing and destroying

2023-08-03 Thread Sebastian Wick
On Sun, Jul 30, 2023 at 12:51 AM Maíra Canal wrote: > > After we flush the workqueue at the commit tale, we need to make sure > that no work is queued until we destroy the state. Currently, new work > can be queued in the workqueue, even after the commit tale, as the > vblank thread is still runni

Re: [PATCH v2 0/2] doc: uapi: Document dma-buf interop design & semantics

2023-08-03 Thread Sebastian Wick
For what it's worth this series is Reviewed-by: Sebastian Wick On Thu, Aug 3, 2023 at 5:49 PM Daniel Stone wrote: > > Hi all, > This is v2 to the linked patch series; thanks to everyone for reviewing > the initial version. I've moved this out of a pure DRM scope

Re: [PATCH v4 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

2023-07-04 Thread Sebastian Wick
On Sat, Jul 1, 2023 at 4:09 AM André Almeida wrote: > > From: Simon Ser > > If the driver supports it, allow user-space to supply the > DRM_MODE_PAGE_FLIP_ASYNC flag to request an async page-flip. > Set drm_crtc_state.async_flip accordingly. > > Document that drivers will reject atomic commits if

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-07-03 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 11:27 PM Jessica Zhang wrote: > > > > On 6/30/2023 7:43 AM, Sebastian Wick wrote: > > On Fri, Jun 30, 2023 at 2:26 AM Jessica Zhang > > wrote: > >> > >> Add support for pixel_source property to drm_plane and related > >&g

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 4:59 PM Alex Deucher wrote: > > On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick > wrote: > > > > On Tue, Jun 27, 2023 at 3:23 PM André Almeida > > wrote: > > > > > > Create a section that specifies how to deal with DRM

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: > https://lore.kernel.org/lkml/20230626183347.55118-1-andreal

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-06-30 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 2:26 AM Jessica Zhang wrote: > > Add support for pixel_source property to drm_plane and related > documentation. > > This enum property will allow user to specify a pixel source for the > plane. Possible pixel sources will be defined in the > drm_plane_pixel_source enum. >

Re: [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-06-21 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:21 PM Aravind Iddamsetty wrote: > > Our hardware supports RAS(Reliability, Availability, Serviceability) by > exposing a set of error counters which can be used by observability > tools to take corrective actions or repairs. Traditionally there were > being exposed via PM

Re: [PATCH 06/36] drm/amd/display: add CRTC driver-specific property for gamma TF

2023-06-06 Thread Sebastian Wick
On Tue, Jun 6, 2023 at 6:19 PM Joshua Ashton wrote: > > > > On 6/1/23 20:17, Harry Wentland wrote: > > > > > > On 5/23/23 18:14, Melissa Wen wrote: > >> Hook up driver-specific atomic operations for managing AMD color > >> properties and create AMD driver-specific color management properties > >>

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
With the documentation about RGB and YCC variants added the drm core patches are Reviewed-by: Sebastian Wick On Fri, May 26, 2023 at 6:24 PM Sebastian Wick wrote: > > On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > > > On Thu, 25 May 2023 15:17:56 -0400 > &g

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:37 PM Simon Ser wrote: > > On Friday, May 26th, 2023 at 18:27, Sebastian Wick > wrote: > > > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > > + * Driver specific behavior. > > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > > + * Dri

Re: [PATCH v4 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-05-26 Thread Sebastian Wick
o support with e.g. the appropriate YCC transform when necessary, independent of the sink support. > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: Simon Ser > Cc: Ville Syrjälä > Cc: Melissa Wen

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
CYCC is "constant luminance" > - correct type for BT.601 > > v4: > - drop DP/HDMI clarifications that might create > more questions than answers > > Signed-off-by: Joshua Ashton > Signed-off-by: Harry Wentland > Reviewed-by: Harry Wentland > > Cc: Pekka

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > On Thu, 25 May 2023 15:17:56 -0400 > Harry Wentland wrote: > > > This patchset is based on Joshua's previous patchset [1], as well > > as my previous patchset [2]. > > > > It is > > - enabling support for the colorspace property in amdgpu,

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Sebastian Wick
On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > > On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > > > Hi all, > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > > pipeline before blending, ie. after a pixel is tapped from a plane's > > framebuffer and bef

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Sebastian Wick
On Fri, May 5, 2023 at 5:28 PM Daniel Vetter wrote: > > On Thu, May 04, 2023 at 03:22:59PM +, Simon Ser wrote: > > Hi all, > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > > pipeline before blending, ie. after a pixel is tapped from a plane's > > framebuffe

Re: [PATCH v2 00/21] Enable Colorspace connector property in amdgpu

2023-03-21 Thread Sebastian Wick
e the colorspace property > directly to the infoframe and reduce the options to sRGB, BT709, > BT601, and BT2020 (and possibly opRGB). > > v2: > - Tested with DP and HDMI analyzers > - Confirmed driver will fallback to lower bpc when needed > - Dropped hunk to set HDMI AVI infof

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Sebastian Wick
On Fri, Mar 17, 2023 at 7:38 PM Ville Syrjälä wrote: > > On Fri, Mar 17, 2023 at 06:40:53PM +0100, Sebastian Wick wrote: > > On Fri, Mar 17, 2023 at 5:34 PM Ville Syrjälä > > wrote: > > > > > > On Fri, Mar 17, 2023 at 05:37:51PM +0200, Pekka Paalanen wrote:

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Sebastian Wick
; > > > On Fri, 17 Mar 2023 14:50:40 +0200 > > > > Ville Syrjälä wrote: > > > > > > > > > On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote: > > > > > > On Fri, 17 Mar 2023 01:01:38 +0200 > > > >

Re: [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-17 Thread Sebastian Wick
On Thu, Mar 16, 2023 at 11:59 PM Rob Clark wrote: > > On Thu, Mar 16, 2023 at 3:22 PM Sebastian Wick > wrote: > > > > On Thu, Mar 16, 2023 at 5:29 PM Rob Clark wrote: > > > > > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > &g

Re: [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-16 Thread Sebastian Wick
On Thu, Mar 16, 2023 at 5:29 PM Rob Clark wrote: > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote: > > > On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl wrote: > > > > > > > > On Fri, Mar 10, 2023 at 09:38:18AM -0800, Rob Clark

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-16 Thread Sebastian Wick
; > > > On Thu, 16 Mar 2023 11:50:27 +0200 > > > > Ville Syrjälä wrote: > > > > > > > > > On Thu, Mar 16, 2023 at 01:37:24AM +0100, Sebastian Wick wrote: > > > > > > On Tue, Mar 7, 2023 at 4:12 PM Harry Wentland > > > >

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-15 Thread Sebastian Wick
sed by the driver. Not great at all. Something to remember for the new property. > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freede

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-09 Thread Sebastian Wick
On Thu, Mar 9, 2023 at 11:03 AM Pekka Paalanen wrote: > > On Thu, 9 Mar 2023 01:56:11 +0100 > Sebastian Wick wrote: > > > On Wed, Mar 8, 2023 at 9:59 AM Pekka Paalanen wrote: > > > > > > On Tue, 7 Mar 2023 10:10:52 -0500 > > > Harry Wentl

Re: [PATCH v3 14/17] drm/amd/display: Add debugfs for testing output colorspace

2023-03-08 Thread Sebastian Wick
ndy when debugging display > issues. > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freedesktop.org > Reviewed-By: Joshua Ashton

Re: [PATCH v3 11/17] drm/amd/display: Send correct DP colorspace infopacket

2023-03-08 Thread Sebastian Wick
d > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freedesktop.org > Reviewed-By: Joshua Ashton > --- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 +++--

Re: [PATCH v3 05/17] drm/connector: Use common colorspace_names array

2023-03-08 Thread Sebastian Wick
arry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Uma Shankar > Cc: Ville Syrjälä > Cc: Joshua Ashton > Cc: Jani Nikula > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freedeskt

Re: [PATCH v3 03/17] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-03-08 Thread Sebastian Wick
20 colorspace entry > > that userspace can use. > > > > v2: > > - leave CYCC alone for now; it serves a purpose > > - leave BT2020_RGB the new default BT2020 > > > > Signed-off-by: Joshua Ashton > > Signed-off-by: Harry Wentland > > Reviewed

  1   2   >