Re: [PATCH v2 4/4] arm64: dts: rockchip: Enable HDMI1 on rock-5b

2025-03-31 Thread Sebastian Reichel
Hi, On Mon, Mar 31, 2025 at 08:01:34PM +0100, Mark Brown wrote: > On Wed, Dec 11, 2024 at 01:06:17AM +0200, Cristian Ciocaltea wrote: > > Add the necessary DT changes to enable the second HDMI output port on > > Radxa ROCK 5B. > > > > While at it, switch the position of &vop_mmu and @vop to maint

Re: [PATCH] drm/rockchip: dw_hdmi_qp: Fix io init for dw_hdmi_qp_rockchip_resume

2025-03-17 Thread Sebastian Reichel
588_GRF_VO1_CON9, val); > + cfg = of_device_get_match_data(dev); > + cfg->ctrl_ops->io_init(hdmi); I think it would be better to store the ctrl_ops (or io_init) callback in struct rockchip_hdmi_qp during driver probe and avoid another lookup of the match_data, which involves string comparisons. Otherwise: Reviewed-by: Sebastian Reichel Greetings, -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 6/9] power: supply: pcf50633: Remove charger

2025-03-12 Thread Sebastian Reichel
.org/all/Z8z236h4B5A6Ki3D@gallifrey/ > > Remove it. > > [...] Applied, thanks! [6/9] power: supply: pcf50633: Remove charger commit: aae075a93f7705e29c599d101abc7e467125d871 Best regards, -- Sebastian Reichel

Re: [PATCH] drm/rockchip: vop2: add missing bitfield.h include

2025-03-03 Thread Sebastian Reichel
e used > FIELD_PREP macro. Add this missing include. > > Fixes: 328e6885996c ("drm/rockchip: vop2: Add platform specific callback") > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202503040135.fgoywdlb-...@intel.com/ > Signed-off

Re: [PATCH RFC] backlight: pwm_bl: Read back PWM period from provider

2025-02-26 Thread Sebastian Reichel
Hi, On Wed, Feb 26, 2025 at 05:34:50PM +0100, Uwe Kleine-König wrote: > On Wed, Feb 26, 2025 at 05:31:08PM +0200, Abel Vesa wrote: > > The current implementation assumes that the PWM provider will be able to > > meet the requested period, but that is not always the case. Some PWM > > providers hav

[PATCH v3 1/2] dt-bindings: display: panel: Add Raydium RM67200

2025-02-25 Thread Sebastian Reichel
The Rockchip W552793DBA-V10 display/touchscreen board contains a Wanchanglong W552793BAA panel, which in turn is using a Raydium RM67200 MIPI-DSI controller. Add a DT binding for the DSI panel. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- .../bindings/display/panel

[PATCH v3 2/2] drm/panel: add Raydium RM67200 panel driver

2025-02-25 Thread Sebastian Reichel
-by: Jessica Zhang Reviewed-by: Andy Yan Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67200.c | 499 ++ 3 files changed, 510

[PATCH v3 0/2] Rockchip W552793DBA-V10 panel support

2025-02-25 Thread Sebastian Reichel
. Greetings, -- Sebastian --- Sebastian Reichel (2): dt-bindings: display: panel: Add Raydium RM67200 drm/panel: add Raydium RM67200 panel driver .../bindings/display/panel/raydium,rm67200.yaml| 72 +++ drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel

Re: [PATCH v2 0/2] Rockchip W552793DBA-V10 panel support

2025-02-24 Thread Sebastian Reichel
Hi, On Fri, Feb 07, 2025 at 05:21:46PM +0100, Sebastian Reichel wrote: > This has been tested in combination with the series from Heiko Stübner > enabling DSI support for the RK3588 [0] (DSI controller support has been > merged already, only the PHY support is missing) on the RK3588 EVB1

Re: [PATCH 3/4] arm64: dts: rockchip: Add HDMI1 PHY PLL clock source to VOP2 on RK3588

2025-02-18 Thread Sebastian Reichel
Hi, On Tue, Feb 18, 2025 at 03:53:06PM +0100, Heiko Stübner wrote: > Am Dienstag, 18. Februar 2025, 15:13:07 MEZ schrieb Sebastian Reichel: > > On Tue, Feb 18, 2025 at 08:17:46PM +0800, Jianfeng Liu wrote: > > > On Tue, 18 Feb 2025 11:00:57 +0100, Heiko Stübnerwrote: >

Re: [PATCH 3/4] arm64: dts: rockchip: Add HDMI1 PHY PLL clock source to VOP2 on RK3588

2025-02-18 Thread Sebastian Reichel
Hi, On Tue, Feb 18, 2025 at 08:17:46PM +0800, Jianfeng Liu wrote: > On Tue, 18 Feb 2025 11:00:57 +0100, Heiko Stübnerwrote: > >So I guess step1, check what error is actually returned. > > I have checked that the return value is -517: > > rockchip-drm display-subsystem: [drm] *ERROR* failed to ge

Re: [PATCH v6 00/14] Add eDP support for RK3588

2025-02-13 Thread Sebastian Reichel
Hi, On Thu, Feb 13, 2025 at 05:56:55PM +0100, Diederik de Haas wrote: > On Thu Feb 13, 2025 at 3:54 PM CET, Piotr Oniszczuk wrote: > > > > > >> Wiadomość napisana przez Damon Ding w dniu 23 > >> sty 2025, o godz. 11:07: > >> > >> Picked from: > >> https://patchwork.kernel.org/project/linux-rock

Re: [PATCH v6 00/14] Add eDP support for RK3588

2025-02-13 Thread Sebastian Reichel
Hello Piotr, On Thu, Feb 13, 2025 at 03:54:00PM +0100, Piotr Oniszczuk wrote: > > Wiadomość napisana przez Damon Ding w dniu 23 > > sty 2025, o godz. 11:07: > > > > Picked from: > > https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593 > > > > These patchs have been tested wi

[PATCH v1] drm/edp-panel: Add panel used by T14s Gen6 Snapdragon

2025-02-10 Thread Sebastian Reichel
From: Sebastian Reichel The Lenovo Thinkpad T14s Gen6 Snapdragon is currently sold with three different panel versions: OLED, Low Power IPS or IPS with Touchscreen. My Low Power IPS version had this panel and the kernel complained about not knowing any details. I don't have any

[PATCH v2 0/2] Rockchip W552793DBA-V10 panel support

2025-02-07 Thread Sebastian Reichel
having a look. Greetings, -- Sebastian --- Sebastian Reichel (2): dt-bindings: display: panel: Add Raydium RM67200 drm/panel: add Raydium RM67200 panel driver .../bindings/display/panel/raydium,rm67200.yaml| 72 +++ drivers/gpu/drm/panel/Kconfig | 10

[PATCH v2 2/2] drm/panel: add Raydium RM67200 panel driver

2025-02-07 Thread Sebastian Reichel
-by: Jessica Zhang Reviewed-by: Andy Yan Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67200.c | 503 ++ 3 files changed, 514

[PATCH v2 1/2] dt-bindings: display: panel: Add Raydium RM67200

2025-02-07 Thread Sebastian Reichel
The Rockchip W552793DBA-V10 display/touchscreen board contains a Wanchanglong W552793BAA panel, which in turn is using a Raydium RM67200 MIPI-DSI controller. Add a DT binding for the DSI panel. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- .../bindings/display/panel

Re: [PATCH] drm/rockchip: Fix Copyright description

2024-12-12 Thread Sebastian Reichel
ndy Yan > --- Reviewed-by: Sebastian Reichel -- Sebastian > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +- > drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- > drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 +- > drivers/gpu/drm/rockchip/cdn-dp

Re: [PATCH v1 2/2] drm/panel: add Raydium RM67200 panel driver

2024-12-10 Thread Sebastian Reichel
Hello Jessica, On Tue, Dec 10, 2024 at 09:45:09AM -0800, Jessica Zhang wrote: > [...] > > +static const struct raydium_rm67200_panel_info w552793baa_info = { > > + .mode = { > > + .clock = 132000, > > + .hdisplay = 1080, > > + .hsync_start = 1095, > > + .h

[PATCH v1 0/2] Rockchip W552793DBA-V10 panel support

2024-12-10 Thread Sebastian Reichel
...@sntech.de/ Thanks for having a look. Greetings, -- Sebastian Sebastian Reichel (2): dt-bindings: display: panel: Add Raydium RM67200 drm/panel: add Raydium RM67200 panel driver .../display/panel/raydium,rm67200.yaml| 72 +++ drivers/gpu/drm/panel/Kconfig | 8

[PATCH v1 2/2] drm/panel: add Raydium RM67200 panel driver

2024-12-10 Thread Sebastian Reichel
-by: Sebastian Reichel --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67200.c | 503 ++ 3 files changed, 512 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel

[PATCH v1 1/2] dt-bindings: display: panel: Add Raydium RM67200

2024-12-10 Thread Sebastian Reichel
The Rockchip W552793DBA-V10 display/touchscreen board contains a Wanchanglong W552793BAA panel, which in turn is using a Raydium RM67200 MIPI-DSI controller. Add a DT binding for the DSI panel. Signed-off-by: Sebastian Reichel --- .../display/panel/raydium,rm67200.yaml| 72

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-12-05 Thread Sebastian Reichel
Hello Damon, On Thu, Dec 05, 2024 at 09:13:33AM +0800, Damon Ding wrote: > Firstly, the term "the HDMI and eDP dynamic switching" can be somewhat > misleading, because the eDP usually does not support hot plug. The RK3588 > eDP is often used as DP, and it actually supports DP 1.2. Therefore, it is

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-12-02 Thread Sebastian Reichel
Hi, On Mon, Dec 02, 2024 at 11:28:13AM +0800, Damon Ding wrote: > Hi, > > On 2024/12/2 6:59, Sebastian Reichel wrote: > > Hi, > > > > On Sat, Nov 30, 2024 at 09:25:12PM +0100, Heiko Stübner wrote: > > > Am Freitag, 29. November 2024, 03:43:57 CET schrieb Dam

Re: [PATCH v1 04/10] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode

2024-12-01 Thread Sebastian Reichel
Hi, On Sat, Nov 30, 2024 at 09:25:12PM +0100, Heiko Stübner wrote: > Am Freitag, 29. November 2024, 03:43:57 CET schrieb Damon Ding: > > On 2024/11/27 19:04, Heiko Stübner wrote: > > > Am Mittwoch, 27. November 2024, 12:00:10 CET schrieb Damon Ding: > > >> On 2024/11/27 17:29, Heiko Stübner wrote:

Re: [PATCH v2] drm/rockchip: vop2: fix rk3588 dp+dsi maxclk verification

2024-11-22 Thread Sebastian Reichel
too. > > Fixes: 5a028e8f062f ("drm/rockchip: vop2: Add support for rk3588") > Signed-off-by: Heiko Stuebner > Reviewed-by: Quentin Schulz > Acked-by: Andy Yan > --- Reviewed-by: Sebastian Reichel Tested-by: Sebastian Reichel -- Sebastian > changes in v2: > - drop

Re: [PATCH 2/2] drm/rockchip: dsi: Don't log errors on deferred dphy

2024-11-08 Thread Sebastian Reichel
Hi, On Fri, Nov 08, 2024 at 02:53:58PM +0100, Dragan Simic wrote: > Deferred driver probing shouldn't result in errors or warnings being logged, > because their presence in the kernel log provides no value and may actually > cause false impression that some issues exist. Thus, let's no longer pro

Re: [PATCH v4 01/27] power: supply: add undervoltage health status property

2024-09-14 Thread Sebastian Reichel
Hi, On Fri, Sep 13, 2024 at 06:07:44PM GMT, Dzmitry Sankouski wrote: > Add POWER_SUPPLY_HEALTH_UNDERVOLTAGE status for power supply > to report under voltage lockout failures. > > Signed-off-by: Dzmitry Sankouski > --- This is missing updates to Documentation/ABI/testing/sysfs-class-power and d

Re: [PATCH 0/3] drm/omap: Minor fixes

2024-09-14 Thread Sebastian Reichel
Hi, On Tue, Aug 06, 2024 at 04:50:26PM GMT, Tomi Valkeinen wrote: > A few minor fixes to omapdrm, mostly to remove sparse or other checker > warnings. > > Tomi > > Signed-off-by: Tomi Valkeinen For the series: Reviewed-by: Sebastian Reichel Greetings, -- Sebastian >

Re: [PATCH 4/9] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s

2024-06-13 Thread Sebastian Reichel
Hi, On Wed, Jun 12, 2024 at 03:52:57PM GMT, Tomeu Vizoso wrote: > See Chapter 36 "RKNN" from the RK3588 TRM (Part 1). > > This is a derivative of NVIDIA's NVDLA, but with its own front-end > processor. > > Mostly taken from downstream. > > Signed-off-by: Tomeu Vizoso > --- Looking at the TRM

Re: [PATCH 5/9] arm64: dts: rockchip: Enable the NPU on quartzpro64

2024-06-13 Thread Sebastian Reichel
Hi, On Wed, Jun 12, 2024 at 03:52:58PM GMT, Tomeu Vizoso wrote: > Enable the nodes added in a previous commit to the rk3588s device tree. > > Signed-off-by: Tomeu Vizoso > --- There is a separate regulator for the NPU. For QuartzPro64, which is basically the same as EVB1, it should look like th

Re: [PATCH 2/9] iommu/rockchip: Attach multiple power domains

2024-06-13 Thread Sebastian Reichel
Hi, On Thu, Jun 13, 2024 at 11:34:02AM GMT, Tomeu Vizoso wrote: > On Thu, Jun 13, 2024 at 11:24 AM Tomeu Vizoso wrote: > > On Thu, Jun 13, 2024 at 2:05 AM Sebastian Reichel > > wrote: > > > On Wed, Jun 12, 2024 at 03:52:55PM GMT, Tomeu Vizoso wrote: > > > >

Re: [PATCH 2/9] iommu/rockchip: Attach multiple power domains

2024-06-12 Thread Sebastian Reichel
Hi, On Wed, Jun 12, 2024 at 03:52:55PM GMT, Tomeu Vizoso wrote: > IOMMUs with multiple base addresses can also have multiple power > domains. > > The base framework only takes care of a single power domain, as some > devices will need for these power domains to be powered on in a specific > order

Re: [PATCH 1/9] iommu/rockchip: Add compatible for rockchip,rk3588-iommu

2024-06-12 Thread Sebastian Reichel
Hello Tomeu, On Wed, Jun 12, 2024 at 03:52:54PM GMT, Tomeu Vizoso wrote: > So far, seems to be fully compatible with the one in the RK3568. > > The bindings already had this compatible, but the driver didn't > advertise it. > > Signed-off-by: Tomeu Vizoso > --- The driver does not need to advi

Re: (subset) [PATCH 00/34] address all -Wunused-const warnings

2024-04-10 Thread Sebastian Reichel
nst' variables in header files > instead of using macros or enums. > > [...] Applied, thanks! [09/34] power: rt9455: hide unused rt9455_boost_voltage_values commit: 452d8950db3e839aba1bb13bc5378f4bac11fa04 Best regards, -- Sebastian Reichel

Re: [PATCH v2 1/2] dt-bindings: backlight: Add Texas Instruments LM3509

2024-03-09 Thread Sebastian Reichel
Hi, On Sat, Mar 09, 2024 at 01:22:28PM +0100, Krzysztof Kozlowski wrote: > LED strings are true in case of... well, LED strings, but I just > wonder if such setup is applicable for backlight. Anyway, if you > think it is, I don't mind. LED strings are being used as backlight. Either from the edge

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

2023-11-16 Thread Sebastian Reichel
Hi, On Thu, Nov 16, 2023 at 06:39:40PM +0800, Andy Yan wrote: > > > vop2->sys_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > > > "rockchip,grf"); > > This already lacks an error check, shame on me... > > > > > + vop2->vop_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > >

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Sebastian Reichel
er directly or using the devm variant, leading to > a crash. And probably the driver will crash if it happens, for some > reason, to try to send a message via the DSI bus. > > But that's another topic. > > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel

Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached

2023-09-20 Thread Sebastian Reichel
ach() was never called before. > > This happens if the panel driver asks for an EPROBE_DEFER. > > So let's suppress the WARN() in this special case. ... > Signed-off-by: H. Nikolaus Schaller > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omap

Re: [PATCH v2 3/3] dt-bindings: display: add rotation property to sitronix,st7789v

2023-08-03 Thread Sebastian Reichel
Hi, On Thu, Aug 03, 2023 at 10:13:50PM +0200, Michael Riesch wrote: > The sitronix-st7789v driver now considers the rotation property. > Add the property to the documentation. > > Acked-by: Conor Dooley > Signed-off-by: Michael Riesch > --- Reviewed-by: Sebastian Reic

Re: [PATCH v2 2/3] drm/panel: sitronix-st7789v: add panel orientation support

2023-08-03 Thread Sebastian Reichel
Hi, On Thu, Aug 03, 2023 at 10:13:49PM +0200, Michael Riesch wrote: > Determine the orientation of the display based on the device tree and > propagate it. > > Reviewed-by: Neil Armstrong > Signed-off-by: Michael Riesch > --- Reviewed-by: Sebastian Reichel -- Sebastian

Re: [PATCH v2 1/3] drm/panel: sitronix-st7789v: fix indentation in drm_panel_funcs

2023-08-03 Thread Sebastian Reichel
Hi, On Thu, Aug 03, 2023 at 10:13:48PM +0200, Michael Riesch wrote: > Fix indentation of the callbacks in struct drm_panel_funcs. > No functional changes. > > Signed-off-by: Michael Riesch > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-

Re: [PATCH v3 00/19] Sitronix ST7789V improvements

2023-07-31 Thread Sebastian Reichel
Hi, Each patch in the series has at least one Reviewed-by tag and the DT binding changes have an Acked-by from at least one of the DT binding maintainers. It has been pending on the mailing list for two weeks now, so can it be applied? P.S.: Looks like I missed Neil in the original recipients lis

[PATCH v3 02/19] dt-bindings: display: st7789v: add Inanbo T28CP45TN89

2023-07-13 Thread Sebastian Reichel
Add compatible value for Inanbo t28cp45tn89 and make reset GPIO non mandatory, since it might not be connected to the CPU. Reviewed-by: Michael Riesch Acked-by: Rob Herring Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 5 +++-- 1 file

[PATCH v3 15/19] dt-bindings: display: st7789v: bound the number of Rx data lines

2023-07-13 Thread Sebastian Reichel
igned-off-by: Miquel Raynal Acked-by: Krzysztof Kozlowski Reviewed-by: Sebastian Reichel Tested-by: Sebastian Reichel Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devic

[PATCH v3 08/19] drm/panel: sitronix-st7789v: avoid hardcoding mode info

2023-07-13 Thread Sebastian Reichel
Avoid hard-coding the default_mode and supply it from match data. One additional layer of abstraction has been introduced, which will be needed for specifying other panel information (e.g. bus flags) in the next steps. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu

[PATCH v3 19/19] drm/panel: sitronix-st7789v: Check display ID

2023-07-13 Thread Sebastian Reichel
just warn the user, in case the DT description would be lacking the Rx bus width (which is likely on old descriptions) in order to avoid breaking existing devices. Signed-off-by: Miquel Raynal Acked-by: Sam Ravnborg Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Tested-by: Sebastian

[PATCH v3 12/19] drm/panel: sitronix-st7789v: avoid hardcoding polarity info

2023-07-13 Thread Sebastian Reichel
Add polarity information via mode and bus flags, so that they are no longer hardcoded and forward the information to the DRM stack. This is required for adding panels with different settings. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix

[PATCH v3 11/19] drm/panel: sitronix-st7789v: avoid hardcoding invert mode

2023-07-13 Thread Sebastian Reichel
While the default panel uses invert mode, some panels require non-invert mode instead. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v3 10/19] drm/panel: sitronix-st7789v: add media bus format

2023-07-13 Thread Sebastian Reichel
Add support for describing the media bus format in the panel configuration and expose that to userspace. Since both supported formats (RGB565 and RGB666) are using 6 bits per color also hardcode that information. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu/drm

[PATCH v3 03/19] drm/panel: sitronix-st7789v: add SPI ID table

2023-07-13 Thread Sebastian Reichel
SPI device drivers should also have a SPI ID table. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel

[PATCH v3 07/19] drm/panel: sitronix-st7789v: improve error handling

2023-07-13 Thread Sebastian Reichel
Improve error handling in the probe routine, so that probe defer errors are captured in /sys/kernel/debug/devices_deferred Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 23 ++- 1 file changed, 12 insertions

[PATCH v3 05/19] drm/panel: sitronix-st7789v: make reset GPIO optional

2023-07-13 Thread Sebastian Reichel
The reset pin might not be software controllable from the SoC, so make it optional. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH v3 14/19] dt-bindings: display: st7789v: Add the edt, et028013dma panel compatible

2023-07-13 Thread Sebastian Reichel
From: Miquel Raynal The ST7789V LCD controller is also embedded in the ET028013DMA panel. Add a compatible string to describe this other panel. Signed-off-by: Miquel Raynal Acked-by: Krzysztof Kozlowski Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Signed-off-by: Sebastian Reichel

[PATCH v3 13/19] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support

2023-07-13 Thread Sebastian Reichel
has been seen on the device. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 25 +++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel

[PATCH v3 06/19] drm/panel: sitronix-st7789v: simplify st7789v_spi_write

2023-07-13 Thread Sebastian Reichel
st7789v_spi_write initializes a message with just a single transfer, spi_sync_transfer can be used for that. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a

[PATCH v3 04/19] drm/panel: sitronix-st7789v: remove unused constants

2023-07-13 Thread Sebastian Reichel
ST7789V_COLMOD_RGB_FMT_18BITS and ST7789V_COLMOD_CTRL_FMT_18BITS are unused in favour of MIPI_DCS_PIXEL_FMT_18BIT, remove them. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 3 --- 1 file changed, 3 deletions(-) diff --git a

[PATCH v3 09/19] drm/panel: sitronix-st7789v: avoid hardcoding panel size

2023-07-13 Thread Sebastian Reichel
Move the panel size information to the mode struct, so that different panel sizes can be specified depending on the panel type. Reviewed-by: Michael Riesch Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH v3 18/19] drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support

2023-07-13 Thread Sebastian Reichel
malfunction if any of the following situation occurs: * Pixel clock is above 3MHz * Pixel clock is not inverted I could not properly identify the reasons behind these failures, scope captures show valid input signals. Signed-off-by: Miquel Raynal Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel

[PATCH v3 17/19] drm/panel: sitronix-st7789v: Clarify a definition

2023-07-13 Thread Sebastian Reichel
not a high state. Correct the definition to ease the comparison with the datasheet. Signed-off-by: Miquel Raynal Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Tested-by: Sebastian Reichel Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 ++-- 1

[PATCH v3 16/19] drm/panel: sitronix-st7789v: Use 9 bits per spi word by default

2023-07-13 Thread Sebastian Reichel
From: Miquel Raynal The Sitronix controller expects 9-bit words, provide this as default at probe time rather than specifying this in each and every access. Signed-off-by: Miquel Raynal Reviewed-by: Sam Ravnborg Acked-by: Maxime Ripard Reviewed-by: Sebastian Reichel Tested-by: Sebastian

[PATCH v3 01/19] dt-bindings: vendor-prefixes: add Inanbo

2023-07-13 Thread Sebastian Reichel
Shenzhen INANBO Electronic Technology Co., Ltd. manufacturers TFT/OLED LCD panels. Reviewed-by: Michael Riesch Acked-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH v3 00/19] Sitronix ST7789V improvements

2023-07-13 Thread Sebastian Reichel
er of Rx data lines drm/panel: sitronix-st7789v: Use 9 bits per spi word by default drm/panel: sitronix-st7789v: Clarify a definition drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support drm/panel: sitronix-st7789v: Check display ID Sebastian Reichel (13): dt-bindings: vendor-

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-16 Thread Sebastian Reichel
Hi, On Fri, Jun 16, 2023 at 12:13:45PM +0200, Miquel Raynal wrote: > s...@kernel.org wrote on Thu, 15 Jun 2023 01:27:24 +0200: > > On Sat, Jun 10, 2023 at 10:45:25PM +0200, Sam Ravnborg wrote: > > > On Fri, Jun 09, 2023 at 04:59:51PM +0200, Miquel Raynal wrote: > > > > A very basic debugging rul

Re: [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings

2023-06-15 Thread Sebastian Reichel
Hi Sam, On Thu, Jun 15, 2023 at 07:43:46AM +0200, Sam Ravnborg wrote: > On Thu, Jun 15, 2023 at 01:22:17AM +0200, Sebastian Reichel wrote: > > > > May I point to you Sebastian Reichel's series that features a partial > > > > overlap with your work? [0] > &g

Re: [PATCH 7/7] drm/panel: sitronix-st7789v: Check display ID

2023-06-14 Thread Sebastian Reichel
Hi, On Sat, Jun 10, 2023 at 10:45:25PM +0200, Sam Ravnborg wrote: > Hi Miquel, > > On Fri, Jun 09, 2023 at 04:59:51PM +0200, Miquel Raynal wrote: > > A very basic debugging rule when a device is connected for the first > > time is to access a read-only register which contains known data in > > or

Re: [PATCH 1/7] drm/panel: sitronix-st7789v: Prevent core spi warnings

2023-06-14 Thread Sebastian Reichel
Hi, On Tue, Jun 13, 2023 at 08:56:30AM +0200, Miquel Raynal wrote: > Hi Michael, > > michael.rie...@wolfvision.net wrote on Tue, 13 Jun 2023 08:15:26 +0200: > > > Hi Miquel, > > > > On 6/9/23 16:59, Miquel Raynal wrote: > > > The spi core warns us about using an of_device_id table without a >

[PATCH v2 09/13] drm/panel: sitronix-st7789v: avoid hardcoding panel size

2023-04-22 Thread Sebastian Reichel
Move the panel size information to the mode struct, so that different panel sizes can be specified depending on the panel type. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 12/13] drm/panel: sitronix-st7789v: avoid hardcoding polarity info

2023-04-22 Thread Sebastian Reichel
Add polarity information via mode and bus flags, so that they are no longer hardcoded and forward the information to the DRM stack. This is required for adding panels with different settings. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 22

[PATCH v2 06/13] drm/panel: sitronix-st7789v: simplify st7789v_spi_write

2023-04-22 Thread Sebastian Reichel
st7789v_spi_write initializes a message with just a single transfer, spi_sync_transfer can be used for that. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH v2 07/13] drm/panel: sitronix-st7789v: improve error handling

2023-04-22 Thread Sebastian Reichel
Improve error handling in the probe routine, so that probe defer errors are captured in /sys/kernel/debug/devices_deferred Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 23 ++- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a

[PATCH v2 05/13] drm/panel: sitronix-st7789v: make reset GPIO optional

2023-04-22 Thread Sebastian Reichel
The reset pin might not be software controllable from the SoC, so make it optional. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers

[PATCH v2 10/13] drm/panel: sitronix-st7789v: add media bus format

2023-04-22 Thread Sebastian Reichel
Add support for describing the media bus format in the panel configuration and expose that to userspace. Since both supported formats (RGB565 and RGB666) are using 6 bits per color also hardcode that information. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 11/13] drm/panel: sitronix-st7789v: avoid hardcoding invert mode

2023-04-22 Thread Sebastian Reichel
While the default panel uses invert mode, some panels require non-invert mode instead. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 02/13] dt-bindings: display: st7789v: add Inanbo T28CP45TN89

2023-04-22 Thread Sebastian Reichel
Add compatible value for Inanbo t28cp45tn89 and make reset GPIO non mandatory, since it might not be connected to the CPU. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 13/13] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support

2023-04-22 Thread Sebastian Reichel
has been seen on the device. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 25 +++ 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index

[PATCH v2 08/13] drm/panel: sitronix-st7789v: avoid hardcoding mode info

2023-04-22 Thread Sebastian Reichel
Avoid hard-coding the default_mode and supply it from match data. One additional layer of abstraction has been introduced, which will be needed for specifying other panel information (e.g. bus flags) in the next steps. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix

[PATCH v2 04/13] drm/panel: sitronix-st7789v: remove unused constants

2023-04-22 Thread Sebastian Reichel
ST7789V_COLMOD_RGB_FMT_18BITS and ST7789V_COLMOD_CTRL_FMT_18BITS are unused in favour of MIPI_DCS_PIXEL_FMT_18BIT, remove them. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCH v2 01/13] dt-bindings: vendor-prefixes: add Inanbo

2023-04-22 Thread Sebastian Reichel
Shenzhen INANBO Electronic Technology Co., Ltd. manufacturers TFT/OLED LCD panels. Acked-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v2 03/13] drm/panel: sitronix-st7789v: add SPI ID table

2023-04-22 Thread Sebastian Reichel
SPI device drivers should also have a SPI ID table. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCH v2 00/13] Add Inanbo T28CP45TN89 panel support

2023-04-22 Thread Sebastian Reichel
/ * Apply DT binding changes requested by Krzysztof Kozlowski and his Ack * I changed the driver patches to avoid code duplication and splitted the code a bit more -- Sebastian Sebastian Reichel (13): dt-bindings: vendor-prefixes: add Inanbo dt-bindings: display: st7789v: add Inanbo

[PATCHv1 5/7] drm/panel: sitronix-st7789v: make reset GPIO optional

2023-03-17 Thread Sebastian Reichel
The reset pin might not be software controllable from the SoC, so make it optional. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers

[PATCHv1 2/7] dt-bindings: display: st7789v: add Inanbo T28CP45TN89

2023-03-17 Thread Sebastian Reichel
Add compatible value for Inanbo t28cp45tn89 and make reset GPIO non mandatory, since it might not be connected to the CPU. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a

[PATCHv1 4/7] drm/panel: sitronix-st7789v: remove unused constants

2023-03-17 Thread Sebastian Reichel
ST7789V_COLMOD_RGB_FMT_18BITS and ST7789V_COLMOD_CTRL_FMT_18BITS are unused in favour of MIPI_DCS_PIXEL_FMT_18BIT, remove them. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel

[PATCHv1 6/7] drm/panel: sitronix-st7789v: prepare for additional panels

2023-03-17 Thread Sebastian Reichel
Prepare the driver for additional panels with different initialization. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 110 +++--- 1 file changed, 67 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b

[PATCHv1 3/7] drm/panel: sitronix-st7789v: add SPI ID table

2023-03-17 Thread Sebastian Reichel
SPI device drivers should also have a SPI ID table. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c

[PATCHv1 7/7] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support

2023-03-17 Thread Sebastian Reichel
has been seen on the device. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c| 137 ++ 1 file changed, 137 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index

[PATCHv1 0/7] Add Inanbo T28CP45TN89 panel support

2023-03-17 Thread Sebastian Reichel
e, but did not want to delay getting some review feedback :) [0] https://lore.kernel.org/all/20230314115644.3775169-1-gerald.loac...@wolfvision.net/ -- Sebastian Sebastian Reichel (7): dt-bindings: vendor-prefixes: add Inanbo dt-bindings: display: st7789v: add Inanbo T28CP45TN89 drm/panel

[PATCHv1 1/7] dt-bindings: vendor-prefixes: add Inanbo

2023-03-17 Thread Sebastian Reichel
Shenzhen INANBO Electronic Technology Co., Ltd. manufacturers TFT/OLED LCD panels. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-01 Thread Sebastian Reichel
-e > 's/spi[0-9] {/spi {/' > > With this, a few errors in examples were exposed and fixed. > > Signed-off-by: Rob Herring > --- Acked-by: Sebastian Reichel # for power-supply -- Sebastian ... > .../devicetree/bindings/power/supply/bq2415x.yaml | 2 +- >

Re: [PATCH] dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-01-29 Thread Sebastian Reichel
ternProperties: >'^(ac|usb)$': > type: object > +additionalProperties: false > description: USB/AC charging parameters > properties: >charger-type: Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Sebastian Reichel
NTDUMP | VM_DONTEXPAND; > + set_vm_flags(vma, VM_IO | VM_DONTDUMP | VM_DONTEXPAND); > vma->vm_ops = &cs_char_vm_ops; > vma->vm_private_data = file->private_data; > Acked-by: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] drm/imx: ipuv3-plane: Fix overlay plane width

2022-11-08 Thread Sebastian Reichel
Hi, On Tue, Nov 08, 2022 at 03:14:20PM +0100, Philipp Zabel wrote: > ipu_src_rect_width() was introduced to support odd screen resolutions > such as 1366x768 by internally rounding up primary plane width to a > multiple of 8 and compensating with reduced horizontal blanking. > This also caused ove

Re: [PATCH 2/2] power: supply: Add Lenovo Yoga C630 EC driver

2022-09-13 Thread Sebastian Reichel
Hi, [+Cc Lee Jones, DRI devel] On Tue, Aug 09, 2022 at 10:05:00PM -0500, Bjorn Andersson wrote: > The Qualcomm Snapdragon-based Lenovo Yoga C630 has some sort of EC > providing AC-adapter and battery status, as well as USB Type-C altmode > notifications for Displayport operation. > > The Yoga C6

Re: [PATCH v5 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver

2022-07-16 Thread Sebastian Reichel
Hi, On Fri, Jul 15, 2022 at 07:26:04PM +0800, ChiaEn Wu wrote: > From: ChiaEn Wu > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > driver, display bias voltage supply, one general purpose LDO, a

Re: [PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers

2022-06-17 Thread Sebastian Reichel
gt; Changes since v1: removed the last remaining .fb_blank reference > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-sony-acx565akm.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/pan

Re: [PATCH v2 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-17 Thread Sebastian Reichel
Signed-off-by: Stephen Kitt > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > --- > Changes since v1: removed unnecessary parentheses > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm

Re: [PATCH 3/3] drm/panel: sony-acx565akm: Use backlight helpers

2022-06-09 Thread Sebastian Reichel
l@lists.freedesktop.org > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/panel/panel-sony-acx565akm.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c > b/drivers/gpu/drm/pan

Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-09 Thread Sebastian Reichel
| BL_CORE_SUSPENDED; > + backlight_disable(backlight); > } The brackets can be removed now. Otherwise: Reviewed-by: Sebastian Reichel -- Sebastian > - > - backlight_update_status(backlight); > } > > static void hw_guard_start(struct panel_drv_data

Re: [PATCH] dt-bindings: Fix properties without any type

2022-05-22 Thread Sebastian Reichel
ndings/serial/8250.yaml| 1 + > .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++ > .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++ > Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 + > 25 files changed, 55 insertions(+),

  1   2   3   4   5   6   7   >