Re: [PATCH v2] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-25 Thread Saurabh Singh Sengar
On Tue, Feb 25, 2025 at 04:46:12PM +, Michael Kelley wrote: > From: Saurabh Sengar > > > > When a Hyper-V framebuffer device is unbind, hyperv_fb driver tries to > > release the framebuffer forcefully. If this framebuffer is in use it > > produce the following WARN and hence this framebuffer

Re: [PATCH] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-24 Thread Saurabh Singh Sengar
On Mon, Feb 24, 2025 at 12:38:22AM +, Michael Kelley wrote: > From: Saurabh Singh Sengar Sent: Sunday, > February 23, 2025 6:10 AM > > > > On Sat, Feb 22, 2025 at 08:16:53PM +, Michael Kelley wrote: > > > From: Saurabh Singh Sengar Sent: Saturday, >

Re: [PATCH] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-23 Thread Saurabh Singh Sengar
On Sat, Feb 22, 2025 at 08:16:53PM +, Michael Kelley wrote: > From: Saurabh Singh Sengar Sent: Saturday, > February 22, 2025 9:27 AM > > > > On Wed, Feb 19, 2025 at 05:22:36AM +, Michael Kelley wrote: > > > From: Saurabh Sengar Sent: Saturday, > >

Re: [PATCH] fbdev: hyperv_fb: Allow graceful removal of framebuffer

2025-02-22 Thread Saurabh Singh Sengar
On Wed, Feb 19, 2025 at 05:22:36AM +, Michael Kelley wrote: > From: Saurabh Sengar Sent: Saturday, February > 15, 2025 1:21 AM > > > > When a Hyper-V framebuffer device is unbind, hyperv_fb driver tries to > > release the framebuffer forcefully. If this framebuffer is in use it > > produce t

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-12 Thread Saurabh Singh Sengar
On Thu, Feb 13, 2025 at 01:35:22AM +, Michael Kelley wrote: > From: Saurabh Singh Sengar Sent: Monday, > February 10, 2025 8:52 AM > > > [snip] > > > > > > > > > > While we are at it, I want to mention that I also observed below WARN > > &

Re: [PATCH 1/1] drm/hyperv: Fix address space leak when Hyper-V DRM device is removed

2025-02-11 Thread Saurabh Singh Sengar
On Tue, Feb 11, 2025 at 03:46:51AM +, Michael Kelley wrote: > From: Saurabh Singh Sengar Sent: Monday, > February 10, 2025 7:33 PM > > > > On Mon, Feb 10, 2025 at 11:34:41AM -0800, mhkelle...@gmail.com wrote: > > > From: Michael Kelley > > > > >

Re: [PATCH 1/1] drm/hyperv: Fix address space leak when Hyper-V DRM device is removed

2025-02-10 Thread Saurabh Singh Sengar
On Mon, Feb 10, 2025 at 11:34:41AM -0800, mhkelle...@gmail.com wrote: > From: Michael Kelley > > When a Hyper-V DRM device is probed, the driver allocates MMIO space for > the vram, and maps it cacheable. If the device removed, or in the error > path for device probing, the MMIO space is released

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-10 Thread Saurabh Singh Sengar
On Mon, Feb 10, 2025 at 06:58:25AM -0800, Saurabh Singh Sengar wrote: > On Mon, Feb 10, 2025 at 02:28:35PM +, Michael Kelley wrote: > > From: Saurabh Singh Sengar Sent: Monday, > > February 10, 2025 4:41 AM > > > > > > On Sun, Feb 09, 2025 at 03:52:52PM

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-10 Thread Saurabh Singh Sengar
On Mon, Feb 10, 2025 at 02:28:35PM +, Michael Kelley wrote: > From: Saurabh Singh Sengar Sent: Monday, > February 10, 2025 4:41 AM > > > > On Sun, Feb 09, 2025 at 03:52:52PM -0800, mhkelle...@gmail.com wrote: > > > From: Michael Kelley > > > > &

Re: [PATCH 1/1] fbdev: hyperv_fb: iounmap() the correct memory when removing a device

2025-02-10 Thread Saurabh Singh Sengar
On Sun, Feb 09, 2025 at 03:52:52PM -0800, mhkelle...@gmail.com wrote: > From: Michael Kelley > > When a Hyper-V framebuffer device is removed, or the driver is unbound > from a device, any allocated and/or mapped memory must be released. In > particular, MMIO address space that was mapped to the

RE: hyper_bf soft lockup on Azure Gen2 VM when taking kdump or executing kexec

2025-02-07 Thread Saurabh Singh Sengar
Thanks Michael, for the analysis. I have tried the kdump steps on Oracle 9.4, 6.13.0 kernel as well. Although I couldn't see the soft lockup issue I see some other VMBus failures. But I agree the bootup is extremely slow, which should be due to same reason. My system is having newer UEFI versi

Re: [PATCH 1/1] fbdev/hyperv_fb: Fix logic error for Gen2 VMs in hvfb_getmem()

2024-02-03 Thread Saurabh Singh Sengar
On Wed, Jan 31, 2024 at 10:00:22PM -0800, mhkelle...@gmail.com wrote: > From: Michael Kelley > > A recent commit removing the use of screen_info introduced a logic > error. The error causes hvfb_getmem() to always return -ENOMEM > for Generation 2 VMs. As a result, the Hyper-V frame buffer > devi

Re: [PATCH] drm: Check output polling initialized before disabling

2024-01-04 Thread Saurabh Singh Sengar
On Thu, Jan 04, 2024 at 09:19:42PM -0800, Shradha Gupta wrote: > On Wed, Dec 27, 2023 at 02:33:17AM -0800, Saurabh Singh Sengar wrote: > > On Tue, Dec 26, 2023 at 11:27:15PM -0800, Shradha Gupta wrote: > > > In drm_mode_config_helper_suspend() check if output polling > >

Re: [PATCH] drm: Check output polling initialized before disabling

2023-12-27 Thread Saurabh Singh Sengar
On Tue, Dec 26, 2023 at 11:27:15PM -0800, Shradha Gupta wrote: > In drm_mode_config_helper_suspend() check if output polling > support is initialized before enabling/disabling polling. > For drivers like hyperv-drm, that do not initialize connector > polling, if suspend is called without this check

Re: [PATCH] drm/hyperv: Don't rely on screen_info.lfb_base for Gen1 VMs

2022-09-13 Thread Saurabh Singh Sengar
On Mon, Sep 12, 2022 at 09:03:53AM +0200, Thomas Zimmermann wrote: > Hi > > Am 11.09.22 um 18:21 schrieb Saurabh Singh Sengar: > >On Sat, Sep 10, 2022 at 08:11:24PM +0200, Thomas Zimmermann wrote: > >>Hi > >> > >>Am 09.09.22 um 16:43 schrieb Saurabh Seng

Re: [PATCH] drm/hyperv: Don't rely on screen_info.lfb_base for Gen1 VMs

2022-09-11 Thread Saurabh Singh Sengar
On Sat, Sep 10, 2022 at 08:11:24PM +0200, Thomas Zimmermann wrote: > Hi > > Am 09.09.22 um 16:43 schrieb Saurabh Sengar: > >hyperv_setup_vram tries to remove conflicting framebuffer based on > >'screen_info'. As observed in past due to some bug or wrong setting > >in grub, the 'screen_info' fields

Re: [PATCH] drm/hyperv: Add ratelimit on error message

2022-09-11 Thread Saurabh Singh Sengar
On Sat, Sep 10, 2022 at 08:06:05PM +0200, Thomas Zimmermann wrote: > Hi > > Am 09.09.22 um 17:09 schrieb Saurabh Sengar: > >Due to a full ring buffer, the driver may be unable to send updates to > >the Hyper-V host. But outputing the error message can make the problem > >worse because console out

Re: [PATCH v4] drm/hyperv: Add error message for fb size greater than allocated

2022-05-03 Thread Saurabh Singh Sengar
On Tue, Apr 12, 2022 at 05:06:07AM +, Dexuan Cui wrote: > > From: Saurabh Sengar > > Sent: Monday, April 11, 2022 9:29 PM > > ... > > Add error message when the size of requested framebuffer is more than > > the allocated size by vmbus mmio region for framebuffer > > The line lacks a period,

Re: [PATCH v3] drm/hyperv: Added error message for fb size greater than allocated

2022-04-11 Thread Saurabh Singh Sengar
On Mon, Apr 11, 2022 at 07:02:19PM +, Dexuan Cui wrote: > > From: Saurabh Singh Sengar > > Sent: Monday, April 11, 2022 12:56 AM > > > >... > > > > - if (fb->pitches[0] * fb->height > hv->fb_size) > > >

Re: [PATCH v3] drm/hyperv: Added error message for fb size greater than allocated

2022-04-11 Thread Saurabh Singh Sengar
On Mon, Apr 11, 2022 at 06:40:38AM +, Dexuan Cui wrote: > > Subject: [PATCH v3] drm/hyperv: Added error message for fb size greater than > > allocated > > > > Added error message when the size of requested framebuffer is more than > > the allocated size by vmbus mmio region for framebuffer >

Re: [PATCH v2] drm/hyperv: Added error message for fb size greater then allocated

2022-04-08 Thread Saurabh Singh Sengar
On Thu, Apr 07, 2022 at 09:28:53AM -0700, Deepak Rawat wrote: > On Wed, Apr 6, 2022 at 11:27 PM Saurabh Sengar > wrote: > > > > Added error message when the size of requested framebuffer is more then > > the allocated size by vmbus mmio region for framebuffer > > > > Signed-off-by: Saurabh Sengar