Re: [PATCH AUTOSEL 6.11 08/15] drm: display: Set fwnode for aux bus devices

2024-12-05 Thread Saravana Kannan
On Thu, Dec 5, 2024 at 4:06 PM Saravana Kannan wrote: > > On Wed, Dec 4, 2024 at 3:29 PM Sasha Levin wrote: > > > > From: Saravana Kannan > > > > [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] > > > > fwnode needs to be set for a dev

Re: [PATCH AUTOSEL 6.12 08/15] drm: display: Set fwnode for aux bus devices

2024-12-05 Thread Saravana Kannan
On Wed, Dec 4, 2024 at 3:28 PM Sasha Levin wrote: > > From: Saravana Kannan > > [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] > > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you&#x

Re: [PATCH AUTOSEL 6.11 08/15] drm: display: Set fwnode for aux bus devices

2024-12-05 Thread Saravana Kannan
On Wed, Dec 4, 2024 at 3:29 PM Sasha Levin wrote: > > From: Saravana Kannan > > [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] > > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you&#x

Re: [PATCH AUTOSEL 6.6 04/10] drm: display: Set fwnode for aux bus devices

2024-12-05 Thread Saravana Kannan
On Wed, Dec 4, 2024 at 3:29 PM Sasha Levin wrote: > > From: Saravana Kannan > > [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] > > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you&#x

Re: [PATCH AUTOSEL 6.1 4/8] drm: display: Set fwnode for aux bus devices

2024-12-05 Thread Saravana Kannan
On Wed, Dec 4, 2024 at 3:30 PM Sasha Levin wrote: > > From: Saravana Kannan > > [ Upstream commit fe2e59aa5d7077c5c564d55b7e2997e83710c314 ] > > fwnode needs to be set for a device for fw_devlink to be able to > track/enforce its dependencies correctly. Without this, you&#x

Re: imx8mp: HDMI display blank/black problems

2024-10-30 Thread Saravana Kannan
On Wed, Oct 30, 2024 at 10:28 AM Adam Ford wrote: > > On Wed, Oct 30, 2024 at 4:01 AM Frieder Schrempf > wrote: > > > > Hi Johannes, > > > > On 25.10.24 10:05 AM, mailingli...@johanneskirchmair.de wrote: > > > [Sie erhalten nicht häufig E-Mails von mailingli...@johanneskirchmair.de. > > > Weiter

Re: [PATCH v2] driver core: fw_devlink: Stop trying to optimize cycle detection logic

2024-10-29 Thread Saravana Kannan
On Tue, Oct 29, 2024 at 4:21 AM Tomi Valkeinen wrote: > > Hi, > > On 28/10/2024 22:39, Saravana Kannan wrote: > > On Mon, Oct 28, 2024 at 1:06 AM Tomi Valkeinen > > wrote: > >> > >> Hi, > >> > >> On 26/10/2024 07:52, Saravana Kannan

Re: [PATCH v2] driver core: fw_devlink: Stop trying to optimize cycle detection logic

2024-10-28 Thread Saravana Kannan
On Mon, Oct 28, 2024 at 1:06 AM Tomi Valkeinen wrote: > > Hi, > > On 26/10/2024 07:52, Saravana Kannan wrote: > > In attempting to optimize fw_devlink runtime, I introduced numerous cycle > > detection bugs by foregoing cycle detection logic under specific > > co

[PATCH v2] driver core: fw_devlink: Stop trying to optimize cycle detection logic

2024-10-25 Thread Saravana Kannan
oxy device links from a device that is an ancestor of a consumer fwnode. Reported-by: Tomi Valkeinen Closes: https://lore.kernel.org/all/1a1ab663-d068-40fb-8c94-f0715403d...@ideasonboard.com/ Fixes: 6442d79d880c ("driver core: fw_devlink: Improve detection of overlapping cycles") Sig

Re: fw_devlinks preventing a panel driver from probing

2024-10-25 Thread Saravana Kannan
On Thu, Oct 24, 2024 at 3:55 PM Saravana Kannan wrote: > > On Wed, Oct 23, 2024 at 1:52 AM Tomi Valkeinen > wrote: > > > > Hi, > > > > On 22/10/2024 19:07, Saravana Kannan wrote: > > > On Tue, Oct 22, 2024 at 12:51 AM Tomi Valkeinen > > > wrot

[PATCH 2/3] phy: tegra: xusb: Set fwnode for xusb port devices

2024-10-25 Thread Saravana Kannan
2.padctl: Failed to create device link (0x180) with 1-0008 Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonath...@nvidia.com/ Tested-by: Jon Hunter Suggested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan --- drivers/phy/tegra/x

Re: [PATCH 0/3] A few minor fw_devlink fixes

2024-10-25 Thread Saravana Kannan
On Thu, Oct 24, 2024 at 12:08 AM Greg Kroah-Hartman wrote: > > On Wed, Oct 23, 2024 at 11:13:41PM -0700, Saravana Kannan wrote: > > Probably easiest for Greg to pull in these changes? > > > > PSA: Do not pull any of these patches into stable kernels. fw_devlink >

Re: fw_devlinks preventing a panel driver from probing

2024-10-25 Thread Saravana Kannan
On Wed, Oct 23, 2024 at 1:52 AM Tomi Valkeinen wrote: > > Hi, > > On 22/10/2024 19:07, Saravana Kannan wrote: > > On Tue, Oct 22, 2024 at 12:51 AM Tomi Valkeinen > > wrote: > >> > >> Hi, > >> > >> On 22/10/2024 02:29, Saravana Kannan wr

Re: [PATCH 3/3] drivers: core: fw_devlink: Make the error message a bit more useful

2024-10-24 Thread Saravana Kannan
Greg, Can you fix up the commit subject prefix to "driver core: fw_devlink:" please? Don't want to send v2 just for that. -Saravana On Wed, Oct 23, 2024 at 11:14 PM Saravana Kannan wrote: > > It would make it easier to debugs issues similar to the ones > reported[1

[PATCH 1/3] drm: display: Set fwnode for aux bus devices

2024-10-23 Thread Saravana Kannan
0.edp-tx: Failed to create device link (0x180) with backlight-lcd0 Reported-by: "Nícolas F. R. A. Prado" Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ Tested-by: "Nícolas F. R. A. Prado" Signed-off-by: Saravana Kannan ---

Re: [PATCH] drm: display: Set fwnode for aux bus devices

2024-10-23 Thread Saravana Kannan
On Wed, Oct 23, 2024 at 12:56 PM Nícolas F. R. A. Prado wrote: > > On Wed, Oct 23, 2024 at 12:13:36PM -0700, Saravana Kannan wrote: > > fwnode needs to be set for a device for fw_devlink to be able to > > track/enforce its dependencies correctly. Without this, you'll see

[PATCH 3/3] drivers: core: fw_devlink: Make the error message a bit more useful

2024-10-23 Thread Saravana Kannan
a.com/ Signed-off-by: Saravana Kannan --- drivers/base/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index a4c853411a6b..3b13fed1c3e3 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2181,8 +2181,8 @@ stati

[PATCH 0/3] A few minor fw_devlink fixes

2024-10-23 Thread Saravana Kannan
herry-picked into stable kernels, cc me and wait for my explicit Ack. Thanks, Saravana Saravana Kannan (3): drm: display: Set fwnode for aux bus devices phy: tegra: xusb: Set fwnode for xusb port devices drivers: core: fw_devlink: Make the error message a bit more useful drivers/base/c

[PATCH] drm: display: Set fwnode for aux bus devices

2024-10-23 Thread Saravana Kannan
: "Nícolas F. R. A. Prado" Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonath...@nvidia.com/ Signed-off-by: Saravana Kannan --- Don't pull this into stable branches unless its causing a regression in older LTS branches. fw_devlink code is c

Re: fw_devlinks preventing a panel driver from probing

2024-10-22 Thread Saravana Kannan
On Tue, Oct 22, 2024 at 12:51 AM Tomi Valkeinen wrote: > > Hi, > > On 22/10/2024 02:29, Saravana Kannan wrote: > > Hi Tomi, > > > > Sorry it took a while to get back. > > > > On Mon, Sep 16, 2024 at 4:52 AM Tomi Valkeinen > > wrote: > >> &

Re: fw_devlinks preventing a panel driver from probing

2024-10-21 Thread Saravana Kannan
Hi Tomi, Sorry it took a while to get back. On Mon, Sep 16, 2024 at 4:52 AM Tomi Valkeinen wrote: > > Hi, > > We have an issue where two devices have dependencies to each other, > according to drivers/base/core.c's fw_devlinks, and this prevents them > from probing. I've been adding debugging to

Re: [PATCH v1] drm/mipi-dsi: Set the fwnode for mipi_dsi_device

2023-05-04 Thread Saravana Kannan
On Thu, May 4, 2023 at 12:51 AM Maxime Ripard wrote: > > Hi Saravana, > > On Wed, May 03, 2023 at 09:40:05PM -0700, Saravana Kannan wrote: > > On Fri, Mar 17, 2023 at 3:36 PM Saravana Kannan > > wrote: > > > > > > On Sun, Mar 12, 2023

Re: [PATCH v1] drm/mipi-dsi: Set the fwnode for mipi_dsi_device

2023-05-03 Thread Saravana Kannan
On Fri, Mar 17, 2023 at 3:36 PM Saravana Kannan wrote: > > On Sun, Mar 12, 2023 at 7:45 AM Martin Kepplinger > wrote: > > > > Am Donnerstag, dem 09.03.2023 um 22:39 -0800 schrieb Saravana Kannan: > > > After commit 3fb16866b51d ("driver core: fw_devlink: Mak

Re: [PATCH v1] drm/mipi-dsi: Set the fwnode for mipi_dsi_device

2023-03-17 Thread Saravana Kannan
On Sun, Mar 12, 2023 at 7:45 AM Martin Kepplinger wrote: > > Am Donnerstag, dem 09.03.2023 um 22:39 -0800 schrieb Saravana Kannan: > > After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle > > detection more robust"), fw_devlink prints an error when consumer

[PATCH v1] drm/mipi-dsi: Set the fwnode for mipi_dsi_device

2023-03-09 Thread Saravana Kannan
kernel.org/lkml/2a8e407f4f18c9350f8629a2b5fa18673355b2ae.ca...@puri.sm/ Fixes: 068a00233969 ("drm: Add MIPI DSI bus support") Signed-off-by: Saravana Kannan --- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drive

Re: [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Saravana Kannan
On Thu, Oct 7, 2021 at 1:11 PM Stephen Boyd wrote: > > Quoting Stephen Boyd (2021-10-07 11:40:07) > > Quoting Saravana Kannan (2021-10-06 20:07:11) > > > On Wed, Oct 6, 2021 at 12:38 PM Stephen Boyd wrote: > > > > diff --git a/drivers/base/component.c b/drive

Re: [PATCH] drm/mipi: set fwnode when a mipi_dsi_device registers itself

2021-07-16 Thread Saravana Kannan
k across mipi_dsi bus devices too. This feature avoid unnecessary probe deferrals of mipi_dsi devices, defers consumers of mipi_dsi devices till the mipi_dsi devices probe, and allows mipi_dsi drivers to implement sync_state() callbacks. Reviewed-by: Saravana Kannan Thanks, Saravana > > Sugg

Re: [PATCH AUTOSEL 4.19 05/12] drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device

2021-06-15 Thread Saravana Kannan
On Tue, Jun 15, 2021 at 8:50 AM Sasha Levin wrote: > > From: Saravana Kannan > > [ Upstream commit 9bf3797796f570b34438235a6a537df85832bdad ] > > On sunxi boards that use HDMI output, HDMI device probe keeps being > avoided indefinitely with these repeated messages in

Re: [PATCH v2] drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device

2021-06-07 Thread Saravana Kannan
On Mon, Jun 7, 2021 at 4:41 AM Maxime Ripard wrote: > > On Mon, Jun 07, 2021 at 10:58:36AM +0200, Ondrej Jirman wrote: > > From: Saravana Kannan > > > > On sunxi boards that use HDMI output, HDMI device probe keeps being > > avoided indefinitely with th

Re: [PATCH 3/7] component: Introduce struct aggregate_device

2021-05-20 Thread Saravana Kannan
t the struct device that was being > used is actually the parent of the aggregate device and driver. > > Cc: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Rob Clark > Cc: Russell King > Cc: Saravana Kannan > Signed-off-by: Stephen Boyd > --- > drivers/base/c

Re: [PATCH 0/7] component: Make into an aggregate bus

2021-05-20 Thread Saravana Kannan
On Wed, May 19, 2021 at 6:41 PM Stephen Boyd wrote: > > Quoting Saravana Kannan (2021-05-19 18:27:50) > > On Wed, May 19, 2021 at 5:25 PM Stephen Boyd wrote: > > > > > > This series is from discussion we had on reordering the device lists for > > > dr

Re: [PATCHv2 1/5] rtc: m41t80: add support for fixed clock

2021-04-29 Thread Saravana Kannan
describing the square wave pin > as fixed-clock, which is registered early and basically how > this pin is used on the i.MX6. > > Suggested-by: Saravana Kannan > Signed-off-by: Sebastian Reichel > --- > Documentation/devicetree/bindings/rtc/rtc-m41t80.txt | 9 + > dr

Re: Closed source userspace graphics drivers with an open source kernel component

2010-07-01 Thread Saravana Kannan
Dave Airlie wrote: This is more about initial development stages. We maintain kernel API/ABI for all in-tree drivers, however before we put a driver into mainline, we usually need to redo the crazy interfaces that vendors have come up with. Like 32/64 alignment, passing userspace addresses into t

Closed source userspace graphics drivers with an open source kernel component

2010-07-01 Thread Saravana Kannan
Dave Airlie wrote: > This is more about initial development stages. We maintain kernel > API/ABI for all in-tree drivers, however before we put a driver into > mainline, we usually need to redo the crazy interfaces that vendors > have come up with. Like 32/64 alignment, passing userspace addresses