Re: [PATCH] fbcon: Increase maximum font width x height to 64 x 64

2024-03-15 Thread Samuel Thibault
Hello, Helge Deller, le ven. 15 mars 2024 10:35:40 +0100, a ecrit: > You should have marked this patch with "v2"... The actual changes were exactly the same. > On 3/13/24 17:59, Samuel Thibault wrote: > > This remains relatively simple by just enlarging integers. >

[PATCHv2] fbcon: Increase maximum font width x height to 64 x 128

2024-03-15 Thread Samuel Thibault
By using bitmaps we actually support whatever size we would want, but the console currently limits fonts to 64x128 (which gives 60x16 text on 4k screens), so we don't need more for now, and we can easily increase later. Signed-off-by: Samuel Thibault --- Difference from v1: - use a b

Re: [PATCH] fbcon: Increase maximum font width x height to 64 x 64

2024-03-13 Thread Samuel Thibault
Luca Ceresoli, le mer. 13 mars 2024 17:45:31 +0100, a ecrit: > This patch is clearly not formatted according to the standard format > and it does not apply with 'git am'. (Note: the failure of application was not related to the formatting at all, but just a little fuzz for the static word in stat

[PATCH] fbcon: Increase maximum font width x height to 64 x 64

2024-03-13 Thread Samuel Thibault
This remains relatively simple by just enlarging integers. It wouldn't be that simple to get to the console's 64x128 maximum, as it would require 128b integers. Signed-off-by: Samuel Thibault --- drivers/video/fbdev/core/fbcon.c | 17 ++--- include/linux/fb.h

Re: [PATCH] fbcon: Increase maximum font width x height to 64 x 64

2024-03-13 Thread Samuel Thibault
Luca Ceresoli, le mer. 13 mars 2024 17:45:31 +0100, a ecrit: > Using 'git format-patch' and 'git send-email' is *very* recommended as > it will take care of all the formatting for you. It's quite a pitty that git cannot simply consume the output of diff. Now I'll have to download 8GB of linux tre

[PATCH] fbcon: Increase maximum font width x height to 64 x 64

2024-03-12 Thread Samuel Thibault
This remains relatively simple by just enlarging integers. It wouldn't be that simple to get to the console's 64x128 maximum, as it would require 128b integers. Signed-off-by: Samuel Thibault Index: linux-6.4/drivers/video/fbdev/co

[PATCH] VT: Protect KD_FONT_OP_GET_TALL from unbound access

2023-03-06 Thread Samuel Thibault
ch) call (since we already prevent loading a font larger than that), and c = (font.width+7)/8 * vpitch * font.charcount will always remain below max_font_size. Fixes: 24d69384bcd3 ("VT: Add KD_FONT_OP_SET/GET_TALL operations") Reported-by: syzbot+3af17071816b61e80...@syzkaller.appspotmai

[PATCHv2] fbcon: Check font dimension limits

2023-01-29 Thread Samuel Thibault
eported-by: Sanan Hasanov Signed-off-by: Samuel Thibault Fixes: 2d2699d98492 ("fbcon: font setting should check limitation of driver") Cc: sta...@vger.kernel.org --- v1 -> v2: - Use BIT macro instead of fixing bit test by hand. - Add Fixes and Cc: stable headers. Index: linux-6.0/d

Re: [PATCH] fbcon: Check font dimension limits

2023-01-29 Thread Samuel Thibault
Jiri Slaby, le jeu. 26 janv. 2023 10:02:55 +0100, a ecrit: > On 26. 01. 23, 1:49, Samuel Thibault wrote: > > Index: linux-6.0/drivers/video/fbdev/core/fbcon.c > > === > > --- linux-6.0.orig/drivers/vid

Re: [PATCH] fbcon: Check font dimension limits

2023-01-29 Thread Samuel Thibault
Greg KH, le jeu. 26 janv. 2023 08:43:02 +0100, a ecrit: > On Thu, Jan 26, 2023 at 01:49:12AM +0100, Samuel Thibault wrote: > > blit_x and blit_y are uint32_t, so fbcon currently cannot support fonts > > larger than 32x32. > > "u32" you mean, right? Right :)

[PATCH] fbcon: Check font dimension limits

2023-01-26 Thread Samuel Thibault
Reported-by: Sanan Hasanov Signed-off-by: Samuel Thibault Index: linux-6.0/drivers/video/fbdev/core/fbcon.c === --- linux-6.0.orig/drivers/video/fbdev/core/fbcon.c +++ linux-6.0/drivers/video/fbdev/core/fbcon.c @@ -2489,9 +2489,12

Re: [PATCH] fbcon: Check font dimension limits

2023-01-26 Thread Samuel Thibault
(FYI, the UB was already a problem before my big-font patch submission, the checks I add here are already making sense in previous versions anyway) Samuel Thibault, le jeu. 26 janv. 2023 01:49:12 +0100, a ecrit: > blit_x and blit_y are uint32_t, so fbcon currently cannot support fonts >

[i915] assert_device_not_suspended

2015-04-14 Thread Samuel Thibault
I forgot to mention that this is linux 4.0.0 Samuel

[i915] assert_device_not_suspended

2015-04-14 Thread Samuel Thibault
Hello, Yesterday, as usual I ran xlock before the night. In the morning, I typed a key to wake it up, it didn't. I had to reboot. I could however read in the logs: Apr 14 05:00:13 type kernel: [33976.116204] WARNING: CPU: 2 PID: 63 at drivers/gpu/drm/i915/intel_uncore.c:69 assert_device_not_susp

[REGRESSION FIXED] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2013-01-22 Thread Samuel Thibault
Hello, Samuel Thibault, le Thu 05 Jan 2012 10:53:01 +0100, a ?crit : > Samuel Thibault, le Thu 05 Jan 2012 03:16:46 +0100, a ?crit : > > Samuel Thibault, le Fri 16 Sep 2011 18:30:50 +0200, a ?crit : > > > Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a ?crit : > > &g

Re: [REGRESSION FIXED] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2013-01-22 Thread Samuel Thibault
Hello, Samuel Thibault, le Thu 05 Jan 2012 10:53:01 +0100, a écrit : > Samuel Thibault, le Thu 05 Jan 2012 03:16:46 +0100, a écrit : > > Samuel Thibault, le Fri 16 Sep 2011 18:30:50 +0200, a écrit : > > > Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a écrit : > > &g

Re: [REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2012-01-05 Thread Samuel Thibault
Samuel Thibault, le Thu 05 Jan 2012 03:16:46 +0100, a écrit : > Samuel Thibault, le Fri 16 Sep 2011 18:30:50 +0200, a écrit : > > Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a écrit : > > > On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault > > > wrote: >

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2012-01-05 Thread Samuel Thibault
Samuel Thibault, le Thu 05 Jan 2012 03:16:46 +0100, a ?crit : > Samuel Thibault, le Fri 16 Sep 2011 18:30:50 +0200, a ?crit : > > Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a ?crit : > > > On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault > > ens-lyon.org> wr

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2012-01-05 Thread Samuel Thibault
Samuel Thibault, le Fri 16 Sep 2011 18:30:50 +0200, a ?crit : > Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a ?crit : > > On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault > ens-lyon.org> wrote: > > > > > At home only. At work, with a different VGA scree

Re: [REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2012-01-04 Thread Samuel Thibault
Samuel Thibault, le Fri 16 Sep 2011 18:30:50 +0200, a écrit : > Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a écrit : > > On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault > > wrote: > > > > > At home only. At work, with a different VGA screen, I&#

Re: [REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-18 Thread Samuel Thibault
Samuel Thibault, le Fri 16 Sep 2011 18:30:50 +0200, a écrit : > Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a écrit : > > On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault > > wrote: > > > > > At home only. At work, with a different VGA screen, I&#

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-16 Thread Samuel Thibault
Samuel Thibault, le Fri 16 Sep 2011 18:30:50 +0200, a ?crit : > Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a ?crit : > > On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault > ens-lyon.org> wrote: > > > > > At home only. At work, with a different VGA scree

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-16 Thread Samuel Thibault
Keith Packard, le Thu 15 Sep 2011 09:22:48 -0500, a ?crit : > On Thu, 15 Sep 2011 10:12:59 +0200, Samuel Thibault ens-lyon.org> wrote: > > > At home only. At work, with a different VGA screen, I'm still getting > > the issue. > > You're still having a prob

Re: [REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-15 Thread Samuel Thibault
Keith Packard, le Thu 15 Sep 2011 00:43:36 -0500, a écrit : > On Thu, 15 Sep 2011 01:27:17 +0200, Samuel Thibault > wrote: > Non-text part: multipart/mixed > > Hello, > > > > I'm trying to upgrade from 3.0 to 3.1-rcsomething on a DELL latitude > > E6420

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-15 Thread Samuel Thibault
Samuel Thibault, le Thu 15 Sep 2011 09:41:06 +0200, a ?crit : > Keith Packard, le Thu 15 Sep 2011 00:43:36 -0500, a ?crit : > > On Thu, 15 Sep 2011 01:27:17 +0200, Samuel Thibault > ens-lyon.org> wrote: > > Non-text part: multipart/mixed > > > I'm trying to upg

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-15 Thread Samuel Thibault
Keith Packard, le Thu 15 Sep 2011 00:43:36 -0500, a ?crit : > On Thu, 15 Sep 2011 01:27:17 +0200, Samuel Thibault ens-lyon.org> wrote: > Non-text part: multipart/mixed > > Hello, > > > > I'm trying to upgrade from 3.0 to 3.1-rcsomething on a DELL latitude > >

[REGRESSION] i915 KMS dual head broken on DELL latitude E6420 in 3.1-rc*

2011-09-15 Thread Samuel Thibault
Hello, I'm trying to upgrade from 3.0 to 3.1-rcsomething on a DELL latitude E6420, but dual head is broken. Here is the scenario: - Turn computer on with VGA1 connected. Both LVDS1 and VGA1 show the text console fine. - Start X. VGA1 shows X fine, but LVDS1 (1600x900 resolution) shows an odd