[PATCH v2 1/2] drm/radeon: fix bad DMA from INTERRUPT_CNTL2

safe. Fixes: d8f60cfc9345 ("drm/radeon/kms: Add support for interrupts on r6xx/r7xx chips (v3)") Fixes: 25a857fbe973 ("drm/radeon/kms: add support for interrupts on SI") Fixes: a59781bbe528 ("drm/radeon: add support for interrupts on CIK (v5)") Signed-off-by: Sam

[PATCH v2 2/2] drm/amdgpu: fix bad DMA from INTERRUPT_CNTL2

safe. Fixes: 27ae10641e9c ("drm/amdgpu: add interupt handler implementation for si v3") Signed-off-by: Sam Bobroff --- v2 * New in this version. drivers/gpu/drm/amd/amdgpu/si_ih.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_ih.c

[PATCH v2 0/2] fix bad DMA from INTERRUPT_CNTL2

DMA from INTERRUPT_CNTL2 - Split amdgpu changes into separate patch. Patch 2/2 (new in this version): drm/amdgpu: fix bad DMA from INTERRUPT_CNTL2 Patch set v1: Patch 1/1: drm/radeon drm/amdgpu: fix bad DMA from INTERRUPT_CNTL2 Sam Bobroff (2): drm/radeon: fix bad DMA from INTERRUPT_CNTL2 drm

Re: [PATCH 1/1] drm/radeon drm/amdgpu: fix bad DMA from INTERRUPT_CNTL2

On Fri, Nov 15, 2019 at 09:58:18AM -0500, Alex Deucher wrote: > On Thu, Nov 14, 2019 at 9:05 PM Sam Bobroff wrote: > > > > The INTERRUPT_CNTL2 register expects a valid DMA address, but is > > currently set with a GPU MC address. This can cause problems on > > system

[PATCH 1/1] drm/radeon drm/amdgpu: fix bad DMA from INTERRUPT_CNTL2

e9c ("drm/amdgpu: add interupt handler implementation for si v3") Signed-off-by: Sam Bobroff --- A couple of notes: - Initial discussion: https://lists.freedesktop.org/archives/dri-devel/2019-November/244090.html - I have only tested the case that uses r600_irq_init(), but they are all ver

Re: [PATCH RFC 1/1] drm/radeon: fix bad DMA from INTERRUPT_CNTL2

On Thu, Nov 14, 2019 at 12:05:19AM -0500, Alex Deucher wrote: > On Wed, Nov 13, 2019 at 9:53 PM Sam Bobroff wrote: > > > > Currently, binding the radeon driver to a Radeon FirePro (PCI > > 1002:68f2) that has been passed through to a guest on a Power8 machine > >

[PATCH RFC 1/1] drm/radeon: fix bad DMA from INTERRUPT_CNTL2

Currently, binding the radeon driver to a Radeon FirePro (PCI 1002:68f2) that has been passed through to a guest on a Power8 machine causes a bad DMA read which causes the device to be frozen, leading to the driver failing to bind and other problems. The bad DMA is to the address written into the

Re: [EXTERNAL] Re: [PATCH 1/1] drm/bochs: Fix connector leak during driver unload

On Tue, May 21, 2019 at 10:10:29AM +0200, Gerd Hoffmann wrote: > Hi, > > The bug is in the driver, so ... > > > Bisecting the issue for commits to drivers/gpu/drm/bochs/ points to: > > 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up > > helpers.") > > ... but the issue also

[PATCH 1/1] drm/bochs: Fix connector leak during driver unload

commits. Both together are required to cause it: Fixes: 846c7dfc1193 ("drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2.") Fixes: 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up helpers.") Signed-off-by: Sam Bobroff --- Hell

[PATCH v2 2/2] drm/ast: Fix connector leak during driver unload

When unloading the ast driver, a warning message is printed by drm_mode_config_cleanup() because a reference is still held to one of the drm_connector structs. Correct this by calling drm_crtc_force_disable_all() in ast_fbdev_destroy(). Signed-off-by: Sam Bobroff --- v2 * Changed to use

[PATCH v2 1/2] drm/ast: Fix incorrect free on ioregs

Try to use MMIO registers when PIO isn't supported") Signed-off-by: Sam Bobroff --- drivers/gpu/drm/ast/ast_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index dac355812adc..373700c05a00 100644

[PATCH v2 0/2] Two AST driver fixes

isable_all(). Patch set v1: Patch 1/2: drm/ast: Fix incorrect free on ioregs Patch 2/2: drm/ast: Fix connector leak during driver unload Sam Bobroff (2): drm/ast: Fix incorrect free on ioregs drm/ast: Fix connector leak during driver unload drivers/gpu/drm/ast/ast_fb.c | 1 + drivers/gpu/drm/ast/

Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

On Fri, Nov 30, 2018 at 10:41:08AM +0100, Daniel Vetter wrote: > On Fri, Nov 30, 2018 at 11:17:51AM +1100, Sam Bobroff wrote: > > On Thu, Nov 29, 2018 at 09:56:53AM +0100, Daniel Vetter wrote: > > > On Thu, Nov 29, 2018 at 9:05 AM Sam Bobroff > > > wrote: > > &g

Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

On Thu, Nov 29, 2018 at 09:56:53AM +0100, Daniel Vetter wrote: > On Thu, Nov 29, 2018 at 9:05 AM Sam Bobroff wrote: > > > > On Thu, Nov 29, 2018 at 09:40:53AM +1000, Dave Airlie wrote: > > > On Mon, 5 Nov 2018 at 15:59, Sam Bobroff wrote: > > > > > > &g

Re: [PATCH 2/2] drm/ast: Fix connector leak during driver unload

On Thu, Nov 29, 2018 at 09:40:53AM +1000, Dave Airlie wrote: > On Mon, 5 Nov 2018 at 15:59, Sam Bobroff wrote: > > > > When unloading the ast driver, a warning message is printed by > > drm_mode_config_cleanup() because a reference is still held to one of > >

[PATCH 1/2] drm/ast: Fix incorrect free on ioregs

Try to use MMIO registers when PIO isn't supported") Signed-off-by: Sam Bobroff --- drivers/gpu/drm/ast/ast_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index dac355812adc..373700c05a00 100644

[PATCH 0/2] Two AST driver fixes

ffer_remove(), that seems to be be necessary because drm_framebuffer_remove() is expecting the framebuffer to be dynamically allocated (but the AST driver directly contains it) (I saw some references to this being legacy behaviour). Cheers, Sam. Sam Bobroff (2): drm/ast: Fix incorrect free

[PATCH 2/2] drm/ast: Fix connector leak during driver unload

When unloading the ast driver, a warning message is printed by drm_mode_config_cleanup() because a reference is still held to one of the drm_connector structs. Correct this by calling drm_framebuffer_remove() in ast_fbdev_destroy(). Signed-off-by: Sam Bobroff --- drivers/gpu/drm/ast/ast_fb.c