ср, 8 июн. 2022 г. в 11:17, Maxime Ripard :
>
> On Mon, Jun 06, 2022 at 01:16:06PM +0300, Roman Stratiienko wrote:
> > вс, 5 июн. 2022 г. в 23:23, Jernej Škrabec :
> > >
> > > Dne nedelja, 05. junij 2022 ob 11:40:18 CEST je Roman Stratiienko
> > > napis
Hi Maxime,
пн, 6 июн. 2022 г. в 12:22, Maxime Ripard :
>
> On Mon, Jun 06, 2022 at 11:20:06AM +0200, Maxime Ripard wrote:
> > On Mon, Jun 06, 2022 at 11:17:20AM +0300, Roman Stratiienko wrote:
> > > Hello Jernej,
> > >
> > > Thank you for having a look.
Hi,
вс, 5 июн. 2022 г. в 23:23, Jernej Škrabec :
>
> Dne nedelja, 05. junij 2022 ob 11:40:18 CEST je Roman Stratiienko napisal(a):
> > Otherwise alpha value is discarded, resulting incorrect pixel
> > apperance on the display.
> >
> > This also fixes missing transpar
Hello Jernej,
Thank you for having a look.
вс, 5 июн. 2022 г. в 23:37, Jernej Škrabec :
>
> Dne nedelja, 05. junij 2022 ob 17:47:31 CEST je Roman Stratiienko napisal(a):
> > Allwinner DE2 and DE3 hardware support 3 pixel blend modes:
> > "None", "Pre-multiplied&q
ture changes. It must be set to true for cases when more
than 1 overlay layer is used within a channel and at least one of the
overlay layers within a group uses premultiplied blending mode.
Test:
Manually tested all the modes using kmsxx python wrapper with and
without 'force_premulti
: Roman Stratiienko
---
Changelog:
V2: Added code hunk missing in v1
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 5 +++--
drivers/gpu/drm/sun4i/sun8i_mixer.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c
b/drivers/gpu/drm/sun4i/sun8i_mixer.c
Hi Maxime,
пт, 3 июн. 2022 г. в 11:24, Maxime Ripard :
>
> Hi,
>
> On Thu, Jun 02, 2022 at 06:01:18PM +, Roman Stratiienko wrote:
> > According to DE2.0/DE3.0 manual VI scaler enable register is double
> > buffered, but de facto it doesn't, or the hardware has the
Hi Ondrej,
пт, 3 июн. 2022 г. в 00:55, Ondřej Jirman :
>
> Hi Roman,
>
> On Thu, Jun 02, 2022 at 06:01:18PM +, Roman Stratiienko wrote:
> > According to DE2.0/DE3.0 manual VI scaler enable register is double
> > buffered, but de facto it doesn't, or the hardwar
github.com/GloDroid/glodroid_tests/issues/4
Signed-off-by: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_mixer.c| 12
drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 4 +++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c
b/drivers/gpu
: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 ++
drivers/gpu/drm/sun4i/sun8i_mixer.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c
b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index 6b1711a9a71f..71ab0a00b4de 100644
--- a/drivers/gpu/drm/sun4i
Hi Maxime,
пн, 30 мая 2022 г. в 16:22, Maxime Ripard :
>
> Hi Roman,
>
> On Wed, May 25, 2022 at 11:54:45AM +, Roman Stratiienko wrote:
> > By this commit 2 related issues are solved:
> >
> > Issue #1. Corruption in blend route/enable register:
> >
&
ср, 25 мая 2022 г. в 18:14, Jernej Škrabec :
>
> Dne sreda, 25. maj 2022 ob 16:55:56 CEST je Roman Stratiienko napisal(a):
> > вт, 24 мая 2022 г. в 22:14, Jernej Škrabec :
> > >
> > > Dne torek, 24. maj 2022 ob 19:14:35 CEST je Roman Stratiienko napisal(a):
> >
вт, 24 мая 2022 г. в 22:14, Jernej Škrabec :
>
> Dne torek, 24. maj 2022 ob 19:14:35 CEST je Roman Stratiienko napisal(a):
> > By the way, not related to this issue:
> >
> > I cherry-picked
> > https://patchwork.kernel.org/project/dri-devel/patch/20220424162633.12369-
вт, 24 мая 2022 г. в 22:13, Jernej Škrabec :
>
> Don't top post, it's annoying and against rules.
>
> Dne torek, 24. maj 2022 ob 19:10:06 CEST je Roman Stratiienko napisal(a):
> > Please draft a test for the zpos issue you're mentioning.
> >
> > It'
planes for crtc.
2. Use this number instead of zpos to disable unused blend pipes.
Signed-off-by: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_mixer.h| 2 +
drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 60 +-
drivers/gpu/drm/sun4i/sun8i_ui_layer.h | 2 +
dr
By the way, not related to this issue:
I cherry-picked
https://patchwork.kernel.org/project/dri-devel/patch/20220424162633.12369-9-sam...@sholland.org/
and got a blank FB console on OPI3.
Can you check it please?
Regards,
Roman
вт, 24 мая 2022 г. в 20:10, Roman Stratiienko :
>
> Please
17:31:13 CEST je Roman Stratiienko napisal(a):
> > NAK for this. Further testing showed such an approach is not reliable
> > due to .atomic_update() callback called only in case planes have some
> > changes.
>
> Additionally, I think it would be better to fix underlaying zpos
NAK for this. Further testing showed such an approach is not reliable
due to .atomic_update() callback called only in case planes have some
changes.
вт, 24 мая 2022 г. в 16:52, Roman Stratiienko :
>
> Corruption happens when plane zpos is updated
>
> Example scenario:
>
> Ini
the planes we are ending up with BLD_EN[2]=0,
which makes this channel disabled.
To fix this issue, clear BLEND registers before updating the planes
and do not clear the old state while processing every plane.
Signed-off-by: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_mixer.c
Hi Jernej,
вт, 31 авг. 2021 г. в 19:52, Jernej Škrabec :
>
> Hi!
>
> Dne petek, 27. avgust 2021 ob 15:16:03 CEST je Roman Stratiienko napisal(a):
> > +CC: jernej.skra...@gmail.com
> >
> > пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko :
> > >
> > >
Hello Jernej,
During local testing I faced an issue where YV12 buffers are displayed
all in blue.
Issue can be fixed by reverting:
ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")
Could you have a look please?
Best regards,
Roman Stratiienko
+CC: jernej.skra...@gmail.com
пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko :
>
> Hello Jernej,
>
> During local testing I faced an issue where YV12 buffers are displayed
> all in blue.
>
> Issue can be fixed by reverting:
> ea067aee45a8 ("drm/sun4i: de2/de3:
Create callback to allow updating engine's registers on mode change.
Signed-off-by: Roman Stratiienko
Reviewed-by: Jernej Skrabec
---
drivers/gpu/drm/sun4i/sun4i_crtc.c | 3 +++
drivers/gpu/drm/sun4i/sunxi_engine.h | 12
2 files changed, 15 insertions(+)
diff --git a/dr
+CC: jernej.skra...@gmail.com
пт, 28 мая 2021 г. в 23:31, Roman Stratiienko :
>
> Fixes corrupted display picture when primary plane isn't full-screen.
>
> Signed-off-by: Roman Stratiienko
> ---
> drivers/gpu/drm/sun4i/sun8i_mixer.c| 28
&
This patchset fixes corrupted display picture when primary plane isn't
full-screen.
Please review/merge.
v2:
- Split commit in 2 parts
- Add Fixes line to the commit message
v3:
- Address review comments of v2 + removed 3 local varibles
- Change 'Fixes' line
v4:
Resend (author's email changed).
Fixes corrupted display picture when primary plane isn't full-screen.
Signed-off-by: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_mixer.c| 28
drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 30 --
2 files changed, 28 insertions(+
Please review/merge.
v2:
Initial patch
v3:
- Skip adding & applying alpha property if VI count > 1 (v3s case)
v4:
Resend (author's email changed)
v5:
Resend
drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 29 +
drivers/gpu/drm/sun4i/sun8i_ui_layer.h | 5 +
drivers/gpu
2 VI planes.
Signed-off-by: Roman Stratiienko
Reviewed-by: Jernej Skrabec
---
drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 48 +-
drivers/gpu/drm/sun4i/sun8i_vi_layer.h | 11 ++
2 files changed, 51 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/sun4i
DE2.0 and DE3.0 UI layers supports plane-global alpha channel.
Add alpha property to the DRM plane and connect it to the
corresponding registers in mixer.
Signed-off-by: Roman Stratiienko
Reviewed-by: Jernej Skrabec
---
drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 29
ср, 2 сент. 2020 г. в 19:46, Jernej Škrabec :
>
> Dne sreda, 02. september 2020 ob 09:01:17 CEST je Roman Stratiienko
> napisal(a):
> > ср, 2 сент. 2020 г. в 00:58, Jernej Skrabec :
> > > Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode
> > >
b ("drm/sun4i: de2: csc_mode in de2 format struct is mostly
> redundant")
> Reported-by: Roman Stratiienko
> Signed-off-by: Jernej Skrabec
> ---
> drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers
Fixes: e1ef9006663b ("drm/sun4i: Wire in DE2 YUV support")
Signed-off-by: Roman Stratiienko
---
CC: meg...@megous.com
CC: jernej.skra...@gmail.com
CC: linux-su...@googlegroups.com
CC: dri-devel@lists.freedesktop.org
CC: linux-arm-ker...@lists.infradead.org
CC: linux-ker...@vger.kern
0 UI and DE3.0 VI overlay channels to use premultiply format.
Mark all blending pipes as premultiply except DE2.0 VI plane.
4. If DRM plane uses coverage blending format, set blending mode register
to convert it to premultiply.
Signed-off-by: Roman Stratiienko
--
v4:
- Initial version (De
ending step and mix PIPE0 with
background, but it is not supported by the hardware.
Use premultiplied alpha buffer of PIPE0 overlay channel as is.
In this case we got same effect as mixing PIPE0 with black background.
Signed-off-by: Roman Stratiienko
---
v4:
- Initial version, depends on other u
Patches 1-2 already reviewed and ready to be applied.
Patch 4 is RFC and require more testing on real hardware.
[PATCH v4 1/4] drm/sun4i: Add alpha property for sun8i UI layer
[PATCH v4 2/4] drm/sun4i: Add alpha property for sun8i and sun50i VI
[PATCH v4 3/4] drm/sun4i: Add support for premulti/c
2 VI planes.
Signed-off-by: Roman Stratiienko
Reviewed-by: Jernej Skrabec
---
v2: Initial version by mistake
v3:
- Skip adding & applying alpha property if VI count > 1
V4:
- Changed author e-mail address to avoid mail rejecting
- Picked reviewed-by line
---
drivers/gpu/dr
DE2.0 and DE3.0 UI layers supports plane-global alpha channel.
Add alpha property to the DRM plane and connect it to the
corresponding registers in mixer.
Signed-off-by: Roman Stratiienko
Reviewed-by: Jernej Skrabec
---
v2: Initial commit by mistake
v3:
- Picked `reviewed-by` line
V4:
- Changed
чт, 2 янв. 2020 г., 09:42 Jernej Škrabec :
>
> Hi!
>
> Dne sreda, 01. januar 2020 ob 21:47:50 CET je
> roman.stratiie...@globallogic.com napisal(a):
> > From: Roman Stratiienko
> >
> > According to DRM documentation the only difference between PRIMARY
> > a
чт, 2 янв. 2020 г., 12:08 Maxime Ripard :
>
> Hi,
>
> On Wed, Jan 01, 2020 at 10:47:50PM +0200, roman.stratiie...@globallogic.com
> wrote:
> > From: Roman Stratiienko
> >
> > According to DRM documentation the only difference between PRIMARY
> > and OV
From: Roman Stratiienko
DE2.0 and DE3.0 UI layers supports plane-global alpha channel.
Add alpha property to the DRM plane and connect it to the
corresponding registers in mixer.
Signed-off-by: Roman Stratiienko
Reviewed-by: Jernej Skrabec
---
v2: Initial commit by mistake
v3:
- Picked
From: Roman Stratiienko
DE3.0 VI layers supports plane-global alpha channel.
DE2.0 FCC block have GLOBAL_ALPHA register that can be used as alpha source
for blender.
Add alpha property to the DRM plane and connect it to the
corresponding registers in the mixer.
Do not add alpha property for
From: Roman Stratiienko
According to DRM documentation the only difference between PRIMARY
and OVERLAY plane is that each CRTC must have PRIMARY plane and
OVERLAY are optional.
Allow PRIMARY plane to have dimension different from full-screen.
Fixes: 5bb5f5dafa1a ("drm/sun4i: Reorgani
From: Roman Stratiienko
Create callback to update engine's registers on mode change.
Signed-off-by: Roman Stratiienko
Reviewed-by: Jernej Skrabec
---
v2:
- Split commit in 2 parts.
- Add description to mode_set callback
- Dropped 1 line from sun4i_crtc_mode_set_nofb()
- Add s
Please HOLD this until v3.
I forgot about blender channel frame coords that updated according to
zpos and can have gap between channels.
I will also try to simplify this patch.
On Sun, Dec 29, 2019 at 6:28 PM wrote:
>
> From: Roman Stratiienko
>
> To set blending channel order regis
False alarm. Since DRM sets normalized ZPOS there should be no gaps
and all should work as expected.
On Mon, Dec 30, 2019 at 1:25 PM Roman Stratiienko
wrote:
>
> Please HOLD this until v3.
> I forgot about blender channel frame coords that updated according to
> zpos and can have
From: Roman Stratiienko
According to DRM documentation the only difference between PRIMARY
and OVERLAY plane is that each CRTC must have PRIMARY plane and
OVERLAY are optional.
Allow PRIMARY plane to have dimension different from full-screen.
Fixes: 90212fffa4fc ("drm/sun4i: Use v
From: Roman Stratiienko
DE3.0 VI layers supports plane-global alpha channel.
DE2.0 FCC block have GLOBAL_ALPHA register that can be used as alpha source
for blender.
Add alpha property to the DRM plane and connect it to the
corresponding registers in the mixer.
Signed-off-by: Roman Stratiienko
From: Roman Stratiienko
DE2.0 and DE3.0 UI layers supports plane-global alpha channel.
Add alpha property to the DRM plane and connect it to the
corresponding registers in mixer.
Signed-off-by: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 29
From: Roman Stratiienko
To set blending channel order register software needs to know state and
position of each channel, which impossible at plane commit stage.
Move this procedure to atomic_flush stage, where all necessary information
is available.
Fixes: f88c5ee77496 ("drm/sun4i: Impl
From: Roman Stratiienko
Create callback to update engine's registers on mode change.
Signed-off-by: Roman Stratiienko
---
v2:
- Split commit in 2 parts.
- Add description to mode_set callback
- Dropped 1 line from sun4i_crtc_mode_set_nofb()
- Add struct drm_display_mode declaration (fix
From: Roman Stratiienko
At system start blink of u-boot ghost framebuffer can be observed.
Fix it.
Fixes: 9d75b8c0b999 ("drm/sun4i: add support for Allwinner DE2 mixers")
Signed-off-by: Roman Stratiienko
Reviewed-by: Jernej Skrabec
---
v2:
- Picked 'Reviewed-by' line
Hello Jernej,
Thank you for review.
On Sun, Dec 29, 2019 at 11:40 AM Jernej Škrabec wrote:
>
> Hi!
>
> Dne sobota, 28. december 2019 ob 21:28:17 CET je
> roman.stratiie...@globallogic.com napisal(a):
> > From: Roman Stratiienko
> >
> > To set blending channel
From: Roman Stratiienko
According to DRM documentation the only difference between PRIMARY
and OVERLAY plane is that each CRTC must have PRIMARY plane and
OVERLAY are optional.
Allow PRIMARY plane to have dimension different from full-screen.
Signed-off-by: Roman Stratiienko
---
drivers/gpu
be much harder for me.
On Sun, Dec 29, 2019 at 3:02 PM Jernej Škrabec wrote:
>
> Dne nedelja, 29. december 2019 ob 13:47:38 CET je Roman Stratiienko
> napisal(a):
> > On Sun, Dec 29, 2019 at 2:18 PM Jernej Škrabec
> wrote:
> > > Dne nedelja, 29. december 2019 ob 13:08:
From: Roman Stratiienko
At system start blink of u-boot ghost framebuffer can be observed.
Fix it.
Signed-off-by: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_mixer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c
b/drivers/gpu/drm/sun4i
From: Roman Stratiienko
To set blending channel order register software needs to know state and
position of each channel, which impossible at plane commit stage.
Move this procedure to atomic_flush stage, where all necessary information
is available.
Signed-off-by: Roman Stratiienko
From: Roman Stratiienko
Screen composition that requires dynamic layout modification,
especially scaling is corrupted when layout changes.
For example if one of the layer scales down, misaligned lines can be
observed, and dynamic increasing of destination area makes mixer to hang
and draw
On Sun, Dec 29, 2019 at 2:18 PM Jernej Škrabec wrote:
>
> Dne nedelja, 29. december 2019 ob 13:08:19 CET je Roman Stratiienko
> napisal(a):
> > Hello Jernej,
> >
> > Thank you for review.
> >
> > On Sun, Dec 29, 2019 at 11:40 AM Jernej Škrabec
> w
On Thu, Sep 19, 2019 at 9:53 PM Jernej Škrabec wrote:
>
> Hi!
>
> Dne sreda, 18. september 2019 ob 13:05:41 CEST je
> roman.stratiie...@globallogic.com napisal(a):
> > From: Roman Stratiienko
> >
> > According to Allwinner DE2.0 Specification REV 1.0, vi layer
overlays
could be a universal solution, but I have not sufficient knowledge in
KMS to bring-up this idea.
On Fri, Sep 20, 2019 at 9:18 AM Maxime Ripard wrote:
>
> Hi,
>
> On Thu, Sep 19, 2019 at 11:03:26PM +0300, Roman Stratiienko wrote:
> > Actually, I beleive this is True solution,
On Fri, Sep 20, 2019 at 9:20 AM Maxime Ripard wrote:
>
> On Thu, Sep 19, 2019 at 08:53:10PM +0200, Jernej Škrabec wrote:
> > Dne sreda, 18. september 2019 ob 13:05:41 CEST je
> > roman.stratiie...@globallogic.com napisal(a):
> > > From: Roman Stratiienko
> > >
37:03PM +0300, roman.stratiie...@globallogic.com
> wrote:
> > > From: Roman Stratiienko
> > >
> > > DE2.0 blender does not take into the account alpha channel of vi layer.
> > > Thus makes overlaying of this layer totally opaque.
> > > Using vi layer as bottom sol
From: Roman Stratiienko
DE2.0 blender does not take into the account alpha channel of vi layer.
Thus makes overlaying of this layer totally opaque.
Using vi layer as bottom solves this issue.
Tested on Android.
Signed-off-by: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 33
ayers on top of the video layers.
чт, 19 сент. 2019 г., 21:15 Jernej Škrabec :
> Dne četrtek, 19. september 2019 ob 19:17:54 CEST je Maxime Ripard
> napisal(a):
> > Hi,
> >
> > On Thu, Sep 19, 2019 at 03:37:03PM +0300,
> roman.stratiie...@globallogic.com
> w
From: Roman Stratiienko
According to Allwinner DE2.0 Specification REV 1.0, vi layer supports the
following pixel formats: ABGR_, ARGB_, BGRA_, RGBA_
Signed-off-by: Roman Stratiienko
---
drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 4
1 file changed, 4 insertions(+)
diff
65 matches
Mail list logo
