Re: [PATCH v2 1/3] drm: Create an app info option for wedge events

2025-05-12 Thread Rodrigo Vivi
rs/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c > index c02c4c4e9412..f329613e061f 100644 > --- a/drivers/gpu/drm/xe/xe_device.c > +++ b/drivers/gpu/drm/xe/xe_device.c > @@ -1168,7 +1168,8 @@ void xe_device_declare_wedged(struct xe_device *xe) > > /* Notif

[PULL] drm-intel-next

2025-05-08 Thread Rodrigo Vivi
i915/display: Add link rate and lane count to i915_display_info Nemesa Garg (1): drm/i915/display: Implement wa_14024400148 Rodrigo Vivi (2): drm/{i915,xe}: Move intel_pch under display drm/i915/display: Convert intel_pch towards intel_display Ville Syrjälä (6): dr

Re: [RFC 9/9] {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl

2025-05-07 Thread Rodrigo Vivi
On Tue, May 06, 2025 at 03:13:53PM -0300, Jason Gunthorpe wrote: Hi Jason, first of all, thank you so much for creating this and for the review here. > On Tue, Apr 29, 2025 at 09:39:56PM +0530, Badal Nilawar wrote: > > > diff --git a/drivers/gpu/drm/xe/xe_pcode_fwctl.c > > b/drivers/gpu/drm/xe

Re: [PATCH v24 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-05-07 Thread Rodrigo Vivi
On Wed, May 07, 2025 at 03:57:26PM +, Jonathan Cavitt wrote: > Add support for userspace to request a list of observed faults > from a specified VM. > > v2: > - Only allow querying of failed pagefaults (Matt Brost) > > v3: > - Remove unnecessary size parameter from helper function, as it >

Re: [PATCH v24 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-05-07 Thread Rodrigo Vivi
On Wed, May 07, 2025 at 03:57:24PM +, Jonathan Cavitt wrote: > Add initial declarations for the drm_xe_vm_get_property ioctl. > > v2: > - Expand kernel docs for drm_xe_vm_get_property (Jianxun) > > v3: > - Remove address type external definitions (Jianxun) > - Add fault type to xe_drm_fault s

Re: [PATCH v3] drm: Fix potential overflow issue in event_string array

2025-05-02 Thread Rodrigo Vivi
On Thu, May 01, 2025 at 03:22:25PM +0300, Raag Jadav wrote: > On Wed, Apr 09, 2025 at 09:24:41AM +0300, Raag Jadav wrote: > > On Wed, Apr 09, 2025 at 09:46:33AM +0800, jiangf...@kylinos.cn wrote: > > > From: Feng Jiang > > > > > > When calling scnprintf() to append recovery method to event_string

Re: [RFC 9/9] {fwctl,drm}/xe/pcode: Introduce xe_pcode_fwctl

2025-05-01 Thread Rodrigo Vivi
On Tue, Apr 29, 2025 at 09:39:56PM +0530, Badal Nilawar wrote: > From: Rodrigo Vivi > > Xe PCODE FWCTL implements the generic FWCTL IOCLTs to allow limited > access from user space (as admin) to some very specific PCODE > Mailboxes only related to hardware configuration. > >

Re: [PATCH RESEND] drm/i915/pch: fix warning for coffeelake on SunrisePoint PCH

2025-04-29 Thread Rodrigo Vivi
t; drivers/gpu/drm/i915/display/intel_pch.c:126 intel_pch_type+0x1af/0xae0 [i915] > [5.609317] CPU: 3 UID: 0 PID: 440 Comm: (udev-worker) Not tainted > 6.15.0-rc3-drm-tip-2fa6469c618d #3 PREEMPT(voluntary) > > Signed-off-by: Jiajia Liu > Reviewed-by: Rodrigo Vivi pushed to drm-intel-ne

Re: [PATCH] drm/i915/pch: fix warning for coffeelake on SunrisePoint PCH

2025-04-22 Thread Rodrigo Vivi
send it. https://gitlab.freedesktop.org/drm/tip/ Feel free to resend with: Reviewed-by: Rodrigo Vivi > > Signed-off-by: Jiajia Liu > --- > drivers/gpu/drm/i915/soc/intel_pch.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i9

Re: [PATCH v8 12/12] drm/xe/nvm: add support for non-posted erase

2025-04-21 Thread Rodrigo Vivi
rt for non-posted erase with polling > for erase completion. > > Signed-off-by: Abliyev, Reuven > Signed-off-by: Alexander Usyskin Reviewed-by: Rodrigo Vivi and Acked-by: Rodrigo Vivi on all xe and i915 patches to get merged through another trees if needed. > ---

[PULL] drm-intel-next

2025-04-11 Thread Rodrigo Vivi
is enable Lucas De Marchi (2): drm/i915/dram: Add missing INTEL_DRAM str conversions drm/i915/dram: Consolidate logging of DRAM type Mohammed Thasleem (1): drm/i915/dmc: Create debugfs entry for dc6 counter Rodrigo Vivi (1): drm/i915/display: Fix htmldocs build Su

Re: [PATCH v7 00/12] mtd: add driver for Intel discrete graphics

2025-04-05 Thread Rodrigo Vivi
On Wed, Mar 26, 2025 at 05:26:11PM +0200, Alexander Usyskin wrote: > Add driver for access to Intel discrete graphics card > internal NVM device. > Expose device on auxiliary bus by i915 and Xe drivers and > provide mtd driver to register this device with MTD framework. > > This is a rewrite of "d

Re: [PATCH] drm/xe: avoid plain 64-bit division

2025-03-28 Thread Rodrigo Vivi
tions for SVM support") > Signed-off-by: Arnd Bergmann Reviewed-by: Rodrigo Vivi and pushing it right now, thanks for the patch > --- > drivers/gpu/drm/xe/xe_migrate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_m

Re: [PATCH] drm/i915/gsc: delete a stray tab in intel_gsc_fw_get_binary_info()

2025-03-28 Thread Rodrigo Vivi
On Mon, Mar 10, 2025 at 10:46:19PM +0300, Dan Carpenter wrote: > This line is indented on tab too far. Delete the extra tab. > > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vivi and pushing right now... > --- > drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 2 +- >

[PULL] drm-xe-fixes

2025-03-13 Thread Rodrigo Vivi
cancelling work (Tejas) - Fix new warnings around userptr (Thomas) - Temporaritly disable D3Cold on BMG (Rodrigo) - Retry and wait longer for GuC PC to start (Rodrigo) - Remove redundant check in xe_vm_create_ioctl (Xin) -------- Rodr

[PULL] drm-intel-fixes

2025-03-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes i915 fixes for this week. The most interesting seems to be a bump in the MMAP_GTT_VERSION to indicate a missing support for partial mmaps, which had been previously introduced by commit 255fc1703e42 ("drm/i915/gem: Calculate object page offset for partial memory mappin

[PULL] drm-xe-fixes

2025-03-11 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our xe fixes for this round, with many fixes around userptr. Thanks, Rodrigo. drm-xe-fixes-2025-03-06: - Remove double page flip on initial plane (Maarten) - Properly setup userptr pfn_flags_mask (Auld) - Fix GT "for each engine" workarounds (Tvrtko) - Fix userptr rac

Re: [PATCH next] drm/xe: Fix uninitialized variable in xe_vm_bind_ioctl()

2025-03-11 Thread Rodrigo Vivi
On Mon, Mar 10, 2025 at 01:48:00PM +0300, Dan Carpenter wrote: > The error handling assumes that vm_bind_ioctl_check_args() will > initialize "bind_ops" but there are a couple early returns where that's > not true. Initialize "bind_ops" to NULL from the start. It is not a couple, but only the one

[PULL] drm-intel-fixes

2025-03-06 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the only i915 fix for this round. Thanks, Rodrigo. drm-intel-fixes-2025-03-06: - DP MST fix (Jani) The following changes since commit 7eb172143d5508b4da468ed59ee857c6e5e01da6: Linux 6.14-rc5 (2025-03-02 11:48:20 -0800) are available in the Git repository at: ht

[PULL] drm-xe-fixes

2025-02-27 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our xe fixes for this round. Thanks, Rodrigo. drm-xe-fixes-2025-02-27: uAPI: - OA uapi fix (Umesh) Driver: - Userptr related fixes (Auld) - Remove a duplicated register entry (Mingong) - Scheduler related fix to prevent exec races when freeing it (Tejas) The followin

[PULL] drm-intel-fixes

2025-02-27 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our only i915 fix for this round. Thanks, Rodrigo. drm-intel-fixes-2025-02-27: - Fix encoder HW state readout for DP UHBR MST (Imre) The following changes since commit d082ecbc71e9e0bf49883ee4afd435a77a5101b6: Linux 6.14-rc4 (2025-02-23 12:32:57 -0800) are availab

Re: [PATCH] drm/xe/regs: remove a duplicate definition for RING_CTL_SIZE(size)

2025-02-25 Thread Rodrigo Vivi
On Tue, Feb 25, 2025 at 03:34:03PM -0800, Matthew Brost wrote: > On Tue, Feb 25, 2025 at 03:31:01PM +0800, Mingcong Bai wrote: > > Commit b79e8fd954c4 ("drm/xe: Remove dependency on intel_engine_regs.h") > > introduced an internal set of engine registers, however, as part of this > > change, it has

Re: [PATCH 6/6] drm/xe: Drop remove callback support

2025-02-21 Thread Rodrigo Vivi
- /** > - * @probing: cover the section in which @remove_action_list can be used > - * to post cleaning actions > - */ > - bool probing; > - > /** >* @mem_access: keep track of memory access in the device, possibly >* triggering additional actions when they occur. > diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c > index 41ec6825b9bcc..447eacb355d7c 100644 > --- a/drivers/gpu/drm/xe/xe_pci.c > +++ b/drivers/gpu/drm/xe/xe_pci.c > @@ -900,10 +900,8 @@ static int xe_pci_probe(struct pci_dev *pdev, const > struct pci_device_id *ent) > return err; > > err = xe_device_probe(xe); > - if (err) { > - xe_device_call_remove_actions(xe); > + if (err) > return err; > - } > For the series: Reviewed-by: Rodrigo Vivi > err = xe_pm_init(xe); > if (err) > -- > 2.48.1 >

[PULL] drm-xe-fixes

2025-02-20 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our round of Xe fixes of this week. Thanks, Rodrigo. drm-xe-fixes-2025-02-20: - Fix error handling in xe_irq_install (Lucas) - Fix devcoredump format (Jose, Lucas) The following changes since commit 0ad2507d5d93f39619fc42372c347d6006b64319: Linux 6.14-rc3 (2025-02

[PULL] drm-intel-fixes

2025-02-20 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our i915 fixes for this round. Mostly display related, with the exception of the spin_lock_irqsave conversion on guc submission. Thanks, Rodrigo. drm-intel-fixes-2025-02-20: - Use spin_lock_irqsave() in interruptible context on guc submission (Krzysztof) - Fixes on DD

[PULL] drm-xe-fixes

2025-02-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the xe fixes for this round. Thanks, Rodrigo. drm-xe-fixes-2025-02-13: - Remove bo->clients out of bos_lock area (Tejas) - Carve out wopcm portion from the stolen memory (Nirmoy) The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3: Linux 6.1

[PULL] drm-intel-fixes

2025-02-13 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the i915 fixes for this round, with only one patch from Krzysztof on selftests. drm-intel-fixes-2025-02-13: - Selftest fix: avoid using uninitialized context The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3: Linux 6.14-rc2 (2025-02-09 12:4

Re: [PATCH v12 0/5] Introduce DRM device wedged event

2025-02-13 Thread Rodrigo Vivi
On Wed, Feb 12, 2025 at 01:25:05PM -0500, Rodrigo Vivi wrote: > On Wed, Feb 12, 2025 at 08:57:10AM +0200, Raag Jadav wrote: > > On Tue, Feb 04, 2025 at 12:35:23PM +0530, Raag Jadav wrote: > > > This series introduces device wedged event in DRM subsystem and uses it > >

Re: [PATCH v12 0/5] Introduce DRM device wedged event

2025-02-12 Thread Rodrigo Vivi
On Wed, Feb 12, 2025 at 08:57:10AM +0200, Raag Jadav wrote: > On Tue, Feb 04, 2025 at 12:35:23PM +0530, Raag Jadav wrote: > > This series introduces device wedged event in DRM subsystem and uses it > > in xe, i915 and amdgpu drivers. Detailed description in commit message. > > > > This was earlier

Re: [PATCH V9] drm/xe/uapi: Use hint for guc to set GT frequency

2025-02-12 Thread Rodrigo Vivi
On Wed, Feb 12, 2025 at 03:38:06PM +, Teres Alexis, Alan Previn wrote: > On Wed, 2025-02-12 at 17:48 +0530, Tejas Upadhyay wrote: > > Allow user to provide a low latency hint. When set, KMD sends a hint > > to GuC which results in special handling for that process. SLPC will > > ramp the GT fre

Re: [PATCH 01/12] drm/{i915, xe}: Suspend/resume fbdev emulation via client interfaces

2025-02-11 Thread Rodrigo Vivi
nt. > No functional changes. Well, there is one functional change that is the clientlist iterator and the clientlist_mutex hold. So I would avoid the statement of no functional change. But indeed it seems there's not relevant functional changes... the code itself looks right to me:

Re: [PATCH v2] drm/i915: Add VM_DONTEXPAND to exported buffers

2025-02-11 Thread Rodrigo Vivi
On Tue, Feb 11, 2025 at 04:57:03PM +0100, Jacek Lawrynowicz wrote: > Hi, can I submit this to drm-misc or should someone commit this to drm-intel? This is drm-intel. More specifically drm-intel-gt-next. Since Joonas had some concerns on the v1, let's wait for him to check if the provided answers

Re: Compile error on "error: call to ‘__compiletime_assert_581’ declared with attribute error: clamp() low limit dsc_min_bpc * 3 greater than high limit dsc_max_bpc * 3"

2025-02-06 Thread Rodrigo Vivi
On Thu, Feb 06, 2025 at 09:43:54PM +0530, Nautiyal, Ankit K wrote: > > On 2/6/2025 1:34 PM, Zhuo, Qiuxu wrote: > > Hi, > > > > I got the compile error as below. > > My GCC is: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 > > kernel: v6.14-rc1 > > Hi Qiuxu, > > Thanks for the mail. > > Fix was sent

Re: [PULL] drm-intel-fixes

2025-02-06 Thread Rodrigo Vivi
On Thu, Feb 06, 2025 at 09:11:42AM -0500, Rodrigo Vivi wrote: > Hi Dave and Sima, > > Here goes the first i915 fixes towards 6.14. > > It looks that our CI was dead for the last round, but I double > checked locally in both ADL-P and DG2 and everything is working fine. >

[PULL] drm-intel-fixes

2025-02-06 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the first i915 fixes towards 6.14. It looks that our CI was dead for the last round, but I double checked locally in both ADL-P and DG2 and everything is working fine. In the last round the only addition was the Jani's DP fix, that looks correct. So, let's move forward

[PULL] drm-xe-fixes

2025-02-06 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first Xe related fixes towards 6.14. Thanks, Rodrigo. drm-xe-fixes-2025-02-06: UAPI Changes: - OA uAPI related fixes (Ashutosh) Driver Changes: - Fix SRIOV migration initialization (Michal) - Restore devcoredump to a sane state (Lucas) The following changes si

Re: [PATCH-resent-to-correct-ml 3/8] drm/xe: Add scoped guards for xe_force_wake

2025-02-04 Thread Rodrigo Vivi
On Tue, Feb 04, 2025 at 11:28:03PM +0100, Maarten Lankhorst wrote: > Hey, > > > On 2025-02-04 17:30, Michal Wajdeczko wrote: > > Hi Maarten, > > > > On 04.02.2025 14:22, Maarten Lankhorst wrote: > > > Instead of finding bugs where we may or may not release force_wake, I've > > > decided to be in

Re: [PATCH v12 4/5] drm/i915: Use device wedged event

2025-02-04 Thread Rodrigo Vivi
On Tue, Feb 04, 2025 at 12:35:27PM +0530, Raag Jadav wrote: > Now that we have device wedged event provided by DRM core, make use > of it and support both driver rebind and bus-reset based recovery. > With this in place, userspace will be notified of wedged device on > gt reset failure. > > Signed

Re: [PATCH v12 3/5] drm/xe: Use device wedged event

2025-02-04 Thread Rodrigo Vivi
d) > v3: Generic implementation in DRM subsystem (Lucas) > v4: Change authorship to Raag (Aravind) > > Signed-off-by: Raag Jadav > Reviewed-by: Aravind Iddamsetty Acked-by: Rodrigo Vivi to merge this through drm-misc-next > --- > drivers/gpu/drm/xe/xe_device.c | 7 ++- &

Re: [PATCH v4] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-02-03 Thread Rodrigo Vivi
On Tue, Jan 21, 2025 at 09:42:17AM -0500, Rodrigo Vivi wrote: > On Sat, Jan 18, 2025 at 06:47:27PM +0100, Michal Wajdeczko wrote: > > > > > > On 17.01.2025 22:57, Vinay Belgaumkar wrote: > > > Default SLPC power profile is Base(0). Power Saving mode(1) > > &

Re: [PATCH][next] drm/i915/selftest: Fix spelling mistake "ofset" -> "offset"

2025-02-03 Thread Rodrigo Vivi
On Sun, Feb 02, 2025 at 10:14:31PM +, Colin Ian King wrote: > There is a spelling mistake in an error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu

Re: [PATCH v2] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-02-03 Thread Rodrigo Vivi
On Sun, Feb 02, 2025 at 06:28:08AM -0800, Guenter Roeck wrote: > On 2/2/25 05:27, David Laight wrote: > > On Tue, 21 Jan 2025 15:15:09 -0800 > > Linus Torvalds wrote: > > > > > On Tue, 21 Jan 2025 at 14:59, Rodrigo Vivi wrote: > > > > > > >

Re: [PATCH v6 4/6] drm/xe/guc: Move xe_hw_engine_snapshot creation back to xe_hw_engine.c

2025-01-30 Thread Rodrigo Vivi
On Tue, Jan 28, 2025 at 10:36:50AM -0800, Alan Previn wrote: > xe_devcoredump calls xe_engine_snapshot_capture_for_queue() to allocate > and populate the xe_hw_engine_snapshot structure. Move that function > back into xe_hw_engine.c since it doesn't make sense for > GuC-Err-Capture to allocate a st

Re: [PATCH v6 3/6] drm/xe/guc: Split engine state print between xe_hw_engine vs xe_guc_capture

2025-01-30 Thread Rodrigo Vivi
On Tue, Jan 28, 2025 at 10:36:49AM -0800, Alan Previn wrote: > Relocate the xe_engine_snapshot_print function from xe_guc_capture.c > into xe_hw_engine.c but split out the GuC-Err-Capture register printing > portion out into a separate helper inside xe_guc_capture.c so that > we can have a clear se

Re: [PATCH v6 1/6] drm/xe/guc: Rename __guc_capture_parsed_output

2025-01-30 Thread Rodrigo Vivi
xe/xe_guc_capture.h > b/drivers/gpu/drm/xe/xe_guc_capture.h > index 20a078dc4b85..046989fba3b1 100644 > --- a/drivers/gpu/drm/xe/xe_guc_capture.h > +++ b/drivers/gpu/drm/xe/xe_guc_capture.h > @@ -50,7 +50,7 @@ size_t xe_guc_capture_ads_input_worst_size(struct xe_guc > *guc); > const struc

Re: [PATCH v4 07/11] mtd: intel-dg: wake card on operations

2025-01-29 Thread Rodrigo Vivi
On Wed, Jan 01, 2025 at 05:39:21PM +0200, Alexander Usyskin wrote: > Enable runtime PM in mtd driver to notify graphics driver that > whole card should be kept awake while nvm operations are > performed through this driver. > > CC: Lucas De Marchi > Acked-by: Miquel Raynal > Signed-off-by: Alexa

Re: [PATCH v4 10/11] drm/xe/nvm: add on-die non-volatile memory device

2025-01-29 Thread Rodrigo Vivi
On Wed, Jan 01, 2025 at 05:39:24PM +0200, Alexander Usyskin wrote: > Enable access to internal non-volatile memory on DGFX > with GSC/CSC devices via a child device. > The nvm child device is exposed via auxiliary bus. > > Reviewed-by: Rodrigo Vivi Since this patch needs a rebase

Re: [PATCH v2] drm/i915/lspcon: do not hardcode settle timeout

2025-01-27 Thread Rodrigo Vivi
On Thu, Jan 23, 2025 at 10:16:07PM -0500, Rodrigo Vivi wrote: > On Wed, Jan 22, 2025 at 01:15:31PM +0200, Giedrius Statkevičius wrote: > > Hello, > > > > On Mon, 4 Nov 2024 at 23:28, Rodrigo Vivi wrote: > > > > > > On Mon, Nov 04, 2024 at 02:09:

Re: [PATCH] drm/i915: Remove unused live_context_for_engine

2025-01-27 Thread Rodrigo Vivi
On Sat, Jan 25, 2025 at 12:38:46AM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The last use of live_context_for_engine() was removed in 2021 by > commit 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt code") > > Re

Re: [PATCH v2] drm/i915/lspcon: do not hardcode settle timeout

2025-01-23 Thread Rodrigo Vivi
On Wed, Jan 22, 2025 at 01:15:31PM +0200, Giedrius Statkevičius wrote: > Hello, > > On Mon, 4 Nov 2024 at 23:28, Rodrigo Vivi wrote: > > > > On Mon, Nov 04, 2024 at 02:09:46PM +0200, Giedrius Statkevičius wrote: > > > Hello, > > > > > > Kind p

Re: [PATCH v4 0/1] Maintenence of devcoredump <-> GuC-Err-Capture plumbing

2025-01-21 Thread Rodrigo Vivi
On Tue, Jan 21, 2025 at 11:09:34AM -0800, Alan Previn wrote: > The GuC-Error-Capture is currently reaching into xe_devcoredump > structure to store its own place-holder snaphot to workaround > the race between G2H-Error-Capture-Notification vs Drm-Scheduler > triggering GuC-Submission-exec-queue-ti

Re: [PATCH v2] drm/i915/backlight: Return immediately when scale() finds invalid parameters

2025-01-21 Thread Rodrigo Vivi
zed-by: Linus Torvalds > Suggested-by: Linus Torvalds > Suggested-by: David Laight > Cc: David Laight > Cc: Jani Nikula > Cc: Andy Shevchenko > Signed-off-by: Guenter Roeck Reviewed-by: Rodrigo Vivi I'm pushing this soon to drm-intel-next, unless Linus want to take thi

Re: [PATCH v4] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-01-21 Thread Rodrigo Vivi
On Sat, Jan 18, 2025 at 06:47:27PM +0100, Michal Wajdeczko wrote: > > > On 17.01.2025 22:57, Vinay Belgaumkar wrote: > > Default SLPC power profile is Base(0). Power Saving mode(1) > > has conservative up/down thresholds and is suitable for use with > > apps that typically need to be power effici

Re: [PATCH v3] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-01-17 Thread Rodrigo Vivi
mat and add some kernel doc for SLPC (Rodrigo) > > v3: Update doc with info about power profiles (Rodrigo) > > Cc: Sushma Venkatesh Reddy > Cc: Rodrigo Vivi > Signed-off-by: Vinay Belgaumkar > --- > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 + >

Re: [PATCH V7] drm/xe/mmap: Add mmap support for PCI memory barrier

2025-01-17 Thread Rodrigo Vivi
On Mon, Jan 13, 2025 at 05:12:01PM +0530, Tejas Upadhyay wrote: Next time, please identify the patch with 'drm/xe/uapi' to get it more visible to maintainers. > In order to avoid having userspace to use MI_MEM_FENCE, > we are adding a mechanism for userspace to generate a > PCI memory barrier wit

Re: [PATCH v2] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-01-17 Thread Rodrigo Vivi
On Fri, Jan 17, 2025 at 10:21:53AM -0800, Belgaumkar, Vinay wrote: > > On 1/17/2025 6:29 AM, Rodrigo Vivi wrote: > > On Thu, Jan 16, 2025 at 03:51:03PM -0800, Belgaumkar, Vinay wrote: > > > On 1/16/2025 2:57 PM, Rodrigo Vivi wrote: > > > > On Fri, Jan 10

Re: [PATCH] MAINTAINERS: Also exclude xe for drm-misc

2025-01-17 Thread Rodrigo Vivi
ow I understand why my inbox has more drm items nowadays :) Reviewed-by: Rodrigo Vivi > > DRM DRIVERS FOR ALLWINNER A10 > M: Maxime Ripard > -- > 2.48.0 >

Re: [PATCH v2] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-01-17 Thread Rodrigo Vivi
On Thu, Jan 16, 2025 at 03:51:03PM -0800, Belgaumkar, Vinay wrote: > > On 1/16/2025 2:57 PM, Rodrigo Vivi wrote: > > On Fri, Jan 10, 2025 at 03:21:51PM -0800, Vinay Belgaumkar wrote: > > > Default SLPC power profile is Base(0). Power Saving mode(1) > > > has conserva

Re: [PATCH v2] drm/i915/slpc: Add sysfs for SLPC power profiles

2025-01-16 Thread Rodrigo Vivi
mat and add some kernel doc for SLPC (Rodrigo) > > Cc: Sushma Venkatesh Reddy > Cc: Rodrigo Vivi > Signed-off-by: Vinay Belgaumkar > --- > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 +++ > drivers/gpu/drm/i915/gt/intel_rps.c | 4 ++ > .../d

Re: [PATCH] drm/bridge: fix documentation for the hdmi_audio_prepare() callback

2025-01-14 Thread Rodrigo Vivi
ot;drm/bridge: connector: add support for HDMI codec > framework") Reviewed-by: Rodrigo Vivi > Reported-by: Stephen Rothwell > Closes: > https://lore.kernel.org/linux-next/20250106174645.46392...@canb.auug.org.au/ > Signed-off-by: Dmitry Baryshkov > --- > include/drm/

Re: [PATCH 0/3] drm/i915/gvt: Deadcoding

2025-01-13 Thread Rodrigo Vivi
On Sat, Jan 11, 2025 at 02:12:17PM +0900, Zhenyu Wang wrote: > On Thu, Jan 09, 2025 at 04:10:24PM -0500, Rodrigo Vivi wrote: > > On Mon, Jan 06, 2025 at 04:30:20PM +0900, Zhenyu Wang wrote: > > > On Sun, Dec 22, 2024 at 12:25:09AM +, Dr. David Alan Gilbert wrote:

[PULL] drm-xe-next

2025-01-10 Thread Rodrigo Vivi
drm/xe: Fix all typos in xe Rodrigo Vivi (1): drm/xe: Introduce the RPa information Vinay Belgaumkar (1): drm/xe/slpc: Remove unnecessary force wakes drivers/gpu/drm/xe/Kconfig.debug | 4 +- drivers/gpu/drm/xe/abi/guc_capture_abi.h | 2 +- drivers/gpu/drm/x

Re: [PATCH 0/3] drm/i915/gvt: Deadcoding

2025-01-09 Thread Rodrigo Vivi
On Mon, Jan 06, 2025 at 04:30:20PM +0900, Zhenyu Wang wrote: > On Sun, Dec 22, 2024 at 12:25:09AM +, Dr. David Alan Gilbert wrote: > > Note: zhen...@linux.intel.com's address bounces: > > > > yeah, I've left Intel so can't use that box any more, looks Rodrigo hasn't > queue up my address chan

Re: linux-next: manual merge of the drm-intel tree with the mm tree

2025-01-08 Thread Rodrigo Vivi
On Wed, Jan 08, 2025 at 12:16:50PM +1100, Stephen Rothwell wrote: > Hi All, > > On Mon, 6 Jan 2025 13:03:48 +1100 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the drm-intel tree got a conflict in: > > > > drivers/gpu/drm/i915/display/intel_display_driver.c > > > > between co

[PULL] drm-intel-next

2025-01-07 Thread Rodrigo Vivi
ges drm/i915/dg2: Introduce DG2_D subplatform drm/i915: Introduce intel_cpu_info.c for CPU IDs drm/i915/dg2: Implement Wa_14022698537 Rodrigo Vivi (9): drm/i915: Remove vga and gmbus seq out of i915_restore_display drm/i915/display: Convert i915_suspend into i9xx_display_sr

[PULL] drm-xe-next

2025-01-07 Thread Rodrigo Vivi
rruptible wait when moving BO to system drm/xe: Wait for migration job before unmapping pages drm/xe/tests: Move shrink test out of xe_bo Rodrigo Vivi (2): drm/xe/pm: Also avoid missing outer rpm warning on system suspend drm/xe/dg1: Fix power gate sequence. Thomas Hellström

Re: [PULL] drm-intel-next

2024-12-20 Thread Rodrigo Vivi
On Wed, Dec 11, 2024 at 03:38:46PM -0500, Rodrigo Vivi wrote: > Hi Dave and Sima, > > Here goes our first drm-intel-next round targeting 6.14. > > One drm/print change coming from here. The rest is mostly > display changes and one GSC FW update for ARL platforms. > > Tha

Re: [PATCH v2 4/7] drm/xe: Implement cgroup for vram

2024-12-20 Thread Rodrigo Vivi
x27;m glad to see that we are finally going to get some cgroups support! Acked-by: Rodrigo Vivi Fell free to push this through any tree... > > > > On Wed, Dec 04, 2024 at 02:44:04PM +0100, Maarten Lankhorst wrote: > > Add vram based cgroup eviction to Xe. > > Most

Re: [PATCH v3 06/10] mtd: intel-dg: wake card on operations

2024-12-17 Thread Rodrigo Vivi
On Tue, Nov 19, 2024 at 04:01:08PM +0200, Alexander Usyskin wrote: > Enable runtime PM in mtd driver to notify graphics driver that > whole card should be kept awake while nvm operations are > performed through this driver. > > CC: Lucas De Marchi > Acked-by: Miquel Raynal > Signed-off-by: Alexa

Re: [PATCH v3 03/10] mtd: intel-dg: implement access functions

2024-12-17 Thread Rodrigo Vivi
On Tue, Nov 19, 2024 at 04:01:05PM +0200, Alexander Usyskin wrote: > Implement read(), erase() and write() functions. > > CC: Lucas De Marchi > CC: Rodrigo Vivi > Acked-by: Miquel Raynal > Co-developed-by: Tomas Winkler > Signed-off-by: Tomas Winkler > Co-dev

Re: [PATCH] drm/xe/vsec: enforce CONFIG_INTEL_VSEC dependency

2024-12-17 Thread Rodrigo Vivi
On Tue, Dec 17, 2024 at 08:28:59PM +0100, Arnd Bergmann wrote: > On Tue, Dec 17, 2024, at 19:52, Rodrigo Vivi wrote: > > On Tue, Dec 17, 2024 at 08:18:44AM +0100, Arnd Bergmann wrote: > >> From: Arnd Bergmann > >> > >> When INTEL_VSEC is in a loadable mo

Re: [PATCH v3 02/10] mtd: intel-dg: implement region enumeration

2024-12-17 Thread Rodrigo Vivi
On Tue, Nov 19, 2024 at 04:01:04PM +0200, Alexander Usyskin wrote: > In intel-dg, there is no access to the spi controller, > the information is extracted from the descriptor region. > > CC: Rodrigo Vivi > CC: Lucas De Marchi > Acked-by: Miquel Raynal > Co-developed-by: To

Re: [PATCH] drm/i915/slpc: Add sysfs for SLPC power profiles

2024-12-17 Thread Rodrigo Vivi
On Mon, Dec 16, 2024 at 04:57:04PM -0800, Vinay Belgaumkar wrote: > Default SLPC power profile is Base(0). Power Saving mode(1) > has conservative up/down thresholds and is suitable for use with > apps that typically need to be power efficient. > > Cc: Sushma Venkatesh Reddy >

Re: [PATCH] drm/xe/vsec: enforce CONFIG_INTEL_VSEC dependency

2024-12-17 Thread Rodrigo Vivi
On Tue, Dec 17, 2024 at 08:18:44AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When INTEL_VSEC is in a loadable module, XE cannot be built-in any more: > > x86_64-linux-ld: vmlinux.o: in function `xe_vsec_init': > (.text+0x19861bf): undefined reference to `intel_vsec_register' > > Thi

[PULL] drm-xe-next

2024-12-11 Thread Rodrigo Vivi
e: Trace xe_bo_validate drm/xe: Avoid evicting object of the same vm in none fault mode Raag Jadav (1): drm/xe/throttle: Log throttle reasons Randy Dunlap (1): drm/xe/vm_doc: fix more doc typos Rodrigo Vivi (2): Merge drm/drm-next into drm-xe-next Merge drm/drm-next in

[PULL] drm-intel-next

2024-12-11 Thread Rodrigo Vivi
g4x_dp_set_clock() call to g4x_dp_compute_config() Jiasheng Jiang (1): drm/i915: Fix memory leak by correcting cache object name in error handler Jouni Högander (1): drm/i915/psr: Disable Panel Replay as well if VRR is enabled Rodrigo Vivi (8): drm/i915: Remove vga and gmbus seq o

Re: [PATCH] drm/i915: Update license on selftest lists to MIT

2024-12-10 Thread Rodrigo Vivi
On Sun, Dec 08, 2024 at 03:17:27PM +, Ed Maste wrote: > These two files (i915_live_selftests.h, i915_mock_selftests.h) were > introduced in commit 953c7f82eb89 ("drm/i915: Provide a hook for > selftests") and are effectively just a list of selftests. > > The selftest implementation itself is l

Re: [PATCH] drm/xe/vm_doc: fix more doc typos

2024-12-02 Thread Rodrigo Vivi
On Wed, Nov 27, 2024 at 07:58:59PM -0800, Randy Dunlap wrote: > Fix all typos in xe_vm_doc.h as reported by codespell. > > Signed-off-by: Randy Dunlap > Cc: Lucas De Marchi > Cc: Thomas Hellström > Cc: Rodrigo Vivi > Cc: intel...@lists.freedesktop.org > Cc: David Air

Re: [PATCH v2] drm/i915/guc: Flush ct receive tasklet during reset preparation

2024-11-30 Thread Rodrigo Vivi
On Mon, Nov 04, 2024 at 01:41:03PM -0800, Zhanjun Dong wrote: > GuC to host communication is interrupt driven, the handling has 3 > parts: interrupt context, tasklet and request queue worker. > During GuC reset prepare, interrupt is disabled before destroy > contexts steps start. The IRQ and worker

Re: [PATCH v7 2/8] drm/ttm: Add ttm_bo_access

2024-11-28 Thread Rodrigo Vivi
On Wed, Nov 27, 2024 at 02:19:32PM +0100, Christian König wrote: > Am 26.11.24 um 18:46 schrieb Matthew Brost: > > Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible > > VRAM easily be accessed. Add ttm_bo_access, which is similar to > > ttm_bo_vm_access, to access such memory.

Re: [PATCH] drm/i915: Fixed an typo in i915_gem_gtt.c

2024-11-25 Thread Rodrigo Vivi
On Wed, Nov 20, 2024 at 08:32:45PM +0800, Zhang He wrote: > in function `i915_gem_gtt_reserve` @node comment, > i915_vma has no `mode` member, `i915_vma.node` is the correct name > > Signed-off-by: Zhang He Reviewed-by: Rodrigo Vivi and pushed to drm-intel-next. Thanks f

Re: [PATCH 4/4] drm/i915/dp_mst: Fix error handling while adding a connector

2024-11-15 Thread Rodrigo Vivi
On Fri, Nov 15, 2024 at 06:41:59PM +0200, Imre Deak wrote: > After an error during adding an MST connector the MST port and the > intel_connector object could be leaked, fix this up. > > Signed-off-by: Imre Deak Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/disp

Re: [PATCH 1/4] drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

2024-11-15 Thread Rodrigo Vivi
On Fri, Nov 15, 2024 at 10:30:12PM +0200, Imre Deak wrote: > On Fri, Nov 15, 2024 at 03:20:58PM -0500, Rodrigo Vivi wrote: > > On Fri, Nov 15, 2024 at 06:41:56PM +0200, Imre Deak wrote: > > > The connector initialization in intel_dp_add_mst_connector() depends on > >

Re: [PATCH 2/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-15 Thread Rodrigo Vivi
list after the properties on the > connector have been added, this is ok since these steps don't have a > dependency. > > Signed-off-by: Imre Deak Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/drm_connector.c | 103 ++-- > inclu

Re: [PATCH 1/4] drm/i915/dp_mst: Fix connector initialization in intel_dp_add_mst_connector()

2024-11-15 Thread Rodrigo Vivi
actually removes callers of base.dev. I don't see how that it could be causing this new null dereference. > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12799 But well, trusting more the tests then my eyes, let's move forward. Reviewed-by: Rodrigo Vivi > Signe

Re: [PATCH 3/4] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-11-15 Thread Rodrigo Vivi
-ups. > > Signed-off-by: Imre Deak Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 29 - > 1 file changed, 11 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c > b/drivers/gp

Re: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-11-07 Thread Rodrigo Vivi
On Tue, Nov 05, 2024 at 07:17:53AM -0500, Usyskin, Alexander wrote: > > -Original Message- > > From: Vivi, Rodrigo > > Sent: Monday, November 4, 2024 11:16 PM > > To: Usyskin, Alexander > > Cc: Gupta, Anshuman ; Deak, Imre > > ; Miquel Raynal ; > > Richard Weinberger ; Vignesh Raghavendra

Re: [PATCH v2 07/10] drm/i915/nvm: add nvm device for discrete graphics

2024-11-07 Thread Rodrigo Vivi
On Thu, Nov 07, 2024 at 03:13:53PM +0200, Alexander Usyskin wrote: > Enable access to internal non-volatile memory on > DGFX devices via a child device. > The nvm child device is exposed via auxiliary bus. Reviewed-by: Rodrigo Vivi > > CC: Rodrigo Vivi > CC: Lucas De Marchi

Re: [PATCH v2 08/10] drm/i915/nvm: add support for access mode

2024-11-07 Thread Rodrigo Vivi
On Thu, Nov 07, 2024 at 03:13:54PM +0200, Alexander Usyskin wrote: > Check NVM access mode from GSC FW status registers > and overwrite access status read from SPI descriptor, if needed. Reviewed-by: Rodrigo Vivi > > Signed-off-by: Alexander Usyskin > --- > drivers/gpu/dr

Re: [PATCH v2 10/10] drm/xe/nvm: add support for access mode

2024-11-07 Thread Rodrigo Vivi
On Thu, Nov 07, 2024 at 03:13:56PM +0200, Alexander Usyskin wrote: > Check NVM access mode from GSC FW status registers > and overwrite access status read from SPI descriptor, if needed. Reviewed-by: Rodrigo Vivi > > Signed-off-by: Alexander Usyskin > --- > drive

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-04 Thread Rodrigo Vivi
On Mon, Nov 04, 2024 at 01:30:41PM -0800, Matthew Brost wrote: > On Mon, Nov 04, 2024 at 08:47:01PM +0100, Christian König wrote: > > Am 01.11.24 um 00:43 schrieb Matthew Brost: > > > On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: > > > > Non-contiguous VRAM cannot easily be mapped

Re: [PATCH] drm/i915/gt: Remove unused execlists_unwind_incomplete_requests

2024-11-04 Thread Rodrigo Vivi
> Remove it. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Rodrigo Vivi and pushed to drm-intel-gt-next thanks for the patch. > --- > drivers/gpu/drm/i915/gt/intel_engine.h | 3 --- > drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 9 --

Re: [PATCH v2] drm/i915/lspcon: do not hardcode settle timeout

2024-11-04 Thread Rodrigo Vivi
On Mon, Nov 04, 2024 at 02:09:46PM +0200, Giedrius Statkevičius wrote: > Hello, > > Kind ping. There was a pipe underun in CI... I honestly don't believe this patch is causing it, but anyway I decided to trigger a retest there before I push this. Thanks for the patch and review. > > > On Thu,

Re: [PATCH 01/10] mtd: add driver for intel graphics non-volatile memory device

2024-11-04 Thread Rodrigo Vivi
On Tue, Oct 22, 2024 at 01:41:10PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > non-volatile memory device. > > CC: Rodrigo Vivi > CC: Lucas De Marchi > Co-developed-by: Tomas Winkler > Signed-off-by: Tomas Winkler > Signed-o

Re: [PATCH 09/10] drm/xe/nvm: add on-die non-volatile memory device

2024-11-04 Thread Rodrigo Vivi
On Mon, Oct 28, 2024 at 10:48:48AM -0400, Rodrigo Vivi wrote: > On Tue, Oct 22, 2024 at 01:41:18PM +0300, Alexander Usyskin wrote: > > Enable access to internal non-volatile memory on DGFX > > with GSC/CSC devices via a child device. > > The nvm child device is exposed via

Re: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-11-04 Thread Rodrigo Vivi
On Tue, Oct 29, 2024 at 11:24:36AM +, Usyskin, Alexander wrote: > > -Original Message- > > From: Gupta, Anshuman > > Sent: Monday, October 28, 2024 5:02 PM > > To: Vivi, Rodrigo ; Usyskin, Alexander > > ; Deak, Imre > > Cc: Miquel Raynal ; Richard Weinberger > > ; Vignesh Raghavendra

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-04 Thread Rodrigo Vivi
On Thu, Oct 31, 2024 at 04:43:19PM -0700, Matthew Brost wrote: > On Thu, Oct 31, 2024 at 11:10:42AM -0700, Matthew Brost wrote: > > Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible > > VRAM easily be accessed. Add ttm_bo_access, which is similar to > > ttm_bo_vm_access, to acc

Re: [PATCH 06/10] mtd: intel-dg: wake card on operations

2024-10-28 Thread Rodrigo Vivi
On Tue, Oct 22, 2024 at 01:41:15PM +0300, Alexander Usyskin wrote: > Enable runtime PM in mtd driver to notify graphics driver that > whole card should be kept awake while nvm operations are > performed through this driver. > > CC: Lucas De Marchi > Signed-off-by: Alexander Usyskin > --- > driv

Re: [PATCH 09/10] drm/xe/nvm: add on-die non-volatile memory device

2024-10-28 Thread Rodrigo Vivi
On Tue, Oct 22, 2024 at 01:41:18PM +0300, Alexander Usyskin wrote: > Enable access to internal non-volatile memory on DGFX > with GSC/CSC devices via a child device. > The nvm child device is exposed via auxiliary bus. I looked at all of the i915 and xe patches here and everything looks right. Jus

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-25 Thread Rodrigo Vivi
On Fri, Oct 18, 2024 at 05:07:22PM -0400, Alex Deucher wrote: > On Fri, Oct 18, 2024 at 1:56 PM André Almeida wrote: > > > > Em 18/10/2024 12:31, Alex Deucher escreveu: > > > On Fri, Oct 18, 2024 at 11:23 AM Rodrigo Vivi > > > wrote: > > >> > >

  1   2   3   4   5   6   7   8   9   10   >