Re: [PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

2024-03-18 Thread Robin van der Gracht
Hi Thomas, Thank you for submitting your patch, it looks fine to me. Reviewed-by: Robin van der Gracht On Wed, 13 Mar 2024 16:45:00 +0100 Thomas Zimmermann wrote: > Replace the use of struct backlight_properties.fb_blank with a > call to backlight_get_brightness(). The helper impleme

Re: [PATCH 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb

2024-02-13 Thread Robin van der Gracht
acklight_ops. > > Signed-off-by: Thomas Zimmermann > Cc: Robin van der Gracht > --- > drivers/auxdisplay/ht16k33.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c > index a90430b7d07ba..0a858db32486b 1006

Re: [PATCH 10/32] auxdisplay/ht16k33: Initialize fb_ops with fbdev macros

2023-11-22 Thread Robin van der Gracht
systems that do not use these functions. Signed-off-by: Thomas Zimmermann Cc: Miguel Ojeda Cc: Robin van der Gracht --- drivers/auxdisplay/Kconfig | 5 + drivers/auxdisplay/ht16k33.c | 7 ++- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/auxdisplay/Kconfig b

Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

2023-11-21 Thread Robin van der Gracht
On 2023-11-15 11:19, Thomas Zimmermann wrote: The ht16k33 driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Cc: Miguel Ojeda Cc: Robin van der Gracht

Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

2023-01-09 Thread Robin van der Gracht
Hi Sam, On 2023-01-08 10:29, Sam Ravnborg wrote: Hi Robin. On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote: On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint wrote: > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backli