Re: [PATCH] staging: vme_user: vme_bridge.h: Document mutex in vme_dma_resource structure

On Sat, Aug 3, 2024 at 9:54 AM Dan Carpenter wrote: > On Sat, Aug 03, 2024 at 05:48:14AM +0530, Riyan Dhiman wrote: > > Adhere to Linux kernel coding style > > > > Reported by checkpatch: > > > > CHECK: mutex definition without comment > > > > Proof

[PATCH] staging: vme_user: vme_bridge.h: Document mutex in vme_dma_resource structure

could lead to data corruption or inconsistant state. Signed-off-by: Riyan Dhiman --- drivers/staging/vme_user/vme_bridge.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h index 9bdc41bb6602..bb3750b40eb1 100644 --- a/d

[PATCH] staging: vme_user: vme_bridge.h: Fix mutex without comment warning

Adhere to Linux kernel coding style Reported by checkpatch: CHECK: mutex definition without comment Signed-off-by: Riyan Dhiman --- drivers/staging/vme_user/vme_bridge.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user

Re: [PATCH] staging: vme_user: vme_bridge.h: Fix mutex without comment warning

se mutexes are used? - Explanations of the race conditions these mutexes prevent? - Citations from the driver's design documentation (if available)? 3. Is there a preferred format or level of detail you'd like to see in the changelog for each documentation change? Thank you for your t

[PATCH] staging: vme_user: vme.h: alignment of closing parenthesis should match open parenthesis in function declaration

Adhere to Linux kernel coding style. Reported by checkpatch: CHECK: Alignment should match open parenthesis Signed-off-by: Riyan Dhiman --- drivers/staging/vme_user/vme.h | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vme_user/vme.h b

[PATCH] staging: fbtft: Fix mutex and spinlock without comment warning

Adhere to Linux kernel coding style Reported by checkpatch: CHECK: spinlock_t definition without comment CHECK: mutex definition without comment Signed-off-by: Riyan Dhiman --- drivers/staging/fbtft/fbtft.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fbtft/fbtft.h b

[PATCH] staging: fbtft: Remove ftrace-like logging

Adhere to Linux kernel coding style Reported by checkpatch: WARNING: Unnecessary ftrace-like logging - prefer using ftrace Signed-off-by: Riyan Dhiman --- drivers/staging/fbtft/fb_ili9320.c | 2 -- drivers/staging/fbtft/fb_ra8875.c | 7 --- drivers/staging/fbtft/fb_sh1106.c | 3

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

would be valuable and if there are any additional areas where I can be of assistance? Thank you for your time and consideration. Best regards, Riyan Dhiman

Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

regards, Riyan Dhiman On Tue, Jul 23, 2024 at 1:13 PM Greg KH wrote: > On Tue, Jul 23, 2024 at 11:33:11AM +0530, Riyan Dhiman wrote: > > Adhere to Linux kernel coding style. > > > > Reported by checkpatch: > > > > CHECK: Unnecessary parentheses around 'dev

[PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

essary parentheses around 'par->info->var.yres == 240' CHECK: Unnecessary parentheses around 'par->spi->bits_per_word == 8' CHECK: Unnecessary parentheses around '!txbuflen' CHECK: Unnecessary parentheses around 'bpp > 8' ERROR: space prohibited