Re: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration

2025-05-15 Thread Raag Jadav
On Thu, May 15, 2025 at 04:53:38PM +0530, Usyskin, Alexander wrote: > > On Thu, Apr 24, 2025 at 04:25:27PM +0300, Alexander Usyskin wrote: > > > In intel-dg, there is no access to the spi controller, > > > the information is extracted from the descriptor region. > > > > ... > > > > > @@ -22,9 +24

Re: [PATCH v9 02/12] mtd: add driver for intel graphics non-volatile memory device

2025-05-15 Thread Raag Jadav
On Thu, May 15, 2025 at 03:41:08PM +0530, Usyskin, Alexander wrote: > > On Thu, Apr 24, 2025 at 04:25:26PM +0300, Alexander Usyskin wrote: > > > Add auxiliary driver for intel discrete graphics > > > non-volatile memory device. ... > > > + for (n = 0, i = 0; i < INTEL_DG_NVM_REGIONS; i++) { > > >

Re: [PATCH v2 2/3] drm/doc: Add a section about "App information" for the wedge API

2025-05-12 Thread Raag Jadav
On Sun, May 11, 2025 at 07:47:44PM -0300, André Almeida wrote: > Add a section about "App information" for the wedge API. > > Signed-off-by: André Almeida > --- > Documentation/gpu/drm-uapi.rst | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/gpu/drm-uapi.

Re: [PATCH v3] drm: Fix potential overflow issue in event_string array

2025-05-01 Thread Raag Jadav
On Wed, Apr 09, 2025 at 09:24:41AM +0300, Raag Jadav wrote: > On Wed, Apr 09, 2025 at 09:46:33AM +0800, jiangf...@kylinos.cn wrote: > > From: Feng Jiang > > > > When calling scnprintf() to append recovery method to event_string, > > the second argument should be

Re: [PATCH v9 03/12] mtd: intel-dg: implement region enumeration

2025-04-29 Thread Raag Jadav
On Thu, Apr 24, 2025 at 04:25:27PM +0300, Alexander Usyskin wrote: > In intel-dg, there is no access to the spi controller, > the information is extracted from the descriptor region. ... > @@ -22,9 +24,199 @@ struct intel_dg_nvm { > u8 id; > u64 offset; >

Re: [PATCH v9 02/12] mtd: add driver for intel graphics non-volatile memory device

2025-04-29 Thread Raag Jadav
On Thu, Apr 24, 2025 at 04:25:26PM +0300, Alexander Usyskin wrote: > Add auxiliary driver for intel discrete graphics > non-volatile memory device. ... > +static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev, > + const struct auxiliary_device_id *aux_dev_id) >

Re: [PATCH v3] drm: Fix potential overflow issue in event_string array

2025-04-10 Thread Raag Jadav
lem. > > Fixes: b7cf9f4ac1b8 ("drm: Introduce device wedged event") > Signed-off-by: Feng Jiang Reviewed-by: Raag Jadav Thanks for the fix.

Re: [PATCH v2] drm: Fix the length of event_string in drm_dev_wedged_event()

2025-04-08 Thread Raag Jadav
On Tue, Apr 08, 2025 at 07:27:28PM +0800, jiangf...@kylinos.cn wrote: > From: Feng Jiang > > When calling scnprintf() to append recovery method to event_string, > the second argument should be `sizeof(event_string) - len`, otherwise > there is a potential overflow problem. Thanks. Perhaps change

Re: [PATCH] drm: Fix the length of event_string in drm_dev_wedged_event()

2025-04-07 Thread Raag Jadav
On Tue, Apr 08, 2025 at 09:32:19AM +0800, jiangf...@kylinos.cn wrote: > From: Feng Jiang > > The format of the event_string value is `WEDGED=[,..,]`, > so method should be appended after 'WEDGED=' rather than overwriting it. It's already appending it, the fix is rather for the potential array ov

Re: [PATCH v10 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-04-05 Thread Raag Jadav
On Mon, Mar 24, 2025 at 10:27:08PM +0530, Cavitt, Jonathan wrote: > From: Jadav, Raag > > On Thu, Mar 20, 2025 at 03:26:15PM +, Jonathan Cavitt wrote: > > > Add support for userspace to request a list of observed faults > > > from a specified VM. > > > > ... > > > > > +static int xe_vm_get_

Re: [PATCH v12 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-26 Thread Raag Jadav
On Wed, Mar 26, 2025 at 07:51:15PM +0530, Cavitt, Jonathan wrote: > > From: Jadav, Raag > > On Tue, Mar 25, 2025 at 08:15:59PM +0530, Cavitt, Jonathan wrote: > > > From: Jadav, Raag > > > > On Mon, Mar 24, 2025 at 11:09:28PM +, Jonathan Cavitt wrote: > > > > > Add support for userspace to r

Re: [PATCH v12 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-25 Thread Raag Jadav
On Tue, Mar 25, 2025 at 08:15:59PM +0530, Cavitt, Jonathan wrote: > From: Jadav, Raag > > On Mon, Mar 24, 2025 at 11:09:28PM +, Jonathan Cavitt wrote: > > > Add support for userspace to request a list of observed faults > > > from a specified VM. > > > > ... > > > > > v10: > > > - Remove un

Re: [PATCH v10 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-25 Thread Raag Jadav
On Tue, Mar 25, 2025 at 08:14:13PM +0530, Cavitt, Jonathan wrote: > From: Jadav, Raag > > On Tue, Mar 25, 2025 at 03:01:27AM +0530, Cavitt, Jonathan wrote: > > > From: Jadav, Raag > > > > On Mon, Mar 24, 2025 at 10:27:08PM +0530, Cavitt, Jonathan wrote: > > > > > From: Jadav, Raag > > > > > >

Re: [PATCH v12 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-25 Thread Raag Jadav
On Mon, Mar 24, 2025 at 11:09:28PM +, Jonathan Cavitt wrote: > Add support for userspace to request a list of observed faults > from a specified VM. ... > v10: > - Remove unnecessary switch case logic (Raag) This is usually "changes present in version" and not "comments received in version"

Re: [PATCH v10 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-25 Thread Raag Jadav
On Tue, Mar 25, 2025 at 03:01:27AM +0530, Cavitt, Jonathan wrote: > From: Jadav, Raag > > On Mon, Mar 24, 2025 at 10:27:08PM +0530, Cavitt, Jonathan wrote: > > > From: Jadav, Raag > > > > On Thu, Mar 20, 2025 at 03:26:15PM +, Jonathan Cavitt wrote: > > > > > Add support for userspace to req

Re: [PATCH v10 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-21 Thread Raag Jadav
On Thu, Mar 20, 2025 at 03:26:15PM +, Jonathan Cavitt wrote: > Add support for userspace to request a list of observed faults > from a specified VM. ... > +static int xe_vm_get_property_size(struct xe_vm *vm, u32 property) > +{ > + int size = -EINVAL; Mixing size and error codes is usual

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-13 Thread Raag Jadav
On Wed, Mar 12, 2025 at 06:59:33PM -0300, André Almeida wrote: > Em 12/03/2025 07:06, Raag Jadav escreveu: > > On Tue, Mar 11, 2025 at 07:09:45PM +0200, Raag Jadav wrote: > > > On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: > > > > Em 01/03/2

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-03-12 Thread Raag Jadav
On Wed, Mar 12, 2025 at 09:25:08AM +0100, Christian König wrote: >Am 11.03.25 um 18:13 schrieb Raag Jadav: >> On Mon, Mar 10, 2025 at 06:03:27PM -0400, Alex Deucher wrote: >>> On Mon, Mar 10, 2025 at 5:54 PM André Almeida >>> wrote: >>>> Em 01/03/2025 0

Re: [PATCH v3 0/7] drm/v3d: Fix GPU reset issues on the Raspberry Pi 5

2025-03-12 Thread Raag Jadav
On Tue, Mar 11, 2025 at 03:13:42PM -0300, Maíra Canal wrote: > This series addresses GPU reset issues reported in [1], where running a > long compute job would trigger repeated GPU resets, leading to a UI > freeze. > > Patches #1 and #2 prevent the same faulty job from being resubmitted in a > loo

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-12 Thread Raag Jadav
On Tue, Mar 11, 2025 at 07:09:45PM +0200, Raag Jadav wrote: > On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: > > Em 01/03/2025 02:53, Raag Jadav escreveu: > > > On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: > > > > Hi Raag, > >

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-03-11 Thread Raag Jadav
On Mon, Mar 10, 2025 at 06:03:27PM -0400, Alex Deucher wrote: > On Mon, Mar 10, 2025 at 5:54 PM André Almeida wrote: > > > > Em 01/03/2025 03:04, Raag Jadav escreveu: > > > On Fri, Feb 28, 2025 at 06:49:43PM -0300, André Almeida wrote: > > >> Hi Raag, > &

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-03-11 Thread Raag Jadav
On Mon, Mar 10, 2025 at 06:27:53PM -0300, André Almeida wrote: > Em 01/03/2025 02:53, Raag Jadav escreveu: > > On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: > > > Hi Raag, > > > > > > On 2/28/25 11:20, Raag Jadav wrote: > > > > Cc

Re: [PATCH v3 0/2] Cleanup io.h

2025-03-01 Thread Raag Jadav
On Fri, Feb 28, 2025 at 08:42:10PM +0200, Andy Shevchenko wrote: > On Fri, Feb 28, 2025 at 08:41:33PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 28, 2025 at 07:41:55PM +0200, Raag Jadav wrote: > > > On Fri, Feb 28, 2025 at 06:11:16PM +0100, Arnd Bergmann wrote: > > >

Re: [PATCH v3 0/2] Cleanup io.h

2025-03-01 Thread Raag Jadav
On Fri, Feb 28, 2025 at 06:11:16PM +0100, Arnd Bergmann wrote: > On Thu, Feb 27, 2025, at 16:25, Andy Shevchenko wrote: > > On Thu, Feb 27, 2025 at 12:37:45PM +0530, Raag Jadav wrote: > >> This series attempts to cleanup io.h with "include what you use" approach.

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-02-28 Thread Raag Jadav
On Fri, Feb 28, 2025 at 06:49:43PM -0300, André Almeida wrote: > Hi Raag, > > On 2/28/25 11:58, Raag Jadav wrote: > > On Fri, Feb 28, 2025 at 09:13:53AM -0300, André Almeida wrote: > > > To notify userspace about which app (if any) made the device get in a > &

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-02-28 Thread Raag Jadav
On Fri, Feb 28, 2025 at 06:54:12PM -0300, André Almeida wrote: > Hi Raag, > > On 2/28/25 11:20, Raag Jadav wrote: > > Cc: Lucas > > > > On Fri, Feb 28, 2025 at 09:13:52AM -0300, André Almeida wrote: > > > When a device get wedged, it might be caused by a gui

Re: [PATCH v3 0/2] Cleanup io.h

2025-02-28 Thread Raag Jadav
On Fri, Feb 28, 2025 at 08:52:51PM +0200, Andy Shevchenko wrote: > On Fri, Feb 28, 2025 at 08:45:26PM +0200, Raag Jadav wrote: > > On Fri, Feb 28, 2025 at 08:42:10PM +0200, Andy Shevchenko wrote: > > > On Fri, Feb 28, 2025 at 08:41:33PM +0200, Andy Shevchenko wrote: > > >

Re: [PATCH 2/2] drm/amdgpu: Make use of drm_wedge_app_info

2025-02-28 Thread Raag Jadav
On Fri, Feb 28, 2025 at 09:13:53AM -0300, André Almeida wrote: > To notify userspace about which app (if any) made the device get in a > wedge state, make use of drm_wedge_app_info parameter, filling it with > the app PID and name. > > Signed-off-by: André Almeida > --- > drivers/gpu/drm/amd/amd

Re: [PATCH 1/2] drm: Create an app info option for wedge events

2025-02-28 Thread Raag Jadav
Cc: Lucas On Fri, Feb 28, 2025 at 09:13:52AM -0300, André Almeida wrote: > When a device get wedged, it might be caused by a guilty application. > For userspace, knowing which app was the cause can be useful for some > situations, like for implementing a policy, logs or for giving a chance > for t

[PATCH v3 1/2] drm/draw: include missing headers

2025-02-26 Thread Raag Jadav
Include headers for the symbols directly used in this file instead of relying on intermediate headers. Signed-off-by: Raag Jadav Acked-by: Simona Vetter --- drivers/gpu/drm/drm_draw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_draw.c b/drivers/gpu/drm/drm_draw.c

[PATCH v3 0/2] Cleanup io.h

2025-02-26 Thread Raag Jadav
.intel.com [2] https://lore.kernel.org/r/2342b516-2c6e-42e5-b4f4-579b28082...@app.fastmail.com [3] https://lore.kernel.org/r/f6eb011b-40fb-409a-b2b2-a09d0e770...@app.fastmail.com v2: Fix sparc build errors v3: Fix nios2 build errors and re-order patches Raag Jadav (2): drm/draw: include missi

[PATCH v3 2/2] io.h: drop unused headers

2025-02-26 Thread Raag Jadav
Drop unused headers and type declaration from io.h. Signed-off-by: Raag Jadav Acked-by: Andy Shevchenko --- include/linux/io.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/io.h b/include/linux/io.h index 40cb2de73f5e..6a6bc4d46d0a 100644 --- a/include/linux/io.h +++ b

Re: [PATCH v2 0/2] Cleanup io.h

2025-02-21 Thread Raag Jadav
On Fri, Feb 21, 2025 at 11:15:47AM +0100, Arnd Bergmann wrote: > On Fri, Feb 21, 2025, at 06:08, Raag Jadav wrote: > > In a wider effort to improve build speeds, we're attempting to split/cleanup > > core headers. > > > > This series attempts to cleanup io.h with

Re: [PATCH v2 2/2] drm/draw: include bug.h

2025-02-21 Thread Raag Jadav
On Fri, Feb 21, 2025 at 10:49:48AM +0100, Simona Vetter wrote: > On Fri, Feb 21, 2025 at 07:05:12AM +0100, Greg KH wrote: > > On Fri, Feb 21, 2025 at 10:38:04AM +0530, Raag Jadav wrote: > > > Directly include bug.h for WARN() helpers instead of relying on > >

[PATCH v2 1/2] io.h: drop unused headers

2025-02-20 Thread Raag Jadav
Drop unused headers and type declaration from io.h. Signed-off-by: Raag Jadav --- include/linux/io.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/io.h b/include/linux/io.h index 40cb2de73f5e..6a6bc4d46d0a 100644 --- a/include/linux/io.h +++ b/include/linux/io.h @@ -9,13

[PATCH v2 2/2] drm/draw: include bug.h

2025-02-20 Thread Raag Jadav
Directly include bug.h for WARN() helpers instead of relying on intermediate headers. Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_draw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_draw.c b/drivers/gpu/drm/drm_draw.c index cb2ad12bce57..0a0e1eebf481 100644

[PATCH v2 0/2] Cleanup io.h

2025-02-20 Thread Raag Jadav
with it, or let Andy know if you'd rather let him carry them. [1] https://lore.kernel.org/r/z7cqcame4lxtt...@black.fi.intel.com/ v2: Fix drm_draw.c build errors Raag Jadav (2): io.h: drop unused headers drm/draw: include bug.h drivers/gpu/drm/drm_draw.c | 1 + include/linux/io.h

Re: [PATCH v12 0/5] Introduce DRM device wedged event

2025-02-11 Thread Raag Jadav
On Tue, Feb 04, 2025 at 12:35:23PM +0530, Raag Jadav wrote: > This series introduces device wedged event in DRM subsystem and uses it > in xe, i915 and amdgpu drivers. Detailed description in commit message. > > This was earlier attempted as xe specific uevent in v1 and v2 on [1]. &g

[PATCH v12 5/5] drm/amdgpu: Use device wedged event

2025-02-03 Thread Raag Jadav
From: André Almeida Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma Signed-off-by: André Alme

[PATCH v12 4/5] drm/i915: Use device wedged event

2025-02-03 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu

[PATCH v12 0/5] Introduce DRM device wedged event

2025-02-03 Thread Raag Jadav
et chapter (André) Wedged event support for amdgpu (André) v12: Refine consumer expectations and terminologies (Xaver, Pekka) André Almeida (1): drm/amdgpu: Use device wedged event Raag Jadav (4): drm: Introduce device wedged event drm/doc: Document device wedged event drm/xe: Use dev

[PATCH v12 3/5] drm/xe: Use device wedged event

2025-02-03 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device.c | 7 ++- 1 fi

[PATCH v12 2/5] drm/doc: Document device wedged event

2025-02-03 Thread Raag Jadav
leanup and consumer prerequisites (Christian, Aravind) v11: Reference wedged event in device reset chapter (André) v12: Refine consumer expectations and terminologies (Xaver, Pekka) Signed-off-by: Raag Jadav Reviewed-by: Christian König Reviewed-by: André Almeida --- Documentation/gpu/drm-uapi

[PATCH v12 1/5] drm: Introduce device wedged event

2025-02-03 Thread Raag Jadav
djustments (Andy) Handle invalid recovery method v8: Allow sending multiple methods with uevent (Lucas, Michal) static_assert() globally (Andy) v9: Provide 'none' method for device reset (Christian) Provide recovery opts using switch c

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2025-01-28 Thread Raag Jadav
On Tue, Jan 28, 2025 at 01:38:09PM +0200, Pekka Paalanen wrote: > On Tue, 28 Jan 2025 11:37:53 +0200 > Raag Jadav wrote: > > > On Mon, Jan 27, 2025 at 12:23:28PM +0200, Pekka Paalanen wrote: > > > On Wed, 22 Jan 2025 07:22:25 +0200 > > > Raag Jadav wrote: >

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2025-01-28 Thread Raag Jadav
On Mon, Jan 27, 2025 at 12:23:28PM +0200, Pekka Paalanen wrote: > On Wed, 22 Jan 2025 07:22:25 +0200 > Raag Jadav wrote: > > > On Tue, Jan 21, 2025 at 02:14:56AM +0100, Xaver Hugl wrote: > > > > +It is the responsibility of the consumer to make sure that the devi

[PATCH v11 3/5] drm/xe: Use device wedged event

2025-01-23 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device.c | 7 ++- 1 fi

[PATCH v11 5/5] drm/amdgpu: Use device wedged event

2025-01-23 Thread Raag Jadav
From: André Almeida Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma Signed-off-by: André Alme

[PATCH v11 1/5] drm: Introduce device wedged event

2025-01-23 Thread Raag Jadav
tatic_assert() globally (Andy) v9: Provide 'none' method for device reset (Christian) Provide recovery opts using switch cases v11: Log device reset (André) Signed-off-by: Raag Jadav Reviewed-by: André Almeida --- drivers/gpu/drm/drm_drv.c | 68

[PATCH v11 4/5] drm/i915: Use device wedged event

2025-01-23 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu

[PATCH v11 2/5] drm/doc: Document device wedged event

2025-01-23 Thread Raag Jadav
leanup and consumer prerequisites (Christian, Aravind) v11: Reference wedged event in device reset section (André) Signed-off-by: Raag Jadav Reviewed-by: Christian König Reviewed-by: André Almeida --- Documentation/gpu/drm-uapi.rst | 112 - 1 file changed, 109 insert

[PATCH v11 0/5] Introduce DRM device wedged event

2025-01-23 Thread Raag Jadav
et section (André) Wedged event support for amdgpu (André) André Almeida (1): drm/amdgpu: Use device wedged event Raag Jadav (4): drm: Introduce device wedged event drm/doc: Document device wedged event drm/xe: Use device wedged event drm/i915: Use device wedged event Documentati

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2025-01-21 Thread Raag Jadav
On Tue, Jan 21, 2025 at 02:14:56AM +0100, Xaver Hugl wrote: > > +It is the responsibility of the consumer to make sure that the device or > > +its resources are not in use by any process before attempting recovery. > I'm not convinced this is actually doable in practice, outside of > killing all ap

Re: [PATCH v10 0/4] Introduce DRM device wedged event

2025-01-21 Thread Raag Jadav
On Tue, Jan 21, 2025 at 01:59:47AM +0100, Xaver Hugl wrote: > Hi, > > I experimented with using this in KWin, and > https://invent.kde.org/plasma/kwin/-/merge_requests/7027/diffs?commit_id=6da40f1b9e2bc94615a436de4778880cee16f940 > makes it fall back to a software renderer when a rebind is require

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2024-12-17 Thread Raag Jadav
On Thu, Dec 12, 2024 at 03:50:29PM -0300, André Almeida wrote: > Em 28/11/2024 12:37, Raag Jadav escreveu: > > Add documentation for device wedged event in a new 'Device wedging' > > chapter. The describes basic definitions, prerequisites and consumer > > exp

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Raag Jadav
2/16/2024 3:48 PM, Christian König wrote: > > > > > Am 13.12.24 um 16:56 schrieb André Almeida: > > > > > > Em 13/12/2024 11:36, Raag Jadav escreveu: > > > > > > > On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: > > > > &g

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-13 Thread Raag Jadav
On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: > Hi Christian, > > Em 13/12/2024 04:34, Christian König escreveu: > > Am 12.12.24 um 20:09 schrieb André Almeida: > > > Use DRM's device wedged event to notify userspace that a reset had > > > happened. For now, only use `none` method

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-13 Thread Raag Jadav
On Thu, Dec 12, 2024 at 03:31:01PM -0300, André Almeida wrote: > Hi Raag, > > Thank you for your patch. > > Em 28/11/2024 12:37, Raag Jadav escreveu: > > [...] > > > +int drm_dev_wedged_event(struct drm_device *dev, unsigned long method) > > +{

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-12 Thread Raag Jadav
On Wed, Dec 11, 2024 at 06:14:12PM +0100, Maxime Ripard wrote: > On Wed, Dec 04, 2024 at 01:17:17PM +0200, Raag Jadav wrote: > > + misc maintainers > > > > On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote: > > > Am 03.12.24 um 06:00 schrieb Raag Jadav

Re: [PATCHv10 00/10] Display Global Histogram

2024-12-09 Thread Raag Jadav
On Mon, Dec 09, 2024 at 10:18:42AM -0800, Matt Roper wrote: > On Mon, Dec 09, 2024 at 07:43:55PM +0200, Raag Jadav wrote: > > On Mon, Dec 09, 2024 at 08:57:56AM -0800, Matt Roper wrote: > > > On Mon, Dec 09, 2024 at 09:54:54PM +0530, Arun R Murthy wrote: > > > > D

Re: [PATCHv10 00/10] Display Global Histogram

2024-12-09 Thread Raag Jadav
On Mon, Dec 09, 2024 at 10:18:42AM -0800, Matt Roper wrote: > On Mon, Dec 09, 2024 at 07:43:55PM +0200, Raag Jadav wrote: > > On Mon, Dec 09, 2024 at 08:57:56AM -0800, Matt Roper wrote: > > > On Mon, Dec 09, 2024 at 09:54:54PM +0530, Arun R Murthy wrote: > > > > D

Re: [PATCHv10 00/10] Display Global Histogram

2024-12-09 Thread Raag Jadav
On Mon, Dec 09, 2024 at 08:57:56AM -0800, Matt Roper wrote: > On Mon, Dec 09, 2024 at 09:54:54PM +0530, Arun R Murthy wrote: > > Display histogram is a hardware functionality where a statistics for 'x' > > number of frames is generated to form a histogram data. This is notified > > to the user via

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-04 Thread Raag Jadav
+ misc maintainers On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote: > Am 03.12.24 um 06:00 schrieb Raag Jadav: > > On Mon, Dec 02, 2024 at 10:07:59AM +0200, Raag Jadav wrote: > > > On Fri, Nov 29, 2024 at 10:40:14AM -0300, André Almeida wrote: > > > >

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-02 Thread Raag Jadav
On Mon, Dec 02, 2024 at 10:07:59AM +0200, Raag Jadav wrote: > On Fri, Nov 29, 2024 at 10:40:14AM -0300, André Almeida wrote: > > Hi Raag, > > > > Em 28/11/2024 12:37, Raag Jadav escreveu: > > > Introduce device wedged event, which notifies userspace of 'wedge

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-02 Thread Raag Jadav
On Fri, Nov 29, 2024 at 10:40:14AM -0300, André Almeida wrote: > Hi Raag, > > Em 28/11/2024 12:37, Raag Jadav escreveu: > > Introduce device wedged event, which notifies userspace of 'wedged' > > (hanged/unusable) state of the DRM device through a uevent. This is

[PATCH v10 0/4] Introduce DRM device wedged event

2024-11-28 Thread Raag Jadav
(Andy) v9: Document prerequisites section (Christian) Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases v10: Clarify mmap cleanup and consumer prerequisites (Christian, Aravind) Raag Jadav (4): drm: Introduce device wedged event

[PATCH v10 4/4] drm/i915: Use device wedged event

2024-11-28 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu

[PATCH v10 1/4] drm: Introduce device wedged event

2024-11-28 Thread Raag Jadav
globally (Andy) v9: Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_drv.c | 66 +++ include/drm/drm_device.h | 8 + include/drm/drm_drv.h | 1 +

[PATCH v10 2/4] drm/doc: Document device wedged event

2024-11-28 Thread Raag Jadav
leanup and consumer prerequisites (Christian, Aravind) Signed-off-by: Raag Jadav Reviewed-by: Christian König --- Documentation/gpu/drm-uapi.rst | 112 - 1 file changed, 109 insertions(+), 3 deletions(-) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentati

[PATCH v10 3/4] drm/xe: Use device wedged event

2024-11-28 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device.c | 9 +++

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-25 Thread Raag Jadav
On Mon, Nov 25, 2024 at 10:32:42AM +0100, Christian König wrote: > Am 22.11.24 um 17:02 schrieb Raag Jadav: > > On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: > > > Am 22.11.24 um 08:07 schrieb Raag Jadav: > > > > On Mon, Nov 18, 2024 at 08:26:37PM +

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-22 Thread Raag Jadav
On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: > Am 22.11.24 um 08:07 schrieb Raag Jadav: > > On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: > > > On 15/11/24 10:37, Raag Jadav wrote: > > > > Introduce device wedged event, which

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-21 Thread Raag Jadav
On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: > On 15/11/24 10:37, Raag Jadav wrote: > > Introduce device wedged event, which notifies userspace of 'wedged' > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful espec

Re: [PATCH v9 3/4] drm/xe: Use device wedged event

2024-11-19 Thread Raag Jadav
On Tue, Nov 19, 2024 at 10:25:10AM +0530, Ghimiray, Himal Prasad wrote: > On 15-11-2024 10:37, Raag Jadav wrote: > > This was previously attempted as xe specific reset uevent but dropped > > in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") &

[PATCH v9 3/4] drm/xe: Use device wedged event

2024-11-14 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 9 +++-- 1 file changed, 7 insert

[PATCH v9 2/4] drm/doc: Document device wedged event

2024-11-14 Thread Raag Jadav
Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) v9: Add prerequisites section (Christian) Signed-off-by: Raag Jadav --- Documen

[PATCH v9 4/4] drm/i915: Use device wedged event

2024-11-14 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 3

[PATCH v9 1/4] drm: Introduce device wedged event

2024-11-14 Thread Raag Jadav
Aesthetic adjustments (Andy) Handle invalid method cases v8: Allow sending multiple methods with uevent (Lucas, Michal) static_assert() globally (Andy) v9: Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases Signed-off-by: Raag Jadav

[PATCH v9 0/4] Introduce DRM device wedged event

2024-11-14 Thread Raag Jadav
: Document prerequisites section (Christian) Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases Raag Jadav (4): drm: Introduce device wedged event drm/doc: Document device wedged event drm/xe: Use device wedged event drm/i915: Use device we

Re: [PATCH v8 2/4] drm/doc: Document device wedged event

2024-10-31 Thread Raag Jadav
On Tue, Oct 29, 2024 at 10:51:34AM +0100, Christian König wrote: > Am 25.10.24 um 10:48 schrieb Raag Jadav: > > Add documentation for device wedged event in a new 'Device wedging' > > chapter. The describes basic definitions and consumer expectations > > along with a

Re: [PATCH v8 1/4] drm: Introduce device wedged event

2024-10-26 Thread Raag Jadav
On Fri, Oct 25, 2024 at 05:45:59PM +0300, Andy Shevchenko wrote: > On Fri, Oct 25, 2024 at 12:08:50PM +0300, Jani Nikula wrote: > > On Fri, 25 Oct 2024, Raag Jadav wrote: > > ... > > > > +/* > > > + * Available recovery methods for wedged device.

[PATCH v8 4/4] drm/i915: Use device wedged event

2024-10-25 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 3

[PATCH v8 3/4] drm/xe: Use device wedged event

2024-10-25 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 9 +++-- 1 file changed, 7 insert

[PATCH v8 2/4] drm/doc: Document device wedged event

2024-10-25 Thread Raag Jadav
Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) Signed-off-by: Raag Jadav --- Documentation/gpu/drm-uap

[PATCH v8 1/4] drm: Introduce device wedged event

2024-10-25 Thread Raag Jadav
Handle invalid method cases v8: Allow sending multiple methods with uevent (Lucas, Michal) static_assert() globally (Andy) Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_drv.c | 51 +++ include/drm/drm_device.h | 7 ++ include/drm/drm_drv.h

[PATCH v8 0/4] Introduce DRM device wedged event

2024-10-25 Thread Raag Jadav
functions (Andy, Jani) Aesthetic adjustments (Andy) Handle invalid method cases Add documentation to drm-uapi.rst (Sima) v8: Drop sysfs and allow sending multiple methods with uevent (Lucas, Michal) Improve documentation (Christian, Rodrigo) static_assert() globally (Andy) Raag Jadav

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-19 Thread Raag Jadav
On Thu, Oct 17, 2024 at 04:16:09PM -0300, André Almeida wrote: > Hi Raag, > > Em 30/09/2024 04:38, Raag Jadav escreveu: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > >

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-18 Thread Raag Jadav
On Fri, Oct 18, 2024 at 02:54:38PM +0200, Christian König wrote: > Am 18.10.24 um 14:46 schrieb Raag Jadav: > > > As far as I can see this makes the enum how to recover the device > > > superfluous because you will most likely always need a bus reset to get > > > out

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-18 Thread Raag Jadav
On Fri, Oct 18, 2024 at 12:58:09PM +0200, Christian König wrote: > Am 17.10.24 um 18:43 schrieb Rodrigo Vivi: > > On Thu, Oct 17, 2024 at 09:59:10AM +0200, Christian König wrote: > > > > > Purpose of this implementation is to provide drivers a generic way to > > > > > recover with the help of users

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-16 Thread Raag Jadav
On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > Introduce device wedged event, which will notify userspace of wedged > (hanged/unusable) state of the DRM device through a uevent. This is > useful especially in cases where the device is no longer operating as > expected

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-11 Thread Raag Jadav
On Thu, Oct 10, 2024 at 08:02:10AM -0500, Lucas De Marchi wrote: > On Tue, Oct 08, 2024 at 06:02:43PM +0300, Raag Jadav wrote: > > On Thu, Oct 03, 2024 at 03:23:22PM +0300, Raag Jadav wrote: > > > On Tue, Oct 01, 2024 at 02:20:29PM +0200, Michal Wajdeczko wrote: > > >

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-08 Thread Raag Jadav
On Thu, Oct 03, 2024 at 03:23:22PM +0300, Raag Jadav wrote: > On Tue, Oct 01, 2024 at 02:20:29PM +0200, Michal Wajdeczko wrote: > > On 30.09.2024 09:38, Raag Jadav wrote: > > > > > > +/** > > > + * enum drm_wedge_recovery - Recovery method for wedged device i

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-03 Thread Raag Jadav
On Tue, Oct 01, 2024 at 02:20:29PM +0200, Michal Wajdeczko wrote: > Hi, > > sorry for late comments, Sure, no problem. > On 30.09.2024 09:38, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Raag Jadav
On Tue, Oct 01, 2024 at 05:54:46PM +0300, Andy Shevchenko wrote: > On Tue, Oct 01, 2024 at 05:18:33PM +0300, Raag Jadav wrote: > > On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote: > > > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > > > &

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Raag Jadav
On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote: > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > > On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > > > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > > ...

Re: [PATCH v7 2/5] drm: Expose wedge recovery methods

2024-09-30 Thread Raag Jadav
On Mon, Sep 30, 2024 at 04:01:38PM +0300, Andy Shevchenko wrote: > On Mon, Sep 30, 2024 at 01:08:42PM +0530, Raag Jadav wrote: > > Now that we have device wedged event in place, add wedge_recovery sysfs > > attribute which will expose recovery methods supported by the DRM devi

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-09-30 Thread Raag Jadav
On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > >

[PATCH v7 5/5] drm/i915: Use device wedged event

2024-09-30 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 2

[PATCH v7 4/5] drm/xe: Use device wedged event

2024-09-30 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 17 +++-- drivers/gpu/drm/xe/xe_dev

[PATCH v7 3/5] drm/doc: Document device wedged event

2024-09-30 Thread Raag Jadav
Add documentation for device wedged event along with its consumer expectations. For now it is amended to 'Device reset' chapter, but with extended functionality in the future it can be refactored into its own chapter. Signed-off-by: Raag Jadav --- Documentation/gpu/drm-uap

  1   2   >