On 8 July 2014 21:25, Inki Dae wrote:
> 2014-06-20 0:13 GMT+09:00 Rahul Sharma :
>> This situation arises when userspace remove the frambuffer object
>> and call setmode ioctl.
>>
>> drm_mode_rmfb --> drm_plane_force_disable --> plane->crt
Hi Inki,
What do you think about the following fix? I need your inputs for this.
Regards,
Rahul Sharma
On 19 June 2014 20:43, Rahul Sharma wrote:
> This situation arises when userspace remove the frambuffer object
> and call setmode ioctl.
>
> drm_mode_rmfb --> drm_plan
timing_base = 0x0,
> .has_shadowcon = 1,
> + .sysreg_disp1blk_offset = 0x210,
offset should be defined as Macros in reg file.
> };
>
> static struct fimd_driver_data exynos5_fimd_driver_data = {
> .timing_base = 0x2,
> .has_shadowcon = 1,
&
Thanks Inki,
One more thing. mixer_layer_update is only called on for mixer version;
MXR_VER_16_0_33_0, MXR_VER_128_0_0_184. This condition
should have taken care of Exynos4 scenarios. What you say?
Regards,
Rahul Sharma.
On 24 June 2014 20:20, Inki Dae wrote:
> 2014-06-24 20:38 GMT+09
Hi Tomasz,
On 23 June 2014 20:08, Tomasz Figa wrote:
> Hi Rahul,
>
> On 23.06.2014 15:58, Rahul Sharma wrote:
>> Hi Ajay, Inki,
>>
>> I tested this series for Exynos5420 based peach-pit board,
>> Exynos5800 based Peach-pi board and Exynos5250 based
>> Snow
:
Tested-by: Rahul Sharma
Regards,
Rahul Sharma.
On 20 June 2014 21:21, Inki Dae wrote:
> 2014-06-20 17:06 GMT+09:00 Ajay kumar :
>> ping.
>
> I will have a review soon but I'm afraid that I cannot have a test yet
> because I have no any board with panel based on eDP and L
HDMI probe proceeds with dummy regulators when the regulators
are not provided in DT node or regulator provider has not get
probed or failed to register the regulators.
This patch modify hdmi driver to defer the probe in case the
regulators are not available.
Signed-off-by: Rahul Sharma
---
v2
mixer_wait_for_vblank function expects that the upcoming
vsync interrupt handler routine will clear the
wait_vsync_event atomic variable.
For this to happen, interrupts should be enabled and
disabled properly.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c |4
1
Mixer soft reset is a recommended step before reconfiguring
the mixer after power on. Mixer looses the previous state of
DMAs if soft reset. This is the recommendation from the
hardware team.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c |2 ++
1 file changed, 2
Allowing only one layer update per vsync can cause issues
while there are update available for both layers. There is
a good amount of possibility to loose updates if we allow
single update per vsync.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c |7 +--
1 file
Mixer should be power gated only after it is gracefully stopped.
The recommended sequence is to Stop the mixer and wait till
it enters to IDLE state before gating the clocks and power to
the mixer.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c | 15
device power enabled.
Similar logic for poweroff sequence.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos
Fixes for various issues which are to Power On/Off sequence,
Layer update, waiting for vblank in exynos mixer driver.
v2: 1) Repalce mixer_enable_vblank with drm_vblank_get.
This series is based on exynos-drm-fixes branch in Inki dae's tree.
Rahul Sharma (5):
drm/exynos: set power
Hi All,
On 18 June 2014 17:04, Rahul Sharma wrote:
> mixer_wait_for_vblank function expects that the upcoming
> vsync interrupt handler routine will clear the
> wait_vsync_event atomic variable.
>
> For this to happen, interrupts should be enabled and
> disabled properly.
crashes the system.
Signed-off-by: Rahul Sharma
---
This works fine but I am not confident on the correctness of the
solution.
drivers/gpu/drm/exynos/exynos_drm_crtc.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
b/drivers/gpu/drm/exynos
Thanks Inki,
On 19 June 2014 09:34, Inki Dae wrote:
> On 2014? 06? 18? 22:42, Rahul Sharma wrote:
>> HDMI probe proceeds with dummy regulators when the regulators
>> are not provided in DT node or regulator provider has not get
>> probed or failed to register the regulat
HDMI probe proceeds with dummy regulators when the regulators
are not provided in DT node or regulator provider has not get
probed or failed to register the regulators.
This patch modify hdmi driver to defer the probe in case the
regulators are not available.
Signed-off-by: Rahul Sharma
mixer_wait_for_vblank function expects that the upcoming
vsync interrupt handler routine will clear the
wait_vsync_event atomic variable.
For this to happen, interrupts should be enabled and
disabled properly.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c |4
1
Mixer soft reset is a recommended step before reconfiguring
the mixer after power on. Mixer looses the previous state of
DMAs if soft reset. This is the recommendation from the
hardware team.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c |2 ++
1 file changed, 2
Allowing only one layer update per vsync can cause issues
while there are update available for both layers. There is
a good amount of possibility to loose updates if we allow
single update per vsync.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c |7 +--
1 file
Mixer should be power gated only after it is gracefully stopped.
The recommended sequence is to Stop the mixer and wait till
it enters to IDLE state before gating the clocks and power to
the mixer.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c | 15
device power enabled.
Similar logic for poweroff sequence.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_mixer.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos
Fixes for various issues which are to Power On/Off sequence,
Layer update, waiting for vblank in exynos mixer driver.
This series is based on exynos-drm-fixes branch in Inki dae's tree.
Rahul Sharma (5):
drm/exynos: set power state variable after enabling clocks and power
drm/exynos:
On 2 June 2014 14:41, Andrzej Hajda wrote:
> Hi Rahul,
>
> On 05/28/2014 08:11 AM, Rahul Sharma wrote:
>> System hangs when FIMD registers are accessed to disable
>> hardware overlays. This is because of the clocks which are
>> not enabled before register access.
>
,
Rahul Sharma.
On 27 May 2014 18:28, Inki Dae wrote:
> On 2014? 05? 27? 18:55, Rahul Sharma wrote:
>>
>>
>> On 26 May 2014 14:21, Rahul Sharma wrote:
>>> Hi Daniel,
>>>
>>> On 26 May 2014 13:11, Daniel Kurtz wrote:
>>>> On Mon,
System hangs when FIMD registers are accessed to disable
hardware overlays. This is because of the clocks which are
not enabled before register access.
'Hardware overlay disable' is cleaned from the FIMD probe.
Signed-off-by: Rahul Sharma
---
Based on exynos-drm-next branch.
drive
On 26 May 2014 14:21, Rahul Sharma wrote:
> Hi Daniel,
>
> On 26 May 2014 13:11, Daniel Kurtz wrote:
>> On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma
>> wrote:
>>>
>>> Hi Inki,
>>>
>>> Please review this patch.
> [snip]
>>&g
Hi Daniel,
On 26 May 2014 13:11, Daniel Kurtz wrote:
> On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma
> wrote:
>>
>> Hi Inki,
>>
>> Please review this patch.
[snip]
>> > +
>> > + ret = clk_prepare_enable(ctx->lcd_clk);
>
> Hi Rahul,
Hi Inki,
Please review this patch.
Regards,
Rahul Sharma
On 23 May 2014 17:17, Rahul Sharma wrote:
> From: Rahul Sharma
>
> Fimd probe is accessing fimd Registers without enabling the fimd
> gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled
> during kerne
From: Rahul Sharma
Fimd probe is accessing fimd Registers without enabling the fimd
gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled
during kernel boottime, the system hangs during boottime.
This issue got surfaced when verifying with sysmmu enabled. Probe of
fimd Sysmmu
ntime_get_sync should
> be called as well, to wake up display pm domain.
>
You are right. I have added pm runtime get sync and put sync.
Regards,
Rahul Sharma.
>
> Regards
> Andrzej
>
>
>>
>> }
>>
>
From: Rahul Sharma
Fimd probe is accessing fimd Registers without enabling the fimd
gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled
during kernel boottime, the system hangs during boottime.
This issue got surfaced when verifying with sysmmu enabled. Probe of
fimd Sysmmu
On 22 May 2014 23:26, Sachin Kamat wrote:
> Hi Rahul,
>
> On 22 May 2014 19:46, Rahul Sharma wrote:
>> Hi Inki,
>>
>> This is another one which has not got reviewed. Please review.
>
> Inki has applied a similar patch from Takashi [1].
Thanks Sachin,
Good
Hi Inki,
This is another one which has not got reviewed. Please review.
Regards,
Rahul Sharma
On 30 April 2014 19:11, Rahul Sharma wrote:
> From: Rahul Sharma
>
> While testing S2R on exynos board, system is hanging and
> rebooting due to nested mutex_lock calls in exynos
Hi Inki,
Please review this patch.
Regards,
Rahul Sharma
On 3 April 2014 20:41, Rahul Sharma wrote:
> From: Shirish S
>
> This patch implements the power on/off sequence
> of HDMI PHY in exynos5420 and exynos5250 as provided
> by the hardware team.
>
> This has been
before accessing sysmmu regs and
then disables. Later fimd probe tries to read the register without
enabling the clock which is wrong and hangs the system.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 17 -
1 file changed, 16 insertions(+), 1
On 22 May 2014 13:33, Thierry Reding wrote:
> On Thu, May 22, 2014 at 12:06:16PM +0530, Rahul Sharma wrote:
>> On 22 May 2014 11:51, Sachin Kamat wrote:
>> > Hi Rahul,
>> [snip]
>> >>
>> >> + clk_prepare_enable(ctx->b
On 22 May 2014 12:25, Inki Dae wrote:
> On 2014? 05? 22? 13:36, Rahul Sharma wrote:
>> Hi Inki,
>>
>> On 21 May 2014 16:43, Inki Dae wrote:
>>>
>>> Hi Rahul,
>>>
>>> On 2014? 05? 07? 20:25, Rahul Sharma wrote:
>>>> From: R
On 22 May 2014 11:51, Sachin Kamat wrote:
> Hi Rahul,
[snip]
>>
>> + clk_prepare_enable(ctx->bus_clk);
>
> Probably a check for its success?
>
>> + clk_prepare_enable(ctx->lcd_clk);
>
Generally we don't check this in any of the driver. I
Thanks Sachin.
On 22 May 2014 11:38, Sachin Kamat wrote:
> Hi Rahul,
>
> On 7 May 2014 17:21, Rahul Sharma wrote:
>> From: Rahul Sharma
>>
>> Allow to allocate non-contigous buffers when iommu is enabled.
>> Currently, it tries to allocates contigous buffer whi
From: Rahul Sharma
Allow to allocate non-contigous buffers when iommu is enabled.
Currently, it tries to allocates contigous buffer which consistently
fail for large buffers and then fall back to non contigous. Apart
from being slow, this implementation is also very noisy and fills
the screen
Hi Inki,
The below fix doesn't affect the FB dev buffer allocation. IMO the scenario
where u-boot allocates the buffer is not disturbed.
Please review the implementation.
Regards,
Rahul Sharma.
On 7 May 2014 17:21, Rahul Sharma wrote:
> From: Rahul Sharma
>
> Allow to allocate
From: Rahul Sharma
Fimd probe is accessing fimd Registers without enabling the fimd
gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled
during kernel boottime, the system hangs during boottime.
This issue got surfaced when verifying with sysmmu enabled. Probe of
fimd Sysmmu
Hi Inki,
On 21 May 2014 16:43, Inki Dae wrote:
>
> Hi Rahul,
>
> On 2014? 05? 07? 20:25, Rahul Sharma wrote:
>> From: Rahul Sharma
>>
>> In case of exynos, setting dma-burst to 16Word causes permanent
>> tearing for very small buffers, e.g. cursor buffer. Bur
Hi Inki, Tomasz,
Any comment on this patch?
Regards,
Rahul Sharma
On 20 May 2014 10:36, Rahul Sharma wrote:
> Exynos drm hdmi driver used to get dummy hdmiphy clock to
> control the PMU bit for hdmiphy. This bit needs to be set
> before setting any resolution to hdmi hardware.
On 19 May 2014 16:24, Tomasz Figa wrote:
> On 19.05.2014 09:10, Rahul Sharma wrote:
>> On 16 May 2014 20:19, Tomasz Figa wrote:
>>> On 16.05.2014 16:30, Rahul Sharma wrote:
>>>> On 16 May 2014 16:20, Tomasz Figa wrote:
>>>>> On 16.05.2014 12:35, Ra
driver is modified to control the phy enable bit
inside PMU using regmap interfaces.
Devicetree binding document for hdmi is also updated.
Signed-off-by: Rahul Sharma
---
V2:
1) Squashed hdmiphy clock cleanup patch.
2) Addressed comments related to indentation, using
BIT macro while
On 11 April 2014 07:22, Rahul Sharma wrote:
> Thanks Tomasz,
>
> This patch is not longer required after rebasing to Tomasz Stanislawski's
> Simple Phy patches.
>
Hi All,
We had further discussion on the "Simple Phy Driver" at
http://www.spinics.net/lists/linux-
On 16 May 2014 20:19, Tomasz Figa wrote:
> On 16.05.2014 16:30, Rahul Sharma wrote:
>> On 16 May 2014 16:20, Tomasz Figa wrote:
>>> On 16.05.2014 12:35, Rahul Sharma wrote:
>>>> On 16 May 2014 15:12, Rahul Sharma wrote:
>>>>> On 16 May 2014 03:14, T
On 16 May 2014 16:20, Tomasz Figa wrote:
> On 16.05.2014 12:35, Rahul Sharma wrote:
>> On 16 May 2014 15:12, Rahul Sharma wrote:
>>> On 16 May 2014 03:14, Tomasz Figa wrote:
>>>> On 15.05.2014 06:01, Rahul Sharma wrote:
>> [snip]
>>>>>> the
On 16 May 2014 15:12, Rahul Sharma wrote:
> On 16 May 2014 03:14, Tomasz Figa wrote:
>> On 15.05.2014 06:01, Rahul Sharma wrote:
[snip]
>>>> the PHY provider.
>>>>
>>>
>>> Please correct me if I got you wrong. You want somthing like this:
On 16 May 2014 03:14, Tomasz Figa wrote:
> On 15.05.2014 06:01, Rahul Sharma wrote:
>> Thanks Tomasz,
>>
>> On 15 May 2014 01:31, Tomasz Figa wrote:
>>> Hi Rahul, Tomasz,
>> [snip]
>>>> + simplephys: simple-phys at 1004 {
>>>&g
On 15 May 2014 19:11, Kishon Vijay Abraham I wrote:
>
>
> On Thursday 15 May 2014 07:05 PM, Rahul Sharma wrote:
>> Hi,
>>
>> On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz
>> wrote:
>>>
>>> Hi,
>>>
>>> On Thursday, May 15
Hi,
On 15 May 2014 19:01, Bartlomiej Zolnierkiewicz
wrote:
>
> Hi,
>
> On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote:
>> From: Tomasz Stanislawski
>>
>> Add exynos-simple-phy driver to support a single register
>> PHY interfaces present on Exyn
awski
Signed-off-by: Rahul Sharma
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c
b/drivers/media/platform/s5p-tv/hdmi_drv.c
index 534722c..8013e52 100644
--- a/drivers/media/pla
awski
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 9a6d652..ef1cdd0 100644
--- a/drivers/gpu/drm/exynos/exynos_h
From: Tomasz Stanislawski
Add exynos-simple-phy driver to support a single register
PHY interfaces present on Exynos4 SoC.
Signed-off-by: Tomasz Stanislawski
Signed-off-by: Rahul Sharma
---
.../devicetree/bindings/phy/samsung-phy.txt| 57 ++
drivers/phy/Kconfig
From: Rahul Sharma
Changelog:
v4:
* Rename files to follow "phy-exynos-simple" names.
* Rename Macros to this convention PHY_EXYNOS_SIMPLE_.
* Added list of phy specifier values to documentation file.
* Removed of_match_ptr from driver probe.
On 15 May 2014 13:12, Thierry Reding wrote:
> On Thu, May 15, 2014 at 10:49:37AM +0530, Rahul Sharma wrote:
>> Hi Thierry,
>>
>> On 15 May 2014 03:44, Thierry Reding wrote:
>> > On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote:
> [...]
>> &g
Hi Thierry,
On 15 May 2014 03:44, Thierry Reding wrote:
> On Thu, May 15, 2014 at 12:47:21AM +0530, Rahul Sharma wrote:
> [...]
>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> [...]
>&g
stem_controller: system-controller at 1004 {
...
simple_phys: simple-phys {
compatible = "samsung,exynos5420-simple-phy";
...
};
};
Regards,
Rahul Sharma.
> Otherwise looks good.
>
> Best regards,
> Tomasz
> ___
awski
Signed-off-by: Rahul Sharma
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c
b/drivers/media/platform/s5p-tv/hdmi_drv.c
index 534722c..8013e52 100644
--- a/drivers/media/pla
awski
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 9a6d652..ef1cdd0 100644
--- a/drivers/gpu/drm/exynos/exynos_h
From: Tomasz Stanislawski
Add exynos-simple-phy driver to support a single register
PHY interfaces present on Exynos4 SoC.
Signed-off-by: Tomasz Stanislawski
Signed-off-by: Rahul Sharma
---
.../devicetree/bindings/phy/samsung-phy.txt| 56 ++
drivers/phy/Kconfig
From: Rahul Sharma
Hi All,
This series has been originally proposed by Tomasz Stanislawski. With
his permission, I have addressed the following review comments in V3.
Changelog:
v3:
* Implement lazy-init of PHYs.
* Use MACROs instead of numbers to represent phys.
* Use
On 7 May 2014 21:03, Tomasz Figa wrote:
> [CCing more DT-folks :)]
>
> On 07.05.2014 16:19, Rahul Sharma wrote:
>> On 7 May 2014 19:06, Tomasz Stanislawski wrote:
>>> On 05/07/2014 12:38 PM, Rahul Sharma wrote:
>>>> On 5 May 2014 15:14, Kishon Vijay Abraha
On 7 May 2014 19:06, Tomasz Stanislawski wrote:
> On 05/07/2014 12:38 PM, Rahul Sharma wrote:
>> On 5 May 2014 15:14, Kishon Vijay Abraham I wrote:
>>> Hi,
>>>
>>> On Wednesday 09 April 2014 03:31 PM, Sylwester Nawrocki wrote:
>>>> Hi,
>>>
From: Rahul Sharma
Allow to allocate non-contigous buffers when iommu is enabled.
Currently, it tries to allocates contigous buffer which consistently
fail for large buffers and then fall back to non contigous. Apart
from being slow, this implementation is also very noisy and fills
the screen
From: Rahul Sharma
In case of exynos, setting dma-burst to 16Word causes permanent
tearing for very small buffers, e.g. cursor buffer. Burst Mode
switching, which is based on overlay size is not recommended as
overlay size varies a lot towards the end of the screen. This
causes unstable DMA
On 5 May 2014 15:14, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 09 April 2014 03:31 PM, Sylwester Nawrocki wrote:
>> Hi,
>>
>> On 09/04/14 11:12, Rahul Sharma wrote:
>>> Idea looks good. How about keeping compatible which is independent
>>>
Hi Everybody,
Gentle ping.
Please have a look at the patches in this series?
There are few more in pipeline. Please consider these as well.
http://comments.gmane.org/gmane.linux.kernel.samsung-soc/30501
http://www.spinics.net/lists/linux-samsung-soc/msg28083.html
Warm Regards,
Rahul Sharma
On
From: Rahul Sharma
While testing S2R on exynos board, system is hanging and
rebooting due to nested mutex_lock calls in exynos drm
resume callback. Changing the order of the calls is fixing
the issue.
Signed-off-by: Rahul Sharma
---
Based on exynos-drm-next branch in Inki Dae's tree.
dr
From: Rahul Sharma
While testing S2R on exynos board, system is hanging and
rebooting due to nested mutex_lock calls in exynos drm
resume callback. Changing the order of the calls is fixing
the issue.
Change-Id: I3f3ada8a413a414dca0bbac53cfc5fe3138af4d6
Signed-off-by: Rahul Sharma
---
drivers
Sure (5250, 5420). I will wait for the same to update DT patches, if any.
Regards,
Rahul Sharma.
On 30 April 2014 14:02, Tomasz Stanislawski wrote:
> Hi Rahul,
> I will prepare we v3 version.
> Do you want me to add your patches for exynos5?50 to the patchset?
> Regards,
> Toma
Hi Tomasz,
I have tested your patches for exynos5250 and 5420. Works fine. Are
you planning to post v3? If you want I can share hand with you for v3.
Regards,
Rahul Sharma
On 9 April 2014 17:17, Andreas Oberritter wrote:
> Hello Andrzej,
>
> On 09.04.2014 10:37, Andrzej Ha
From: Rahul Sharma
Fimd probe is accessing fimd Registers without enabling the fimd
gate clocks. This hangs the system at boot time.
This issue got surfaced when verifying with sysmmu enabled. Probe of
fimd Sysmmu enables the master clock before accessing sysmmu regs and
then disables. Later
From: Rahul Sharma
V2:
1) Rebased on Tomasz Stanislawski's Simple phy driver patches
at https://lkml.org/lkml/2014/4/8/226.
Adds apb mapped phy support for exynos5420 hdmi. Replace
dummy hdmiphy clock with regmap calls.
Based on Inki Dae's exynos-drm-next branch.
Rahul Sharma
From: Rahul Sharma
Enable support for hdmi for exynos5420 hdmiphy. Add
compatible string in the of_match table. Also added
hdmiphy configuration values for exynos5420.
Signed-off-by: Rahul Sharma
Signed-off-by: Shirish S
---
.../devicetree/bindings/video/exynos_hdmi.txt |1
From: Rahul Sharma
Previous SoCs have hdmi phys which are accessible through
dedicated i2c lines. Newer SoCs have Apb mapped hdmi phys.
Hdmi driver is modified to support apb mapped phys.
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 142
From: Rahul Sharma
Cleaning up unnecessary i2c read call after hdmiphy configuration.
This check is redundant since check for hdmiphy pll lock status
confirms the correct settings for phy.
Signed-off-by: Rahul Sharma
Signed-off-by: Daniel Kurtz
Reviewed-by: Tomasz Figa
---
drivers/gpu/drm
From: Rahul Sharma
V2:
1) Rebased on Tomasz Stanislawski at https://lkml.org/lkml/2014/4/8/226.
Adds apb mapped phy support for exynos5420 hdmi. Replace
dummy hdmiphy clock with regmap calls.
Based on Inki Dae's exynos-drm-next branch.
Rahul Sharma (3):
drm/exynos: remove unnecessary
On 15 April 2014 19:59, Tomasz Stanislawski wrote:
> On 04/15/2014 03:42 PM, Rahul Sharma wrote:
>> On 15 April 2014 18:41, Tomasz Stanislawski
>> wrote:
>>> On 04/15/2014 11:42 AM, Rahul Sharma wrote:
>>>> Hi Tomasz,
>>>>
>>>&
On 15 April 2014 18:41, Tomasz Stanislawski wrote:
> On 04/15/2014 11:42 AM, Rahul Sharma wrote:
>> Hi Tomasz,
>>
>> On 15 April 2014 14:57, Tomasz Stanislawski
>> wrote:
>>> Adds support for limitation of maximal pixel clock of HDMI
>>> signal. T
diff --git a/include/media/s5p_hdmi.h b/include/media/s5p_hdmi.h
> index 181642b..7272d65 100644
> --- a/include/media/s5p_hdmi.h
> +++ b/include/media/s5p_hdmi.h
> @@ -31,6 +31,7 @@ struct s5p_hdmi_platform_data {
> int mhl_bus;
> struct i2c_board_info *mhl_info;
-- Forwarded message --
From:
Date: 15 April 2014 14:32
Subject: [Bug 74121] New: [3.15-rc1] Exynos: Sandbox report fatal
error "Unexpected 64bit argument detected"
To: dri-devel at lists.freedesktop.org
https://bugzilla.kernel.org/show_bug.cgi?id=74121
Bug ID: 7412
Thanks Tomasz,
On 10 April 2014 22:47, Tomasz Figa wrote:
> Hi Rahul,
>
> On 02.04.2014 19:13, Rahul Sharma wrote:
>>
>> From: Rahul Sharma
>>
>> Previous SoCs have hdmi phys which are accessible through
>> dedicated i2c lines. Newer SoCs have Apb mapped h
Thanks Tomasz,
This patch is not longer required after rebasing to Tomasz Stanislawski's
Simple Phy patches.
Regards,
Rahul Sharma.
On 10 April 2014 22:30, Tomasz Figa wrote:
> Hi Rahul,
>
> On 02.04.2014 19:13, Rahul Sharma wrote:
>>
>> From: Rahul Sharma
>>
Hi Tomasz,
On 10 April 2014 21:02, Tomasz Figa wrote:
> Hi Rahul,
>
> On 02.04.2014 19:13, Rahul Sharma wrote:
>>
>> From: Rahul Sharma
>>
>> Exynos drm hdmi driver used to get dummy hdmiphy clock to
>> control the PMU bit for hdmiphy. This clock is remov
ase of clk it would be easier.
If it is really required to change this divider, it should be registered as
a clock provider in clock driver exposing single divider clock.
Regards,
Rahul Sharma
>
> Regards
> Andrzej
>
>
> ___
>
_provider;
>> +
>> + /* count number of phys to create */
>> + for (count = 0; offsets[count] != ~0; ++count)
>> + ;
>
> count = ARRAY_SIZE(offsets) - 1;
>
>> +
>> + phys = devm_kzalloc(dev, (count + 1) * sizeof(phys[0]), GFP_KERNE
Thanks Inki,
On 3 April 2014 21:23, Inki Dae wrote:
> Hi Rahul,
>
> Thanks for contributions.
>
> 2014-04-03 2:13 GMT+09:00 Rahul Sharma :
>> From: Rahul Sharma
>>
>> Hdmiphy control bit needs to be set before setting the resolution
>> to hdmi hardwar
changed.
Signed-off-by: Rahul Sharma
Signed-off-by: Shirish S
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 40 ++
1 file changed, 16 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_hdmi.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index b2cbf43..fce2f7b 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm
From: Shirish S
This patch implements the power on/off sequence
of HDMI PHY in exynos5420 and exynos5250 as provided
by the hardware team.
This has been verified for mulitple iterations of
S2R.
Signed-off-by: Shirish S
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_hdmi.c
From: Daniel Kurtz
Our resources were just zalloc'ed as part of hdata.
They are already 0.
Signed-off-by: Daniel Kurtz
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_hdmi.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/dr
From: Paul Taysom
Smatch error from arm build: drivers/gpu/drm/exynos/
exynos_hdmi.c:2374 hdmi_probe() error: potential NULL
dereference 'hdata->hdmiphy_port'.
Added check for hdata->hdmiphy_port that it is not NULL.
Signed-off-by: Paul Taysom
Signed-off-by: Rahul Sharma
---
: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 79f98ac..f6d4435 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
-off-by: Sean Paul
Signed-off-by: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_hdmi.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index f3189af..79f98ac 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
From: Rahul Sharma
Series is addressing various issues in the drm hdmi driver
for exynos Soc.
Based on Inki Dae's exynos-drm-next branch.
Daniel Kurtz (1):
drm/exynos: hdmi: remove unnecessary memset
Paul Taysom (1):
drm/exynos: check for null pointers in error handling
Rahul Shar
From: Rahul Sharma
Enable support for hdmi for exynos5420 hdmiphy. Add
compatible string in the of_match table. Also added
hdmiphy configuration values for exynos5420.
Signed-off-by: Rahul Sharma
Signed-off-by: Shirish S
---
.../devicetree/bindings/video/exynos_hdmi.txt |1
1 - 100 of 643 matches
Mail list logo
