[PATCH 8/8] drm/exynos: fimd: add complete_scanout function

2013-01-09 Thread Prathyush K
On Tue, Jan 8, 2013 at 4:18 AM, Mandeep Singh Baines wrote: > On Wed, Dec 26, 2012 at 3:27 AM, Prathyush K > wrote: > > The wait_for_vblank interface is modified to the complete_scanout > > function in fimd. This patch adds the fimd_complete_scanout function > > > >

Re: [PATCH 8/8] drm/exynos: fimd: add complete_scanout function

2013-01-08 Thread Prathyush K
On Tue, Jan 8, 2013 at 4:18 AM, Mandeep Singh Baines wrote: > On Wed, Dec 26, 2012 at 3:27 AM, Prathyush K > wrote: > > The wait_for_vblank interface is modified to the complete_scanout > > function in fimd. This patch adds the fimd_complete_scanout function > > > >

[PATCH] drm/exynos: fimd: modify condition in fimd resume

2013-01-04 Thread Prathyush K
Hi, Please review this patch. Regards, Prathyush On Thu, Dec 27, 2012 at 5:10 PM, Prathyush K wrote: > If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not > call fimd_activate(false) and just returns. Similarily the check in > fimd_resume should not resume if p

Re: [PATCH] drm/exynos: fimd: modify condition in fimd resume

2013-01-04 Thread Prathyush K
Hi, Please review this patch. Regards, Prathyush On Thu, Dec 27, 2012 at 5:10 PM, Prathyush K wrote: > If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not > call fimd_activate(false) and just returns. Similarily the check in > fimd_resume should not resume if p

[PATCH 7/8] drm/exynos: hdmi: add complete_scanout function

2013-01-03 Thread Prathyush K
On Wed, Jan 2, 2013 at 10:12 PM, Sean Paul wrote: > On Wed, Dec 26, 2012 at 6:27 AM, Prathyush K > wrote: > > The wait_for_vblank interface is modified to the complete_scanout > > function in hdmi. This inturn calls the complete_scanout mixer op. > >

[PATCH 8/8] drm/exynos: fimd: add complete_scanout function

2013-01-03 Thread Prathyush K
On Wed, Jan 2, 2013 at 10:24 PM, Sean Paul wrote: > On Wed, Dec 26, 2012 at 6:27 AM, Prathyush K > wrote: > > The wait_for_vblank interface is modified to the complete_scanout > > function in fimd. This patch adds the fimd_complete_scanout function > > > > Inside

[PATCH 4/8] drm/exynos: fimd: clear channel before enabling iommu

2013-01-03 Thread Prathyush K
On Thu, Jan 3, 2013 at 2:33 AM, St?phane Marchesin < stephane.marchesin at gmail.com> wrote: > On Wed, Dec 26, 2012 at 3:27 AM, Prathyush K > wrote: > > From: Akshu Agrawal > > > > If any fimd channel was already active, initializing iommu will result > > in

Re: [PATCH 7/8] drm/exynos: hdmi: add complete_scanout function

2013-01-03 Thread Prathyush K
On Wed, Jan 2, 2013 at 10:12 PM, Sean Paul wrote: > On Wed, Dec 26, 2012 at 6:27 AM, Prathyush K > wrote: > > The wait_for_vblank interface is modified to the complete_scanout > > function in hdmi. This inturn calls the complete_scanout mixer op. > >

Re: [PATCH 8/8] drm/exynos: fimd: add complete_scanout function

2013-01-03 Thread Prathyush K
On Wed, Jan 2, 2013 at 10:24 PM, Sean Paul wrote: > On Wed, Dec 26, 2012 at 6:27 AM, Prathyush K > wrote: > > The wait_for_vblank interface is modified to the complete_scanout > > function in fimd. This patch adds the fimd_complete_scanout function > > > > Inside

Re: [PATCH 4/8] drm/exynos: fimd: clear channel before enabling iommu

2013-01-02 Thread Prathyush K
On Thu, Jan 3, 2013 at 2:33 AM, Stéphane Marchesin < stephane.marche...@gmail.com> wrote: > On Wed, Dec 26, 2012 at 3:27 AM, Prathyush K > wrote: > > From: Akshu Agrawal > > > > If any fimd channel was already active, initializing iommu will result > > in

[PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Prathyush K
On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > This patch fixes gem buffer allocation type checking. > EXYNOS_BO_CONTIG has 0 so the checking should be fixed > to 'if (!(flags & EXYNOS_BO_NONCONTIG))' > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos

[PATCH] drm/exynos: fimd: modify condition in fimd resume

2012-12-27 Thread Prathyush K
off fimd but resume will not turn it on. This patch fixes this issue by reversing the condition. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Prathyush K
On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > This patch fixes gem buffer allocation type checking. > EXYNOS_BO_CONTIG has 0 so the checking should be fixed > to 'if (!(flags & EXYNOS_BO_NONCONTIG))' > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos

[PATCH] drm/exynos: fimd: modify condition in fimd resume

2012-12-27 Thread Prathyush K
off fimd but resume will not turn it on. This patch fixes this issue by reversing the condition. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu

[PATCH 8/8] drm/exynos: fimd: add complete_scanout function

2012-12-26 Thread Prathyush K
shadow register, then the function waits for the next vblank and returns. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 32 +++- include/video/samsung_fimd.h | 1 + 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a

[PATCH 7/8] drm/exynos: hdmi: add complete_scanout function

2012-12-26 Thread Prathyush K
it with the dma address of the framebuffer. If the dma_address is in the base register, the mixer window is disabled. If the dma_address is in the shadow register, then the function waits for the next vblank and returns. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 11

[PATCH 6/8] drm/exynos: add complete_scanout interface

2012-12-26 Thread Prathyush K
not actually reading from the buffer, the complete scanout function will just return and not wait for vsync. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 7 --- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 23 +++ drivers/gpu/drm/exynos

[PATCH 5/8] drm/exynos: mixer: do not finish a pageflip if layer update in progress

2012-12-26 Thread Prathyush K
per vsync. Signed-off-by: Sean Paul Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_mixer.c | 35 ++- drivers/gpu/drm/exynos/regs-mixer.h | 1 + 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b

[PATCH 4/8] drm/exynos: fimd: clear channel before enabling iommu

2012-12-26 Thread Prathyush K
-off-by: Akshu Agrawal Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index f88eaa4

[PATCH 3/8] drm/exynos: enable vblank in fimd wait for vblank

2012-12-26 Thread Prathyush K
This patch checks if vblank is enabled inside wait for vblank. If not enabled, vblank is temporarily enabled before waiting and then disabled afterwards. This ensures that the wait never times out. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 12 1 file

[PATCH 2/8] drm/exynos: fimd: call win_disable only when window is enabled

2012-12-26 Thread Prathyush K
This patch adds a check in fimd_window_suspend to call win_disable only if the window is enabled. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers

[PATCH 1/8] drm/exynos: add mixer apply function

2012-12-26 Thread Prathyush K
: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 15 ++- drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 1 + drivers/gpu/drm/exynos/exynos_mixer.c| 18 +- 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 0/8] drm/exynos: address more scenarios with wait_for_vblank

2012-12-26 Thread Prathyush K
annot free the buffer. Akshu Agrawal (1): drm/exynos: fimd: clear channel before enabling iommu Prathyush K (6): drm/exynos: add mixer apply function drm/exynos: fimd: call win_disable only when window is enabled drm/exynos: enable vblank in fimd wait for vblank drm/exynos: add complete_sc

[PATCH 8/8] drm/exynos: fimd: add complete_scanout function

2012-12-26 Thread Prathyush K
shadow register, then the function waits for the next vblank and returns. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 32 +++- include/video/samsung_fimd.h | 1 + 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a

[PATCH 7/8] drm/exynos: hdmi: add complete_scanout function

2012-12-26 Thread Prathyush K
it with the dma address of the framebuffer. If the dma_address is in the base register, the mixer window is disabled. If the dma_address is in the shadow register, then the function waits for the next vblank and returns. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 11

[PATCH 6/8] drm/exynos: add complete_scanout interface

2012-12-26 Thread Prathyush K
not actually reading from the buffer, the complete scanout function will just return and not wait for vsync. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 7 --- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 23 +++ drivers/gpu/drm/exynos

[PATCH 4/8] drm/exynos: fimd: clear channel before enabling iommu

2012-12-26 Thread Prathyush K
-off-by: Akshu Agrawal Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index f88eaa4

[PATCH 2/8] drm/exynos: fimd: call win_disable only when window is enabled

2012-12-26 Thread Prathyush K
This patch adds a check in fimd_window_suspend to call win_disable only if the window is enabled. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers

[PATCH 5/8] drm/exynos: mixer: do not finish a pageflip if layer update in progress

2012-12-26 Thread Prathyush K
per vsync. Signed-off-by: Sean Paul Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_mixer.c | 35 ++- drivers/gpu/drm/exynos/regs-mixer.h | 1 + 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b

[PATCH 3/8] drm/exynos: enable vblank in fimd wait for vblank

2012-12-26 Thread Prathyush K
This patch checks if vblank is enabled inside wait for vblank. If not enabled, vblank is temporarily enabled before waiting and then disabled afterwards. This ensures that the wait never times out. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 12 1 file

[PATCH 1/8] drm/exynos: add mixer apply function

2012-12-26 Thread Prathyush K
: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 15 ++- drivers/gpu/drm/exynos/exynos_drm_hdmi.h | 1 + drivers/gpu/drm/exynos/exynos_mixer.c| 18 +- 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 0/8] drm/exynos: address more scenarios with wait_for_vblank

2012-12-26 Thread Prathyush K
annot free the buffer. Akshu Agrawal (1): drm/exynos: fimd: clear channel before enabling iommu Prathyush K (6): drm/exynos: add mixer apply function drm/exynos: fimd: call win_disable only when window is enabled drm/exynos: enable vblank in fimd wait for vblank drm/exynos: add complete_sc

[PATCH v2] drm/exynos: clear windows in fimd dpms off

2012-12-13 Thread Prathyush K
current kernel with additional changes like removing 'fimd_win_commit' call from the resume function since this is taken care by encoder dpms, and the modification of resume flag in win_disable. Signed-off-by: Prathyush K Signed-off-by: Sean Paul Signed-off-by: Stephane Marchesin Signed-

[PATCH v2] drm/exynos: clear windows in fimd dpms off

2012-12-13 Thread Prathyush K
current kernel with additional changes like removing 'fimd_win_commit' call from the resume function since this is taken care by encoder dpms, and the modification of resume flag in win_disable. Signed-off-by: Prathyush K Signed-off-by: Sean Paul Signed-off-by: Stephane Marchesin Signed-

[PATCH 7/7] drm/exynos: clear windows in fimd dpms off

2012-12-07 Thread Prathyush K
On Fri, Dec 7, 2012 at 1:04 PM, Prathyush K wrote: > > > > On Fri, Dec 7, 2012 at 10:37 AM, Inki Dae wrote: > >> >> >> 2012/12/6 Prathyush K >> >>> When fimd is turned off, we disable the clocks which will stop >>> the dma. Now if we

[PATCH 7/7] drm/exynos: clear windows in fimd dpms off

2012-12-07 Thread Prathyush K
On Fri, Dec 7, 2012 at 10:37 AM, Inki Dae wrote: > > > 2012/12/6 Prathyush K > >> When fimd is turned off, we disable the clocks which will stop >> the dma. Now if we remove the current framebuffer, we cannot >> disable the overlay but the current framebuffer will

[PATCH v2 0/7] drm/exynos: modify wait_for_vblank and clear windows in dpms off

2012-12-07 Thread Prathyush K
ot; patch is not required. Regards, Prathyush On Fri, Dec 7, 2012 at 9:43 AM, Inki Dae wrote: > > > 2012/12/6 Prathyush K > >> This patchset fixes the various issues which result in getting a PAGE >> FAULT >> while using fimd and hdmi in exynos drm. >> >> C

Re: [PATCH 7/7] drm/exynos: clear windows in fimd dpms off

2012-12-06 Thread Prathyush K
On Fri, Dec 7, 2012 at 1:04 PM, Prathyush K wrote: > > > > On Fri, Dec 7, 2012 at 10:37 AM, Inki Dae wrote: > >> >> >> 2012/12/6 Prathyush K >> >>> When fimd is turned off, we disable the clocks which will stop >>> the dma. Now if we

Re: [PATCH 7/7] drm/exynos: clear windows in fimd dpms off

2012-12-06 Thread Prathyush K
On Fri, Dec 7, 2012 at 10:37 AM, Inki Dae wrote: > > > 2012/12/6 Prathyush K > >> When fimd is turned off, we disable the clocks which will stop >> the dma. Now if we remove the current framebuffer, we cannot >> disable the overlay but the current framebuffer will

Re: [PATCH v2 0/7] drm/exynos: modify wait_for_vblank and clear windows in dpms off

2012-12-06 Thread Prathyush K
ot; patch is not required. Regards, Prathyush On Fri, Dec 7, 2012 at 9:43 AM, Inki Dae wrote: > > > 2012/12/6 Prathyush K > >> This patchset fixes the various issues which result in getting a PAGE >> FAULT >> while using fimd and hdmi in exynos drm. >> >> C

[PATCH 7/7] drm/exynos: clear windows in fimd dpms off

2012-12-06 Thread Prathyush K
rent fb is removed when fimd is off, fimd_win_disable will set the 'resume' flag of that window to zero and return. So when fimd resumes, that window will not be resumed. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 40 +-

[PATCH 6/7] drm/exynos: clear windows in mixer dpms off

2012-12-06 Thread Prathyush K
current fb is removed when mixer is off, mixer_win_disable will set the 'resume' flag of that window to zero and return. So when mixer resumes, that window will not be resumed. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_mixer.c | 193 --

[PATCH 5/7] drm/exynos: modify wait_for_vblank of fimd

2012-12-06 Thread Prathyush K
). This patch modifies the wait for vblank function of fimd. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 25 + 1 files changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos

[PATCH 4/7] drm/exynos: modify wait_for_vblank of mixer

2012-12-06 Thread Prathyush K
). This patch modifies the wait for vblank function of mixer. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_mixer.c | 31 ++- 1 files changed, 26 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm

[PATCH 3/7] drm/exynos: move fimd wait_for_vblank to manager_ops

2012-12-06 Thread Prathyush K
The wait for vblank callback is moved from overlay_ops to manager_ops for fimd. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b

[PATCH 2/7] drm/exynos: move hdmi's wait_for_vblank to manager_ops

2012-12-06 Thread Prathyush K
The wait_for_vblank callback of hdmi and mixer is now moved from overlay_ops to manager_ops. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 22 +++--- drivers/gpu/drm/exynos/exynos_drm_hdmi.h |2 +- drivers/gpu/drm/exynos/exynos_mixer.c| 26

[PATCH 1/7] drm/exynos: make wait_for_vblank a manager op

2012-12-06 Thread Prathyush K
The wait_for_vblank callback is moved from overlay ops to manager ops of exynos drm driver. Also, the check for DPMS OFF of encoder is removed before calling wait_for_vblank. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_drv.h |6 +++--- drivers/gpu/drm/exynos

[PATCH v2 0/7] drm/exynos: modify wait_for_vblank and clear windows in dpms off

2012-12-06 Thread Prathyush K
t the 'resume' flag of that window to zero and return. So when fimd/mixer resumes, that window will not be resumed. Prathyush K (7): drm/exynos: make wait_for_vblank a manager op drm/exynos: move hdmi's wait_for_vblank to manager_ops drm/exynos: move fimd wait_for_vblank to mana

[PATCH 7/7] drm/exynos: clear windows in fimd dpms off

2012-12-06 Thread Prathyush K
rent fb is removed when fimd is off, fimd_win_disable will set the 'resume' flag of that window to zero and return. So when fimd resumes, that window will not be resumed. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 40 +-

[PATCH 6/7] drm/exynos: clear windows in mixer dpms off

2012-12-06 Thread Prathyush K
current fb is removed when mixer is off, mixer_win_disable will set the 'resume' flag of that window to zero and return. So when mixer resumes, that window will not be resumed. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_mixer.c | 193 --

[PATCH 5/7] drm/exynos: modify wait_for_vblank of fimd

2012-12-06 Thread Prathyush K
). This patch modifies the wait for vblank function of fimd. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 25 + 1 files changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos

[PATCH 4/7] drm/exynos: modify wait_for_vblank of mixer

2012-12-06 Thread Prathyush K
). This patch modifies the wait for vblank function of mixer. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_mixer.c | 31 ++- 1 files changed, 26 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm

[PATCH 3/7] drm/exynos: move fimd wait_for_vblank to manager_ops

2012-12-06 Thread Prathyush K
The wait for vblank callback is moved from overlay_ops to manager_ops for fimd. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b

[PATCH 2/7] drm/exynos: move hdmi's wait_for_vblank to manager_ops

2012-12-06 Thread Prathyush K
The wait_for_vblank callback of hdmi and mixer is now moved from overlay_ops to manager_ops. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 22 +++--- drivers/gpu/drm/exynos/exynos_drm_hdmi.h |2 +- drivers/gpu/drm/exynos/exynos_mixer.c| 26

[PATCH 1/7] drm/exynos: make wait_for_vblank a manager op

2012-12-06 Thread Prathyush K
The wait_for_vblank callback is moved from overlay ops to manager ops of exynos drm driver. Also, the check for DPMS OFF of encoder is removed before calling wait_for_vblank. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_drv.h |6 +++--- drivers/gpu/drm/exynos

[PATCH v2 0/7] drm/exynos: modify wait_for_vblank and clear windows in dpms off

2012-12-06 Thread Prathyush K
t the 'resume' flag of that window to zero and return. So when fimd/mixer resumes, that window will not be resumed. Prathyush K (7): drm/exynos: make wait_for_vblank a manager op drm/exynos: move hdmi's wait_for_vblank to manager_ops drm/exynos: move fimd wait_for_vblank to mana

[PATCH 0/3] drm/exynos: modify usage of wait for vblank

2012-12-05 Thread Prathyush K
; + atomic_set(&ctx->wait_vsync_**event, 0); > + DRM_WAKEUP(&ctx->wait_vsync_**queue); > + } > > I lost your PATCH mail. so, I send my comment using this body mail. > > Thank's > BR > > Eunchul Kim. > > > On 12/05/2012 04:27 PM, Ink

[PATCH 0/3] drm/exynos: modify usage of wait for vblank

2012-12-05 Thread Prathyush K
On Wed, Dec 5, 2012 at 11:40 AM, Inki Dae wrote: > > > 2012/12/5 Inki Dae > >> >> >> 2012/12/5 Prathyush K >> >>> This patchset fixes a few issues with use of wait for vblank in >>> exynos drm. >>> >>> Please apply the

[PATCH v2] drm/exynos: release fb pended by page flip

2012-12-05 Thread Prathyush K
, 2080, 20C0. Please check modetest without enabling flipping. modetest -s 17 at 4:1280x720. Regards, Prathyush On Wed, Dec 5, 2012 at 9:16 AM, Inki Dae wrote: > > > 2012/12/5 Inki Dae > >> >> >> 2012/12/4 Prathyush K >> >>> >>> &

Re: [PATCH 0/3] drm/exynos: modify usage of wait for vblank

2012-12-05 Thread Prathyush K
; + atomic_set(&ctx->wait_vsync_**event, 0); > + DRM_WAKEUP(&ctx->wait_vsync_**queue); > + } > > I lost your PATCH mail. so, I send my comment using this body mail. > > Thank's > BR > > Eunchul Kim. > > > On 12/05/2012 04:27 PM, Ink

Re: [PATCH 0/3] drm/exynos: modify usage of wait for vblank

2012-12-04 Thread Prathyush K
On Wed, Dec 5, 2012 at 11:40 AM, Inki Dae wrote: > > > 2012/12/5 Inki Dae > >> >> >> 2012/12/5 Prathyush K >> >>> This patchset fixes a few issues with use of wait for vblank in >>> exynos drm. >>> >>> Please apply the

Re: [PATCH v2] drm/exynos: release fb pended by page flip

2012-12-04 Thread Prathyush K
, 2080, 20C0. Please check modetest without enabling flipping. modetest -s 17@4:1280x720. Regards, Prathyush On Wed, Dec 5, 2012 at 9:16 AM, Inki Dae wrote: > > > 2012/12/5 Inki Dae > >> >> >> 2012/12/4 Prathyush K >> >>> >>> &

[PATCH 0/3] drm/exynos: modify usage of wait for vblank

2012-12-04 Thread Prathyush K
e we are able to wait for vblank before freeing any framebuffers after disabling the crtc. With these three patches and without "drm/exynos: release fb pended by page flip" I could not find any crash/page_fault in drm with fimd/hdmi during hotplug and page flips. Prathyush K (3): drm/

[PATCH 3/3] drm/exynos: do not disable crtc if already off

2012-12-04 Thread Prathyush K
framebuffers after disabling the crtc. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_crtc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index 2efa4b0..faa6ee0

[PATCH 2/3] drm/exynos: move wait_for_vblank to manager_ops

2012-12-04 Thread Prathyush K
fb might get removed before dma is finished). Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_drv.h |6 ++-- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 15 +++ drivers/gpu/drm/exynos/exynos_drm_fimd.c| 34 +- drivers/gpu/drm/exy

[PATCH 1/3] drm/exynos: modify wait for vsync functions to use wait queues

2012-12-04 Thread Prathyush K
). This patch modifies the wait for vblank functions of both fimd and mixer. Also, the current fimd wait_for_vblank did not work in exynos5 since VIDCON1 has to be used in addition to timing base offset (0x2). This patch also eliminates this problem. Signed-off-by: Prathyush K --- drivers

[PATCH v2] drm/exynos: release fb pended by page flip

2012-12-04 Thread Prathyush K
On Tue, Dec 4, 2012 at 5:44 PM, Inki Dae wrote: > Changelog v2: > fix page fault issue. > - defer to unreference old fb to avoid page fault issue. > So with this fixup, new fb would be updated to hardware > prior to old fb unreferencing. And it removes unnecessary > patch, "drm/exynos: Unreferenc

[PATCH 0/3] drm/exynos: modify usage of wait for vblank

2012-12-04 Thread Prathyush K
e we are able to wait for vblank before freeing any framebuffers after disabling the crtc. With these three patches and without "drm/exynos: release fb pended by page flip" I could not find any crash/page_fault in drm with fimd/hdmi during hotplug and page flips. Prathyush K (3): drm/

[PATCH 3/3] drm/exynos: do not disable crtc if already off

2012-12-04 Thread Prathyush K
framebuffers after disabling the crtc. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_crtc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index 2efa4b0..faa6ee0

[PATCH 2/3] drm/exynos: move wait_for_vblank to manager_ops

2012-12-04 Thread Prathyush K
fb might get removed before dma is finished). Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_drv.h |6 ++-- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 15 +++ drivers/gpu/drm/exynos/exynos_drm_fimd.c| 34 +- drivers/gpu/drm/exy

[PATCH 1/3] drm/exynos: modify wait for vsync functions to use wait queues

2012-12-04 Thread Prathyush K
). This patch modifies the wait for vblank functions of both fimd and mixer. Also, the current fimd wait_for_vblank did not work in exynos5 since VIDCON1 has to be used in addition to timing base offset (0x2). This patch also eliminates this problem. Signed-off-by: Prathyush K --- drivers

Re: [PATCH v2] drm/exynos: release fb pended by page flip

2012-12-04 Thread Prathyush K
On Tue, Dec 4, 2012 at 5:44 PM, Inki Dae wrote: > Changelog v2: > fix page fault issue. > - defer to unreference old fb to avoid page fault issue. > So with this fixup, new fb would be updated to hardware > prior to old fb unreferencing. And it removes unnecessary > patch, "drm/exynos: Unreferenc

[PATCH v2] drm/exynos: create new sgt from existing sgt

2012-12-03 Thread Prathyush K
s-drm-next-iommu branch of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_dmabuf.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dmabuf

[PATCH] drm/exynos: enable iommu for mixer and not hdmi

2012-12-03 Thread Prathyush K
moves the iommu_on function from the hdmi context to the mixer context. And this patch is based on exynos-drm-next-iommu branch of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c |8 drivers/gpu/

[PATCH v2] drm/exynos: create new sgt from existing sgt

2012-12-02 Thread Prathyush K
s-drm-next-iommu branch of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_dmabuf.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dmabuf

[PATCH] drm/exynos: enable iommu for mixer and not hdmi

2012-12-02 Thread Prathyush K
moves the iommu_on function from the hdmi context to the mixer context. And this patch is based on exynos-drm-next-iommu branch of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c |8 drivers/gpu/

[PATCH] drm/exynos: use sgt instead of pages for framebuffer address

2012-11-22 Thread Prathyush K
The 'pages' structure in the exynos gem buffer has been removed. So we get the fix.smem_start from the first sgl of the scatter gather table. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) di

[PATCH] drm/exynos: use sgt instead of pages for framebuffer address

2012-11-21 Thread Prathyush K
The 'pages' structure in the exynos gem buffer has been removed. So we get the fix.smem_start from the first sgl of the scatter gather table. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) di

[PATCH] drm/exynos: modify burst size based on overlay size

2012-11-20 Thread Prathyush K
The BURST size of fimd is adjusted based on the number of bytes to be read. This is calculated based on the overlay width and the number of bits per pixel. There are three burst lengths supported - 4 words, 8 words and 16 words where each word is 8 bytes long. Signed-off-by: Prathyush K

[PATCH v2] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-20 Thread Prathyush K
not being freed during deallocate. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_buf.c| 20 - drivers/gpu/drm/exynos/exynos_drm_buf.h|4 +- drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |3 +- drivers/gpu/drm/exynos/exynos_drm_gem.c| 41 +

[PATCH] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-20 Thread Prathyush K
On Tue, Nov 20, 2012 at 12:49 PM, Kyungmin Park wrote: > On 11/20/12, Prathyush K wrote: > > On Mon, Nov 19, 2012 at 3:14 PM, Kyungmin Park > > wrote: > > > >> Hi, > >> > >> On 11/15/12, Prathyush K wrote: > >> > The 'pages

[PATCH] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-20 Thread Prathyush K
On Mon, Nov 19, 2012 at 3:14 PM, Kyungmin Park wrote: > Hi, > > On 11/15/12, Prathyush K wrote: > > The 'pages' structure is not required since we can use the 'sgt'. Even > for > > CONTIG buffers, a SGT is created (which will have just one sgl). Thi

[PATCH] drm/exynos: modify burst size based on overlay size

2012-11-20 Thread Prathyush K
The BURST size of fimd is adjusted based on the number of bytes to be read. This is calculated based on the overlay width and the number of bits per pixel. There are three burst lengths supported - 4 words, 8 words and 16 words where each word is 8 bytes long. Signed-off-by: Prathyush K

[PATCH v2] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-20 Thread Prathyush K
not being freed during deallocate. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_buf.c| 20 - drivers/gpu/drm/exynos/exynos_drm_buf.h|4 +- drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |3 +- drivers/gpu/drm/exynos/exynos_drm_gem.c| 41 +

Re: [PATCH] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-20 Thread Prathyush K
On Tue, Nov 20, 2012 at 12:49 PM, Kyungmin Park wrote: > On 11/20/12, Prathyush K wrote: > > On Mon, Nov 19, 2012 at 3:14 PM, Kyungmin Park > > wrote: > > > >> Hi, > >> > >> On 11/15/12, Prathyush K wrote: > >> > The 'pages

Re: [PATCH] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-19 Thread Prathyush K
On Mon, Nov 19, 2012 at 3:14 PM, Kyungmin Park wrote: > Hi, > > On 11/15/12, Prathyush K wrote: > > The 'pages' structure is not required since we can use the 'sgt'. Even > for > > CONTIG buffers, a SGT is created (which will have just one sgl). Thi

[PATCH v3] drm/exynos: add exynos drm specific fb_mmap function

2012-11-19 Thread Prathyush K
contiguous and calls dma_mmap_writecombine for mapping the buffer to user space. dma_mmap_writecombine will be able to map a contiguous buffer as well as non-contig buffer depending on whether an IOMMU mapping is created for drm or not. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos

[PATCH v3] drm/exynos: add exynos drm specific fb_mmap function

2012-11-19 Thread Prathyush K
contiguous and calls dma_mmap_writecombine for mapping the buffer to user space. dma_mmap_writecombine will be able to map a contiguous buffer as well as non-contig buffer depending on whether an IOMMU mapping is created for drm or not. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos

[PATCH v2] drm/exynos: add exynos drm specific fb_mmap function

2012-11-16 Thread Prathyush K
contiguous thus failing in case of a non-contig buffer. The exynos drm specific implementation of fb_mmap extracts the private data from the fb_info and calls dma_mmap_attrs with the parameters used while allocating the buffer. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos

[PATCH v2] drm/exynos: add exynos drm specific fb_mmap function

2012-11-16 Thread Prathyush K
contiguous thus failing in case of a non-contig buffer. The exynos drm specific implementation of fb_mmap extracts the private data from the fb_info and calls dma_mmap_attrs with the parameters used while allocating the buffer. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos

[PATCH v2] drm/exynos: add exynos drm specific fb_mmap function

2012-11-16 Thread Prathyush K
contiguous thus failing in case of a non-contig buffer. The exynos drm specific implementation of fb_mmap extracts the private data from the fb_info and calls dma_mmap_attrs with the parameters used while allocating the buffer. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos

[PATCH] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-16 Thread Prathyush K
re and is removed. This patch also fixes a memory leak where the 'pages' structure was being allocated during gem buffer allocation but not being freed during deallocate. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_buf.c| 20 -- drivers/gpu/drm/exy

[PATCH v2] drm/exynos: add exynos drm specific fb_mmap function

2012-11-15 Thread Prathyush K
contiguous thus failing in case of a non-contig buffer. The exynos drm specific implementation of fb_mmap extracts the private data from the fb_info and calls dma_mmap_attrs with the parameters used while allocating the buffer. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos

[PATCH] drm/exynos: remove 'pages' and 'page_size' elements in exynos gem buffer

2012-11-15 Thread Prathyush K
re and is removed. This patch also fixes a memory leak where the 'pages' structure was being allocated during gem buffer allocation but not being freed during deallocate. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_buf.c| 20 -- drivers/gpu/drm/exy

[PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Prathyush K
On Fri, Nov 9, 2012 at 1:09 PM, Inki Dae wrote: > This patch fixes access issue to invalid memory region. > > crtc had only one drm_framebuffer object so when framebuffer > cleanup was requested after page flip, it'd try to disable > hardware overlay to current crtc. > But if current crtc points

Re: [PATCH] drm: fix drm_framebuffer cleanup.

2012-11-09 Thread Prathyush K
On Fri, Nov 9, 2012 at 1:09 PM, Inki Dae wrote: > This patch fixes access issue to invalid memory region. > > crtc had only one drm_framebuffer object so when framebuffer > cleanup was requested after page flip, it'd try to disable > hardware overlay to current crtc. > But if current crtc points

[PATCH 3/3] drm/exynos: clone new sgt instead of creating from pages

2012-11-07 Thread Prathyush K
large buffers. Instead, we can just clone the sgt which was already created during buffer allocation and create the new sgt. This is done by calling 'sg_clone_table'. This will be much faster than creating from pages. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_

[PATCH 2/3] drm/exynos: remove unnecessary sg_alloc_table call

2012-11-07 Thread Prathyush K
The function dma_get_sgtable will allocate a sg table internally so it is not necessary to allocate a sg table before it. The unnecessary 'sg_alloc_table' call is removed. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |8 +--- 1 files changed, 1

[PATCH 1/3] scatterlist: add sg_clone_table function

2012-11-07 Thread Prathyush K
tables for dma mapping from the original sg table. Signed-off-by: Prathyush K --- include/linux/scatterlist.h |1 + lib/scatterlist.c | 36 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/include/linux/scatterlist.h

[PATCH] scatterlist: add sg_clone_table function

2012-11-07 Thread Prathyush K
tables for dma mapping from the original sg table. Signed-off-by: Prathyush K --- include/linux/scatterlist.h |1 + lib/scatterlist.c | 36 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/include/linux/scatterlist.h

  1   2   >