on Pinetab2.
[1]
https://lore.kernel.org/linux-rockchip/562b38e5.a496.1975f09f983.coremail.andys...@163.com/
Reported-by: Diederik de Haas
Closes:
https://lore.kernel.org/linux-rockchip/daevdstmwi1e.j454vzn0r...@cknow.org/
Suggested-by: Andy Yan
Signed-off-by: Piotr Zalewski
---
drivers/gpu
is another question. I still haven't figured out why
> this problem doesn't occur when compiling rockchipdrm=y .
Couldn't reason out why this only happens with drm=m yet
unfortunately.
Best regards, Piotr Zalewski
in
the register _is_ what was written earlier in atomic enable i.e value is
vaild? Maybe it is just "unfortunate" timing?
```
[6.646991] vop2_crtc_atomic_try_set_gamma gamma_lut:
[6.647594] vop2_vp_dsp_lut_disable dsp_ctrl: 0x0001
```
I will have time to spend more on this over the weekend.
Best regards, Piotr Zalewski
could be that this issue surfaced an underlaying
> issue and if so, fixing that would be even better.
When i have time this week I will check on what version of the kernel i
tested gamma lut when i sent the patches and test there.
> Thanks a lot!
>
Thank _you_ for taking your time to do all the bisecting.
Best regards, Piotr Zalewski
68_VP_DSP_CTRL__DSP_LUT_EN) == 0)
+ return;
+
dsp_ctrl &= ~RK3568_VP_DSP_CTRL__DSP_LUT_EN;
vop2_vp_write(vp, RK3568_VP_DSP_CTRL, dsp_ctrl);
}
I will wait with sending a patch because maybe Andy has something to add
to this.
Best regards, Piotr Zalewski
://lore.kernel.org/linux-rockchip/20241101185545.559090-3-pz010001011...@proton.me/
Suggested-by: Andy Yan
Signed-off-by: Piotr Zalewski
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
b
hecking it only in the atomic_flush fixed the issue.
Thanks Andy for pointing that out.
Regards, Piotr Zalewski
-next.
Regards, Piotr Zalewski
-8c05-40d2-a5d8-23de960c5...@rock-chips.com/
[3]
https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c#L3437
Helped-by: Daniel Stone
Helped-by: Dragan Simic
Helped-by: Diederik de Haas
Helped-by: Andy Yan
Signed-off-by: Piotr Zalewski
---
Hi Andy
> 在 2024-10-28 14:42:28，"Andy Yan" andys...@163.com 写道：
>
> > Hi Piotr，
> > Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a buildroot +
> > weston environment:
> > weston --backend=drm-backend.so -i 0 --continue-without-input
> > weston-simple-egl
> >
> > simple-egl will draw
Hi again
On Monday, October 28th, 2024 at 5:40 PM, Piotr Zalewski
wrote:
> On Monday, October 28th, 2024 at 7:42 AM, Andy Yan andys...@163.com wrote:
>
> > Hi Piotr，
>
>
> Hi Andy
>
> > Tested on top of Linux 6.12-rc5 with rk3566-box-demo in a build
> I've been quite busy lately, and it will take some time before I can analyze
> what the specific reason is.
Np, I will try to reproduce this behavior with weston on Pinetab2 in the
meantime.
Best Regards, Piotr Zalewski
Hi all,
any comments on this?
On Thursday, October 17th, 2024 at 12:36 AM, Piotr Zalewski
wrote:
> Add support for gamma LUT in VOP2 driver. The implementation was inspired
> by one found in VOP1 driver. Blue and red channels in gamma LUT register
> write were swapped with respe
https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c#L3437
Helped-by: Daniel Stone
Helped-by: Dragan Simic
Helped-by: Diederik de Haas
Helped-by: Andy Yan
Signed-off-by: Piotr Zalewski
---
Notes:
Changes in v6:
- Move gamma lu
Hi Andy
On Wednesday, October 16th, 2024 at 11:23 AM, Piotr Zalewski
wrote:
> > > static void vop2_crtc_atomic_flush(struct drm_crtc *crtc,
> > > @@ -2790,7 +2945,13 @@ static int vop2_create_crtcs(struct vop2 *vop2)
> > > }
> > >
> > > drm_crtc_
Hi Daniel,
On Wednesday, October 16th, 2024 at 2:27 PM, Daniel Stone
wrote:
> Hi all,
>
> On Wed, 16 Oct 2024 at 02:11, Andy Yan andys...@163.com wrote:
>
> > At 2024-10-16 04:13:40, "Piotr Zalewski" pz010001011...@proton.me wrote:
> >
> > > Ok I
Hi Diederik
On Wednesday, October 16th, 2024 at 11:20 AM, Diederik de Haas
wrote:
> On Wed Oct 16, 2024 at 11:16 AM CEST, Piotr Zalewski wrote:
>
> > I will rework it to[1] and test it. (Have to check if hdmi out on pt2
> > works).
>
>
> Last time I tried i
ptr dereference later on in
drm_crtc_enable_color_mgmt (unless something changed in recent kernel
versions, last time I tested was 6.10? or even 6.8).
Best regards, Piotr Zalewski
Hi Andy,
On Wednesday, October 16th, 2024 at 3:10 AM, Andy Yan wrote:
> Hi Piotr,
>
> At 2024-10-16 04:13:40, "Piotr Zalewski" pz010001011...@proton.me wrote:
>
> > Hi Andy
> >
> > On Tuesday, October 15th, 2024 at 2:22 PM, Andy Yan andys...@
Hi Andy, Ignore the message I'm answering to. I accidentally sent it
prematurely.
On Wednesday, October 16th, 2024 at 9:41 AM, Piotr Zalewski
wrote:
> Hi Andy,
>
> On Wednesday, October 16th, 2024 at 3:10 AM, Andy Yan andys...@163.com wrote:
>
> > Hi Piotr,
> >
Hi Andy,
On Wednesday, October 16th, 2024 at 3:10 AM, Andy Yan wrote:
> Hi Piotr,
>
> At 2024-10-16 04:13:40, "Piotr Zalewski" pz010001011...@proton.me wrote:
>
> > Hi Andy
> >
> > On Tuesday, October 15th, 2024 at 2:22 PM, Andy Yan andys...@
(vp);
```
> > > >
> > > > drm_crtc_helper_add(&vp->crtc, &vop2_crtc_helper_funcs);
> > > > + if (vop2->lut_regs && vp->crtc.dev != NULL) {
> > > > + const struct vop2_video_port_data *vp_data = &vop2_data->vp[vp->id];
> > > >
> > > > + drm_mode_crtc_set_gamma_size(&vp->crtc, vp_data->gamma_lut_len);
> > > > + drm_crtc_enable_color_mgmt(&vp->crtc, 0, false,
> > > > + vp_data->gamma_lut_len);
> > >
> > > It seems that we can keep it in one line, the default limit of linux
> > > kernel coding style is 100 characters now.
> >
> > Thanks. I didn't know, I will amend it.
>
>
> See bdc48fa11e46("checkpatch/coding-style: deprecate 80-column warning")
>
Interesting.
Best regards, Piotr Zalewski
On Tuesday, October 15th, 2024 at 5:38 AM, Andy Yan wrote:
> Hi Piotr,
>
> At 2024-10-15 06:30:27, "Piotr Zalewski" pz010001011...@proton.me wrote:
>
> > Add support for gamma LUT in VOP2 driver. The implementation was inspired
> > by one found in VOP1 driv
d8-23de960c5...@rock-chips.com/
[3]
https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c#L3437
Helped-by: Daniel Stone
Helped-by: Dragan Simic
Helped-by: Diederik de Haas
Helped-by: Andy Yan
Signed-off-by: Piotr Zalewski
---
Notes:
Changes in
Hi Daniel,
Can you comment on or review this? This version of the patch was based on
your suggestions and it has been stuck for some time now.
I appreciate your time and help :)
Best Regards, Piotr Zalewski
On Thursday, August 15th, 2024 at 2:46 PM, Piotr Zalewski
wrote:
> Add support
d probably be better to set mode_changed when the colour
management configuration changes". Let's wait for his reply to this
version of the patch, perhaps he meant something different or not exactly
what I did.
[1]
https://lore.kernel.org/linux-rockchip/CAPj87rOM=j0zmuWL9frGKV1xzPbJrk=q9ip7f_hapynbcqp...@mail.gmail.com/
[2]
https://lore.kernel.org/linux-rockchip/TkgKVivuaLFLILPY-n3iZo_8KF-daKdqdu-0_e0HP-5Ar_8DALDeNWog2suwWKjX7eomcbGET0KZe7DlzdhK2YM6CbLbeKeFZr-MJzJMtw0=@proton.me/
Best Regards, Piotr Zalewski
ik de Haas
Helped-by: Andy Yan
Signed-off-by: Piotr Zalewski
---
Notes:
WASN'T tested on RK3588.
Changes in v4:
- rework the implementation to better utilize DRM atomic updates[2]
- handle the RK3588 case[2][3]
Changes in v3:
- v3 is patch v2 "
On Tuesday, July 30th, 2024 at 12:43 PM, Andy Yan
wrote:
> Hi Piotr,
Hi Andy
> On 7/30/24 05:20, Piotr Zalewski wrote:
>
> >
> > On Monday, July 29th, 2024 at 4:35 AM, Andy Yan andy@rock-chips.com
> > wrote:
> >
> > > > > > +
>
the
same concept as LUT_PORT_SEL in case of RK356x)
- VOP2_POST0_DSP_CTRL: gamma_update_en (seems to represent the same
concept as in VOP1 in case of RK3399)
- I also found dsp_lut_en but I presume it is a bug in documentation.
Should RK3588 be handled as RK3399? (gamma LUT can be written directly but
gamma_update_en bit has to be set before). What about gamma_ahb_write_sel?
[1] https://lkml.org/lkml/2024/7/27/293
Best Regards, Piotr Zalewski
On Friday, July 26th, 2024 at 10:55 AM, Andy Yan
wrote:
> Hi Piotr
Hi Andy!
> Thanks for your work.
>
> On 7/25/24 06:05, Piotr Zalewski wrote:
>
> > Add support for gamma LUT in VOP2 driver. The implementation is based on
> > the one found in VOP driver and mod
On Friday, July 26th, 2024 at 1:31 PM, Daniel Stone
wrote:
> Hi Piotr,
Hi Daniel, sorry for delayed response.
>
> > static void vop2_dither_setup(struct drm_crtc *crtc, u32 *dsp_ctrl)
> > @@ -2152,6 +2127,9 @@ static void vop2_crtc_atomic_enable(struct drm_crtc
> > *crtc,
> >
> > vop2_post_co
active_changed) {
+ u32 dsp_ctrl = vop2_vp_read(vp, RK3568_VP_DSP_CTRL);;
+
+ vop2_lock(vop2);
+
+ vop2_crtc_gamma_set(vop2, crtc, old_crtc_state, &dsp_ctrl);
+
+ vop2_vp_write(vp, RK3568_VP_DSP_CTRL, dsp_ctrl);
+ vop2_cfg_done(vp);
+ vop2_unlock(vop2);
+ }
}
static void vop2_crtc_atomic_flush(struct drm_crtc *crtc,
Best regards, Piotr Zalewski
to VOP2_SYS_LUT_PORT_SEL register was added before the write of DSP_LUT_EN
bit. Gamma size is set and drm color management is enabled for each video
port's CRTC except ones which have no associated device. Tested on RK3566
(Pinetab2).
Helped-by: Dragan Simic
Signed-off-by: Piotr Zal
24th, 2024 at 9:06 PM, Piotr Zalewski
wrote:
> Add support for gamma LUT in VOP2 driver. The implementation is based on
> the one found in VOP driver and modified to be compatible with VOP2. Blue
> and red channels in gamma LUT register write were swapped with respect to
> how gamm
to VOP2_SYS_LUT_PORT_SEL register was added before the write of DSP_LUT_EN
bit. Gamma size is set and drm color management is enabled for each video
port's CRTC except ones which have no associated device. Tested on RK3566
(Pinetab2).
Helped-by: Dragan Simic
Signed-off-by: Piotr Zal
to VOP2_SYS_LUT_PORT_SEL register was added before the write of DSP_LUT_EN
bit. Gamma size is set and drm color management is enabled for each video
port's CRTC except ones which have no associated device. Tested on RK3566
(Pinetab2).
Signed-off-by: Piotr Zalewski
---
diff --git a/drivers/gp
On 2024-07-21 12:06, Piotr Zalewski wrote:
>
> > Add support for gamma LUT in VOP2 driver. The implementation is based
> > on
> > the one found in VOP driver and modified to be compatible with VOP2.
> > Blue
> > and red channels in gamma LUT register write were swa
37 matches
Mail list logo
