Hi,
Le 14/05/2025 à 14:53, Philipp Stanner a écrit :
On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pelloux-Prayer wrote:
This commit adds a document section in drm-uapi.rst about
tracepoints,
and mark the events gpu_scheduler_trace.h as stable uAPI.
The goal is to explicitly state that tools
Hi,
Le 14/05/2025 à 14:44, Philipp Stanner a écrit :
On Thu, 2025-04-24 at 10:38 +0200, Pierre-Eric Pelloux-Prayer wrote:
This will be used in a later commit to trace the drm client_id in
some of the gpu_scheduler trace events.
This requires changing all the users of drm_sched_job_init to
add
Hi Philipp,
Did you get a chance to take a look at the latest revision of this series?
Thanks,
Pierre-Eric
Le 24/04/2025 à 10:38, Pierre-Eric Pelloux-Prayer a écrit :
Hi,
The initial goal of this series was to improve the drm and amdgpu
trace events to be able to expose more of the inner
Log fences using the same format for coherency.
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-uapi.rst| 19 +++
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 19 +++
2 files changed, 38 insertions(+)
diff --git a/Documentation/gpu/drm-uapi.rst b
tch to using it.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++
.../gpu/drm/scheduler/gpu_scheduler_trace.h| 18 ++
drivers/gpu/drm/scheduler/sched_main
ned-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Tvrtko Ursulin
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 8
drivers/gpu/drm/scheduler/sched_entity.c| 8
drivers/gpu/drm/scheduler/sched_main.c | 4 ++--
3 files changed, 10 insertions(+), 10
stian König
Acked-by: Philipp Stanner
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
b/drivers/gpu/drm/sche
ies
between the jobs (previously it was only possible for fences
traced by drm_sched_job_wait_dep).
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Tvrtko Ursulin
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 23 +++
drivers/gpu/drm/scheduler/sched_entity.c | 8 +
A fence uniquely identify a job, so this commits updates the places
where a kernel pointer was used as an identifier by:
"fence=%llu:%llu"
Signed-off-by: Pierre-Eric Pelloux-Prayer
Reviewed-by: Tvrtko Ursulin
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 44 ++--
GPU.
With workqueues this is not possible anymore, so the event needs to
contain the dev_name() to identify the device.
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 6 --
1 file changed, 4 insertions(+), 2 deletion
r/drm_client_id
together.
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/accel/amdxdna/aie2_ctx.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu
unt of the biggest uint64_t).
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index 3dfd8b34dceb..ab
vents:
https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37
- v8:
https://lists.freedesktop.org/archives/dri-devel/2025-March/496781.html
Pierre-Eric Pelloux-Prayer (10):
drm/debugfs: output client_id in in drm_clients_info
drm/sched: store the drm client_id in drm_sched_fence
drm/sched: add device
Hi,
Le 16/04/2025 à 12:01, Khatri, Sunil a écrit :
On 4/16/2025 12:56 PM, Tvrtko Ursulin wrote:
On 15/04/2025 19:43, Sunil Khatri wrote:
add process and pid information in the userqueue error
logging to make it more useful in resolving the error
by logs.
Sample log:
[ 42.444297] [drm:amdg
've missed something?
Thanks,
Pierre-Eric
Le 20/03/2025 à 10:57, Pierre-Eric Pelloux-Prayer a écrit :
Hi,
The initial goal of this series was to improve the drm and amdgpu
trace events to be able to expose more of the inner workings of
the scheduler and drivers to developers via tools.
T
ned-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 8
drivers/gpu/drm/scheduler/sched_entity.c| 8
drivers/gpu/drm/scheduler/sched_main.c | 4 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drive
unt of the biggest uint64_t).
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index 6b2178864c7e..ae
ies
between the jobs (previously it was only possible for fences
traced by drm_sched_job_wait_dep).
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 24 ++-
drivers/gpu/drm/scheduler/sched_entity.c | 8 +++
2 files changed, 31 i
7:
https://lists.freedesktop.org/archives/dri-devel/2025-January/488117.html
Pierre-Eric Pelloux-Prayer (10):
drm/debugfs: output client_id in in drm_clients_info
drm/sched: store the drm client_id in drm_sched_fence
drm/sched: add device name to the drm_sched_process_job event
drm/sched: cleanup gpu_s
tch to using it.
Suggested-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 ++
.../gpu/drm/scheduler/gpu_scheduler_trace.h| 18 ++
drivers/gpu/drm/scheduler/sched_main.c | 1 -
include/drm/
GPU.
With workqueues this is not possible anymore, so the event needs to
contain the dev_name() to identify the device.
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 6 --
1 file changed, 4 insertions(+), 2 deletion
: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-uapi.rst| 19
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 22 +++
2 files changed, 41 insertions(+)
diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation
Log fences using the same format for coherency.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
b/drivers/gpu/drm/amd
stian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
index 5d9992a
A fence uniquely identify a job, so this commits updates the places
where a kernel pointer was used as an identifier by:
"fence=%llu:%llu"
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 45 ++-
1 file changed, 24
r/drm_client_id
together.
Reviewed-by: Christian König
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/accel/amdxdna/aie2_ctx.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu/drm/amd/amdg
: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-uapi.rst| 19
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 22 +++
2 files changed, 41 insertions(+)
diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
index
ierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
index ca19cd9a146a..5c740cb80037 100644
--- a/dr
base event class,
the caller of trace_drm_run_job have to pass a dep_count of 0 (which
is ignored because dependencies are only considered at submit time).
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 59 ---
drivers/gpu/drm/scheduler
A fence uniquely identify a job, so this commits updates the places
where a kernel pointer was used as an identifier by:
"fence=%llu:%llu"
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 41 +++
1 file changed, 23
r/drm_client_id
together.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/accel/amdxdna/aie2_ctx.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 8 +---
GPU.
With workqueues this is not possible anymore, so the event needs to
contain the dev_name() to identify the device.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drive
unt of the biggest uint64_t).
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index 536409a35df4..061601211bc2 100644
--- a/drive
s/umr/-/merge_requests/37
- v6:
https://lists.freedesktop.org/archives/dri-devel/2024-November/477644.html
Pierre-Eric Pelloux-Prayer (7):
drm/debugfs: output client_id in in drm_clients_info
drm/sched: store the drm client_id in drm_sched_fence
drm/sched: add device name to the drm_sched_process_job
Le 14/11/2024 à 15:56, Steven Rostedt a écrit :
On Thu, 14 Nov 2024 11:01:07 +0100
Pierre-Eric Pelloux-Prayer wrote:
A fence uniquely identify a job, so this commits updates the places
where a kernel pointer was used as an identifier by:
"fence=(context:%llu, seqno:%lld)"
Le 15/11/2024 à 11:46, Philipp Stanner a écrit :
On Thu, 2024-11-14 at 11:01 +0100, Pierre-Eric Pelloux-Prayer wrote:
Hi,
Hi,
I have only just discovered this thread; Danilo and I (we're
maintainers of the scheduler since early October) seem to miss on CC.
Do you use sc
Le 14/11/2024 à 12:50, Tvrtko Ursulin a écrit :
On 14/11/2024 10:01, Pierre-Eric Pelloux-Prayer wrote:
A fence uniquely identify a job, so this commits updates the places
where a kernel pointer was used as an identifier by:
"fence=(context:%llu, seqno:%lld)"
Any special
Hi Philipp,
Le 15/11/2024 à 16:03, Philipp Stanner a écrit :
On Thu, 2024-11-14 at 11:01 +0100, Pierre-Eric Pelloux-Prayer wrote:
Until the switch from kthread to workqueue,
Could you include the commit ID here where that happened?
"Since switching the scheduler from using kthrea
Le 15/11/2024 à 15:56, Philipp Stanner a écrit :
On Thu, 2024-11-14 at 11:01 +0100, Pierre-Eric Pelloux-Prayer wrote:
This will be used in a later commit to trace the drm client_id in
some of the gpu_scheduler trace events.
I think this commit message should detail what the patch is actual
Le 15/11/2024 à 13:23, Steven Price a écrit :
On 14/11/2024 10:01, Pierre-Eric Pelloux-Prayer wrote:
This will be used in a later commit to trace the drm client_id in
some of the gpu_scheduler trace events.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu
Le 14/11/2024 à 13:01, Tvrtko Ursulin a écrit :
On 14/11/2024 10:01, Pierre-Eric Pelloux-Prayer wrote:
This will be used in a later commit to trace the drm client_id in
some of the gpu_scheduler trace events.
I wonder if it would be tidier to store the drm_client_id in the entity via
nts:
https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37
- v5:
https://lists.freedesktop.org/archives/dri-devel/2024-June/457827.html
Pierre-Eric Pelloux-Prayer (7):
drm/debugfs: output client_id in in drm_clients_info
drm/sched: store the drm client_id in drm_sched_fence
drm/sched:
: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-uapi.rst| 19
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 22 +++
2 files changed, 41 insertions(+)
diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
index
ierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
index 67696f5e1331..8340c7c0c6b6 100644
--- a/dr
the same base event class,
the caller of trace_drm_run_job have to pass a dep_count of 0 (which
is ignored because dependencies are only considered at submit time).
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 59 ---
drivers/gpu/drm
A fence uniquely identify a job, so this commits updates the places
where a kernel pointer was used as an identifier by:
"fence=(context:%llu, seqno:%lld)"
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 39 +++
1 fi
Until the switch from kthread to workqueue, a userspace application could
determine the source device from the pid of the thread sending the event.
With workqueues this is not possible anymore, so the event needs to contain
the dev_name() to identify the device.
Signed-off-by: Pierre-Eric
This will be used in a later commit to trace the drm client_id in
some of the gpu_scheduler trace events.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
drivers/gpu/drm/amd/amdgpu
client_id is a unique id used by fdinfo. Having it listed in 'clients'
output means a userspace application can correlate the fields, eg:
given a fdinfo id get the fdinfo name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 10 ++
1 file
Hi,
Le 10/10/2024 à 12:02, Dan Carpenter a écrit :
Hello Pierre-Eric Pelloux-Prayer,
Commit 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") from Oct
3, 2024 (linux-next), leads to the following Smatch static checker
warning:
drivers/gpu/drm/drm_debugfs.c:104 drm_cl
Thanks for the updated patch, looks good to me.
Le 09/10/2024 à 14:31, Christian König a écrit :
Am 09.10.24 um 14:28 schrieb Mohammed Anees:
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value fr
Hi,
Le 05/10/2024 à 01:59, Mohammed Anees a écrit :
Before this patch, if multiple BO_HANDLES chunks were submitted,
the error -EINVAL would be correctly set but could be overwritten
by the return value from amdgpu_cs_p1_bo_handles(). This patch
ensures that once an error condition is detected,
Le 08/10/2024 à 10:13, Christian König a écrit :
Am 03.10.24 um 14:43 schrieb Pierre-Eric Pelloux-Prayer:
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit
Le 08/10/2024 à 10:24, Christian König a écrit :
Am 03.10.24 um 14:43 schrieb Pierre-Eric Pelloux-Prayer:
If a drm_file name is set append it to the process name.
This information is useful with the virtio/native-context driver: this
allows the guest applications identifier to visible in
gears/test-set-fd-name --
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 1 +
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
And rename it process_desc, since it will soon contain more than
just the process_name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29
At the point the VM is locked (through the root PDs dma_resv object), so
it's safer to call amdgpu_vm_set_task_info.
The original place was not protected against concurrent access, but the
risk was limited to mangled process/task name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
driver
Add an optional drm-client-name field to drm fdinfo's output.
Reviewed-by: Christian König
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-usage-stats.rst | 5 +
drivers/gpu/drm/drm_file.c| 5 +
2 files changed, 10 inser
valid use, and clears the existing name.
Reviewed-by: Tvrtko Ursulin
Reviewed-by: Dmitry Osipenko
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 14 +++---
drivers/gpu/drm/drm_file.c| 5
drivers/gpu/drm/drm_ioctl.c | 51 +
tches 1, 4 and 6 were slightly reworked based on Tvrtko' suggestions.
v4: https://lists.freedesktop.org/archives/dri-devel/2024-September/471695.html
Pierre-Eric Pelloux-Prayer (6):
drm: add DRM_SET_CLIENT_NAME ioctl
drm: use drm_file client_name in fdinfo
drm/amdgpu: d
gears/test-set-fd-name --
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 1 +
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
Add an optional drm-client-name field to drm fdinfo's output.
Reviewed-by: Christian König
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-usage-stats.rst | 5 +
drivers/gpu/drm/drm_file.c| 5 +
2 files changed, 10 inser
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29
At the point the VM is locked (through the root PDs dma_resv object), so
it's safer to call amdgpu_vm_set_task_info.
The original place was not protected against concurrent access, but the
risk was limited to mangled process/task name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
driver
And rename it process_desc, since it will soon contain more than
just the process_name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
ssage of commit 3/6 (Trvtko)
* reworked amdgpu_vm_set_task_info a bit in 4/6 (Trvtko)
v3: https://lists.freedesktop.org/archives/dri-devel/2024-September/470488.html
Pierre-Eric Pelloux-Prayer (6):
drm: add DRM_SET_CLIENT_NAME ioctl
drm: use drm_file client_name in fdinfo
drm/amdgpu: delay th
valid use, and clears the existing name.
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 14 ++---
drivers/gpu/drm/drm_file.c| 5
drivers/gpu/drm/drm_ioctl.c | 55 +++
include/drm/drm_fil
Le 24/09/2024 à 10:43, Tvrtko Ursulin a écrit :
On 24/09/2024 09:23, Christian König wrote:
Am 23.09.24 um 12:25 schrieb Tvrtko Ursulin:
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote:
At this point the vm is locked so we safely modify it without risk of
concurrent access.
To
Le 23/09/2024 à 12:06, Tvrtko Ursulin a écrit :
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote:
Giving the opportunity to userspace to associate a free-form
name with a drm_file struct is helpful for tracking and debugging.
This is similar to the existing DMA_BUF_SET_NAME ioctl
Le 23/09/2024 à 12:58, Tvrtko Ursulin a écrit :
On 20/09/2024 10:06, Pierre-Eric Pelloux-Prayer wrote:
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit
Hi Dmitry,
Le 23/09/2024 à 12:28, Dmitry Osipenko a écrit :
On 9/20/24 12:06, Pierre-Eric Pelloux-Prayer wrote:
Giving the opportunity to userspace to associate a free-form
name with a drm_file struct is helpful for tracking and debugging.
This is similar to the existing DMA_BUF_SET_NAME
And rename it process_desc, since it will soon contain more than
just the process_name.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
Add an optional drm-client-name field to drm fdinfo's output.
Reviewed-by: Christian König
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-usage-stats.rst | 5 +
drivers/gpu/drm/drm_file.c| 5 +
2 files changed, 10 inser
gears/test-set-fd-name --
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 1 +
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
This will allow to use flexible array to store the process name and
other information.
This also means that process name will be determined once and for all,
instead of at each submit.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 15 +--
1
At this point the vm is locked so we safely modify it without risk of
concurrent access.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b
-'
* if a 0-length string is passed the name is cleared
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 12 ++---
drivers/gpu/drm/drm_file.c| 5
drivers/gpu/drm/drm_ioctl.c | 48 +++
include/drm/drm_file.h|
allocated on first submit
- amdgpu_task_info::process_name was renamed process_desc,
and includes drm_file::name when set. Like task_info
allocation this is done only once.
Pierre-Eric Pelloux-Prayer (6):
drm: add DRM_SET_NAME ioctl
drm: use drm_file name in fdinfo
drm/amdgpu:
Le 16/09/2024 à 16:35, Tvrtko Ursulin a écrit :
On 16/09/2024 14:32, Pierre-Eric Pelloux-Prayer wrote:
Giving the opportunity to userspace to associate a free-form
name with a drm_file struct is helpful for tracking and debugging.
This is similar to the existing DMA_BUF_SET_NAME ioctl
12255Process:glxgears/test-set-fd-name --
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 16 +---
drivers/gpu/drm/amd/a
-'
* if a 0-length string is passed the name is cleared
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 12 ++
drivers/gpu/drm/drm_file.c| 5 +
drivers/gpu/drm/drm_ioctl.c | 42 +++
include/drm/drm_file.h
Add an optional drm-client-name field to drm fdinfo's output.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-usage-stats.rst | 5 +
drivers/gpu/drm/drm_file.c| 5 +
2 files changed, 10 insertions(+)
diff --git a/Documentation/gpu/drm-usage-stats.r
Hi Tvrtko,
Le 12/09/2024 à 10:13, Tvrtko Ursulin a écrit :
On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote:
Giving the opportunity to userspace to associate a free-form
name with a drm_file struct is helpful for tracking and debugging.
This is similar to the existing DMA_BUF_SET_NAME
Hi,
Le 12/09/2024 à 10:24, Tvrtko Ursulin a écrit :
On 11/09/2024 15:58, Pierre-Eric Pelloux-Prayer wrote:
In debugfs gem_info/vm_info files, timeout handler and page fault reports.
This information is useful with the virtio/native-context driver: this
allows the guest applications
12255Process:glxgears/test-set-fd-name --
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 11 --
drivers/gpu/drm/amd/a
Add an optional drm-client-name field to drm fdinfo's output.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation/gpu/drm-usage-stats.rst | 5 +
drivers/gpu/drm/drm_file.c| 5 +
2 files changed, 10 insertions(+)
diff --git a/Documentation/gpu/drm-usage-stats.r
Userspace MR to use this ioctl:
https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1428
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
drivers/gpu/drm/drm_debugfs.c | 12
drivers/gpu/drm/drm_file.c| 5 +
drivers/gpu/drm/drm_ioct
Hi Maíra,
Le 03/07/2024 à 17:41, Maíra Canal a écrit :
Hi Pierre,
On 6/14/24 05:16, Pierre-Eric Pelloux-Prayer wrote:
This commit adds a document section in drm-uapi.rst about tracepoints,
and mark the events gpu_scheduler_trace.h as stable uAPI.
The goal is to explicitly state that tools
Le 03/07/2024 à 13:05, Lucas Stach a écrit :
Am Freitag, dem 14.06.2024 um 10:16 +0200 schrieb Pierre-Eric Pelloux-
Prayer:
Trace the fence dependencies similarly to how we print fences:
... , dependencies:{(context:606, seqno:38006)}
This allows tools to analyze the dependencies between
Le 03/07/2024 à 12:46, Lucas Stach a écrit :
Am Freitag, dem 14.06.2024 um 10:16 +0200 schrieb Pierre-Eric Pelloux-
Prayer:
This commit adds a document section in drm-uapi.rst about tracepoints,
and mark the events gpu_scheduler_trace.h as stable uAPI.
The goal is to explicitly state that
in this series.
Thanks!
Pierre-Eric
Le 14/06/2024 à 10:16, Pierre-Eric Pelloux-Prayer a écrit :
This commit adds a document section in drm-uapi.rst about tracepoints,
and mark the events gpu_scheduler_trace.h as stable uAPI.
The goal is to explicitly state that tools can rely on the fiel
Le 20/06/2024 à 15:36, Christian König a écrit :
Am 20.06.24 um 15:06 schrieb Pierre-Eric Pelloux-Prayer:
Le 19/06/2024 à 11:26, Christian König a écrit :
Am 18.06.24 um 17:23 schrieb Pierre-Eric Pelloux-Prayer:
Waking up a device can take multiple seconds, so if it's not
going to be
Hi,
Le 14/06/2024 à 11:08, Christian König a écrit :
Am 14.06.24 um 10:16 schrieb Pierre-Eric Pelloux-Prayer:
Until the switch from kthread to workqueue, a userspace application could
determine the source device from the pid of the thread sending the event.
With workqueues this is not
This commit adds a document section in drm-uapi.rst about tracepoints,
and mark the events gpu_scheduler_trace.h as stable uAPI.
The goal is to explicitly state that tools can rely on the fields,
formats and semantics of these events.
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
Documentation
the same base event class,
the caller of trace_drm_run_job have to pass a dep_count of 0 (which
is ignored because dependencies are only considered at submit time).
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 59 ---
drivers/gpu/drm
A fence uniquely identify a job, so this commits updates the places
where a kernel pointer was used as an identifier by:
"fence=(context:%llu, seqno:%lld)"
Signed-off-by: Pierre-Eric Pelloux-Prayer
---
.../gpu/drm/scheduler/gpu_scheduler_trace.h | 45 ++-
1 fi
Until the switch from kthread to workqueue, a userspace application could
determine the source device from the pid of the thread sending the event.
With workqueues this is not possible anymore, so the event needs to contain
the dev_name() to identify the device.
Signed-off-by: Pierre-Eric
-Eric Pelloux-Prayer (4):
drm/sched: add device name to the drm_sched_process_job event
drm/sched: cleanup gpu_scheduler trace events
drm/sched: trace dependencies for gpu jobs
drm/doc: document some tracepoints as uAPI
Documentation/gpu/drm-uapi.rst| 19 +++
.../gpu/drm
1 - 100 of 143 matches
Mail list logo
