Re: [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Phillip Potter
cdrom_sysctl_handler > }, > - { } > }; > static struct ctl_table_header *cdrom_sysctl_header; > > > -- > 2.30.2 Hi Joel, Looks good to me, many thanks. I'll send on for inclusion. Reviewed-by: Phillip Potter Regards, Phil

Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-09-30 Thread Phillip Potter
On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados > > > > > > This commit comes at the tail end of a greater

Re: [PATCH v2 7/8] cdrom: simplify subdirectory registration with register_sysctl()

2021-11-25 Thread Phillip Potter
l_header = register_sysctl_table(cdrom_root_table); > + cdrom_sysctl_header = register_sysctl("dev/cdrom", cdrom_table); > > /* set the defaults */ > cdrom_sysctl_settings.autoclose = autoclose; > -- > 2.33.0 > Dear Luis, Thank you for the patch. Tested and working, looks good to me. As this has already been pulled into Andrew Morton's tree, I have added in Jens and the linux-block list so there is awareness that the patch will go via -mm then linux-next tree. For what it's worth (although guess it won't be in the commit now): Reviewed-by: Phillip Potter Regards, Phil

Re: [PATCH] zero-fill colormap in drivers/video/fbdev/core/fbcmap.c

2021-04-02 Thread Phillip Potter
On Thu, Apr 01, 2021 at 11:55:50AM +0200, Geert Uytterhoeven wrote: > On Thu, Apr 1, 2021 at 12:09 AM Phillip Potter wrote: > > Use kzalloc() rather than kmalloc() for the dynamically allocated parts > > of the colormap in fb_alloc_cmap_gfp, to prevent a leak of random ker

[PATCH] zero-fill colormap in drivers/video/fbdev/core/fbcmap.c

2021-03-31 Thread Phillip Potter
=741578659feabd108ad9e06696f0c1f2e69c4b6e Reported-by: syzbot+47fa9c9c648b76530...@syzkaller.appspotmail.com Signed-off-by: Phillip Potter --- drivers/video/fbdev/core/fbcmap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/core/fbcmap.c b/drivers/video/fbdev

Re: [PATCH] drm: gma500: Replace 120ms mdelay calls in mdfld_dsi_pkg_sender.c

2018-10-03 Thread Phillip Potter
On Tue, Oct 02, 2018 at 09:52:51AM +0200, Patrik Jakobsson wrote: > Hi Phillip, > This is executed while holding a spinlock so we cannot sleep here. > This is true for send_pkg_done() as well. > > - Patrik Dear Patrik, Oops, sorry. I'll try and be more observant in future. Just picked up on thes

[PATCH] drm: gma500: Replace 120ms mdelay calls in mdfld_dsi_pkg_sender.c

2018-10-01 Thread Phillip Potter
Replace all 120ms mdelay macro calls with msleep function calls. As msleep is not suitable for < 20ms sleeps, also remove comment from mdelay(5) call. Signed-off-by: Phillip Potter --- diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sender.c b/drivers/gpu/drm/gma500/mdfld_dsi_pkg_sende