ree/Documentation/process/license-rules.rst
--
Cordially
Philippe Ombredanne
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
L-2.0-or-later
>> and GPL-2.0-only later, and kernel sources will likely then get patched in
>> one
>> go.
>
> + Philippe O. to check what I'm writing just below.
>
> In -next branch I only see reference to GPL-2.0+ identifier so for me
> it fine to use it here.
tion) any later version.
> - *
> * Modified by Philippe Cornu
> * This generic Synopsys DesignWare MIPI DSI host driver is based on the
> * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.
> --
> 2.15.1
>
Thank you.
Acked-by: Philippe Omb
> Signed-off-by: Sean Paul
> --- /dev/null
> +++ b/include/drm/drm_hdcp.h
> @@ -0,0 +1,39 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright (C) 2017 Google, Inc.
> + *
> + * Authors:
> + * Sean Paul
> + */
Thank you++ for
R ANY CLAIM, DAMAGES OR
> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
Would you mind using an SPDX tag instead of this fine but long legales
er
> lines" behavior, ok?
>
> Alex, can you talk to the AMD lawyers and ask them about just putting
> the SPDX line instead?
>
> Linus
You made my day! I shall add that every time someone sends a patch
with long legalese boilerplate instead of a shorter SDPX t
a style that you should at least use for the license id
as requested and commented by Linus:
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright 2017 David Lechner
> +// DRM driver for Sitronix ST7735R panels
--
Cordially
Philippe Ombredanne
by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + */
Maxime,
Would you consider using the new SPDX ids instead of this fine legalese?
e.g. this as the top line:
// SPDX-License-Identifier: GPL-2.0+
--
Cordially
Philippe Omb
u/drm/stm/ltdc.h
>> +++ b/drivers/gpu/drm/stm/ltdc.h
>> @@ -1,3 +1,4 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> /*
>>* Copyright (C) STMicroelectronics SA 2017
>>*
>> @@ -5,8 +6,6 @@
>>* Yannick Fertre
>>* Fabien Dessenne
>>* Mickael Reulier
>> - *
>> - * License terms: GNU General Public License (GPL), version 2
>>*/
>>
>> #ifndef _LTDC_H_
>>
For the use of SPDX ids: Thank you +++ and
Acked-by: Philippe Ombredanne
--
Cordially
Philippe Ombredanne
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
c
>> +++ b/drivers/gpu/drm/sti/sti_tvout.c
>> @@ -1,9 +1,9 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> /*
>>* Copyright (C) STMicroelectronics SA 2014
>>* Authors: Benjamin Gaignard
>>* Vincent Abriou
>>* for STMicroelectronics.
>> - * License terms: GNU General Public License (GPL), version 2
>>*/
>>
>> #include
>> diff --git a/drivers/gpu/drm/sti/sti_vid.c b/drivers/gpu/drm/sti/sti_vid.c
>> index 577a3341d3c1..2aac36c95835 100644
>> --- a/drivers/gpu/drm/sti/sti_vid.c
>> +++ b/drivers/gpu/drm/sti/sti_vid.c
>> @@ -1,7 +1,7 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> /*
>>* Copyright (C) STMicroelectronics SA 2014
>>* Author: Fabien Dessenne for STMicroelectronics.
>> - * License terms: GNU General Public License (GPL), version 2
>>*/
>> #include
>>
>> diff --git a/drivers/gpu/drm/sti/sti_vid.h b/drivers/gpu/drm/sti/sti_vid.h
>> index fdc90f922a05..9dbd78461de1 100644
>> --- a/drivers/gpu/drm/sti/sti_vid.h
>> +++ b/drivers/gpu/drm/sti/sti_vid.h
>> @@ -1,7 +1,7 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> /*
>>* Copyright (C) STMicroelectronics SA 2014
>>* Author: Fabien Dessenne for STMicroelectronics.
>> - * License terms: GNU General Public License (GPL), version 2
>>*/
>>
>> #ifndef _STI_VID_H_
>> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
>> index 2dcba1d3a122..fbadb9ef6d31 100644
>> --- a/drivers/gpu/drm/sti/sti_vtg.c
>> +++ b/drivers/gpu/drm/sti/sti_vtg.c
>> @@ -1,10 +1,10 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> /*
>>* Copyright (C) STMicroelectronics SA 2014
>>* Authors: Benjamin Gaignard
>>* Fabien Dessenne
>>* Vincent Abriou
>>* for STMicroelectronics.
>> - * License terms: GNU General Public License (GPL), version 2
>>*/
>>
>> #include
>> diff --git a/drivers/gpu/drm/sti/sti_vtg.h b/drivers/gpu/drm/sti/sti_vtg.h
>> index f1dcdf9c2342..d177129e5bcb 100644
>> --- a/drivers/gpu/drm/sti/sti_vtg.h
>> +++ b/drivers/gpu/drm/sti/sti_vtg.h
>> @@ -1,7 +1,7 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> /*
>>* Copyright (C) STMicroelectronics SA 2014
>>* Author: Benjamin Gaignard for
>> STMicroelectronics.
>> - * License terms: GNU General Public License (GPL), version 2
>>*/
>>
>> #ifndef _STI_VTG_H_
>>
For the use of SPDX ids: Thank you +++ feel free to add my review to
the patch series
Reviewed-by: Philippe Ombredanne
--
Cordially
Philippe Ombredanne
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
rk properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined in a .h file
> far away from the .c file it is used in.
>
> Cc: Patrik Jakobsson
> Cc: David Airlie
> Reported-by: Philippe Ombredanne
> Signed-off-by: Greg K
11 matches
Mail list logo