Re: [PATCH v2 21/25] nvdimm: virtio_pmem: drop owner assignment

2024-03-31 Thread Pankaj Gupta
virtio core already sets the .owner, so driver does not need to. > > Acked-by: Dave Jiang > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Pankaj Gupta > Depends on the first patch. > --- > drivers/nvdimm/virtio_pmem.c | 1 - > 1 file changed, 1 deletion(-) > &g

Re: [PATCH RFC] virtio: wrap config->reset calls

2021-10-13 Thread Pankaj Gupta
644 > --- a/net/vmw_vsock/virtio_transport.c > +++ b/net/vmw_vsock/virtio_transport.c > @@ -665,7 +665,7 @@ static void virtio_vsock_remove(struct virtio_device > *vdev) > vsock_for_each_connected_socket(virtio_vsock_reset_sock); > > /* Stop all work handlers to make sure no one is accessing the device, > -* so we can safely call vdev->config->reset(). > +* so we can safely call virtio_reset_device(). > */ > mutex_lock(&vsock->rx_lock); > vsock->rx_run = false; > @@ -682,7 +682,7 @@ static void virtio_vsock_remove(struct virtio_device > *vdev) > /* Flush all device writes and interrupts, device will not use any > * more buffers. > */ > - vdev->config->reset(vdev); > + virtio_reset_device(vdev); > > mutex_lock(&vsock->rx_lock); > while ((pkt = virtqueue_detach_unused_buf(vsock->vqs[VSOCK_VQ_RX]))) > diff --git a/sound/virtio/virtio_card.c b/sound/virtio/virtio_card.c > index 150ab3e37013..e2847c040f75 100644 > --- a/sound/virtio/virtio_card.c > +++ b/sound/virtio/virtio_card.c > @@ -350,7 +350,7 @@ static void virtsnd_remove(struct virtio_device *vdev) > snd_card_free(snd->card); > > vdev->config->del_vqs(vdev); > - vdev->config->reset(vdev); > + virtio_reset_device(vdev); > > for (i = 0; snd->substreams && i < snd->nsubstreams; ++i) { > struct virtio_pcm_substream *vss = &snd->substreams[i]; > @@ -379,7 +379,7 @@ static int virtsnd_freeze(struct virtio_device *vdev) > virtsnd_ctl_msg_cancel_all(snd); > > vdev->config->del_vqs(vdev); > - vdev->config->reset(vdev); > + virtio_reset_device(vdev); > > for (i = 0; i < snd->nsubstreams; ++i) > cancel_work_sync(&snd->substreams[i].elapsed_period); Reviewed-by: Pankaj Gupta

Re: [PATCH v7 1/9] fs: Constify vma argument to vma_is_dax

2020-03-26 Thread Pankaj Gupta
ux/fs.h > @@ -3391,7 +3391,7 @@ static inline bool io_is_direct(struct file *filp) > return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host); > } > > -static inline bool vma_is_dax(struct vm_area_struct *vma) > +static inline bool vma_is_da