lcdsel_grf_reg is defined as u32, so "< 0" comaprison is always false,
which breaks VOP selection on eg. RK3399. Compare against 0.
Fixes: f3aaa6125b6f ("drm/rockchip: dsi: add rk3568 support")
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/rockchip/dw-mipi-dsi-rock
mit makes sun8i-hdmi-phy into a proper platform device
and fixes the display pipeline probe on sunxi boards that use HDMI.
More context: https://lkml.org/lkml/2021/5/16/203
Signed-off-by: Saravana Kannan
Signed-off-by: Ondrej Jirman
---
v2: Fix building as a module (phy and hdmi are part of the
is commit makes sun8i-hdmi-phy into a proper platform device
and fixes the display pipeline probe on sunxi boards that use HDMI.
More context: https://lkml.org/lkml/2021/5/16/203
Signed-off-by: Saravana Kannan
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 4 +--
It's writing too much data. regmap_bulk_write expects number of
register sized chunks to write, not a byte sized length of the
bounce buffer. Bounce buffer needs to be padded too, so that
regmap_bulk_write will not read past the end of the buffer.
Signed-off-by: Ondrej Jirman
---
driver
Allwinner A31 MIPI-DSI controller support")
Signed-off-by: Ondrej Jirman
Reviewed-by: Jernej Skrabec
---
v2:
- use ALIGN
- add tags
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
b/driver
uired voltage. Use 10-20ms to also
give the power supplies some time to reach the required voltage,
too.
This fixes intermittent panel initialization failures and screen
corruption during resume from sleep on PinePhone.
Reported-by: Samuel Holland
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/
ake a look.
thank you and regards,
Ondrej Jirman
Ondrej Jirman (2):
drm/panel: st7703: Make the sleep exit timing match the spec
drm/panel: st7703: Fix the power up sequence of the panel
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 29 ++-
1 file changed, 15 insertions(+), 14
between init commands and the sleep exit command is
not necessary. (not specified anywhere)
Reported-by: Samuel Holland
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel
quired property
- 'iovcc-supply' is a required property
- 'reset-gpios' is a required property
Fix it.
Signed-off-by: Ondrej Jirman
---
.../devicetree/bindings/display/bridge/nwl-dsi.yaml | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/
The display has one port. Allow it in the binding.
Signed-off-by: Ondrej Jirman
---
.../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git
a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
b/Documentation
This patchset fixes warnings in the example in display/bridge/nwl-dsi.yaml
revealed during port of display/panel/rocktech,jh057n00900.yaml to
yaml.
Please take a look.
thank you and regards,
Ondrej Jirman
Ondrej Jirman (2):
dt-bindings: display: Fix example in nwl-dsi.yaml
dt-binding
Pinephone has a Goodix GT917S capacitive touchscreen controller on
I2C0 bus. Add support for it.
Signed-off-by: Ondrej Jirman
Acked-by: Linus Walleij
---
.../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts
Convert Rocktech MIPI DSI panel driver from txt to yaml bindings.
Signed-off-by: Ondrej Jirman
---
.../display/panel/rocktech,jh057n00900.txt| 23 ---
.../display/panel/rocktech,jh057n00900.yaml | 66 +++
2 files changed, 66 insertions(+), 23 deletions(-)
delete mode
From: Icenowy Zheng
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for
display.
Backlight levels curve was optimized by Martijn Braam using a
lux meter.
Add its device nodes.
Signed-off-by: Icenowy Zheng
Signed-off-by: Martijn Braam
Signed-off-by: Ondrej Jirman
Acked-by
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in
PinePhone. Add support for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 199 +-
1 file changed, 197 insertions(
From: Icenowy Zheng
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for
display.
Backlight levels curve was optimized by Martijn Braam using a
lux meter.
Add its device nodes.
Signed-off-by: Icenowy Zheng
Signed-off-by: Martijn Braam
Signed-off-by: Ondrej Jirman
Acked-by
This rename is done so that the driver matches the name of the
display controller and in preparation for adding support for more
panels to the driver.
This is just a basic file rename, with no code changes.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel
The datasheet suggests to issue sleep in after display off
as a part of the panel's shutdown sequence.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --
Calling sleep out and display on is a controller specific part
of the initialization process. Move it out of the panel specific
initialization function to the enable callback.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 33
This rename is done so that the driver matches the name of the
display controller and in preparation for adding support for more
panels to the driver.
This is just a basic file rename, with no code changes.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel
It's better than having it spread around the driver.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 50 +--
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in
PinePhone. Add support for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 200 +-
1 file changed, 198 insertions(
This patchset adds support for the LCD panel of PinePhone.
I've tested this on PinePhone 1.0 and 1.2.
Please take a look.
thank you and regards,
Ondrej Jirman
Changes in v7:
- Removed mode.vrefresh, rebased onto next-20200701
- v6->v7 diff: https://megous.com/dl/tmp/v6-v7.patch
Ch
Parametrize the driver so that it can support more panels based
on st7703 controller.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 43 +--
1 file changed, 31 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu
The reset pin is inverted, so if we don't assert reset, the actual gpio
will be high and may keep driving the IO port of the panel.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 +
1 file changed, 1 insertion(+)
diff --
Pinephone has a Goodix GT917S capacitive touchscreen controller on
I2C0 bus. Add support for it.
Signed-off-by: Ondrej Jirman
Acked-by: Linus Walleij
---
.../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts
It's better than having it spread around the driver.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 48 +--
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7
From: Icenowy Zheng
Shenzhen Xingbangda Display Technology Co., Ltd is a company which
produces LCD modules. It supplies the LCD panels for the PinePhone.
Add the vendor prefix of it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
Acked-by: Rob Herring
---
Documentation
Convert Rocktech MIPI DSI panel driver from txt to yaml bindings.
Signed-off-by: Ondrej Jirman
---
.../display/panel/rocktech,jh057n00900.txt| 23 ---
.../display/panel/rocktech,jh057n00900.yaml | 66 +++
2 files changed, 66 insertions(+), 23 deletions(-)
delete mode
This patchset adds support for the LCD panel of PinePhone.
I've tested this on PinePhone 1.0 and 1.2.
Please take a look.
thank you and regards,
Ondrej Jirman
Changes in v6:
- Fixed spacing in yaml
- Fixed wrong vccio->iovcc supply name in the bindings doc
- I noticed that the
Calling sleep out and display on is a controller specific part
of the initialization process. Move it out of the panel specific
initialization function to the enable callback.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 33
The driver was renamed, change the path in the MAINTAINERS file.
Signed-off-by: Ondrej Jirman
---
MAINTAINERS | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5f186a661a9b..f5183eae08df 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on
Sitronix ST7703 LCD controller just like rocktech,jh057n00900. It is
used in PinePhone.
Add a compatible for it.
Signed-off-by: Ondrej Jirman
---
.../bindings/display/panel/rocktech,jh057n00900.yaml| 6
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on
Sitronix ST7703 LCD controller just like rocktech,jh057n00900. It is
used in PinePhone.
Add a compatible for it.
Signed-off-by: Ondrej Jirman
---
.../bindings/display/panel/rocktech,jh057n00900.yaml| 6
The datasheet suggests to issue sleep in after display off
as a part of the panel's shutdown sequence.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --
From: Icenowy Zheng
Shenzhen Xingbangda Display Technology Co., Ltd is a company which
produces LCD modules. It supplies the LCD panels for the PinePhone.
Add the vendor prefix of it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
Acked-by: Rob Herring
---
Documentation
The reset pin is inverted, so if we don't assert reset, the actual gpio
will be high and may keep driving the IO port of the panel.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 +
1 file changed, 1 insertion(+)
diff --
This is done so that code that's not specific to a particular
jh057n panel is named after the controller. Functions specific
to the panel are kept named after the panel.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c
Parametrize the driver so that it can support more panels based
on st7703 controller.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 43 +--
1 file changed, 31 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu
This is done so that code that's not specific to a particular
jh057n panel is named after the controller. Functions specific
to the panel are kept named after the panel.
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c
Calling sleep out and display on is a controller specific part
of the initialization process. Move it out of the panel specific
initialization function to the enable callback.
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 33 ++-
1 file changed
It's better than having it spread around the driver.
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 50 +--
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
b/drivers/gpu/drm/
Pinephone has a Goodix GT917S capacitive touchscreen controller on
I2C0 bus. Add support for it.
Signed-off-by: Ondrej Jirman
---
.../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64
This is done so that code that's not specific to a particular
jh057n panel is named after the controller. Functions specific
to the panel are kept named after the panel.
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 90 ++-
1 file change
From: Icenowy Zheng
Shenzhen Xingbangda Display Technology Co., Ltd is a company which
produces LCD modules. It supplies the LCD panels for the PinePhone.
Add the vendor prefix of it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
Acked-by: Rob Herring
---
Documentation
The reset pin is inverted, so if we don't assert reset, the actual gpio
will be high and may keep driving the IO port of the panel.
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/
From: Icenowy Zheng
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for
display.
Backlight levels curve was optimized by Martijn Braam using a
lux meter.
Add its device nodes.
Signed-off-by: Icenowy Zheng
Signed-off-by: Martijn Braam
Signed-off-by: Ondrej Jirman
Parametrize the driver so that it can support more panels based
on st7703 controller.
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 43 +--
1 file changed, 31 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on
Sitronix ST7703 LCD controller just like rocktech,jh057n00900. It is
used in PinePhone.
Add a compatible for it.
Signed-off-by: Ondrej Jirman
---
.../bindings/display/panel/rocktech,jh057n00900.yaml| 6
The datasheet suggests to issue sleep in after display off
as a part of the panel's shutdown sequence.
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/
This rename is done so that the driver matches the name of the
display controller and in preparation for adding support for more
panels to the driver.
This is just a basic file rename, with no code changes.
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/Kconfig | 26
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel used in
PinePhone. Add support for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 199 +-
1 file changed, 197 insertions(+), 2 deletions(-)
diff --
Convert Rocktech MIPI DSI panel driver from txt to yaml bindings.
Signed-off-by: Ondrej Jirman
---
.../display/panel/rocktech,jh057n00900.txt| 23 ---
.../display/panel/rocktech,jh057n00900.yaml | 66 +++
2 files changed, 66 insertions(+), 23 deletions(-)
delete mode
This patchset adds support for the LCD panel of PinePhone.
I've tested this on PinePhone 1.0 and 1.2.
Please take a look.
thank you and regards,
Ondrej Jirman
Changes in v5:
- rewritten on top of rocktech-jh057n00900 driver
- rocktech-jh057n00900 renamed to st7703 (controller
From: Icenowy Zheng
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for
display.
Backlight levels curve was optimized by Martijn Braam using a
lux meter.
Add its device nodes.
Signed-off-by: Icenowy Zheng
Signed-off-by: Martijn Braam
Signed-off-by: Ondrej Jirman
From: Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on
Sitronix ST7703 LCD controller.
Add its device tree binding.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
Reviewed-by: Linus Walleij
Reviewed-by: Rob Herring
---
.../display/
From: Icenowy Zheng
Shenzhen Xingbangda Display Technology Co., Ltd is a company which
produces LCD modules. It supplies the LCD panels for the PinePhone.
Add the vendor prefix of it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
Acked-by: Rob Herring
---
Documentation
From: Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI IPS LCD panel made by
Xingbangda, which is used on PinePhone final assembled phones.
It is based on Sitronix ST7703 LCD controller.
Add support for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
---
dr
This patchset adds support for the LCD panel of PinePhone.
The first 3 patches are for the panel itself, and the last 2 patches are
for enabling it on PinePhone.
I've tested this on PinePhone 1.0 and 1.2.
Please take a look.
thank you and regards,
Ondrej Jirman
Changes in v4:
- use -
Pinephone has a Goodix GT917S capacitive touchscreen controller on
I2C0 bus. Add support for it.
Signed-off-by: Ondrej Jirman
---
.../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64
This patchset adds support for the LCD panel of PinePhone.
The first 3 patches are for the panel itself, and the last 2 patches are
for enabling it on PinePhone.
I've tested this on PinePhone 1.0 and 1.2.
Please take a look.
thank you and regards,
Ondrej Jirman
Changes in v3:
-
From: Icenowy Zheng
Shenzhen Xingbangda Display Technology Co., Ltd is a company which
produces LCD modules. It supplies the LCD panels for the PinePhone.
Add the vendor prefix of it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
---
Documentation/devicetree/bindings/vendor
From: Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI IPS LCD panel made by
Xingbangda, which is used on PinePhone final assembled phones.
It is based on Sitronix ST7703 LCD controller.
Add support for it.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
---
dr
Pinephone has a Goodix GT917S capacitive touchscreen controller on
I2C0 bus. Add support for it.
Signed-off-by: Ondrej Jirman
---
.../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64
From: Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI LCD panel. It is based on
Sitronix ST7703 LCD controller.
Add its device tree binding.
Signed-off-by: Icenowy Zheng
Signed-off-by: Ondrej Jirman
---
.../display/panel/sitronix,st7703.yaml| 63 +
From: Icenowy Zheng
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for
display.
Backlight levels curve was optimized by Martijn Braam using a
lux meter.
Add its device nodes.
Signed-off-by: Icenowy Zheng
Signed-off-by: Martijn Braam
Signed-off-by: Ondrej Jirman
Arguments to GENMASK should be msb >= lsb.
Signed-off-by: Ondrej Jirman
---
I just grepped the whole kernel tree for GENMASK argument order issues,
and this is one of the three that popped up. No testing was done.
drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +-
1 file changed, 1 insertion(+)
Shut down the display engine during suspend.
Signed-off-by: Ondrej Jirman
---
Changes in v2:
- spaces -> tabs
drivers/gpu/drm/sun4i/sun4i_drv.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c
b/drivers/gpu/drm/sun4i/sun4i_dr
Shut down the display engine during suspend.
Signed-off-by: Ondrej Jirman
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c
b/drivers/gpu/drm/sun4i/sun4i_drv.c
index a5757b11b730..c519d7cfcf43
69 matches
Mail list logo
