Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-07-17 Thread Omer Shpigelman
On 7/17/24 15:33, Leon Romanovsky wrote: > On Wed, Jul 17, 2024 at 10:51:03AM +0000, Omer Shpigelman wrote: >> On 7/17/24 10:36, Leon Romanovsky wrote: >>> On Wed, Jul 17, 2024 at 07:08:59AM +0000, Omer Shpigelman wrote: >>>> On 7/16/24 16:40, Jason Gunthorpe wrote:

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-07-17 Thread Omer Shpigelman
On 7/17/24 10:36, Leon Romanovsky wrote: > On Wed, Jul 17, 2024 at 07:08:59AM +0000, Omer Shpigelman wrote: >> On 7/16/24 16:40, Jason Gunthorpe wrote: >>> On Sun, Jul 14, 2024 at 10:18:12AM +0000, Omer Shpigelman wrote: >>>> On 7/12/24 16:08, Jason Gunthorpe wro

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-07-17 Thread Omer Shpigelman
On 7/16/24 16:40, Jason Gunthorpe wrote: > On Sun, Jul 14, 2024 at 10:18:12AM +0000, Omer Shpigelman wrote: >> On 7/12/24 16:08, Jason Gunthorpe wrote: >>> [You don't often get email from j...@ziepe.ca. Learn why this is important >>> at https://aka.ms/LearnAboutS

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-07-14 Thread Omer Shpigelman
On 7/12/24 16:08, Jason Gunthorpe wrote: > [You don't often get email from j...@ziepe.ca. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Fri, Jun 28, 2024 at 10:24:32AM +, Omer Shpigelman wrote: > >> We need the core driv

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-07-01 Thread Omer Shpigelman
On 6/30/24 16:29, Leon Romanovsky wrote: > On Fri, Jun 28, 2024 at 10:24:32AM +0000, Omer Shpigelman wrote: >> On 6/19/24 13:52, Leon Romanovsky wrote: >>> On Wed, Jun 19, 2024 at 09:27:54AM +0000, Omer Shpigelman wrote: >>>> On 6/18/24 15:58, Leon Romanovsky wrote:

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-30 Thread Omer Shpigelman
On 6/26/24 17:13, Andrew Lunn wrote: >> Here is the output: >> $ ethtool eth0 >> Settings for eth0: >> Supported ports: [ FIBRE Backplane ] >> Supported link modes: 10baseKR4/Full >> 10baseSR4/Full >> 10baseCR

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-28 Thread Omer Shpigelman
On 6/19/24 13:52, Leon Romanovsky wrote: > On Wed, Jun 19, 2024 at 09:27:54AM +0000, Omer Shpigelman wrote: >> On 6/18/24 15:58, Leon Romanovsky wrote: >>> On Tue, Jun 18, 2024 at 11:08:34AM +0000, Omer Shpigelman wrote: >>>> On 6/17/24 22:04, Leon Romanovsky wrote: &

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-26 Thread Omer Shpigelman
On 6/23/24 17:46, Andrew Lunn wrote: >>> But what about when the system is under memory pressure? You say it >>> allocates memory. What happens if those allocations fail. Does >>> changing the MTU take me from a working system to a dead system? It is >>> good practice to not kill a working system u

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-24 Thread Omer Shpigelman
On 6/19/24 13:52, Leon Romanovsky wrote: > On Wed, Jun 19, 2024 at 09:27:54AM +0000, Omer Shpigelman wrote: >> On 6/18/24 15:58, Leon Romanovsky wrote: >>> On Tue, Jun 18, 2024 at 11:08:34AM +0000, Omer Shpigelman wrote: >>>> On 6/17/24 22:04, Leon Romanovsky wrote: &

Re: [PATCH 04/15] net: hbl_cn: QP state machine

2024-06-24 Thread Omer Shpigelman
On 6/18/24 12:00, Leon Romanovsky wrote: > On Tue, Jun 18, 2024 at 07:58:55AM +0000, Omer Shpigelman wrote: >> On 6/18/24 10:08, Leon Romanovsky wrote: >>> On Tue, Jun 18, 2024 at 05:50:15AM +0000, Omer Shpigelman wrote: >>>> On 6/17/24 16:18, Leon Romanovsky wrote: &

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-24 Thread Omer Shpigelman
On 6/23/24 18:02, Andrew Lunn wrote: >>> If there is no netdev, what is the point of putting it into loopback? >>> How do you send packets which are to be looped back? How do you >>> receive them to see if they were actually looped back? >>> >>> Andrew >> >> To run RDMA test in loopback. > > W

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-23 Thread Omer Shpigelman
On 6/20/24 22:14, Andrew Lunn wrote: > On Thu, Jun 20, 2024 at 06:51:35AM -0700, Jakub Kicinski wrote: >> On Thu, 20 Jun 2024 08:43:34 +0000 Omer Shpigelman wrote: >>>> You support 400G, you really need to give the user the ability >>>> to access higher pages. &

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-23 Thread Omer Shpigelman
On 6/21/24 13:30, Sunil Kovvuri Goutham wrote: + +What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_disable_decap +What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_inject_rx_err +What: >> /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_mac_lane_remap >>

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-22 Thread Omer Shpigelman
On 6/21/24 18:33, Andrew Lunn wrote: >> I see other vendors have debugfs entries for debug configurations or >> settings, not just for dumping debug info. > > Did you see any added in the last few years? This is also something > DaveM pushed back on. We want uniform APIs so that all devices look >

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-22 Thread Omer Shpigelman
On 6/19/24 19:13, Andrew Lunn wrote: > On Wed, Jun 19, 2024 at 07:16:20AM +0000, Omer Shpigelman wrote: >> On 6/18/24 17:19, Andrew Lunn wrote: >>>>>> +static u32 hbl_en_get_mtu(struct hbl_aux_dev *aux_dev, u32 port_idx) >>>>>> +{ >>>&g

Re: [PATCH 13/15] accel/habanalabs: network scaling support

2024-06-21 Thread Omer Shpigelman
On 6/19/24 21:41, Sunil Kovvuri Goutham wrote: > [Some people who received this message don't often get email from > sgout...@marvell.com. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > >> >> Add common support for AI scaling over the network. Initialize the h

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-21 Thread Omer Shpigelman
On 6/19/24 21:35, Sunil Kovvuri Goutham wrote: > [Some people who received this message don't often get email from > sgout...@marvell.com. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > >> + >> +What: /sys/kernel/debug/habanalabs_cn/hbl_cn/nic_disabl

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-20 Thread Omer Shpigelman
On 6/19/24 18:21, Jakub Kicinski wrote: > [Some people who received this message don't often get email from > k...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Wed, 19 Jun 2024 07:16:20 + Omer Shpigelman wrote: >&

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-20 Thread Omer Shpigelman
On 6/19/24 18:40, Andrew Lunn wrote: >>> Does this device require IPv4? What about users and infrastructures that >>> use IPv6 only? >>> IPv4 is legacy at this point. >> >> Gaudi2 supports IPv4 only. > > Really? I guess really old stuff, SLIP from 1988 does not support > IPv6, but i don't remembe

Re: [PATCH 00/15] Introduce HabanaLabs network drivers

2024-06-19 Thread Omer Shpigelman
On 6/19/24 19:33, Jiri Pirko wrote: > [You don't often get email from j...@resnulli.us. Learn why this is important > at https://aka.ms/LearnAboutSenderIdentification ] > > Thu, Jun 13, 2024 at 10:21:53AM CEST, oshpigel...@habana.ai wrote: >> This patch set implements the HabanaLabs network drive

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-19 Thread Omer Shpigelman
On 6/19/24 11:01, Przemek Kitszel wrote: > On 6/19/24 09:16, Omer Shpigelman wrote: >> On 6/18/24 17:19, Andrew Lunn wrote: > > [...] > >>>>>> +module_param(poll_enable, bool, 0444); >>>>>> +MODULE_PARM_DESC(poll_enable, >>>>>

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-19 Thread Omer Shpigelman
On 6/19/24 00:19, Stephen Hemminger wrote: > On Tue, 18 Jun 2024 19:37:36 + > Omer Shpigelman wrote: > >>> >>> Is there any reason in particular to call netif_receive_skb instead of >>> napi_gro_receive ? >>> >> >> As you can s

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-19 Thread Omer Shpigelman
On 6/15/24 03:10, Stephen Hemminger wrote: > [You don't often get email from step...@networkplumber.org. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, 13 Jun 2024 11:22:02 +0300 > Omer Shpigelman wrote: > >> +static i

Re: [PATCH 00/15] Introduce HabanaLabs network drivers

2024-06-19 Thread Omer Shpigelman
On 6/17/24 15:34, Alexander Lobakin wrote: > [Some people who received this message don't often get email from > aleksander.loba...@intel.com. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > From: Omer Shpigelman > Date: Thu, 13

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-19 Thread Omer Shpigelman
On 6/17/24 17:17, Jason Gunthorpe wrote: > [You don't often get email from j...@ziepe.ca. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:04AM +0300, Omer Shpigelman wrote: >> Add an RDMA driver of Ga

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-19 Thread Omer Shpigelman
On 6/18/24 19:01, Przemek Kitszel wrote: > On 6/18/24 13:08, Omer Shpigelman wrote: >> On 6/17/24 22:04, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from >>> l...@kernel.org. Learn why this is

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-19 Thread Omer Shpigelman
On 6/18/24 15:58, Leon Romanovsky wrote: > On Tue, Jun 18, 2024 at 11:08:34AM +0000, Omer Shpigelman wrote: >> On 6/17/24 22:04, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from >>> l...@kernel.org. Learn why this is

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-19 Thread Omer Shpigelman
On 6/18/24 17:19, Andrew Lunn wrote: +static u32 hbl_en_get_mtu(struct hbl_aux_dev *aux_dev, u32 port_idx) +{ + struct hbl_en_port *port = HBL_EN_PORT(aux_dev, port_idx); + struct net_device *ndev = port->ndev; + u32 mtu; + + if (atomic_cmpxchg(&po

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 01:48, Joe Damato wrote: > [You don't often get email from jdam...@fastly.com. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:02AM +0300, Omer Shpigelman wrote: >> This ethernet driver is initia

Re: [PATCH 04/15] net: hbl_cn: QP state machine

2024-06-18 Thread Omer Shpigelman
On 6/18/24 10:08, Leon Romanovsky wrote: > On Tue, Jun 18, 2024 at 05:50:15AM +0000, Omer Shpigelman wrote: >> On 6/17/24 16:18, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from >>> l...@kernel.org. Learn why this is

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 14:48, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 08:08:26AM +0000, Omer Shpigelman wro

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 13:55, Zhu Yanjun wrote: > [You don't often get email from yanjun@linux.dev. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > 在 2024/6/13 16:22, Omer Shpigelman 写道: >> + >> +/* This function should be called after ctr

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 03:16, Stephen Hemminger wrote: > [You don't often get email from step...@networkplumber.org. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > >> + >> +/* get the src IP as it is done in devinet_ioctl() */ >> +static int hbl_en_get_src_ip(struct hbl_au

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 18:02, Andrew Lunn wrote: > [Some people who received this message don't often get email from > and...@lunn.ch. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 04:05:57PM +0200, Markus Elfring wrote: >> … >>> +++ b/drivers/ne

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 22:04, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 05:43:49PM +0000, Omer Shpigelman wro

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 03:05, Stephen Hemminger wrote: > [You don't often get email from step...@networkplumber.org. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > >> +#define HBL_AUX2NIC(aux_dev) \ >> + ({ \ >> + struct hbl_aux_dev *__aux_dev = (aux_dev);

Re: [PATCH 04/15] net: hbl_cn: QP state machine

2024-06-18 Thread Omer Shpigelman
On 6/17/24 16:18, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:21:57AM +0300, Omer Shpigelman wr

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-18 Thread Omer Shpigelman
On 6/13/24 22:18, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:04AM +0300, Omer Shpigelman w

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/13/24 16:01, Przemek Kitszel wrote: > [Some people who received this message don't often get email from > przemyslaw.kits...@intel.com. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On 6/13/24 10:21, Omer Shpigelman wrote: >

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/14/24 00:49, Andrew Lunn wrote: > [Some people who received this message don't often get email from > and...@lunn.ch. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > >> +static int hbl_en_napi_poll(struct napi_struct *napi, int budget); >> +static int hbl_

[PATCH 06/15] net: hbl_cn: debugfs support

2024-06-14 Thread Omer Shpigelman
Add debugfs files for advanced settings, debug options and testing. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey Agranovich Co-developed-by: Bharat Jauhari Signed-off-by: Bharat Jauhari Co

[PATCH 05/15] net: hbl_cn: memory trace events

2024-06-14 Thread Omer Shpigelman
Add trace events for hbl_cn to track memory allocations. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey Agranovich Co-developed-by: Bharat Jauhari Signed-off-by: Bharat Jauhari Co-developed

[PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-14 Thread Omer Shpigelman
This ethernet driver is initialized via auxiliary bus by the hbl_cn driver. It serves mainly for control operations that are needed for AI scaling. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey

[PATCH 13/15] accel/habanalabs: network scaling support

2024-06-14 Thread Omer Shpigelman
Add common support for AI scaling over the network. Initialize the hbl_cn driver via auxiliary bus and serve as its adapter for accessing the device. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by

[PATCH 10/15] net: hbl_en: gaudi2: ASIC specific support

2024-06-14 Thread Omer Shpigelman
Add Gaudi2 ASIC specific support for ethernet purpose which includes HW specific configurations and operations. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey Agranovich Co-developed-by: Bharat

[PATCH 12/15] RDMA/hbl: direct verbs support

2024-06-14 Thread Omer Shpigelman
Add direct verbs (DV) uAPI. The added operations are: query_port: query vendor specific port attributes. set_port_ex: set port extended settings. usr_fifo: set user FIFO object for triggering HW doorbells. encap: set port encapsulation (UDP/IPv4). Signed-off-by: Omer Shpigelman Co-developed-by

[PATCH 14/15] accel/habanalabs/gaudi2: CN registers header files

2024-06-14 Thread Omer Shpigelman
Add the relevant CN registers header files. These files are generated automatically from a tool maintained by the VLSI engineers. These are required for the upcoming GAUDI2 CN driver support. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed

[PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-14 Thread Omer Shpigelman
tracking and port/device HW counters. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey Agranovich Co-developed-by: Bharat Jauhari Signed-off-by: Bharat Jauhari Co-developed-by: David Meriin

[PATCH 00/15] Introduce HabanaLabs network drivers

2024-06-14 Thread Omer Shpigelman
/pull/1472 Any feedback, comment or question is welcome. Thanks, Omer Omer Shpigelman (15): net: hbl_cn: add habanalabs Core Network driver net: hbl_cn: memory manager component net: hbl_cn: physical layer support net: hbl_cn: QP state machine net: hbl_cn: memory trace events net

[PATCH 03/15] net: hbl_cn: physical layer support

2024-06-14 Thread Omer Shpigelman
Add a common physical (PHY) layer initialization and link notification. An notification is sent on every link up/down change. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey Agranovich Co

[PATCH 02/15] net: hbl_cn: memory manager component

2024-06-14 Thread Omer Shpigelman
Add a common memory manager which handles allocation and mapping. It manages physical/virtual memory on host/device. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey Agranovich Co-developed-by

[PATCH 15/15] accel/habanalabs/gaudi2: network scaling support

2024-06-14 Thread Omer Shpigelman
Add GAUDI2 ASIC specific support for AI scaling over the network. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co-developed-by: Andrey Agranovich Signed-off-by: Andrey Agranovich Co-developed-by: Bharat Jauhari Signed-off-by: Bharat Jauhari Co

[PATCH 04/15] net: hbl_cn: QP state machine

2024-06-14 Thread Omer Shpigelman
Add a common QP state machine which handles the moving for a QP from one state to another including performing necessary checks, draining in-flight transactions, invalidating caches and error reporting. Signed-off-by: Omer Shpigelman Co-developed-by: Abhilash K V Signed-off-by: Abhilash K V Co