Re: [PATCH] drm/amdgpu: Make the submission path memory reclaim safe

2024-12-03 Thread Oleksandr Natalenko
90,9 @@ void amdgpu_gfx_off_ctrl(struct amdgpu_device *adev, bool > enable) > AMD_IP_BLOCK_TYPE_GFX, true)) > adev->gfx.gfx_off_state = true; > } else { > - > schedule_delayed_work(&adev-&

Re: [PATCH] drm/display: fix typo

2024-03-31 Thread Oleksandr Natalenko
On sobota 20. ledna 2024 7:44:45, CEST Randy Dunlap wrote: > > On 1/19/24 02:22, Oleksandr Natalenko wrote: > > While studying the code I've bumped into a small typo within the > > kernel-doc for two functions, apparently, due to copy-paste. > > > > This c

[PATCH] drm/display: fix typo

2024-01-19 Thread Oleksandr Natalenko
While studying the code I've bumped into a small typo within the kernel-doc for two functions, apparently, due to copy-paste. This commit fixes "sizo" word to be "size". Signed-off-by: Oleksandr Natalenko --- drivers/gpu/drm/display/drm_dp_dual_mode_helper.c |

Re: [PATCH] drm: Do not overrun array in drm_gem_get_pages()

2023-10-12 Thread Oleksandr Natalenko
Wilcox (Oracle) > Reported-by: Oleksandr Natalenko > Tested-by: Oleksandr Natalenko > Link: https://lore.kernel.org/lkml/13360591.ulzwgnk...@natalenko.name/ > Fixes: 3291e09a4638 ("drm: convert drm_gem_put_pages() to use a folio_batch") > Cc: sta...@vger.kernel.org # 6.5.

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-05 Thread Oleksandr Natalenko
On čtvrtek 5. října 2023 15:05:27 CEST Matthew Wilcox wrote: > On Thu, Oct 05, 2023 at 02:30:55PM +0200, Oleksandr Natalenko wrote: > > No-no, sorry for possible confusion. Let me explain again: > > > > 1. we had an issue with i915, which was introduced by 0b62af28f249, and

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-05 Thread Oleksandr Natalenko
Hello. On čtvrtek 5. října 2023 14:19:44 CEST Matthew Wilcox wrote: > On Thu, Oct 05, 2023 at 09:56:03AM +0200, Oleksandr Natalenko wrote: > > Hello. > > > > On čtvrtek 5. října 2023 9:44:42 CEST Thomas Zimmermann wrote: > > > Hi > > > > > >

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-05 Thread Oleksandr Natalenko
Hello. On čtvrtek 5. října 2023 9:44:42 CEST Thomas Zimmermann wrote: > Hi > > Am 02.10.23 um 17:38 schrieb Oleksandr Natalenko: > > On pondělí 2. října 2023 16:32:45 CEST Matthew Wilcox wrote: > >> On Mon, Oct 02, 2023 at 01:02:52PM +0200, Oleksandr Natalenko wrot

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Oleksandr Natalenko
On pondělí 2. října 2023 16:32:45 CEST Matthew Wilcox wrote: > On Mon, Oct 02, 2023 at 01:02:52PM +0200, Oleksandr Natalenko wrote: > > > > > > BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250 > > > > > > > > &

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-02 Thread Oleksandr Natalenko
/cc Matthew, Andrew (please see below) On pondělí 2. října 2023 12:42:42 CEST Bagas Sanjaya wrote: > On Mon, Oct 02, 2023 at 08:20:15AM +0200, Oleksandr Natalenko wrote: > > Hello. > > > > On pondělí 2. října 2023 1:45:44 CEST Bagas Sanjaya wrote: > > > On Sun, Oc

Re: [REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-01 Thread Oleksandr Natalenko
Hello. On pondělí 2. října 2023 1:45:44 CEST Bagas Sanjaya wrote: > On Sun, Oct 01, 2023 at 06:32:34PM +0200, Oleksandr Natalenko wrote: > > Hello. > > > > I've got a VM from a cloud provider, and since v6.5 I observe the following > > kfence splat in dmesg d

[REGRESSION] BUG: KFENCE: memory corruption in drm_gem_put_pages+0x186/0x250

2023-10-01 Thread Oleksandr Natalenko
le of times and then stops. Currently, I'm running v6.5.5. So far, there's no impact on how VM functions for me. The VGA adapter is as follows: 00:02.0 VGA compatible controller: Cirrus Logic GD 5446 Please check. Thanks. -- Oleksandr Natalenko (post-factum) signature.asc Descrip

Re: [REGRESSION] [BISECTED] Panic in gen8_ggtt_insert_entries() with v6.5

2023-09-19 Thread Oleksandr Natalenko
Hello. On úterý 19. září 2023 17:43:40 CEST Matthew Wilcox wrote: > On Tue, Sep 19, 2023 at 10:26:42AM +0200, Oleksandr Natalenko wrote: > > Andrzej asked me to try to revert commits 0b62af28f249, e0b72c14d8dc and > > 1e0877d58b1e, and reverting those fixed the i915 cr

Re: [Intel-gfx] [REGRESSION] [BISECTED] Panic in gen8_ggtt_insert_entries() with v6.5

2023-09-19 Thread Oleksandr Natalenko
Thank you. Please consider correcting the title though. Lenovo T14s (Tiger Lake) is not affected. Affected are: Lenovo T460s (Skylake) and Lenovo T490s (WhiskeyLake) -- Oleksandr Natalenko (post-factum) signature.asc Description: This is a digitally signed message part.

Re: [REGRESSION] [BISECTED] Panic in gen8_ggtt_insert_entries() with v6.5

2023-09-19 Thread Oleksandr Natalenko
/cc Bagas as well (see below). On úterý 19. září 2023 10:26:42 CEST Oleksandr Natalenko wrote: > /cc Matthew Wilcox and Andrew Morton because of folios (please see below). > > On sobota 2. září 2023 18:14:12 CEST Oleksandr Natalenko wrote: > > Hello. > > > > Since v

[REGRESSION] [BISECTED] Panic in gen8_ggtt_insert_entries() with v6.5

2023-09-19 Thread Oleksandr Natalenko
/cc Matthew Wilcox and Andrew Morton because of folios (please see below). On sobota 2. září 2023 18:14:12 CEST Oleksandr Natalenko wrote: > Hello. > > Since v6.5 kernel the following HW: > > * Lenovo T460s laptop with Skylake GT2 [HD Graphics 520] (rev 07) > * Lenovo

[REGRESSION] Panic in gen8_ggtt_insert_entries() with v6.5

2023-09-02 Thread Oleksandr Natalenko
to make the issue more visible. Please help. Thanks. [1] https://gitlab.freedesktop.org/drm/intel/-/issues/9256 -- Oleksandr Natalenko (post-factum) signature.asc Description: This is a digitally signed message part.

[PATCH] drm/virtio: Pass correct device to dma_sync_sgtable_for_device()

2023-02-24 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko The "vdev->dev.parent" should be used instead of "vdev->dev" as a device for which to perform the DMA operation in both virtio_gpu_cmd_transfer_to_host_2d(3d). Because the virtio-gpu device "vdev->dev" doesn't really have DM

Re: [PATCH] drm/xen: Add missing VM_DONTEXPAND flag in mmap callback

2022-06-19 Thread Oleksandr Andrushchenko
Hi, Oleksandr! On 09.05.22 16:51, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > With Xen PV Display driver in use the "expected" VM_DONTEXPAND flag > is not set (neither explicitly nor implicitly), so the driver hits > the code path in drm_gem_mmap_obj() w

[PATCH] drm/xen: Add missing VM_DONTEXPAND flag in mmap callback

2022-05-09 Thread Oleksandr Tyshchenko
From: Oleksandr Tyshchenko With Xen PV Display driver in use the "expected" VM_DONTEXPAND flag is not set (neither explicitly nor implicitly), so the driver hits the code path in drm_gem_mmap_obj() which triggers the WARNING. Signed-off-by: Oleksandr Tyshchenko --- This patch el

Re: [PATCH v3 00/21] xen: simplify frontend side ring setup

2022-05-09 Thread Oleksandr
that touch PV display (#07, #16), PV sound (#08, #20) and shared buffer framework used by both frontends (#10): Reviewed-by: Oleksandr Tyshchenko Also I didn't see any issues with these frontends while testing on Arm64 based board. So, you can also add: [Arm64 only] Tested-by: Olek

Re: [PATCH v2 14/19] xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring()

2022-05-02 Thread Oleksandr
end_id, - virt_to_gfn((void *)page), 0); - if (ret < 0) { - free_page(page); - goto fail; - } - - evtchnl->u.evt.page = (struct xendispl_event_page *)page; - gref = ret; + evtchnl->u.evt.page = page; handler = evtchnl_interrupt_evt; } - evtchnl->gref = gref; ret = xenbus_alloc_evtchn(xb_dev, &evtchnl->port); if (ret < 0) -- Regards, Oleksandr Tyshchenko

Re: [PATCH 59/60] drm/xen: Add support for the nomodeset kernel parameter

2021-12-14 Thread Oleksandr Andrushchenko
return -ENODEV; > + > DRM_INFO("Creating %s\n", xen_drm_driver.desc); > > drm_info = kzalloc(sizeof(*drm_info), GFP_KERNEL); With the commit message fixed: Reviewed-by: Oleksandr Andrushchenko Thank you, Oleksandr

Re: [PATCH] drm/xen: fix potential memleak in error branch

2021-11-15 Thread Oleksandr Andrushchenko
if (ret < 0) > + if (ret < 0) { > + gem_free_pages_array(xen_obj); > return ERR_PTR(ret); > + } > > DRM_DEBUG("Imported buffer of size %zu with nents %u\n", > size, sgt->orig_nents); Thank you, Oleksandr

Re: [PATCH 2/3] drm/xen: Implement mmap as GEM object function

2021-11-08 Thread Oleksandr Andrushchenko
created by the helper macro > DEFINE_DRM_GEM_FOPS(). > > Signed-off-by: Thomas Zimmermann Reviewed-by: Oleksandr Andrushchenko > --- > drivers/gpu/drm/xen/xen_drm_front.c | 16 +--- > drivers/gpu/drm/xen/xen_drm_front_gem.c | 108 +--- > drivers/g

Re: [PATCH 2/5] xen: flag xen_drm_front to be not essential for system boot

2021-10-22 Thread Oleksandr Andrushchenko
Hi, Juergen! On 22.10.21 09:47, Juergen Gross wrote: > Similar to the virtual frame buffer (vfb) the pv display driver is not > essential for booting the system. Set the respective flag. > > Signed-off-by: Juergen Gross Reviewed-by: Oleksandr Andrushchenko > --- > d

Re: [PATCH 11/11] drm/tiny: drm_gem_simple_display_pipe_prepare_fb is the default

2021-05-21 Thread Oleksandr Andrushchenko
On 5/21/21 12:09 PM, Daniel Vetter wrote: > Goes through all the drivers and deletes the default hook since it's > the default now. > > Signed-off-by: Daniel Vetter Acked-by: Oleksandr Andrushchenko

Re: thinkpad x1 carbon display flickering after update to 5.12. good on 5.11.x (i915)

2021-05-14 Thread Oleksandr Natalenko
ice > himbeere@rather ~ $ > > Downgrading to 5.11 solves the issue for me. Any ideas? Does [1] fix your issue? [1] https://cgit.freedesktop.org/drm-tip/patch/?id=acca7762eb71bc05a8f28d29320d193150051f79 -- Oleksandr Natalenko (post-factum)

Re: WARNING: AMDGPU DRM warning in 5.11.9

2021-03-25 Thread Oleksandr Natalenko
3977] drm_ioctl+0x222/0x3c0 [drm] [ 3676.034071] amdgpu_drm_ioctl+0x49/0x80 [amdgpu] [ 3676.034145] __x64_sys_ioctl+0x83/0xb0 [ 3676.034149] do_syscall_64+0x33/0x40 … [ 3676.034171] ---[ end trace 66e9865b027112f3 ]--- ``` Thanks. -- Oleksandr Natalenko (post-factum) ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

2021-03-25 Thread Oleksandr Andrushchenko
Hi, Daniel! On 3/25/21 11:16 AM, Daniel Vetter wrote: > On Thu, Mar 25, 2021 at 7:53 AM Oleksandr Andrushchenko > wrote: >> Hi, >> >> On 3/25/21 8:19 AM, Wan Jiabing wrote: >>> struct xen_drm_front_drm_info has been declared. >>> Remove the duplicate. &g

Re: [PATCH] gpu/xen: Fix a use after free in xen_drm_drv_init

2021-03-25 Thread Oleksandr Andrushchenko
iled and still free the drm_info. > Second sets front_info->drm_info to NULL to avoid uaf. > > Signed-off-by: Lv Yunlong Thank you for the patch, Reviewed-by: Oleksandr Andrushchenko Will apply to drm-misc-next-fixes Thank you, Oleksandr > --- > drivers/gpu/drm/xen/xen_d

Re: [PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

2021-03-25 Thread Oleksandr Andrushchenko
Hi, On 3/25/21 8:19 AM, Wan Jiabing wrote: > struct xen_drm_front_drm_info has been declared. > Remove the duplicate. > > Signed-off-by: Wan Jiabing Thank you for the patch, Reviewed-by: Oleksandr Andrushchenko Will apply to drm-misc-next-fixes Thank you, Oleksandr > ---

Re: [PATCH] drm/xen: adjust Kconfig

2021-03-01 Thread Oleksandr Andrushchenko
On 2/24/21 6:17 PM, Daniel Vetter wrote: > On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko > wrote: >> Hello, Jan! >> >> On 2/23/21 6:41 PM, Jan Beulich wrote: >>> By having selected DRM_XEN, I was assuming I would build the frontend >>> driv

Re: [PATCH] drm/xen: adjust Kconfig

2021-02-24 Thread Oleksandr Andrushchenko
"depends on" to the other, real option, and "select"ing > the dummy one. > > Signed-off-by: Jan Beulich Reviewed-by: Oleksandr Andrushchenko > --- a/drivers/gpu/drm/xen/Kconfig > +++ b/drivers/gpu/drm/xen/Kconfig > @@ -1,15 +1,11 @@ > # SPDX-License-Ide

[PATCH] drm/xen-front: Add support for EDID based configuration

2020-08-26 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Version 2 of the Xen displif protocol adds XENDISPL_OP_GET_EDID request which allows frontends to request EDID structure per connector. This request is optional and if not supported by the backend then visible area is still defined by the relevant XenStore&#

Re: [PATCH v2 2/5] drm/xen-front: Fix misused IS_ERR_OR_NULL checks

2020-08-21 Thread Oleksandr Andrushchenko
t; NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? > This is because of commit 4c1cb04e0e7ac4ba1ef5457929ef9b5671d9eed3 was not CCed to stable. So, if we want the patch to be applied to older stable kernels we also need this patch as well. Thank y

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-17 Thread Oleksandr Andrushchenko
On 8/13/20 10:05 AM, Jürgen Groß wrote: > On 13.08.20 08:32, Oleksandr Andrushchenko wrote: >> Juergen, Boris, >> >> can we please merge these via Xen Linux tree as I have collected enough >> Ack/R-b? >> >> The series has DRM patches, but those anyway

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-17 Thread Oleksandr Andrushchenko
On 8/13/20 6:02 PM, Jürgen Groß wrote: > On 13.08.20 08:21, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko > > Series pushed to: > > xen/tip.git for-linus-5.9 > The top patch has strange title though: "Subject: [PATCH v2 5/5] drm/xen-front: Pass d

Re: [PATCH 18/20] drm/xen: Introduce GEM object functions

2020-08-17 Thread Oleksandr Andrushchenko
_free_object_unlocked or any other name if this seems to be too long, but starting with xen_drm_front_ as the rest of exported functions? With this, Acked-by: Oleksandr Andrushchenko Thank you, Oleksandr > { > struct xen_drm_front_drm_info *drm_info = obj->dev->dev_priv

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-17 Thread Oleksandr Andrushchenko
On 8/13/20 6:13 PM, Jürgen Groß wrote: > On 13.08.20 17:10, Oleksandr Andrushchenko wrote: >> >> On 8/13/20 6:02 PM, Jürgen Groß wrote: >>> On 13.08.20 08:21, Oleksandr Andrushchenko wrote: >>>> From: Oleksandr Andrushchenko >>> >>> Series p

Re: [PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-13 Thread Oleksandr Andrushchenko
Juergen, Boris, can we please merge these via Xen Linux tree as I have collected enough Ack/R-b? The series has DRM patches, but those anyway are Xen related, so I think this should be fine from DRI point of view. Thank you, Oleksandr On 8/13/20 9:21 AM, Oleksandr Andrushchenko wrote: > F

[PATCH v2 4/5] xen: Sync up with the canonical protocol definition in Xen

2020-08-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the sync up with the canonical definition of the display protocol in Xen. 1. Add protocol version as an integer Version string, which is in fact an integer, is hard to handle in the code that supports different protocol versions. To simplify that also add

[PATCH v2 3/5] drm/xen-front: Add YUYV to supported formats

2020-08-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Add YUYV to supported formats, so the frontend can work with the formats used by cameras and other HW. Signed-off-by: Oleksandr Andrushchenko Acked-by: Noralf Trønnes --- drivers/gpu/drm/xen/xen_drm_front_conn.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 5/5] drm/xen-front: Pass dumb buffer data offset to the backend

2020-08-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko While importing a dmabuf it is possible that the data of the buffer is put with offset which is indicated by the SGT offset. Respect the offset value and forward it to the backend. Signed-off-by: Oleksandr Andrushchenko Acked-by: Noralf Trønnes --- drivers/gpu

[PATCH v2 1/5] xen/gntdev: Fix dmabuf import with non-zero sgt offset

2020-08-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko It is possible that the scatter-gather table during dmabuf import has non-zero offset of the data, but user-space doesn't expect that. Fix this by failing the import, so user-space doesn't access wrong data. Fixes: bf8dc55b1358 ("xen/gntdev: Im

[PATCH v2 0/5] Fixes and improvements for Xen pvdrm

2020-08-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hello, This series contains an assorted set of fixes and improvements for the Xen para-virtualized display driver and grant device driver which I have collected over the last couple of months: 1. Minor fixes to grant device driver and drm/xen-front. 2. New format

[PATCH v2 2/5] drm/xen-front: Fix misused IS_ERR_OR_NULL checks

2020-08-12 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the following static checker warning: drivers/gpu/drm/xen/xen_drm_front_gem.c:140 xen_drm_front_gem_create() warn: passing zero to

Re: [PATCH 1/6] xen/gntdev: Fix dmabuf import with non-zero sgt offset

2020-08-05 Thread Oleksandr Andrushchenko
On 8/4/20 9:11 AM, Jürgen Groß wrote: > On 31.07.20 14:51, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> It is possible that the scatter-gather table during dmabuf import has >> non-zero offset of the data, but user-space doesn't expect

Re: [PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks

2020-08-04 Thread Oleksandr Andrushchenko
On 8/4/20 9:12 AM, Jürgen Groß wrote: > On 31.07.20 14:51, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV >> display frontend" from Apr 3, 2018, leads to th

[PATCH 0/6] Fixes and improvements for Xen pvdrm

2020-07-31 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hello, This series contains an assorted set of fixes and improvements for the Xen para-virtualized display driver and grant device driver which I have collected over the last couple of months: 1. Minor fixes to grant device driver and drm/xen-front. 2. New format

[PATCH 6/6] drm/xen-front: Add support for EDID based configuration

2020-07-31 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Version 2 of the Xen displif protocol adds XENDISPL_OP_GET_EDID request which allows frontends to request EDID structure per connector. This request is optional and if not supported by the backend then visible area is still defined by the relevant XenStore&#

[PATCH 2/6] drm/xen-front: Fix misused IS_ERR_OR_NULL checks

2020-07-31 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko The patch c575b7eeb89f: "drm/xen-front: Add support for Xen PV display frontend" from Apr 3, 2018, leads to the following static checker warning: drivers/gpu/drm/xen/xen_drm_front_gem.c:140 xen_drm_front_gem_create() warn: passing zero to

[PATCH 3/6] drm/xen-front: Add YUYV to supported formats

2020-07-31 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Add YUYV to supported formats, so the frontend can work with the formats used by cameras and other HW. Signed-off-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_conn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xen

[PATCH 4/6] xen: Sync up with the canonical protocol definition in Xen

2020-07-31 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the sync up with the canonical definition of the display protocol in Xen. 1. Add protocol version as an integer Version string, which is in fact an integer, is hard to handle in the code that supports different protocol versions. To simplify that also add

[PATCH 5/6] drm/xen-front: Pass dumb buffer data offset to the backend

2020-07-31 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko While importing a dmabuf it is possible that the data of the buffer is put with offset which is indicated by the SGT offset. Respect the offset value and forward it to the backend. Signed-off-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front.c

[PATCH 1/6] xen/gntdev: Fix dmabuf import with non-zero sgt offset

2020-07-31 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko It is possible that the scatter-gather table during dmabuf import has non-zero offset of the data, but user-space doesn't expect that. Fix this by failing the import, so user-space doesn't access wrong data. Fixes: 37ccb44d0b00 ("xen/gntdev: Im

Re: [PATCH v2 37/38] drm/xen: remove _unlocked suffix in drm_object_put_unlocked

2020-05-16 Thread Oleksandr Andrushchenko
fix. It makes the API cleaner. > > Done via the following script: > > __from=drm_gem_object_put_unlocked > __to=drm_gem_object_put > for __file in $(git grep --name-only $__from); do >sed -i "s/$__from/$__to/g" $__file; > done > > Cc: Oleksandr Andrushche

Re: [bug report] drm/xen-front: Add support for Xen PV display frontend

2020-05-08 Thread Oleksandr Andrushchenko
R_NULL to just IS_ERR I am planning a series of patches later on, so I'll include this fix as well > > Normally Smatch is smart enough to know that the pointer isn't NULL so > it doesn't generate a warning but yesterday I introduced a bug in Smatch &g

Re: [bug report] drm/xen-front: Add support for Xen PV display frontend

2020-04-22 Thread Oleksandr Andrushchenko
On 4/21/20 14:51, Dan Carpenter wrote: > It turns out there aren't that many of these in xen. > > $ grep IS_ERR_OR_NULL drivers/gpu/drm/xen/ -Rn > drivers/gpu/drm/xen/xen_drm_front_kms.c:63: if (IS_ERR_OR_NULL(fb)) > drivers/gpu/drm/xen/xen_drm_front_gem.c:86: if (IS_ERR_OR_NULL(xen_obj)) >

Re: [bug report] drm/xen-front: Add support for Xen PV display frontend

2020-04-22 Thread Oleksandr Andrushchenko
reate() sometimes returns NULL or error pointers > but that's because of a bug in the unreleased version of Smatch and > because gem_create() uses IS_ERR_OR_NULL(). > > 141 > 142 return &xen_obj->base; > 143 } > > regards, > dan carpenter

Re: [Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning

2020-03-31 Thread Oleksandr Andrushchenko
On 3/30/20 12:59, Ding Xiang wrote: Fix a static code checker warning: drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create() warn: passing zero to 'PTR_ERR' Signed-off-by: Ding Xiang Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_f

[RFC PATCH 5/7] pwm: replace polarity enum with macros

2020-03-17 Thread Oleksandr Suvorov
To avoid duplication of pwm polarity definitions, remove "enum pwm_polarity" and use macros instead. Prepare to use both polarity flags in DTs. Signed-off-by: Oleksandr Suvorov --- drivers/pwm/core.c | 2 +- drivers/pwm/pwm-atmel-tcb.c | 8 drive

[RFC PATCH 0/7] Rework PWM_POLARITY_* flags

2020-03-17 Thread Oleksandr Suvorov
PWM_POLARITY_* flags were defined in include/linux/pwm.h as a enum and in include/dt-bindings/pwm/pwm.h as macros. This patchset fixes duplication and introduces using PWM_POLARITY_NORMAL flag instead of '0' constant in DT files. Oleksandr Suvorov (7): pwm: rename the PWM_POLARIT

Re: [PATCH 04/52] drm: Set final_kfree in drm_dev_alloc

2020-02-19 Thread Oleksandr Andrushchenko
patch here fixes that leak. > > Same for virtio, started leaking with > > commit b1df3a2b24a917f8853d43fe9683c0e360d2c33a > Author: Gerd Hoffmann > Date: Tue Feb 11 14:58:04 2020 +0100 > > drm/virtio: add drm_driver.release callback. > > Cc: Gerd Hoffmann >

Re: [RFC PATCH v3 5/5] drm/panel: simple: add panel-dpi support

2020-02-18 Thread Oleksandr Suvorov
ex.com/ It works for me, thanks! Reviewed-by: Oleksandr Suvorov > > The panel-dpi compatible is a fallback that > allows the DT to specify the timing. > > When matching panel-dpi expect the device tree to include the > timing information for the display-panel. > > Background

Re: [PATCH v5 15/15] drm/xen: Explicitly disable automatic sending of vblank event

2020-01-29 Thread Oleksandr Andrushchenko
blank events explicitly. > > v5: > * update comment > v4: > * separate commit from core vblank changes > > Signed-off-by: Thomas Zimmermann > Acked-by: Gerd Hoffmann > Reviewed-by: Daniel Vetter Thank you for your work, Reviewed-by: Oleksandr Andrushchenko > --- &

Re: [PATCH v4 15/15] drm/xen: Explicitly disable automatic sending of vblank event

2020-01-28 Thread Oleksandr Andrushchenko
On 1/27/20 1:59 PM, Thomas Zimmermann wrote: > Hi > > Am 27.01.20 um 10:53 schrieb Oleksandr Andrushchenko: >> Sorry for jumping in late >> >> On 1/23/20 11:21 AM, Thomas Zimmermann wrote: >>> The atomic helpers automatically send out fake VBLANK events if n

Re: [PATCH v4 15/15] drm/xen: Explicitly disable automatic sending of vblank event

2020-01-28 Thread Oleksandr Andrushchenko
> disable automatic vblank events explictly. > > v4: > * separate commit from core vblank changes > > Signed-off-by: Thomas Zimmermann > Acked-by: Gerd Hoffmann Reviewed-by: Oleksandr Andrushchenko > --- > drivers/gpu/drm/xen/xen_drm_front_kms.c | 13 +++

Re: [PATCH v4 2/3] dt-bindings: panel-simple: add bindings for logic technologies displays

2020-01-24 Thread Oleksandr Suvorov
ouch-display-1280x800-datasheet.pdf > [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30 > > Signed-off-by: Marcel Ziswiler Reviewed-by: Oleksandr Suvorov > > --- > > Changes in v4: > - Re-ordered commits as suggested by Sam and re-worded commit messag

Re: [PATCH v4 3/3] drm/panel: simple: add display timings for logic technologies displays

2020-01-24 Thread Oleksandr Suvorov
vds-capacitive-touch-display-1280x800-datasheet.pdf > [4] https://www.endrich.com/isi50_isi30_tft-displays/lt170410-1whc_isi30 > > Signed-off-by: Marcel Ziswiler > Reviewed-by: Philippe Schenker Reviewed-by: Oleksandr Suvorov > > --- > > Changes in v4: > - Added recently made m

Re: [PATCH v1 1/3] dt-bindings: display: add panel-timing.yaml

2020-01-21 Thread Oleksandr Suvorov
cal panel resolution in pixels -^^^^^^ Vertical Anyway, those are minor issues, so Reviewed-by: Oleksandr Suvorov > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo

Re: [PATCH 1/3] drm/panel: make LVDS panel driver DPI capable

2020-01-20 Thread Oleksandr Suvorov
rm driver name; - fork panel-lvds driver as panel-generic driver with dpi support. What solution do you prefer? > > .of_match_table = panel_lvds_of_table, > > }, > > }; > > Sam -- Best regards Oleksandr Suvorov Toradex AG

[PATCH 0/3] Generic DPI panel on Colibri iMX7 / Col.Eval.board

2020-01-16 Thread Oleksandr Suvorov
Make LVDS panel driver DPI capable and use it to add generic RGB (DPI) panel support for Colibri iMX7 SoM on Colibri Evaluation Board. Oleksandr Suvorov (1): ARM: dts: imx7-colibri: add generic RGB (DPI) panel Stefan Agner (2): drm/panel: make LVDS panel driver DPI capable drm/panel

[PATCH 2/3] drm/panel: pass video modes bus_flags

2020-01-16 Thread Oleksandr Suvorov
From: Stefan Agner Make sure that the bus_flags parsed from the display timings are passed to the connector display info. Signed-off-by: Stefan Agner Signed-off-by: Oleksandr Suvorov --- drivers/gpu/drm/panel/panel-lvds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 1/3] drm/panel: make LVDS panel driver DPI capable

2020-01-16 Thread Oleksandr Suvorov
From: Stefan Agner The LVDS panel driver has almost everything which is required to describe a simple parallel RGB panel (also known as DPI, Display Pixel Interface). Signed-off-by: Stefan Agner Signed-off-by: Oleksandr Suvorov --- drivers/gpu/drm/panel/panel-lvds.c | 40

Re: [Xen-devel] [PATCH 13/15] xen/gntdev-dmabuf: Ditch dummy map functions

2019-11-18 Thread Oleksandr Andrushchenko
On 11/18/19 12:35 PM, Daniel Vetter wrote: There's no in-kernel users for the k(un)map stuff. And the mmap one is actively harmful - return 0 and then _not_ actually mmaping can't end well. Signed-off-by: Daniel Vetter Reviewed-by: Oleksandr Andrushchenko Cc: Boris Ostrovsky C

Re: [PATCH 6/8] drm/xen: Simplify fb_create

2019-11-17 Thread Oleksandr Andrushchenko
s a full reference for us. > > Might as well take the real pointer ins't of complicated games that > baffle. > > Signed-off-by: Daniel Vetter > Cc: Oleksandr Andrushchenko > Cc: xen-de...@lists.xenproject.org Reviewed-by: Oleksandr Andrushchenko > --- > drivers/gpu/drm

Re: [Xen-devel] [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-10-27 Thread Oleksandr Andrushchenko
On 10/21/19 10:12 PM, Jason Gunthorpe wrote: On Wed, Oct 16, 2019 at 06:35:15AM +, Oleksandr Andrushchenko wrote: On 10/16/19 8:11 AM, Jürgen Groß wrote: On 15.10.19 20:12, Jason Gunthorpe wrote: From: Jason Gunthorpe DMA_SHARED_BUFFER can not be enabled by the user (it represents a

Re: [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-10-16 Thread Oleksandr Andrushchenko
>> symbols so they are turned on implicitly when the user enables a kconfig >> that needs them. >> >> Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable. >> >> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UA

Re: [Xen-devel] [PATCH] drm/xen-front: Make structure fb_funcs constant

2019-08-18 Thread Oleksandr Andrushchenko
On 8/14/19 8:26 PM, Daniel Vetter wrote: On Tue, Aug 13, 2019 at 10:32:00AM +0300, Oleksandr Andrushchenko wrote: On 8/13/19 9:27 AM, Nishka Dasgupta wrote: Static structure fb_funcs, of type drm_framebuffer_funcs, is used only when it is passed to drm_gem_fb_create_with_funcs() as its last

Re: [Xen-devel] [PATCH] drm/xen-front: Make structure fb_funcs constant

2019-08-13 Thread Oleksandr Andrushchenko
modified. Therefore make fb_funcs constant to protect it from further modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH 0/1] This patch fixes connection detection for monitors w/o DDC.

2019-07-29 Thread Oleksandr Suvorov
On Thu, Jul 25, 2019 at 5:41 PM maxime.rip...@free-electrons.com wrote: > > On Thu, Jul 25, 2019 at 11:05:23AM +, Oleksandr Suvorov wrote: > > > > Even in source code of this driver there is an author's description: > > /* > > * Even if we have a

[PATCH 0/1] This patch fixes connection detection for monitors w/o DDC.

2019-07-25 Thread Oleksandr Suvorov
f/drm/card0/card0-VGA-1/status unknown === Oleksandr Suvorov (1): drm/bridge: vga-dac: Fix detect of monitor connection drivers/gpu/drm/bridge/dumb-vga-dac.c | 18 -- 1 file changed, 18 deletions(-) -- 2.20.1

[PATCH 1/1] drm/bridge: vga-dac: Fix detect of monitor connection

2019-07-25 Thread Oleksandr Suvorov
of dumb monitor detection like: ... DRM: head 'VGA-1' found, connector 32 is disconnected. ... Cc: sta...@vger.kernel.org Fixes: 56fe8b6f4991 ("drm/bridge: Add RGB to VGA bridge support") Signed-off-by: Oleksandr Suvorov --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 18 --

Re: [PATCH v1 02/33] drm/xen: drop use of drmP.h

2019-06-30 Thread Oleksandr Andrushchenko
On 6/30/19 9:18 AM, Sam Ravnborg wrote: The drmP.h header is deprecated. Drop all uses. Added includes/forwards to the header files and then fixed fallout in the .c files. Signed-off-by: Sam Ravnborg Cc: Oleksandr Andrushchenko Cc: xen-de...@lists.xenproject.org --- The list of cc: was too

Re: [Xen-devel] [PATCH 38/59] drm/xen: Drop drm_gem_prime_export/import

2019-06-17 Thread Oleksandr Andrushchenko
On 6/14/19 11:35 PM, Daniel Vetter wrote: They're the default. Aside: Would be really nice to switch the others over to drm_gem_object_funcs. Signed-off-by: Daniel Vetter Cc: Oleksandr Andrushchenko Cc: xen-de...@lists.xenproject.org Reviewed-by: Oleksandr Andrushchenko --- driver

Re: [PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-05-07 Thread Oleksandr Andrushchenko
the if ladder and first check if the buffer is imported. Fixes: b9068cde51ee ("drm/cma-helper: Add DRM_GEM_CMA_VMAP_DRIVER_OPS") Cc: sta...@vger.kernel.org Reported-by: "Li, Tingqian" Signed-off-by: Noralf Trønnes Reviewed-by: Oleksandr Andrushchenko --

Re: [PATCH] xen, fbfront: mark expected switch fall-through

2019-02-28 Thread Oleksandr Andrushchenko
+Xen-devel list On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’: drivers/v

Re: [PATCH v2 2/2] drm/drv: drm_dev_unplug(): Move out drm_dev_put() call

2019-02-08 Thread Oleksandr Andrushchenko
On 2/8/19 4:01 PM, Noralf Trønnes wrote: This makes it possible to use drm_dev_unplug() with the upcoming devm_drm_dev_init() which will do drm_dev_put() in its release callback. Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: Dave Airlie Cc: Sean Paul Cc: Oleksandr

Re: [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-05 Thread Oleksandr Andrushchenko
On 2/3/19 5:41 PM, Noralf Trønnes wrote: > The only thing now that makes drm_dev_unplug() special is that it sets > drm_device->unplugged. Move this code to drm_dev_unregister() so that we > can remove drm_dev_unplug(). > > Signed-off-by: Noralf Trønnes Reviewed-by: Oleks

Re: [PATCH 1/6] drm: Fix drm_release() and device unplug

2019-02-05 Thread Oleksandr Andrushchenko
s there's open fd(s) > - The driver holds a ref on drm_device as long as it's bound to the >struct device > > When both sides are done with drm_device, it is released. > > Signed-off-by: Noralf Trønnes Reviewed-by: Oleksandr Andrushchenko > --- > dri

Re: [PATCH 6/6] drm/drv: Remove drm_dev_unplug()

2019-02-05 Thread Oleksandr Andrushchenko
On 2/3/19 5:42 PM, Noralf Trønnes wrote: > There are no users left. > > Signed-off-by: Noralf Trønnes Reviewed-by: Oleksandr Andrushchenko > --- > drivers/gpu/drm/drm_drv.c | 17 - > include/drm/drm_drv.h | 1 - > 2 files changed, 18 deletions(-) >

Re: [PATCH 5/6] drm/xen: Use drm_dev_unregister()

2019-02-05 Thread Oleksandr Andrushchenko
er the check. > > Cc: Oleksandr Andrushchenko > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/xen/xen_drm_front.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/xen/xen_drm_front.c > b/drivers/gpu/drm/xen/xen

Re: [Xen-devel] [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy()

2019-02-04 Thread Oleksandr Andrushchenko
On 1/26/19 2:05 PM, YueHaibing wrote: > There is no need to have the 'struct drm_framebuffer *fb' variable > static since new value always be assigned before use it. > > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [Xen-devel][PATCH] drm/xen-front: Fix mmap attributes for display buffers

2019-02-04 Thread Oleksandr Andrushchenko
On 1/29/19 9:07 PM, Julien Grall wrote: > Hi Oleksandr, > > On 1/29/19 3:04 PM, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> When GEM backing storage is allocated those are normal pages, >> so there is no point using pgprot_writecom

Re: [PATCH -next] drm/xen-front: Drop pointless static qualifier in fb_destroy()

2019-02-01 Thread Oleksandr Andrushchenko
On 1/28/19 8:36 AM, Oleksandr Andrushchenko wrote: > On 1/26/19 2:05 PM, YueHaibing wrote: >> There is no need to have the 'struct drm_framebuffer *fb' variable >> static since new value always be assigned before use it. >> >> Signed-off-by: YueHaibing &

Re: [Xen-devel][PATCH] drm/xen-front: Fix mmap attributes for display buffers

2019-02-01 Thread Oleksandr Andrushchenko
On 1/30/19 11:09 AM, Oleksandr Andrushchenko wrote: > On 1/29/19 9:07 PM, Julien Grall wrote: >> Hi Oleksandr, >> >> On 1/29/19 3:04 PM, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> When GEM backing storage is allocated

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

2019-01-30 Thread Oleksandr Andrushchenko
Dropped in favor of https://lkml.org/lkml/2019/1/29/910 On 1/24/19 5:02 PM, Julien Grall wrote: > > > On 24/01/2019 14:34, Oleksandr Andrushchenko wrote: >> Hello, Julien! > > Hi, > >> On 1/22/19 1:44 PM, Julien Grall wrote: >>> >>> >&g

Re: [Xen-devel][PATCH] drm/xen-front: Fix mmap attributes for display buffers

2019-01-30 Thread Oleksandr Andrushchenko
On 1/29/19 9:07 PM, Julien Grall wrote: > Hi Oleksandr, > > On 1/29/19 3:04 PM, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> When GEM backing storage is allocated those are normal pages, >> so there is no point using pgprot_writecom

Re: [Xen-devel] [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent

2019-01-30 Thread Oleksandr Andrushchenko
On 1/24/19 5:02 PM, Julien Grall wrote: > > > On 24/01/2019 14:34, Oleksandr Andrushchenko wrote: >> Hello, Julien! > > Hi, > >> On 1/22/19 1:44 PM, Julien Grall wrote: >>> >>> >>> On 1/22/19 10:28 AM, Oleksandr Andrushchenko wrote: &g

[Xen-devel][PATCH] drm/xen-front: Fix mmap attributes for display buffers

2019-01-29 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko When GEM backing storage is allocated those are normal pages, so there is no point using pgprot_writecombine while mmaping. This fixes mismatch of buffer pages' memory attributes between the frontend and backend which may cause screen artifacts. Fixes: c575b7e

  1   2   3   4   5   6   >