Re: [PATCH] drm/debugfs: fix potential NULL pointer dereference

2023-12-06 Thread Nishanth Menon
> 3b/4b boards. > > > > Fixes: caf525ed45b4 ("drm/encoder: register per-encoder debugfs dir") > > Signed-off-by: Marek Szyprowski > > Reviewed-by: Dmitry Baryshkov Tested-by: Nishanth Menon Fixed multiple platform boot fails on TI K3 SoC family incl

Re: [PATCH] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2023-12-01 Thread Nishanth Menon
ithout Texas Instruments K3 Multicore SoC support. > > Fixes: 4babef0708656c54 ("drm/imagination: Add skeleton PowerVR driver") Minor nitpick here - 12 char sha.. otherwise: Reviewed-by: Nishanth Menon > Signed-off-by: Geert Uytterhoeven > --- > drivers/gpu/drm/imaginati

Re: [PATCH v2] drm: bridge: it66121: Fix invalid connector dereference

2023-09-01 Thread Nishanth Menon
nformation to > > the sound framework if there is no connector attached. > > > > Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support") > > Reported-by: Nishanth Menon > > Closes: https://lore.kernel.org/all/20230825105849.crhon42qndxqif4i@gondola/ > &g

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

2023-08-31 Thread Nishanth Menon
as EDID information cannot be provided to > > the sound framework if there is no connector attached. > > > > Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support") > > Reported-by: Nishanth Menon > > Closes: https://lore.kernel.org/all/20230825105849.crh

Re: [3/3] drm: bridge: it66121: Add audio support

2023-08-25 Thread Nishanth Menon
but I see this when HDMI is not connected on BeaglePlay https://gist.github.com/nmenon/f3d4a34ec9b9d188fbefb65f94090bcb Cc Jai Luthra -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[PATCH] drm/bridge: cdns-dsi: Make sure to to create proper aliases for dt

2021-09-21 Thread Nishanth Menon
Add MODULE_DEVICE_TABLE to the device tree table to create required aliases needed for module to be loaded with device tree based platform. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Nishanth Menon --- drivers/gpu/drm/bridge/cdns-dsi.c | 1 + 1 file

Re: [PATCH] drm: bridge: cdns: Kconfig: Switch over dependency to ARCH_K3

2020-11-13 Thread Nishanth Menon
On 11:06-20201108, Sam Ravnborg wrote: > Hi Nishanth > > On Mon, Oct 26, 2020 at 11:54:41AM -0500, Nishanth Menon wrote: > > With the integration of chip-id detection scheme in kernel[1], there > > is no specific need to maintain multitudes of SoC specific config > > o

[PATCH] drm: bridge: cdns: Kconfig: Switch over dependency to ARCH_K3

2020-10-26 Thread Nishanth Menon
: Tomi Valkeinen Cc: Laurent Pinchart Cc: Yuti Amonkar Cc: Jyri Sarha Signed-off-by: Nishanth Menon --- drivers/gpu/drm/bridge/cadence/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cadence/Kconfig b/drivers/gpu/drm/bridge/cadence/Kconfi

[PATCH 1/3] ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node

2016-09-19 Thread Nishanth Menon
eneral/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360 > Thanks for the detailed explanation. http://www.spinics.net/lists/devicetree/msg141248.html helped explain the same. -- Regards, Nishanth Menon

[PATCH 1/3] ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node

2016-09-16 Thread Nishanth Menon
cut the blue or red wire to diffuse the bomb" ;) "The am335x-evm has blue and red wires crossed to get 24-bit RGB (and 16-bit BGR". I mean, there has to be some sort of better description specific to lcdc if some product used yellow and green wires for the same signals crossed? -- Regards, Nishanth Menon

[PATCH v3 1/5] clk: ti: add "ti, gpio-gate-clock" controlled clock

2014-09-19 Thread Nishanth Menon
> Why is this a TI clock? Sounds like a generic one to me. Like thread: https://lkml.org/lkml/2014/9/5/284 ? > > In any case, this should go through Mike. > yep - should have been posted independent of this series :). -- Regards, Nishanth Menon

Re: [RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.

2013-04-16 Thread Nishanth Menon
onale behind why #include #include would want __linux__ and why __KERNEL__ check is un-wanted. Ofcourse, I cant comment about the "One of the BSDs" in else options.. and why we'd like to keep it around in kernel :) -- Regards, Nishanth Menon ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.

2013-04-16 Thread Nishanth Menon
onale behind why #include #include would want __linux__ and why __KERNEL__ check is un-wanted. Ofcourse, I cant comment about the "One of the BSDs" in else options.. and why we'd like to keep it around in kernel :) -- Regards, Nishanth Menon

[RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.

2013-04-14 Thread Nishanth Menon
o-dev/2011-June/thread.html#4874 Seems to me as a valid fix even for upstream perhaps? Regards, Nishanth Menon include/uapi/drm/drm.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 8d1e2bb..73a99e4 100644 --- a/includ

[RFC PATCH] drm.h: Fix DRM compilation with bare-metal toolchain.

2013-04-12 Thread Nishanth Menon
linaro-dev/2011-June/thread.html#4874 Seems to me as a valid fix even for upstream perhaps? Regards, Nishanth Menon include/uapi/drm/drm.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 8d1e2bb..73a99e4 100644 --- a/includ

Re: [PATCH V2] drm/edid: kernel-doc minimal cleanup

2013-03-06 Thread Nishanth Menon
On 10:27-20130304, Nishanth Menon wrote: > On 18:09-20130302, Paul Menzel wrote: > > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > > Some basic cleanups for kernel-doc errors or missing documentation > > > parameters. [..] > > > index

[PATCH V2] drm/edid: kernel-doc minimal cleanup

2013-03-06 Thread Nishanth Menon
On 10:27-20130304, Nishanth Menon wrote: > On 18:09-20130302, Paul Menzel wrote: > > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > > Some basic cleanups for kernel-doc errors or missing documentation > > > parameters. [..] > > > index

Re: [PATCH V2] drm/edid: kernel-doc minimal cleanup

2013-03-04 Thread Nishanth Menon
On 18:09-20130302, Paul Menzel wrote: > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > Some basic cleanups for kernel-doc errors or missing documentation > > parameters. > > Nishanth, thanks for doing that! glad to be of help. > > > index c19

[PATCH V2] drm/edid: kernel-doc minimal cleanup

2013-03-04 Thread Nishanth Menon
On 18:09-20130302, Paul Menzel wrote: > Am Freitag, den 01.03.2013, 08:00 -0600 schrieb Nishanth Menon: > > Some basic cleanups for kernel-doc errors or missing documentation > > parameters. > > Nishanth, thanks for doing that! glad to be of help. > > > index c19

[PATCH V2] drm/edid: kernel-doc minimal cleanup

2013-03-01 Thread Nishanth Menon
: No description found for parameter 'edid' Cc: David Airlie Cc: Dave Airlie Cc: Adam Jackson Cc: Rodrigo Vivi Cc: Ville Syrjälä Cc: dri-devel@lists.freedesktop.org Signed-off-by: Nishanth Menon --- V2: review comments incorporated V1: http://marc.info/?t=13621411595&r=1&

Re: [PATCH] drm/edid: kernel-doc minimal cleanup

2013-03-01 Thread Nishanth Menon
On 14:43-20130301, Ville Syrjälä wrote: > On Thu, Feb 28, 2013 at 05:13:09PM -0600, Nishanth Menon wrote: [..] > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > > > #define DDC_SEGMENT_ADDR 0x30 > > /** > > - * Get EDID information via I2C. >

[PATCH V2] drm/edid: kernel-doc minimal cleanup

2013-03-01 Thread Nishanth Menon
: No description found for parameter 'edid' Cc: David Airlie Cc: Dave Airlie Cc: Adam Jackson Cc: Rodrigo Vivi Cc: Ville Syrj?l? Cc: dri-devel at lists.freedesktop.org Signed-off-by: Nishanth Menon --- V2: review comments incorporated V1: http://marc.info/?t=13621411595&

[PATCH] drm/edid: kernel-doc minimal cleanup

2013-03-01 Thread Nishanth Menon
On 14:43-20130301, Ville Syrj?l? wrote: > On Thu, Feb 28, 2013 at 05:13:09PM -0600, Nishanth Menon wrote: [..] > > @@ -982,14 +982,14 @@ EXPORT_SYMBOL(drm_edid_is_valid); > > > > #define DDC_SEGMENT_ADDR 0x30 > > /** > > - * Get EDID information via I2C. >

[PATCH] drm/edid: kernel-doc minimal cleanup

2013-03-01 Thread Nishanth Menon
_edid.c:2658): No description found for parameter 'edid' Cc: David Airlie Cc: Dave Airlie Cc: Adam Jackson Cc: Rodrigo Vivi Cc: dri-devel@lists.freedesktop.org Signed-off-by: Nishanth Menon --- It does seem the drm_edid.c could do with some amount of documentation cleanup, but I have stayed with th

[PATCH] drm/edid: kernel-doc minimal cleanup

2013-02-28 Thread Nishanth Menon
id.c:2658): No description found for parameter 'edid' Cc: David Airlie Cc: Dave Airlie Cc: Adam Jackson Cc: Rodrigo Vivi Cc: dri-devel at lists.freedesktop.org Signed-off-by: Nishanth Menon --- It does seem the drm_edid.c could do with some amount of documentation cleanup, but I have stayed wi