Christian König writes:
> Am 27.04.2017 um 18:17 schrieb Nikola Pajkovsky:
>> This is super simple elimination of else branch and I should
>> probably even use unlikely in
>>
>> if (ring->count_dw < count_dw) {
>>
>> However, amdgpu_ring_w
else branch is pointless if it's right at the end of function and use
unlikely() on err path.
Signed-off-by: Nikola Pajkovsky
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 45 +++--
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/dr
This is super simple elimination of else branch and I should
probably even use unlikely in
if (ring->count_dw < count_dw) {
However, amdgpu_ring_write() has similar if condition, but does not
return after DRM_ERROR and it looks suspicious. On error, we still
adding v to ring and keeping c
Daniel Vetter writes:
> On Tue, Dec 11, 2012 at 1:31 PM, Nikola Pajkovsky
> wrote:
>> looks like we still have some oops in i915. i915 maintainers do you have
>> any ideas what's going on? I will try to trigger that oops later today
>> and provide more informati
Hey folks,
looks like we still have some oops in i915. i915 maintainers do you have
any ideas what's going on? I will try to trigger that oops later today
and provide more information.
[10733.442608] WARNING: at drivers/gpu/drm/i915/i915_gem.c:3437
i915_gem_object_pin+0x151/0x1a0()
[10733.442612
Daniel Vetter writes:
> On Tue, Dec 11, 2012 at 1:31 PM, Nikola Pajkovsky wrote:
>> looks like we still have some oops in i915. i915 maintainers do you have
>> any ideas what's going on? I will try to trigger that oops later today
>> and provide more information.
Hey folks,
looks like we still have some oops in i915. i915 maintainers do you have
any ideas what's going on? I will try to trigger that oops later today
and provide more information.
[10733.442608] WARNING: at drivers/gpu/drm/i915/i915_gem.c:3437
i915_gem_object_pin+0x151/0x1a0()
[10733.442612
