Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

Joe, Please drop this chunk: it's a successive controller version number which are all backward compatible with "fallthrough" on each case so removing from this last one makes it inconsistent. In sort: NACK for atmel-mci. Best regards, Nicolas On 09/09/2020 at 22:06, Joe Perches wrote: >

Re: [PATCH 1/2] drm/panel: Add and fill drm_panel type field

Hi Laurent, On 23/08/2019 at 03:40, Laurent Pinchart wrote: > Add a type field to the drm_panel structure to report the panel type, > using DRM_MODE_CONNECTOR_* macros (the values that make sense are LVDS, > eDP, DSI and DPI). This will be used to initialise the corresponding > connector type. Wi

Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic

On 09/07/2019 at 17:35, Joshua Henderson wrote: > This bit enables replication logic to expand an RGB color less than 24 > bits, to 24 bits, which is used internally for all formats. Otherwise, > the least significant bits are always set to zero and the color may not > be what is expected. > > Si

Re: [PATCH] MAINTAINERS: add Sam Ravnborg for drm/atmel_hlcdc

On 28/06/2019 at 08:12, Boris Brezillon wrote: > On Thu, 27 Jun 2019 23:16:43 +0200 > Sam Ravnborg wrote: > >> I have agreed with Boris Brezillon that we will share the >> maintainer role for the drm/atmel_hlcdc driver. >> Nicolas Ferre from Microchip has donated a few boards that >> allows me to

Re: [PATCH][next] video: fbdev: atmel_lcdfb: remove redundant initialization to variable ret

On 11/06/2019 at 19:09, Colin King wrote: > External E-Mail > > > From: Colin Ian King > > Currently variable ret is being initialized with -ENOENT however that > value is never read and ret is being re-assigned later on. Hence this > assignment is redundant and can be removed. > > Addresses-C

Re: [PATCH -next] video: fbdev: atmel_lcdfb: remove set but not used variable 'pdata'

On 03/04/2019 at 09:24, YueHaibing wrote: > External E-Mail > > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/video/fbdev/atmel_lcdfb.c: In function 'atmel_lcdfb_remove': > drivers/video/fbdev/atmel_lcdfb.c:1255:28: warning: > variable 'pdata' set but not used [-Wunused-but-set-

Re: [PATCH] video: fbdev: atmel_lcdfb: drop AVR and platform_data support

On 25/02/2019 at 22:25, Alexandre Belloni wrote: > Make the driver OF only as since AVR32 has been removed from the kernel, > there are only OF enabled platform using it. > > Signed-off-by: Alexandre Belloni In case it's needed: Acked-by: Nicolas Ferre > --- > drivers/video/fbdev/Kconfig

Re: [PATCH] video: fbdev: atmel_lcdfb: drop AVR and platform_data support

On 25/02/2019 at 22:25, Alexandre Belloni wrote: > Make the driver OF only as since AVR32 has been removed from the kernel, > there are only OF enabled platform using it. > > Signed-off-by: Alexandre Belloni It looks good to me: Acked-by: Nicolas Ferre Thanks Alexandre. Best regards, Nicola

Re: [PATCH 2/4] drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated

On 11/01/2019 at 14:29, Peter Rosin wrote: > On 2019-01-10 18:48, Boris Brezillon wrote: >> On Thu, 10 Jan 2019 15:10:39 + >> Peter Rosin wrote: >> >>> The destination crtc rectangle is independent of source plane rotation. >>> >>> Signed-off-by: Peter Rosin >>> --- >>> drivers/gpu/drm/atme

Re: [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues

On 10/01/2019 at 18:45, Boris Brezillon wrote: > On Thu, 10 Jan 2019 15:10:28 + > Peter Rosin wrote: > >> Hi! >> >> I found an unfortunate issue while recoding plane handling to use >> drm_atomic_helper_check_plane_state(). The driver rotates clockwise, >> which is not correct. I simply fixed