>Sender : Rob Clark
>Date : 2023-01-24 00:37 (GMT+9)
>Title : [PATCH] PM / devfreq: Fix build issues with devfreq disabled
>
>From: Rob Clark
>
>The existing no-op shims for when PM_DEVFREQ (or an individual governor)
>only do half the job. The governor specific config/tuning structs need
>to b
>On Tue, Jan 24, 2023 at 8:04 PM MyungJoo Ham wrote:
>>
>> >Sender : Rob Clark
>> >Date : 2023-01-24 00:37 (GMT+9)
>> >Title : [PATCH] PM / devfreq: Fix build issues with devfreq disabled
>> >
>> >From: Rob Clark
>> >
>> >
t; on one vop vblank time, so the other panel will flicker when do ddr
> frequency scaling.
>
> Signed-off-by: Lin Huang
> Reviewed-by: Chanwoo Choi
Acked-by: MyungJoo Ham
The code looks fine, but I've just found that I cannot merge this
code as I am not handling drivers/gpu/d
> base on dfi result, we do ddr frequency scaling, register
> dmc driver to devfreq framework, and use simple-ondemand
> policy.
>
> Signed-off-by: Lin Huang
> Reviewed-by: Chanwoo Choi
> ---
Thanks. LGTM.
Signed-off-by: MyungJoo Ham
Cheers,
MyungJoo.
> on rk3399 platform, there is dfi conroller can monitor
> ddr load, base on this result, we can do ddr freqency
> scaling.
>
> Signed-off-by: Lin Huang
> Acked-by: Chanwoo Choi
LGTM
Signed-off-by: MyungJoo Ham
t; +EXPORT_SYMBOL_GPL(dmc_register_notifier);
> +EXPORT_SYMBOL_GPL(dmc_unregister_notifier);
> +EXPORT_SYMBOL_GPL(rockchip_dmc_get);
> +EXPORT_SYMBOL_GPL(rockchip_dmc_put);
Do you really need to export all these device driver specific
functions? Looks like a design flaw here.
Cheers,
MyungJoo
--
MyungJoo Ham, Ph.D.
S/W R&D Center, Samsung Electronics
