[PATCH v2 0/2] CMRR patch fixes

2024-06-13 Thread Mitul Golani
Address following issues regarding CMRR 1. Describe target_rr_divider in struct drm_dp_as_sdp. 2. Use required macro to avoid overflow. -v2: - Remove extra line from commit message. Mitul Golani (2): drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp drm/i915/display: Update

[PATCH v2 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-13 Thread Mitul Golani
Describe newly added parameter target_rr_divider in struct drm_dp_as_sdp. -v2: Remove extra line from commit message.(Lucas) Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing AS SDP") Cc: Mitul Golani Cc: Arun R Murthy Cc: Suraj Kandpal Cc: Ankit Na

[PATCH v2 2/2] drm/i915/display: Update calculation to avoid overflow

2024-06-13 Thread Mitul Golani
Update calculation to avoid overflow. -v2: Remove extra line from commit message.(Lucas) Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Suraj Kandpal Cc: Jani Nikula Cc: Stephen Rothwell Signed-off-by: Mitul Golani R

[PATCH 0/2] CMRR patch fixes

2024-06-12 Thread Mitul Golani
Address following issues regarding CMRR 1. Describe target_rr_divider in struct drm_dp_as_sdp. 3. Use required macro to avoid overflow. Mitul Golani (2): drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp drm/i915/display: Update calculation to avoid overflow drivers/gpu/drm/i915

[PATCH 2/2] drm/i915/display: Update calculation to avoid overflow

2024-06-12 Thread Mitul Golani
Update calculation to avoid overflow. Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Suraj Kandpal Cc: Jani Nikula Cc: Stephen Rothwell Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i9

[PATCH 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-12 Thread Mitul Golani
Describe newly added parameter target_rr_divider in struct drm_dp_as_sdp. Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing AS SDP") Cc: Mitul Golani Cc: Arun R Murthy Cc: Suraj Kandpal Cc: Ankit Nautiyal Cc: Jani Nikula Cc: Stephen Rothwell Sig

[PATCH 3/3] drm/i915/display: Update calculation to avoid overflow

2024-06-12 Thread Mitul Golani
Update calculation to avoid overflow. Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Suraj Kandpal Cc: Jani Nikula Cc: Stephen Rothwell Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vrr.c | 9 ++

[PATCH 2/3] drm/i915/display: Send vrr vsync params whne vrr is enabled

2024-06-12 Thread Mitul Golani
Compute trans vrr vsync params only when either VRR or CMRR is enabled. Fixes: 5922f45329cd ("drm/i915/display: Compute vrr vsync params") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Suraj Kandpal Cc: Jani Nikula Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gp

[PATCH 0/3] CMRR patch fixes

2024-06-12 Thread Mitul Golani
Address following issues regarding CMRR 1. Describe target_rr_divider in struct drm_dp_as_sdp. 2. Compute vrr_vsync params when vrr.enable is set. 3. Use required macro to avoid overflow. Mitul Golani (3): drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp drm/i915/display: Send vrr

[PATCH 1/3] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-12 Thread Mitul Golani
Describe newly added parameter target_rr_divider in struct drm_dp_as_sdp. Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing AS SDP") Cc: Mitul Golani Cc: Arun R Murthy Cc: Suraj Kandpal Cc: Ankit Nautiyal Cc: Jani Nikula Cc: Stephen Rothwell Sig

[PATCH v13 7/9] drm/i915/display: Compute Adaptive sync SDP params

2024-06-05 Thread Mitul Golani
intel_dp_compute_as_sdp. --v4: - Use drm_mode_vrefresh instead of manual calculation (Ankit). Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v13 3/9] drm/i915: Define and compute Transcoder CMRR registers

2024-06-05 Thread Mitul Golani
name to intel_vrr_regs.h instead of reg.h (Jani) --v7: - Remove adding CMRR flag to vrr_ctl register during set_transcoder_timing, as it is already being done during intel_vrr_enable. (Ankit) Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v13 5/9] drm/dp: Add refresh rate divider to struct representing AS SDP

2024-06-05 Thread Mitul Golani
Add target_rr_divider to structure representing AS SDP. It is valid only in FAVT mode, sink device ignores the bit in AVT mode. --v2: - Update commit header and send patch to dri-devel. Signed-off-by: Mitul Golani Reviewed-by: Arun R Murthy --- include/drm/display/drm_dp_helper.h | 1 + 1

[PATCH v13 4/9] drm/i915: Update trans_vrr_ctl flag when cmrr is computed

2024-06-05 Thread Mitul Golani
-v4: - Removing RFC tag. --v5: - CMRR handling in co-existatnce of LRR and DRRS. --v7: - Rebase on top of AS SDP merge. --v8: - Remove cmrr_enabling/disabling and update commit message. (Ankit) --v9: - Revert removed line(Ankit). Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/

[PATCH v13 9/9] drm/i915: Compute CMRR and calculate vtotal

2024-06-05 Thread Mitul Golani
cmrr.enable.(Ankit) - Add TODO: for to address target refresh rate precision as future enhancement. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 1 + .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display

[PATCH v13 8/9] drm/i915/display: Compute vrr vsync params

2024-06-05 Thread Mitul Golani
) - Replace vrr.enable flag to cmrr.enable, mistakenly added. (Ankit) Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_vrr.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c

[PATCH v13 6/9] drm/i915/display: Add support for pack and unpack

2024-06-05 Thread Mitul Golani
Add support of pack and unpack for target_rr_divider. --v2: - Set Target Refresh Rate Divider bit when related AS SDP bit is set (Ankit). --v3: - target_rr_divider is bools so set accordingly (Ankit). Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v13 1/9] gpu/drm/i915: Update indentation for VRR registers and bits

2024-06-05 Thread Mitul Golani
Update the indentation for the VRR register definition and its bits, and fix checkpatch issues to ensure smooth movement of registers and bits. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/i915_reg.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v13 2/9] drm/i915: Separate VRR related register definitions

2024-06-05 Thread Mitul Golani
Move VRR related register definitions to a separate file called intel_vrr_regs.h. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vrr.c | 1 + drivers/gpu/drm/i915/display/intel_vrr_regs.h | 112 ++ drivers/gpu/drm/i915/i915_reg.h | 101

[PATCH v13 0/9] Implement CMRR Support

2024-06-05 Thread Mitul Golani
. -v12: - Add patch to fix check patch issues for VRR related registers in i915_reg.h then move them to intel_vrr_regs.h with separate patch. -v13: - Reverted unrelated patches while rebase. Mitul Golani (9): gpu/drm/i915: Update indentation for VRR registers and bits drm/i915: Separate VRR

[PATCH v12 9/9] drm/i915/display: Compute Adaptive sync SDP params

2024-06-05 Thread Mitul Golani
intel_dp_compute_as_sdp. --v4: - Use drm_mode_vrefresh instead of manual calculation (Ankit). Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v12 8/9] drm/i915/display: Add support for pack and unpack

2024-06-05 Thread Mitul Golani
Add support of pack and unpack for target_rr_divider. --v2: - Set Target Refresh Rate Divider bit when related AS SDP bit is set (Ankit). --v3: - target_rr_divider is bools so set accordingly (Ankit). Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v12 6/9] drm/i915: Update trans_vrr_ctl flag when cmrr is computed

2024-06-05 Thread Mitul Golani
-v4: - Removing RFC tag. --v5: - CMRR handling in co-existatnce of LRR and DRRS. --v7: - Rebase on top of AS SDP merge. --v8: - Remove cmrr_enabling/disabling and update commit message. (Ankit) --v9: - Revert removed line(Ankit). Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/

[PATCH v12 7/9] drm/dp: Add refresh rate divider to struct representing AS SDP

2024-06-05 Thread Mitul Golani
Add target_rr_divider to structure representing AS SDP. It is valid only in FAVT mode, sink device ignores the bit in AVT mode. --v2: - Update commit header and send patch to dri-devel. Signed-off-by: Mitul Golani Reviewed-by: Arun R Murthy --- include/drm/display/drm_dp_helper.h | 1 + 1

[PATCH v12 5/9] drm/i915: Define and compute Transcoder CMRR registers

2024-06-05 Thread Mitul Golani
name to intel_vrr_regs.h instead of reg.h (Jani) --v7: - Remove adding CMRR flag to vrr_ctl register during set_transcoder_timing, as it is already being done during intel_vrr_enable. (Ankit) Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v12 4/9] drm/i915: Separate VRR related register definitions

2024-06-05 Thread Mitul Golani
Move VRR related register definitions to a separate file called intel_vrr_regs.h. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vrr.c | 1 + drivers/gpu/drm/i915/display/intel_vrr_regs.h | 112 ++ drivers/gpu/drm/i915/i915_reg.h | 101

[PATCH v12 3/9] gpu/drm/i915: Update indentation for VRR registers and bits

2024-06-05 Thread Mitul Golani
Update the indentation for the VRR register definition and its bits, and fix checkpatch issues to ensure smooth movement of registers and bits. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/i915_reg.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v12 1/9] drm/i915: Protect CRC reg macro arguments for consistency

2024-06-05 Thread Mitul Golani
From: Ville Syrjälä It's probably a good idea to start protecting all macro arguments to avoid any cargo-cult mistakes when people go looking for examples of how to define these things. Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20240531115342.2763-8-ville

[PATCH v12 2/9] drm-tip: 2024y-06m-05d-09h-52m-50s UTC integration manifest

2024-06-05 Thread Mitul Golani
From: Ville Syrjälä --- integration-manifest | 28 1 file changed, 28 insertions(+) create mode 100644 integration-manifest diff --git a/integration-manifest b/integration-manifest new file mode 100644 index ..d840964a2208 --- /dev/null +++ b/integratio

[PATCH v12 0/9] Implement CMRR Support

2024-06-05 Thread Mitul Golani
. -v12: - Add patch to fix check patch issues for VRR related registers in i915_reg.h then move them to intel_vrr_regs.h with separate patch. - Use drm_mode_vrefresh instead of manual refresh rate calculation. Mitul Golani (7): gpu/drm/i915: Update indentation for VRR registers and bits drm/i915

[PATCH v11 6/8] drm/i915/display: Compute Adaptive sync SDP params

2024-06-02 Thread Mitul Golani
intel_dp_compute_as_sdp. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index ac81b172b1ec..be3b9ba943a5

[PATCH v11 8/8] drm/i915: Compute CMRR and calculate vtotal

2024-06-02 Thread Mitul Golani
cmrr.enable.(Ankit) - Add TODO: for to address target refresh rate precision as future enhancement. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 1 + .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display

[PATCH v11 7/8] drm/i915/display: Compute vrr vsync params

2024-06-02 Thread Mitul Golani
) - Replace vrr.enable flag to cmrr.enable, mistakenly added. (Ankit) Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_vrr.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c

[PATCH v11 5/8] drm/i915/display: Add support for pack and unpack

2024-06-02 Thread Mitul Golani
Add support of pack and unpack for target_rr_divider. --v2: - Set Target Refresh Rate Divider bit when related AS SDP bit is set (Ankit). --v3: - target_rr_divider is bools so set accordingly (Ankit). Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v11 4/8] drm/dp: Add refresh rate divider to struct representing AS SDP

2024-06-02 Thread Mitul Golani
Add target_rr_divider to structure representing AS SDP. It is valid only in FAVT mode, sink device ignores the bit in AVT mode. --v2: - Update commit header and send patch to dri-devel. Signed-off-by: Mitul Golani Reviewed-by: Arun R Murthy --- include/drm/display/drm_dp_helper.h | 1 + 1

[PATCH v11 3/8] drm/i915: Update trans_vrr_ctl flag when cmrr is computed

2024-06-02 Thread Mitul Golani
-v4: - Removing RFC tag. --v5: - CMRR handling in co-existatnce of LRR and DRRS. --v7: - Rebase on top of AS SDP merge. --v8: - Remove cmrr_enabling/disabling and update commit message. (Ankit) --v9: - Revert removed line(Ankit). Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/

[PATCH v11 2/8] drm/i915: Define and compute Transcoder CMRR registers

2024-06-02 Thread Mitul Golani
name to intel_vrr_regs.h instead of reg.h (Jani) --v7: - Remove adding CMRR flag to vrr_ctl register during set_transcoder_timing, as it is already being done during intel_vrr_enable. (Ankit) Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 23

[PATCH v11 0/8] Implement CMRR Support

2024-06-02 Thread Mitul Golani
. Mitul Golani (8): drm/i915: Separate VRR related register definitions drm/i915: Define and compute Transcoder CMRR registers drm/i915: Update trans_vrr_ctl flag when cmrr is computed drm/dp: Add refresh rate divider to struct representing AS SDP drm/i915/display: Add support for pack and

[PATCH v11 1/8] drm/i915: Separate VRR related register definitions

2024-06-02 Thread Mitul Golani
Move VRR related register definitions to a separate file called intel_vrr_regs.h. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vrr.c | 1 + drivers/gpu/drm/i915/display/intel_vrr_regs.h | 113 ++ drivers/gpu/drm/i915/i915_reg.h | 100

[PATCH v10 4/8] drm/i915: Compute CMRR and calculate vtotal

2024-05-29 Thread Mitul Golani
cmrr.enable are not mutually exclusive, handle accordingly (Ankit). - is_edp is not required inside is_cmrr_frac_required function (Ankit). - Add video_mode_required flag for future enhancement. - Correct cmrr_m/cmrr_n calculation. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display

[PATCH v10 8/8] drm/i915/display: Compute vrr vsync params

2024-05-29 Thread Mitul Golani
Compute vrr vsync params in case of FAVT as well instead of only to AVT mode of operation. --v2: - Remove redundant computation for vrr_vsync_start and vrr_vsync_end(Ankit). Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vrr.c | 17 + 1 file changed, 9

[PATCH v10 6/8] drm/i915/display: Add support for pack and unpack

2024-05-29 Thread Mitul Golani
Add support of pack and unpack for target_rr_divider. --v2: - Set Target Refresh Rate Divider bit when related AS SDP bit is set (Ankit). --v3: - target_rr_divider is bools so set accordingly (Ankit). Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 4 1 file

[PATCH v10 7/8] drm/i915/display: Compute Adaptive sync SDP params

2024-05-29 Thread Mitul Golani
Compute params for Adaptive Sync SDP when Fixed Average Vtotal mode is enabled. --v2: Since vrr.enable is set in case of cmrr also, handle accordingly(Ankit). Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 17 + 1 file changed, 13 insertions(+), 4

[PATCH v10 5/8] drm/dp: Add refresh rate divider to struct representing AS SDP

2024-05-29 Thread Mitul Golani
Add target_rr_divider to structure representing AS SDP. It is valid only in FAVT mode, sink device ignores the bit in AVT mode. --v2: - Update commit header and send patch to dri-devel. Signed-off-by: Mitul Golani Reviewed-by: Arun R Murthy --- include/drm/display/drm_dp_helper.h | 1 + 1

[PATCH v10 2/8] drm/i915: Define and compute Transcoder CMRR registers

2024-05-29 Thread Mitul Golani
name to intel_vrr_regs.h instead of reg.h (Jani) Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 23 ++- .../drm/i915/display/intel_display_types.h| 6 + drivers/gpu/drm/i915/display/intel_vrr.c | 22 ++ drivers/gpu/drm

[PATCH v10 3/8] drm/i915: Update trans_vrr_ctl flag when cmrr is computed

2024-05-29 Thread Mitul Golani
-v4: - Removing RFC tag. --v5: - CMRR handling in co-existatnce of LRR and DRRS. --v7: - Rebase on top of AS SDP merge. --v8: - Remove cmrr_enabling/disabling and update commit message. (Ankit) --v9: - Revert removed line(Ankit). Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vr

[PATCH v10 1/8] drm/i915: Separate VRR related register definitions

2024-05-29 Thread Mitul Golani
Move VRR related register definitions to a separate file called intel_vrr_regs.h. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vrr.c | 1 + drivers/gpu/drm/i915/display/intel_vrr_regs.h | 117 ++ drivers/gpu/drm/i915/i915_reg.h | 100

[PATCH v10 0/8] Implement CMRR Support

2024-05-29 Thread Mitul Golani
accordingly. - is_edp is not required inside is_cmrr_frac_required function. - Add video_mode_required flag for future enhancement. - Correct cmrr_m/cmrr_n calculation. - target_rr_divider is bools so handle accordingly. Mitul Golani (8): drm/i915: Separate VRR related register definitions drm

[PATCH] drm/dp: correct struct member name in documentation

2024-04-04 Thread Mitul Golani
Correct struct member name to 'mode' instead of 'operation mode' in 'drm_dp_as_sdp' structure description. Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Jani Nikula Signed-off-by: Mitul Golani ---

[PATCH v18 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-12 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. --v4: - Use VRR_SYNC_START/END macros correctly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers

[PATCH v17 9/9] drm/i915/display: Read/Write Adaptive Sync SDP

2024-03-11 Thread Mitul Golani
Add read/write calls for Adaptive Sync SDP. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b

[PATCH v17 6/9] drm/i915/display: Compute AS SDP parameters

2024-03-11 Thread Mitul Golani
conn_state from intel_dp_compute_as_sdp, as not used. - Remove fullstop in subject line. --v9: - Add vrr.enable instead of is_in_vrr_range. --v10: - remove vrefresh and connector, as they are no longer required. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v17 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-11 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. --v4: - Use VRR_SYNC_START/END macros correctly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers

[PATCH v17 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-03-11 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2

[PATCH v17 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-03-11 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file chan

[PATCH v17 3/9] drm/i915/display: Add crtc state dump for Adaptive Sync SDP

2024-03-11 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files

[PATCH v17 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-03-11 Thread Mitul Golani
sdp->target_rr & 0xFF. - Shift by 8 instead of 32, and drop casting to u64. - Remove changes which are does not belong to this patch. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c

[PATCH v17 2/9] drm: Add Adaptive Sync SDP logging

2024-03-11 Thread Mitul Golani
anges to commit message. --v6: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. --v7: - Add drm/i915/display in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_hel

[PATCH v17 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-03-11 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 25

[PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-11 Thread Mitul Golani
longer required. - Use VRR_SYNC_START/END macros correctly. - Update commit message for Patch#9 --v17: - Relocate vrr vsync params. Signed-off-by: Mitul Golani Mitul Golani (9): drm/dp: Add support to indicate if sink supports AS SDP drm: Add Adaptive Sync SDP logging drm/i915/display: Add crtc s

[PATCH v16 6/9] drm/i915/display: Compute AS SDP parameters

2024-03-06 Thread Mitul Golani
conn_state from intel_dp_compute_as_sdp, as not used. - Remove fullstop in subject line. --v9: - Add vrr.enable instead of is_in_vrr_range. --v10: - remove vrefresh and connector, as they are no longer required. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v16 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-06 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. --v4: - Use VRR_SYNC_START/END macros correctly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers

[PATCH v16 9/9] drm/i915/display: Read/Write Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Add read/write calls for Adaptive Sync SDP. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display

[PATCH v16 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file chan

[PATCH v16 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
sdp->target_rr & 0xFF. - Shift by 8 instead of 32, and drop casting to u64. - Remove changes which are does not belong to this patch. Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 92 +++ drive

[PATCH v16 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-03-06 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2

[PATCH v16 3/9] drm/i915/display: Add crtc state dump for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files

[PATCH v16 2/9] drm: Add Adaptive Sync SDP logging

2024-03-06 Thread Mitul Golani
anges to commit message. --v6: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. --v7: - Add drm/i915/display in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_hel

[PATCH v16 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-03-06 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 25

[PATCH v16 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-06 Thread Mitul Golani
longer required. - Use VRR_SYNC_START/END macros correctly. - Update commit message for Patch#9 Signed-off-by: Mitul Golani Mitul Golani (9): drm/dp: Add support to indicate if sink supports AS SDP drm: Add Adaptive Sync SDP logging drm/i915/display: Add crtc state dump for Adaptive Sync SDP drm/i

[PATCH v15 9/9] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-03-01 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH v15 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-01 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 29

[PATCH v15 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-03-01 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --gi

[PATCH v15 6/9] drm/i915/display: Compute AS SDP parameters

2024-03-01 Thread Mitul Golani
conn_state from intel_dp_compute_as_sdp, as not used. - Remove fullstop in subject line. --v9: - Add vrr.enable instead of is_in_vrr_range. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 26 + 1 file changed, 26 insertions

[PATCH v15 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-03-01 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 9 insertions

[PATCH v15 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-03-01 Thread Mitul Golani
if AS_SDP bit is set in crtc_state->infoframes.enable. If not return. - Check for HAS_AS_SDP() before setting VIDEO_DIP_ENABLE_AS_ADL mask. --v6: - Rename intel_read_dp_infoframe_as_sdp to intel_read_dp_as_sdp. - Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_devic

[PATCH v15 3/9] drm: Add crtc state dump for Adaptive Sync SDP

2024-03-01 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files changed, 14 insertions

[PATCH v15 2/9] drm: Add Adaptive Sync SDP logging

2024-03-01 Thread Mitul Golani
anges to commit message. --v6: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 12 ++ include/drm/display/drm_dp.h| 10

[PATCH v15 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-03-01 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display

[PATCH v15 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-01 Thread Mitul Golani
compute config. Signed-off-by: Mitul Golani Mitul Golani (9): drm/dp: Add support to indicate if sink supports AS SDP drm: Add Adaptive Sync SDP logging drm: Add crtc state dump for Adaptive Sync SDP drm/i915/dp: Add Read/Write support for Adaptive Sync SDP drm/i915/dp: Add wrapper fu

[PATCH v14 6/9] drm/i915/display: Compute AS SDP parameters

2024-02-29 Thread Mitul Golani
conn_state from intel_dp_compute_as_sdp, as not used. - Remove fullstop in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 26 + 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915

[PATCH v14 8/9] drm/i915/display: Compute vrr_vsync params

2024-02-29 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 29

[PATCH v14 9/9] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-29 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH v14 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
if AS_SDP bit is set in crtc_state->infoframes.enable. If not return. - Check for HAS_AS_SDP() before setting VIDEO_DIP_ENABLE_AS_ADL mask. Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c |

[PATCH v14 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --gi

[PATCH v14 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-02-29 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 9 insertions

[PATCH v14 3/9] drm: Add crtc state dump for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files changed, 14 insertions

[PATCH v14 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-02-29 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display

[PATCH v14 2/9] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Mitul Golani
anges to commit message. --v6: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 12 ++ include/drm/display/drm_dp.h| 10

[PATCH v14 0/9] Enable Adaptive Sync SDP Support for DP

2024-02-29 Thread Mitul Golani
rtc_state->infoframes.enable, to add on correct place holder. --v14: Mistakenly dropped first patch, adding back. Signed-off-by: Mitul Golani i Mitul Golani (9): drm/dp: Add support to indicate if sink supports AS SDP drm: Add Adaptive Sync SDP logging drm: Add crtc state dump for Adaptive Sy

[PATCH v13 6/8] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --gi

[PATCH v13 7/8] drm/i915/display: Compute vrr_vsync params

2024-02-29 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 29

[PATCH v13 8/8] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-29 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH v13 4/8] drm/i915/dp: Add wrapper function to check AS SDP

2024-02-29 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 9 insertions

[PATCH v13 5/8] drm/i915/display: Compute AS SDP parameters

2024-02-29 Thread Mitul Golani
conn_state from intel_dp_compute_as_sdp, as not used. - Remove fullstop in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 26 + 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915

[PATCH v13 3/8] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
if AS_SDP bit is set in crtc_state->infoframes.enable. If not return. - Check for HAS_AS_SDP() before setting VIDEO_DIP_ENABLE_AS_ADL mask. Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c |

[PATCH v13 2/8] drm: Add crtc state dump for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. --v2: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. Signed-off-by: Mitul Golani --- .../gpu/drm/i915/display

[PATCH v13 1/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Mitul Golani
to commit message. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 12 ++ include/drm/display/drm_dp.h| 10 + include/drm/display/drm_dp_helper.h | 29 + 3 files changed, 51 insertions(+) diff --git a/drivers/gpu/

[PATCH v13 0/8] Enable Adaptive Sync SDP Support for DP

2024-02-29 Thread Mitul Golani
rtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani Mitul Golani (8): drm: Add Adaptive Sync SDP logging drm: Add crtc state dump for Adaptive Sync SDP drm/i915/dp: Add Read/Write support for Adaptive Sync SDP drm/i915/dp: Add wrapper function to check

[PATCH v12 8/8] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-28 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 drivers/gpu/drm/i915/display/intel_dp.c | 4 drivers/gpu/drm/i915/display

  1   2   >